[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

courbet updated this revision to Diff 188318. courbet added a comment. - add more tests - Traverse using decls. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58606/new/ https://reviews.llvm.org/D58606 Files: clang-tidy/bugprone/StringIntegerAssig

[PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

kadircet added a comment. LG Do we have any metrics regarding change in completion quality? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58448/new/ https://reviews.llvm.org/D58448 ___ cfe-commits mail

[PATCH] D58665: [analyzer] Handle comparison between non-default AS symbol and constant

dstenb created this revision. dstenb added reviewers: NoQ, zaks.anna, george.karpenkov. Herald added subscribers: cfe-commits, Charusso, jdoerfert, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. When comparing a sym

[PATCH] D58504: [OpenCL][8.0.0 Release] Notes for OpenCL

hans added a comment. Many thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58504/new/ https://reviews.llvm.org/D58504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

martong added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:1344 + + EXPECT_EQ(FromChooseExpr->isConditionTrue(), ToChooseExpr->isConditionTrue()); +} To compensate the skipping of the template test, perhaps we should have another expe

[PATCH] D57883: [clang-tidy] refactor ExceptionAnalyzer further to give ternary answer

JonasToth marked an inline comment as done. JonasToth added inline comments. Comment at: clang-tidy/utils/ExceptionAnalyzer.h:112 +/// throw, if it's unknown or if it won't throw. +enum State Behaviour : 2; + bjope wrote: > (post-commit comments) > > I'v

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

miyuki added inline comments. Comment at: llvm/lib/IR/Value.cpp:651 if (auto *GO = dyn_cast(this)) { // Don't make any assumptions about function pointer alignment. Some // targets use the LSBs to store additional information. This comment needs to b

Re: [PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

Unfortunately, the evaluation tool I use only works on compilable code, so it doesn't capture the unsolved specifier case in this patch. I didn't try to collect the metrics because I think this is more of a bug fix than quality improvement. On Tue, Feb 26, 2019, 10:25 Kadir Cetinkaya via Phabricat

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k-abi.c clang/test/CodeGen/target-dat

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

ilya-biryukov added inline comments. Comment at: include/clang/Index/IndexSymbol.h:75 UsingValue, + UsingDeclaration, }; We don't seem to use the subkind anywhere. Let's remove it. Comment at: unittests/Index/IndexTests.cpp:253 + tooling:

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

michaelplatings updated this revision to Diff 188325. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 Files: clang/lib/Basic/Targets/ARM.cpp clang/test/CodeGen/armv7k-abi.c clang/test/CodeGen/target-dat

Re: [PATCH] D58448: [clangd] Improve global code completion when scope specifier is unresolved.

Slightly offtopic. It would be nice to add a way to collect quality during actual completion sessions, rather than simulated ones. I'm thinking about clients sending a message to the server mentioning the completion item user ended up selecting in a completion list (would require an LSP extension)

Re: r354721 - Remove sanitizer context workaround no longer necessary

Merged to release_80 in r354858. On Sat, Feb 23, 2019 at 7:18 AM Brad Smith via cfe-commits wrote: > > Author: brad > Date: Fri Feb 22 22:19:28 2019 > New Revision: 354721 > > URL: http://llvm.org/viewvc/llvm-project?rev=354721&view=rev > Log: > Remove sanitizer context workaround no longer neces

Re: r354723 - Remove OpenBSD case for old system libstdc++ header path as OpenBSD

Merged to release_80 in r354859. On Sat, Feb 23, 2019 at 8:20 AM Brad Smith via cfe-commits wrote: > > Author: brad > Date: Fri Feb 22 23:21:19 2019 > New Revision: 354723 > > URL: http://llvm.org/viewvc/llvm-project?rev=354723&view=rev > Log: > Remove OpenBSD case for old system libstdc++ header

r354861 - CodeGen: Explicitly initialize structure padding in the -ftrivial-auto-var-init mode

Author: glider Date: Tue Feb 26 02:46:21 2019 New Revision: 354861 URL: http://llvm.org/viewvc/llvm-project?rev=354861&view=rev Log: CodeGen: Explicitly initialize structure padding in the -ftrivial-auto-var-init mode When generating initializers for local structures in the -ftrivial-auto-var-in

r354864 - [CodeComplete] Propagate preferred type for function arguments in more cases

Author: ibiryukov Date: Tue Feb 26 03:01:50 2019 New Revision: 354864 URL: http://llvm.org/viewvc/llvm-project?rev=354864&view=rev Log: [CodeComplete] Propagate preferred type for function arguments in more cases Summary: See the added test for some new cases. This change also removes special cod

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet updated this revision to Diff 188327. kadircet added a comment. Herald added a project: clang. - Revert YCM related parts Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56718/new/ https://reviews.llvm.org/D56718 Files: docs/clangd.rst I

[PATCH] D58541: [CodeComplete] Propagate preferred type for function arguments in more cases

This revision was automatically updated to reflect the committed changes. Closed by commit rL354864: [CodeComplete] Propagate preferred type for function arguments in more cases (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[clang-tools-extra] r354865 - [clangd] Update docs to mention YCM integration and new LSP features

Author: kadircet Date: Tue Feb 26 03:08:04 2019 New Revision: 354865 URL: http://llvm.org/viewvc/llvm-project?rev=354865&view=rev Log: [clangd] Update docs to mention YCM integration and new LSP features Reviewers: gribozavr Reviewed By: gribozavr Subscribers: ilya-biryukov, ioeric, MaskRay, jk

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

kadircet updated this revision to Diff 188329. kadircet added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56718/new/ https://reviews.llvm.org/D56718 Files: docs/clangd/index.rst Index: docs/clangd/index.rst ===

[PATCH] D56718: [clangd] Update docs to mention YCM integration and new LSP features

This revision was automatically updated to reflect the committed changes. Closed by commit rL354865: [clangd] Update docs to mention YCM integration and new LSP features (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd created this revision. sidorovd added reviewers: Anastasia, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the code: #pragma OPENCL EXTENSION cl_intel_planar_yuv : begin // some declarations #pragma OPENCL EXTENSION cl_intel_planar_yuv : end

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd updated this revision to Diff 188338. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58666/new/ https://reviews.llvm.org/D58666 Files: lib/Headers/opencl-c.h test/Headers/opencl-c-header.cl test/SemaOpenCL/extension-begin.cl Index: test/SemaOpenCL/extension-begin.cl =

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

Anastasia added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Can we also test that macro `my_ext` is not defined here but defined above? It seems we are not testing anything like thi

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58569/new/ https://reviews.llvm.org/D58569

[PATCH] D58634: [PR40778] Generate address space conversion when binding reference to a temporary value in different address space

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: lib/CodeGen/CGCall.cpp:4067 + IRFuncTy->getParamType(FirstIRArg)->isPointerTy()) +V = Builder.CreatePointerBitCastOrAddrSpaceCast( +V, IRFuncTy->getPa

[PATCH] D58658: [OpenCL] Fix assertion due to blocks

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58658/new/ https://reviews.llvm.org/D58658 ___ cfe-commits mailing lis

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

riccibruno accepted this revision. riccibruno added a comment. This revision is now accepted and ready to land. I think this looks good now. Thanks ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 _

[PATCH] D58668: [ASTImporter] Fix redecl failures of FunctionTemplateSpec

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of function template specializations are not handled well curre

[PATCH] D58666: [OpenCL] Undefine cl_intel_planar_yuv extension

sidorovd marked an inline comment as done. sidorovd added inline comments. Comment at: test/SemaOpenCL/extension-begin.cl:26 + #ifndef IMPLICIT_INCLUDE #include "extension-begin.h" Anastasia wrote: > Can we also test that macro `my_ext` is not defined here but

r354873 - [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

Author: pgousseau Date: Tue Feb 26 05:30:14 2019 New Revision: 354873 URL: http://llvm.org/viewvc/llvm-project?rev=354873&view=rev Log: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC. enum SanitizerOrdinal has reached maximum capacity, this change

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. In D57914#1410387 , @riccibruno wrote: > I think this looks good now. Thanks ! Pushed at r354873, thanks for the help! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 _

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354873: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different… (authored by pgousseau, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5791

[PATCH] D58556: [LibTooling] Add "smart" retrieval of AST-node source to FixIt library

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/FixIt.h:60 +// future to include more associated text (like comments). +CharSourceRange getSourceRangeAuto(const Stmt &S, ASTContext &Context); + ilya

r354875 - revert r354873 as this breaks lldb builds.

Author: pgousseau Date: Tue Feb 26 05:50:29 2019 New Revision: 354875 URL: http://llvm.org/viewvc/llvm-project?rev=354875&view=rev Log: revert r354873 as this breaks lldb builds. Modified: cfe/trunk/include/clang/Basic/Attr.td cfe/trunk/include/clang/Basic/Sanitizers.def cfe/trunk/inc

[PATCH] D57914: [Driver] Allow enum SanitizerOrdinal to represent more than 64 different sanitizer checks, NFC.

pgousseau added a comment. reverted at r354875 at this break lldb build. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57914/new/ https://reviews.llvm.org/D57914 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

martong created this revision. martong added reviewers: a_sidorin, shafik. Herald added subscribers: cfe-commits, jdoerfert, gamesh411, Szelethus, dkrupp, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a project: clang. Redecl chains of class template specializations are not handled w

r354878 - [clang][Index] Visit UsingDecls and generate USRs for them

Author: kadircet Date: Tue Feb 26 06:23:12 2019 New Revision: 354878 URL: http://llvm.org/viewvc/llvm-project?rev=354878&view=rev Log: [clang][Index] Visit UsingDecls and generate USRs for them Summary: Add indexing of UsingDecl itself. Also enable generation of USRs for UsingDecls, using the qua

[clang-tools-extra] r354879 - [clangd] Index UsingDecls

Author: kadircet Date: Tue Feb 26 06:23:47 2019 New Revision: 354879 URL: http://llvm.org/viewvc/llvm-project?rev=354879&view=rev Log: [clangd] Index UsingDecls Summary: D58340 enables indexing of USRs, this makes sure test in clangd are aligned with the change Reviewers: hokein Subscribers: il

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

This revision was automatically updated to reflect the committed changes. Closed by commit rL354878: [clang][Index] Visit UsingDecls and generate USRs for them (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHAN

[PATCH] D58340: [clang][Index] Visit UsingDecls and generate USRs for them

kadircet updated this revision to Diff 188361. kadircet marked an inline comment as done. kadircet added a comment. - Revert SymbolSubKind change - Add test to check for SymbolKind Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58340/new/ https://reviews.llvm.org/

[PATCH] D58341: [clangd] Index UsingDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE354879: [clangd] Index UsingDecls (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58341?vs=188170&id=188363#toc Repository: rCTE Clang Tools Extra CHANGES

[PATCH] D57765: [ARM] Add Cortex-M35P Support

LukeCheeseman updated this revision to Diff 188364. LukeCheeseman added a comment. - Test cpus Cortex-M33 and Cortex-M35P seperately CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57765/new/ https://reviews.llvm.org/D57765 Files: test/Driver/arm-cortex-cpus.c Index: test/Driver/arm-

r354880 - [clang-format] SpaceBeforeParens for lambda expressions

Author: anng Date: Tue Feb 26 06:34:49 2019 New Revision: 354880 URL: http://llvm.org/viewvc/llvm-project?rev=354880&view=rev Log: [clang-format] SpaceBeforeParens for lambda expressions Add support for lambda expressions to the SpaceBeforeParens formatting option. Differential Revision: https:/

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

MyDeveloperDay added inline comments. Comment at: clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:79 +return; + } + elide {} on small if statements Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188367. courbet marked an inline comment as done. courbet added a comment. - cosmetics Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy/bugprone/Strin

r354885 - [libclang] Avoid crashing when getting layout info of an undeduced type.

Author: emilio Date: Tue Feb 26 07:04:18 2019 New Revision: 354885 URL: http://llvm.org/viewvc/llvm-project?rev=354885&view=rev Log: [libclang] Avoid crashing when getting layout info of an undeduced type. When the type is not deducible, return an error instead of crashing. This fixes https://bu

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

This revision was automatically updated to reflect the committed changes. emilio marked an inline comment as done. Closed by commit rC354885: [libclang] Avoid crashing when getting layout info of an undeduced type. (authored by emilio, committed by ). Changed prior to commit: https://reviews.ll

[PATCH] D58569: [libclang] Avoid crashing when getting layout info of an undeduced type.

emilio added a comment. Thank you for all the reviews! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58569/new/ https://reviews.llvm.org/D58569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D56943: [clang-format][NFC] Allow getLLVMStyle() to take a language

MyDeveloperDay added inline comments. Herald added a subscriber: jdoerfert. Comment at: clang/lib/Format/ContinuationIndenter.cpp:193 RawStringFormat.Language, &PredefinedStyle)) { -PredefinedStyle = getLLVMStyle(); +PredefinedStyle

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: lib/Sema/SemaExpr.cpp:11292 +} + +/// Argument's value might be modified, so update the info. riccibruno wrote: > Hmm, I don't think that this will work. Suppose that you have

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright updated this revision to Diff 188372. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58137/new/ https://reviews.llvm.org/D58137 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/abseil/CMakeLists.txt clang-tidy/abseil/DurationRewriter.cpp clang-tidy/abseil/DurationR

[PATCH] D56411: [CUDA][HIP][Sema] Fix template kernel with function as template parameter

yaxunl added a comment. In D56411#1410153 , @rjmccall wrote: > In D56411#1406212 , @yaxunl wrote: > > > I would like to fix the validation issue only and leave the overload > > resolution issue for future. > > > As

[PATCH] D58137: [clang-tidy] Add the abseil-time-subtraction check

hwright marked an inline comment as done. hwright added inline comments. Comment at: clang-tidy/abseil/TimeSubtractionCheck.cpp:97 +void TimeSubtractionCheck::check(const MatchFinder::MatchResult &Result) { + const auto *BinOp = Result.Nodes.getNodeAs("binop"); + std::string in

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

anton-afanasyev created this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, arphaman, mgrang, hiraditya, mgorny, mehdi_amini. Herald added projects: clang, LLVM. This is the first part of time tracing system, I have splitted them cause this part is mostly written by Ar

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong updated this revision to Diff 188379. martong marked 4 inline comments as done. martong added a comment. - getDefinition -> getTemplateDefinition - Remove comments for braces, added FIXME Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58494/new/ https://re

r354893 - [OpenCL] Fix assertion due to blocks

Author: yaxunl Date: Tue Feb 26 08:20:41 2019 New Revision: 354893 URL: http://llvm.org/viewvc/llvm-project?rev=354893&view=rev Log: [OpenCL] Fix assertion due to blocks A recent change caused assertion in CodeGenFunction::EmitBlockCallExpr when a block is called. There is code Func = CGM.ge

[PATCH] D58658: [OpenCL] Fix assertion due to blocks

This revision was automatically updated to reflect the committed changes. Closed by commit rC354893: [OpenCL] Fix assertion due to blocks (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58658/new/ h

[PATCH] D58494: [ASTImporter] Handle redecl chain of FunctionTemplateDecls

martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:4966 // it has any definition in the redecl chain. -static ClassTemplateDecl *getDefinition(ClassTemplateDecl *D) { - CXXRecordDecl *ToTemplatedDef = D->getTemplatedDecl()->getDefinition(); +template static aut

[PATCH] D57716: [CUDA][HIP] Check calling convention based on function target

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57716/new/ https://reviews.llvm.org/D57716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D58343: Enablement for AMD znver2 architecture - skeleton patch

This revision was automatically updated to reflect the committed changes. Closed by commit rL354897: [X86] AMD znver2 enablement (authored by ggopala, committed by ). Changed prior to commit: https://reviews.llvm.org/D58343?vs=187389&id=188391#toc Repository: rL LLVM CHANGES SINCE LAST ACTI

[PATCH] D58344: Enablement for AMD znver2 architecture - skeleton

This revision was automatically updated to reflect the committed changes. Closed by commit rL354899: [X86] AMD znver2 enablement (authored by ggopala, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D58344?

[PATCH] D58683: [clangd] Set thread priority on Windows

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, gribozavr. Herald added subscribers: arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58683 Files: clang-tools-extra/clangd/Threading.

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder updated this revision to Diff 188397. tmroeder added a comment. Added the other expectation, as suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58663/new/ https://reviews.llvm.org/D58663 Files: clang/docs/LibASTMatchersReferenc

[PATCH] D57906: [CTU] Do not allow different CPP dialects in CTU

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/CrossTU/CrossTranslationUnit.cpp:255 + // in the other unit it has none. + if (LangTo.CPlusPlus11 != LangFrom.CPlusPlus11 || + LangTo.CPlusPlus14 != LangFrom.CPlusPlus14 || ---

[PATCH] D58623: [AMDGPU] Allow using integral non-type template parameters

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58623/new/ https://reviews.llvm.org/D58623 __

[clang-tools-extra] r354903 - [clang-tidy] undo bitfields in ExceptionAnalyzer

Author: jonastoth Date: Tue Feb 26 10:15:17 2019 New Revision: 354903 URL: http://llvm.org/viewvc/llvm-project?rev=354903&view=rev Log: [clang-tidy] undo bitfields in ExceptionAnalyzer Scoped enums do induce some problems with some MSVC and GCC versions if used as bitfields. Therefor this is deac

[PATCH] D58091: Customize warnings for missing built-in type

jdoerfert updated this revision to Diff 188411. jdoerfert marked an inline comment as done. jdoerfert added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58091/new/ https://reviews.llvm.org/D58091 Files: clang/include/clang/B

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra added a comment. There's a new quirk we've ran into after this patch landed. Consider this code: int foo() { int prev; __asm__ __volatile__("whatever" : "=a" (prev)::); return prev; } When we compile for device, asm constraint is not valid for NVPTX, we emit delayed diag and

r354909 - [AMDGPU] Allow using integral non-type template parameters

Author: hliao Date: Tue Feb 26 10:49:36 2019 New Revision: 354909 URL: http://llvm.org/viewvc/llvm-project?rev=354909&view=rev Log: [AMDGPU] Allow using integral non-type template parameters Summary: - Allow using integral non-type template parameters in the following attributes __attribute_

[PATCH] D58623: [AMDGPU] Allow using integral non-type template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rC354909: [AMDGPU] Allow using integral non-type template parameters (authored by hliao, committed by ). Changed prior to commit: https://reviews.llvm.org/D58623?vs=188172&id=188416#toc Repository: rC

[PATCH] D58665: [analyzer] Handle comparison between non-default AS symbol and constant

NoQ added a comment. Hi, thanks!, i think this is correct. As in, `LocAsInteger` was clearly a mistake to begin with, but this change shouldn't make it worse. You should be able to get away with not supporting comparisons between regions without symbolic base [as integers] and concrete integers

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev added a comment. In D58463#1410900 , @tra wrote: > There's a new quirk we've ran into after this patch landed. Consider this > code: > > int foo() { > int prev; > __asm__ __volatile__("mov %0, 0" : "=a" (prev)::); > return prev; >

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 18 inline comments as done. jkorous added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:116 + + DirectoryWatcher::EventKind K = DirectoryWatcher::EventKind::Added; + if (ievt->mask & IN_MODIFY) { jko

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

tmroeder added a comment. I'm going to submit this patch again, since that I believe I understand the problem, and I have tested this version on Win10 with the latest MSVC (other than the expectation that I just added, but that test wasn't a problem on the Windows builders, and the new expectat

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 188423. jkorous marked 4 inline comments as done. jkorous added a comment. - Use RetryAfterSignal - Propagate events from inotify directly - Remove ModTime - Add assert for unknown event kinds CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/

r354915 - [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test.

Author: ctopper Date: Tue Feb 26 11:20:04 2019 New Revision: 354915 URL: http://llvm.org/viewvc/llvm-project?rev=354915&view=rev Log: [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test. These are supported by at least libgcc trunk so we can include them now. Modified: cfe/trun

r354916 - [ASTImporter] Add support for importing ChooseExpr AST nodes.

Author: tmroeder Date: Tue Feb 26 11:26:41 2019 New Revision: 354916 URL: http://llvm.org/viewvc/llvm-project?rev=354916&view=rev Log: [ASTImporter] Add support for importing ChooseExpr AST nodes. Summary: This allows ASTs to be merged when they contain ChooseExpr (the GNU __builtin_choose_expr c

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL354916: [ASTImporter] Add support for importing ChooseExpr AST nodes. (authored by tmroeder, committed by ). Herald added

Re: r354915 - [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test.

Doesn't look like this patch added 'znver2'? On Tue, Feb 26, 2019 at 10:20 PM Craig Topper via cfe-commits wrote: > > Author: ctopper > Date: Tue Feb 26 11:20:04 2019 > New Revision: 354915 > > URL: http://llvm.org/viewvc/llvm-project?rev=354915&view=rev > Log: > [X86] Add 'znver2' and 'cascadela

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

rnk created this revision. rnk added a reviewer: vsk. Herald added a subscriber: jdoerfert. Herald added a project: clang. The MS C++ ABI has no constructor variants, but it has destructor variants, so we should move the deleting destructor variant check outside the check for "does the ABI have co

RE: r354915 - [X86] Add 'znver2' and 'cascadelake' to the __builtin_cpu_is test.

You're right. It was already there after Ganesh's patch this morning. I hadn't updated my clang tree so I thought it was missing. Sorry. -Original Message- From: Roman Lebedev [mailto:lebedev...@gmail.com] Sent: Tuesday, February 26, 2019 11:29 AM To: Topper, Craig Cc: cfe-commits@lists

[PATCH] D58663: [ASTImporter] Add support for importing ChooseExpr AST nodes.

rnk added a comment. Sounds good, thanks for debugging this. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58663/new/ https://reviews.llvm.org/D58663 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D57628: [index] Improve indexing support for MSPropertyDecl.

vsapsai added a comment. Herald added a subscriber: jdoerfert. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57628/new/ https://reviews.llvm.org/D57628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra added a comment. > Hi Artem, I think we can just delay emission of this warning to solve this > problem. I'm not sure we can always tell whether the warning is real or if it's the consequence of failing to parse inline asm. E.g.: namespace { __host__ __device__ a() { int prev;

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

phosek added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58374: [Clang][NewPM] Don't bail out if the target machine is empty

phosek added a comment. Ping? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58374/new/ https://reviews.llvm.org/D58374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

vsk added inline comments. Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:28 +// FIXME: Should we emit coverage info for deleting dtors? They do contain +// conditional branches. LLVM IR PGO will insrument them just fine, though. + Probably not. IIUC th

[PATCH] D56900: [Fixed Point Arithmetic] Fixed Point and Integer Conversions

leonardchan added a comment. @rjmccall @ebevhan @bjope *ping* any other comments on this patch? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56900/new/ https://reviews.llvm.org/D56900 ___ cfe-commits mailing list cf

[PATCH] D57590: [ASTImporter] Improve import of FileID.

efriedma added a comment. I don't know anything about this particular patch, but you aren't allowed to set deadlines like that; the patch review process requires that the patch is actually reviewed. If you aren't getting a response, ask on cfe-dev. Repository: rC Clang CHANGES SINCE LAST A

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev added a comment. In D58463#1411039 , @tra wrote: > > Hi Artem, I think we can just delay emission of this warning to solve this > > problem. > > I'm not sure we can always tell whether the warning is real or if it's the > consequence of failing t

[PATCH] D58375: [Clang][NewPM] Disable tests that are broken under new PM

efriedma added a comment. I thought the plan was to fix whatever issue was causing the -O0 tests to fail, then rebase on top of that? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58375/new/ https://reviews.llvm.org/D58375

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

rnk added inline comments. Comment at: clang/test/Profile/cxx-abc-deleting-dtor.cpp:28 +// FIXME: Should we emit coverage info for deleting dtors? They do contain +// conditional branches. LLVM IR PGO will insrument them just fine, though. + vsk wrote: > Probably

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

rnk updated this revision to Diff 188434. rnk marked 3 inline comments as done. rnk added a comment. - fix CHECK-NOT - FIXME that isn't needed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58691/new/ https://reviews.llvm.org/D58691 Files: clang/

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

tra added a comment. >> E.g.: >> >> namespace { >> __host__ __device__ a() { >> int prev; >> __asm__ __volatile__("mov %0, 0" : "=a" (prev)::); >> return prev; >> } >> >> __host__ __device__ b() { >> int prev; >> return prev; >> } >> >> } //namespace >> >>

[PATCH] D58463: [CUDA]Delayed diagnostics for the asm instructions.

ABataev added a comment. In D58463#1411086 , @tra wrote: > >> E.g.: > >> > >> namespace { > >> __host__ __device__ a() { > >> int prev; > >> __asm__ __volatile__("mov %0, 0" : "=a" (prev)::); > >> return prev; > >> } > >> > >> __hos

[PATCH] D58691: [MS] Don't emit coverage for deleting dtors

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks! Lgtm. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58691/new/ https://reviews.llvm.org/D58691

[PATCH] D57590: [ASTImporter] Improve import of FileID.

martong added a comment. In D57590#1411055 , @efriedma wrote: > I don't know anything about this particular patch, but you aren't allowed to > set deadlines like that; the patch review process requires that the patch is > actually reviewed. If you aren'

[PATCH] D54176: [PGO] clang part of change for context-sensitive PGO.

davidxl added a comment. Please add changes to option documentation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54176/new/ https://reviews.llvm.org/D54176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

r354924 - [MS] Don't emit coverage for deleting dtors

Author: rnk Date: Tue Feb 26 12:42:52 2019 New Revision: 354924 URL: http://llvm.org/viewvc/llvm-project?rev=354924&view=rev Log: [MS] Don't emit coverage for deleting dtors Summary: The MS C++ ABI has no constructor variants, but it has destructor variants, so we should move the deleting destruc

  1   2   >