r355666 - [Clang] Include the test directory ommited in r355665

Author: phosek Date: Thu Mar 7 22:16:32 2019 New Revision: 355666 URL: http://llvm.org/viewvc/llvm-project?rev=355666=rev Log: [Clang] Include the test directory ommited in r355665 This was omitted in r355655 causing the test to fail. Added:

[PATCH] D56990: Bugfix for Replacement of tied operand of inline asm

xiangzhangllvm added a comment. !!! Hi, dear efriedma, very sorry! I just saw your reply. line 2093: getTargetHooks().adjustInlineAsmType(... InputConstraint,...) will just deal with the constrain string, and it can't check the TiedOperand in the function. So, this will make inconsistent

r355665 - [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

Author: phosek Date: Thu Mar 7 21:35:22 2019 New Revision: 355665 URL: http://llvm.org/viewvc/llvm-project?rev=355665=rev Log: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ This change is a consequence of the discussion in "RFC: Place libs in Clang-dedicated directories",

[libunwind] r355665 - [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

Author: phosek Date: Thu Mar 7 21:35:22 2019 New Revision: 355665 URL: http://llvm.org/viewvc/llvm-project?rev=355665=rev Log: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ This change is a consequence of the discussion in "RFC: Place libs in Clang-dedicated directories",

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

This revision was automatically updated to reflect the committed changes. Closed by commit rL355665: [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D59013?vs=189795=189813#toc

r355664 - Fix test case committed in r355662.

Author: ahatanak Date: Thu Mar 7 21:30:54 2019 New Revision: 355664 URL: http://llvm.org/viewvc/llvm-project?rev=355664=rev Log: Fix test case committed in r355662. Build bots were failing because wide string literals don't have type 'int *' on some targets. Modified:

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

This revision was automatically updated to reflect the committed changes. Closed by commit rL355662: [ObjC] Emit a boxed expression as a compile-time constant if the (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r355662 - [ObjC] Emit a boxed expression as a compile-time constant if the

Author: ahatanak Date: Thu Mar 7 20:45:37 2019 New Revision: 355662 URL: http://llvm.org/viewvc/llvm-project?rev=355662=rev Log: [ObjC] Emit a boxed expression as a compile-time constant if the expression inside the parentheses is a valid UTF-8 string literal. Previously clang emitted an

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak marked an inline comment as done. ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:922 +def warn_objc_boxing_invalid_utf8_string : Warning< + "string is ill-formed as UTF-8 and will become a null NSString* when boxed">, + InGroup;

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:922 +def warn_objc_boxing_invalid_utf8_string : Warning< + "string is ill-formed as UTF-8 and will become a

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:922 +def warn_objc_boxing_invalid_utf8_string : Warning< + "string is ill-formed as UTF-8 and will become a null NSString* when boxed">, + InGroup; rjmccall wrote: > Might

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

ahatanak updated this revision to Diff 189809. ahatanak marked an inline comment as done. ahatanak added a comment. Use the type of `NSStringPointer` in the diagnostic string. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58729/new/

[PATCH] D57850: [analyzer] Emit an error rather than assert on invalid checker option input

NoQ added a comment. > Would you mind me committing as is? Np, please do, the patch is great regardless! Comment at: lib/StaticAnalyzer/Checkers/PaddingChecker.cpp:352-355 + if (Checker->AllowedPad < 0) +

[PATCH] D58880: [WIP] [Looking for API feedback] [clangd] Type hierarchy subtypes

nridge planned changes to this revision. nridge added a comment. Thanks for the detailed analysis! For completeness, I think another advantage of option 3 is that it allows us to make the key for relation lookups be a (SymbolID, RelationKind) pair rather than just a SymbolID. It sounds like I

[PATCH] D59123: [analyzer] RetainCount: Fix a crash when a function follows retain/autorelease naming convention but takes no arguments.

NoQ added a comment. The actual crash happens in `RetainCountChecker::evalCall()`: 912 const Expr *BindReturnTo = 913 (BSmr == BehaviorSummary::IdentityThis) 914 ? cast(CE)->getImplicitObjectArgument() 915 : CE->getArg(0); // <== here Repository:

[PATCH] D59123: [analyzer] RetainCount: Fix a crash when a function follows retain/autorelease naming convention but takes no arguments.

NoQ created this revision. NoQ added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. We desperately need a checker that finds unchecked

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:699 def ParenthesesOnEquality : DiagGroup<"parentheses-equality">; +def AssigmentInBoolContext : DiagGroup<"assigment-in-bool-context">; def Parentheses : DiagGroup<"parentheses",

[PATCH] D58729: Emit boxed expression as a compile-time constant if the expression inside the parentheses is a string literal

rjmccall added inline comments. Comment at: include/clang/Basic/DiagnosticGroups.td:407 def ObjCFlexibleArray : DiagGroup<"objc-flexible-array">; +def ObjCBoxing : DiagGroup<"objc-boxing">; def OpenCLUnsupportedRGBA: DiagGroup<"opencl-unsupported-rgba">; Sure.

[PATCH] D59121: [analyzer] Fix macro names in diagnostics within bigger macros.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. On the newly included test

[PATCH] D58885: Variable auto-init: split out small arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rL355660: Variable auto-init: split out small arrays (authored by jfb, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST

r355660 - Variable auto-init: split out small arrays

Author: jfb Date: Thu Mar 7 17:26:49 2019 New Revision: 355660 URL: http://llvm.org/viewvc/llvm-project?rev=355660=rev Log: Variable auto-init: split out small arrays Summary: Following up with r355181, initialize small arrays as well. LLVM stage2 shows a tiny size gain. Reviewers: glider,

[PATCH] D59118: creduce script for clang crashes

george.burgess.iv added a comment. Thanks for this! Functionally, this looks good. My comments are mostly just simplicity/readability nitpicks. Comment at: clang/utils/creduce-clang-crash.py:36 + # Get clang call from build script + cmd = None + with open(build_script,

Re: r355322 - Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.

I would recommend doing what was done for _xgetbv as in r351391: - Provide __builtin_ia32_rot* everywhere (or something like that in the implementor's namespace) - Conditionally #define _rot* to __builtin_ia32_rot* in ia32intrin.h, maybe ifdef _GNUC - Also provide _rot* builtins when

r355659 - [X86] Make x86-intrinsics-headers-clean.cpp stricter.

Author: ctopper Date: Thu Mar 7 17:15:18 2019 New Revision: 355659 URL: http://llvm.org/viewvc/llvm-project?rev=355659=rev Log: [X86] Make x86-intrinsics-headers-clean.cpp stricter. Remove the -Wno-ignored-attributes. Add -fno-lax-vector-conversions Also use -ffreestanding instead of defining

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

george.burgess.iv added a comment. Looks solid to me overall; just a few nits. I don't think I have actual ownership over any of this code, so I'll defer to either Aaron or Richard for the final LGTM Thanks again! Comment at: clang/lib/Sema/SemaChecking.cpp:317 + // buffer

[PATCH] D59118: creduce script for clang crashes

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a script that calls C-Reduce on an input file and given the clang crash script, which is used to

[PATCH] D59055: [analyzer] Prepare generic taint checker for new sources

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Ok, so "source" functions are now merely "propagate from nothing" functions? Fair enough! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59055/new/

[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like elements

NoQ accepted this revision. NoQ added a comment. Ok, thanks, sounds good! Let's land and see where it goes. Comment at: test/Analysis/ptr-sort.cpp:4-25 +namespace std { + template + bool is_sorted(ForwardIt first, ForwardIt last); + + template + void nth_element(RandomIt

[PATCH] D58777: [analyzer] Fix an assertation failurure for invalid sourcelocation, add a new debug checker

NoQ accepted this revision. NoQ added a subscriber: george.karpenkov. NoQ added a comment. This revision is now accepted and ready to land. Very nice! Crashing diagnostic locations are a fairly common issue. That said, this still makes me wonder what sort of checker were you writing that

Re: r355322 - Enable _rotl, _lrotl, _rotr, _lrotr on all platforms.

This patch breaks some code which is (conditionally) defining functions of these names on certain platforms. Now, it's true that it shouldn't be doing that, and if the claim in the commit message about GCC was true, I'd just say "don't do that". But, the commit message is wrong. GCC does _not_

[PATCH] D59013: [CMake][runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/

phosek updated this revision to Diff 189795. phosek marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59013/new/ https://reviews.llvm.org/D59013 Files: clang/lib/Driver/ToolChain.cpp clang/lib/Driver/ToolChains/Fuchsia.cpp

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59054/new/ https://reviews.llvm.org/D59054 ___ cfe-commits mailing list

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

NoQ updated this revision to Diff 189791. NoQ added a comment. Added this as a comment. If the patch is not obvious at a glance, feel free to demand comments! Every second you spend trying to figure out how the code works is multiplied by the number of people who will have to do the same in

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

NoQ added a comment. At a glance, it seems as if these are great findings for a hardening effort, but most of these don't look like immediate bugs (had a look at 10 or so), so i guess i'd suggest `optin.cplusplus`, at least for now. Also, hmm, how about the following heuristics (looked at the

[PATCH] D59048: Add AIX Target Info

hubert.reinterpretcast added inline comments. Comment at: clang/test/Preprocessor/init.c:6420 +// PPC64-AIX:#define _LONG_LONG 1 +// PPC64-AIX:#define _POWER 1 +// PPC64-AIX:#define __64BIT__ 1 hubert.reinterpretcast wrote: > apaprocki wrote: > > XL on AIX emits

[PATCH] D57922: [analyzer] Insert checker options into AnalyzerOption::ConfigTable

Szelethus planned changes to this revision. Szelethus added a comment. Uhh, we still need to restore the default value -- I might end up splitting this patch a little further. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57922/new/ https://reviews.llvm.org/D57922

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

Szelethus added a reviewer: JonasToth. Szelethus added a comment. Is this patch good to go? :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48866/new/ https://reviews.llvm.org/D48866 ___ cfe-commits

[PATCH] D48866: [clang-tidy] Add incorrect-pointer-cast checker

hgabii marked 2 inline comments as done. hgabii added a comment. @steakhal I think it is basically done. If you have any recommendations what needs to be changed, then I welcome your contribution. I can also fix new comments, but I have limited time for this. Repository: rCTE Clang Tools

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

Szelethus added a comment. Ooooh you explained that very well, I'm clear on what's happening then :D Still, I'll poke the code here and there to learn about this part of the analyzer, I might even come up with some meaningful feedback (or a meaningful patch acceptance). CHANGES SINCE LAST

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:2348 +// Virtual bases still aren't allowed. Multiple bases are fine though. +for (auto B : CRD->bases()) { + assert(B.isVirtual() == false); alexfh wrote: > Should

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

NoQ updated this revision to Diff 189781. NoQ marked 5 inline comments as done. NoQ added a comment. Thx! Also added the more direct test. > I'll take the time to understand the infrastructure behind it Well, roughly, the `CompoundVal` kind of value is used very rarely, unlike

[PATCH] D59105: [RFC] Create an Arbitrary Precision Integer Type.

rsmith added a comment. In principle, I think an extension in this space seems reasonable and useful. Considering the points in http://clang.llvm.org/get_involved.html, I'm happy to assume you meet points 2, 5, and 6, but I'd like to see a written-up rationale for the other points. (In

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

aaron.ballman added a comment. I'm definitely worried about the false positive rate for this check -- from a quick look at the diagnostics from LLVM, every one of them is a false positive (though perhaps I've missed something; it was a very quick look). Requiring users to explicitly use a

Re: r355489 - clang-cl: Parse /Qspectre and a few other missing options (PR40964)

Yes, we warn about them being unused. On Thu, Mar 7, 2019 at 21:59 Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Do we warn "ignoring flag" or something like that for these, or are these > now silently ignored? > > On Wed, Mar 6, 2019 at 4:37 AM Hans Wennborg via cfe-commits

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

GorNishanov requested changes to this revision. GorNishanov added inline comments. This revision now requires changes to proceed. Comment at: lib/Sema/SemaCoroutine.cpp:675 + // Second emphasis of [expr.await]p2: must be outside of an exception handler. + if

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

lewissbaker added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:675 + // Second emphasis of [expr.await]p2: must be outside of an exception handler. + if (S.getCurScope()->getFlags() & Scope::CatchScope) { +S.Diag(Loc, diag::err_coroutine_within_handler) <<

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

lewissbaker added inline comments. Comment at: test/SemaCXX/coroutines.cpp:299-311 // FIXME: The spec says this is ill-formed. void operator=(CtorDtor&) { co_yield 0; // expected-error {{'co_yield' cannot be used in a copy assignment operator}} } void

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

GorNishanov added inline comments. Comment at: test/SemaCXX/coroutines.cpp:299-311 // FIXME: The spec says this is ill-formed. void operator=(CtorDtor&) { co_yield 0; // expected-error {{'co_yield' cannot be used in a copy assignment operator}} } void

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

thakis added a comment. Does our serialization machinery serialize these correctly automatically? What happens if you compiler a header saying `execution_character_set_push, "utf-8")` in a header, compile that to a pch, then include that through the pch in a .c file that does pop? My guess is

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/IncompleteComparisonOperatorCheck.cpp:197 + + const auto Ops = utils::options::parseStringList(CheckedFunctions); + Finder->addMatcher( Please don't use auto where return type is not

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache marked an inline comment as done. modocache added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:675 + // Second emphasis of [expr.await]p2: must be outside of an exception handler. + if (S.getCurScope()->getFlags() & Scope::CatchScope) { +S.Diag(Loc,

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache updated this revision to Diff 189763. modocache added a comment. Add test case for executing a lambda using co_yield within a catch block. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 Files:

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

JonasToth added a comment. @lebedev.ri @kallehuttunen what do you think of putting this into context of the proposal (i believe its being standardized with c++20) of `operator==() = default` and the spaceship-operator. This check could serve as a basis to modernize the `operator==` to the

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:197-200 - if (S.isUnevaluatedContext()) { -S.Diag(Loc, diag::err_coroutine_unevaluated_context) << Keyword; -return false; - } lewissbaker wrote: > Does removing this check now

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

MyDeveloperDay added a comment. I definately been burnt by not handling all the cases, but imagine a string class class mystring { const char *ptr; int size; int numallocated; } to compare the strings I wouldn't want to compare all the fields? I think this could lead to a lot of false

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

efriedma added a comment. It looks like every call to getABIKind() is doing the wrong thing; I'm worried that's going to lead to some sort of subtle miscompile without some sort of centralized fix to compute the correct calling convention for every place that checks it. Not sure how to write

r355627 - Recommit "Support attribute used in member funcs of class templates"

Author: rafauler Date: Thu Mar 7 11:14:30 2019 New Revision: 355627 URL: http://llvm.org/viewvc/llvm-project?rev=355627=rev Log: Recommit "Support attribute used in member funcs of class templates" The patch originally broke code that was incompatible with GCC, but we want to follow GCC

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

lebedev.ri added inline comments. Comment at: clang-tidy/bugprone/IncompleteComparisonOperatorCheck.cpp:242-243 +diag(Operator->getBeginLoc(), "incomplete comparison operator"); +Lhs->diagFields(*this, Operator->getBeginLoc()); +Rhs->diagFields(*this,

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen added a comment. In D59103#1421875 , @lebedev.ri wrote: > Thank you for working on this! > > This looks questionable to me. > Is this based on some coding standard? > Are there any numbers on the false-positive rate of theck? It's not

r355625 - Fix some clang analysis tests passing arguments incorrectly

Author: rnk Date: Thu Mar 7 10:57:04 2019 New Revision: 355625 URL: http://llvm.org/viewvc/llvm-project?rev=355625=rev Log: Fix some clang analysis tests passing arguments incorrectly Modified: cfe/trunk/unittests/Analysis/ExprMutationAnalyzerTest.cpp Modified:

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen added a comment. The checker gives quite many warnings on LLVM code base. For example, running it for lib/Transforms/Scalar: /home/kalle/llvm/lib/Transforms/Scalar/GVN.cpp:119:3: warning: incomplete comparison operator [bugprone-incomplete-comparison-operator] bool

[PATCH] D59034: Delete x86_64 ShadowCallStack support

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT355624: Delete x86_64 ShadowCallStack support (authored by vlad.tsyrklevich, committed by ). Changed prior to commit: https://reviews.llvm.org/D59034?vs=189750=189756#toc Repository: rCRT Compiler

r355624 - Delete x86_64 ShadowCallStack support

Author: vlad.tsyrklevich Date: Thu Mar 7 10:56:36 2019 New Revision: 355624 URL: http://llvm.org/viewvc/llvm-project?rev=355624=rev Log: Delete x86_64 ShadowCallStack support Summary: ShadowCallStack on x86_64 suffered from the same racy security issues as Return Flow Guard and had performance

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

sigatrev added a comment. Yeah, that would be great. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

lebedev.ri added a comment. Thank you for working on this! This looks questionable to me. Is this based on some coding standard? Are there any numbers on the false-positive rate of theck? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59103/new/

[PATCH] D59103: [clang-tidy] New checker bugprone-incomplete-comparison-operator

kallehuttunen created this revision. kallehuttunen added reviewers: alexfh, hokein, JonasToth, aaron.ballman. kallehuttunen added a project: clang-tools-extra. Herald added subscribers: jdoerfert, xazax.hun, mgorny. Herald added a project: clang. The checker detects comparison operators that

[PATCH] D58530: Add PragmaHandler for MSVC pragma execution_character_set

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, thanks! Would you like someone to land this for you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58530/new/ https://reviews.llvm.org/D58530

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

lewissbaker added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:197-200 - if (S.isUnevaluatedContext()) { -S.Diag(Loc, diag::err_coroutine_unevaluated_context) << Keyword; -return false; - } Does removing this check now mean that we're not

[PATCH] D59034: Delete x86_64 ShadowCallStack support

vlad.tsyrklevich updated this revision to Diff 189750. vlad.tsyrklevich added a comment. - Keep x86_64 doc link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59034/new/ https://reviews.llvm.org/D59034 Files: clang/docs/ShadowCallStack.rst

[PATCH] D58814: [clang][Index] Constructors and Destructors do not reference class

nathawes accepted this revision. nathawes added a comment. This revision is now accepted and ready to land. Thank you! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58814/new/ https://reviews.llvm.org/D58814 ___

r355605 - [analyzer] handle modification of vars inside an expr with comma operator

Author: petarj Date: Thu Mar 7 07:50:52 2019 New Revision: 355605 URL: http://llvm.org/viewvc/llvm-project?rev=355605=rev Log: [analyzer] handle modification of vars inside an expr with comma operator We should track mutation of a variable within a comma operator expression. Current code in

r355616 - Rollback of rL355585.

Author: hctim Date: Thu Mar 7 10:13:39 2019 New Revision: 355616 URL: http://llvm.org/viewvc/llvm-project?rev=355616=rev Log: Rollback of rL355585. Introduces memory leak in FunctionTest.GetPointerAlignment that breaks sanitizer buildbots: ```

r355614 - [OPENMP 5.0]Add initial support for 'allocate' directive.

Author: abataev Date: Thu Mar 7 09:54:44 2019 New Revision: 355614 URL: http://llvm.org/viewvc/llvm-project?rev=355614=rev Log: [OPENMP 5.0]Add initial support for 'allocate' directive. Added parsing/sema analysis/serialization/deserialization support for 'allocate' directive. Added:

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()(

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet marked an inline comment as done. kadircet added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. + Cmd.CommandLine =

[PATCH] D58216: Support attribute used in member funcs of class templates II

bob.wilson added a comment. OK, that doesn't sound like it will be a problem Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58216/new/ https://reviews.llvm.org/D58216 ___ cfe-commits mailing list

[PATCH] D58708: [PR40778] Preserve addr space in Derived to Base cast

Anastasia closed this revision. Anastasia added a comment. Committed in r355606. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58708/new/ https://reviews.llvm.org/D58708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r355609 - [Sema] Change addr space diagnostics in casts to follow C++ style.

Author: stulova Date: Thu Mar 7 09:06:30 2019 New Revision: 355609 URL: http://llvm.org/viewvc/llvm-project?rev=355609=rev Log: [Sema] Change addr space diagnostics in casts to follow C++ style. This change adds a new diagnostic for mismatching address spaces to be used for C++ casts (only

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

This revision was automatically updated to reflect the committed changes. Closed by commit rL355609: [Sema] Change addr space diagnostics in casts to follow C++ style. (authored by stulova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58719: [PR40778][Sema] Adjust address space of operands in builtin operators

This revision was automatically updated to reflect the committed changes. Closed by commit rC355608: [PR40778][Sema] Adjust addr space of operands in builtin operators. (authored by stulova, committed by ). Herald added a subscriber: kristina. Herald added a project: clang. Changed prior to

r355608 - [PR40778][Sema] Adjust addr space of operands in builtin operators.

Author: stulova Date: Thu Mar 7 08:43:41 2019 New Revision: 355608 URL: http://llvm.org/viewvc/llvm-project?rev=355608=rev Log: [PR40778][Sema] Adjust addr space of operands in builtin operators. Adjust address space for references and pointer operands of builtin operators. Currently this

r355606 - [PR40778] Preserve addr space in Derived to Base cast.

Author: stulova Date: Thu Mar 7 08:23:15 2019 New Revision: 355606 URL: http://llvm.org/viewvc/llvm-project?rev=355606=rev Log: [PR40778] Preserve addr space in Derived to Base cast. The address space for the Base class pointer when up-casting from Derived should be taken from the Derived class

[PATCH] D59092: [clangd] Deduplicate Refs on the fly.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clangd/index/Ref.cpp:44 RefSlab RefSlab::Builder::build() && { // We can reuse the arena, as it only has unique strings and we need them all.

[PATCH] D58894: [analyzer] Handle modification of vars inside an expr with comma operator

This revision was automatically updated to reflect the committed changes. Closed by commit rL355605: [analyzer] handle modification of vars inside an expr with comma operator (authored by petarj, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

ioeric added inline comments. Comment at: clangd/GlobalCompilationDatabase.cpp:25 + // Clangd does not generate dependency file. + Cmd.CommandLine = tooling::getClangStripDependencyFileAdjuster()( + Cmd.CommandLine, Cmd.Filename); Please use

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clangd/GlobalCompilationDatabase.cpp:24 llvm::StringRef ResourceDir) { + // Clangd does not generate dependency file. +

[PATCH] D59054: [analyzer] C++17: PR40022: Support aggregate initialization with compound values in presence of base classes.

Szelethus added a comment. At first glance this looks OK, but I'll take the time to understand the infrastructure behind it and give a proper review. Comment at: clang/test/Analysis/array-struct-region.cpp:3 // RUN: %clang_analyze_cc1

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a subscriber: rnkovacs. > This patch is the next in the series of patches to finish the proper error > handling (i.e. using Error and Expected). Please see the "Stack" column > above. @balazske Or is it superseded by this one?

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

carwil created this revision. Herald added subscribers: cfe-commits, jdoerfert, kristof.beyls, javed.absar. Herald added a project: clang. See: https://bugs.llvm.org/show_bug.cgi?id=39982 When considering how to classify homogeneous aggregates as return/argument types, the ABI of the function

[PATCH] D53757: [ASTImporter] Changed use of Import to Import_New in ASTNodeImporter.

martong added a comment. Herald added a reviewer: martong. Herald added a project: clang. Ping. This patch is the next in the series of patches to finish the proper error handling (i.e. using Error and Expected). Please see the "Stack" column above. Repository: rC Clang CHANGES SINCE LAST

[PATCH] D58930: Add XCOFF triple object format type for AIX

jasonliu updated this revision to Diff 189713. jasonliu added a comment. Share the same "unsupported error" message with WASM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58930/new/ https://reviews.llvm.org/D58930 Files:

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

xbolva00 added a comment. Addressed notes. Not sure why we miss _Bool warn3(int x, _Bool a) { return x = 0 || a; } in C mode :/ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58878/new/ https://reviews.llvm.org/D58878 ___ cfe-commits

[PATCH] D58878: [Diagnostics] Warn for assignments in bool contexts

xbolva00 updated this revision to Diff 189711. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58878/new/ https://reviews.llvm.org/D58878 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExprCXX.cpp

r355601 - expected-no-diagnostics@ does not make sense, switching to a more idiomatic form; NFC.

Author: aaronballman Date: Thu Mar 7 07:03:06 2019 New Revision: 355601 URL: http://llvm.org/viewvc/llvm-project?rev=355601=rev Log: expected-no-diagnostics@ does not make sense, switching to a more idiomatic form; NFC. Modified: cfe/trunk/test/SemaObjCXX/vararg-non-pod.mm Modified:

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman added inline comments. Comment at: lib/Sema/SemaDecl.cpp:5970 auto *VD = dyn_cast(); -if (!ND.isExternallyVisible() || (VD && VD->isStaticLocal())) { +const NamespaceDecl *NS = nullptr; +bool isAnonymousNS = false; This can be

[PATCH] D59092: [clangd] Deduplicate Refs on the fly.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: arphaman, mgrang, jkorous, MaskRay, ioeric, ilya-biryukov. Herald added a project: clang. Currently, we only do deduplication when we flush final results. We may have huge duplications (refs from headers)

[PATCH] D59022: [clangd] Strip plugin arguments in clangd-indexer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL355599: [clangd] Strip plugin arguments in clangd-indexer. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE

[clang-tools-extra] r355599 - [clangd] Strip plugin arguments in clangd-indexer.

Author: hokein Date: Thu Mar 7 06:47:17 2019 New Revision: 355599 URL: http://llvm.org/viewvc/llvm-project?rev=355599=rev Log: [clangd] Strip plugin arguments in clangd-indexer. Summary: This would allow clangd-indexer runs on chromium repo. Reviewers: kadircet Reviewed By: kadircet

[PATCH] D59086: [clangd] Adjust compile commands to be applicable for tooling

kadircet updated this revision to Diff 189706. kadircet marked 2 inline comments as done. kadircet added a comment. - Change testing strategy Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59086/new/ https://reviews.llvm.org/D59086 Files:

[PATCH] D57464: Generalize method overloading on addr spaces to C++

ebevhan added a comment. Any more input on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57464/new/ https://reviews.llvm.org/D57464 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

  1   2   >