[PATCH] D59353: [WebAssembly] Use rethrow intrinsic in the rethrow block

This revision was automatically updated to reflect the committed changes. Closed by commit rC356317: [WebAssembly] Use rethrow intrinsic in the rethrow block (authored by aheejin, committed by ). Changed prior to commit: https://reviews.llvm.org/D59353?vs=190587&id=190947#toc Repository: rC

r356317 - [WebAssembly] Use rethrow intrinsic in the rethrow block

Author: aheejin Date: Fri Mar 15 22:39:12 2019 New Revision: 356317 URL: http://llvm.org/viewvc/llvm-project?rev=356317&view=rev Log: [WebAssembly] Use rethrow intrinsic in the rethrow block Summary: Because in wasm we merge all catch clauses into one big catchpad, in case none of the types in ca

[PATCH] D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h

craig.topper updated this revision to Diff 190943. craig.topper added a comment. Add comments based on rnk's review Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59346/new/ https://reviews.llvm.org/D59346 Files: lib/Headers/ia32intrin.h test/CodeGen/rot-intr

[PATCH] D59446: CodeGen: Preserve packed attribute in constStructWithPadding.

pcc created this revision. pcc added reviewers: jfb, glider. Herald added a project: clang. Otherwise the object may have an incorrect size due to tail padding. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59446 Files: clang/lib/CodeGen/CGDecl.cpp clang/test/CodeGenCXX/a

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. In D54978#1431788 , @ddcc wrote: > The only relevant commit that I can find is > https://github.com/Z3Prover/z3/commit/2cb4223979cc94e2ebc4e49a9e83adbdcd2b6979 > , but it first landed in z3 4.6.0. It looks like it's speci

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. The only relevant commit that I can find is https://github.com/Z3Prover/z3/commit/2cb4223979cc94e2ebc4e49a9e83adbdcd2b6979 , but it first landed in z3 4.6.0. It looks like it's specific to CMake though, so is it different if you use the python build? I haven't tried the CM

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. In D54978#1431786 , @ddcc wrote: > In D54978#1431430 , @mikhail.ramalho > wrote: > > > Sorry for the massive delay, but I just updated the `FindZ3` script to > > retrieve the versi

[PATCH] D54978: Move the SMT API to LLVM

ddcc added a comment. In D54978#1431430 , @mikhail.ramalho wrote: > Sorry for the massive delay, but I just updated the `FindZ3` script to > retrieve the version from the lib. I changed it to use `try_run` instead of > `try_compile` so we can get the ve

r356307 - hello, clang

Author: charusso Date: Fri Mar 15 16:44:35 2019 New Revision: 356307 URL: http://llvm.org/viewvc/llvm-project?rev=356307&view=rev Log: hello, clang Test commit with head and body. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h Modified: cfe/trunk/include/cl

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay added a comment. In D59296#1430813 , @aaron.ballman wrote: > I think the release notes should be updated to mention that a > previously-supported option has been removed and that there's a new option > available as a replacement; I don't think w

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190937. MaskRay marked an inline comment as done. MaskRay added a comment. Update ReleaseNotes.rst Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/ReleaseN

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

thakis added a comment. In D58418#1431399 , @jkorous wrote: > In D58418#1430630 , @thakis wrote: > > > In D58418#1430490 , @jkorous wrote: > > > > > In D58418#1430160

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190936. MaskRay added a comment. Reflow string literal Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/pp-trace.rst pp-trace/PPCallbacksTracker.cpp pp-

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

MaskRay updated this revision to Diff 190935. MaskRay added a comment. Reflow comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59296/new/ https://reviews.llvm.org/D59296 Files: docs/pp-trace.rst pp-trace/PPCallbacksTracker.cpp pp-trace/

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

This revision was automatically updated to reflect the committed changes. Closed by commit rL356308: [analyzer] Teach scan-build to find clang when installed in /usr/local/bin/ (authored by dcoughlin, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed p

r356308 - [analyzer] Teach scan-build to find clang when installed in /usr/local/bin/

Author: dcoughlin Date: Fri Mar 15 18:01:29 2019 New Revision: 356308 URL: http://llvm.org/viewvc/llvm-project?rev=356308&view=rev Log: [analyzer] Teach scan-build to find clang when installed in /usr/local/bin/ Change scan-build to support the scenario where scan-build is installed in $TOOLCHAIN

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thx! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59406/new/ https://reviews.llvm.org/D59406 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

dcoughlin updated this revision to Diff 190931. dcoughlin edited the summary of this revision. dcoughlin added a comment. Herald added a subscriber: jdoerfert. Update to restrict the new behavior to when Xcode is present. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59406/new/ https://

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

dcoughlin added a comment. That's a good point. I've updated the patch to look for 'xcrun' CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59406/new/ https://reviews.llvm.org/D59406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D59406: [analyzer] Teach scan-build to find /usr/bin/clang when installed in /usr/local/bin/

NoQ added a comment. This should indeed take care of our relatively tricky macOS use-case! I'm a bit worried for unexpected consequences on some of the more exotic linux setups - who knows what `../..` is supposed to contain. Maybe restrict this lookup to Darwin somehow? - And i guess let's eve

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang updated this revision to Diff 190929. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59440/new/ https://reviews.llvm.org/D59440 Files: clang/utils/creduce-clang-crash.py Index: clang/utils/creduce-clang-crash.py ==

[PATCH] D57335: [IR] Don't assume all functions are 4 byte aligned

efriedma added a comment. Anyone looking at updating the datalayout for other platforms? (If nobody is looking at all, I'll try to find some time next week, I guess.) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57335/new/ https://reviews.llvm.org/D57335 ___

[PATCH] D59440: add steps to preprocess file and reduce command line args

akhuang created this revision. akhuang added reviewers: rnk, george.burgess.iv. Herald added a reviewer: serge-sans-paille. Herald added a project: clang. Herald added a subscriber: cfe-commits. -try to preprocess the file before reducing -try to remove some command line arguments -now requires a

[PATCH] D58757: Add a version of the pass_object_size attribute that works with builtin_dynamic_object_size

erik.pilkington added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1570 +def PassDynamicObjectSize : InheritableParamAttr { + let Spellings = [Clang<"pass_dynamic_object_size">]; + let Args = [IntArgument<"Type">]; aaron.ballman wrote: > Why u

[PATCH] D58757: Add a version of the pass_object_size attribute that works with builtin_dynamic_object_size

erik.pilkington updated this revision to Diff 190917. erik.pilkington marked 4 inline comments as done. erik.pilkington added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58757/new/ https://reviews.llvm.org/D58757 Files: clang/include/clang/Basic/

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

hubert.reinterpretcast added subscribers: asb, majnemer, lhames. hubert.reinterpretcast added a comment. @asb @lhames @majnemer, based on D36826 , I believe that your guidance would be helpful here regarding the use of `llvm_unreachable`, `report_fatal_error`, an

[PATCH] D57835: Fix -ftime-report with -x ir

fedor.sergeev added inline comments. Comment at: test/Frontend/ftime-report-bitcode.ll:1 +; RUN: %clang_cc1 -triple x86_64-apple-darwin10 -ftime-report -emit-obj -o /dev/null %s 2>&1 | FileCheck %s + Can you, please, test -fexperimental-new-pass-manager mode as

[PATCH] D57835: Fix -ftime-report with -x ir

fedor.sergeev added a comment. In D57835#1387622 , @arsenm wrote: > I partially solved the problem with double printing the reports. It's from > this in cc1_main: > > // If any timers were active but haven't been destroyed yet, print theirp > // resu

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

reuk added a comment. @MyDeveloperDay I'm not sure you built this branch. Perhaps you applied this patch to an older version of the repo. For me, SpaceBeforeCpp11BracedListOptions is defined at Format.h:1570. This builds fine for me, on macOS 10.14 with Xcode 10.1's clang. I just rebased onto

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/StmtOpenMP.h:274 + /// Prerequisite: Executable Directive must not be Standalone directive. + Stmt *getStructuredBlock() const; }; riccibruno wrote: > This is not const-correct. The const-qualifie

[PATCH] D59346: [X86] Add gcc rotate intrinsics to ia32intrin.h

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. Looks good to me. Let's wait for @jyknight though. Comment at: lib/Headers/ia32intrin.h:120 + +#ifndef _MSC_VER +/* Select the correct function based on the size of long. */ --

[PATCH] D59196: [NFC][clang][PCH] ASTStmtReader::VisitStmt(): fixup faulty assert.

lebedev.ri abandoned this revision. lebedev.ri added a comment. In D59196#1431531 , @riccibruno wrote: > In D59196#1431473 , @lebedev.ri > wrote: > > > In D59196#1429393 , @

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

riccibruno added inline comments. Comment at: include/clang/AST/Stmt.h:100 unsigned sClass : 8; +unsigned IsOMPStructuredBlock : 1; }; What about a comment explaining the purpose of this bit ? Comment at: include/clang/AST/StmtOpenM

[PATCH] D59196: [NFC][clang][PCH] ASTStmtReader::VisitStmt(): fixup faulty assert.

riccibruno added a comment. In D59196#1431473 , @lebedev.ri wrote: > In D59196#1429393 , @riccibruno > wrote: > > > I am not an expert in the serialization code (just did some modifications), > > but this seems re

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431302 , @arsenm wrote: > > ML workloads are extremely unlikely to use a call. We should have an > execution tests with noinline somewhere to stress this I compiled and ran a test with noinline function and I saw fu

[PATCH] D59196: [NFC][clang][PCH] ASTStmtReader::VisitStmt(): fixup faulty assert.

lebedev.ri added a reviewer: dexonsmith. lebedev.ri added a comment. In D59196#1429393 , @riccibruno wrote: > I am not an expert in the serialization code (just did some modifications), > but this seems reasonable to me. That's my thoughts too.. Unless

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. Hi all, Sorry for the massive delay, but I just updated the `FindZ3` script to retrieve the version from the lib. I changed it to use `try_run` instead of `try_compile` so we can get the version number. I tried to use @brzycki code to get the version from the h

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho updated this revision to Diff 190893. mikhail.ramalho added a comment. Update Z3 script to use cmake's `try_run` in order to retrieve the version from the lib. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54978/new/ https://reviews.llvm.org/D54978 Files: clang/CMake

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. In D58418#1430630 , @thakis wrote: > In D58418#1430490 , @jkorous wrote: > > > In D58418#1430160 , @thakis wrote: > > > > > Why is this needed for in

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

modocache added a comment. Great, thanks for the reviews, everyone! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

This revision was automatically updated to reflect the committed changes. Closed by commit rC356296: [coroutines][PR40978] Emit error for co_yield within catch block (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D59076?vs=190740&id=190890#toc Reposit

r356296 - [coroutines][PR40978] Emit error for co_yield within catch block

Author: modocache Date: Fri Mar 15 13:25:49 2019 New Revision: 356296 URL: http://llvm.org/viewvc/llvm-project?rev=356296&view=rev Log: [coroutines][PR40978] Emit error for co_yield within catch block Summary: As reported in https://bugs.llvm.org/show_bug.cgi?id=40978, it's an error to use the `c

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + ABataev

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote:

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, +

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

jkorous added a comment. Hi Duncan, thanks for working on better interfaces in clang! I am just wondering - is it safe to have the lifetime of a single object on heap managed by two different `IntrusiveRefCntPtr` instances? Comment at: clang/lib/Frontend/ASTUnit.cpp:1693

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1431284 , @yaxunl wrote: > In D59316#1431276 , @arsenm wrote: > > > In D59316#1431253 , @yaxunl wrote: > > > > > In D59316#1431238

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + ABataev

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431276 , @arsenm wrote: > In D59316#1431253 , @yaxunl wrote: > > > In D59316#1431238 , @arsenm wrote: > > > > > In D59316#1429580

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + jdoerfert wrote: > ABataev wrote: > > jdoerfert wrote:

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, + bool RequiresOMPRuntime, j

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1431253 , @yaxunl wrote: > In D59316#1431238 , @arsenm wrote: > > > In D59316#1429580 , @yaxunl wrote: > > > > > Here we are looking at the

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + ABataev

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet added a comment. In D59302#1431045 , @ilya-biryukov wrote: > I'll look more closely into the details, but just a high-level question now: > why would we want to make this optional and not simply surface these extra > diagnostics? The optional

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, +

[PATCH] D59094: [ARM] Fix bug 39982 - pcs("aapcs-vfp") is not consistent

efriedma accepted this revision. efriedma added a reviewer: t.p.northover. efriedma added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/TargetInfo.cpp:6023 + // Variadic functions should always marshal to the base standard. + b

[PATCH] D59426: [PR41010][OpenCL] Allow OpenCL C style vector initialization in C++

Anastasia created this revision. Anastasia added reviewers: rjmccall, bader. Herald added subscribers: jdoerfert, ebevhan, yaxunl. Not sure it's the right approach but the idea is that we would like to accept vector contraction syntax from OpenCL C. This commit fixes Sema checks when creating a

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

yaxunl added a comment. In D59316#1431238 , @arsenm wrote: > In D59316#1429580 , @yaxunl wrote: > > > Here we are looking at the code which emulates a "linker" for HIP > > toolchain. The offloading action builder r

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert updated this revision to Diff 190868. jdoerfert added a comment. Fix a typo (use of wrong variable) and improve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59319/new/ https://reviews.llvm.org/D59319 Files: openmp/libomptarge

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

arsenm added a comment. In D59316#1429580 , @yaxunl wrote: > Here we are looking at the code which emulates a "linker" for HIP toolchain. > The offloading action builder requests the offloading toolchain have a > linker, but amdgpu does not have a real l

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + jdoerfert wrote: > > What is this buffer used for? Tra

r356291 - [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3)

Author: emankov Date: Fri Mar 15 12:04:46 2019 New Revision: 356291 URL: http://llvm.org/viewvc/llvm-project?rev=356291&view=rev Log: [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3) Partial fix for the clang Bug 38811 "Clang fails to compile with CUDA-9.x on Windows". [Synopsis] __sptr

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert marked an inline comment as not done. jdoerfert added inline comments. Comment at: openmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h:73 +/// Note: Only the team master is allowed to call non-const functions! +struct shared_bytes_buffer { + > Wh

[PATCH] D59423: [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3)

This revision was automatically updated to reflect the committed changes. Closed by commit rC356291: [CUDA][Windows] Partial fix for bug 38811 (Step 2 of 3) (authored by emankov, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D59423?vs=

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert updated this revision to Diff 190866. jdoerfert marked an inline comment as done. jdoerfert added a comment. Fix the set/release use case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59424/new/ https://reviews.llvm.org/D59424 Files: o

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

jkorous added a comment. In D59377#1430002 , @dexonsmith wrote: > ... since I noticed that FileManager ... This kind of implies that we should move the comment from `FileManager` constructor implementation to the header thus making it an explicit part o

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, + bool RequiresOMPRuntime, j

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

CodaFi created this revision. CodaFi added reviewers: georgemorgan, mehdi_amini, kristina. Herald added subscribers: cfe-commits, jdoerfert, kristof.beyls, javed.absar, dberris. Herald added a project: clang. D33259 hard-coded a linker flag relative to a linker

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert marked an inline comment as done. jdoerfert added a comment. > What is this buffer used for? [...] I'll copy your comment and respond in this review D59424 . Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +///

[PATCH] D54395: [clang-tidy] implement utility-function to add 'const' to variables

JonasToth added a comment. ping :) Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54395/new/ https://reviews.llvm.org/D54395 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

jdoerfert updated this revision to Diff 190861. jdoerfert marked an inline comment as done. jdoerfert added a comment. Rebase onto D59424 and fix errors caused by the wrong use of ident_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D59424: [OpenMP][NVPTX] Replace void** buffer by byte-wise buffer

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added a project: OpenMP. This commit implements the existing void** buffer used to share arguments between threads in a team with a byte-wise buffer. For now, the void** buffer

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Comment at: clang/lib/Sema/SemaChecking.cpp:338 + case Builtin::BI__builtin___vsnprintf_chk: { +DiagID = diag::warn_memcpy

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added a comment. Looks very polished, thanks! Will have to sink the change in a bit, will come back with more comments on Monday. In the meantime, a few initial comments and suggestions. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:54 +/// bo

Re: r352930 - [WebAssembly] Add an import_field function attribute

On Fri, Mar 8, 2019 at 5:06 PM Aaron Ballman wrote: > > On Wed, Feb 6, 2019 at 12:43 AM Dan Gohman wrote: > > > > > > > > On Tue, Feb 5, 2019 at 11:20 AM Aaron Ballman > > wrote: > >> > >> On Fri, Feb 1, 2019 at 8:27 PM Dan Gohman wrote: > >> > > >> > > >> > Indeed, and the existing import_mo

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

jkorous added a comment. @ilya-biryukov could you please give details about the quality metric you are using and some description of posted measurements? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59300/new/ https://reviews.llvm.org/D59300 _

[PATCH] D59319: [OpenMP][Offloading][1/3] A generic and simple target region interface

ABataev added inline comments. Comment at: openmp/libomptarget/deviceRTLs/common/target_region.h:104 +/// +EXTERN int8_t __kmpc_target_region_kernel_init(ident_t *Ident, bool UseSPMDMode, + bool RequiresOMPRuntime, I

[PATCH] D45978: dllexport const variables must have external linkage.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D45978/new/ https://reviews.llvm.org/D45978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added a comment. I'll look more closely into the details, but just a high-level question now: why would we want to make this optional and not simply surface these extra diagnostics? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59302/

[PATCH] D59316: [HIP-Clang] propagate -mllvm options to opt and llc

This revision was automatically updated to reflect the committed changes. Closed by commit rC356277: [HIP-Clang] propagate -mllvm options to opt and llc (authored by aaronenyeshi, committed by ). Changed prior to commit: https://reviews.llvm.org/D59316?vs=190474&id=190850#toc Repository: rC

r356277 - [HIP-Clang] propagate -mllvm options to opt and llc

Author: aaronenyeshi Date: Fri Mar 15 10:31:51 2019 New Revision: 356277 URL: http://llvm.org/viewvc/llvm-project?rev=356277&view=rev Log: [HIP-Clang] propagate -mllvm options to opt and llc Change the HIP Toolchain to pass the OPT_mllvm options into OPT and LLC stages. Added a lit test to verif

[PATCH] D57855: [analyzer] Reimplement checker options

Szelethus planned changes to this revision. Szelethus marked 3 inline comments as done. Szelethus added a comment. Alright, I'll de-clutter this patch a bit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57855/new/ https://reviews.llvm.org/D57855 _

[PATCH] D59076: [coroutines][PR40978] Emit error for co_yield within catch block

GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59076/new/ https://reviews.llvm.org/D59076 ___ cfe-

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache added a comment. I realize this isn't the correct solution, but would any would-be reviewers like to comment on the problem? Whether it's here or on the Bugzilla report https://bugs.llvm.org/show_bug.cgi?id=39287, as a newcomer to Clang modules I could use some help understanding whet

[PATCH] D58673: [ASTImporter] Fix redecl failures of ClassTemplateSpec

shafik accepted this revision. shafik added a comment. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58673/new/ https://reviews.llvm.org/D58673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D59328: [OpenMP][Offloading][2/3] Codegen for target regions (TRegions)

jdoerfert updated this revision to Diff 190840. jdoerfert added a comment. Remove code extracted into separate commits, see D59418 , D59420 , and D59421 . Repository: rG LLVM Github Monorepo C

[PATCH] D59421: [OpenMP][Offloading] Allow to build the TRegion interface functions

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added projects: OpenMP, clang. This patch adds the TRegion interface functions to the ones we can build through the common OpenMP target offloading class. This is a preperation

[PATCH] D59420: [NFC][OpenMP] Move runtime function generation to the target codegen

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added projects: OpenMP, clang. jdoerfert added a parent revision: D59418: [OpenMP][Offloading] Extract common functionality. This commit simply moves the runtime function gener

[PATCH] D59418: [OpenMP][Offloading] Extract common functionality

jdoerfert created this revision. jdoerfert added reviewers: ABataev, arpith-jacob, guraypp, gtbercea, hfinkel. jdoerfert added a project: OpenMP. Herald added a project: clang. This patch introduces the CGOpenMPRuntimeTarget class to collect helpers and functionality common to all target offloadin

[PATCH] D59233: libclang/CIndexer.cpp: Use loadquery() on AIX for path to library

xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59233/new/ https://reviews.llvm.org/D59233 ___ cf

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

ikudrin created this revision. ikudrin added reviewers: ioeric, bkramer, hans, thakis, rsmith, zturner. Herald added a project: clang. This patch partially reverts D46942 . If the source file path contains directory junctions, and we resolve them when printing di

[PATCH] D59219: [PR41007][OpenCL] Allow printf and toolchain reserved variadic functions in C++

bader added a comment. > May be test/Driver/include-default-header.cl would make more sense to show > the intent? test/Headers/opencl-c-header.cl sounds like good candidate. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59219/new/ https://reviews.llvm.org/D59219

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

JonasToth added a comment. From my side its LGTM, but I would let @serge-sans-paille accept, as he is probably more familiar with python then I am. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56343/new/ https://reviews.llvm.org/D56343 __

[PATCH] D59296: [pp-trace] Delete -ignore and add generalized -callbacks

aaron.ballman added a comment. I think the release notes should be updated to mention that a previously-supported option has been removed and that there's a new option available as a replacement; I don't think we have any other docs for pp-trace to worry about updating, do we? ==

[PATCH] D59318: [clang-tidy] add an overload for diag method that allows users to provide a diagnostic name rather than using the check name when building a diagnostic.

JonasToth added a comment. What is the reason you want this change to happen? I think this gives the chance to create inconsistencies which we should avoid. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59318/new/ https://reviews.llvm.org/D59318

[clang-tools-extra] r356264 - [clangd] Remove includes of "gmock-matchers.h". NFC

Author: ibiryukov Date: Fri Mar 15 07:30:07 2019 New Revision: 356264 URL: http://llvm.org/viewvc/llvm-project?rev=356264&view=rev Log: [clangd] Remove includes of "gmock-matchers.h". NFC For consistency with most of the test code. Modified: clang-tools-extra/trunk/unittests/clangd/ExpectedT

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

aaron.ballman added inline comments. Comment at: clang-tools-extra/test/clang-tidy/google-runtime-int.m:1 +// RUN: clang-tidy -checks=-*,google-runtime-int %s 2>&1 -- -x objective-c | not grep 'warning:\|error:' + We typically use `| count 0` instead of an expli

[PATCH] D59300: [clangd] Tune the fuzzy-matching algorithm

This revision was automatically updated to reflect the committed changes. Closed by commit rL356261: [clangd] Tune the fuzzy-matching algorithm (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews

[clang-tools-extra] r356261 - [clangd] Tune the fuzzy-matching algorithm

Author: ibiryukov Date: Fri Mar 15 07:00:49 2019 New Revision: 356261 URL: http://llvm.org/viewvc/llvm-project?rev=356261&view=rev Log: [clangd] Tune the fuzzy-matching algorithm Summary: To reduce the gap between prefix and initialism matches. The motivation is producing better scoring in one p

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

serge-sans-paille created this revision. serge-sans-paille added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a warning is raised from the expansion of a system macro that involves pasted token, there was still situations were they were not skip

  1   2   >