[PATCH] D59135: Add check for matching HeaderFilter before emitting Diagnostic

lebedev.ri added a comment. In D59135#1422822 , @thorsten-klein wrote: > Sorry for delay. I am currently not able to build master (Error: "sort" is > not a member of "llvm"). > And if I try to build 6.0.1-rc3 I can build clang-tidy but I am not able to

[PATCH] D59578: [X86] Remove getCPUKindCanonicalName which seems to be unused.

craig.topper created this revision. craig.topper added a reviewer: erichkeane. Herald added a project: clang. Repository: rC Clang https://reviews.llvm.org/D59578 Files: lib/Basic/Targets/X86.cpp lib/Basic/Targets/X86.h Index: lib/Basic/Targets/X86.h =

r356537 - [X86] Separate PentiumPro and i686. They aren't aliases in the backend.

Author: ctopper Date: Wed Mar 20 00:31:18 2019 New Revision: 356537 URL: http://llvm.org/viewvc/llvm-project?rev=356537&view=rev Log: [X86] Separate PentiumPro and i686. They aren't aliases in the backend. PentiumPro has HasNOPL set in the backend. i686 does not. Despite having a function that l

[PATCH] D59567: [X86] Add __popcntd and __popcntq to ia32intrin.h to match gcc and icc. Remove popcnt feature flag from _popcnt32/_popcnt64 and move to ia32intrin.h to match gcc

RKSimon added a comment. IIRC we don't use libcalls for popcnt - we just expand Comment at: clang/lib/Headers/ia32intrin.h:35 +/// +/// This intrinsic corresponds to the POPCNT instruction. +/// Change this as we don't require POPCNT any more? CHANGES SINCE

[PATCH] D59354: [clangd] Print arguments in template specializations

ilya-biryukov added inline comments. Comment at: clang/lib/AST/TypePrinter.cpp:1635 +static void printArgument(const TemplateArgument &A, const PrintingPolicy &PP, + llvm::raw_ostream &OS) { ilya-biryukov wrote: > NIT: consider also add

[PATCH] D59354: [clangd] Print arguments in template specializations

kadircet updated this revision to Diff 191460. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59354/new/ https://reviews.llvm.org/D59354 Files: clang-tools-ex

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: unittests/AST/OMPStructuredBlockTest.cpp:64 +++i; +})"; + ASSERT_TRUE( Same comment as in the other patch -- I would prefer that the source is inlined into the ASSERT_TRUE, with implicit string concatenation and "\n"

r356541 - [clangd] Print arguments in template specializations

Author: kadircet Date: Wed Mar 20 02:43:38 2019 New Revision: 356541 URL: http://llvm.org/viewvc/llvm-project?rev=356541&view=rev Log: [clangd] Print arguments in template specializations Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differe

[clang-tools-extra] r356541 - [clangd] Print arguments in template specializations

Author: kadircet Date: Wed Mar 20 02:43:38 2019 New Revision: 356541 URL: http://llvm.org/viewvc/llvm-project?rev=356541&view=rev Log: [clangd] Print arguments in template specializations Reviewers: ilya-biryukov Subscribers: ioeric, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Differe

[PATCH] D59354: [clangd] Print arguments in template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rC356541: [clangd] Print arguments in template specializations (authored by kadircet, committed by ). Changed prior to commit: https://reviews.llvm.org/D59354?vs=191460&id=191462#toc Repository: rC Cla

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

klimek added a comment. In D55170#1432832 , @reuk wrote: > @klimek I agree that the rule is somewhat arbitrary. However, it's the style > rule of an established codebase with many users (I don't have a concrete > number, but the project has 1400 stars on

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

kadircet updated this revision to Diff 191465. kadircet marked an inline comment as done. kadircet added a comment. - Make limit a hardcoded value rather then a command line argument - Limit diags per include directive Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://rev

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

klimek added a comment. In D55170#1432929 , @MyDeveloperDay wrote: > > I don't think risk is what matters - in the end it's about cost, and cost > > is a very technical reason > > I'm really sorry I'm not trying to be difficult its just over the years I

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

klimek added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2546-2560 return Line.Type == LT_ObjCDecl || Left.is(tok::semi) || (Style.SpaceBeforeParens != FormatStyle::SBPO_Never && -(Left.isOneOf(tok::kw_if, tok::pp_elif, tok::kw_for, tok

r356543 - Fix -Wdocumentation warning. NFCI.

Author: rksimon Date: Wed Mar 20 03:28:08 2019 New Revision: 356543 URL: http://llvm.org/viewvc/llvm-project?rev=356543&view=rev Log: Fix -Wdocumentation warning. NFCI. Modified: cfe/trunk/include/clang/Tooling/FixIt.h Modified: cfe/trunk/include/clang/Tooling/FixIt.h URL: http://llvm.org/v

[PATCH] D59407: [clangd] Add RelationSlab

kadircet added a comment. In D59407#1432543 , @nridge wrote: > If it's (B), how many bytes should the index be? Are the space gains worth > the complexity, given that `SymbolID` is only 8 bytes to begin with? (As > compared to say, the filenames in `Ref`

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

klimek added inline comments. Comment at: include/clang/Basic/TokenKinds.h:80 K == tok::utf8_string_literal || K == tok::utf16_string_literal || - K == tok::utf32_string_literal; } This change looks pretty good, minus the changes outside Format

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

klimek added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:401 + * ``SIS_AlwaysNoElse`` (in configuration: ``AlwaysNoElse``) +Allow short if/else if statements even if the else is a compound statement. + I'd try to make this either unco

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: unittests/AST/OMPStructuredBlockTest.cpp:64 +++i; +})"; + ASSERT_TRUE( gribozavr wrote: > Same comment as in the other patch -- I would prefer that the source is > inlined into the ASSERT_TRUE, with implicit string

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

teemperor created this revision. teemperor added reviewers: balazske, martong. Herald added subscribers: cfe-commits, rnkovacs. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. `ASTImporter::Imported` currently returns a Decl, but that return valu

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

kadircet added a comment. Could you do a rebase? I've tried to land it but there are too many merge conflicts currently. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150 ___ cfe-commits mailing list

[clang-tools-extra] r356547 - [clang-tidy] Parallelize clang-tidy-diff.py

Author: zinovy.nis Date: Wed Mar 20 04:30:05 2019 New Revision: 356547 URL: http://llvm.org/viewvc/llvm-project?rev=356547&view=rev Log: [clang-tidy] Parallelize clang-tidy-diff.py This patch has 2 rationales: - large patches lead to long command lines and often cause max command line length re

[PATCH] D57662: [clang-tidy] Parallelize clang-tidy-diff.py

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356547: [clang-tidy] Parallelize clang-tidy-diff.py (authored by zinovy.nis, committed by ). Changed prior to commit: https://reviews.llvm.org/D57662?vs=189562&id=191474#toc Repository: rCTE Clang

[clang-tools-extra] r356548 - [clang-tidy] Cosmetic fix

Author: zinovy.nis Date: Wed Mar 20 04:34:29 2019 New Revision: 356548 URL: http://llvm.org/viewvc/llvm-project?rev=356548&view=rev Log: [clang-tidy] Cosmetic fix Differential Revision: https://reviews.llvm.org/D57662 Modified: clang-tools-extra/trunk/clang-tidy/tool/clang-tidy-diff.py Mod

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

rdwampler added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57687/new/ https://reviews.llvm.org/D57687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:436 +static void +AlignTokenSequenceAll(unsigned Start, unsigned End, unsigned Column, + F &&Matches, VelocityRa wrote: > klimek wrote: > > I don't think the 'All' pos

r356551 - Correct this attribute group documentation to have a heading, which fixes the docs builder.

Author: aaronballman Date: Wed Mar 20 04:58:38 2019 New Revision: 356551 URL: http://llvm.org/viewvc/llvm-project?rev=356551&view=rev Log: Correct this attribute group documentation to have a heading, which fixes the docs builder. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified

[PATCH] D59520: [WebAssembly] Address review comments on r352930

aaron.ballman added a comment. In D59520#1435728 , @sunfish wrote: > In D59520#1434854 , @aaron.ballman > wrote: > > > > Removes errnoneous use of diag::err_alias_is_definition, which turned out > > > to be ineffe

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr added inline comments. Comment at: unittests/AST/OMPStructuredBlockTest.cpp:64 +++i; +})"; + ASSERT_TRUE( lebedev.ri wrote: > gribozavr wrote: > > Same comment as in the other patch -- I would prefer that the source is > > inlined into the ASSERT_TRUE

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. I would prefer an observer-like solution but I am not against this change. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59595/new/ https://reviews.llvm.or

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

klimek added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:2976 + +return Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_None || + Style.AllowShortLambdasOnASingleLine == FormatStyle::SLS_Inline || If SLS_All is supposed

[PATCH] D59546: [clang-format] structured binding in range for detected as Objective C

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59546/new/ https://reviews.llvm.org/D59546 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

klimek added a comment. I don't understand yet why running clang-format locally would not do the same change? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54881/new/ https://reviews.llvm.org/D54881 ___ cfe-commits mailing list cfe-commits

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ioeric added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:33 +// If MergedSyms is provided, increments a symbols Reference count once for +// every file it was mentioned in. +void mergeRefs(llvm::ArrayRef> RefSlabs, nit: s/every file/

[clang-tools-extra] r356553 - Revert rL356547 : [clang-tidy] Cosmetic fix

Author: rksimon Date: Wed Mar 20 06:24:33 2019 New Revision: 356553 URL: http://llvm.org/viewvc/llvm-project?rev=356553&view=rev Log: Revert rL356547 : [clang-tidy] Cosmetic fix Differential Revision: https://reviews.llvm.org/D57662 [clang-tidy] Parallelize clang-tidy-diff.py This patch

[PATCH] D59560: Permit redeclarations of a builtin to specify calling convention.

erichkeane updated this revision to Diff 191483. erichkeane added a comment. Woops! Look like I left without actually changing the revision *shame*. Also, I was an idiot about SemaType, please disregard my previous comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59560/new/ http

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

mzeren-vmw added a comment. In D55170#1436087 , @klimek wrote: > Oh wow, wasn't aware how popular this is. Sigh. I'd like us to push them to > change their style guide, but I guess that's not going to fly. IDK. If the criteria is "public coding standard

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

reuk marked an inline comment as done. reuk added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2546-2560 return Line.Type == LT_ObjCDecl || Left.is(tok::semi) || (Style.SpaceBeforeParens != FormatStyle::SBPO_Never && -(Left.isOneOf(tok::

[PATCH] D59533: [X86] Add __crc32b/__crc32w/__crc32d/__crc32q intrinsics to match gcc and icc.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with one minor (doxygen desciptions) Comment at: lib/Headers/ia32intrin.h:58 +static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__, __target

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz added a comment. Is it because the diff was made with the svn repository? It is for the newest revision. Should I make a new diff with the git repo instead? Or is it not because of the diff, but something in phabricator instead? Sorry this is my first patch. CHANGES SINCE LAST ACTION h

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

klimek added inline comments. Comment at: lib/Format/TokenAnnotator.cpp:2546-2560 return Line.Type == LT_ObjCDecl || Left.is(tok::semi) || (Style.SpaceBeforeParens != FormatStyle::SBPO_Never && -(Left.isOneOf(tok::kw_if, tok::pp_elif, tok::kw_for, tok

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

kadircet added a comment. In D52150#1436278 , @to-miz wrote: > Is it because the diff was made with the svn repository? It is for the newest > revision. > Should I make a new diff with the git repo instead? > Or is it not because of the diff, but someth

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/Stmt.h:102 +/// This bit is set only for the Stmt's that are the structured-block +/// of OpeMP [non-standalone] executable directives. +/// I.e. those returned by OMPExecutableDirective::getStructuredBlo

[PATCH] D59481: [clangd] Count number of references while merging RefSlabs inside FileIndex

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:170 I.first->second = mergeSymbol(I.first->second, Sym); +// We re-count number of references while merging refs from scratch. +I.first->getSecond().References

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa updated this revision to Diff 191493. VelocityRa marked 13 inline comments as done. VelocityRa added a comment. Diff updated. Some comments about the inline changes, since the rest were trivial: - `AlignMacroSequence` was inlined - `AlignMacros` was after that - `AlignMacrosMatches` ca

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

VelocityRa added inline comments. Comment at: lib/Format/WhitespaceManager.cpp:500 +if (Changes[i].NewlinesBefore != 0) { + EndOfSequence = i; + // If there is a blank line, or if the last line didn't contain any klimek wrote: > VelocityRa wrote: >

[PATCH] D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ 🔓

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59336/new/ https://reviews.llvm.org/D59336

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/AST/Stmt.h:102 +/// This bit is set only for the Stmt's that are the structured-block +/// of OpeMP [non-standalone] executable di

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

ABataev accepted this revision. ABataev added a comment. LG for the OpenMP part Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59214/new/ https://reviews.llvm.org/D59214 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz added a comment. I checked out the git repository and applied the patch to head and reran all tests. The diff produced by git is basically the same, should I upload the new diff? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52150/new/ https://reviews.llvm.org/D52150

r356564 - [ASTImporter] Remove obsolete function ImportTemplateParameterList.

Author: balazske Date: Wed Mar 20 08:42:42 2019 New Revision: 356564 URL: http://llvm.org/viewvc/llvm-project?rev=356564&view=rev Log: [ASTImporter] Remove obsolete function ImportTemplateParameterList. Summary: The ASTNodeImporter::ImportTemplateParameterList is replaced by a template specializa

[PATCH] D59134: [ASTImporter] Remove obsolete function ImportTemplateParameterList.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356564: [ASTImporter] Remove obsolete function ImportTemplateParameterList. (authored by balazske, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

[PATCH] D58531: [clang] Specify type of pthread_create builtin

srhines added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:9574 - assert(!RequiresICE && "Result of intrinsic cannot be required to be an ICE"); + assert(!RequiresICE && "Result of function cannot be required to be an ICE"); I would just remov

[clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux.

Author: zinovy.nis Date: Wed Mar 20 08:50:26 2019 New Revision: 356565 URL: http://llvm.org/viewvc/llvm-project?rev=356565&view=rev Log: Reland r356547 after fixing the tests for Linux. [clang-tidy] Parallelize clang-tidy-diff.py This patch has 2 rationales: - large patches lead to long command

[PATCH] D59214: [clang][OpeMP] Model OpenMP structured-block in AST (PR40563)

lebedev.ri added inline comments. Comment at: include/clang/AST/Stmt.h:102 +/// This bit is set only for the Stmt's that are the structured-block +/// of OpeMP [non-standalone] executable directives. +/// I.e. those returned by OMPExecutableDirective::getStructuredBlo

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D59599 Files: clangd/AST.cpp unittests

[clang-tools-extra] r356567 - gn build: Add build files for some clang-tools-extra

Author: nico Date: Wed Mar 20 09:14:16 2019 New Revision: 356567 URL: http://llvm.org/viewvc/llvm-project?rev=356567&view=rev Log: gn build: Add build files for some clang-tools-extra Adds clang-change-namespace, clang-move, clang-query, clang-reorder-fields. Differential Revision: https://revie

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

martong accepted this revision. martong added a comment. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59595/new/ https://reviews.llvm.org/D59595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D59554: gn build: Add build files for some clang-tools-extra

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356567: gn build: Add build files for some clang-tools-extra (authored by nico, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://

[PATCH] D59306: [NFC][clang][astdump] Some baseline tests for OpenMP

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL356569: [NFC][clang][astdump] Some baseline tests for OpenMP (authored by lebedevri, committed by ). Herald added a projec

r356571 - [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint))

Author: asavonic Date: Wed Mar 20 09:43:07 2019 New Revision: 356571 URL: http://llvm.org/viewvc/llvm-project?rev=356571&view=rev Log: [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint)) Summary: [OpenCL] Generate 'unroll.enable' metadata for __attribute__((open

[PATCH] D59493: [OpenCL] Generate 'unroll.enable' metadata for __attribute__((opencl_unroll_hint))

This revision was automatically updated to reflect the committed changes. Closed by commit rC356571: [OpenCL] Generate 'unroll.enable' metadata for __attribute__… (authored by asavonic, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59493/new/ http

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:401 + * ``SIS_AlwaysNoElse`` (in configuration: ``AlwaysNoElse``) +Allow short if/else if statements even if the else is a compound state

[PATCH] D58404: [clang-format] Add basic support for formatting C# files

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: include/clang/Basic/TokenKinds.h:80 K == tok::utf8_string_literal || K == tok::utf16_string_literal || - K == tok::utf32_string_literal; } klimek

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clangd/AST.cpp:95 +} else { + // FIXME: Cls->getTypeAsWritten might return null in some cases, e.g. + // clang sees first sees a

r356575 - [clang-format] structured binding in range for detected as Objective C

Author: paulhoad Date: Wed Mar 20 10:10:23 2019 New Revision: 356575 URL: http://llvm.org/viewvc/llvm-project?rev=356575&view=rev Log: [clang-format] structured binding in range for detected as Objective C Summary: Sometime after 6.0.0 and the current trunk 9.0.0 the following code would be cons

[PATCH] D47849: [OpenMP][Clang][NVPTX] Enable math functions called in an OpenMP NVPTX target device region to be resolved as device-native function calls

tra added a comment. > This is, or is very similar to, the problem that the host/device overloading > addresses in CUDA. IIRC the difference was that OpenMP didn't have explicit notion of host/device functions which made it hard to apply host/device overloading in practice. > It is also the

[PATCH] D59546: [clang-format] structured binding in range for detected as Objective C

This revision was automatically updated to reflect the committed changes. Closed by commit rC356575: [clang-format] structured binding in range for detected as Objective C (authored by paulhoad, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D59

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

Anastasia created this revision. Anastasia added reviewers: svenvh, rjmccall. Herald added subscribers: jdoerfert, ebevhan, yaxunl. For backwards compatibility we should allow alternative spelling of address spaces - `private`, `local`, `global`, `constant`, `generic`. Note that in order to acce

r356577 - [AST] Disable ast-dump-openmp-parallel-master-XFAIL.c test

Author: lebedevri Date: Wed Mar 20 10:14:49 2019 New Revision: 356577 URL: http://llvm.org/viewvc/llvm-project?rev=356577&view=rev Log: [AST] Disable ast-dump-openmp-parallel-master-XFAIL.c test Fails on MSVC buildbot (but not locally). Not important as it is 'testing' something that isn't suppor

r356578 - [NFC][ASTMatchers] Alphabetically sort REGISTER_MATCHER() macros in RegistryMaps::RegistryMaps()

Author: lebedevri Date: Wed Mar 20 10:15:47 2019 New Revision: 356578 URL: http://llvm.org/viewvc/llvm-project?rev=356578&view=rev Log: [NFC][ASTMatchers] Alphabetically sort REGISTER_MATCHER() macros in RegistryMaps::RegistryMaps() As noted in https://reviews.llvm.org/D59453#inline-526253 Modi

[PATCH] D53705: [OpenCL] Postpone PSV address space diagnostic

Anastasia added a comment. Herald added a subscriber: ebevhan. Herald added a project: clang. Btw, I have created a patch that allows non-underscore prefixed spelling for address spaces in C++ for OpenCL: https://reviews.llvm.org/D59603 I assume the error becomes less critical however it remains

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:135 +// \endcode +class RewriteRule { +public: ymandel wrote: > ilya-biryukov wrote: > > Maybe consider separating the fluent API to build the rewrite rule from

r356580 - [X86] Remove getCPUKindCanonicalName which is unused.

Author: ctopper Date: Wed Mar 20 10:26:51 2019 New Revision: 356580 URL: http://llvm.org/viewvc/llvm-project?rev=356580&view=rev Log: [X86] Remove getCPUKindCanonicalName which is unused. Differential Revision: https://reviews.llvm.org/D59578 Modified: cfe/trunk/lib/Basic/Targets/X86.cpp

[PATCH] D59578: [X86] Remove getCPUKindCanonicalName which seems to be unused.

This revision was automatically updated to reflect the committed changes. Closed by commit rL356580: [X86] Remove getCPUKindCanonicalName which is unused. (authored by ctopper, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SI

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

MyDeveloperDay added a comment. In D52150#1436423 , @to-miz wrote: > I checked out the git repository and applied the patch to head and reran all > tests. > The diff produced by git is basically the same, should I upload the new diff? I think you might

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay updated this revision to Diff 191530. MyDeveloperDay added a comment. Addressing code review comment @klimek I think is what you meant, a much smaller and neater version of what I had before. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llv

[PATCH] D59605: [clangd] Introduce background-indexer

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, jdoerfert, erik.pilkington, arphaman, jkorous, MaskRay, ioeric, mgorny. Herald added a project: clang. Sample output: I[18:37:50.083] BackgroundIndex: build symbol index periodically e

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

MyDeveloperDay updated this revision to Diff 191536. MyDeveloperDay added a comment. Sorry for the spam: - write this a little better CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59309/new/ https://reviews.llvm.org/D59309 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests

[PATCH] D59605: [clangd] Introduce background-indexer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/background-indexer/BackgroundIndexer.cpp:13 + +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/clangd/Context.h" +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-e

[PATCH] D59302: [clangd] Surface diagnostics from headers inside main file

ilya-biryukov added a comment. Thanks for changes. A few more comments. Comment at: clangd/ClangdUnit.cpp:259 +// Generates a mapping from start of an include directive to its range. +std::map +positionToRangeMap(const std::vector &MainFileIncludes) { Could we

[PATCH] D59599: [clangd] Fix a crash while printing Template Arguments

Eugene.Zelenko added inline comments. Comment at: clangd/AST.cpp:86 else if (auto *Cls = llvm::dyn_cast(&ND)) { -if (auto STL = Cls->getTypeAsWritten() - ->getTypeLoc() - .getAs()) { - llvm::SmallVector ArgLocs; - ArgLo

[PATCH] D59605: [clangd] Introduce background-indexer

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/background-indexer/BackgroundIndexer.cpp:13 + +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-extra/clangd/Context.h" +#include "/usr/local/google/home/kadircet/repos/llvm/clang-tools-ex

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel marked 4 inline comments as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:135 +// \endcode +class RewriteRule { +public: ilya-biryukov wrote: > ymandel wrote: > > ilya-biryukov wrote: > > > Maybe co

[PATCH] D59605: [clangd] Introduce background-indexer

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clangd/index/Background.cpp:29 #include "llvm/Support/SHA1.h" #include Unnecessary empty line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D59279: [Analyzer] Checker for non-determinism caused by iteration of unordered container of pointers

mgrang added a comment. Ping for reviews please. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59279/new/ https://reviews.llvm.org/D59279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D56343: [clang-tidy] Refactor: Extract Class CheckRunner on check_clang_tidy.py

LegalizeAdulthood marked 9 inline comments as done. LegalizeAdulthood added inline comments. Comment at: test/clang-tidy/check_clang_tidy.py:112 +process_output = e.output.decode() +print('%s failed:\n%s' % (' '.join(args), process_output)) +if raise_error: --

[PATCH] D59605: [clangd] Introduce background-indexer

jkorous added inline comments. Comment at: clang-tools-extra/clangd/background-indexer/BackgroundIndexer.cpp:56 + // non-interactive tools like this one. + 24 * 60 * 60 * 1000); + llvm::SmallString<128> DummyFile(CompileCommandsDir); Nit: maybe we shou

[PATCH] D55170: [clang-format]: Add NonEmptyParentheses spacing option

MyDeveloperDay added a comment. > The cost is financial, as it's developer time, which costs real money to > companies. In the end, to support this, people like myself who are doing this > as part of their job spend time that they'd otherwise spend to make other > things better that might be mo

[PATCH] D52150: [clang-format] BeforeHash added to IndentPPDirectives

to-miz updated this revision to Diff 191540. to-miz added a comment. Made a new diff on the git repository, since the docs now recommend using git. Rebased and created a new diff with `git show HEAD -U99`. The patch applies cleanly on windows after `git reset --hard` so I hope there shouldn't

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

arsenm added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:397 +def ext_pp_opencl_variadic_macros : Extension< + "variadic macros not supported in OpenCL">; Maybe rephrase the message now to say it's an extension? The other similar wa

[clang-tools-extra] r356589 - [clang-tidy] Fix redundant check breaking the test on many platforms.

Author: zinovy.nis Date: Wed Mar 20 11:37:04 2019 New Revision: 356589 URL: http://llvm.org/viewvc/llvm-project?rev=356589&view=rev Log: [clang-tidy] Fix redundant check breaking the test on many platforms. Differential Revision: https://reviews.llvm.org/D57662 Modified: clang-tools-extra/t

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

keryell added a comment. I was a little bit worried about struct top_level { int i; }; private ::top_level a; but it should be fine because in that case we have a `tok::coloncolon` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603 _

[PATCH] D59595: Remove the unused return value in ASTImporter::Imported [NFC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL356592: Remove the unused return value in ASTImporter::Imported [NFC] (authored by teemperor, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

r356592 - Remove the unused return value in ASTImporter::Imported [NFC]

Author: teemperor Date: Wed Mar 20 12:00:25 2019 New Revision: 356592 URL: http://llvm.org/viewvc/llvm-project?rev=356592&view=rev Log: Remove the unused return value in ASTImporter::Imported [NFC] Summary: `ASTImporter::Imported` currently returns a Decl, but that return value is not used by th

RE: [clang-tools-extra] r356565 - Reland r356547 after fixing the tests for Linux.

Hi Zinovy, The test you modified is still failing on the PS4 linux bot after your change: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/45557 FAIL: Clang Tools :: clang-tidy/clang-tidy-diff.cpp (14410 of 47824) TEST 'Clang Tools :: clang

r356598 - Recommit "Support attribute used in member funcs of class templates"

Author: rafauler Date: Wed Mar 20 12:22:24 2019 New Revision: 356598 URL: http://llvm.org/viewvc/llvm-project?rev=356598&view=rev Log: Recommit "Support attribute used in member funcs of class templates" This diff previously exposed a bug in LLVM's IRLinker, breaking buildbots that tried to self-

r356599 - [Sema] Deduplicate some availability checking logic

Author: epilk Date: Wed Mar 20 12:26:33 2019 New Revision: 356599 URL: http://llvm.org/viewvc/llvm-project?rev=356599&view=rev Log: [Sema] Deduplicate some availability checking logic Before this commit, we emit unavailable errors for calls to functions during overload resolution, and for referen

r356600 - Add a __has_extension check for '#pragma clang attribute' as an external-declaration

Author: epilk Date: Wed Mar 20 12:26:37 2019 New Revision: 356600 URL: http://llvm.org/viewvc/llvm-project?rev=356600&view=rev Log: Add a __has_extension check for '#pragma clang attribute' as an external-declaration This was added in r356075. Modified: cfe/trunk/include/clang/Basic/Feature

[PATCH] D59394: [Sema] De-duplicate some availability checking logic

This revision was automatically updated to reflect the committed changes. Closed by commit rL356599: [Sema] Deduplicate some availability checking logic (authored by epilk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

  1   2   >