[PATCH] D59863: [HIP] Support gpu arch gfx906+sram-ecc

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added a subscriber: jholewinski. Add a new gpu arch gfx906+sram-ecc for HIP. It is similar to gfx906 but implies target feature sram-ecc enabled, whereas gfx906 implies target sram-ecc disabled. Corresponding option

Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

I’m familiar with this issue as I had to fix a memory bug in LLVM IRLinker that was exposed by this commit. That’s why I initially reverted it. However, after fixing it, I was able to do the full clang LTO self-hosting with lld on Linux. Is there any way I can repro this issue? It’s probably a

Re: r356598 - Recommit "Support attribute used in member funcs of class templates"

On Wed, Mar 20, 2019 at 12:21 PM Rafael Auler via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rafauler > Date: Wed Mar 20 12:22:24 2019 > New Revision: 356598 > > URL: http://llvm.org/viewvc/llvm-project?rev=356598=rev > Log: > Recommit "Support attribute used in member funcs of

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

NoQ added a comment. Hi, i wanted to squeeze in D59861 somewhere in the middle of your work, would you mind? I'll definitely have a look at your patches soon :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/ https://reviews.llvm.org/D59516

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

NoQ added a comment. (whoops sry nvm typo in reviewer list) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59861/new/ https://reviews.llvm.org/D59861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59861: [analyzer] NFC: Replace Taint API with a usual inter-checker communication API?

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso, alexfh. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet, mgorny. Herald added a project: clang. Given how

Buildbot numbers for the week of 03/17/2019 - 03/23/2019

Hello everyone, Below are some buildbot numbers for the last week of 03/17/2019 - 03/23/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 03/10/2019 - 03/16/2019

Hello everyone, Below are some buildbot numbers for the week of 03/10/2019 - 03/16/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D59859: [clang-tidy] FIXIT for implicit bool conversion now obeys upper case suffixes if enforced.

pnappa created this revision. pnappa added a reviewer: lebedev.ri. pnappa added a project: clang-tools-extra. Herald added subscribers: cfe-commits, jdoerfert, xazax.hun. Herald added a project: clang. Fix for https://bugs.llvm.org/show_bug.cgi?id=41199#c1 Previously, if a user implicitly cast

[PATCH] D59725: Additions to creduce script

george.burgess.iv added a comment. Only a few more nits on my side, and this LGTM. WDYT, arichardson? Comment at: clang/utils/creduce-clang-crash.py:137 + +# If no message was found, use the top five stack trace functions, +# ignoring some common functions

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 192394. axzhang added a comment. Add documentation about the added option for `modernize-make-unique`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp

[PATCH] D59857: [analyzer] PR37501: Disable the assertion for reverse-engineering logical op short circuits.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso, alexfh. Herald added subscribers: cfe-commits, jdoerfert, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Replace the

[PATCH] D59407: [clangd] Add RelationSlab

nridge added a comment. Ok, cool. In that case, I think this patch is ready to be committed, and would appreciate it if someone could commit it. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407

[PATCH] D59407: [clangd] Add RelationSlab

gribozavr added a comment. Submitting code as it becomes ready is the usual practice here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59407/new/ https://reviews.llvm.org/D59407 ___ cfe-commits

[PATCH] D59838: gn build: Add build files for clang-include-fixer and find-all-symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rL357042: gn build: Add build files for clang-include-fixer and find-all-symbols (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D59838?vs=192334=192387#toc

[PATCH] D59407: [clangd] Add RelationSlab

nridge added a comment. As this is the first of a series of patches adding support for relations, and then building type hierarchy subtypes on top (as discussed here ), how should we go about landing this -- should we land each patch in the series as

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

erik.pilkington closed this revision. erik.pilkington added a comment. Landed in r357040. (I forgot to write Differential revision:!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59670/new/ https://reviews.llvm.org/D59670 ___ cfe-commits

r357040 - [Sema] Fix an assert when a block captures a constexpr local

Author: epilk Date: Tue Mar 26 16:21:19 2019 New Revision: 357040 URL: http://llvm.org/viewvc/llvm-project?rev=357040=rev Log: [Sema] Fix an assert when a block captures a constexpr local MarkVarDeclODRUsed indirectly calls captureInBlock, which creates a copy expression. The copy expression is

r357041 - Emit -Wfortify-source using DiagRuntimeBehaviour

Author: epilk Date: Tue Mar 26 16:21:22 2019 New Revision: 357041 URL: http://llvm.org/viewvc/llvm-project?rev=357041=rev Log: Emit -Wfortify-source using DiagRuntimeBehaviour This fixes a false positive on the following, where st is configured to have different sizes based on some preprocessor

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

erik.pilkington added a comment. In D58797#1443411 , @efriedma wrote: > For that particular case, I think we could suppress the false positive using > DiagRuntimeBehavior. How many total false positives are we talking about, > and how many can the

[PATCH] D59516: [analyzer] Add custom filter functions for GenericTaintChecker

boga95 added a comment. I add a new taint type, which represents a lack of taintedness. That's why I changed the name of `addTaint()` to `setTaint()`. Of course, it's not an important change, I can move it to another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59516/new/

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker updated this revision to Diff 192384. lewissbaker added a comment. Added missing 'require coroutines' for experimental/task entry in module.modulemap Added missing #include in experimental/task header that was failing module builds Repository: rCXX libc++ CHANGES SINCE LAST

[PATCH] D46140: [coroutines] Add std::experimental::task type

lewissbaker reopened this revision. lewissbaker added a comment. This revision is now accepted and ready to land. Reopening as the commit for this diff was reverted due to it breaking the buildbot module builds. Repository: rCXX libc++ CHANGES SINCE LAST ACTION

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192383. stephanemoore added a comment. Update tests to match updated diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/ https://reviews.llvm.org/D59806 Files:

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Cool! I have found this message-semantic idea useful in Unity where every `GameObject` could talk with each other in a very generic way

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

rjmccall added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:7274 +// Classrefs pointing at Objective-C stub classes have the least +// significant bit set to 1. +auto *Tag = llvm::ConstantInt::get(CGM.IntPtrTy, 1); slavapestov

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov updated this revision to Diff 192378. slavapestov marked 2 inline comments as done. slavapestov added a comment. Second revision adds the following: - Validation of the attribute in Sema - Sema tests for the above - Correct behavior of super method calls of a class with the attribute

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore marked 2 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:110 + "invoke a superclass initializer?") + << Message->getMethodDecl() + <<

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

slavapestov marked 11 inline comments as done. slavapestov added a comment. Thanks for the comments everyone. In the next version of the patch, I fixed most of the review feedback and also addressed an issue where super message sends were not calling `objc_loadClassRef()`.

[PATCH] D59388: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

dexonsmith closed this revision. dexonsmith added a comment. Committed r357038. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59388/new/ https://reviews.llvm.org/D59388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r357038 - Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:32:06 2019 New Revision: 357038 URL: http://llvm.org/viewvc/llvm-project?rev=357038=rev Log: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC FileManager constructs a VFS in its constructor if it isn't passed one, and there's no way to

[clang-tools-extra] r357038 - Basic: Return a reference from FileManager::getVirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:32:06 2019 New Revision: 357038 URL: http://llvm.org/viewvc/llvm-project?rev=357038=rev Log: Basic: Return a reference from FileManager::getVirtualFileSystem, NFC FileManager constructs a VFS in its constructor if it isn't passed one, and there's no way to

[PATCH] D58367: [analyzer] NFC: Improve upon the concept of BugReporterVisitor.

NoQ updated this revision to Diff 192372. NoQ marked 6 inline comments as done. NoQ added a comment. Remove memoization for now. Address a few inline comments. I'm mostly done with this first patch, did i accidentally miss anything? In D58367#1402796 ,

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore marked 2 inline comments as done. stephanemoore added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:113 + + Finds invocations of `-self` on super instances in initializers of subclasses + of `NSObject` and recommends calling a superclass

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192373. stephanemoore added a comment. Use double backticks rather than single backticks for symbols in documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/

[PATCH] D59377: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

dexonsmith closed this revision. dexonsmith added a comment. Committed r357037. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59377/new/ https://reviews.llvm.org/D59377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] r357037 - Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:18:52 2019 New Revision: 357037 URL: http://llvm.org/viewvc/llvm-project?rev=357037=rev Log: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC Remove CompilerInstance::VirtualFileSystem and CompilerInstance::setVirtualFileSystem, instead relying on

r357037 - Frontend: Remove CompilerInstance::VirtualFileSystem, NFC

Author: dexonsmith Date: Tue Mar 26 15:18:52 2019 New Revision: 357037 URL: http://llvm.org/viewvc/llvm-project?rev=357037=rev Log: Frontend: Remove CompilerInstance::VirtualFileSystem, NFC Remove CompilerInstance::VirtualFileSystem and CompilerInstance::setVirtualFileSystem, instead relying on

r357036 - [cmake] Reset variable before using it

Author: smeenai Date: Tue Mar 26 15:16:53 2019 New Revision: 357036 URL: http://llvm.org/viewvc/llvm-project?rev=357036=rev Log: [cmake] Reset variable before using it A bunch of macros use the same variable name, and since CMake macros don't get their own scope, the value persists across macro

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda updated this revision to Diff 192370. hintonda added a comment. - Address additional comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files:

[PATCH] D58236: Make address space conversions a bit stricter.

rjmccall added a comment. In D58236#1443556 , @ebevhan wrote: > In D58236#1443082 , @rjmccall wrote: > > > I think C probably requires us to allow this under an explicit cast, but we > > can at least warn about

[PATCH] D59628: Add support for __attribute__((objc_class_stub))

jordan_rose added inline comments. Comment at: lib/CodeGen/CGObjCMac.cpp:7285 -Entry = new llvm::GlobalVariable(CGM.getModule(), ObjCTypes.ClassnfABIPtrTy, +Entry = new llvm::GlobalVariable(CGM.getModule(), ClassGV->getType(),

[PATCH] D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it

JDevlieghere added inline comments. Comment at: lib/AST/ASTImporter.cpp:1951 + // something we're trying to import while completin ToEnum + Decl *ToOrigin = Importer.GetOriginalDecl(ToEnum); + ``` if (Decl *ToOrigin = Importer.GetOriginalDecl(ToEnum)) if

[PATCH] D59838: gn build: Add build files for clang-include-fixer and find-all-symbols

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59838/new/ https://reviews.llvm.org/D59838 ___ cfe-commits mailing list

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith added a comment. Okay if we change the flag then I believe the tests under llvm/tests/lib/DebugInfo/CodeView must be updated. If we use NonTrivial all the existing tests work as expected. LLVM change is here (you are all reviewers). https://reviews.llvm.org/D59348 Repository: rC

[PATCH] D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it

shafik added a comment. LLDB regression test that goes with this fix: https://reviews.llvm.org/D59847 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59845/new/ https://reviews.llvm.org/D59845 ___ cfe-commits mailing list

r357031 - Make -mno-outline pass -enable-machine-outliner=never to ld in LTO

Author: paquette Date: Tue Mar 26 14:22:42 2019 New Revision: 357031 URL: http://llvm.org/viewvc/llvm-project?rev=357031=rev Log: Make -mno-outline pass -enable-machine-outliner=never to ld in LTO Since AArch64 has default outlining behaviour, we need to make sure that -mno-outline is actually

[PATCH] D59845: Fix IsStructuralMatch specialization for EnumDecl to prevent re-importing an EnumDecl while trying to complete it

shafik created this revision. shafik added reviewers: martong, teemperor, friss, a_sidorin. Herald added subscribers: jdoerfert, rnkovacs. We may try and re-import an EnumDecl while trying to complete it in `IsStructuralMatch(...)` specialization for `EnumDecl`. This change mirrors a similar

[PATCH] D59841: [Gnu Driver] If -pie and -static-pie are both passed, let -static-pie win.

saugustine added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:311 if (Args.hasArg(options::OPT_shared) || Args.hasArg(options::OPT_static) || - Args.hasArg(options::OPT_r)) + Args.hasArg(options::OPT_r) || Args.hasArg(options::OPT_static_pie))

[PATCH] D59603: [PR40707][PR41011][OpenCL] Allow addr space spelling without double underscore in C++ mode

jsji added a comment. Looks like this may cause some unexpected failures. See https://bugs.llvm.org/show_bug.cgi?id=41247 for more details. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59603/new/ https://reviews.llvm.org/D59603

[PATCH] D59725: Additions to creduce script

akhuang updated this revision to Diff 192350. akhuang marked 2 inline comments as done. akhuang added a comment. Herald added a subscriber: jdoerfert. added to error message regexes and command line flags CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59725/new/

[PATCH] D59725: Additions to creduce script

akhuang marked 8 inline comments as done. akhuang added inline comments. Comment at: clang/utils/creduce-clang-crash.py:145 + matches = re.findall(stacktrace_re, crash_output) + result = filter(lambda x: x and x.strip() not in filters, matches)[:5] + for msg in

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda added a comment. In D59802#1443527 , @aaron.ballman wrote: > Would it make sense to transform `if (dyn_cast_or_null(Obj))` into `if > (Obj && isa(Obj))` or are there bad transformations from that? Sure, that sounds reasonable. I only see

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

george.burgess.iv added a comment. (Forgot to refresh before pressing 'Submit', so maybe efriedma's comment answers all of the questions in mine ;) ) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58797/new/ https://reviews.llvm.org/D58797

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

george.burgess.iv added a comment. We have warnings like -Wdivision-by-zero that take reachability into account: https://godbolt.org/z/3PD-eF. I don't immediately know how it's all done (e.g. in batch because CFG construction is expensive? ...), but looking there for inspiration may be useful.

[PATCH] D59841: [Gnu Driver] Is -pie and -static-pie are both passed, let -static-pie win.

sivachandra created this revision. sivachandra added a reviewer: saugustine. Herald added a project: clang. Herald added a subscriber: cfe-commits. A static-pie binary is a PIE after all, so letting -static-pie win makes the resulting binary statically linked as well as being a PIE. Repository:

[PATCH] D58236: Make address space conversions a bit stricter.

ebevhan added a comment. In D58236#1443082 , @rjmccall wrote: > I think C probably requires us to allow this under an explicit cast, but we > can at least warn about it. It does not require us to allow this as an > implicit conversion, and that should

[PATCH] D57687: [clang-format] Add style option AllowShortLambdasOnASingleLine

This revision was automatically updated to reflect the committed changes. Closed by commit rL357027: [clang-format] Add style option AllowShortLambdasOnASingleLine (authored by rdwampler, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r357027 - [clang-format] Add style option AllowShortLambdasOnASingleLine

Author: rdwampler Date: Tue Mar 26 13:18:14 2019 New Revision: 357027 URL: http://llvm.org/viewvc/llvm-project?rev=357027=rev Log: [clang-format] Add style option AllowShortLambdasOnASingleLine Summary: This option `AllowShortLambdasOnASingleLine` similar to the other `AllowShort*` options, but

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

aaron.ballman added a comment. In D59802#1443515 , @hintonda wrote: > In D59802#1443451 , @hintonda wrote: > > > In D59802#1443340 , @aaron.ballman > > wrote: > > > > >

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda added a comment. In D59802#1443451 , @hintonda wrote: > In D59802#1443340 , @aaron.ballman > wrote: > > > Should this check also try to find this pattern: > > > > if (dyn_cast(Bobble)) > > ... > > >

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:113 + + Finds invocations of `-self` on super instances in initializers of subclasses + of `NSObject` and recommends calling a superclass initializer instead. Please use

[PATCH] D59838: gn build: Add build files for clang-include-fixer and find-all-symbols

thakis created this revision. thakis added a reviewer: mbonadei. Herald added a project: LLVM. (Not adding a build file for clang-include-fixer/plugin yet.) https://reviews.llvm.org/D59838 Files: llvm/utils/gn/secondary/BUILD.gn

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda added a comment. In D59802#1443340 , @aaron.ballman wrote: > Should this check also try to find this pattern: > > if (dyn_cast(Bobble)) > ... > > > in order to recommend the proper replacement: > > if (isa(Bobble)) > ... > > > I ask

[PATCH] D59646: [PR40778][PR41157][OpenCL] Prevent implicit initialization of local address space objects

rjmccall added inline comments. Comment at: lib/Sema/SemaDecl.cpp:11648-11651 +// In OpenCL we don't allow to initialize objects in local address space. +if (getLangOpts().OpenCL && +Var->getType().getAddressSpace() == LangAS::opencl_local) + return;

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:57 +/// \endcode +AST_MATCHER_P(ObjCImplementationDecl, isSubclassOf, + ast_matchers::internal::Matcher, aaron.ballman wrote: > This matcher seems

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192317. stephanemoore added a comment. Enclose -self in backticks in check documentation (overlooked in previous attempt). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59806/new/

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192316. stephanemoore marked an inline comment as done. stephanemoore added a comment. Enclose -self in backticks in release notes and check documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192315. stephanemoore marked 5 inline comments as done. stephanemoore added a comment. Fix diagnostic format string to actually use the message's method declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

efriedma added a comment. For that particular case, I think we could suppress the false positive using DiagRuntimeBehavior. How many total false positives are we talking about, and how many can the compiler statically prove are unreachable? Repository: rC Clang CHANGES SINCE LAST ACTION

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

stephanemoore updated this revision to Diff 192312. stephanemoore added a comment. Removed usage of `auto` with a nonobvious type in isSubclassOf matcher. Added backticks around `NSObject` in docs. Synchronized check description in release notes and check documentation. Repository: rG LLVM

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:57 +/// \endcode +AST_MATCHER_P(ObjCImplementationDecl, isSubclassOf, + ast_matchers::internal::Matcher, This matcher seems like it would be

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/llvm-avoid-cast-in-conditional.rst:8 +statements which will assert on failure in Debug builds. The use of +cast<> implies that the operation cannot fail, and should not be used +as the

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

aaron.ballman added a comment. Should this check also try to find this pattern: if (dyn_cast(Bobble)) ... in order to recommend the proper replacement: if (isa(Bobble)) ... I ask because the name `llvm-avoid-cast-in-conditional` sounds like it would also cover this situation and

[PATCH] D58797: [Sema] Add some compile time _FORTIFY_SOURCE diagnostics

aaron.ballman added a comment. In D58797#1439888 , @erik.pilkington wrote: > Ah, I didn't consider that case. Presumably `st` is configured to have > different sizes based on the target? I agree that this is a false-positive, > but it seems like a

[PATCH] D58659: [Sema] Fix assertion when `auto` parameter in lambda has an attribute.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/lib/Sema/SemaType.cpp:261 +/// necessary. +QualType ReplaceAutoType(QualType TypeWithAuto, QualType Replacement) { +

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

rjmccall accepted this revision. rjmccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaExpr.cpp:15692 + MaybeODRUseExprSet LocalMaybeODRUseExprs; + std::swap(LocalMaybeODRUseExprs, MaybeODRUseExprs); +

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

erik.pilkington added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15692 + MaybeODRUseExprSet LocalMaybeODRUseExprs; + std::swap(LocalMaybeODRUseExprs, MaybeODRUseExprs); + rjmccall wrote: > It looks like `SmallPtrSet`'s move constructor does

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

erik.pilkington updated this revision to Diff 192300. erik.pilkington marked an inline comment as done. erik.pilkington added a comment. Add an assert. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59670/new/ https://reviews.llvm.org/D59670 Files: clang/include/clang/Sema/Sema.h

[PATCH] D59492: [OpenCL] Allow variadic macros as Clang feature

Anastasia closed this revision. Anastasia added a comment. Committed in r356987. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59492/new/ https://reviews.llvm.org/D59492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56160: [clang-tidy] modernize-use-trailing-return-type check

aaron.ballman added inline comments. Comment at: clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp:274 + + if (F->getLocation().isInvalid()) +return; bernhardmgruber wrote: > aaron.ballman wrote: > > bernhardmgruber wrote: > > > aaron.ballman wrote: > > >

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid updated this revision to Diff 192297. zbrid added a comment. Herald added a subscriber: jsji. update whitespace in wasm file to match surrounding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59827/new/ https://reviews.llvm.org/D59827

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

aheejin added inline comments. Comment at: clang/test/Preprocessor/init.c:9678 // WEBASSEMBLY-NEXT:#define __GXX_ABI_VERSION 1002 +// WEBASSEMBLY-NEXT: #define __HAVE_SPECULATION_SAFE_VALUE 1 // WEBASSEMBLY32-NEXT:#define __ILP32__ 1 Nit: Remove the whitespace

[PATCH] D59827: [slh] x86 impl of ARM instrinsic for SLH

zbrid created this revision. zbrid added reviewers: chandlerc, kristof.beyls, aaron.ballman, devinj.jeanpierre. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jfb, aheejin, hiraditya, javed.absar, dschuff. Herald added projects: clang, LLVM. This is similar to the work Kristof

[PATCH] D46140: [coroutines] Add std::experimental::task type

modocache closed this revision. modocache added a comment. Committed in rL357010 . Apologies, I forgot to include the differential revision in the commit message so this diff wasn't closed automatically as a result. I'll comment on rL357010

[PATCH] D58091: Customize warnings for missing built-in type

bcain added a comment. In D58091#1397586 , @jyknight wrote: > I think this warning (-Wbuiltin-requires-header) doesn't really make sense as > its own warning. > > We already have two related (on-by-default) warnings. ... In D58091#1414250

[PATCH] D59665: Call to HandleNameConflict in VisitEnumDecl mistakeningly using Name instead of SearchName

shafik marked an inline comment as done. shafik added a comment. In D59665#1442826 , @martong wrote: > In D59665#1442328 , @shafik wrote: > > > @martong your idea does not work b/c default construction > >

[PATCH] D59467: [clang] Adding the Likely Attribute from C++2a to AST

Tyker added a comment. @lebedev.ri where are tests for AST serialization are located ? i didn't find them. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 ___ cfe-commits mailing list

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:61 + // Check if any of the superclasses of the class match. + for (const auto *SuperClass = Node.getClassInterface()->getSuperClass(); + SuperClass != nullptr;

[PATCH] D58236: Make address space conversions a bit stricter.

rjmccall added a comment. I think C probably requires us to allow this under an explicit cast, but we can at least warn about it. It does not require us to allow this as an implicit conversion, and that should be an error. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58236/new/

r357001 - [CodeGen] Delete never used LValueAlign

Author: maskray Date: Tue Mar 26 08:39:45 2019 New Revision: 357001 URL: http://llvm.org/viewvc/llvm-project?rev=357001=rev Log: [CodeGen] Delete never used LValueAlign It was added by rC176658 but never used since then. Modified: cfe/trunk/lib/CodeGen/CGAtomic.cpp Modified:

[PATCH] D54978: Move the SMT API to LLVM

aprantl added a comment. Thanks! The problem with these methods is that LLVM_DUMP_METHOD forces the function to be emitted even if it is not used and Clang modules without local submodule visibility will implicitly include all header files in a module, which will then cause the missing symbol

[PATCH] D59426: [PR41010][OpenCL] Allow OpenCL C style vector initialization in C++

rjmccall added a reviewer: rsmith. rjmccall added inline comments. Comment at: lib/Sema/SemaInit.cpp:1295 +? InitializedEntity::InitializeTemporary(ElemType) +: Entity; + There should at least be a comment here explaining this, but mostly

[PATCH] D59670: [Sema] Fix an assert when a block captures a constexpr local

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:15692 + MaybeODRUseExprSet LocalMaybeODRUseExprs; + std::swap(LocalMaybeODRUseExprs, MaybeODRUseExprs); + It looks like `SmallPtrSet`'s move constructor does actually guarantee to leave

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

takuto.ikuta added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1352 + + llvm::TimeTraceScope TimeScope("Backend", StringRef("")); + We don't need explicit StringRef constructor call here. Just passing "" is enough. Comment

[PATCH] D59008: [AMDGPU] Switch default dwarf version to 5

dblaikie added a comment. In D59008#1442962 , @probinson wrote: > In D59008#1442515 , @dblaikie wrote: > > > In D59008#1442256 , @t-tye wrote: > > > > > In D59008#1442014

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

dblaikie added a comment. @asmith: Where's the LLVM-side change/review that goes with this, btw? In D59347#1442970 , @probinson wrote: > As a rule I would prefer flags with positive names, as it's slightly easier > to read `!isTrivial` than

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. In D54978#1442493 , @aprantl wrote: > I'm afraid this broke some bots that build with `LLVM_ENABLE_MODULES=1`. > > For example: > >

[PATCH] D57858: [analyzer] Add a new frontend flag to display all checker options

dkrupp added a comment. @dcoughlin I don't necessarily agree with you. Let me explain why we think this feature is important. We should give the users the possibility to list all possibly configurable checker options and their meaning. Many of these options should be possible to be set by the

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

probinson added a comment. As a rule I would prefer flags with positive names, as it's slightly easier to read `!isTrivial` than `!isNonTrivial`. And trivially shorter. :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347

  1   2   >