r357452 - SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)

Author: hans Date: Tue Apr 2 01:01:38 2019 New Revision: 357452 URL: http://llvm.org/viewvc/llvm-project?rev=357452&view=rev Log: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259) The code was previously checking that candidates for sinking had

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Looks great, thanks! Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:110 + // constructed with the builder class. + static constexpr char Ro

Re: [clang-tools-extra] r357429 - Fix clangd unittest _WIN32 ifdef

Thanks for fixing this! On Mon, Apr 1, 2019 at 11:14 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Apr 1 14:16:17 2019 > New Revision: 357429 > > URL: http://llvm.org/viewvc/llvm-project?rev=357429&view=rev > Log: > Fix clangd unittest _WIN32 ifd

[clang-tools-extra] r357454 - [clangd] Use capacity() instead of size() in RefSlab::bytes()

Author: ibiryukov Date: Tue Apr 2 01:24:37 2019 New Revision: 357454 URL: http://llvm.org/viewvc/llvm-project?rev=357454&view=rev Log: [clangd] Use capacity() instead of size() in RefSlab::bytes() Patch by Nathan Ridge. Reviewers: gribozavr Reviewed By: gribozavr Subscribers: ilya-biryukov, i

[PATCH] D60040: [clangd] Use capacity() instead of size() in RefSlab::bytes()

This revision was automatically updated to reflect the committed changes. Closed by commit rL357454: [clangd] Use capacity() instead of size() in RefSlab::bytes() (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

MarinaKalashina created this revision. MarinaKalashina added reviewers: djasper, sylvestre.ledru, alexfh. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. This commit adds a chapter 'CLion integration' to ClangFormat.rst. The official announcement of clang-format s

[PATCH] D60115: Adding 'CLion integration' to clang-format doc

sylvestre.ledru added inline comments. Comment at: docs/ClangFormat.rst:171 + +:program:`clang-format` is integrated into CLion as an alternative code +formatter. It is disabled by default and can be turned on in Maybe add a link to CLion here? I didn't know what

[PATCH] D58573: [analyzer] Move UninitializedObject out of alpha

Szelethus added a comment. One heuristic that we could use is to ignore inherited data members optionally. Does that sound any good? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58573/new/ https://reviews.llvm.org/D58573 _

[PATCH] D31417: [OpenMP] Add support for omp simd pragmas without runtime

huntergr abandoned this revision. huntergr added a comment. In D31417#1450587 , @xtian wrote: > LGTM. This provides a consistent behavior same as GCC and ICC w/ > -fopenmp-simd option. To answer, Kelvin's question. it is not directly tied > with "target

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

ilya-biryukov added a comment. Will address the rest of the comments later, answering a few questions that popped up first. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:72 + /// macro or a name, arguments and parentheses of a function-like macro. + llvm::Arra

[PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

uabelho added a comment. Hi, I noticed that with this commit I get a whole bunch (~40) of warnings like the below when compiling with gcc 7.4: [10/16] Building CXX object tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/clangTidyUtils.dir/HeaderGuard.cpp.o In file included from ../tool

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong marked 2 inline comments as done. martong added inline comments. Comment at: lib/AST/ASTImporter.cpp:2154 +return NameOrErr.takeError(); } } a_sidorin wrote: > Should we write `else Name = *NameOrError`? Atm, we implement the simplest stra

Re: [PATCH] D59528: [clang-tidy] Expand modular headers for PPCallbacks

On Tue, Apr 2, 2019 at 10:53 AM Mikael Holmén via Phabricator < revi...@reviews.llvm.org> wrote: > uabelho added a comment. > > Hi, > > I noticed that with this commit I get a whole bunch (~40) of warnings like > the below when compiling with gcc 7.4: > > [10/16] Building CXX object > tools/clan

[PATCH] D60116: [clang-format] Regroup #includes into blocks for Google style

ioeric created this revision. ioeric added reviewers: sammccall, klimek. Herald added a project: clang. Herald added a subscriber: cfe-commits. Regrouping #includes in blocks separated by blank lines when sorting C++ #include headers was implemented recently, and it has been preferred in Google's

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clang-tidy/ClangTidy.cpp:75 Context.diag(CheckName, PD->getLocation().asLocation(), - PD->getShortDescrip

[PATCH] D59413: Fix isInSystemMacro in presence of macro and pasted token

serge-sans-paille added a comment. @rsmith : up :-) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59413/new/ https://reviews.llvm.org/D59413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

r357461 - Fix compiler warning, remove extra ";" [NFC]

Author: uabelho Date: Tue Apr 2 03:01:09 2019 New Revision: 357461 URL: http://llvm.org/viewvc/llvm-project?rev=357461&view=rev Log: Fix compiler warning, remove extra ";" [NFC] At least gcc 7.4 complained with ../tools/clang/lib/StaticAnalyzer/Checkers/Taint.cpp:26:53: warning: extra ';' [-Wpe

[PATCH] D59827: [slh] x86 impl of ARM instrinsic + builtin for SLH

kristof.beyls added a comment. This intrinsic got added to gcc a while ago and should become available in the upcoming gcc 9 release. In gcc however, the prototype of the intrinsic is slightly different (see https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html): type __builtin_speculation_safe

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

tschuett added a comment. Are you planning to do this recursively? The minimizer does not help much for the following example, while Sema.h contains 10,000 lines of useless code. #include "clang/Sema/Sema.h" int foo() {} Repository: rC Clang CHANGES SINCE LAST ACTION https://review

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker marked an inline comment as done. Tyker added inline comments. Comment at: clang/lib/Analysis/CFG.cpp:2208 +} + CFGBlock *CFGBuilder::VisitStmt(Stmt *S, AddStmtChoice asc) { NoQ wrote: > Tyker wrote: > > NoQ wrote: > > > Tyker wrote: > > > > riccibruno wro

r357466 - [PowerPC] Fix issue with inline asm - soft float mode

Author: spetrovic Date: Tue Apr 2 04:00:09 2019 New Revision: 357466 URL: http://llvm.org/viewvc/llvm-project?rev=357466&view=rev Log: [PowerPC] Fix issue with inline asm - soft float mode This patch prevents floating point register constraints in soft float mode. Differential Revision: https:/

[PATCH] D59310: [PowerPC] Fix issue with inline asm - soft float mode

This revision was automatically updated to reflect the committed changes. Closed by commit rC357466: [PowerPC] Fix issue with inline asm - soft float mode (authored by spetrovic, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: http

r357467 - Fix Wimplicit-fallthrough warning introduced in rL357466. NFCI.

Author: rksimon Date: Tue Apr 2 04:25:38 2019 New Revision: 357467 URL: http://llvm.org/viewvc/llvm-project?rev=357467&view=rev Log: Fix Wimplicit-fallthrough warning introduced in rL357466. NFCI. Modified: cfe/trunk/lib/Basic/Targets/PPC.h Modified: cfe/trunk/lib/Basic/Targets/PPC.h URL:

[clang-tools-extra] r357468 - [clang-tidy] make getLangOpts return a const ref

Author: alexfh Date: Tue Apr 2 04:31:56 2019 New Revision: 357468 URL: http://llvm.org/viewvc/llvm-project?rev=357468&view=rev Log: [clang-tidy] make getLangOpts return a const ref Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyCheck.h Modified: clang-tools-extra/trunk/clang-tidy/Cla

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

Szelethus added a comment. Woah, the code looks amazing, cheers on the refactoring! I'll be honest, I'm struggling a bit with the sentence "we're now in the top frame". In order, I don't understand what does - we - now - in the top frame mean. "Top-level argument" is another one -- Do we have

[PATCH] D60110: [analyzer] When failing to evaluate a __builtin_constant_p, presume it's false.

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60110/new/ https://reviews.llvm.org/D60110 ___ cfe-com

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis created this revision. thakis added reviewers: jkorous, arphaman. Herald added subscribers: kadircet, dexonsmith, ioeric, ilya-biryukov, mgorny. The CMake variable controlling if XPC code is built is called `CLANGD_BUILD_XPC` but three places unintentionally checked the non-existent varia

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam updated this revision to Diff 193258. zahiraam marked 15 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43576/new/ https://reviews.llvm.org/D43576 Files: include/clang/AST/Decl.h include/clang/AST/RecursiveASTVisitor.h include/clang/Basic/Attr.td

[PATCH] D43576: Solution to fix PR27066 - Redefinition with same mangled name as another definition (dllexport and uuid)

zahiraam added a comment. There are still a few things I haven't addressed yet. Mostly because not sure there is another solution like getting rid of the map from StringRef to expr. The other issue is not adding new kind to ParsedAttr. There may be another way of doing it, but didn't look at it

[PATCH] D59802: [clang-tidy] Add new checker: llvm-avoid-cast-in-conditional

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/AvoidCastInConditionalCheck.cpp:18 + +AST_MATCHER(Expr, isMacroID) { return Node.getExprLoc().isMacroID(); } +} // namespace ast_matchers @aar

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 193260. ymandel marked 3 inline comments as done. ymandel added a comment. Small tweaks in response to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 Files:

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. Thank you for the extremely helpful and detailed review!! Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:110 + // constructed with the builder class. + static constexpr char RootId[] = "___root___"; +}; ilya-biryuko

[PATCH] D60123: [AST] Forbid copy/move of Stmt.

riccibruno created this revision. riccibruno added a reviewer: aaron.ballman. riccibruno added a project: clang. Herald added a subscriber: cfe-commits. Statements and expressions are not supposed to be moved, and trying to do so is only going to result in tears. Someone tripped on this a few day

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

thakis created this revision. thakis added a reviewer: mbonadei. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. With this, check-clang-tools unit tests are complete, but the lit tests still don't run the one

[PATCH] D60123: [AST] Forbid copy/move of Stmt.

lebedev.ri added a comment. Probably `Decl` too? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/ https://reviews.llvm.org/D60123 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D60123: [AST] Forbid copy/move of Stmt.

riccibruno added a comment. In D60123#1451303 , @lebedev.ri wrote: > Probably `Decl` too? Yep. I though it was already done but after checking it seems I remembered incorrectly. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall added inline comments. Comment at: clang/include/clang/Tooling/Syntax/TokenBuffer.h:1 +//===- TokenBuffer.h - store tokens of preprocessed files -*- C++ -*-=// +// ilya-biryukov wrote: > sammccall wrote: > > are you sure TokenBuffer is the cent

[PATCH] D60123: [AST] Forbid copy/move of statements/declarations/types.

riccibruno updated this revision to Diff 193267. riccibruno retitled this revision from "[AST] Forbid copy/move of Stmt." to "[AST] Forbid copy/move of statements/declarations/types.". riccibruno edited the summary of this revision. riccibruno added a reviewer: lebedev.ri. Repository: rC Clang

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ioeric updated this revision to Diff 193268. ioeric added a comment. - Rebase Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59811/new/ https://reviews.llvm.org/D59811 Files: clangd/ClangdServer.cpp clangd/CodeComplete.h clangd/TUScheduler.cpp

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193269. Tyker added a comment. fixed the CFG issue is an proper way CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/c

[PATCH] D60123: [AST] Forbid copy/move of statements/declarations/types.

riccibruno added a comment. In D60123#1451307 , @riccibruno wrote: > In D60123#1451303 , @lebedev.ri > wrote: > > > Probably `Decl` too? > > > Yep. I though it was already done but after checking it seems I remembe

[PATCH] D59932: [clang-tidy] **Prototype**: Add fix description to clang-tidy checks.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:109 + /// not supported. + virtual llvm::StringRef fixDescription() { return ""; } + alexfh wrote: > Checks can provide differen

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas updated this revision to Diff 193277. ztamas added a comment. Fixed typo. Mentioned the default value in release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59870/new/ https://reviews.llvm.org/D59870 Files: clang-tools-extra/clang-tidy/bugprone/TooSmallLoopVariableChe

[PATCH] D60123: [AST] Forbid copy/move of statements/types.

riccibruno updated this revision to Diff 193271. riccibruno retitled this revision from "[AST] Forbid copy/move of statements/declarations/types." to "[AST] Forbid copy/move of statements/types.". Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/ https://r

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric created this revision. ioeric added a reviewer: sammccall. Herald added subscribers: cfe-commits, jdoerfert, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. o Lex the code to get the identifiers and put them into a "symbol" index. o Adds a new completion

[PATCH] D59811: [clangd] Add fallback mode for code completion when compile command or preamble is not ready.

ilya-biryukov added a comment. Leaving a few first comments, have to run. Will take another look later, sorry about the delay today (also feel free to add more reviewers in case this is urgent). Comment at: clangd/ClangdServer.cpp:197 return CB(llvm::make_error()); +

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas marked 3 inline comments as done. ztamas added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone-too-small-loop-variable.rst:33 + + Upper limit for the magnitue bits of the loop variable. If it's set the check + filters out those catches in

[PATCH] D59887: [Syntax] Introduce TokenBuffer, start clangToolingSyntax library

sammccall added a comment. Not sure what the implications of design changes are, so will defer reviewing details of tokencollector (which generally looks good, but is of course highly coupled to lexer/pp) and range mapping (which I suspect could be simplified, but depends heavily on the model).

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia updated this revision to Diff 193281. Anastasia added a comment. - Use `AggValueSlot` in the constructor call generation to store/retrieve address space of 'this'. - Fixed detecting the address space conversion while performing qualification conversion. CHANGES SINCE LAST ACTION ht

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

mbonadei accepted this revision. mbonadei added a comment. This revision is now accepted and ready to land. LGTM, just a couple of comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17 + configs += [ "//llvm/utils/gn/build:clang_code" ] + deps

[PATCH] D59467: [clang] Adding the Likelihood Attribute from C++2a

Tyker updated this revision to Diff 193284. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59467/new/ https://reviews.llvm.org/D59467 Files: clang/include/clang/AST/Stmt.h clang/include/clang/AST/StmtCXX.h clang/include/clang/AST/TextNodeDumper.h clang/include/clang/Basic/Attr.td

[PATCH] D60128: Add const children accessors to all nodes.

nicolas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add const children accessors to all AST nodes where non const accessors exist. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D60128 Files: clang/include/clang/AST/Expr.h c

[PATCH] D60029: Add const children() accessors to all AST nodes.

nicolas updated this revision to Diff 193288. nicolas retitled this revision from "Add const children() accessors to Stmts" to "Add const children() accessors to all AST nodes.". nicolas edited the summary of this revision. nicolas added a comment. Added children() const to all AST nodes. CHANG

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

thakis marked 2 inline comments as done. thakis added inline comments. Comment at: llvm/utils/gn/secondary/clang-tools-extra/clangd/xpc/BUILD.gn:17 + configs += [ "//llvm/utils/gn/build:clang_code" ] + deps = [ +"//clang-tools-extra/clangd", mbonadei wrote:

[PATCH] D60124: gn build: Add build files for non-framework xpc clangd bits

This revision was automatically updated to reflect the committed changes. Closed by commit rL357476: gn build: Add build files for non-framework xpc clangd bits (authored by nico, committed by ). Changed prior to commit: https://reviews.llvm.org/D60124?vs=193264&id=193290#toc Repository: rL

[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor nits. Thanks for this! Comment at: clang/include/clang/Sema/ParsedAttr.h:896 + void takeOneFrom(ParsedAttributes &attrs, ParsedAtt

[PATCH] D60123: [AST] Forbid copy/move of statements/types.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60123/new/ https://reviews.llvm.org/D60123 ___

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

thakis created this revision. thakis added reviewers: mbonadei, sdefresne. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric, ilya-biryukov, mgorny. Herald added a project: LLVM. thakis edited the summary of this revision. This is a bit of a larger change since thi

[PATCH] D60099: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60099/new/ https://reviews.llvm.org/D60099 ___ cfe-commit

[PATCH] D60120: check-clang-tools: Actually build and run XPC test

thakis added a comment. (I noticed this while working on D60130 ) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60120/new/ https://reviews.llvm.org/D60120 ___ cfe-commits mailing list cfe-commits@lists.llvm.

r357480 - [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

Author: pgousseau Date: Tue Apr 2 08:20:26 2019 New Revision: 357480 URL: http://llvm.org/viewvc/llvm-project?rev=357480&view=rev Log: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4. Can be safely enabled on PS4. Reviewed By: probinson Differential Revision: https:

[PATCH] D59815: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357480: [Driver] Enable -fsanitize-address-globals-dead-stripping by default on PS4. (authored by pgousseau, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel updated this revision to Diff 193306. ymandel added a comment. Remove dependency on NodeIds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59376/new/ https://reviews.llvm.org/D59376 Files: clang/include/clang/Tooling/Refactoring/Transfor

[PATCH] D59376: [LibTooling] Add Transformer, a library for source-to-source transformations.

ymandel added a comment. I've removed the dependency on NodeIds given our (off thread) discussions regarding their overall value and appropriateness in clang::tooling vs clang::ast_matchers. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D5937

r357488 - [OPENMP]Fix mapping of the pointers captured by reference.

Author: abataev Date: Tue Apr 2 09:03:40 2019 New Revision: 357488 URL: http://llvm.org/viewvc/llvm-project?rev=357488&view=rev Log: [OPENMP]Fix mapping of the pointers captured by reference. If the pointer is captured by reference, it must be mapped as _PTR_AND_OBJ kind of mapping to correctly

[PATCH] D53633: [AArch64] Implement FP16FML intrinsics

SjoerdMeijer added a comment. FYI: a new ACLE version has been published, please find it here: https://developer.arm.com/architectures/system-architectures/software-standards/acle The "Neon Intrinsics" section contains these new intrinsics. Repository: rL LLVM CHANGES SINCE LAST ACTION

[PATCH] D60130: gn build: Add build files for clangd xpc framework code

thakis updated this revision to Diff 193313. thakis added a comment. Use {{source_file_part}} in bundle_data where possible. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60130/new/ https://reviews.llvm.org/D60130 Files: clang-tools-extra/clangd/xpc/framework/CMakeLists.txt clang-t

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

dexonsmith added a comment. In D55463#1451166 , @tschuett wrote: > Are you planning to do this recursively? > The minimizer does not help much for the following example, while Sema.h > contains 10,000 lines of useless code. > > #include "clang/Sema/Sem

[PATCH] D60139: Add clang-tidy/checks/misc-placement-new-target-size check

DennisL created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Finds placement-new calls where the size of the pointee type of the placement parameter is smaller than the size of the constructed type and the pointer is implicitly cast to ``void *``

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60108/new/ https://reviews.llvm.org/D60108 ___ cfe-commits mailing list c

Default -fomit-frame-pointer for PowerPC

Hello cfe-commits, The attached patch is for clang to use -fomit-frame-pointer by default for all PowerPC targets when optimizing code. Right now, clang uses -fomit-frame-pointer for PowerPC Linux and NetBSD but not for other targets. I have been running `clang -target powerpc-openbsd`. The pat

Re: Default -fomit-frame-pointer for PowerPC

Best to submit patches to phabricator https://reviews.llvm.org/ On Tue, Apr 2, 2019 at 8:30 PM George Koehler via cfe-commits wrote: > > Hello cfe-commits, > > The attached patch is for clang to use -fomit-frame-pointer by default > for all PowerPC targets when optimizing code. Right now, clang

r357501 - [os_log] Mark os_log_helper `nounwind`

Author: vedantk Date: Tue Apr 2 10:42:38 2019 New Revision: 357501 URL: http://llvm.org/viewvc/llvm-project?rev=357501&view=rev Log: [os_log] Mark os_log_helper `nounwind` Allow the optimizer to remove unnecessary EH cleanups surrounding calls to os_log_helper, to save some code size. As a foll

[PATCH] D60108: [os_log] Mark os_log_helper `nounwind`

This revision was automatically updated to reflect the committed changes. Closed by commit rC357501: [os_log] Mark os_log_helper `nounwind` (authored by vedantk, committed by ). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D60108?vs=193217&id=193322#toc Repo

Re: Default -fomit-frame-pointer for PowerPC

On 4/2/19 12:31 PM, Roman Lebedev via cfe-commits wrote: > Best to submit patches to phabricator https://reviews.llvm.org/ Please follow the instructions here: http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface - This will make it much easier for us to track this. Th

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 created this revision. ashi1 added a reviewer: yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. Do not produce Fat binary functions for HIP when no device code is present. Repository: rC Clang https://reviews.llvm.org/D60141 Files: lib/CodeGen/CGCUDANV.c

r357505 - [driver] clang-format. Fix indentation, split long lines. NFC

Author: atanasyan Date: Tue Apr 2 11:03:15 2019 New Revision: 357505 URL: http://llvm.org/viewvc/llvm-project?rev=357505&view=rev Log: [driver] clang-format. Fix indentation, split long lines. NFC Modified: cfe/trunk/lib/Driver/Driver.cpp cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/t

r357506 - [driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple`

Author: atanasyan Date: Tue Apr 2 11:03:31 2019 New Revision: 357506 URL: http://llvm.org/viewvc/llvm-project?rev=357506&view=rev Log: [driver][mips] Check both `gnuabi64` and `gnu` suffixes in `getMultiarchTriple` In case of N64 ABI toolchain paths migth have `mips-linux-gnuabi64` or `mips-linu

[PATCH] D60139: [clang-tidy] Add misc-placement-new-target-size check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/PlacementNewTargetSizeCheck.cpp:10 +#include + +#include "PlacementNewTargetSizeCheck.h" Unnecessary empty line. Please run Clang-format after fixing. Comment at: clang-tidy/mis

[PATCH] D59797: [COFF] Reorder fields in Chunk and SectionChunk to reduce their size

rnk added a comment. I think I've addressed all the comments, and I know that @ruiu is currently travelling or recovering from travel to Japan, so I'll go ahead and land this. Feel free to provide post-commit feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D56924: Special case ObjCPropertyDecl for printing

dgoldman added a comment. Herald added a subscriber: dexonsmith. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56924/new/ https://reviews.llvm.org/D56924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore updated this revision to Diff 193340. stephanemoore marked an inline comment as done. stephanemoore added a comment. Add a test case where a macro emits just `self` in the message expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:112 + << Message->getMethodDecl() + << FixItHint::CreateReplacement(Message->getSourceRange(), + StringRef("[super init]")); --

r357514 - [OPENMP]Add codegen for private vars with allocate clause.

Author: abataev Date: Tue Apr 2 12:44:46 2019 New Revision: 357514 URL: http://llvm.org/viewvc/llvm-project?rev=357514&view=rev Log: [OPENMP]Add codegen for private vars with allocate clause. Added codegen/test for the privatized variables with the allocate clause. Modified: cfe/trunk/lib/C

r357516 - [Sema] Fix a use-after-deallocate of a ParsedAttr

Author: epilk Date: Tue Apr 2 12:48:11 2019 New Revision: 357516 URL: http://llvm.org/viewvc/llvm-project?rev=357516&view=rev Log: [Sema] Fix a use-after-deallocate of a ParsedAttr moveAttrFromListToList only makes sense when moving an attribute to a list with a pool that's either equivalent, or

r357515 - [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

Author: epilk Date: Tue Apr 2 12:48:07 2019 New Revision: 357515 URL: http://llvm.org/viewvc/llvm-project?rev=357515&view=rev Log: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue This ability was removed in r351487, but it's needed when a lambda appears as an OpaqueValueE

[PATCH] D60099: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue

This revision was automatically updated to reflect the committed changes. Closed by commit rC357515: [CodeGen] Fix a regression by emitting lambda expressions in EmitLValue (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60099?vs=193179&id=193347#toc Repo

[PATCH] D60101: [Sema] Fix a use-after-deallocate of a ParsedAttr

This revision was automatically updated to reflect the committed changes. Closed by commit rC357516: [Sema] Fix a use-after-deallocate of a ParsedAttr (authored by epilk, committed by ). Changed prior to commit: https://reviews.llvm.org/D60101?vs=193185&id=193348#toc Repository: rC Clang CH

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-c

r357520 - [HIP-Clang] Fat binary should not be produced for non GPU code

Author: aaronenyeshi Date: Tue Apr 2 13:10:18 2019 New Revision: 357520 URL: http://llvm.org/viewvc/llvm-project?rev=357520&view=rev Log: [HIP-Clang] Fat binary should not be produced for non GPU code Skip producing the fat binary functions for HIP when no device code is present. Reviewers: yax

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra added a comment. General nit: please use diffs with very large context when you submit patches with Phabricator. https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP

[PATCH] D49863: [istream] Fix error flags and exceptions propagated from input stream operations

mclow.lists accepted this revision. mclow.lists added a comment. I'm OK with this. I think, strictly speaking, that libc++ is following the standard, and everyone else is not - but what everyone else is doing makes sense. Comment at: libcxx/include/istream:365 __input_arith

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

yaxunl added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP && EmittedKernels.empty() && DeviceVars.empty()) +return nullptr; // void __{cuda|hip}_register_globals(void* handle); tra wrote: > I think this wo

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra accepted this revision. tra added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:475-476 return nullptr; + if (IsHIP && EmittedKernels.empty() && DeviceVars.empty()) +return nullptr; // void __{cuda|hip}_register_globals(void* handle); yax

r357526 - [HIP-Clang] Fat binary should not be produced for non GPU code 2

Author: aaronenyeshi Date: Tue Apr 2 13:49:41 2019 New Revision: 357526 URL: http://llvm.org/viewvc/llvm-project?rev=357526&view=rev Log: [HIP-Clang] Fat binary should not be produced for non GPU code 2 Also for CUDA, we need to disable producing these fat binary functions when there is no GPU

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

This revision was automatically updated to reflect the committed changes. Closed by commit rL357526: [HIP-Clang] Fat binary should not be produced for non GPU code 2 (authored by aaronenyeshi, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

ashi1 added a comment. Hi Artem, I had just committed the change. IS this change OK or should I revert it? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60141/new/ https://reviews.llvm.org/D60141 ___ cfe-commits mail

[PATCH] D60151: [clang-tidy] Add using SmallSet to LLVM.h to fix bug in typedef in llvm checkers.

hintonda created this revision. hintonda added a reviewer: alexfh. Herald added a subscriber: xazax.hun. Herald added a project: clang. Fixed ambiguous namespace bug in llvm checkers that add the llvm namespace to clang::tidy, by adding using declaration for SmallSet. Repository: rG LLVM Githu

[PATCH] D60112: [analyzer] Treat write into a top-level parameter variable with destructor as escape.

NoQ marked an inline comment as done. NoQ added a comment. In D60112#1451198 , @Szelethus wrote: > Woah, the code looks amazing, cheers on the refactoring! I'll be honest, I'm > struggling a bit with the sentence "we're now in the top frame". In order, I

[PATCH] D60141: [HIP-Clang] Fat binary should not be produced for non GPU code

tra added a comment. In D60141#1452019 , @ashi1 wrote: > Hi Artem, I had just committed the change. IS this change OK or should I > revert it? The `if` condition could use some clang-formatting, but other than that the patch still looks OK to me. Rep

  1   2   >