[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

owenpan added a comment. @MyDeveloperDay: Can you add a link to the bugzilla report? I stopped pushing my solution because as @krasimir said it's probably not a bug although the current documentation doesn't spell it out. Nonetheless, I'm with you and would like to see this improvement

[PATCH] D59756: [clangd] Support dependent bases in type hierarchy

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/unittests/clangd/TypeHierarchyTests.cpp:405 + *Result, + AllOf(WithName("S"), WithKind(SymbolKind::Struct), +Parents(AllOf(WithName("S"),

[PATCH] D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list

This revision was automatically updated to reflect the committed changes. Closed by commit rL357851: [clang-format] Fix Bug 41407 (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r357851 - [clang-format] Fix Bug 41407

Author: owenpan Date: Sat Apr 6 16:10:11 2019 New Revision: 357851 URL: http://llvm.org/viewvc/llvm-project?rev=357851=rev Log: [clang-format] Fix Bug 41407 Differential Revision: https://reviews.llvm.org/D60359 Modified: cfe/trunk/lib/Format/ContinuationIndenter.cpp

[PATCH] D60332: [gn] Support for per-target runtime directory layout

This revision was automatically updated to reflect the committed changes. Closed by commit rL357850: [gn] Support for per-target runtime directory layout (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D60332?vs=194037=194038#toc Repository: rL LLVM

[PATCH] D60332: [gn] Support for per-target runtime directory layout

phosek updated this revision to Diff 194037. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60332/new/ https://reviews.llvm.org/D60332 Files:

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

MyDeveloperDay added a comment. Herald added a project: clang. @owenpan can I help you bring this back up to date and review, I think I saw another issue in the bugzilla requesting this. I know the code owners like new option to have a style guide used by a large code base, but to me this

[PATCH] D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thanks for doing this, it LGTM, I like your solution better ;-) I will abandon D60361: [clang-format] [PR41407] Constructor initializer list indented incorrectly

[PATCH] D54978: Move the SMT API to LLVM

gou4shi1 added a comment. In D54978#1457318 , @mikhail.ramalho wrote: > In D54978#1447107 , @gou4shi1 wrote: > > > My own out-of-tree pass `#include ` and use cmake's > > `add_llvm_library` to compile it into a

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda updated this revision to Diff 194017. hintonda added a comment. Explicitly check for implicitCastExpr and add additional negative matching test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802

[PATCH] D54978: Move the SMT API to LLVM

mikhail.ramalho added a comment. In D54978#1447107 , @gou4shi1 wrote: > My own out-of-tree pass `#include ` and use cmake's > `add_llvm_library` to compile it into a `.so` > However, `opt -load-pass-plugin=my-pass.so -passes="foo" bar.ll` fails: >

[PATCH] D59309: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rL357837: [clang-format] BreakAfterReturnType ignored on functions with numeric template… (authored by paulhoad, committed by ). Herald added a project: LLVM. Changed prior to commit:

r357837 - [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters

Author: paulhoad Date: Sat Apr 6 03:13:04 2019 New Revision: 357837 URL: http://llvm.org/viewvc/llvm-project?rev=357837=rev Log: [clang-format] BreakAfterReturnType ignored on functions with numeric template parameters Summary: Addresses PR40696 - https://bugs.llvm.org/show_bug.cgi?id=40696

[PATCH] D60359: [clang-format] Fix incorrect indentation of C++ constructor initializer list

owenpan created this revision. owenpan added reviewers: sammccall, klimek, djasper, krasimir. owenpan added a project: clang. Herald added a subscriber: cfe-commits. See https://bugs.llvm.org/show_bug.cgi?id=41407 for more info. Repository: rC Clang https://reviews.llvm.org/D60359 Files: