[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

qiucf marked an inline comment as done. qiucf added a comment. Part of a function signature can also match where it is called, so the test failed. I did the changes to pass the test but diff file was generated locally so it didn't contain this change. Sorry for the mistake. Repository: rC Cl

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358048: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of (authored by ahatanak, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

r358048 - [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of

Author: ahatanak Date: Tue Apr 9 23:20:23 2019 New Revision: 358048 URL: http://llvm.org/viewvc/llvm-project?rev=358048&view=rev Log: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata. This fixes a bug where ARC contract wasn't inserting the retainRV marker when

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

qiucf updated this revision to Diff 194446. qiucf added a comment. Fix error about a mismatch in mmintrin test cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924 Files: clang/lib/Driver/CMakeLists.txt clang/lib/Dr

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

ahatanak added a comment. Just one minor comment, but otherwise the patch looks good to me. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:92 +llvm::Function *generateNonTrivialCStructDefaultConstructor(CodeGenModule &GCM, +

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda added a comment. Have a working prototype for aliases, but underneath, an option is an option, so should be able to support both without any trouble. Will upload as soon as I clean it up and add tests, etc... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D59347: [DebugInfo] Combine Trivial and NonTrivial flags

asmith marked 2 inline comments as done. asmith added a comment. This should be ready to commit CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59347/new/ https://reviews.llvm.org/D59347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

MaskRay added a comment. > is that to imply that the first block all do not use split DWARF? The first block do not use split DWARF. > In a previous message I think you said that the only change was "-gmlt > -gsplit-dwarf -fno-split-dwarf-inlining => 1 (before) 2 (after)" - which I'm > not sur

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Okay, so it looks like dexter might be a replacement for the lldgb.py wrapper and would support gdb, lldb, and the visual studio debugger. I think it would be nice to migrate the bulk of the

[PATCH] D55044: [clang-tidy] check for Abseil make_unique

axzhang updated this revision to Diff 194435. axzhang marked an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55044/new/ https://reviews.llvm.org/D55044 Files: clang-tidy/abseil/AbseilTidyModule.cpp clang-tidy/modernize/MakeSmartPtrCheck.cpp clang-tidy/m

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

jkorous marked an inline comment as done. jkorous added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:372 D = adjustDeclToTemplate(D); + const Decl* CanonicalDecl = D->getCanonicalDecl(); arphaman wrote: > Why are we now checking for the canonic

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

aaronpuchert added a comment. Ok, here is an idea. We introduce `-split-dwarf-output` in Clang instead of `-fsplit-dwarf-dwo-name-attr`. If given, it overrides the output file name for the Split DWARF file, which we otherwise take from `-split-dwarf-file`. The option is obviously incompatible w

[PATCH] D40381: Parse concept definition

saar.raz updated this revision to Diff 194417. saar.raz added a comment. Herald added a subscriber: jfb. Herald added a project: clang. Address most of rsmith's CR comments, rebase onto trunk Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40381/new/ https://review

[PATCH] D40381: Parse concept definition

saar.raz marked 21 inline comments as done. saar.raz added a comment. Only the TemplatedDecl issue remains, all other comments have been addressed and we're rebased onto master. @rsmith please reply to the last comment, and lets finally start merging these :) Repository: rC Clang CHANGES SI

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

keryell added a comment. While we are thinking about recycling some attributes across languages, we have to think about the fact that real applications are often made from various languages, such as SYCL + OpenMP 5 or whatever. It would be nice not to forbid such a combination inside the same TU

[PATCH] D59923: [Driver] Simplify -g level computation and its interaction with -gsplit-dwarf

dblaikie added a comment. I'm still not entirely clear on how this is all changing, sorry - in the patch description summary, the first block of examples doesn't mention which of those disables split DWARF (the second block of examples all say "+ split" - is that to imply that the first block a

[PATCH] D59425: Explicitly Craft a Path to Compiler-RT Builtins on Bare Metal Targets

CodaFi added a reviewer: phosek. CodaFi added a subscriber: phosek. CodaFi added a comment. +@phosek Who seems to be the last significant contributor to this file. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59425/new/ https://reviews.llvm.org/D59425 ___

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

rjmccall added a reviewer: ahatanak. rjmccall added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang/CodeGen/CodeGenABITypes.h:140 +QualType QT); + } // end namespace CodeGen

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

rjmccall added a comment. In D60302#1460379 , @ahatanak wrote: > Thanks. Does this require changes to swift too? Yes, it will, to `getObjCRetainAutoreleasedReturnValueMarker` in `GenObjC.cpp`. Repository: rC Clang CHANGES SINCE LAST ACTION https:/

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

bader added a comment. To give more context to the question, I'd like to clarify the use case of new attributes. As @Fznamznon already mentioned in previous comments SYCL is not supposed to expose any non-standard extensions to a user. Here is code example of the SYCL program, which demonstrat

[PATCH] D60485: [AArch64] Add support for MTE intrinsics

javed.absar created this revision. javed.absar added reviewers: DavidSpickett, olista01. Herald added a subscriber: kristof.beyls. This patch provides intrinsics support for Memory Tagging Extension (MTE), which was introduced with the Armv8.5-a architecture. These intrinsics are available whe

[PATCH] D40381: Parse concept definition

saar.raz added inline comments. Herald added a subscriber: arphaman. Comment at: include/clang/AST/DeclTemplate.h:3035 + SourceRange getSourceRange() const override LLVM_READONLY { +return SourceRange(getLocation(), getLocation()); + } rsmith wrote: > faisa

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak added a comment. Thanks. Does this require changes to swift too? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60302/new/ https://reviews.llvm.org/D60302 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji requested changes to this revision. jsji added a comment. This revision now requires changes to proceed. Please make sure you run all test before updating patch! Comment at: clang/test/CodeGen/ppc-mmintrin.c:23 +// CHECK: i64 @_mm_packs_pu16(i64 [[REG1:[0-9a-zA-Z_%.]+]], i

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Okay. In that case, I have no objections to this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60302/new/ https://reviews.llvm.org/D60302

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

rjmccall added a comment. I think it would be more reasonable to just change `getDeclLanguageLinkage` to check for a kernel function. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60454/new/ https://reviews.llvm.org/D60454 ___ cfe-commits

[PATCH] D60161: Expose non-trivial struct helpers for Swift.

allevato updated this revision to Diff 194379. allevato added a comment. - Apply review changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60161/new/ https://reviews.llvm.org/D60161 Files: clang/include/clang/CodeGen/CodeGenABITypes.h clang

[PATCH] D60186: Support CLANG_ENABLE_DEFAULT_PIE like gcc --enable-default-pie

jiangyi added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60186/new/ https://reviews.llvm.org/D60186 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

Eugene.Zelenko added inline comments. Comment at: clang-tidy/bugprone/PlacementNewTargetTypeMismatch.cpp:38 + const CastExpr *Cast = dyn_cast(PlacementExpr); + if (nullptr == Cast) { +return; JonasToth wrote: > braces, above the comment does not follow the

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

JonasToth added a comment. Hey Dennis, my 2cents on the check. I think it is very good to have! Did you check coding guidelines if they say something to this issue? (e.g. cppcoreguidelines, hicpp, cert) As we have modules for them it would be great to make aliases to this check if they demand

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

tcwang updated this revision to Diff 194371. tcwang marked an inline comment as done. tcwang added a comment. Fix some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60472/new/ https://reviews.llvm.org/D60472 Files: clang/include/clang/

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

tcwang marked 4 inline comments as done. tcwang added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:192 + // En/disable crypto + if (Arg *A = Args.getLastArg(options::OPT_mcrypto, options::OPT_mnocrypto, + options::OPT_m

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. (Also, dexter has seen 7 commits over its lifetime, so I'm not sure that's something we'd want to depend on.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 ___ cfe-commits

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. In D54187#1460181 , @aprantl wrote: > Did anyone take the time to look at dexter and whether it would fit the bill > here? It would be great to avoid reimplementing its functionality just to > have something that then only works o

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm marked 5 inline comments as done. bd1976llvm added inline comments. Comment at: lld/ELF/InputFiles.cpp:402 + if (Config->DepLibs) +if (fs::exists(Specifier)) + Driver->addFile(Specifier, /*WithLOption=*/false); jyknight wrote: > bd1976llvm wr

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto for ARM/AArch64

manojgupta added inline comments. Comment at: clang/include/clang/Driver/Options.td:2218 Group; -def mpower8_crypto : Flag<["-"], "mcrypto">, -Group; -def mnopower8_crypto : Flag<["-"], "mno-crypto">, -Group; +def mcrypto : Flag<["-"], "mcrypto">, Group, +HelpTex

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

aprantl added a comment. Did anyone take the time to look at dexter and whether it would fit the bill here? It would be great to avoid reimplementing its functionality just to have something that then only works on Windows. My position is that for the kind of very basic end-to-end testing that

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. In D60455#1459935 , @Anastasia wrote: > I was just wondering since SYCL is intended to be a single source C++ for > OpenCL and this attribute is for internal use is it possible to just reuse > existing OpenCL kernel attribute?

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

thakis added a comment. aprantl: Ping on Hans's question from Dec 18. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D60472: [AArch64][PowerPC][Driver] Allow setting crypto feature through -mcrypto.

tcwang created this revision. Herald added subscribers: cfe-commits, jsji, kbarton, kristof.beyls, javed.absar, nemanjai. Herald added a project: clang. tcwang added reviewers: kristof.beyls, dlj, manojgupta. This patch enhances Clang flags -mcrypto and -mno-crypto to enable/disable crypto featu

[PATCH] D60302: [CodeGen][ObjC] Emit the retainRV marker as a module flag instead of named metadata.

ahatanak added a comment. The upgrader rewrites the named metadata into a module flag (see https://reviews.llvm.org/D60303). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60302/new/ https://reviews.llvm.org/D60302 _

r358016 - [OPENMP]Allow allocate directive on parameters.

Author: abataev Date: Tue Apr 9 09:31:37 2019 New Revision: 358016 URL: http://llvm.org/viewvc/llvm-project?rev=358016&view=rev Log: [OPENMP]Allow allocate directive on parameters. Patch allows to use allocate directives on the function parameters. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cp

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Anastasia requested changes to this revision. Anastasia added a comment. This revision now requires changes to proceed. I was just wondering since SYCL is intended to be a single source C++ for OpenCL and this attribute is for internal use is it possible to just reuse existing OpenCL kernel attr

[PATCH] D54881: [clang-format] Prevent Clang-Format from editing leading whitespace on lines outside of the format range

klimek added a comment. In D54881#1449848 , @russellmcc wrote: > klimek: I'm sorry, I don't fully understand your proposed fix. Could you > explain it in more detail? > > Without being able to respond to your proposal in detail, I strongly believe > if

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda added a comment. In D59746#1459906 , @hintonda wrote: > In D59746#1459826 , @hintonda wrote: > > > In D59746#1459672 , @klimek wrote: > > > > > If we can extend cl::

[PATCH] D60323: [clangd] Include compile command inference in fileStatus API

kadircet added a comment. What about surfacing compile command itself as well? IMO, it is an important information that we always extract from logs by digging currently. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60323/new/ https://reviews.llvm.

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda added a comment. In D59746#1459826 , @hintonda wrote: > In D59746#1459672 , @klimek wrote: > > > In D59746#1458539 , @hintonda > > wrote: > > > > > In D59746#145846

[PATCH] D60432: [clang][ASTContext] Simplify caching for declaration-related comments

arphaman added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:372 D = adjustDeclToTemplate(D); + const Decl* CanonicalDecl = D->getCanonicalDecl(); Why are we now checking for the canonical declaration instead of `D` as before? Repository: rC

[PATCH] D60456: [RISCV][WIP/RFC] Hard float ABI support

rjmccall added inline comments. Comment at: lib/Basic/Targets/RISCV.h:102 // TODO: support lp64f and lp64d ABIs. -if (Name == "lp64") { +if (Name == "lp64" || Name == "lp64f" || Name == "lp64d") { ABI = Name; You can remove the TODO here, assu

[PATCH] D60465: [ASTImporter] Error handling fix in ImportDefinition_New.

balazske updated this revision to Diff 194333. balazske added a comment. - Removed unneeded and wrong type cast. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60465/new/ https://reviews.llvm.org/D60465 Files: lib/AST/ASTImporter.cpp Index: lib/AST/ASTImporte

[PATCH] D55463: Introduce a source minimizer that reduces source to directives that might affect the dependency list for a compilation

arphaman updated this revision to Diff 194331. arphaman added a comment. Updated to the new LLVM license comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55463/new/ https://reviews.llvm.org/D55463 Files: include/clang/Basic/DiagnosticFrontendKinds.td

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

jyknight added inline comments. Comment at: lld/ELF/InputFiles.cpp:402 + if (Config->DepLibs) +if (fs::exists(Specifier)) + Driver->addFile(Specifier, /*WithLOption=*/false); bd1976llvm wrote: > jyknight wrote: > > bd1976llvm wrote: > > > jyknight wrote

[PATCH] D60465: [ASTImporter] Error handling fix in ImportDefinition_New.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. ASTImporter::ImportDefinition_New contained a call to Import th

[PATCH] D60274: [ELF] Implement Dependent Libraries Feature

bd1976llvm marked 25 inline comments as done. bd1976llvm added a comment. I have updated the diff to address review comments. I think we can continue to refine this patch in parallel with discussing the design further (I am not dismissing the concerns raised by @compnerd and @jyknight). I am un

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1000 +def SYCLDevice : InheritableAttr { + let Spellings = [GNU<"sycl_device">]; + let Subjects = SubjectList<[Function, Var]>; aaron.ballman wrote: > Is there a reason to not also i

[PATCH] D59746: [LibTooling] Fix '-h' option

hintonda added a comment. In D59746#1459672 , @klimek wrote: > In D59746#1458539 , @hintonda wrote: > > > In D59746#1458461 , @hintonda > > wrote: > > > > > In D59746#145843

[PATCH] D60463: [ASTImporter] Add check for correct import of source locations.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Unit tests extended with a new check for source locations. Curr

r358006 - Fixed comment as pointed out by post-commit review of D59845

Author: teemperor Date: Tue Apr 9 07:18:23 2019 New Revision: 358006 URL: http://llvm.org/viewvc/llvm-project?rev=358006&view=rev Log: Fixed comment as pointed out by post-commit review of D59845 Modified: cfe/trunk/lib/AST/ASTImporter.cpp Modified: cfe/trunk/lib/AST/ASTImporter.cpp URL: h

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric added a comment. Thanks for the review! Comment at: clangd/CodeComplete.cpp:1320 +llvm::IntrusiveRefCntPtr VFS) && { +auto CompletionFilter = speculateCompletionFilter(Content, Pos); +if (!CompletionFilter) { sammccall wrote:

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric updated this revision to Diff 194315. ioeric added a comment. - minor cleanup Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60126/new/ https://reviews.llvm.org/D60126 Files: clangd/ClangdServer.cpp clangd/ClangdUnit.cpp clangd/CodeComp

[PATCH] D60126: [clangd] Use identifiers in file as completion candidates when build is not ready.

ioeric updated this revision to Diff 194311. ioeric marked 9 inline comments as done. ioeric added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60126/new/ https://reviews.llvm.org/D60126 Files: clangd/ClangdS

[PATCH] D60461: [ASTImporter] Import TemplateParameterLists in function templates.

balazske created this revision. Herald added subscribers: cfe-commits, gamesh411, Szelethus, dkrupp. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: clang. Correct missing import of TemplateParameterList in function dec

[PATCH] D59987: Add support for detection of devtoolset-8

This revision was automatically updated to reflect the committed changes. Closed by commit rL358002: Add support for detection of devtoolset-8 (authored by tstellar, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.l

r358002 - Add support for detection of devtoolset-8

Author: tstellar Date: Tue Apr 9 06:26:10 2019 New Revision: 358002 URL: http://llvm.org/viewvc/llvm-project?rev=358002&view=rev Log: Add support for detection of devtoolset-8 Summary: The current llvm/clang et al. project can be built with the latest developer toolset (devtoolset-8) on RHEL, w

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

ABataev added a comment. In D60455#1459678 , @Fznamznon wrote: > Hi all, > > I assume that something to mark the code which is supposed to be offloaded > already is implemented for OpenMP and CUDA. For example I found CUDA-specific > CUDADevice attribute

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon added a comment. Hi all, I assume that something to mark the code which is supposed to be offloaded already is implemented for OpenMP and CUDA. For example I found CUDA-specific CUDADevice attribute. I can't just use CUDA-specific attributes for SYCL but I think that these resources

[PATCH] D59746: [LibTooling] Fix '-h' option

klimek added a comment. In D59746#1458539 , @hintonda wrote: > In D59746#1458461 , @hintonda wrote: > > > In D59746#1458432 , @klimek wrote: > > > > > If we make it an alias

[PATCH] D60456: [RISCV][WIP/RFC] Hard float ABI support

asb created this revision. asb added a reviewer: rjmccall. Herald added subscribers: benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar. Herald added a project

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. These attributes are being parsed and silently ignored -- are there semantics expected for the attributes? Comment at: clang/include/clang/Basic/Attr.td:1000 +def SYCLDevice : InheritableAttr { + le

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

Fznamznon created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. SYCL runtime is supposed to use sycl_kernel attribute to mark functions in the single source which are supposed to be compiled for the device. Compiler is supposed to understa

[PATCH] D60055: Check i < FD->getNumParams() before querying

Violet added a comment. In D60055#1459602 , @lebedev.ri wrote: > I won't be able to properly review this, sorry. Can you suggest someone with familiarity for this part of code? The reviewers I randomly added by `git blame` doesn't seem to be reviewing.

[PATCH] D59711: PR41183: Don't emit Wstrict-prototypes warning for an implicit function declaration.

jyknight added a comment. Herald added a subscriber: dexonsmith. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59711/new/ https://reviews.llvm.org/D59711 ___ cfe-commits mailing list cfe-commits@

[PATCH] D60055: Check i < FD->getNumParams() before querying

lebedev.ri resigned from this revision. lebedev.ri added a comment. I won't be able to properly review this, sorry. While i'm sure this fix silences the assert, i don't know what that means for the original caller. Does it fail? Does it retry in some other scope? Should it be more picky about th

[clang-tools-extra] r357994 - ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

Author: abpostelnicu Date: Tue Apr 9 04:17:02 2019 New Revision: 357994 URL: http://llvm.org/viewvc/llvm-project?rev=357994&view=rev Log: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files. Summary: At Mozilla we are using this tool in order to perform review

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added inline comments. Comment at: lib/Serialization/ASTWriter.cpp:4283 + // Sort to allow reproducible .pch files - https://bugs.debian.org/877359 + std::map> sortedOpenCLTypeExtMap; for (const auto &I : SemaRef.OpenCLTypeExtMap) { riccibruno wrot

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

Anastasia created this revision. Anastasia added reviewers: rjmccall, bader. Herald added subscribers: ebevhan, yaxunl. Kernel function names have to be preserved as in the original source to be able to access them from the host API side. This patch adds restriction to kernels that prevents them

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

r.stahl updated this revision to Diff 194285. r.stahl marked 4 inline comments as done. r.stahl added a comment. - addressed review comments - created cross_tu::containsConst - fixed bug that unions were not exported - added TODO test for constructor case Repository: rC Clang CHANGES SINCE LA

[PATCH] D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

This revision was automatically updated to reflect the committed changes. Closed by commit rL357994: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number… (authored by Abpostelnicu, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Rep

[PATCH] D46421: [analyzer][CrossTU] Extend CTU to VarDecls with initializer

r.stahl added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:357 + return true; +if (!RTy->hasConstFields()) + return true; xazax.hun wrote: > I wonder what would happen with types that has const fields and

[PATCH] D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

JonasToth accepted this revision. JonasToth added a comment. This revision is now accepted and ready to land. How does that happen to be a problem? It feels that `stdout.write` and `stderr.write` should be unconnected? (if you know the reason I would like to know it too :)) Please note, that `ru

r357993 - [RISCV] Unbreak test from r357989

Author: asb Date: Tue Apr 9 03:44:47 2019 New Revision: 357993 URL: http://llvm.org/viewvc/llvm-project?rev=357993&view=rev Log: [RISCV] Unbreak test from r357989 There were some errors in the committed test checks, left in due to a git stash apply mishap. Modified: cfe/trunk/test/CodeGen/

[PATCH] D60453: ClangTidy: Avoid mixing stdout with stderror when dealing with a large number of files.

Abpostelnicu created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D60453 Files: clang-tidy/tool/run-clang-tidy.py Index: clang-tidy/tool/run-clang-tidy.py ==

[PATCH] D60139: [clang-tidy] Add bugprone-placement-new-target-type-mismatch check

DennisL updated this revision to Diff 194283. DennisL added a comment. - handle array to ptr decay - updated error msg - additional tests for arry to ptr decay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60139/new/ https://reviews.llvm.org/D60139 Files: clang-tidy/bugprone/Bugprone

r357991 - [RISCV][NFC] Minor fixup for r357989

Author: asb Date: Tue Apr 9 03:25:05 2019 New Revision: 357991 URL: http://llvm.org/viewvc/llvm-project?rev=357991&view=rev Log: [RISCV][NFC] Minor fixup for r357989 One of the tests in riscv64-lp64-lp64f-lp64d would have had a different lowering for lp64f/lp64d as a float argument was missed.

r357989 - [RISCV][NFC] Refactor RISC-V ABI lowering tests in preparation for hard float patches

Author: asb Date: Tue Apr 9 03:12:49 2019 New Revision: 357989 URL: http://llvm.org/viewvc/llvm-project?rev=357989&view=rev Log: [RISCV][NFC] Refactor RISC-V ABI lowering tests in preparation for hard float patches Split tests in to files representing the subset of RISC-V ABIs they should have

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

reuk added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2009 + // classes case + if (Style.AccessModifierIndentation && Line->Level % 2 == 0) +--Line->Level; klimek wrote: > What if the class starts at level 1? (for example, inside

r357985 - [ASTImporter] Fix in ASTImporter::Import_New(const Decl *)

Author: bjope Date: Tue Apr 9 02:12:32 2019 New Revision: 357985 URL: http://llvm.org/viewvc/llvm-project?rev=357985&view=rev Log: [ASTImporter] Fix in ASTImporter::Import_New(const Decl *) Make sure ASTImporter::Import_New(const Decl *) returns a Expected and not Expected to make the clang/unit

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas added a comment. Ok, I just fixed a remaining typo and rebased the patch to have it work with a more recent version of the code base, so I guess this patch is ready for commit. Jonas, can you commit this change for me? I still don't have commit access, I just applied for it some days ago.

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas updated this revision to Diff 194261. ztamas added a comment. Fixed a typo in release notes. Rebased the patch withh git pull -r. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59870/new/ https://reviews.llvm.org/D59870 Files: clang-tools-extra/clang-tidy/bugprone/TooSmallLoopV

[PATCH] D60225: [clang-format] [PR19056] Add support for indenting class members and methods one level under the modifiers

klimek added inline comments. Comment at: clang/include/clang/Format/Format.h:50 struct FormatStyle { + /// Indents after access modifiers. i.e. + /// \code I think we need to explain this a bit more: What this does is: Indent classes with access modifiers at

[PATCH] D59408: [clang-format] [PR25010] Extend AllowShortIfStatementsOnASingleLine not working if an "else" statement is present

klimek added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:401 + * ``SIS_AlwaysNoElse`` (in configuration: ``AlwaysNoElse``) +Allow short if/else if statements even if the else is a compound statement. + MyDeveloperDay wrote: > klimek w

[PATCH] D59332: [clang-format] AlignConsecutiveDeclarations fails with attributes

klimek added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:468 C.Tok->is(TT_FunctionDeclarationName) || + C.Tok->startsSequence( + tok::l_paren, tok::l_paren, tok::identifier, tok::coloncolon,

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

MyDeveloperDay added a comment. In D60363#1459297 , @lebedev.ri wrote: > Please either subscribe the correct lists or set the correct repo in > differential params. Thanks for the correction, I was never really clear which one to use for the project as

[PATCH] D60363: [clang-format] [PR41170] Break after return type ignored with certain comments positions

lebedev.ri added a comment. Please either subscribe the correct lists or set the correct repo in differential params. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60363/new/ https://reviews.llvm.org/D60363 ___ cfe-

[PATCH] D52527: [clang-format] fix Bug 38686: add AfterCaseLabel to BraceWrapping

owenpan closed this revision. owenpan added a comment. llvm-svn: 357957 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52527/new/ https://reviews.llvm.org/D52527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

qiucf updated this revision to Diff 194253. qiucf retitled this revision from "[PowerPC][Clang] Port MMX intrinsics and basic test cases to Power" to "[PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power". qiucf edited the summary of this revision. qiucf added a comment. - Add mor