[PATCH] D60661: Revert "Revert "[clang-format] Keep protobuf "package" statement on one line""

dchai created this revision. dchai added a reviewer: krasimir. Herald added a project: clang. Herald added a subscriber: cfe-commits. Top-level "package" and "import" statements should generally be kept on one line, for all languages. This reverts commit rL356912

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

Quuxplusone added a comment. As you're making tests for ADL corner cases, you might also consider testing the interactions between ADL and defaulted function parameters, e.g. https://godbolt.org/z/vHnyFl It looks like everyone (except MSVC) already gets that stuff right (or at least portable-be

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL358337: [CommandLineParser] Add DefaultOption flag (authored by dhinton, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D59746?vs=194899&id=195020

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

hintonda added a comment. In D59746#1465445 , @klimek wrote: > lg Thanks again for the help and the suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746

r358337 - [CommandLineParser] Add DefaultOption flag

Author: dhinton Date: Sat Apr 13 09:55:28 2019 New Revision: 358337 URL: http://llvm.org/viewvc/llvm-project?rev=358337&view=rev Log: [CommandLineParser] Add DefaultOption flag Summary: Add DefaultOption flag to CommandLineParser which provides a default option or alias, but allows users to overr

[PATCH] D59746: [CommandLineParser] Add DefaultOption flag

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59746/new/ https://reviews.llvm.org/D59746 ___ c

[PATCH] D59870: [clang-tidy] Add MagnitudeBitsUpperLimit option to bugprone-too-small-loop-variable

ztamas added a comment. In the meantime, I've got the commit access, so I'll give it a try to push this myself. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59870/new/ https://reviews.llvm.org/D59870 ___ cfe-commits mailing list cfe-commi

[clang-tools-extra] r358333 - [clang-tidy] Use back-tick here

Author: ztamas Date: Sat Apr 13 07:31:54 2019 New Revision: 358333 URL: http://llvm.org/viewvc/llvm-project?rev=358333&view=rev Log: [clang-tidy] Use back-tick here Modified: clang-tools-extra/trunk/docs/clang-tidy/checks/misc-throw-by-value-catch-by-reference.rst Modified: clang-tools-ext

[PATCH] D60570: [Sema] Add more tests for the behavior of argument-dependent name lookup

Quuxplusone added inline comments. Comment at: test/CXX/basic/basic.lookup/basic.lookup.argdep/p2-associated-namespaces-classes.cpp:77 + + // associated class: itself, lambda + namespace X5 { Do you also have a test somewhere to verify that the parameter and r

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

riccibruno added a comment. In D60561#1465373 , @Tyker wrote: > the impact was much higher than i expected, around 1% slower in average on > 50 compilation of SemaDecl with -fsyntax-only. Good to know, thanks for doing the measurement ! CHANGES SINCE

[PATCH] D41910: [Concepts] Constrained partial specializations and function overloads.

saar.raz updated this revision to Diff 195010. saar.raz added a comment. Herald added a reviewer: martong. Herald added a reviewer: shafik. Fixed bug in normalization substitution into CSEs Rebase onto trunk Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41910/new/

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz updated this revision to Diff 195009. saar.raz added a comment. Rebase onto trunk Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/ https://reviews.llvm.org/D41569 Files: include/clang/AST/ExprCXX.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D60561: [clang] fixing diagnostics of constexpr callstack

Tyker added a comment. the impact was much higher than i expected, around 1% slower in average on 50 compilation of SemaDecl with -fsyntax-only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60561/new/ https://reviews.llvm.org/D60561 ___

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added inline comments. Comment at: llvm/trunk/lib/Support/TimeProfiler.cpp:29-30 + +static std::string escapeString(StringRef Src) { + std::string OS; + for (const unsigned char &C : Src) { lebedev.ri wrote: > `SmallString<32>` ? > Also, it is safe t

[PATCH] D58675: [clang] Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps

lebedev.ri added a comment. Some post-commit review (please submit a new review, don't replace this diff) As usual, the incorrect license headers keep slipping through. Comment at: llvm/trunk/include/llvm/Support/TimeProfiler.h:5-6 +// +// This file is distributed under the Uni

Re: r357877 - [clang-format] Fix bug https://bugs.llvm.org/show_bug.cgi?id=41413

Hi Paul, Thank you for the information! I will remember to do that from now on. Regards, Owen On Fri, Apr 12, 2019 at 11:34 AM wrote: > Hi Owen, > > FYI, putting a URL in the headline of the commit message takes up > space and doesn't really describe the fix to a casual reader. The > subject