[PATCH] D60663: Time profiler: small fixes and optimizations

aras-p added a comment. > So i can't and won't claim any legal knowledge, but it maybe would be good > for him to at least comment here, that he is ok with this? Yes, absolutely fine. The only reason why some files started with the old license blurb is because I started the branch before licens

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 195234. ymandel marked 2 inline comments as done. ymandel added a comment. Deleted ASTEdit builder; added more `change` overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.o

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel updated this revision to Diff 195235. ymandel added a comment. Fix include ordering (bad clang-format config). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60408/new/ https://reviews.llvm.org/D60408 Files: clang/include/clang/Tooling/Re

[PATCH] D60408: [LibTooling] Extend Transformer to support multiple simultaneous changes.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Tooling/Refactoring/Transformer.h:87 + TextGenerator Replacement; + TextGenerator Explanation; +}; ilya-biryukov wrote: > ymandel wrote: > > ilya-biryukov w

[PATCH] D60674: [X86] Restore the pavg intrinsics.

efriedma added a comment. > Though I modified the avx512 intrinsics to not have masking built in. Do we need autoupgrade support from the old avx512 intrinsics to the new avx512 intrinsics? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/ https://reviews

[PATCH] D59924: [PowerPC] [Clang] Port MMX intrinsics and basic test cases to Power

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59924/new/ https://reviews.llvm.org/D59924 _

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

craig.topper added a comment. In D56571#1467333 , @void wrote: > This code: > > ; ModuleID = 'arch_static_branch.bc' > source_filename = "arch/x86/entry/vsyscall/vsyscall_64.c" > target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" > target

[PATCH] D60674: [X86] Restore the pavg intrinsics.

craig.topper added a comment. In D60674#1467349 , @efriedma wrote: > > Though I modified the avx512 intrinsics to not have masking built in. > > Do we need autoupgrade support from the old avx512 intrinsics to the new > avx512 intrinsics? Yes, and the c

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a nit and the ultimate name for the `isa_and_nonnull<>` API. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:27-28 CheckFa

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_checker'

aaron.ballman added a comment. No opposition from me regarding `llvm_check`, though I think `llvm_tidy` might also be a reasonable option. I'm a bit less keen on `llvm_checker` as the name, but not strongly opposed. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:38

r358441 - [clang-format] Fix -Wconversion-null warning in GCC

Author: reuk Date: Mon Apr 15 13:13:20 2019 New Revision: 358441 URL: http://llvm.org/viewvc/llvm-project?rev=358441&view=rev Log: [clang-format] Fix -Wconversion-null warning in GCC GCC -Wconversion-null warning appeared after 9a63380260860b657b72f07c4f0e61e382ab934a. There was a similar proble

[PATCH] D60726: Fixed -Wconversion-null warning in GCC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL358441: [clang-format] Fix -Wconversion-null warning in GCC (authored by reuk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r358445 - [OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD

Author: abataev Date: Mon Apr 15 13:38:10 2019 New Revision: 358445 URL: http://llvm.org/viewvc/llvm-project?rev=358445&view=rev Log: [OPENMP][NVPTX]Run parallel regions with num_threads clauses in SPMD mode. After the previous patch with the more correct handling of the number of threads in para

r358448 - Time profiler: small fixes and optimizations

Author: anton-afanasyev Date: Mon Apr 15 14:02:47 2019 New Revision: 358448 URL: http://llvm.org/viewvc/llvm-project?rev=358448&view=rev Log: Time profiler: small fixes and optimizations Summary: Fixes from Roman's review here: https://reviews.llvm.org/D58675#1465336 Reviewers: lebedev.ri Subsc

[PATCH] D60663: Time profiler: small fixes and optimizations

This revision was automatically updated to reflect the committed changes. Closed by commit rL358448: Time profiler: small fixes and optimizations (authored by anton-afanasyev, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.org/D60663?vs=195069

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda marked an inline comment as done. hintonda added a comment. In D59802#1467363 , @aaron.ballman wrote: > LGTM aside from a nit and the ultimate name for the `isa_and_nonnull<>` API. Thanks. I'll ping the list again at the end of the week, then

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda marked an inline comment as done. hintonda added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:382 + if module == 'llvm' or module == 'clang': +namespace = module + '_checker' + else: aaron.ballman wrote: > I thought we

[PATCH] D59673: [Driver] Allow setting the DWO name DWARF attribute separately

dblaikie added a comment. In D59673#1465975 , @aaronpuchert wrote: > In D59673#1461983 , @dblaikie wrote: > > > Sure, I think the naming's a bit weird (but hard to come up with good names > > for any of this) > >

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso, jdenny. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Just wanted to give a bit more

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I think this functionality is unused because you would split the file into six to reduce the overhead/scroll and that is it. It is a cool reveal, could you provide a documentation? Repos

[PATCH] D60732: [analyzer] NFC: Use -verify=... in MoveChecker tests.

riccibruno added a comment. This is also very useful to test that a given warning is only emitted in c++xx. Funnily when grepping for `verify=` in `test/` most matches are from tests exercising this functionality. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60

[PATCH] D60735: [FileSystemStatCache] Return std::error_code from stat cache methods

harlanhaskins created this revision. harlanhaskins added a reviewer: benlangmuir. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Previously, we would return true/false signifying if the cache/lookup succeeded or failed. Instead, provide clients with the underlyin

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington, arphaman. ahatanak added a project: clang. Herald added subscribers: dexonsmith, jkorous. If the block implicitly referencing `self` doesn't escape, there is no risk of creating retain cycles, so clang shouldn't

[PATCH] D60735: [FileSystemStatCache] Return std::error_code from stat cache methods

benlangmuir added a comment. LGTM, but I'd appreciate someone who has worked on this more recently taking a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60735/new/ https://reviews.llvm.org/D60735 _

[PATCH] D40381: Parse concept definition

rsmith added a comment. Thanks! Please revert the (presumably unintended) mode changes to the `ptxas` executables. Comment at: include/clang/AST/DeclTemplate.h:3035 + SourceRange getSourceRange() const override LLVM_READONLY { +return SourceRange(getLocation(), getLocati

[PATCH] D60543: [clang] Add matcher for subclasses of Objective-C interfaces 🔍

stephanemoore planned changes to this revision. stephanemoore added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:1479 +/// \endcode +AST_MATCHER_P(ObjCInterfaceDecl, isSubclassOfInterface, + internal::Matcher, aaron.ball

[PATCH] D60674: [X86] Restore the pavg intrinsics.

efriedma added a comment. Okay, thanks. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60674/new/ https://reviews.llvm.org/D60674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

ahatanak added a comment. Sorry, clang was failing to diagnose `self` referenced inside a c++ lambda that was nested inside a block. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60736/new/ https://reviews.llvm.org/D60736 _

[PATCH] D59802: [clang-tidy] Add new checker: llvm-prefer-isa-or-dyn-cast-in-conditionals

hintonda updated this revision to Diff 195270. hintonda added a comment. - Alphabetize registration calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59802/new/ https://reviews.llvm.org/D59802 Files: clang-tools-extra/clang-tidy/llvm/CMakeLis

r358463 - Simplify diagnosis of misplaced attributes in module-declarations.

Author: rsmith Date: Mon Apr 15 16:55:58 2019 New Revision: 358463 URL: http://llvm.org/viewvc/llvm-project?rev=358463&view=rev Log: Simplify diagnosis of misplaced attributes in module-declarations. No functional change intended. Modified: cfe/trunk/lib/Parse/Parser.cpp Modified: cfe/trunk

[PATCH] D60736: [Sema][ObjC] Don't warn about a block implicitly retaining self if the block is marked noescape

erik.pilkington added a comment. Akira and I were just talking about an alternative approach to this: Keep a vector of pairs of BlockDecls and SourceLocations in the enclosing method's FunctionScopeInfo, and emit any unsuppressed diagnostics when popping the method. This would avoid having to

[PATCH] D60739: [analyzer] NFC: Re-use reusable unittest mocks.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. Put them into a dedicated header, as i'

r358464 - DebugInfo: Default to standalone debug when tuning for LLDB

Author: dblaikie Date: Mon Apr 15 17:16:29 2019 New Revision: 358464 URL: http://llvm.org/viewvc/llvm-project?rev=358464&view=rev Log: DebugInfo: Default to standalone debug when tuning for LLDB LLDB can't currently handle Clang's default (limit/no-standalone) DWARF, so platforms that default to

[PATCH] D59806: [clang-tidy] Add a check for [super self] in initializers 🔍

stephanemoore added inline comments. Comment at: clang-tools-extra/clang-tidy/objc/SuperSelfCheck.cpp:57 +/// \endcode +AST_MATCHER_P(ObjCImplementationDecl, isSubclassOf, + ast_matchers::internal::Matcher, stephanemoore wrote: > aaron.ballman wrote:

[PATCH] D56571: [RFC prototype] Implementation of asm-goto support in clang

void added a comment. In D56571#1467358 , @craig.topper wrote: > I think things don't work right unless you disable the integrated assembler. > I'm not sure why though. Using `-no-integrated-as` does allow it to compile, but it doesn't link (with ld.l

[PATCH] D60629: [clang-tidy] Change the namespace for llvm checkers from 'llvm' to 'llvm_check'

hintonda updated this revision to Diff 195278. hintonda added a comment. - Change `llvm_checker` to `llvm_check`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60629/new/ https://reviews.llvm.org/D60629 Files: clang-tools-extra/clang-tidy/add_ne

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet, mgorny. Herald added a project: clang. D44934

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ updated this revision to Diff 195279. NoQ added a comment. Fix test file name in the top comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60742/new/ https://reviews.llvm.org/D60742 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/string.c clang/u

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

NoQ updated this revision to Diff 195280. NoQ added a comment. Whoops, copy-paste error. So, like, the reason why i added a unittest was that i wanted to test separation of concerns: that it's specifically our Store that works correctly, not only the system as a whole. CHANGES SINCE LAST ACTI

r358467 - PR41192: fix cases where "missing '; ' after class" error would

Author: rsmith Date: Mon Apr 15 17:47:45 2019 New Revision: 358467 URL: http://llvm.org/viewvc/llvm-project?rev=358467&view=rev Log: PR41192: fix cases where "missing ';' after class" error would incorrectly fire. Modified: cfe/trunk/lib/Parse/ParseDeclCXX.cpp cfe/trunk/test/CXX/cpp/cpp.m

[PATCH] D60742: [analyzer] RegionStore: Enable loading default bindings from variables.

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM. Comment at: clang/unittests/StaticAnalyzer/StoreTest.cpp:20 +// back from that variable. Test what happens if default bindings are used. +class VariableBindConsum

[PATCH] D60455: [SYCL] Add support for SYCL device attributes

keryell accepted this revision. keryell added inline comments. Comment at: clang/include/clang/Basic/Attr.td:1000 +def SYCLDevice : InheritableAttr { + let Spellings = [GNU<"sycl_device">]; + let Subjects = SubjectList<[Function, Var]>; aaron.ballman wrote: > a

RE: r358355 - [c++20] Enable driver and frontend support for building and using

Hi Richard, The driver test you added (modules.cpp) seems to fail if the compiler configuration uses an external assembler. Is there any way that the test can be rewritten so that it works with both the integrated and an external assembler configurations? Douglas Yung -Original Message---

r358470 - Tweak test to pass when using a non-integrated assembler.

Author: rsmith Date: Mon Apr 15 18:44:53 2019 New Revision: 358470 URL: http://llvm.org/viewvc/llvm-project?rev=358470&view=rev Log: Tweak test to pass when using a non-integrated assembler. Modified: cfe/trunk/test/Driver/modules.cpp Modified: cfe/trunk/test/Driver/modules.cpp URL: http://

Re: r358355 - [c++20] Enable driver and frontend support for building and using

On Mon, 15 Apr 2019 at 18:14, via cfe-commits wrote: > > Hi Richard, > > The driver test you added (modules.cpp) seems to fail if the compiler > configuration uses an external assembler. Is there any way that the test can > be rewritten so that it works with both the integrated and an external

[PATCH] D59754: [Sema] Add c++2a designated initializer warnings

rsmith added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:2017 + auto LastIdx = Field != FieldEnd + ? Field->getFieldIndex() Please use an actual type rather than `auto` here and below. Comment at: cla

RE: r358355 - [c++20] Enable driver and frontend support for building and using

Hi Richard, That helps a little bit! Our main problem is that the environment where the compiler is built and tested (using lit) does not have the external assembler installed, so all of the compiler commands which try to use "-c" fail when trying to run the external assembler. I find that if I

Re: r358355 - [c++20] Enable driver and frontend support for building and using

On Mon, 15 Apr 2019, 19:08 via cfe-commits, wrote: > Hi Richard, > > That helps a little bit! Our main problem is that the environment where > the compiler is built and tested (using lit) does not have the external > assembler installed, so all of the compiler commands which try to use "-c" > fai

Re: r357340 - Adds `-ftime-trace` option to clang that produces Chrome `chrome://tracing` compatible JSON profiling output dumps.

> > > *Ideas on how to improve the backend situation:* > *- Let FPPassManager::runOnFunction() call* > *if (ProfileTime)* > *llvm::timeTraceProfilerBegin("RunPass", FP->getPassName());* > * for each pass so that it's visible which path the time goes into* > In my tests (which I admitt

[PATCH] D59744: Fix i386 ABI "__m64" type bug

wxiao3 updated this revision to Diff 195291. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59744/new/ https://reviews.llvm.org/D59744 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/vector.c test/CodeGen/x86_32-arguments-darwin.c test/CodeGen/x86_32-arguments-linux.c test/CodeGe

[PATCH] D60748: Fix i386 struct and union parameter alignment

wxiao3 created this revision. wxiao3 added reviewers: annita.zhang, LuoYuanke, smaslov, hjl.tools, RKSimon, rnk, andreadb. wxiao3 added a project: clang. Herald added a subscriber: cfe-commits. According to i386 System V ABI 2.1: Structures and unions assume the alignment of their most strictly a

RE: r358355 - [c++20] Enable driver and frontend support for building and using

Both work, although using -### requires a few more changes to the test than just changing –c to –S because all arguments are enclosed in double quotes. I think it would be simplest to just change “-c” to “-S” , and if that is okay with you, I can make the change. Douglas Yung From: Richard Smi

[PATCH] D60749: [Test] Remove obsolete test.

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, aaron.ballman, tyler.nowicki, TylerNowicki. Meinersbur added a project: clang. The FIXME of this test case has been addressed in r335084/r338800. Its execution still does not succeed because of multiple syntax errors. First,

[PATCH] D58033: Add option for emitting dbg info for call sites

aprantl added inline comments. Comment at: include/clang/Driver/Options.td:919 HelpText<"Do not use jump tables for lowering switches">; +def emit_param_entry_values : Joined<["-"], "femit-param-entry-values">, + Group, I assume that this

[PATCH] D58035: [clang/DIVar] Emit flag for params that have unchanged values

aprantl added inline comments. Comment at: lib/CodeGen/CGDebugInfo.cpp:4537 + CGM.getLangOpts().Optimize) { +for (auto &SP : DeclCache) { + auto *D = SP.first; Just looking at the type declarations in CGDebugInfo.h: Why not iterate over the `SPCach

[PATCH] D58033: Add option for emitting dbg info for call sites

djtodoro marked an inline comment as done. djtodoro added inline comments. Comment at: include/clang/Driver/Options.td:919 HelpText<"Do not use jump tables for lowering switches">; +def emit_param_entry_values : Joined<["-"], "femit-param-entry-values">, +

[PATCH] D59264: [Driver] Support compiler-rt crtbegin.o/crtend.o for Linux

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thank you for unifying `crtbegin{,S,T}.o` 😊 I hope Android people can make their `crtbegin*.o` files simpler, one day.. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59264/new/ htt

<    1   2