r359964 - [c++20] Implement tweaked __VA_OPT__ rules from P1042R1:

Author: rsmith Date: Fri May 3 23:46:18 2019 New Revision: 359964 URL: http://llvm.org/viewvc/llvm-project?rev=359964&view=rev Log: [c++20] Implement tweaked __VA_OPT__ rules from P1042R1: * __VA_OPT__ is expanded if the *expanded* __VA_ARGS__ is non-empty, not if the original argument conta

r359962 - Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives

Author: rsmith Date: Fri May 3 22:20:14 2019 New Revision: 359962 URL: http://llvm.org/viewvc/llvm-project?rev=359962&view=rev Log: Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives where either the modification or the other access is unreachable. Modified: cfe/trunk/incl

r359960 - Reduce amount of work ODR hashing does.

Author: rtrieu Date: Fri May 3 21:22:33 2019 New Revision: 359960 URL: http://llvm.org/viewvc/llvm-project?rev=359960&view=rev Log: Reduce amount of work ODR hashing does. When a FunctionProtoType is in the original type in a DecayedType, the decayed type is a PointerType which points back the o

r359958 - Disallow the operand of __builtin_constant_p from modifying enclosing

Author: rsmith Date: Fri May 3 21:00:45 2019 New Revision: 359958 URL: http://llvm.org/viewvc/llvm-project?rev=359958&view=rev Log: Disallow the operand of __builtin_constant_p from modifying enclosing state when it's encountered while evaluating a constexpr function. We attempt to follow GCC tr

[PATCH] D61545: [analyzer] Fix a crash in RVO from within blocks.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. While blocks are an Apple extension to

[PATCH] D61454: [CodeGen][ObjC] Remove the leading 'l_' from ObjC symbols and make private symbols in the __DATA segment internal.

ahatanak updated this revision to Diff 198118. ahatanak added a comment. Make sure private linkage is replaced with internal linkage only when the object file format is MachO. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61454/new/ https://reviews.llvm.org/D614

r359954 - [Driver] Create non-existent directory for -fcrash-diagnostics-dir

Author: phosek Date: Fri May 3 17:55:14 2019 New Revision: 359954 URL: http://llvm.org/viewvc/llvm-project?rev=359954&view=rev Log: [Driver] Create non-existent directory for -fcrash-diagnostics-dir When user specifies non-existent directory to -fcrash-diagnostics-dir, create it rather than fail

[PATCH] D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir

This revision was automatically updated to reflect the committed changes. Closed by commit rL359954: [Driver] Create non-existent directory for -fcrash-diagnostics-dir (authored by phosek, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

r359953 - [cxx_status] Don't list -fmodules / -fmodules-ts against C++ modules

Author: rsmith Date: Fri May 3 17:27:21 2019 New Revision: 359953 URL: http://llvm.org/viewvc/llvm-project?rev=359953&view=rev Log: [cxx_status] Don't list -fmodules / -fmodules-ts against C++ modules support; those turn on different modules modes. The real C++ modules support is behind -std=c++2

r359951 - [cxx_status] Replace "SVN" entries with Clang 8 as appropriate.

Author: rsmith Date: Fri May 3 17:23:18 2019 New Revision: 359951 URL: http://llvm.org/viewvc/llvm-project?rev=359951&view=rev Log: [cxx_status] Replace "SVN" entries with Clang 8 as appropriate. Also: use the "svn" color for "explicit(bool)" rather than the "full" color. Modified: cfe/trun

Buildbot numbers for the week of 04/21/2019 - 04/27/2019

Hello everyone, Below are some buildbot numbers for the last week of 04/21/2019 - 04/27/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 04/07/2019 - 04/13/2019

Hello everyone, Below are some buildbot numbers for the week of 04/07/2019 - 04/13/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 04/14/2019 - 04/20/2019

Hello everyone, Below are some buildbot numbers for the week of 04/14/2019 - 04/20/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. In D61165#1490608 , @rjmccall wrote: > The flip side of that argument is that (1) there aren't very many users right > now and (2) it's much easier to start conservative and then weaken the rule > than it will be to stren

[PATCH] D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61542/new/ https://reviews.llvm.org/D61542 ___ cfe-commits mailing

[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

gkistanova accepted this revision. gkistanova added a comment. This revision is now accepted and ready to land. Thanks for fixing this, Vlad! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61345/new/ https://reviews.llvm.org/D61345 _

r359947 - CWG issue 727: Fix numerous bugs in support for class-scope explicit

Author: rsmith Date: Fri May 3 16:51:38 2019 New Revision: 359947 URL: http://llvm.org/viewvc/llvm-project?rev=359947&view=rev Log: CWG issue 727: Fix numerous bugs in support for class-scope explicit specializations for variable templates. Modified: cfe/trunk/include/clang/AST/Decl.h cf

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. The flip side of that argument is that (1) there aren't very many users right now and (2) it's much easier to start conservative and then weaken the rule than it will be to strengthen it later. It really isn't acceptable to just turn off access/use-checking for the de

[PATCH] D61542: [Driver] Create non-existent directory for -fcrash-diagnostics-dir

phosek created this revision. phosek added reviewers: hans, inglorion, rnk, thakis. Herald added a project: clang. Herald added a subscriber: cfe-commits. When user specifies non-existent directory to -fcrash-diagnostics-dir, create it rather than failing with an error. Repository: rC Clang h

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198108. gtbercea added a comment. - Add new tests. Add stub headers. - Remove old tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cpp li

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

This revision was automatically updated to reflect the committed changes. Closed by commit rL359943: [clang-format] Fix bug in block comment reflow that joins * and / (authored by owenpan, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea updated this revision to Diff 198105. gtbercea added a comment. - Add driver test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 Files: lib/Driver/ToolChains/Clang.cpp lib/Headers/CMakeLists.txt lib/Heade

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

owenpan updated this revision to Diff 198057. owenpan added a comment. Updated the test cases to make them precise and more varied. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 Files: clang/lib/Format/BreakableToken.

r359943 - [clang-format] Fix bug in block comment reflow that joins * and /

Author: owenpan Date: Fri May 3 16:15:40 2019 New Revision: 359943 URL: http://llvm.org/viewvc/llvm-project?rev=359943&view=rev Log: [clang-format] Fix bug in block comment reflow that joins * and / Fixes PR41213 Differential Revision: https://reviews.llvm.org/D61276 Modified: cfe/trunk/li

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

ldionne added a comment. I've only been lurking but FWIW (1) above makes the most sense to me, unless the Standard clearly draws a distinction between *constructed* and *initialized* in the way that was described, in which case (3) is the right approach. However, I would wait for at least a CWG

[PATCH] D61506: [OpenCL] Switch to C++17

rsmith added a comment. Per the OpenCL C++ 1.0 specification, section 2: > The OpenCL C++ programming language is based on the ISO/IEC JTC1 SC22 WG21 N > 3690 language specification (a.k.a. C++14 specification). I think it would be reasonable to permit changing the base C++ standard in OpenCL

[PATCH] D61365: [libcxx] [test] Suppress float->int narrowing warning in vector range-construction test.

CaseyCarter added inline comments. Comment at: test/std/containers/sequences/vector/vector.cons/construct_iter_iter.pass.cpp:159 float array[3] = {0.0f, 1.0f, 2.0f}; +#pragma warning(suppress: 4244) // narrowing float to int std::vector v(array, array + 3); ---

[PATCH] D54784: Use --push/pop-state with XRay link deps

phosek abandoned this revision. phosek added a comment. Herald added a project: clang. Turned out this is not the right approach because not every linker supports `--push-state`/`--pop-state` but I'm hoping to instead rely on ELF autolinking once D60274 lands.

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. In D61165#1490417 , @erik.pilkington wrote: > In D61165#1490168 , @rjmccall wrote: > > > I think the intuitive rule is that initialization is complete when the > > full-expression perform

[PATCH] D60974: Clang IFSO driver action.

compnerd added a comment. @rupprecht - actually, I *really* like the idea of putting the experimental in the name. Also agree with you on the `ifo` vs `ifso`. Although, if we go with `ifo`, I would prefer to bikeshed the option to `-emit-interface` (well with the experimental stuck in as well

[PATCH] D61506: [OpenCL] Switch to C++17

keryell added inline comments. Comment at: include/clang/Frontend/LangStandards.def:162 OpenCL, "OpenCL C++ 1.0", - LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus14 | Digraphs | OpenCL) + LineComment | CPlusPlus | CPlusPlus11 | CPlusPlus1

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall created this revision. Herald added subscribers: cfe-commits, kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. The hope is this will catch a few patterns with repetition: SomeClass* S = ^SomeClass::Create() int getFrobnicator() { return ^f

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC359932: [COFF, ARM64] Fix ABI implementation of struct returns (authored by mgrang, committed by ). Repository: rC Clan

r359932 - [COFF, ARM64] Fix ABI implementation of struct returns

Author: mgrang Date: Fri May 3 14:12:24 2019 New Revision: 359932 URL: http://llvm.org/viewvc/llvm-project?rev=359932&view=rev Log: [COFF, ARM64] Fix ABI implementation of struct returns Summary: Related llvm patch: D60348. Patch co-authored by Sanjin Sijaric. Reviewers: rnk, efriedma, TomTan,

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. In D61165#1490168 , @rjmccall wrote: > I think the intuitive rule is that initialization is complete when the > full-expression performing the initialization is complete because that's the > normal unit of sequencing. No

[PATCH] D61496: Fixed tests where grep was not matching the linefeed

lebedev.ri accepted this revision. lebedev.ri added a comment. This revision is now accepted and ready to land. Sure, this looks better. Comment at: clang/trunk/test/Preprocessor/indent_macro.c:1-2 -// RUN: %clang_cc1 -E %s | grep '^ zzap$' +// RUN: %clang_cc1 -E %s | FileChe

[PATCH] D60974: Clang IFSO driver action.

rupprecht added a comment. I didn't follow the technical details, but I don't see anything wrong with moving forward on this patch. I think this seems like an interesting idea worth experimenting with. In D60974#1488563 , @jakehehrlich wrote: > > Jake,

[PATCH] D61097: [Sema] Emit warning for visibility attribute on internal-linkage declaration

scott.linder added a comment. Richard Smith on cfe-dev pointed out some cases where this patch is incorrect, stemming from trying to calculate the linkage too early; the warning will either have to work without the use of `isExternallyVisible` or will have to be emitted later. This was reverted

[PATCH] D61530: Add AIX Version Macros

sfertile accepted this revision. sfertile added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61530/new/ https://reviews.llvm.org/D61530 ___ cfe-commit

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

rjmccall added inline comments. Comment at: test/CodeGenCXX/address-space-of-this.cpp:9 +//CHECK: call void @_ZN6MyTypeC1Ei(%struct.MyType* addrspacecast (%struct.MyType addrspace(10)* @m to %struct.MyType*), i32 123) +MyType __attribute__((address_space(10))) m = 123; -

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr added a comment. > Can you add tests for the bugs you fixed? thanks The bugs were detected by existing tests (those tests triggered the newly added assertions). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61522/new/ https://reviews.ll

[PATCH] D61530: Add AIX Version Macros

andusy created this revision. andusy added reviewers: hubert.reinterpretcast, jasonliu, sfertile, xingxue. andusy added a project: clang. Herald added a subscriber: jsji. - This patch checks the AIX version and defines the appropriate macros. - Follow up to a comment

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added a comment. In D59474#1490235 , @lildmh wrote: > Hi Alexey, > > Let's discuss your runtime data mapping scheme next week first. After that we > will continue the review of this. That would be good, thanks! Comment at: li

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked 3 inline comments as done. lildmh added a comment. Hi Alexey, Let's discuss your runtime data mapping scheme next week first. After that we will continue the review of this. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8530 + // dynamically. + QualType

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

hfinkel added a comment. > It is up to you. I don't have strong objections if you think this will work > as required. Just the tests must be fixed, especially codegen tests. Thanks, Alexey. I think this will work as required, and then we'll be able to update it when we get declare variant. Agre

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

thakis added a comment. Thanks for the context. Sounds great :) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61269/new/ https://reviews.llvm.org/D61269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

r359918 - Ensure there is stack usage in stack size warning test

Author: arsenm Date: Fri May 3 12:04:14 2019 New Revision: 359918 URL: http://llvm.org/viewvc/llvm-project?rev=359918&view=rev Log: Ensure there is stack usage in stack size warning test r359906 broke this because the only stack usage was from a spill which can be avoided since the only block is

[PATCH] D61270: [CommandLine] Enable Grouping for short options by default. Part 4 of 5

This revision was automatically updated to reflect the committed changes. Closed by commit rL359917: [CommandLine] Enable Grouping for short options by default. Part 4 of 5 (authored by dhinton, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://reviews.llvm.

r359916 - Attempt to fix the clang-sphinx-docs bot after r358797

Author: nico Date: Fri May 3 11:54:18 2019 New Revision: 359916 URL: http://llvm.org/viewvc/llvm-project?rev=359916&view=rev Log: Attempt to fix the clang-sphinx-docs bot after r358797 Modified: cfe/trunk/docs/analyzer/checkers.rst Modified: cfe/trunk/docs/analyzer/checkers.rst URL: http:/

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

ABataev added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8021 + /// the extracted map clauses. + void generateAllInfoForMapper(MapBaseValuesArrayTy &BasePointers, +MapValuesArrayTy &Pointers, lildmh wrote: > ABa

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

hintonda added a comment. In D61269#1490176 , @thakis wrote: > I happened to see this go by. Is there an explanation of the overall goal > somewhere? In general, requiring -- for long flags sounds like a great change > to me, but there are a few exceptio

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:5784 Expr::EvalResult Result; -if (CollapseLoopCountExpr->EvaluateAsInt(Result, SemaRef.getASTContext())) +if (!CollapseLoopCountExpr->isValueDependent() && +!CollapseLoopCountExpr->isTy

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added a comment. In D61399#1490189 , @hfinkel wrote: > > Still, I think we need to prvide the default implementation of those > > non-standard functions (they can be very simple, maybe reporting error is > > going to be enough), which can be over

r359913 - Remove else-after-return

Author: dblaikie Date: Fri May 3 11:11:31 2019 New Revision: 359913 URL: http://llvm.org/viewvc/llvm-project?rev=359913&view=rev Log: Remove else-after-return Modified: cfe/trunk/lib/AST/ExprConstant.cpp Modified: cfe/trunk/lib/AST/ExprConstant.cpp URL: http://llvm.org/viewvc/llvm-project/

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

hfinkel added a comment. > Still, I think we need to prvide the default implementation of those > non-standard functions (they can be very simple, maybe reporting error is > going to be enough), which can be overriden by user. I appreciate your motivation, and I agree with you to some extent. I

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. The OpenMP part looks good. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61509/new/ https://reviews.llvm.org/D61509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D61474: [CUDA][Clang][Bugfix] Add missing CUDA 9.2 case

This revision was automatically updated to reflect the committed changes. Closed by commit rC359910: [CUDA][Clang][Bugfix] Add missing CUDA 9.2 case (authored by gbercea, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61474/new/ https://reviews.llvm

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

rjmccall added a comment. >>> That's only true for subobjects of an enclosing aggregate before that >>> aggregate's initialization is complete though, right? So it doesn't seem >>> like that much of an inconsistency, just mimicking what we would be doing >>> if an exception was thrown in, say,

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

Rakete added a comment. Can you add tests for the bugs you fixed? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61522/new/ https://reviews.llvm.org/D61522 ___ cfe-commits mailing list cfe-co

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh updated this revision to Diff 198050. lildmh added a comment. Fix code format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59474/new/ https://reviews.llvm.org/D59474 Files: include/clang/AST/GlobalDecl.h lib/AST/ASTContext.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGOpenMP

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny updated this revision to Diff 198046. jdenny edited the summary of this revision. jdenny added a comment. Herald added a subscriber: jfb. As discussed, implement OpenMP solution #1 (one-line change in `PragmaOpenMPHandler::HandlePragma` in `ParsePragma.cpp`), and update tests. CHANGES SI

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

thakis added a comment. I happened to see this go by. Is there an explanation of the overall goal somewhere? In general, requiring -- for long flags sounds like a great change to me, but there are a few exceptions: For example. lld-link should keep accepting long flags with a single dash for li

[PATCH] D59474: [OpenMP 5.0] Codegen support for user-defined mappers

lildmh marked 7 inline comments as done. lildmh added a comment. Hi Alexey, Again, thanks for your review! Sorry I didn't get back to you in time because I was distracted by other things. Please see the comments inline. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:8021 + ///

r359910 - [CUDA][Clang][Bugfix] Add missing CUDA 9.2 case

Author: gbercea Date: Fri May 3 10:59:18 2019 New Revision: 359910 URL: http://llvm.org/viewvc/llvm-project?rev=359910&view=rev Log: [CUDA][Clang][Bugfix] Add missing CUDA 9.2 case Summary: The bug was reported on the OpenMP-dev list: .../obj-release/lib/clang/9.0.0/include/__clang_cuda_intrins

[PATCH] D61269: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

This revision was automatically updated to reflect the committed changes. Closed by commit rL359909: [CommandLine] Change help output to prefix long options with `--` instead of `… (authored by dhinton, committed by ). Herald added a subscriber: kristina. Changed prior to commit: https://review

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

aaron.ballman added inline comments. Comment at: clang-tidy/misc/RedundantExpressionCheck.cpp:135-137 +const UnaryExprOrTypeTraitExpr *LeftUnaryExpr = +cast(Left); +const UnaryExprOrTypeTraitExpr *RightUnaryExpr = `const auto *` since you already

r359909 - [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5

Author: dhinton Date: Fri May 3 10:47:29 2019 New Revision: 359909 URL: http://llvm.org/viewvc/llvm-project?rev=359909&view=rev Log: [CommandLine] Change help output to prefix long options with `--` instead of `-`. NFC . Part 3 of 5 Summary: By default, `parseCommandLineOptions()` will accept e

[PATCH] D48292: use modern type trait implementations when available

thakis added a comment. Done in r359907, thanks! Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org/D48292/new/ https://reviews.llvm.org/D48292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D61438: [ASTImporter] Use llvm::Expected and Error in the importer API

jingham added a comment. IIUC, when Expected returns fails, it returns an Error object that might have information about what went wrong. Would it be possible to include the contents of that error n the log message? We often get "I can't run an expression in a really complex proprietary code

[PATCH] D61281: [clang-format] Fixed self assignment

MyDeveloperDay added a comment. In D61281#1488022 , @RKSimon wrote: > In D61281#1485833 , @MyDeveloperDay > wrote: > > > Did this cause some issue? Does this fix something if so can we add a test, > > because mayb

[PATCH] D61276: [clang-format] Fix bug in block comment reflow that joins * and /

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61276/new/ https://reviews.llvm.org/D61276 __

[PATCH] D55125: [clang-tidy] Fix a false positive in misc-redundant-expression check

dkrupp updated this revision to Diff 198041. dkrupp marked 6 inline comments as done. dkrupp added a comment. I have fixed all your comments and rebased the patch to the latest master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55125/new/ https://reviews.llvm.org/D55125 Files: cla

[PATCH] D61522: Added an assertion to constant evaluation enty points that prohibits dependent expressions

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Constant evaluator does not work on value-dependent or type-dependent expressions. Also fixed bugs uncovered by these assertions. Repository: rG LLVM Github Monorepo https://reviews.llvm.o

[PATCH] D48292: use modern type trait implementations when available

ldionne added a comment. In D48292#1490060 , @thakis wrote: > This test is broken with Xcode 9: > > [...] > > > Does this just need an `// XFAIL: apple-clang-9` or is this unexpected? This seems to have been fixed in LLVM Clang trunk since the 8 releas

[PATCH] D61165: Fix a crash where a [[no_destroy]] destructor was not emitted in an array

erik.pilkington added a comment. In D61165#1488657 , @rjmccall wrote: > In D61165#1488553 , @erik.pilkington > wrote: > > > In D61165#1487328 , @rjmccall > > wrote: > > > >

[PATCH] D48292: use modern type trait implementations when available

thakis added a comment. This test is broken with Xcode 9: -- Testing: 53613 tests, 8 threads -- Testing: 0 .. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90 FAIL: libc++ :: std/utilities/meta/meta.unary/meta.unary.prop/is_trivially_destructible.pass.cpp (50845 of 53613)

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

tra added inline comments. Comment at: clang/include/clang/Sema/Sema.h:10407-10409 bool IsAllowedCUDACall(const FunctionDecl *Caller, const FunctionDecl *Callee) { +if (llvm::any_of(ExprEvalContexts, hliao wrote: > tra wrote: > >

[PATCH] D61318: [Sema] Prevent binding references with mismatching address spaces to temporaries

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61318/new/ https://reviews.llvm.org/D61318 ___ cfe-commits mailing list cfe-comm

[PATCH] D60454: [OpenCL] Prevent mangling kernel functions

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60454/new/ https://reviews.llvm.org/D60454 ___ cfe-commits mailing list cfe-comm

[PATCH] D61519: [clangd] Support -fallback-style, similar to clang-format.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D61519 Files: clangd/tool/ClangdMain.cpp Inde

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. Thanks for explaining. I'll proceed with solution #1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61509/new/ https://reviews.llvm.org/D61509 ___ cfe-commits mailing list cfe-

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. In D61509#1489845 , @jdenny wrote: > In D61509#1489771 , @ABataev wrote: > > > In D61509#1489761 , @jdenny wrote: > > > > > In D61509#1489752

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1489771 , @ABataev wrote: > In D61509#1489761 , @jdenny wrote: > > > In D61509#1489752 , @ABataev wrote: > > > > > If the patch is going to

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus requested review of this revision. Szelethus marked an inline comment as done. Szelethus added a comment. I changed the testfiles quite a bit, surprisingly, I'd appreciate another accept on this one please :) Seems to me that the changes describe the actual reports far better... ===

[PATCH] D54757: [clang-tidy] new check: bugprone-branch-clone

Szelethus updated this revision to Diff 198025. Szelethus added a comment. FIx the above mentioned crash. diff --git a/clang-tidy/bugprone/BranchCloneCheck.cpp b/clang-tidy/bugprone/BranchCloneCheck.cpp index f371231..a898311 100644 --- a/clang-tidy/bugprone/BranchCloneCheck.cpp +++ b/cl

[PATCH] D60349: [COFF, ARM64] Fix ABI implementation of struct returns

richard.townsend.arm added a comment. Just completed testing... everything seems to be working correctly. So long as the all the tests pass, let's commit! :D CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60349/new/ https://reviews.llvm.org/D60349

[PATCH] D61518: [clangd] add CLANG_ENABLE_CLANGD option to build clangd. Require threads.

sammccall created this revision. sammccall added a reviewer: gribozavr. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D61518 Files: CMakeLists.txt

[PATCH] D61508: [clang-tidy] misc-header-guard : a simple version of llvm-header-guard

Eugene.Zelenko added inline comments. Comment at: clang-tidy/misc/HeaderGuardCheck.cpp:21 + StringRef OldGuard) { + if (OldGuard.size()) { +return OldGuard; Please use early return. Comment a

[PATCH] D61335: [LibTooling] Add support to Transformer for composing rules as an ordered choice.

ymandel added a comment. In D61335#1489680 , @ilya-biryukov wrote: > > As for naming, agreed, but does that concern drop away once we have only a > > single RewriteRule definition? > > Sure, that won't be an issue. > > The use-cases make sense, thanks fo

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea added a comment. In D61399#1489762 , @ABataev wrote: > In D61399#1489757 , @gtbercea wrote: > > > @ABataev this patch works for both C and C++ and for both math.h and cmath > > headers. > > > Did you test

[PATCH] D61458: [hip] Relax CUDA call restriction within `decltype` context.

jlebar added a comment. > At [nvcc] from CUDA 10, that's not acceptable as we are declaring two > functions only differ from the return type. It seems CUDA attributes do not > contribute to the function signature. clang is quite different here. Yes, this is an intentional and more relaxed seman

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. In D61509#1489761 , @jdenny wrote: > In D61509#1489752 , @ABataev wrote: > > > If the patch is going to be accepted, then definitely it must be solution > > #1. > > > I certainly have no ob

[PATCH] D60678: [libclang] Forward isInline for NamespaceDecl to libclang

yvvan added a comment. Seems so. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60678/new/ https://reviews.llvm.org/D60678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D60379: Make precompiled headers reproducible

Anastasia added a comment. Can this be closed now due to commit r358674? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60379/new/ https://reviews.llvm.org/D60379 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

ABataev added a comment. In D61399#1489757 , @gtbercea wrote: > @ABataev this patch works for both C and C++ and for both math.h and cmath > headers. Did you test it for the builtins? like `pow`, `powf` and `powl`? How are the builtins resolved with th

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1489752 , @ABataev wrote: > If the patch is going to be accepted, then definitely it must be solution #1. I certainly have no objection to that and will be happy to implement it, but can you help me to understand the ra

[PATCH] D61399: [OpenMP][Clang] Support for target math functions

gtbercea added a comment. @ABataev this patch works for both C and C++ and for both math.h and cmath headers. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61399/new/ https://reviews.llvm.org/D61399 ___ cfe-commits

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. If the patch is going to be accepted, then definitely it must be solution #1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61509/new/ https://reviews.llvm.org/D61509 ___ cfe-c

[PATCH] D59988: [PR41276] Generate address space cast of 'this' for objects attributed by an address space in C++

Anastasia marked an inline comment as done. Anastasia added inline comments. Comment at: test/CodeGenCXX/address-space-of-this.cpp:9 +//CHECK: call void @_ZN6MyTypeC1Ei(%struct.MyType* addrspacecast (%struct.MyType addrspace(10)* @m to %struct.MyType*), i32 123) +MyType __attrib

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny created this revision. jdenny added reviewers: ABataev, rnk, Eugene.Zelenko, akyrtzi, rsmith. Herald added subscribers: jdoerfert, dexonsmith, guansong. Herald added a project: clang. Currently, an OpenMP AST node's recorded location starts at the `omp` token after the `#pragma` token, and

  1   2   >