[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

lebedev.ri added a comment. In D61509#1491397 , @jdenny wrote: > In D61509#1491209 , @ABataev wrote: > > > In D61509#1491204 , @lebedev.ri > > wrote: > > > > > In D61509#149

[PATCH] D61472: [X86FixupLEAs] Turn optIncDec into a generic two address LEA optimizer. Support LEA64_32r properly.

craig.topper updated this revision to Diff 198220. craig.topper added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61472/new/ https://reviews.llvm.org/D61472

r360011 - P1286R2: Remove restriction that the exception specification of a

Author: rsmith Date: Sun May 5 22:04:56 2019 New Revision: 360011 URL: http://llvm.org/viewvc/llvm-project?rev=360011&view=rev Log: P1286R2: Remove restriction that the exception specification of a defaulted special member matches the implicit exception specification. Modified: cfe/trunk/inc

r360010 - Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives

Author: rsmith Date: Sun May 5 21:14:01 2019 New Revision: 360010 URL: http://llvm.org/viewvc/llvm-project?rev=360010&view=rev Log: Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives where either the modification or the other access is unreachable. This reverts r359984 (which

[clang-tools-extra] r360009 - Fix test to avoid assuming clang will diagnose problems in unreachable code.

Author: rsmith Date: Sun May 5 21:07:30 2019 New Revision: 360009 URL: http://llvm.org/viewvc/llvm-project?rev=360009&view=rev Log: Fix test to avoid assuming clang will diagnose problems in unreachable code. Modified: clang-tools-extra/trunk/clangd/unittests/DiagnosticsTests.cpp Modified:

[clang-tools-extra] r360007 - Fix up after r360006.

Author: rsmith Date: Sun May 5 21:00:45 2019 New Revision: 360007 URL: http://llvm.org/viewvc/llvm-project?rev=360007&view=rev Log: Fix up after r360006. Modified: clang-tools-extra/trunk/clang-tidy/modernize/MakeSmartPtrCheck.cpp Modified: clang-tools-extra/trunk/clang-tidy/modernize/MakeS

r360006 - [c++20] Implement P1009R2: allow omitting the array bound in an array

Author: rsmith Date: Sun May 5 20:47:15 2019 New Revision: 360006 URL: http://llvm.org/viewvc/llvm-project?rev=360006&view=rev Log: [c++20] Implement P1009R2: allow omitting the array bound in an array new expression. This was voted into C++20 as a defect report resolution, so we retroactively a

[PATCH] D61345: Allow 'CodeGenObjC/illegal-UTF8.m' test for 32-bit targets.

This revision was automatically updated to reflect the committed changes. Closed by commit rL360005: The 'CodeGenObjC/illegal-UTF8.m' get failed with Clang built with 32-bit… (authored by gkistanova, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

r360005 - The 'CodeGenObjC/illegal-UTF8.m' get failed with Clang built with 32-bit targets only (as example ARM-only) with the following error:

Author: gkistanova Date: Sun May 5 20:30:09 2019 New Revision: 360005 URL: http://llvm.org/viewvc/llvm-project?rev=360005&view=rev Log: The 'CodeGenObjC/illegal-UTF8.m' get failed with Clang built with 32-bit targets only (as example ARM-only) with the following error: error: unable to create t

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1491209 , @ABataev wrote: > In D61509#1491204 , @lebedev.ri > wrote: > > > In D61509#1491158 , @jdenny wrote: > > > > > In D61509#1491119

[PATCH] D61559: Fix the crash when formatting unsupported encodings

owenpan updated this revision to Diff 198205. owenpan added a comment. Moved "UTF-32 (LE)" to before "UTF-16 (LE)" in `llvm::StringSwitch` so that the former BOM wouldn't be misnamed as the latter. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61559/new/ https:/

[PATCH] D43500: [clang-tidy]: modernize-use-default-member-init: Remove trailing comma and colon.

chgans added a comment. Hi, Using llvm-8 (llvm ubuntu repo), clang-replacement has improved, but there still a case when a comma is left beyond: if there was only one member init. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43500/new/ https://reviews.llvm.org/D43500 __

[PATCH] D61570: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, this definitely deserves to be a compound value. Could you also add a test that tries to load real/imaginary parts of `y` and compares them to 1? Just to know whether it actually works or just

[clang-tools-extra] r360002 - [clang-tidy] openmp-exception-escape check: point to the structured-block

Author: lebedevri Date: Sun May 5 14:26:32 2019 New Revision: 360002 URL: http://llvm.org/viewvc/llvm-project?rev=360002&view=rev Log: [clang-tidy] openmp-exception-escape check: point to the structured-block I'm not sure what i was thinking when i wrote it to point at the directive. It's at the

[PATCH] D40381: Parse concept definition

saar.raz added a comment. Awesome! I do not have commit permissions though, so can you do the actual commit? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40381/new/ https://reviews.llvm.org/D40381 ___ cfe-commits m

[PATCH] D40381: Parse concept definition

saar.raz updated this revision to Diff 198200. saar.raz marked 4 inline comments as done. saar.raz added a comment. - Address final CR comments by rsmith Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40381/new/ https://reviews.llvm.org/D40381 Files: include/cl

[PATCH] D61569: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive.

This revision was automatically updated to reflect the committed changes. Closed by commit rC359998: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as… (authored by Szelethus, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61

r359998 - [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive.

Author: szelethus Date: Sun May 5 12:42:33 2019 New Revision: 359998 URL: http://llvm.org/viewvc/llvm-project?rev=359998&view=rev Log: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive. https://bugs.llvm.org/show_bug.cgi?id=41741 Pretty much the same as D6124

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel updated this revision to Diff 198194. koldaniel added a comment. Typedef and macro maches fixed, new test cases added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33841/new/ https://reviews.llvm.org/D33841 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readabil

[PATCH] D33841: [clang-tidy] redundant keyword check

koldaniel marked an inline comment as done. koldaniel added inline comments. Comment at: test/clang-tidy/readability-redundant-extern.cpp:37 + +void another_file_scope(int _extern); aaron.ballman wrote: > More tests that I figured out: > ``` > namespace { > exter

[PATCH] D60568: [OpenMP] Add support for registering requires directives with the runtime

gtbercea marked an inline comment as done. gtbercea added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:10364 + if (const auto *FD = dyn_cast(D)) { +if (OMPDeclareTargetDeclAttr::isDeclareTargetDeclaration(FD)) { + HasEmittedDeclareTargetRegion = true; --

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

rsmith added a comment. In D36357#1491081 , @Rakete wrote: > @rsmith One last question: The fixit diagnostic seems to be inconsistent with > the rest? > > main.cpp:2:3: error: '[]' after delete interpreted as 'delete[]' > delete[] { return new i

[PATCH] D61519: [clangd] Support -fallback-style, similar to clang-format.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. LGTM Putting http://lists.llvm.org/pipermail/clangd-dev/2019-May/000411.html here for context. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D60552: [X86] Enable intrinsics of AVX512_BF16, which are supported for BFLOAT16 in Cooper Lake

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60552/new/ https://reviews.llvm.org/D60552 ___ cfe-commits mailing list c

r359984 - Revert rL359962 : Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives

Author: rksimon Date: Sun May 5 10:10:05 2019 New Revision: 359984 URL: http://llvm.org/viewvc/llvm-project?rev=359984&view=rev Log: Revert rL359962 : Use DiagRuntimeBehavior for -Wunsequenced to weed out false positives where either the modification or the other access is unreachable.

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

ABataev added a comment. In D61509#1491204 , @lebedev.ri wrote: > In D61509#1491158 , @jdenny wrote: > > > In D61509#1491119 , @lebedev.ri > > wrote: > > > > > I recommend t

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

lebedev.ri added a comment. In D61509#1491158 , @jdenny wrote: > In D61509#1491119 , @lebedev.ri > wrote: > > > I recommend to split this into two parts - changing `PragmaIntroducerKind > > Introducer` to > > `st

[PATCH] D61570: [analyzer] PR41753: Include complex integer types in NonLoc::isCompoundType

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, baloghadamsoftware, xazax.hun, rnkovacs, Charusso, a_sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. https:

[PATCH] D61569: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive.

Szelethus updated this revision to Diff 198180. Szelethus added a comment. Add a `TODO:`, since we actually don't emit a warning when we should -- I'm afraid that this won't be an easy fix though, similarly to ``__vector_size__``: D61246#inline-543357

[PATCH] D61569: [analyzer][UninitializedObjectChecker] PR41741: Regard all scalar types as primitive.

Szelethus created this revision. Szelethus added reviewers: NoQ, dcoughlin, baloghadamsoftware, gribozavr, xazax.hun, rnkovacs, Charusso, a_sidorin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperi

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

jdenny added a comment. In D61509#1491119 , @lebedev.ri wrote: > I recommend to split this into two parts - changing `PragmaIntroducerKind > Introducer` to > `struct NameMe { PragmaIntroducerKind Kind; SourceLocation Loc};`, and the > actual openmp chan

[PATCH] D61537: [clangd] Boost code completion results that were named in the last few lines.

sammccall updated this revision to Diff 198178. sammccall added a comment. Further tune numbers based on experiments. Remove stopwords due to new threshold. Fix tests. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61537/new/ https://reviews.llvm.org

[PATCH] D61566: Fix for bug 41747: AST Printer doesn't print nested name specifier for out of scope record definitions

dyatkovskiy created this revision. dyatkovskiy added a project: clang. Herald added a subscriber: cfe-commits. This fix adds out of scope member classes definitions support for AST Printer. Repository: rC Clang https://reviews.llvm.org/D61566 Files: clang/lib/AST/DeclPrinter.cpp clang/te

[PATCH] D61509: [PragmaHandler][OpenMP] Expose `#pragma` location

lebedev.ri added reviewers: aaron.ballman, lebedev.ri. lebedev.ri added a comment. I recommend to split this into two parts - changing `PragmaIntroducerKind Introducer` to `struct NameMe { PragmaIntroducerKind Kind; SourceLocation Loc};`, and the actual openmp change. For that change, just basin

[PATCH] D61552: [clang] Adapt ASTMatcher to explicit(bool) specifier

aaron.ballman requested changes to this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. You should also regenerate the documentation by running clang/docs/tools/dump_ast_matchers.py. Comment at: clang/include/clang/ASTMatchers/ASTMatcher

[PATCH] D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture

Rakete added a comment. You might want to consider getting commit access . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61556/new/ https://reviews.llvm.org/D61556 ___

[PATCH] D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture

This revision was automatically updated to reflect the committed changes. Closed by commit rC359980: [clang] fixing -ast-print for variadic parameter pack in lambda capture (authored by Rakete, committed by ). Changed prior to commit: https://reviews.llvm.org/D61556?vs=198155&id=198172#toc

r359980 - [clang] fixing -ast-print for variadic parameter pack in lambda capture

Author: rakete Date: Sun May 5 05:35:12 2019 New Revision: 359980 URL: http://llvm.org/viewvc/llvm-project?rev=359980&view=rev Log: [clang] fixing -ast-print for variadic parameter pack in lambda capture Summary: currently for: ``` template void f(T... t) { auto l = [t...]{}; } ``` `clang

r359979 - [C++] Interpret unknown identifier in parameter clause as unknown type

Author: rakete Date: Sun May 5 05:15:17 2019 New Revision: 359979 URL: http://llvm.org/viewvc/llvm-project?rev=359979&view=rev Log: [C++] Interpret unknown identifier in parameter clause as unknown type instead of as parameter name without a type. Modified: cfe/trunk/lib/Parse/ParseDecl

[PATCH] D60507: [clang-tidy] new check: bugprone-unhandled-self-assignment

ztamas added a comment. Ping. Is it good to go or is there anything else I need to include in this patch? Among the lots of idea, I'm not sure which is just brainstorming and which is a change request. The check seems to work (has useful catches and does not produce too many false positives), ho

[PATCH] D61556: [clang] fixing -ast-print for variadic parameter pack in lambda capture

Tyker added a comment. could you commit it for me please ? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61556/new/ https://reviews.llvm.org/D61556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete added a comment. Is this also okay? main.cpp:2:9: warning: lambda expressions are incompatible with C++98 [-Wc++98-compat] delete[] { return new int; } ^ main.cpp:2:3: error: '[]' after delete interpreted as 'delete[]'; add parentheses to treat this as a lambda-expr

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

Rakete added a comment. @rsmith One last question: The fixit diagnostic seems to be inconsistent with the rest? main.cpp:2:3: error: '[]' after delete interpreted as 'delete[]' delete[] { return new int; } ^~~~ ( ) Shouldn't the `^~~` be start