[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

george.burgess.iv added a comment. I'm happy to give rebasing it a shot later this week. My recollection of the prior state of this patch was that we wanted some backend work done to double-check that no illegal ops get generated by optimizations and such, since these checks are purely done in

[PATCH] D62116: [Sema] raise nullptr check to cover additional uses

nickdesaulniers added a comment. A similar case exists and was flagged in https://www.viva64.com/en/b/0629/ under "Snippet No. 16" (see under #13), `clang/lib/Sema/SemaTemplateInstantiate.cpp` `Sema::InstantiateClass()`. I'll wait for feedback on this patch, then either roll up the additional

[PATCH] D62116: [Sema] raise nullptr check to cover additional uses

nickdesaulniers added a comment. Note that this changes when the destructor for `CXXThisScopeRAII` runs. It's not clear to me why `ThisScope` is constructed at all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62116/new/

[PATCH] D62116: [Sema] raise nullptr check to cover additional uses

nickdesaulniers created this revision. nickdesaulniers added a reviewer: rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was flagged in https://www.viva64.com/en/b/0629/ under "Snippet No. 14" (see under #13). It looks like PVS studio flags nullptr checks where

[PATCH] D62115: fix a issue that clang is incompatible with gcc with -H option.

skan created this revision. skan added reviewers: xiangzhangllvm, LuoYuanke, craig.topper. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang behaves differently with gcc when compiling a file with -H option, gcc will omit the "./", but clang will not. I fix it to make

[PATCH] D62066: [ASTImporter] Enable disabled but passing tests

a_sidorin accepted this revision. a_sidorin added a comment. This revision is now accepted and ready to land. Cool! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62066/new/ https://reviews.llvm.org/D62066

[PATCH] D62064: [ASTImporter] Fix unhandled cases in ASTImporterLookupTable

a_sidorin added a comment. Hi Gabor, This looks fine, but I have a question inline. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4259 static const RecordDecl * getRecordDeclOfFriend(FriendDecl *FD) { QualType Ty = FD->getFriendType()->getType(); + if (auto *Inner =

[PATCH] D61814: [CFG] NFC: Remove implicit conversion from CFGTerminator to Stmt *, make it a variant class instead.

a_sidorin added inline comments. Comment at: clang/lib/Analysis/ReachableCode.cpp:465 + CFGTerminator T = Block->getTerminator(); + if (T.getKind() == CFGTerminator::StmtBranch) { +const Stmt *S = T.getStmt(); isStmtBranch()? CHANGES SINCE LAST ACTION

r361120 - Fix buildbot: Use correct Consume*() for braces.

Author: rakete Date: Sun May 19 08:30:00 2019 New Revision: 361120 URL: http://llvm.org/viewvc/llvm-project?rev=361120=rev Log: Fix buildbot: Use correct Consume*() for braces. Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp Modified: cfe/trunk/lib/Parse/ParseExprCXX.cpp URL:

[PATCH] D36357: Added a better diagnostic when using the delete operator with lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rL361119: Added a better diagnostic when using the delete operator with lambdas (authored by Rakete, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r361119 - Added a better diagnostic when using the delete operator with lambdas

Author: rakete Date: Sun May 19 08:07:58 2019 New Revision: 361119 URL: http://llvm.org/viewvc/llvm-project?rev=361119=rev Log: Added a better diagnostic when using the delete operator with lambdas Summary: This adds a new error for missing parentheses around lambdas in delete operators.

r361117 - Add a Visit overload for DynTypedNode to ASTNodeTraverser

Author: steveire Date: Sun May 19 06:03:48 2019 New Revision: 361117 URL: http://llvm.org/viewvc/llvm-project?rev=361117=rev Log: Add a Visit overload for DynTypedNode to ASTNodeTraverser Reviewers: aaron.ballman Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D54334: [AVR] Automatically link CRT and libgcc from the system avr-gcc

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC361116: [AVR] Automatically link CRT and libgcc from the system avr-gcc (authored by dylanmckay, committed by ). Herald

r361116 - [AVR] Automatically link CRT and libgcc from the system avr-gcc

Author: dylanmckay Date: Sun May 19 02:54:14 2019 New Revision: 361116 URL: http://llvm.org/viewvc/llvm-project?rev=361116=rev Log: [AVR] Automatically link CRT and libgcc from the system avr-gcc Summary: This patch modifies the AVR toolchain so that if avr-gcc and avr-libc are detected during

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

void added a comment. In D38479#1507435 , @phosek wrote: > We (Fuchsia) would like to see this landed as well so we can start using this > in our kernel. I get the feeling that this patch has been abandoned by the author. Would someone like to