[PATCH] D62009: [clang] perform semantic checking in constant context

Tyker added a comment. @rsmith friendly ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62009/new/ https://reviews.llvm.org/D62009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍

stephanemoore planned changes to this revision. stephanemoore added a comment. Thanks for the input! I will get started on making changes accordingly. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2642-2649 + if (const auto *InterfaceDecl = dyn_cast(&Node)) { +

r361920 - Make __has_builtin work with __builtin_LINE and friends.

Author: ericwf Date: Tue May 28 20:15:36 2019 New Revision: 361920 URL: http://llvm.org/viewvc/llvm-project?rev=361920&view=rev Log: Make __has_builtin work with __builtin_LINE and friends. The source location builtins are implemented as keywords, but __has_builtin should still report true for th

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

wuzish added a comment. Thanks. I will commit for @qiucf Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D62121: [PowerPC] [Clang] Port SSE intrinsics to PowerPC

jsji accepted this revision. jsji added a comment. This revision is now accepted and ready to land. LGTM. Thanks for porting. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62121/new/ https://reviews.llvm.org/D62121 _

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore reopened this revision. stephanemoore added inline comments. This revision is now accepted and ready to land. Comment at: test/clang-tidy/google-objc-global-variable-declaration.m:48 static NSString* gMyIntGood = 0; +extern NSString* Y2Good; Whoo

[PATCH] D62483: [CUDA][HIP] Emit dependent libs for host only

phosek added a comment. This seems to be failing on macOS bots with the following error: FAIL: Clang :: CodeGenCUDA/dependent-libs.cu (3052 of 14933) TEST 'Clang :: CodeGenCUDA/dependent-libs.cu' FAILED Script: -- : 'RUN: at line 1'; /b/s/w/

[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3675 +// Render target options such as -fuse-init-array on modern ELF platforms. +TC.addClangTargetOptions(Args, CmdArgs, JA.getOffloadingDeviceKind()); +

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Dunno, looks great :) Also thx @kuhar! Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:194-195 using ClangCFGDomChildrenGetter = -SemiNCAInfo>::ChildrenGetter; +Se

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE361907: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore, committed by ). Changed prior to commit: https://reviews.llvm.org/D62045?vs=201352&id=2

[clang-tools-extra] r361907 - Revise the google-objc-global-variable-declaration check to match the style guide.

Author: stephanemoore Date: Tue May 28 18:36:23 2019 New Revision: 361907 URL: http://llvm.org/viewvc/llvm-project?rev=361907&view=rev Log: Revise the google-objc-global-variable-declaration check to match the style guide. Summary: Revise the google-objc-global-variable-declaration check to matc

r361905 - Fix failure of lit test dependent-libs.cu

Author: yaxunl Date: Tue May 28 18:34:44 2019 New Revision: 361905 URL: http://llvm.org/viewvc/llvm-project?rev=361905&view=rev Log: Fix failure of lit test dependent-libs.cu Modified: cfe/trunk/test/CodeGenCUDA/dependent-libs.cu Modified: cfe/trunk/test/CodeGenCUDA/dependent-libs.cu URL: h

[PATCH] D62367: [X86] VP2INTERSECT clang

xiangzhangllvm updated this revision to Diff 201805. xiangzhangllvm added a comment. rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62367/new/ https://reviews.llvm.org/D62367 Files: docs/ClangCommandLineReference.rst include/clang/Basic/BuiltinsX86.def

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } aheejin wrote: > quantum wrote: > > aheejin wrote: > > > quantum wrote: > > > > aheejin wrote:

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } quantum wrote: > aheejin wrote: > > quantum wrote: > > > aheejin wrote: > > > > Does this mean

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

quantum marked 2 inline comments as done. quantum added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } aheejin wrote: > quantum wrote: > > aheejin wrote: >

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

quantum updated this revision to Diff 201803. quantum marked an inline comment as done. quantum added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62559/new/ https://reviews.llvm.org/D62559 Files: clang/lib/Driver/ToolChai

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } quantum wrote: > aheejin wrote: > > Does this mean we only support `Vptr` among sanitizers [[

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

quantum marked 2 inline comments as done. quantum added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } aheejin wrote: > Does this mean we only support `Vptr

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

tlively added a comment. Please add a test! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62559/new/ https://reviews.llvm.org/D62559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D62437: [clang-tidy] Splits fuchsia-default-arguments

DiegoAstiazaran updated this revision to Diff 201799. DiegoAstiazaran added a comment. Fix patch submitted. Patch submitted with the last update was a new commit, functional changes were not included in that diff. New patch includes functional changes (first patch) and format changes (second pat

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

aheejin added inline comments. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:214 + if (getTriple().isOSEmscripten()) { +Res |= SanitizerKind::Vptr; + } Does this mean we only support `Vptr` among sanitizers [[ https://github.com/llvm/llvm-project

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Comment at: libunwind/test/libunwind/test/config.py:27 +self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root') +or os.path.join(self.libunwind_

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

ast accepted this revision. ast added a comment. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song updated this revision to Diff 201793. yonghong-song added a comment. remove bpf offsetreloc option and use FileCheck in the test. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://reviews.llvm.org/D61809 Files: include/clang/Basic/

[PATCH] D62509: [Driver] Render -fuse-init-array for -fembed-bitcode

compnerd added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:3675 +// Render target options such as -fuse-init-array on modern ELF platforms. +TC.addClangTargetOptions(Args, CmdArgs, JA.getOffloadingDeviceKind()); + Hmm, what other argument

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

This revision was automatically updated to reflect the committed changes. Closed by commit rC361903: [Driver] Search the toolchain dir with -print-file-name (authored by phosek, committed by ). Changed prior to commit: https://reviews.llvm.org/D62558?vs=201788&id=201791#toc Repository: rC Cl

r361903 - [Driver] Search the toolchain dir with -print-file-name

Author: phosek Date: Tue May 28 17:01:05 2019 New Revision: 361903 URL: http://llvm.org/viewvc/llvm-project?rev=361903&view=rev Log: [Driver] Search the toolchain dir with -print-file-name This is useful when looking for directories or files relative to the toolchain root, e.g. include/c++/v1. Th

[PATCH] D62559: [WebAssembly] Support VPtr sanitizer for Emscripten

quantum created this revision. quantum added reviewers: tlively, aheejin. Herald added subscribers: cfe-commits, sunfish, jgravelle-google, sbc100, dschuff. Herald added a project: clang. After https://github.com/emscripten-core/emscripten/pull/8651, Emscripten supports the full UBSan runtime. Th

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62558/new/ https://reviews.llvm.org/D62558 ___ cfe-commit

[PATCH] D62558: [Driver] Search the toolchain dir with -print-file-name

phosek created this revision. phosek added reviewers: mcgrathr, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is useful when looking for directories or files relative to the toolchain root, e.g. include/c++/v1. This change also adds a test to make sure this

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

shafik added a comment. I don't see any regressions but I am a little uncomfortable since there are no tests. So I would feel better if this was split into three parts: Namespaces, Enums and Templates. Are there small test programs that fail due to the missing data? We can add them as regressi

[PATCH] D62557: [analyzer] Modernize CStringChecker to use CallDescriptions.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. NoQ added parent revisions: D62556: [ana

[PATCH] D62133: test/CodeGen/builtin-stackaddress.c duplicates test/CodeGen/2004-02-13-BuiltinFrameReturnAddress.c

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62133/new/ https://reviews.llvm.org/D62133 ___ cfe-commi

[PATCH] D62556: [analyzer] NFC: CallDescription: Implement describing C library functions.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, mikhail.ramalho, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, a.sidorin, szepet. Herald added a project: clang. NoQ added a parent revision: D62441: [an

[PATCH] D62440: [analyzer] NFC: Change evalCall() to provide a CallEvent.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:372 CheckerContext &C) const { - const FunctionDecl *FD = dyn_cast_or_null(CE->getCalleeDecl()

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Seems fine to me; please wait for @aaron.ballman's review to conclude as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62435/new/ https://reviews.llvm.org/D62435

r361897 - [X86] Fix the Sema checks for getmant builtins to only allow 4 and 8 for rounding immediates.

Author: ctopper Date: Tue May 28 16:26:22 2019 New Revision: 361897 URL: http://llvm.org/viewvc/llvm-project?rev=361897&view=rev Log: [X86] Fix the Sema checks for getmant builtins to only allow 4 and 8 for rounding immediates. These don't support embedded rounding so we shouldn't be setting Has

r361895 - Fix r361893 to also update a recently-added test.

Author: rsmith Date: Tue May 28 16:20:52 2019 New Revision: 361895 URL: http://llvm.org/viewvc/llvm-project?rev=361895&view=rev Log: Fix r361893 to also update a recently-added test. Modified: cfe/trunk/test/AST/ast-dump-expr-json.cpp Modified: cfe/trunk/test/AST/ast-dump-expr-json.cpp URL:

r361890 - Move code to mark a variable as odr-used adjacement to all the related

Author: rsmith Date: Tue May 28 16:09:42 2019 New Revision: 361890 URL: http://llvm.org/viewvc/llvm-project?rev=361890&view=rev Log: Move code to mark a variable as odr-used adjacement to all the related code. No functional change intended. Modified: cfe/trunk/include/clang/Sema/Sema.h c

r361891 - If capturing a variable fails, add a capture anyway (and mark it

Author: rsmith Date: Tue May 28 16:09:44 2019 New Revision: 361891 URL: http://llvm.org/viewvc/llvm-project?rev=361891&view=rev Log: If capturing a variable fails, add a capture anyway (and mark it invalid) so that we can avoid repeated diagnostics for the same capture. Modified: cfe/trunk/in

r361892 - Simplify clang::Capture. No functionality change intended.

Author: rsmith Date: Tue May 28 16:09:45 2019 New Revision: 361892 URL: http://llvm.org/viewvc/llvm-project?rev=361892&view=rev Log: Simplify clang::Capture. No functionality change intended. We don't need to pack flags into the bottom bits of pointers here; we have plenty of trailing bits in thi

r361893 - Defer creating fields for captures until we finish building the

Author: rsmith Date: Tue May 28 16:09:46 2019 New Revision: 361893 URL: http://llvm.org/viewvc/llvm-project?rev=361893&view=rev Log: Defer creating fields for captures until we finish building the capturing expression or statement. No functionality change yet. The intent is that we will also dela

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL361889: Add debuginfo-tests that use cdb on Windows (authored by rnk, committed by ). Changed prior to commit: https://reviews.llvm.org/D54187?vs=201779&id=201781#toc Repository: rL LLVM CHANGES SIN

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk updated this revision to Diff 201779. rnk added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - rebase, fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54187/new/ https://reviews.llvm.org/D54187 Files:

[PATCH] D54187: Add debuginfo-tests that use cdb on Windows

rnk added a comment. Thanks! I don't think this suite is going to get too far out of control. I think for most debug info features, checking the info itself gives enough confidence that things work, but there are these cases where I also want an integration test. I'm picking this up again beca

[PATCH] D62271: [Driver] Fix -working-directory issues

This revision was automatically updated to reflect the committed changes. Closed by commit rC361885: [Driver] Fix -working-directory issues (authored by mspencer, committed by ). Changed prior to commit: https://reviews.llvm.org/D62271?vs=200830&id=201774#toc Repository: rC Clang CHANGES SI

r361885 - [Driver] Fix -working-directory issues

Author: mspencer Date: Tue May 28 15:21:47 2019 New Revision: 361885 URL: http://llvm.org/viewvc/llvm-project?rev=361885&view=rev Log: [Driver] Fix -working-directory issues Currently the `-working-directory` option does not actually impact the working directory for all of the clang driver, it on

[PATCH] D62167: CodeView - add static data members to global variable debug info.

dblaikie added a comment. Is this the change we were discussing the other week semi-related to preserved enums? It sounded to me like the conclusion was somewhat to go ahead without adding all these things to the constant list and see how it goes? Is this case different from the enum case in so

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

kuhar added inline comments. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:111 + assert( + (IDom && !IDom->getBlock() && *I == &(*I)->getParent()->getExit() && + IsPostDom) || kuhar wrote: > Szelethus wrote: > > kuhar wrot

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

kuhar added inline comments. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:111 + assert( + (IDom && !IDom->getBlock() && *I == &(*I)->getParent()->getExit() && + IsPostDom) || Szelethus wrote: > kuhar wrote: > > Assertions

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

Szelethus updated this revision to Diff 201769. Szelethus edited the summary of this revision. Szelethus added a comment. Fixes according to @kuhar's comments, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62551/new/ https://reviews.llvm.org/D62551 Files: clang/include/clang/

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

Szelethus marked 5 inline comments as done. Szelethus added inline comments. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:111 + assert( + (IDom && !IDom->getBlock() && *I == &(*I)->getParent()->getExit() && + IsPostDom) || ---

[clang-tools-extra] r361883 - [clangd] Add SourceManager accessor to ParsedAST. NFC

Author: sammccall Date: Tue May 28 14:52:34 2019 New Revision: 361883 URL: http://llvm.org/viewvc/llvm-project?rev=361883&view=rev Log: [clangd] Add SourceManager accessor to ParsedAST. NFC Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h clang-tools-extra/trunk/clangd/XRefs.cpp

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

sammccall updated this revision to Diff 201765. sammccall added a comment. Add DumpRecordLayout. Fix a small SelectionTree bug uncovered by these tweaks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62538/new/ https://reviews.llvm.org/D62538 Files

[PATCH] D62483: [CUDA][HIP] Emit dependent libs for host only

This revision was automatically updated to reflect the committed changes. Closed by commit rC361880: [CUDA][HIP] Emit dependent libs for host only (authored by yaxunl, committed by ). Herald added a project: clang. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6248

[PATCH] D62019: [clang] Handle lrint/llrint builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rC361878: [clang] Handle lrint/llrint builtins (authored by azanella, committed by ). Changed prior to commit: https://reviews.llvm.org/D62019?vs=200291&id=201763#toc Repository: rC Clang CHANGES SINC

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

kuhar added inline comments. Comment at: clang/include/clang/Analysis/Analyses/Dominators.h:39 /// Concrete subclass of DominatorTreeBase for Clang /// This class implements the dominators tree functionality given a Clang CFG. Seems outdated? ==

r361880 - [CUDA][HIP] Emit dependent libs for host only

Author: yaxunl Date: Tue May 28 14:18:59 2019 New Revision: 361880 URL: http://llvm.org/viewvc/llvm-project?rev=361880&view=rev Log: [CUDA][HIP] Emit dependent libs for host only Recently D60274 was introduced to allow lld to handle dependent libs. However current usage of dependent libs (e.g. p

r361878 - [clang] Handle lrint/llrint builtins

Author: azanella Date: Tue May 28 14:16:04 2019 New Revision: 361878 URL: http://llvm.org/viewvc/llvm-project?rev=361878&view=rev Log: [clang] Handle lrint/llrint builtins As for other floating-point rounding builtins that can be optimized when build with -fno-math-errno, this patch adds support

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

rjmccall added a comment. LGTM. David should sign off, too, though. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.org/D61974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D62551: [analyzer][Dominator] Add post dominator tree builder for the CFG + a debug checker

Szelethus created this revision. Szelethus added reviewers: NoQ, kuhar, xazax.hun, rnkovacs, dcoughlin, baloghadamsoftware, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus a

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak updated this revision to Diff 201760. ahatanak marked an inline comment as done. ahatanak added a comment. Remove flag `EncodePointerToObjCTypedef`, which is no longer needed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

yaqiji added a comment. Yes please, thank you :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D62550: [coroutines][PR41909] Don't build dependent coroutine statements for generic lambda

modocache created this revision. modocache added reviewers: GorNishanov, EricWF, lewissbaker, tks2103. Herald added a project: clang. https://bugs.llvm.org/show_bug.cgi?id=41909 describes an issue in which a generic lambda that takes a dependent argument `auto set` causes the template instantiatio

[PATCH] D62271: [Driver] Fix -working-directory issues

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62271/new/ https://reviews.llvm.org/D62271 ___ cfe-commi

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

stephanemoore added a comment. It looks like all concerns have been addressed. Do you need me to land this commit for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62045/new/ https://reviews.llvm.org/D62045

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue marked an inline comment as done. xingxue added inline comments. Comment at: libcxx/include/stdint.h:16 +#endif // _STD_TYPES_T /* hubert.reinterpretcast wrote: > mclow.lists wrote: > > I don't think that this will do what you want it to. > > Is this a

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous added a comment. One more thing. On macOS FSEvents are coalesced more or less at will and it became quite apparent when I was creating automatic tests - I was for example receiving coalesced events Added & Modified & Removed. We had a discussion about how to deal with this and it turne

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

ldionne added a comment. In D62493#1519708 , @rnk wrote: > So, there's nothing wrong, functionally speaking, with what we do today, > right? It's just inconvenient to test. What we do for Darwin today (without this patch) is functionally correct, but h

[PATCH] D48680: Add missing visibility annotation for __base

ldionne added a comment. More specifically, the following program always causes the vtable for `__base` to be internal: cat < int go(float) { return 0; } std::function foo() { return go; } int main() { foo()(3.3f); } EOF That's true with or without this patch, and with or withou

[PATCH] D59253: [AIX][libcxx] AIX system headers need stdint.h and inttypes.h to be re-enterable when macro _STD_TYPES_T is defined

xingxue updated this revision to Diff 201746. xingxue added a comment. Updated comments explaining the scenario of the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59253/new/ https://reviews.llvm.org/D59253 Files: clang/lib/Headers/int

[PATCH] D48680: Add missing visibility annotation for __base

ldionne added a comment. What I don't understand is under which circumstances this changes anything, since we don't export `__base` from the dylib, and implicit instantiations of `__base` don't cause it to be exported. Can you please provide a sample program where this changes what's exported,

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

NoQ added a comment. In D62525#1519475 , @baloghadamsoftware wrote: > Before someone asks: `NoteTag`s are not applicable here since invalidation > and reaching one end of the range happens in many different places. This is > also true for container empt

[PATCH] D61809: [BPF] Preserve debuginfo array/union/struct type/access index

yonghong-song added a comment. @rsmith @eli.friedman Do you have any comments on the clang intrinsic interface in this patch and the llvm intrinsics interface at https://reviews.llvm.org/D61810? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61809/new/ https://r

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 201744. jkorous added a comment. Remove DirectoryWatcher::Event::EventKind::Added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h clang/lib/

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/CMakeLists.txt:862 +# Build with _XOPEN_SOURCE on AIX, as stray macros in _ALL_SOURCE mode tend to +# break things. In this case we need to enable the LARGE FILE API as well +if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES

[PATCH] D61509: [OpenMP] Set pragma start loc to `#pragma` loc

This revision was automatically updated to reflect the committed changes. Closed by commit rL361867: [OpenMP] Set pragma start loc to `#pragma` loc (authored by jdenny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://review

[clang-tools-extra] r361867 - [OpenMP] Set pragma start loc to `#pragma` loc

Author: jdenny Date: Tue May 28 12:27:19 2019 New Revision: 361867 URL: http://llvm.org/viewvc/llvm-project?rev=361867&view=rev Log: [OpenMP] Set pragma start loc to `#pragma` loc This patch adjusts `PragmaOpenMPHandler` to set the location of `tok::annot_pragma_openmp` to the `#pragma` location

[PATCH] D62413: [OpenCL][PR41727] Prevent ICE on global dtors

rjmccall added inline comments. Comment at: lib/CodeGen/CGDeclCXX.cpp:132 + Argument = CGM.getTargetCodeGenInfo().performAddrSpaceCast( + CGM, Addr.getPointer(), SrcAS, LangAS::opencl_global, DestTy); Should this code be conditional to OpenCL? An

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

rjmccall added inline comments. Comment at: lib/AST/ASTContext.cpp:6975 -isa(PointeeTy.getTypePtr()) && -!Options.EncodePointerToObjCTypedef()) { - // Another historical/compatibility reason. Is this option dead now? Repository: rC Clang

[PATCH] D48680: Add missing visibility annotation for __base

manojgupta added a comment. Herald added a subscriber: libcxx-commits. Hi Peter and Marshall, Yunlian has moved to a different project. Can you let me know what is missing in this patch so that it can be submitted. Repository: rCXX libc++ CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D62493: [Driver] Always use Unix-style paths in the Darwin driver

rnk added a comment. So, there's nothing wrong, functionally speaking, with what we do today, right? It's just inconvenient to test. The difficulty of testing the driver has been a long standing problem. I think we might want to instead invent some new kind of alternative to `-###` for writing

r361859 - Driver: support `/Zc:char8_t` and `/Zc:char8_t-`

Author: compnerd Date: Tue May 28 11:26:00 2019 New Revision: 361859 URL: http://llvm.org/viewvc/llvm-project?rev=361859&view=rev Log: Driver: support `/Zc:char8_t` and `/Zc:char8_t-` Update the `cl` emulation to support the `/Zc:char8_t[-]?` options as per the MSVC 2019.1 toolset. These are ali

[PATCH] D62538: [clangd] Add hidden tweaks to dump AST/selection.

sammccall created this revision. sammccall added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. This introduces a few new concepts: - tweaks have an Intent (they don't all advertise as refactorings) -

[PATCH] D61974: [ObjC] Fix encoding of ObjC pointer types that are pointers to typedefs

ahatanak added a comment. ping Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61974/new/ https://reviews.llvm.org/D61974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

thakis added a comment. Since this seems to work with no-canonical-prefixes, I think this is good as-is since people who want build path independent builds need that flag anyway. (At least if Russel can reproduce it working with no-canonical-prefixes; not sure why it wouldn't.) Repository:

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

rnk added a comment. In D61742#1519539 , @russell.gallop wrote: > > I was going to suggest that maybe what we should do is just embed the > > basename, i.e. /nodefaultlib:clang_rt.profile-x86_64.lib ... > > Do you mean /defaultlib:clang_rt.profile-x86_64

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

russell.gallop added a comment. > I was going to suggest that maybe what we should do is just embed the > basename, i.e. /nodefaultlib:clang_rt.profile-x86_64.lib ... Do you mean /defaultlib:clang_rt.profile-x86_64.lib? > ... and then we just ask users to add one /libpath: flag to their linker

[PATCH] D62333: Fix unresolved symbols when linking tools/clang/unittests/Tooling/ToolingTests

quantum marked 2 inline comments as done. quantum added inline comments. Comment at: cfe/trunk/unittests/Tooling/CMakeLists.txt:4 Support TestingSupport ) thakis wrote: > The library is already up here. Why do we need it twice? We don't. It's removed in

[PATCH] D60748: Fix i386 struct and union parameter alignment

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60748/new/ https://reviews.llvm.org/D60748 ___ cfe-commits mailing list cfe

[PATCH] D62167: CodeView - add static data members to global variable debug info.

rnk added subscribers: manmanren, probinson. rnk added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4385 +// Use the global scope for static members. +DContext = getContextDescriptor( + cast(CGM.getContext().getTranslationUnitDecl()), TheCU); -

[PATCH] D62035: [AST] const-ify ObjC inherited class search

beng added a comment. Thanks! @jyknight might want to take a look (this seems fine to me though). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://reviews.llvm.org/D62035 ___ cfe-commits mailing list

[PATCH] D62533: Build with _XOPEN_SOURCE defined on AIX

daltenty created this revision. daltenty added reviewers: hubert.reinterpretcast, xingxue, andusy. daltenty added projects: LLVM, clang. Herald added subscribers: llvm-commits, cfe-commits, jsji, mgorny. It is useful to build with _XOPEN_SOURCE defined on AIX, enabling X/Open and POSIX compatibili

[PATCH] D62525: [Analyzer] Add new visitor to the iterator checkers

baloghadamsoftware added a comment. Before someone asks: `NoteTag`s are not applicable here since invalidation and reaching one end of the range happens in many different places. This is also true for container emptiness. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D58920: [Modules][PR39287] Consolidate multiple std's

modocache added a comment. @rsmith, what do you think of the patch as-is? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58920/new/ https://reviews.llvm.org/D58920 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D62035: [AST] const-ify ObjC inherited class search

adamjernst added a comment. @beng (hello!!) I've spotted you reviewing some Objective-C clang stuff … can you review, or do you have advice on a qualified reviewer? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://reviews.llvm.org/D62035 _

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny added a comment. Ping. Could somebody review this, please? It's blocking NetBSD buildbot for quite some time already. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62005/new/ https://reviews.llvm.org/D62005 ___

[PATCH] D50147: clang-format: support external styles

Typz updated this revision to Diff 201693. Typz marked 3 inline comments as done. Typz added a comment. Herald added subscribers: ormris, mgorny. - Rebased - Adapt styles search path to platform conventions - Allow customizing search path at compile time - Allow overriding search path at runtime t

[PATCH] D61742: [Driver][Windows] Add dependent lib argument for profile instr generate

rnk added a comment. I was going to suggest that maybe what we should do is just embed the basename, i.e. `/nodefaultlib:clang_rt.profile-x86_64.lib`, and then we just ask users to add one `/libpath:` flag to their linker invocation. That saves users from having to come up with a mapping from t

  1   2   >