[PATCH] D61729: [docs] Fix example for Allman brace breaking style

jkorous edited reviewers, added: owenpan; removed: llvm-commits. jkorous added a subscriber: owenpan. jkorous added a comment. You're right, thanks for letting me know. It was changed in 806d5741aa7f . @owenpan was that

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

Charusso added a comment. In D62761#1525917 , @NoQ wrote: > Remove "-" from program point dumps because it resembles a removal marker in > diffs. Could you add an image? I have not seen any problematic stuff, just that. CHANGES SINCE LAST ACTION

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. Let us see those tests! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ updated this revision to Diff 202514. NoQ added a comment. Remove "-" from program point dumps because it resembles a removal marker in diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761 Files:

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ added a comment. I'll add some tests as soon as i'm sure tests for this thing actually work (by landing D62638 ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62761/new/ https://reviews.llvm.org/D62761

[PATCH] D62761: [analyzer] exploded-graph-rewriter: Implement a --diff mode.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ added a comment. NoQ added a

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202511. NoQ added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot clang/test/Analysis/exploded-graph-rewriter/empty.dot

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json)

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json) NoQ wrote: > Charusso

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:191 +.replace('\\>', '>') \ +.rstrip(',') +logging.debug(raw_json)

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. In D62638#1525843 , @Charusso wrote: > In D62638#1525823 , @NoQ wrote: > > > Also switched to python2 because it seems to be the default. The > > differences are minimal. > > > What about the

[PATCH] D62045: Revise the google-objc-global-variable-declaration check to match the style guide.

This revision was automatically updated to reflect the committed changes. Closed by commit rL362279: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[clang-tools-extra] r362279 - Revise the google-objc-global-variable-declaration check to match the style guide.

Author: stephanemoore Date: Fri May 31 16:41:15 2019 New Revision: 362279 URL: http://llvm.org/viewvc/llvm-project?rev=362279=rev Log: Revise the google-objc-global-variable-declaration check to match the style guide. Summary: Revise the google-objc-global-variable-declaration check to match

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = Eugene.Zelenko

Re: r356569 - [NFC][clang][astdump] Some baseline tests for OpenMP

On Sat, Jun 1, 2019 at 2:00 AM Richard Smith wrote: > > These are change detector tests > (https://testing.googleblog.com/2015/01/testing-on-toilet-change-detector-tests.html) > and create a significant maintenance burden that exceeds their value. > > Please either reduce these to tests that

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added a comment. In D62638#1525823 , @NoQ wrote: > Also switched to python2 because it seems to be the default. The differences > are minimal. What about the state of the patch itself? Planned stuff WIP, could I take it to SVGify, or?

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

Charusso added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:151 +super(ExplodedGraph, self).__init__() +self.nodes = collections.defaultdict(ExplodedNode) +self.root_id = None NoQ wrote: > Charusso wrote: >

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = gribozavr

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added inline comments. Comment at: clang/utils/analyzer/exploded-graph-rewriter.py:151 +super(ExplodedGraph, self).__init__() +self.nodes = collections.defaultdict(ExplodedNode) +self.root_id = None Charusso wrote: > `nodes` ->

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ added a comment. Also switched to python2 because it seems to be the default. The differences are minimal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 ___ cfe-commits mailing list

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = Eugene.Zelenko

[PATCH] D62638: [analyzer] A Python script to prettify the ExplodedGraph dumps.

NoQ updated this revision to Diff 202502. NoQ marked 12 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62638/new/ https://reviews.llvm.org/D62638 Files: clang/test/Analysis/exploded-graph-rewriter/edge.dot

[PATCH] D62754: [analyzer] Fix JSON dumps for location contexts.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. That was my feeling as well, but it has been defined like that. Thanks for the clarification! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62754/new/

[PATCH] D62754: [analyzer] Fix JSON dumps for location contexts.

NoQ created this revision. NoQ added a reviewer: Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. `lctx_id` is a property of a location context, not of an item within

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = gribozavr

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

gribozavr added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:54 + +void e() { + int pipefd[2]; srhines wrote: > gribozavr wrote: > > How is `e` different from `a`? > `e` uses O_CLOEXEC properly with `pipe2()` and

[PATCH] D62752: Move VarBypassDector.h to include/clang/CodeGen

zahen created this revision. zahen added a reviewer: chandlerc. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow the VarBypassDetector class to be consumed by external tools by exposing its header from a standard include path. If accepted, I will need a user with

[PATCH] D62470: Clarify when fix-it hints on warnings are appropriate

This revision was automatically updated to reflect the committed changes. Closed by commit rL362266: Clarify when fix-it hints on warnings are appropriate (authored by aaronpuchert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

r362266 - Clarify when fix-it hints on warnings are appropriate

Author: aaronpuchert Date: Fri May 31 14:27:39 2019 New Revision: 362266 URL: http://llvm.org/viewvc/llvm-project?rev=362266=rev Log: Clarify when fix-it hints on warnings are appropriate Summary: This is not a change in the rules, it's meant as a clarification about warnings. Since the recovery

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert updated this revision to Diff 202483. aaronpuchert added a comment. Add missing CHECK-NOTs for -Wmissing-prototypes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59402/new/ https://reviews.llvm.org/D59402 Files:

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert updated this revision to Diff 202480. aaronpuchert added a comment. Remove other change from this one. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59402/new/ https://reviews.llvm.org/D59402 Files: include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert updated this revision to Diff 202479. aaronpuchert added a comment. This revision is now accepted and ready to land. Show note suggesting to add `static`, move fix-it to note for functions, remove fix-it for variables. Show note even for `extern` function definitions when we can't

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert added a comment. I've factored out some changes into D62750 and will rebase this on top if it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59402/new/ https://reviews.llvm.org/D59402

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

yaxunl added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7885 +// By default, restrict the maximum size to 256. +F->addFnAttr("amdgpu-flat-work-group-size", "128,256"); } arsenm wrote: > b-sumner wrote: > > Theoretically, shouldn't the

[PATCH] D62750: Show note for -Wmissing-prototypes for functions with parameters

aaronpuchert created this revision. aaronpuchert added reviewers: aaron.ballman, rsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. There was a search for non-prototype declarations for the function, but we only showed the results for zero-parameter functions. Now we

[PATCH] D62746: msabi: Fix exponential mangling time for certain pathological inputs

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Thanks for this, I remember a user complained about this a long time ago but we never did anything. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62746/new/

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

srhines added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe2.cpp:54 + +void e() { + int pipefd[2]; gribozavr wrote: > How is `e` different from `a`? `e` uses O_CLOEXEC properly with `pipe2()` and makes sure that we don't

[PATCH] D62746: msabi: Fix exponential mangling time in certain pathological inputs

thakis created this revision. thakis added a reviewer: rnk. Template back references used to be recursively recomputed, add a memoization cache to cut down on this. Since there are now two different types of argument maps, rename the existing TypeBackReferences to FunArgBackReferences, and

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

srhines added inline comments. Comment at: clang-tools-extra/test/clang-tidy/android-cloexec-pipe.cpp:17 + pipe(pipefd); + // CHECK-MESSAGES-NOT: warning: +} hokein wrote: > nit: no need to do it explicitly, if a warning is shown unexpectedly, the > test will

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = Eugene.Zelenko

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:317 + + if (pipe(InotifyPollingStopperFDs) == -1) +return nullptr; Use pipe2() with O_CLOEXEC, to avoid leaking the file descriptors to child

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:40 +// FDRead. +// Currently used just for one-off termination signal. +struct SemaphorPipe

[PATCH] D38479: Make -mgeneral-regs-only more like GCC's

efriedma added a comment. Something I ran into when reviewing https://reviews.llvm.org/D62639 is that on AArch64, for varargs functions, we emit floating-point stores when noimplicitfloat is specified. That seems fine for -mno-implicit-float, but maybe not for -mgeneral-regs-only? CHANGES

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous updated this revision to Diff 202467. jkorous marked 2 inline comments as done. jkorous added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58418/new/ https://reviews.llvm.org/D58418 Files:

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

jkorous marked 20 inline comments as done. jkorous added inline comments. Comment at: clang/lib/DirectoryWatcher/linux/DirectoryWatcher-linux.cpp:40 +// FDRead. +// Currently used just for one-off termination signal. +struct SemaphorPipe { gribozavr wrote: >

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = gribozavr

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr marked an inline comment as done. gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto

[PATCH] D62279: Use LTO capable linker

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This is good to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62279/new/ https://reviews.llvm.org/D62279

[PATCH] D62658: [analyzer] print() JSONify: ExplodedNode revision

This revision was automatically updated to reflect the committed changes. Closed by commit rL362249: [analyzer] print() JSONify: ExplodedNode revision (authored by Charusso, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

r362249 - [analyzer] print() JSONify: ExplodedNode revision

Author: charusso Date: Fri May 31 10:54:12 2019 New Revision: 362249 URL: http://llvm.org/viewvc/llvm-project?rev=362249=rev Log: [analyzer] print() JSONify: ExplodedNode revision Summary: Revert node-ID removal. Reviewers: NoQ, xazax.hun, ravikandhadai, baloghadamsoftware, Szelethus

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm marked an inline comment as done. arsenm added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7885 +// By default, restrict the maximum size to 256. +F->addFnAttr("amdgpu-flat-work-group-size", "128,256"); } b-sumner wrote: >

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. In D53157#1525311 , @kpn wrote: > Oh, this ticket is not going to die from neglect. It is true that D43515 > is a higher priority, but I need this > IRBuilder work done as well. My department

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:306 +if (CEArg->isElidable()) { + if (const auto *TempExp = CEArg->getArg(0)) { +if (const auto *UnwrappedCE = Return type

[PATCH] D59402: Fix-it hints for -Wmissing-{prototypes,variable-declarations}

aaronpuchert removed a reviewer: bkramer. aaronpuchert added a comment. I discovered an issue with variables, because there can be multiple definitions with the same `TypeLoc`: extern int a; int a, b; We emit the warning for `b`, but we can't just put static in front of the declaration,

[PATCH] D62049: [clang-tidy] Add a close-on-exec check on pipe2() in Android module.

gribozavr requested changes to this revision. gribozavr added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/clang-tidy/checks/android-cloexec-pipe2.rst:6 + +Checks if the required file flag ``O_CLOEXEC`` is present in the

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

b-sumner added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7885 +// By default, restrict the maximum size to 256. +F->addFnAttr("amdgpu-flat-work-group-size", "128,256"); } Theoretically, shouldn't the minimum be 1? CHANGES SINCE LAST

r362245 - Replace 'default' in an enum-over-a-switch with the missing list.

Author: erichkeane Date: Fri May 31 10:00:48 2019 New Revision: 362245 URL: http://llvm.org/viewvc/llvm-project?rev=362245=rev Log: Replace 'default' in an enum-over-a-switch with the missing list. This suppressed the Wswitch warning causing me to miss it and write an assertion failure.

[PATCH] D61967: [clang-tidy] Add a close-on-exec check on pipe() in Android module.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/android/CloexecPipeCheck.cpp:31 + Result, + "prefer pipe2() to pipe() because pipe2() allows O_CLOEXEC", + ReplacementText); hokein wrote: > the message doesn't seem to

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added a comment. Oh, this ticket is not going to die from neglect. It is true that D43515 is a higher priority, but I need this IRBuilder work done as well. My department head wanted it done by the end of _last_ year. It's not going to die. How about I

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

gribozavr added a comment. Very nice testing approach! Comment at: clang/include/clang/DirectoryWatcher/DirectoryWatcher.h:20 +/// Provides notifications for file changes in a directory. + +/// Invokes client-provided function on every filesystem event in the watched

r362243 - Suppress nothrow/Exception spec conflict warning when we dont know the ES.

Author: erichkeane Date: Fri May 31 09:46:38 2019 New Revision: 362243 URL: http://llvm.org/viewvc/llvm-project?rev=362243=rev Log: Suppress nothrow/Exception spec conflict warning when we dont know the ES. In any situation where the Exception Spec isn't clear, suppress the warning to avoid

[PATCH] D61697: [lit] Disable test on darwin when building shared libs.

hintonda added a comment. ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61697/new/ https://reviews.llvm.org/D61697 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

adzenith added a comment. It appears I was mistaken - the `(?-i)` caused the regex match to fail entirely, which made the system header move all the way to the end. It didn't actually solve my problem. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D33932/new/

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

arsenm created this revision. arsenm added reviewers: t-tye, b-sumner. Herald added subscribers: tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely, kzhuravl. The backend default maximum should be the hardware maximum, so the frontend should set the implementation defined default maximum.

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:311 + } +} +if (CEArg->isStdInitListInitialization()) So `Foo(Bar{1, 2})` is not problematic, it is just that we can't tell it

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

adzenith added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. I just came across this case-insensitive behavior when trying to regroup include blocks and it was surprising. I'm trying to put system headers after other angle-bracket includes (like for Qt), and

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc marked 3 inline comments as done. mibintc added inline comments. Comment at: include/llvm/IR/FPState.h:9-31 + enum FPModelKind { +FPM_Off, +FPM_Precise, +FPM_Strict, +FPM_Fast + }; + kpn wrote: > lebedev.ri wrote: > > All this needs

r362236 - Suppress nothrow/exception spec conflict warning when ES is parsed.

Author: erichkeane Date: Fri May 31 08:56:27 2019 New Revision: 362236 URL: http://llvm.org/viewvc/llvm-project?rev=362236=rev Log: Suppress nothrow/exception spec conflict warning when ES is parsed. The previously added warning ended up causing false positives when nothrow was used on member

[PATCH] D62738: [HIP] Support texture type

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a reviewer: a.sidorin. This patch handles `__attribute__((device_builtin_vector_type))` for HIP. If a class or struct type has this attribute, any variables with this type will be emitted as global symbol in device code

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

sammccall added a comment. Oops, we weren't handling the case when the newly-added overload is dominated by an existing one. Fixed. Comment at: lib/Sema/SemaCodeComplete.cpp:1300 +auto = +OverloadMap[std::make_pair(CurContext, Method->getName())]; +

[PATCH] D62582: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

sammccall updated this revision to Diff 202441. sammccall marked 2 inline comments as done. sammccall added a comment. Handle methods without "normal" identifier names. Add comments. Trigger in both directions (dominated and dominated-by). Repository: rC Clang CHANGES SINCE LAST ACTION

r362232 - Revise test case due to the change from CUDA 10+.

Author: hliao Date: Fri May 31 08:29:55 2019 New Revision: 362232 URL: http://llvm.org/viewvc/llvm-project?rev=362232=rev Log: Revise test case due to the change from CUDA 10+. Modified: cfe/trunk/test/Driver/offloading-interoperability.c Modified:

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added inline comments. Comment at: include/llvm/IR/IRBuilder.h:234 + /// Set the exception handling to be used with constrained floating point + void setDefaultConstrainedExcept(MDNode *NewExcept) { +DefaultConstrainedExcept = NewExcept; kpn

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

kpn added inline comments. Comment at: include/llvm/IR/FPState.h:9-31 + enum FPModelKind { +FPM_Off, +FPM_Precise, +FPM_Strict, +FPM_Fast + }; + lebedev.ri wrote: > All this needs comments, and possibly better names. > `FPM_Off`,etc is very

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn added a comment. I wanted to get the API straight before working on documentation. Comment at: include/llvm/IR/IRBuilder.h:228 + /// Enable/Disable use of constrained floating point math + void setIsConstrainedFP(bool IsCon) { IsFPConstrained = IsCon; } +

Re: r278642 - P0217R3: code generation support for decomposition declarations.

The invented mangling for clang-cl turns out to not be correct :) https://bugs.llvm.org/show_bug.cgi?id=42093 Maybe it's better to add a "can't yet mangle" error, so that we don't silently do the wrong thing? On Sun, Aug 14, 2016 at 9:41 PM Richard Smith via cfe-commits <

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske added a comment. Added lit tests for the simple (`Decl`) cases. The `Expr` and type related changes are more tricky to do. But I do not like this approach to add new tests because the test function in D60463 does almost the same thing for every import

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

lebedev.ri added a comment. I don't know which patch will proceed; but they weren't added already, this seems to be missing documentation changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157

[PATCH] D60499: [ASTImporter] Various source location and range import fixes.

balazske updated this revision to Diff 202438. balazske added a comment. - Import BraceRange of EnumDecl. - Added lit tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60499/new/ https://reviews.llvm.org/D60499 Files: lib/AST/ASTImporter.cpp

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

kpn added a comment. Incorporating feedback from D53157 is probably a good idea. Looks like that hasn't been done yet here completely. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62730/new/ https://reviews.llvm.org/D62730

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

kpn updated this revision to Diff 202436. kpn marked 4 inline comments as done. kpn added a comment. Address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53157/new/ https://reviews.llvm.org/D53157 Files: include/llvm/IR/IRBuilder.h unittests/IR/IRBuilderTest.cpp

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

hokein added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:304 +// e.g. Foo(Bar{1, 2}), the Bar init-list constructor is wrapped around +// an elidable move constructor. +if (CEArg->isElidable()) {

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

hokein updated this revision to Diff 202434. hokein marked 6 inline comments as done. hokein added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62736/new/ https://reviews.llvm.org/D62736 Files:

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer updated this revision to Diff 202433. SjoerdMeijer added a comment. This time with tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697 Files: clang/lib/Driver/ToolChains/Arch/ARM.cpp clang/lib/Driver/ToolChains/Arch/ARM.h

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

gribozavr added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp:302 + if (const auto *CEArg = dyn_cast(Arg)) { +// Strip the ediable move constructor, it is presented in C++11/14 mode. +// e.g. Foo(Bar{1, 2}), the

[clang-tools-extra] r362226 - [clangd] Add missing license for rename.cpp, NFC.

Author: hokein Date: Fri May 31 07:38:16 2019 New Revision: 362226 URL: http://llvm.org/viewvc/llvm-project?rev=362226=rev Log: [clangd] Add missing license for rename.cpp, NFC. Modified: clang-tools-extra/trunk/clangd/refactor/Rename.cpp Modified:

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

lebedev.ri added a comment. Documentation missing. All the blurb from patch description should be in `doc/` Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62731/new/ https://reviews.llvm.org/D62731 ___ cfe-commits

[PATCH] D62736: [clang-tidy] Fix make-unique check to work in C++17 mode.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added a subscriber: xazax.hun. Herald added a project: clang. Previously, we intended to omit the check fix to the case when constructor has any braced-init-list argument. But the HasListInitializedArgument was not correct

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

lebedev.ri added a comment. New files are missing header blurbs; the **precise** explanation of what is what is missing (should be in `doc/`, not patch description) Comment at: include/llvm/IR/FPState.h:9-31 + enum FPModelKind { +FPM_Off, +FPM_Precise, +

[PATCH] D53157: Teach the IRBuilder about constrained fadd and friends

mibintc added a comment. I've posted a small change to this patch here, https://reviews.llvm.org/D62730 and there's a patch to add clang fp options here, https://reviews.llvm.org/D62731 Comment at: include/llvm/IR/IRBuilder.h:234 + /// Set the exception handling to be used

r362225 - Fix for PR42089, regression from r362119

Author: erichkeane Date: Fri May 31 07:26:19 2019 New Revision: 362225 URL: http://llvm.org/viewvc/llvm-project?rev=362225=rev Log: Fix for PR42089, regression from r362119 The implementation of the NoThrow ExceptionSpecificationType missed a switch statement for forming the diagnostic when an

RE: r362119 - Add Attribute NoThrow as an Exception Specifier Type

To Update: Nico and I discussed this on IRC and believe the best way to fix this is to simply suppress this when it comes from a macro-expansion in a system header ala r221172 (or r220992). I intend to work on that fix next after my current (fairly short) fix. Thanks! -Erich From: Nico Weber

RE: r362119 - Add Attribute NoThrow as an Exception Specifier Type

It IS an attribute that works on Linux as well (about ½ way down this page: https://gcc.gnu.org/onlinedocs/gcc-4.7.2/gcc/Function-Attributes.html), though used rarely (at least in C++ code) as far as I understand. The fact that a mistake like this is in the ATL headers is frustrating, but I’m

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc created this revision. mibintc added a reviewer: chandlerc. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Intel would like to contribute a patch to implement support for these Intel- and Microsoft -fp options. This message is to describe the options and request

Re: r362119 - Add Attribute NoThrow as an Exception Specifier Type

I'm not sure this is the best fix. From the patch description, it sounds like this is a Microsoft-specific change. So splitting this into a new diag group that then everyone using the Microsoft headers has to disable seems a bit roundabout – don't we get the same behavior by not emitting this

[PATCH] D62730: [RFC] Alternate implementation of D53157 IRBuilder for Constrained FP using enumeration vs MDNode and add support for fp-model and fp-speculation language options

mibintc created this revision. mibintc added reviewers: andrew.w.kaylor, kpn. Herald added a subscriber: mgorny. Herald added a project: LLVM. This is part of RFC to support language options -fp-model and -fp-speculation. This makes a small modification to D53157

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

SjoerdMeijer marked an inline comment as done. SjoerdMeijer added a comment. Ah yes, the school boy error! ;-) Actually, there was a test, but in a different patch; I will move it to here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697

RE: r362119 - Add Attribute NoThrow as an Exception Specifier Type

Presumably the right choice for you on this one is to separate the diagnostic into a new group. Copying Aaron since he might have an idea of an existing group, otherwise I’ll push a commit to put it in a new one. Thanks for the report! -Erich From: Nico Weber [mailto:tha...@chromium.org]

[PATCH] D60697: [ARM] Allow "-march=foo+fp" to vary with foo.

ostannard requested changes to this revision. ostannard added a comment. This revision now requires changes to proceed. This still needs tests adding. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60697/new/ https://reviews.llvm.org/D60697

[PATCH] D62435: Add Attribute NoThrow as an Exception Specifier Type

erichkeane added a comment. In D62435#1524824 , @mstorsjo wrote: > This change broke compiling Qt on MinGW, see > https://bugs.llvm.org/show_bug.cgi?id=42089. Trivially reproducible by trying > to compile a snippet that looks like this: > > class Foo

  1   2   >