[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus added a comment. In D62883#1545343 , @Charusso wrote: > In D62883#1545341 , @Szelethus wrote: > > > In D62883#1545324 , @Charusso > > wrote: > > > > > As @NoQ poin

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus updated this revision to Diff 204980. Szelethus added a comment. Add another `RUN:` line to see more clearly the effects of this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62883/new/ https://reviews.llvm.org/D62883 Files: clang/include/clang/StaticAnalyzer/Core/An

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Charusso added a comment. In D62883#1545341 , @Szelethus wrote: > In D62883#1545324 , @Charusso wrote: > > > As @NoQ pointed out we have some problem with that function. We are > > tracking *values* without using t

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus marked an inline comment as done. Szelethus added a comment. In D62883#1545324 , @Charusso wrote: > Hey! It is a cool patch as the smallest the scope the better to understand > what is going on. I like the direction, but we saw with @NoQ, we hav

[PATCH] D60974: Clang IFSO driver action.

plotfi updated this revision to Diff 204978. plotfi marked 17 inline comments as done. plotfi added a comment. Addressing @compnerd's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60974/new/ https://reviews.llvm.org/D60974 Files: clang/

[PATCH] D60974: Clang IFSO driver action.

plotfi added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:21 + StringRef InFile; + StringRef Format; + std::set ParsedTemplates; compnerd wrote: > An enumeration may be nicer. For now the format goes into the first line of

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Charusso requested changes to this revision. Charusso added a comment. This revision now requires changes to proceed. Hey! It is a cool patch as the smallest the scope the better to understand what is going on. I like the direction, but we saw with @NoQ, we have to think about "In which range do

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus marked 8 inline comments as done. Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1850 + +return const_cast(Node->getLocationContext() +->getAnalysisDeclContext()->getCFGStmtMap()->getBlock(S));

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus updated this revision to Diff 204973. Szelethus added a comment. - Rebase on the rest of the patches - Make `TrackControlDependencyCondBRVisitor` local to `BugReporterVisitors.cpp` - Hide the current implementation behind the off-by-default analyzer config `"track-conditions"` - Add two

[PATCH] D62619: [analyzer][Dominators] Add a control dependency calculator + a new debug checker

Szelethus updated this revision to Diff 204972. Szelethus retitled this revision from "[analyzer][Dominators] Add a control dependency tree builder + a new debug checker" to "[analyzer][Dominators] Add a control dependency calculator + a new debug checker". Szelethus edited the summary of this re

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

mgehre marked an inline comment as done. mgehre added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/UnusedParametersCheck.cpp:141-156 + // Cannot remove parameter for non-local functions. if (Function->isExternallyVisible() || !Result.SourceManager->is

[PATCH] D63088: [clang-tidy] misc-unused-parameters: don't comment out parameter name for C code

mgehre marked an inline comment as done. mgehre added inline comments. Comment at: clang-tools-extra/test/clang-tidy/misc-unused-parameters.c:1-7 // RUN: %check_clang_tidy %s misc-unused-parameters %t -- -- -xc // Basic removal // = void a(int i) {;} // CHECK-M

r363521 - [docs] Fix another bot error by setting highlight language of objc code-block to objc instead of c++.

Author: dhinton Date: Sun Jun 16 12:15:04 2019 New Revision: 363521 URL: http://llvm.org/viewvc/llvm-project?rev=363521&view=rev Log: [docs] Fix another bot error by setting highlight language of objc code-block to objc instead of c++. Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe

[PATCH] D62883: [analyzer] Track conditions of terminator statements on which the reported node depends on

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporter.h:157 + /// Conditions we're already tracking. + llvm::SmallPtrSet TrackedConditions; + xazax.hun wrote: >

[clang-tools-extra] r363520 - [docs] Fix another bot warning by adding a blank line to separate the `option::` command from the text below.

Author: dhinton Date: Sun Jun 16 11:41:31 2019 New Revision: 363520 URL: http://llvm.org/viewvc/llvm-project?rev=363520&view=rev Log: [docs] Fix another bot warning by adding a blank line to separate the `option::` command from the text below. Modified: clang-tools-extra/trunk/docs/clang-ti

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso marked 3 inline comments as done. Charusso added a comment. @NoQ, thanks for the review! Now everything is working by rL363515 . Comment at: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp:16 + +typedef unsigned lon

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Charusso marked an inline comment as done. Charusso added a comment. In D62926#1545163 , @hintonda wrote: > This test fails to compile on Windows 64 bit builds. Please see > http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/77 Thanks you!

[clang-tools-extra] r363518 - [docs] Fix a few problems with clang-tool docs to get the bots green again.

Author: dhinton Date: Sun Jun 16 10:57:37 2019 New Revision: 363518 URL: http://llvm.org/viewvc/llvm-project?rev=363518&view=rev Log: [docs] Fix a few problems with clang-tool docs to get the bots green again. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst clang-tools-extra/trunk

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Szelethus added inline comments. Comment at: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp:16 + +typedef unsigned long uintptr_t; + hintonda wrote: > I don't believe this is really ever portable, but definitely not on 64 bit > Windows where a

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

Szelethus added inline comments. Comment at: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp:16 + +typedef unsigned long uintptr_t; + Szelethus wrote: > hintonda wrote: > > I don't believe this is really ever portable, but definitely not on 64 b

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

ABataev added a comment. In D63009#1545152 , @gtbercea wrote: > In D63009#1544984 , @ABataev wrote: > > > In D63009#1544900 , @gtbercea > > wrote: > > > > > In D63009#154475

r363515 - [analyzer] ReturnVisitor: more portable test case

Author: charusso Date: Sun Jun 16 10:29:37 2019 New Revision: 363515 URL: http://llvm.org/viewvc/llvm-project?rev=363515&view=rev Log: [analyzer] ReturnVisitor: more portable test case Modified: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp Modified: cfe/trunk/test/Analys

[PATCH] D62926: [analyzer] ReturnVisitor: Bypass everything to see inlined calls

hintonda added a comment. This test fails to compile on Windows 64 bit builds. Please see http://lab.llvm.org:8011/builders/clang-x64-windows-msvc/builds/77 Comment at: cfe/trunk/test/Analysis/inlining/placement-new-fp-suppression.cpp:16 + +typedef unsigned long uintptr_t; +

[PATCH] D62899: [analyzer][UninitializedObjectChecker] Mark uninitialized regions as interesting.

Szelethus added a comment. In D62899#1544630 , @NoQ wrote: > I don't remember what exactly does `markInteresting()` do and these tests > don't really convince me that it does anything at all. Halp? >.< Damnit, forgot my actual test file in the office (d

[PATCH] D63009: [OpenMP] Add target task alloc function with device ID

gtbercea added a comment. In D63009#1544984 , @ABataev wrote: > In D63009#1544900 , @gtbercea wrote: > > > In D63009#1544758 , @Hahnfeld > > wrote: > > > > > Am I correct th

[PATCH] D63387: clang: Promote -fdebug-compilation-dir from cc1 flag to driver-level flag

thakis created this revision. thakis added reviewers: hans, rnk. Herald added a subscriber: aprantl. The flag is useful when wanting to create .o files that are independent from the absolute path to the build directory. -fdebug-prefix-map= can be used to the same effect, but it requires putting th

r363512 - [analyzer] Push correct version of 'Track indices of arrays'

Author: szelethus Date: Sun Jun 16 08:41:25 2019 New Revision: 363512 URL: http://llvm.org/viewvc/llvm-project?rev=363512&view=rev Log: [analyzer] Push correct version of 'Track indices of arrays' Messed up the commit, oops. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

[PATCH] D63080: [analyzer] Track indices of arrays

This revision was automatically updated to reflect the committed changes. Closed by commit rL363510: [analyzer] Track indices of arrays (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.or

r363510 - [analyzer] Track indices of arrays

Author: szelethus Date: Sun Jun 16 07:52:56 2019 New Revision: 363510 URL: http://llvm.org/viewvc/llvm-project?rev=363510&view=rev Log: [analyzer] Track indices of arrays Often times, when an ArraySubscriptExpr was reported as null or undefined, the bug report was difficult to understand, because

[PATCH] D63086: [analyzer][NoStoreFuncVisitor][NFC] Move methods out-of-line, turn some to static functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL363509: [analyzer][NFC] Tease apart and clang-format NoStoreFuncVisitor (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

r363509 - [analyzer][NFC] Tease apart and clang-format NoStoreFuncVisitor

Author: szelethus Date: Sun Jun 16 07:09:11 2019 New Revision: 363509 URL: http://llvm.org/viewvc/llvm-project?rev=363509&view=rev Log: [analyzer][NFC] Tease apart and clang-format NoStoreFuncVisitor Make several methods static functions Move non-trivial methods out-of-line Add a divider Turn non

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D63222: [Clangd] Fixed clangd diagnostics priority

sammccall added a comment. Code gets shorter, tests get longer, very nice :-) Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63222/new/ https://reviews.llvm.org/D63222 ___ cfe-commits mailing list cfe-commits@lists.llv