[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

2019-06-29 Thread Justin Hibbits via Phabricator via cfe-commits
jhibbits updated this revision to Diff 207214. jhibbits added a comment. Made '8548' CPU designation just a stub, to be filled out later. I added it just for parity with GCC. The 8548 CPU, for GCC, also sets the __NO_LWSYNC__ macro, which doesn't belong with the SPE change, so will have to be re

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

2019-06-29 Thread Teresa Johnson via Phabricator via cfe-commits
tejohnson added inline comments. Comment at: llvm-9.0.0-20190629/clang/lib/Driver/ToolChains/CommonArgs.cpp:395 + if(OOpt == "s" || OOpt == "z") +OOpt = "3"; +} Os/Oz are closer to O2 than O3 (which allows

Re: [PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

2019-06-29 Thread Stephen Checkoway via cfe-commits
t; ld.lld: error: -plugin-opt=Oz: number expected, but got 'z' > clang-9: error: linker command failed with exit code 1 (use -v to see > invocation) > > https://bugs.llvm.org/show_bug.cgi?id=42445 > > > Repository: > rC Clang > > https://rev

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

2019-06-29 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 207209. saar.raz added a comment. Herald added subscribers: erik.pilkington, mgorny. Create ASTConstraintSatisfaction for correctly storing constraint satisfaction data in AST nodes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

2019-06-29 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. Good idea, I found this issue a few days ago too. Please upload the patch with a full context. Plesse try to add a testcase. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63976/new/ https://reviews.llvm.org/D63976 __

[PATCH] D63976: Allow clang -Os and -Oz to work with -flto and lld

2019-06-29 Thread Bernhard Rosenkränzer via Phabricator via cfe-commits
.org/show_bug.cgi?id=42445 Repository: rC Clang https://reviews.llvm.org/D63976 Files: llvm-9.0.0-20190629/clang/lib/Driver/ToolChains/CommonArgs.cpp Index: llvm-9.0.0-20190629/clang/lib/Driver/ToolChains/CommonArgs.cpp ==

[PATCH] D59415: Do not resolve directory junctions for `-fdiagnostics-absolute-paths` on Windows.

2019-06-29 Thread Johan Boule via Phabricator via cfe-commits
johan-boule added a comment. Is this going to break symlinks on Windows? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59415/new/ https://reviews.llvm.org/D59415 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

2019-06-29 Thread Mark de Wever via Phabricator via cfe-commits
Mordante created this revision. Mordante added a reviewer: rsmith. Mordante added a project: clang. Herald added a subscriber: cfe-commits. Before when the overflow occurred an assertion as triggered. Now check whether the maximum has been reached and warn properly. This patch fixes the original

[PATCH] D49754: Add -m(no-)spe, and e500 CPU definitions and support to clang

2019-06-29 Thread vit9696 via Phabricator via cfe-commits
vit9696 added a comment. Not sure whether I understood you, do not you already have the common switch by feature, named spe, in Features["spe"] line for that? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D49754/new/ https://reviews.llvm.org/D49754 ___