[PATCH] D60943: Delay diagnosing asm constraints that require immediates until after inlining

void updated this revision to Diff 212085. void added a comment. Herald added subscribers: s.egerton, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, apazos, simoncook, johnrusso, rbar, asb. Move a few more tests around. Some go to the L

[PATCH] D59555: [analyzer] Add yaml parser to GenericTaintChecker

This revision was automatically updated to reflect the committed changes. Closed by commit rL367190: [analyzer] Add yaml parser to GenericTaintChecker (authored by boga95, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

r367190 - [analyzer] Add yaml parser to GenericTaintChecker

Author: boga95 Date: Sun Jul 28 06:38:04 2019 New Revision: 367190 URL: http://llvm.org/viewvc/llvm-project?rev=367190&view=rev Log: [analyzer] Add yaml parser to GenericTaintChecker While we implemented taint propagation rules for several builtin/standard functions, there's a natural desire for

r367193 - Buildbot fix for r367190

Author: boga95 Date: Sun Jul 28 07:57:41 2019 New Revision: 367193 URL: http://llvm.org/viewvc/llvm-project?rev=367193&view=rev Log: Buildbot fix for r367190 Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/GenericTaintCh

r367184 - [FunctionAttrs] Annotate "willreturn" for intrinsics

Author: uenoku Date: Sat Jul 27 23:09:56 2019 New Revision: 367184 URL: http://llvm.org/viewvc/llvm-project?rev=367184&view=rev Log: [FunctionAttrs] Annotate "willreturn" for intrinsics Summary: In D62801, new function attribute `willreturn` was introduced. In short, a function with `willreturn`

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

aaron.ballman added inline comments. Comment at: test/SemaCXX/warn-int-in-bool-context.cpp:99 + + if (ans == yes || no) // expected-warning {{enum constant in boolean context}} +return a; Why do we want to diagnose this case in C++ but not in C? CHANGES S

[PATCH] D63139: [Diagnostics] Implement -Wswitch-unreachable

aaron.ballman added a comment. In D63139#1603667 , @xbolva00 wrote: > Ping again > > Is ‘CaseStmt´ AST C++ issue is a blocker for this patch or not? I do not think it is a blocker for this patch. It's the existing behavior of the AST and while annoying,

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: test/SemaCXX/warn-int-in-bool-context.cpp:99 + + if (ans == yes || no) // expected-warning {{enum constant in boolean context}} +return a; aaron.ballman wrote: > Why do w

Phabricator stability

Just an FYI, but it seems like Phabricator may be having some issues this weekend. When trying to perform reviews, a few folks have noticed they get errors about insufficient space to save various internal tables. Additionally, it seems that emails from submitted reviews are not always being genera

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:11656 + IsListInit = + IsListInit || (isa(OrigE) && S.getLangOpts().CPlusPlus); + Do you want to perform the `isa<>` on `OrigE` or on `E` which has had paren and implicit cast

[PATCH] D63276: [AST] Add FunctionDecl::getParametersSourceRange()

aaron.ballman added a comment. Phab looked to be having disk issues when I added my comments, so I'm pinging this review just to be sure the latest comments make it to the mailing list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63276/new/ https://reviews.llvm.org/D63276

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:103 MaybeParseCXX11Attributes(Attrs, nullptr, /*MightBeObjCMessageSend*/ true); + if (!MaybeParseOpenCLUnrollHintAttribute(Attrs)) Spurious newline? Comment at

[PATCH] D65233: driver: Don't warn about assembler flags being unused when not assembling; different approach

bjope added a comment. In D65233#1603783 , @thakis wrote: > In D65233#1603741 , @bjope wrote: > > > I made another fixup (similar to https://reviews.llvm.org/rL367176) here > > https://reviews.llvm.org/rL367182. >

[PATCH] D64838: [Attr] Support _attribute__ ((fallthrough))

xbolva00 added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:1228 + if (MacroName.empty()) { +if (!PreferClangAttr) + MacroName = "[[fallthrough]]"; This code is not tested? I think you can use tests from my older patch. Repos

[PATCH] D65378: [analyzer][NFC] Refactoring BugReporter.cpp P1.: Store interesting symbols/regions in a simple set

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, Charusso, baloghadamsoftware, dcoughlin. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. The goal of this

[PATCH] D59637: [analyzer] Use the custom propagation rules and sinks in GenericTaintChecker

boga95 updated this revision to Diff 212119. boga95 added a subscriber: steakhal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59637/new/ https://reviews.llvm.org/D59637 Files: clang/lib/StaticAnalyzer/Checkers/GenericTaintChecker.cpp clang/test/Analysis/taint-generic.c Index: clan

[PATCH] D65381: [analyzer][NFC] Refactoring BugReporter.cpp P3.: std::shared_pointer -> PathDiagnosticPieceRef

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, rnkovacs, baloghadamsoftware, dcoughlin, Charusso. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Szelethus edited t

[PATCH] D65382: [analyzer][NFC] Refactoring BugReporter.cpp P4.: If it can be const, make it const

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, Charusso, dcoughlin, baloghadamsoftware, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. When I'm new to a

r367199 - Improve MSVC visualizers for DeclSpec and TemplateName

Author: mps Date: Sun Jul 28 20:34:40 2019 New Revision: 367199 URL: http://llvm.org/viewvc/llvm-project?rev=367199&view=rev Log: Improve MSVC visualizers for DeclSpec and TemplateName DeclSpec now shows the TypeRep, ExprRep, or DeclRep as appropriate TemplateName decodes and displays the Storage

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet updated this revision to Diff 212131. kadircet marked 3 inline comments as done. kadircet added a comment. - Always set LastDiagWasAdjusted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64863/new/ https://reviews.llvm.org/D64863 Files:

[PATCH] D64863: [clangd] Ignore diags from builtin files

kadircet added inline comments. Comment at: clang-tools-extra/clangd/Diagnostics.cpp:563 FillDiagBase(*LastDiag); -adjustDiagFromHeader(*LastDiag, Info, *LangOpts); +if (!InsideMainFile) + LastDiagWasAdjusted = adjustDiagFromHeader(*LastDiag, Info, *LangOpts); -