[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192-197 + /// Pair of checker name and enable/disable to do analysis. + std::vector> CheckerAnalysisVector; + + /// Vector of checker names to do not emit warnings. +

[PATCH] D66045: Improve detection of same value in comparisons

NoQ added a reviewer: NoQ. NoQ added a comment. I like where this is going! I'll add myself so that not to forget to review the CFG bits next week. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66045/new/ https://reviews.llvm.org/D66045

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. But i definitely like it how smooth this patch turned out to be! Also recent bugzilla requests for this feature: https://bugs.llvm.org/show_bug.cgi?id=42816

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192-197 + /// Pair of checker name and enable/disable to do analysis. + std::vector> CheckerAnalysisVector; + + /// Vector of checker names to do not emit warnings. + std::vector

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1750 + // [B1] -> [B2] -> [B3] -> [sink] + // assert(A && B || C);\ \ \ + // ---> [go on with the

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso updated this revision to Diff 214500. Charusso added a comment. - Fix a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp clang/include/clang/Driver/CC1Options.td

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso updated this revision to Diff 214498. Charusso marked 5 inline comments as done. Charusso added a comment. - Fix. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso added inline comments. Comment at: clang/include/clang/Driver/CC1Options.td:127-128 +def analyzer_disable_warning : Separate<["-"], "analyzer-disable-warning">, + HelpText<"Choose analyzer checkers of the warnings to disable">; +def analyzer_disable_warning_EQ :

[PATCH] D65182: [analyzer] Add fix-it hint support.

Charusso accepted this revision. Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:103 void enableWerror() { ShouldEmitAsError = true; } + void enableFixitsAsRemarks() { FixitsAsRemarks = true; } NoQ wrote:

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

NoQ added reviewers: alexfh, Szelethus. NoQ added a subscriber: alexfh. NoQ added a comment. +@alexfh because clang-tidy now finally has a way of safely disabling core checkers without causing crashes all over the place! Would you like to take the same approach as we picked in scan-build, i.e.

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:561 +CmdLineOption `Show` -> `Enable`? > **recursion**, //n.,// see "recursion" I think it's valuable when the object and the documentation describe the same idea in

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 214495. NoQ marked 3 inline comments as done. NoQ added a comment. Fix un-singed options. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65182/new/ https://reviews.llvm.org/D65182 Files: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214496. jcai19 marked 2 inline comments as done. jcai19 added a comment. clang-format the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019 Files:

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 marked 4 inline comments as done. jcai19 added a comment. @efriedma I have changed my implementation to lower llvm.gnu.eabi.mcount intrinsic into pseudo instructions directly, instead of first lowering them into SelectionDAG call nodes. Thanks. Comment at:

[PATCH] D65019: [ARM] push LR before __gnu_mcount_nc

jcai19 updated this revision to Diff 214491. jcai19 added a comment. Lower the intrinsic to pseudo instructions directly, instead of SelectDAG nodes first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65019/new/ https://reviews.llvm.org/D65019

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso updated this revision to Diff 214490. Charusso added a comment. - Remove one misleading 'no-warning' comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66042/new/ https://reviews.llvm.org/D66042 Files: clang-tools-extra/clang-tidy/ClangTidy.cpp

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Charusso created this revision. Charusso added a reviewer: NoQ. Charusso added a project: clang. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. This patch introduces a new option:

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rsmith added a comment. Looks good. Can you add a test to `test/CXX/drs/dr23xx.cpp` with a suitable `dr2386: 10` comment to track that we've implemented DR2386 in Clang 10, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66040/new/

Re: r368501 - Fix a false positive warning when initializing members with gsl::Owners.

It does! Do you want me to commit that test as well? On Fri, 9 Aug 2019 at 17:50, Nico Weber wrote: > This fixes `+ X(std::unique_ptr up) : pointee(up.get()), > pointer(std::move(up)) {}` as well, right? > > On Fri, Aug 9, 2019 at 8:31 PM Gabor Horvath via cfe-commits < >

Re: r368501 - Fix a false positive warning when initializing members with gsl::Owners.

This fixes `+ X(std::unique_ptr up) : pointee(up.get()), pointer(std::move(up)) {}` as well, right? On Fri, Aug 9, 2019 at 8:31 PM Gabor Horvath via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: xazax > Date: Fri Aug 9 17:32:29 2019 > New Revision: 368501 > > URL:

Re: r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

It was an easy fix! In case any problem persists I will revert the commit with the fix itself. On Fri, 9 Aug 2019 at 17:16, Gábor Horváth wrote: > Indeed! > > There pointer is moved later on! Interestingly, I run these warnings on > 300+ projects and none of them had this pattern. Will revert

r368501 - Fix a false positive warning when initializing members with gsl::Owners.

Author: xazax Date: Fri Aug 9 17:32:29 2019 New Revision: 368501 URL: http://llvm.org/viewvc/llvm-project?rev=368501=rev Log: Fix a false positive warning when initializing members with gsl::Owners. Modified: cfe/trunk/lib/Sema/SemaInit.cpp

Re: r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

Indeed! There pointer is moved later on! Interestingly, I run these warnings on 300+ projects and none of them had this pattern. Will revert or fix the patch soon. On Fri, 9 Aug 2019 at 17:13, Nico Weber wrote: > http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/14045 > > FAILED:

Re: r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

http://lab.llvm.org:8011/builders/clang-with-lto-ubuntu/builds/14045 FAILED: tools/clang/lib/Frontend/CMakeFiles/obj.clangFrontend.dir/ASTConsumers.cpp.o /home/buildslave/buildslave1a/clang-with-lto-ubuntu/install/stage1/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GNU_SOURCE

[PATCH] D66040: [Sema] Implement DR2386 for C++17 structured binding

rnk created this revision. rnk added a reviewer: rsmith. Herald added a project: clang. Allow implementations to provide complete definitions of std::tuple_size, but to omit the 'value' member to signal that T is not tuple-like. The Microsoft standard library implements std::tuple_size this way.

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623939 , @hfinkel wrote: > In D65835#1623903 , @ABataev wrote: > > > In D65835#1623883 , @hfinkel wrote: > > > > > In D65835#1623814

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

thakis added a comment. https://webkit.org/code-style-guidelines/ has one instance of `{ }` with a space and one of `{}` without a space, and as far as I can tell no text that says which instance is correct. Are you sure this is the right thing for webkit style? Repository: rC Clang

[PATCH] D65337: [clangd] Disallow extraction of expression-statements.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368500: [clangd] Disallow extraction of expression-statements. (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623903 , @ABataev wrote: > In D65835#1623883 , @hfinkel wrote: > > > In D65835#1623814 , @hfinkel wrote: > > > > > In D65835#1623772

[PATCH] D66031: clangd: use -j for background index pool

sammccall added a subscriber: hans. sammccall added a comment. @hans If you don't mind merging this, it's a nice usability improvement. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ https://reviews.llvm.org/D66031

[clang-tools-extra] r368500 - [clangd] Disallow extraction of expression-statements.

Author: sammccall Date: Fri Aug 9 16:40:54 2019 New Revision: 368500 URL: http://llvm.org/viewvc/llvm-project?rev=368500=rev Log: [clangd] Disallow extraction of expression-statements. Summary: I split out the "extract parent instead of this" logic from the "this isn't worth extracting" logic

[PATCH] D65044: [Format] Add option to enable coroutines keywords

sammccall added a comment. Do we have real examples of code that gets formatted incorrectly when parsed as c++20 but lives in a codebase that uses coroutines TS? This seems very niche (and probably short-lived) - do we really need this option? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D65752: [Sema] Refactor LookupVisibleDecls. NFC

sammccall added a comment. This looks reasonable to me, there are a couple of variations you might think about: - also treat QualifiedNameLookup as an option, and override in places with an RAII pattern like `ScopedOverride Unqual(QualifiedNameLookup, false)` (why don't we have a class like

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb abandoned this revision. jfb added a comment. Let's do the better fix that Michael suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 ___

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214477. jfb added a comment. - Also update function name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files: clang/include/clang/Driver/Driver.h

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders marked 3 inline comments as done. dsanders added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/PreferRegisterOverUnsignedCheck.cpp:48-51 +for (const auto *UsingDirective: Context->using_directives()) + if

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623883 , @hfinkel wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1623883 , @hfinkel wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

dsanders updated this revision to Diff 214476. dsanders added a comment. - Give in on eliding the llvm:: for `using namespace llvm` inside a function They don't appear in the DeclContext and I've been unable to find a way to reasonably detect them Fortunately they don't occur in practice

[PATCH] D66028: [ASTDump] Add is_anonymous to VisitCXXRecordDecl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66028/new/ https://reviews.llvm.org/D66028 ___ cfe-commits mailing

[PATCH] D66031: clangd: use -j for background index pool

This revision was automatically updated to reflect the committed changes. Closed by commit rL368498: clangd: use -j for background index pool (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66038: [Support] heavyweight_hardware_concurrency uses affinity when counting cores fails, and never returns 0

sammccall updated this revision to Diff 214474. sammccall added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66038 Files: llvm/include/llvm/Support/Threading.h

[PATCH] D66038: [Support] heavyweight_hardware_concurrency uses affinity when counting cores fails, and never returns 0

jfb added a comment. The name of this patch is wrong? Or rather, it's 2 in 1? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66038 ___ cfe-commits mailing list

[PATCH] D66038: [Support] heavyweight_hardware_concurrency uses affinity when counting cores fails, and never returns 0

sammccall planned changes to this revision. sammccall added a comment. ugh, I accidentally reused a branch and squashed two patches together. Let me try again... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/

r368499 - Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations"

Author: xazax Date: Fri Aug 9 16:03:50 2019 New Revision: 368499 URL: http://llvm.org/viewvc/llvm-project?rev=368499=rev Log: Attempt to reapply "Even more warnings utilizing gsl::Owner/gsl::Pointer annotations" Modified: cfe/trunk/lib/Sema/SemaInit.cpp

[clang-tools-extra] r368498 - clangd: use -j for background index pool

Author: sammccall Date: Fri Aug 9 16:03:32 2019 New Revision: 368498 URL: http://llvm.org/viewvc/llvm-project?rev=368498=rev Log: clangd: use -j for background index pool Summary: clangd supports a -j option to limit the amount of threads to use for parsing TUs. However, when using

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623814 , @hfinkel wrote: > In D65835#1623772 , @ABataev wrote: > > > In D65835#1623756 , @kkwli0 wrote: > > > > > In D65835#1622042

[PATCH] D66038: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

puremourning added a comment. LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66038/new/ https://reviews.llvm.org/D66038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66038: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

sammccall created this revision. sammccall added reviewers: ilya-biryukov, puremourning. Herald added subscribers: llvm-commits, cfe-commits, jfb, kadircet, arphaman, jkorous, MaskRay, hiraditya. Herald added projects: clang, LLVM. [Support] heavyweight_hardware_concurrency uses affinity when

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1623858 , @ABataev wrote: > In D65835#1623854 , @jdenny wrote: > > > In D65835#1623814 , @hfinkel wrote: > > > > > In D65835#1623772

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RegionStore.cpp:630 +(const RegionBindings::TreeTy *)((uintptr_t)store & ~(uintptr_t)1), +RBFactory.getTreeFactory(), (bool)((uintptr_t)store & (uintptr_t)1)); } xazax.hun

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623854 , @jdenny wrote: > In D65835#1623814 , @hfinkel wrote: > > > In D65835#1623772 , @ABataev wrote: > > > > > In D65835#1623756

[PATCH] D65361: [analyzer] Trust global initializers when analyzing main().

NoQ updated this revision to Diff 214470. NoQ marked 8 inline comments as done. NoQ added a comment. Fxd! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65361/new/ https://reviews.llvm.org/D65361 Files: clang/lib/StaticAnalyzer/Core/RegionStore.cpp clang/test/Analysis/main.c

[PATCH] D66031: clangd: use -j for background index pool

puremourning added a comment. In D66031#1623855 , @sammccall wrote: > Thanks! Want me to land this for you? yes please! I don't have commit rights. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/

[PATCH] D66031: clangd: use -j for background index pool

sammccall accepted this revision. sammccall added a comment. Thanks! Want me to land this for you? Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { puremourning wrote: >

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

jdenny added a comment. In D65835#1623814 , @hfinkel wrote: > In D65835#1623772 , @ABataev wrote: > > > In D65835#1623756 , @kkwli0 wrote: > > > > > In D65835#1622042

[PATCH] D65043: [Format] Add C++20 standard to style options

sammccall added a comment. Sorry for taking so long here, I've been swamped. Unfortunately there's a couple of pain points still: - this change is (mostly?) about being able to turn off c++20 parsing, so you preserve old desirable formatting of c++17 code. But the tests don't contain any such

[PATCH] D65545: Handle some fs::remove failures

vsapsai accepted this revision. vsapsai added a comment. This revision is now accepted and ready to land. Looks good to me. If in some situations abort on error turns out to be too aggressive, we can change it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65182: [analyzer] Add fix-it hint support.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I really like that patch, as no human would rewrite 600 `dyn_cast` and `getAs` to `cast` and `castAs`. Thanks you! Comment at:

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

This revision was automatically updated to reflect the committed changes. Closed by commit rL368495: cfi-icall: Allow the jump table to be optionally made non-canonical. (authored by pcc, committed by ). Changed prior to commit: https://reviews.llvm.org/D65629?vs=214434=214468#toc Repository:

r368495 - cfi-icall: Allow the jump table to be optionally made non-canonical.

Author: pcc Date: Fri Aug 9 15:31:59 2019 New Revision: 368495 URL: http://llvm.org/viewvc/llvm-project?rev=368495=rev Log: cfi-icall: Allow the jump table to be optionally made non-canonical. The default behavior of Clang's indirect function call checker will replace the address of each

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

loladiro updated this revision to Diff 214467. loladiro added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Accidentally only pushed half the changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66035/new/

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

hfinkel added a comment. In D65835#1623772 , @ABataev wrote: > In D65835#1623756 , @kkwli0 wrote: > > > In D65835#1622042 , @ABataev wrote: > > > > > > I want to be sure

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214463. puremourning added a comment. Rebase on master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66031/new/ https://reviews.llvm.org/D66031 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D65182: [analyzer] Add fix-it hint support.

NoQ updated this revision to Diff 214462. NoQ retitled this revision from "[analyzer] WIP: Add fix-it hint support." to "[analyzer] Add fix-it hint support.". NoQ added a comment. - Hide all current fixits behind a checker option, have them off by default. They're not tested enough yet. -

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

Also, how does this stage2 bot work? I clearly see which revision is being compiled from the logs but it is not apparent to me what is the version of the compiler that is used to compiler it. Is it possible that due to some race condition a compiler before my fix is picked up and that is causing

[PATCH] D66031: clangd: use -j for background index pool

puremourning marked an inline comment as done. puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > puremourning wrote:

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214460. puremourning marked an inline comment as not done. puremourning added a comment. Herald added subscribers: jfb, javed.absar. Always use physical cores rather than logical cores for best performance. Repository: rG LLVM Github Monorepo

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

xbolva00 added subscribers: hans, xbolva00. xbolva00 added a comment. Maybe this ABI issue should be fixed for 9.0 ? Not sure how important, but @hans maybe should track this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672

[PATCH] D65925: [clang-format] Add SpaceInEmptyBlock option for WebKit

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/ClangFormatStyleOptions.rst:2120 +**SpaceInEmptyBlock** (``bool``) + If ``true``, spaces may be inserted into ``{}``. +

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

ABataev added a comment. In D65835#1623756 , @kkwli0 wrote: > In D65835#1622042 , @ABataev wrote: > > > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > > > is_device_ptr with the

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65629/new/ https://reviews.llvm.org/D65629

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

I tried both with libc++ instead of libstdc++ and modules but none of them reproduced in my local machine I would be glad if you could try it locally as well! Thanks in advance, Gabor On Fri, 9 Aug 2019 at 13:10, Jonas Devlieghere wrote: > The bot is a little special in that it has modules

[PATCH] D66031: clangd: use -j for background index pool

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { puremourning wrote: > sammccall wrote: > > can we use `std::max(Opts.AsyncThreadsCount,

[PATCH] D65835: [OpenMP] Fix map/is_device_ptr with DSA on combined directive

kkwli0 added a comment. In D65835#1622042 , @ABataev wrote: > > I want to be sure we're on the same page: For OpenMP 5.0, should we allow > > is_device_ptr with the private clauses? > > Yes, since it is allowed by the standard. Umm ... I probably

[PATCH] D66031: clangd: use -j for background index pool

puremourning added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:152 + std::forward(DBSF), + Opts.AsyncThreadsCount ); +} else { sammccall wrote: > can we use `std::max(Opts.AsyncThreadsCount, 1)` instead? > >

[PATCH] D66031: clangd: use -j for background index pool

puremourning updated this revision to Diff 214454. puremourning marked 3 inline comments as done. puremourning added a comment. When -sync -background-index supplied, use 1 thread for background index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D65341: [OpenMP] Add support for close map modifier in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL368491: [OpenMP] Add support for close map modifier in Clang (authored by gbercea, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES

r368491 - [OpenMP] Add support for close map modifier in Clang

Author: gbercea Date: Fri Aug 9 14:42:13 2019 New Revision: 368491 URL: http://llvm.org/viewvc/llvm-project?rev=368491=rev Log: [OpenMP] Add support for close map modifier in Clang Summary: This patch adds support for the close map modifier in Clang. This ensures that the new map type is

[PATCH] D66031: clangd: use -j for background index pool

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Yeah, this is much better than only having `-background-index=no`. I think we should merge this into the 9.0 branch if we still can. Comment at:

Re: r368348 - Fix up fd limit diagnosis code

Thanks for the fix, Qt does seem to build correctly now again. // Martin On Fri, 9 Aug 2019, Reid Kleckner wrote: Let me know if the problem persists after r368475. Someone else filed  https://bugs.llvm.org/show_bug.cgi?id=42948 as well. On Thu, Aug 8, 2019 at 11:34 PM Martin Storsjö

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb updated this revision to Diff 214448. jfb marked an inline comment as done. jfb added a comment. - Rename option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65986/new/ https://reviews.llvm.org/D65986 Files:

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

jfb marked an inline comment as done. jfb added inline comments. Comment at: clang/include/clang/Driver/Options.td:2012 + HelpText<"Use the virtual file system in 'real' mode, or 'physical' mode. In 'real' mode the working directory is linked to the process' working directory.

[PATCH] D66031: clangd: use -j for background index pool

puremourning created this revision. puremourning added a reviewer: kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. clangd supports a -j option to limit the amount of threads to use for parsing TUs. However, when using

[PATCH] D65918: [clang-doc] Generate an HTML index file

This revision was automatically updated to reflect the committed changes. Closed by commit rL368484: [clang-doc] Generate an HTML index file (authored by DiegoAstiazaran, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r368484 - [clang-doc] Generate an HTML index file

Author: diegoastiazaran Date: Fri Aug 9 13:52:28 2019 New Revision: 368484 URL: http://llvm.org/viewvc/llvm-project?rev=368484=rev Log: [clang-doc] Generate an HTML index file clang-doc now generates a file that contains only an index to all the infos that can be used as the landing page for

[PATCH] D65987: [clang-doc] Generate HTML links for children namespaces/records

DiegoAstiazaran updated this revision to Diff 21. DiegoAstiazaran added a comment. Change the implementation of computeRelativePath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65987/new/ https://reviews.llvm.org/D65987 Files: clang-tools-extra/clang-doc/HTMLGenerator.cpp

[PATCH] D65986: Allow setting the VFS to 'real' mode instead of default 'physical'

JDevlieghere added inline comments. Comment at: clang/include/clang/Driver/Options.td:2012 + HelpText<"Use the virtual file system in 'real' mode, or 'physical' mode. In 'real' mode the working directory is linked to the process' working directory. In 'physical' mode it has

[clang-tools-extra] r368482 - [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

Author: sammccall Date: Fri Aug 9 13:45:24 2019 New Revision: 368482 URL: http://llvm.org/viewvc/llvm-project?rev=368482=rev Log: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care. Modified:

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel added a comment. No, I do not have commit access, so if you could commit it, it would be greatly appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453

[PATCH] D64274: [analyzer] VirtualCallChecker overhaul.

NoQ added a comment. In D64274#1600834 , @Szelethus wrote: > If either checker emits an error, the current implementation would say it > originates from `cplusplus.PureVirtualCall`. Could you please create a new > `ProgramPointTag` with the correct

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel marked 2 inline comments as done. ymandel added a comment. Thanks for your detailed and helpful feedback. Comment at: clang/lib/Tooling/Refactoring/Transformer.cpp:129 + Buckets.back().Cases.emplace_back(CaseId, std::move(Case)); } gribozavr wrote:

[PATCH] D65180: [analyzer] VirtualCallChecker: Improve warning messages.

NoQ updated this revision to Diff 214441. NoQ added a comment. - Fix checker names for consumers that display them (eg., clang-tidy). Add a test. - Change bug descriptions: "Call to virtual function during construction or destruction" -> "Pure virtual method call" | "Unexpected loss of virtual

[PATCH] D65877: [libTooling] In Transformer, generalize `applyFirst` to admit rules with incompatible matchers.

ymandel updated this revision to Diff 214442. ymandel marked 14 inline comments as done. ymandel added a comment. Rewrote the code and tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65877/new/ https://reviews.llvm.org/D65877 Files:

[PATCH] D66028: [ASTDump] Add is_anonymous to VisitCXXRecordDecl

shafik created this revision. shafik added reviewers: aaron.ballman, aprantl. Adding is_anonymous the ASTDump for `CXXRecordDecl`. This turned out to be useful when debugging some problems with how LLDB creates ASTs from DWARF. https://reviews.llvm.org/D66028 Files:

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

pcc updated this revision to Diff 214434. pcc marked 2 inline comments as done. pcc added a comment. - Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65629/new/ https://reviews.llvm.org/D65629 Files:

[PATCH] D65629: cfi-icall: Allow the jump table to be optionally made non-canonical.

pcc marked 6 inline comments as done. pcc added inline comments. Comment at: clang/test/CodeGen/cfi-icall-canonical-jump-tables.c:15 +// CHECK: define void @g({{.*}} [[ATTR2:#[0-9]+]] +__attribute__((cfi_jump_table_canonical)) void g() {} + eugenis wrote: >

Re: r368459 - Fix a build bot failure and multiple warnings instances for range base for loops

The bot is a little special in that it has modules enabled. Maybe that explains it? Let me know if that doesn't work and I can try reproducing locally. On Fri, Aug 9, 2019 at 12:02 PM Gábor Horváth wrote: > > I reverted but I cannot reproduce this locally on a linux box. Is there any > way to

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

fedor.sergeev added a comment. In D65975#1621892 , @twoh wrote: > @fedor.sergeev @yamauchi I saw your discussions over llvm-dev mailing list > regarding IR printing with the new pass manager, and though this might be the > reason why IR printing is not

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

NoQ added a comment. Do you have commit access or should i commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 ___ cfe-commits mailing list

  1   2   3   >