r368804 - [NewPM][PassInstrumentation] IR printing support from clang driver

Author: twoh Date: Wed Aug 14 00:11:09 2019 New Revision: 368804 URL: http://llvm.org/viewvc/llvm-project?rev=368804&view=rev Log: [NewPM][PassInstrumentation] IR printing support from clang driver Summary: https://reviews.llvm.org/D50923 enabled the IR printing support for the new pass manager,

[PATCH] D65975: [NewPM][PassInstrumentation] IR printing support from clang driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL368804: [NewPM][PassInstrumentation] IR printing support from clang driver (authored by twoh, committed by ). Herald added a project: LLVM. Changed prior to commit: https://reviews.llvm.org/D65975?vs=21

[PATCH] D66156: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h}

This revision was automatically updated to reflect the committed changes. Closed by commit rL368805: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h} (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

r368805 - Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp, h}

Author: gribozavr Date: Wed Aug 14 00:32:51 2019 New Revision: 368805 URL: http://llvm.org/viewvc/llvm-project?rev=368805&view=rev Log: Removed dead code from clang/tools/libclang/CXIndexDataConsumer.{cpp,h} Reviewers: jkorous Subscribers: dexonsmith, arphaman, cfe-commits Tags: #clang Differe

[PATCH] D66173: [Codegen] Updated test for D66158

xbolva00 updated this revision to Diff 215039. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66173/new/ https://reviews.llvm.org/D66173 Files: test/CodeGen/struct-copy.c Index: test/CodeGen/struct-copy.c === --- test/Cod

r368808 - Fix the -Wunused-variable warning.

Author: hokein Date: Wed Aug 14 01:20:42 2019 New Revision: 368808 URL: http://llvm.org/viewvc/llvm-project?rev=368808&view=rev Log: Fix the -Wunused-variable warning. Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporter.cpp cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Mo

r368809 - [Codegen] Updated test for D66158

Author: xbolva00 Date: Wed Aug 14 01:32:31 2019 New Revision: 368809 URL: http://llvm.org/viewvc/llvm-project?rev=368809&view=rev Log: [Codegen] Updated test for D66158 Reviewers: jdoerfert Reviewed By: jdoerfert Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llv

[PATCH] D66173: [Codegen] Updated test for D66158

This revision was automatically updated to reflect the committed changes. Closed by commit rL368809: [Codegen] Updated test for D66158 (authored by xbolva00, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D66179: [LifetimeAnalysis] Support more STL idioms (template forward declaration and DependentNameType)

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:102 + dyn_cast_or_null(Record->getDescribedTemplate())) { +if (auto *Def = Record->getDefinition()) + addGslOwnerPointerAttributeIfNotExisting(Context, Def); I wonder why

[PATCH] D65935: [ASTImporter] Import ctor initializers after setting flags.

balazske updated this revision to Diff 215056. balazske added a comment. - Moved 'ctor initializer' import before import of body. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65935/new/ https://reviews.llvm.org/D65935 Files: clang/lib/AST/ASTIm

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:128 + // Find the rule wich is the longest prefix of scope. + if (rule.scope.length <= scope.length && + scope.substr(0, rule.scope.length) ==

[PATCH] D66014: [analyzer] Avoid unnecessary enum range check on LValueToRValue casts

gamesh411 accepted this revision. gamesh411 added a comment. @chrish_ericsson_atx Thanks for fixing this! Your help is much appreciated :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66014/new/ https://reviews.llvm.org/D66014

[PATCH] D66206: [CodeGen] Don't keep stale pointers to LoopInfos

ebevhan created this revision. ebevhan added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. CGLoopInfo was keeping pointers to parent loop LoopInfos, but when the loop info vector grew, it reallocated the storage and invalidated all of the parent

r368817 - [analyzer] Note last writes to a condition only in a nested stackframe

Author: szelethus Date: Wed Aug 14 02:39:38 2019 New Revision: 368817 URL: http://llvm.org/viewvc/llvm-project?rev=368817&view=rev Log: [analyzer] Note last writes to a condition only in a nested stackframe Exactly what it says on the tin! The comments in the code detail this a little more too.

[PATCH] D64272: [analyzer] Note last writes to a condition only in a nested stackframe

This revision was automatically updated to reflect the committed changes. Closed by commit rL368817: [analyzer] Note last writes to a condition only in a nested stackframe (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

r368818 - [ASTImporter] Import default expression of param before creating the param.

Author: balazske Date: Wed Aug 14 02:41:39 2019 New Revision: 368818 URL: http://llvm.org/viewvc/llvm-project?rev=368818&view=rev Log: [ASTImporter] Import default expression of param before creating the param. Summary: The default expression of a parameter variable should be imported before the

[PATCH] D65577: [ASTImporter] Import default expression of param before creating the param.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc50959431928: [ASTImporter] Import default expression of param before creating the param. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaInit.cpp:6579 + if (Name.size() >= 2 && Name.front() == '_' && + (Name[1] == '_' || llvm::toUpper(Name[1]) == Name[1]))

[PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

Hahnfeld added a comment. Okay, so I wasn't happy with the current explanations because I don't like "fixing" an issue without understanding the problem. Here's a small reproducer: $ cat main.cpp #include "test.h" int main(int argc, char *argv[]) { m[1] = 2; return 0; } $

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

jvikstrom updated this revision to Diff 215065. jvikstrom marked 4 inline comments as done. jvikstrom added a comment. Simplified matching code. Use real scopes for test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm

Re: [PATCH] D65819: [Driver][Bundler] Improve bundling of object files.

I said this before that most probably this is the bug in partial linking, made by ld. But clang-offload-bundler is also nit quite correct here since the original host code is actually not unbundled. I'll fix the patch later today to keep the partial linking for the host object, but really unbund

[PATCH] D66049: [analyzer] PR41729: Fix some false positives and improve strlcat and strlcpy modeling

gamesh411 added a comment. Nice improvements! It was a good catch that a substantial part of the checker could be cut out. Accurate modelling of CString and related API-s is really important, and this is a good step in that direction. I would test this on a larger codebase as well before committ

r368822 - Fix _WIN32 / _WIN64 Wundef warnings

Author: svenvh Date: Wed Aug 14 03:30:18 2019 New Revision: 368822 URL: http://llvm.org/viewvc/llvm-project?rev=368822&view=rev Log: Fix _WIN32 / _WIN64 Wundef warnings For these macros it is the definedness that matters rather than the value. Make new uses of these macros consistent with existi

[clang-tools-extra] r368824 - [clangd] Fix typos and grammar in a comment. NFC

Author: ibiryukov Date: Wed Aug 14 03:49:32 2019 New Revision: 368824 URL: http://llvm.org/viewvc/llvm-project?rev=368824&view=rev Log: [clangd] Fix typos and grammar in a comment. NFC Modified: clang-tools-extra/trunk/clangd/FindSymbols.cpp Modified: clang-tools-extra/trunk/clangd/FindSymbo

[PATCH] D66209: Improved the doc comment for getCommentsInFile

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: hokein. hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo https

[PATCH] D66209: Improved the doc comment for getCommentsInFile

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66209/new/ https://reviews.llvm.org/D66209

[PATCH] D66209: Improved the doc comment for getCommentsInFile

MaskRay added inline comments. Comment at: clang/include/clang/AST/RawCommentList.h:203 + /// \returns A mapping from an offset of the start of the comment to the + /// comment itself, or nullptr in case there are no comments in in \p File. const std::map *getCommentsInFile(

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215077. SureYeaah marked 11 inline comments as done. SureYeaah added a comment. Refactored design and added unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526

r368825 - [clang] - An update after LLVM change.

Author: grimar Date: Wed Aug 14 04:10:01 2019 New Revision: 368825 URL: http://llvm.org/viewvc/llvm-project?rev=368825&view=rev Log: [clang] - An update after LLVM change. SectionRef::getName() was changed to return Expected<> (D66089) Modified: cfe/trunk/lib/CodeGen/ObjectFilePCHContainerOp

r368827 - Improved the doc comment for getCommentsInFile

Author: gribozavr Date: Wed Aug 14 04:11:52 2019 New Revision: 368827 URL: http://llvm.org/viewvc/llvm-project?rev=368827&view=rev Log: Improved the doc comment for getCommentsInFile Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66209 Modified: cfe/

[PATCH] D66209: Improved the doc comment for getCommentsInFile

This revision was automatically updated to reflect the committed changes. Closed by commit rL368827: Improved the doc comment for getCommentsInFile (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://rev

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

alexfh added a comment. In D66042#1627760 , @NoQ wrote: > In D66042#1627193 , @alexfh wrote: > > > But without this patch clang seems to have the same two ANALYZE log lines > > regardless of whether I enable `core`

r368828 - [NFC] Make test more robust

Author: xbolva00 Date: Wed Aug 14 04:13:10 2019 New Revision: 368828 URL: http://llvm.org/viewvc/llvm-project?rev=368828&view=rev Log: [NFC] Make test more robust Currently fails on ARMs Modified: cfe/trunk/test/CodeGen/struct-copy.c Modified: cfe/trunk/test/CodeGen/struct-copy.c URL: http

[PATCH] D66042: [analyzer] Analysis: "Disable" core checkers

Szelethus added a comment. In D66042#1629019 , @alexfh wrote: > In D66042#1627760 , @NoQ wrote: > > > In D66042#1627193 , @alexfh wrote: > > > > > But without this patch clan

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein created this revision. hokein added a reviewer: ilya-biryukov. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. The current behavior for a failed request is just to log it in the output panel. When applyTweak fails for whatever reason, users usu

[PATCH] D66212: Removed ToolExecutor::isSingleProcess, it is not used by anything

gribozavr created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. gribozavr added a reviewer: sammccall. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66212 Files: clang/include/clang/Tooling/AllTUsExecution.h clang/include/clang/Toolin

r368832 - Removed ToolExecutor::isSingleProcess, it is not used by anything

Author: gribozavr Date: Wed Aug 14 04:35:04 2019 New Revision: 368832 URL: http://llvm.org/viewvc/llvm-project?rev=368832&view=rev Log: Removed ToolExecutor::isSingleProcess, it is not used by anything Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D66212

[PATCH] D66212: Removed ToolExecutor::isSingleProcess, it is not used by anything

This revision was automatically updated to reflect the committed changes. Closed by commit rL368832: Removed ToolExecutor::isSingleProcess, it is not used by anything (authored by gribozavr, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to co

r368779 - [analyzer] Don't delete TaintConfig copy constructor

Author: xiaobai Date: Tue Aug 13 18:09:07 2019 New Revision: 368779 URL: http://llvm.org/viewvc/llvm-project?rev=368779&view=rev Log: [analyzer] Don't delete TaintConfig copy constructor Summary: Explicitly deleting the copy constructor makes compiling the function `ento::registerGenericTaintChec

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia added a comment. In D65744#1627589 , @rjmccall wrote: > I see. Is the deduction rule recursive or something, where a pointer to > pointer is inferred to point to the same address space as the pointee? It is recursive indeed and we currently d

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. To improve the UX around navigating and searching through the results. Repository: rG LLVM Github Monorepo https://review

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65856/new/ https://reviews.llvm.org/D65856

[clang-tools-extra] r368834 - [clangd] Loading TokenColorRules as a class mapping the rules to their associated clangd TextMate scope index.

Author: jvikstrom Date: Wed Aug 14 05:11:58 2019 New Revision: 368834 URL: http://llvm.org/viewvc/llvm-project?rev=368834&view=rev Log: [clangd] Loading TokenColorRules as a class mapping the rules to their associated clangd TextMate scope index. Summary: Loads a mapping of the clangd scope look

[PATCH] D65856: [clangd] Added class for mapping TokenColorRules to their associated clangd TextMate scope

This revision was automatically updated to reflect the committed changes. Closed by commit rL368834: [clangd] Loading TokenColorRules as a class mapping the rules to their… (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh added inline comments. Comment at: clang/lib/Sema/OpenCLBuiltins.td:222 +// GenType definitions. +def FGenTypeN : GenericType<"FGenTypeN", TLFloat, VecAndScalar>; +// Generate basic GenTypes. Names are like: GenTypeFloatVecAndScalar. Anastasia wrote: >

[PATCH] D65456: [OpenCL] Add generic type handling for builtin functions

svenvh updated this revision to Diff 215086. svenvh marked 15 inline comments as done. svenvh added a comment. - Update comments as per review comments. - Rename iterator `List` to `VecSizes` in OpenCLBuiltins.td - Format GenericType definition. CHANGES SINCE LAST ACTION https://reviews.llvm.o

r368836 - [analyzer][CFG] Don't track the condition of asserts

Author: szelethus Date: Wed Aug 14 05:20:08 2019 New Revision: 368836 URL: http://llvm.org/viewvc/llvm-project?rev=368836&view=rev Log: [analyzer][CFG] Don't track the condition of asserts Well, what is says on the tin I guess! Some more changes: * Move isInevitablySinking() from BugReporter.cp

[PATCH] D65287: [analyzer][CFG] Don't track the condition of asserts

This revision was automatically updated to reflect the committed changes. Closed by commit rL368836: [analyzer][CFG] Don't track the condition of asserts (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

ilya-biryukov added a comment. Surfacing errors to the users in those cases is definitely something we need to do, thanks! How do they look in practice? In particular, should we add more context information (either in clangd or in the VSCode extension) to those errors, now that we know they are

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/AST.cpp:106 + +/// Returns a nested name specifier if \p ND refers to a an out-of-line +/// definition. `if .. out-

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215089. SureYeaah added a comment. Removed unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLi

[clang-tools-extra] r368841 - [Clangd] NFC: Fixed comment typo

Author: sureyeaah Date: Wed Aug 14 05:40:09 2019 New Revision: 368841 URL: http://llvm.org/viewvc/llvm-project?rev=368841&view=rev Log: [Clangd] NFC: Fixed comment typo Modified: clang-tools-extra/trunk/clangd/unittests/TweakTesting.h Modified: clang-tools-extra/trunk/clangd/unittests/TweakT

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

ilya-biryukov updated this revision to Diff 215090. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Rename the helper function - Remove mention of 'out-of-line definition' from a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein added a comment. In D66211#1629112 , @ilya-biryukov wrote: > How do they look in practice? In particular, should we add more context > information (either in clangd or in the VSCode extension) to those errors, > now that we know they are shown to

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

This revision was automatically updated to reflect the committed changes. Closed by commit rL368842: [clangd] Print qualifiers of out-of-line definitions in document outline (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prio

[clang-tools-extra] r368842 - [clangd] Print qualifiers of out-of-line definitions in document outline

Author: ibiryukov Date: Wed Aug 14 05:51:04 2019 New Revision: 368842 URL: http://llvm.org/viewvc/llvm-project?rev=368842&view=rev Log: [clangd] Print qualifiers of out-of-line definitions in document outline Summary: To improve the UX around navigating and searching through the results. Reviewe

Re: r368561 - [OpenCL] Ignore parentheses for sampler initialization

Yes, merged in r368843. Thanks, Hans On Tue, Aug 13, 2019 at 6:20 PM Anastasia Stulova wrote: > > Hi Hans, > > > Can this be merged into the release 9.0 branch please? > > > Thank you! > Anastasia > > > From: cfe-commits on behalf of Sven van > Haastregt via cf

Re: r368552 - [OpenCL] Fix lang mode predefined macros for C++ mode.

Merged in r368844. Thanks, Hans On Tue, Aug 13, 2019 at 6:21 PM Anastasia Stulova wrote: > > Hi Hans, > > > Can this be merged into the release 9.0 branch please? > > > Thank you! > Anastasia > > > > From: cfe-commits on behalf of Anastasia > Stulova via cfe-co

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. Thanks for providing examples of error messages, also agree they look fine. If we find bad error messages later, we could revisit the presentation strategy. LGTM ===

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215098. SureYeaah added a comment. Removed debug info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt

[PATCH] D66058: [NFC][clang] Move much of the argument handling code from Driver::BuildActions to Driver::handleArguments.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66058/new/ https://reviews.llvm.org/D66058 ___

[PATCH] D66018: [ARM] Take into account -mcpu and -mfpu options while handling 'crypto' feature

dnsampaio added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:482-486 + llvm::ARM::ArchKind ArchKind = + !ArchName.empty() + ? llvm::ARM::parseArch(arm::getARMArch(ArchName, Triple)) + : llvm::ARM::parseCPUArch( +arm::getA

[PATCH] D65182: [analyzer] Add fix-it hint support.

Szelethus accepted this revision. Szelethus added subscribers: gribozavr, aaron.ballman, alexfh. Szelethus added a comment. Hmm, why the need for checker options? Why not have them by default? If fixits are an experimental feature, maybe we should have a global `enable-fixits` config maybe. But

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein updated this revision to Diff 215107. hokein marked an inline comment as done. hokein added a comment. avoid re-implementing of the method. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66211/new/ https://reviews.llvm.org/D66211 Files: cl

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:109 +// Keep the default behavior. +if (error instanceof vscodelc.ResponseError && +error.code === vscodelc.ErrorCodes.RequestCancelled) -

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia updated this revision to Diff 215106. Anastasia marked 26 inline comments as done. Anastasia added a comment. Addressed various comments from Kevin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64418/new/ https://reviews.llvm.org/D64418 Files: docs/LanguageExtensions.rst

r368850 - [Tooling] Added DeclStmtClass to ExtractionSemicolonPolicy

Author: sureyeaah Date: Wed Aug 14 06:37:39 2019 New Revision: 368850 URL: http://llvm.org/viewvc/llvm-project?rev=368850&view=rev Log: [Tooling] Added DeclStmtClass to ExtractionSemicolonPolicy Since the DeclStmt range includes the semicolon, it doesn't need a semicolon at the end during extract

[clang-tools-extra] r368851 - [clangd][vscode] Surface the error when applying tweaks fails

Author: hokein Date: Wed Aug 14 06:38:52 2019 New Revision: 368851 URL: http://llvm.org/viewvc/llvm-project?rev=368851&view=rev Log: [clangd][vscode] Surface the error when applying tweaks fails Summary: The current behavior for a failed request is just to log it in the output panel. When applyTw

[PATCH] D66211: [clangd][vscode] Surface the error when applying tweaks fails

This revision was automatically updated to reflect the committed changes. Closed by commit rL368851: [clangd][vscode] Surface the error when applying tweaks fails (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D66215: [clangd] Print qualifiers of out-of-line definitions in document outline

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:106 + +/// Returns a nested name specifier if \p ND refers to a an out-of-line +/// definition. hokein wrote: > `if .. out-of-line definition` seems a bit confusing, I think here w

[PATCH] D64418: [Docs][OpenCL] Documentation of C++ for OpenCL mode

Anastasia marked 12 inline comments as done and 2 inline comments as done. Anastasia added inline comments. Comment at: docs/LanguageExtensions.rst:327 +.. _languageextensions-builtin-macros: + FYI, this is not part of my change. It was just hard to produce com

r368853 - [analyzer][NFC] Prove that we only track the evaluated part of the condition

Author: szelethus Date: Wed Aug 14 06:51:52 2019 New Revision: 368853 URL: http://llvm.org/viewvc/llvm-project?rev=368853&view=rev Log: [analyzer][NFC] Prove that we only track the evaluated part of the condition ...because we're working with a BugReporterVisitor, and the non-evaluated part of th

[PATCH] D65290: [analyzer][NFC] Prove that we only track the evaluated part of the condition

This revision was automatically updated to reflect the committed changes. Closed by commit rL368853: [analyzer][NFC] Prove that we only track the evaluated part of the condition (authored by Szelethus, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso updated this revision to Diff 215103. Charusso marked 4 inline comments as done. Charusso retitled this revision from "[analyzer] Analysis: "Disable" core checkers" to "[analyzer] Analysis: Silence checkers". Charusso edited the summary of this revision. Charusso set the repository for th

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Charusso added a comment. I realized that it is meaningless what separator we use to list the checkers, so I have picked `;`. The `,` is limited to the `analyzer-config` list. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192-197 + /// Pair of checker

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Adds the main colorizer component. It colorizes every time clangd sends a publishSemanticHighlighting noti

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added a comment. Thanks!!! Please note that BugReporter.cpp (especially the parts you touched) just got refactored extensively, so you'll need to rebase on master. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h:192 /// Pair of checker name a

[PATCH] D61027: Fix crash on switch conditions of non-integer types in templates

eandrews added a comment. Thank you for letting me know. I did try reproducing the issue with check-all yesterday but was unable to. I do not think I build with 'clang-tools-extra' project enabled though. I'll take another look today. Repository: rL LLVM CHANGES SINCE LAST ACTION https:/

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.def:392 +StringRef, RawSilencedCheckers, "silence-checkers", +"A semicolon separated list of checker and package names to silence.", "") + Hmm, maybe we c

[PATCH] D66042: [analyzer] Analysis: Silence checkers

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp:468-502 void CheckerRegistry::validateCheckerOptions() const { for (const auto &Config : AnOpts.Config) { StringRef SuppliedChecker; StringRef SuppliedOption; s

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

bruntib updated this revision to Diff 215122. bruntib added a comment. Since now the order of diagnostic messages is deterministic, we can count on this order in the test file. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65065/new/ https://review

[PATCH] D65453: Improve the accuracy of the Clang call graph analysis

jcranmer-intel added a comment. The test has been passing for me. What error are you seeing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65453/new/ https://reviews.llvm.org/D65453 ___ cfe-commits mai

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

b-sumner added a comment. Looks fine to me. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D65065: [clang-tidy] Possibility of displaying duplicate warnings

lebedev.ri added a comment. LGTM Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65065/new/ https://reviews.llvm.org/D65065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

r368862 - [libTooling] Fix code to avoid unused-function warning after r368681.

Author: ymandel Date: Wed Aug 14 08:20:06 2019 New Revision: 368862 URL: http://llvm.org/viewvc/llvm-project?rev=368862&view=rev Log: [libTooling] Fix code to avoid unused-function warning after r368681. Modified: cfe/trunk/lib/Tooling/Refactoring/Transformer.cpp Modified: cfe/trunk/lib/Tool

[PATCH] D66221: [clangd] Added highlighting for non type templates.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Highlights pointers to variables as variables. Function pointers are highlighted as functions. Member func

[PATCH] D65919: [clang-tidy] Add llvm-prefer-register-over-unsigned check and apply it to LLVM

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/llvm/LLVMTidyModule.cpp:26 void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { +using readability::NamespaceCommentCheck; + dsanders wrote: > aaron.ballman

[PATCH] D65526: [Clangd] Initial prototype version of ExtractFunction

SureYeaah updated this revision to Diff 215131. SureYeaah added a comment. Better Naming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt cl

r368863 - [NFC] Fix testcase for ARMs

Author: xbolva00 Date: Wed Aug 14 08:35:40 2019 New Revision: 368863 URL: http://llvm.org/viewvc/llvm-project?rev=368863&view=rev Log: [NFC] Fix testcase for ARMs Modified: cfe/trunk/test/CodeGen/struct-copy.c Modified: cfe/trunk/test/CodeGen/struct-copy.c URL: http://llvm.org/viewvc/llvm-p

[PATCH] D27165: Add format_dynamic_key_arg attribute to improve "-Wformat" warnings for functions that load the formatting string dynamically based on a key value

aaron.ballman accepted this revision. aaron.ballman added a comment. I like this approach much better! LGTM, aside from a minor nit. Comment at: clang/include/clang/Basic/IdentifierTable.h:754 + /// If this selector is the specific keyword selector described by Names. + bool

[PATCH] D65997: Add options rounding and exceptions to pragma fp

sepavloff updated this revision to Diff 215134. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65997/new/ https://reviews.llvm.org/D65997 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Basi

[PATCH] D65997: Add options rounding and exceptions to pragma fp

sepavloff marked 2 inline comments as done. sepavloff added inline comments. Comment at: clang/lib/Parse/ParsePragma.cpp:2697 PP.Lex(Tok); +StringRef ExpectedArgumentText; +switch (*FlagKind) { aaron.ballman wrote: > sepavloff wrote: > > aaron.ballma

[PATCH] D66206: [CodeGen] Don't keep stale pointers to LoopInfos

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66206/new/ https://reviews.llvm.org/D66206 ___

[PATCH] D62731: [RFC] Add support for options -fp-model= and -fp-speculation= : specify floating point behavior

mibintc added a comment. Here's a summary of how the rm and eb options are set if user requests fp-model=strict, then the ConstrainedIntrinsic will be built with ( rmDynamic, ebStrict ) if user requests fp-model=except or fp-model=noexcept then the ConstrainedIntrinsic will be built with eb se

[PATCH] D66092: [CodeGen] Generate constrained fp intrinsics depending on FPOptions

andrew.w.kaylor added a comment. In D66092#1627339 , @sepavloff wrote: > In D66092#1625380 , @kpn wrote: > > > Also, if any constrained intrinsics are used in a function then the entire > > function needs to be con

[PATCH] D65997: Add options rounding and exceptions to pragma fp

aaron.ballman added a comment. This generally LGTM, but there are open questions on https://reviews.llvm.org/D66092#1625380 that I think need to be answered before this should be committed. Comment at: clang/lib/Parse/ParsePragma.cpp:2678 + auto *AnnotValue = new (PP.getPr

[PATCH] D66226: [clangd] Skip function bodies inside processed files while indexing

ilya-biryukov created this revision. ilya-biryukov added reviewers: kadircet, sammccall. Herald added subscribers: arphaman, jkorous, MaskRay. Herald added a project: clang. This significantly improves performance of background indexing. We do not collect references and declarations inside the pr

[PATCH] D66221: [clangd] Added highlighting for non type templates.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:231 + if (TP->isFunctionPointerType()) { +addToken(Loc, HighlightingKind::Function); +return; Why do we special-case template param

r368871 - [LifetimeAnalysis] Fix false negatives of statement local lifetime analysis for some STL implementation

Author: xazax Date: Wed Aug 14 09:34:56 2019 New Revision: 368871 URL: http://llvm.org/viewvc/llvm-project?rev=368871&view=rev Log: [LifetimeAnalysis] Fix false negatives of statement local lifetime analysis for some STL implementation Differential Revision: https://reviews.llvm.org/D66152 Modi

[PATCH] D66152: Fix false negatives of statement local lifetime analysis for some STL implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL368871: [LifetimeAnalysis] Fix false negatives of statement local lifetime analysis for… (authored by xazax, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

  1   2   3   >