[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

balazske marked 2 inline comments as done. balazske added a comment. I remember that we had "problems" with nonsense ODR warnings where both declarations are the same. Probably the reason for it was this cache problem. Still the `NonEquivalentDecls` as cache is useful to filter out the non-equi

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:38 Primitive, + LocalVariable, NIT: maybe put it right after `Variable`? IIUC, we do not rely on actual numeric values being the same across different clangd v

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

kadircet added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:229 +if (const VarDecl *VD = dyn_cast(D)) { + if (VD->isLocalVarDecl()) { +addToken(Loc, HighlightingKind::LocalVariable); nit: `addToken(Loc, VD->isLoc

[PATCH] D66723: [clangd] Add a distinct highlighting for local variables

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/SemanticHighlighting.h:38 Primitive, + LocalVariable, ilya-biryukov wrote: > NIT: maybe put it right after `Va

[clang-tools-extra] r369884 - [clangd] Send highlighting diff beyond the end of the file.

Author: hokein Date: Mon Aug 26 01:38:45 2019 New Revision: 369884 URL: http://llvm.org/viewvc/llvm-project?rev=369884&view=rev Log: [clangd] Send highlighting diff beyond the end of the file. Summary: This would make the client life (tracking the changes) easier. Reviewers: jvikstrom Subscribe

[PATCH] D66541: [clangd] Send highlighting diff beyond the end of the file.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369884: [clangd] Send highlighting diff beyond the end of the file. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[PATCH] D66627: [clang-tidy] new check: bugprone-pthread-return

gribozavr added a comment. Thanks for the contribution! In abstract, I think it is a good checker, however, the implementation largely duplicates `clang-tidy/bugprone/PosixReturnCheck.cpp` -- do you think you could factor out the common parts? I see at least two ways: - Factor out a library, u

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom updated this revision to Diff 217099. jvikstrom marked 12 inline comments as done. jvikstrom added a comment. Made tests more readable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66219/new/ https://reviews.llvm.org/D66219 Files: cla

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:135 + // Update the themeRuleMatcher that is used when highlighting. Also triggers a + // recolorization for all current highlighters. Safe to call multipl

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr. Herald added subscribers: kadircet, arphaman, jkorous. Herald added a project: clang. Previously, it would always return nullptr on any error. This change adds a parameter, controlling whether the function should attem

[PATCH] D66731: [Driver] Add an option for createInvocationFromCommandLine to recover on errors

gribozavr added a comment. It does seem reasonable for Clangd to recover when it sees unknown command line flags (after all, in compiler_commands.json we can see command line flags from past and future versions of Clang, GCC and other compilers -- whatever the build system decided to write ther

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

balazske updated this revision to Diff 217105. balazske added a comment. - Small update to newer C++ syntax, use std::pair in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66538/new/ https://reviews.llvm.org/D66538 Files: clang/include/cla

[PATCH] D65526: [Clangd] First version of ExtractFunction

SureYeaah updated this revision to Diff 217108. SureYeaah added a comment. Fixed typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65526/new/ https://reviews.llvm.org/D65526 Files: clang-tools-extra/clangd/refactor/tweaks/CMakeLists.txt clang

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks great, looking forward to use it, just a few more nits. Please update the patch description before committing. Comment at: clang-tools-extra/clangd/clients/cl

[PATCH] D66516: [clangd] Added highlighting to types dependant on templates.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:177 return; +if (TP->isPointerType() || TP->isLValueReferenceType()) + // When highlighting dependant template types the type

[PATCH] D66732: [Clangd] ExtractFunction Added checks for broken control flow

SureYeaah created this revision. SureYeaah added reviewers: sammccall, kadircet. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Added a SelectionTreeVisitor to check for broken control flow - Added unittests Repository: rG LL

[PATCH] D14484: Formatting constructor initializer lists by putting them always on different lines

rfairliecuninghame added a comment. I also think this feature bears further consideration. I understand that google and other coding standard currently allows this, but I feel there's a certain degree of inconsistency in their doing so. None of the open main coding standards would recommend or

[clang-tools-extra] r369893 - [clangd] Added a colorizer to the vscode extension.

Author: jvikstrom Date: Mon Aug 26 04:36:11 2019 New Revision: 369893 URL: http://llvm.org/viewvc/llvm-project?rev=369893&view=rev Log: [clangd] Added a colorizer to the vscode extension. Summary: Adds the main colorizer component. It colorizes every time clangd sends a publishSemanticHighlighti

[PATCH] D66219: [clangd] Added a colorizer to the vscode extension.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 10 inline comments as done. Closed by commit rL369893: [clangd] Added a colorizer to the vscode extension. (authored by jvikstrom, committed by ). Herald added a project: LLVM. Herald added a subscriber: llv

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal created this revision. steakhal added reviewers: NoQ, krememek, Szelethus, baloghadamsoftware. Herald added subscribers: cfe-commits, Charusso, donat.nagy, dexonsmith, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun, whisperity. Herald added a project: clang. Enables the users to

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. I really-really like this change. The results look great, though I'm not sure what happened here

[PATCH] D65526: [Clangd] First version of ExtractFunction

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:29 +// - Always passed by l-value reference +// - No return +// - Cannot move declarations before extracting did you mean no return *type* ? =

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Just reapplies highlightings for all files when visible text editors change. Could find the correct text e

[PATCH] D65526: [Clangd] First version of ExtractFunction

sammccall added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractFunction.cpp:46 +//creating a NewFunction. +// Design Doc at +//===--===// please fix or remove c

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:94 +vscode.window.onDidChangeVisibleTextEditors( +() => this.highlighter.onDidChangeVisibleTextEditors()); +vscode.workspace.onDidCloseTextDocume

[PATCH] D66736: clang-format: [JS] handle `as const`.

mprobst created this revision. mprobst added a reviewer: krasimir. Herald added a project: clang. TypeScript 3.4 supports casting into a const type using `as const`: const x = {x: 1} as const; Previously, clang-format would insert a space after the `const`. With this patch, no space is inserte

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

jvikstrom marked an inline comment as done. jvikstrom added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:94 +vscode.window.onDidChangeVisibleTextEditors( +() => this.highlighter.onDidChangeVisibleTextEditors

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

gribozavr added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:106 +// argument, while the change spans only the argument AND there are two such +// matches. Here, we expect a conflict between the two matches and the second

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:94 +vscode.window.onDidChangeVisibleTextEditors( +() => this.highlighter.onDidChangeVisibleTextEditors()); +vscode.workspace.onDidCloseTextDocume

[PATCH] D66486: [LifetimeAnalysis] Detect more cases when the address of a local variable escapes

gribozavr added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6775 +if (!pathOnlyInitializesGslPointer(Path)) + Init = const_cast(Init->skipRValueSubobjectAdjustments()); xazax.hun wrote: > gribozavr wrote: > > I'm afraid this change could d

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Structured bindings are in a BindingDecl. The decl the declRefExpr points to are the BindingDecls. So this

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

jvikstrom updated this revision to Diff 217131. jvikstrom added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66735/new/ https://reviews.llvm.org/D66735 Files: clang-tools-extra/clangd/clients/clangd-vscode/src/seman

[PATCH] D66572: [analyzer] BugReporter Separation Ep.I.

gribozavr added a comment. Sorry for the silly comments, but my main point is, I guess, that I don't quite understand the design towards which you are refactoring, and to meaningfully review patches I need to be on the same page. Comment at: clang/include/clang/StaticAnalyzer

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

jvikstrom updated this revision to Diff 217134. jvikstrom added a comment. Fixed changes that weren't supposed to be made. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66735/new/ https://reviews.llvm.org/D66735 Files: clang-tools-extra/clangd/c

[PATCH] D59692: [ASTImporter] Fix name conflict handling

martong updated this revision to Diff 217135. martong added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - Use resulting Name from HandleNameConflict if set - Add ODRHandling strategies - Refactor tests, to avoid some code repetition Repository: rG LLVM Git

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. I think there is one more case -- we need to cleanup the highlighting cache if clangd crashes, the extension will automatically restart clangd up to 5 times if it sees clangd crashes, you can

[PATCH] D59692: [ASTImporter] Fix name conflict handling with different strategies

martong added a comment. @shafik I have updated the patch with ODR handling strategies as per our discusson. For the record I copy our discussion here: On Sat, Aug 24, 2019 at 12:50 AM Shafik Yaghmour wrote: > Apologies, I missed this earlier! > > On Wed, Aug 21, 2019 at 2:44 AM Gábor Márto

[clang-tools-extra] r369911 - [clangd] Handling text editor/document lifetimes in vscode extension.

Author: jvikstrom Date: Mon Aug 26 06:56:45 2019 New Revision: 369911 URL: http://llvm.org/viewvc/llvm-project?rev=369911&view=rev Log: [clangd] Handling text editor/document lifetimes in vscode extension. Summary: Just reapplies highlightings for all files when visible text editors change. Coul

[PATCH] D66740: [clangd] Add docs for configuration knobs in clangd

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is a first step in documenting different configuration knobs we have in clangd. Repository: rG LLVM Githu

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

ymandel updated this revision to Diff 217146. ymandel added a comment. fixed comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66676/new/ https://reviews.llvm.org/D66676 Files: clang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cp

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp:106 +// argument, while the change spans only the argument AND there are two such +// matches. Here, we expect a conflic

[PATCH] D66735: [clangd] Handling text editor/document lifetimes in vscode extension.

This revision was automatically updated to reflect the committed changes. jvikstrom marked 4 inline comments as done. Closed by commit rG1c9aa70b042b: [clangd] Handling text editor/document lifetimes in vscode extension. (authored by jvikstrom). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D66740: [clangd] Add docs for configuration knobs in clangd

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/docs/clangd/Configuration.rst:10 + +Clangd has a bunch of command-line options and LSP capabilities that can change +its behaviour in

[PATCH] D66743: [clangd] Cleans up the semantic highlighting resources if clangd crashes.

jvikstrom created this revision. jvikstrom added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Disposes of the vscode listeners when clangd crashes and reuses the old highlighter when it restarts. The

Re: [clang-tools-extra] r369763 - [clang-tidy] Possibility of displaying duplicate warnings

Apologies for not picking this up, I just recently changed my commit email. I can see that it was fixed in the meanwhile. On Sat, 24 Aug 2019 at 01:45, Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Kristof, > > This commit broke test to few builders: > > > http://l

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

gribozavr accepted this revision. gribozavr added a comment. This revision is now accepted and ready to land. I see, it all makes sense now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66676/new/ https://reviews.llvm.org/D66676 ___

[PATCH] D66740: [clangd] Add docs for configuration knobs in clangd

kadircet updated this revision to Diff 217154. kadircet marked 6 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66740/new/ https://reviews.llvm.org/D66740 Files: clang-tools-ex

[PATCH] D66738: [clangd] Added highlighting for structured bindings.

hokein added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:236 + // binding if one exist. + if (const auto *BB = B->getBinding()) +if (const auto *RD = BB->getReferencedDeclOfCallee()) nit: could you spell out th

[PATCH] D61879: WIP: Prototype of DSE optimizations for -ftrivial-auto-var-init

glider added a comment. In D61879#1621423 , @vitalybuka wrote: > Fix https://godbolt.org/z/-PinQP Please consider adding a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61879/new/ https://reviews.ll

[clang-tools-extra] r369914 - [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

Author: ymandel Date: Mon Aug 26 08:17:29 2019 New Revision: 369914 URL: http://llvm.org/viewvc/llvm-project?rev=369914&view=rev Log: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message. Summary: This patch changes the location specified to the `ClangTidyChec

[PATCH] D66676: [clang-tidy] TransformerClangTidyCheck: change choice of location for diagnostic message.

This revision was automatically updated to reflect the committed changes. Closed by commit rL369914: [clang-tidy] TransformerClangTidyCheck: change choice of location for… (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[clang-tools-extra] r369915 - [clang-tidy][NFC] Qualify `makeRule` call in test, for consistency with other calls.

Author: ymandel Date: Mon Aug 26 08:27:05 2019 New Revision: 369915 URL: http://llvm.org/viewvc/llvm-project?rev=369915&view=rev Log: [clang-tidy][NFC] Qualify `makeRule` call in test, for consistency with other calls. One call `makeRule` is unqualified (and unintentionally relying on ADL to res

[PATCH] D66673: [OPENMP][NVPTX]Fix critical region codegen.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66673/new/ https://reviews.llvm.org/D66673 ___ cfe-comm

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal marked 3 inline comments as done. steakhal added a comment. Thank you for your response @Szelethus. Fixed, updating the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal updated this revision to Diff 217162. steakhal added a comment. Reformatted using `clang-format-diff.py`. Minor fixes which were requested by @Szelethus. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733 Files: clang/docs/analyzer/check

r369916 - clang-format: [JS] handle `as const`.

Author: mprobst Date: Mon Aug 26 08:37:05 2019 New Revision: 369916 URL: http://llvm.org/viewvc/llvm-project?rev=369916&view=rev Log: clang-format: [JS] handle `as const`. Summary: TypeScript 3.4 supports casting into a const type using `as const`: const x = {x: 1} as const; Previously, cla

[PATCH] D66747: Moved GlobList into a separate header file

gribozavr created this revision. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. It is a separate abstraction that is used in more contexts than just a helper for ClangTidyDiagnosticConsumer. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D66747 Fi

[PATCH] D66747: Moved GlobList into a separate header file

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66747/new/ https://reviews.llvm.org/D66747 _

[PATCH] D66736: clang-format: [JS] handle `as const`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5836472ac488: clang-format: [JS] handle `as const`. (authored by mprobst). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66736/new/ https://reviews.llvm.org

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal updated this revision to Diff 217164. steakhal added a comment. Fix copy-paste mistake. This time upload the correct version. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733 Files: clang/docs/analyzer/checkers.rst clang/include/clan

[clang-tools-extra] r369917 - [clangd] Add docs for configuration knobs in clangd

Author: kadircet Date: Mon Aug 26 08:42:16 2019 New Revision: 369917 URL: http://llvm.org/viewvc/llvm-project?rev=369917&view=rev Log: [clangd] Add docs for configuration knobs in clangd Summary: This is a first step in documenting different configuration knobs we have in clangd. Reviewers: samm

[PATCH] D66662: [clang-format] [PR43100] clang-format C# support does not add a space between "using" and paren

MyDeveloperDay updated this revision to Diff 217167. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: clang/lib/Format/TokenAnnotator.cpp clang/unittests/Format/FormatTestCSharp.cpp Index: clang/unittests/Format/FormatTestCSharp.cpp ==

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D66740: [clangd] Add docs for configuration knobs in clangd

This revision was automatically updated to reflect the committed changes. Closed by commit rG3aeed0fd5ad5: [clangd] Add docs for configuration knobs in clangd (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66740/new/ https://r

[clang-tools-extra] r369918 - Moved GlobList into a separate header file

Author: gribozavr Date: Mon Aug 26 08:44:32 2019 New Revision: 369918 URL: http://llvm.org/viewvc/llvm-project?rev=369918&view=rev Log: Moved GlobList into a separate header file Summary: It is a separate abstraction that is used in more contexts than just a helper for ClangTidyDiagnosticConsumer

[PATCH] D66748: [PowerPC][Altivec][Clang] Check compile-time constant for vec_dst*

jsji created this revision. jsji added reviewers: nemanjai, hfinkel, echristo. Herald added subscribers: cfe-commits, shchenz, MaskRay, kbarton. Herald added a project: clang. jsji added a reviewer: PowerPC. Herald added a subscriber: wuzish. This is follow up of https://reviews.llvm.org/D66699. W

[PATCH] D66538: [AST] AST structural equivalence to work internally with pairs.

martong added a comment. In D66538#1642999 , @balazske wrote: > In D66538#1642883 , @martong wrote: > > > There is a third test which could be useful to test whether there is no > > faulty cache entries there: > >

[PATCH] D66336: [ASTImporter] Add development internals docs

martong updated this revision to Diff 217171. martong added a comment. - Fix typo: getTemplatedDec -> getTemplatedDecl Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66336/new/ https://reviews.llvm.org/D66336 Files: clang/docs/InternalsManual.rst

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

steakhal added a comment. @NoQ What do you think, should it be under a flag (as it would be now), or enabled by default? I think these warnings are valuable and we should consider it enabling by default. An interesting fact is that previously rGf224820b45c6847b91071da8d7ade59f373b96f3

[PATCH] D66747: Moved GlobList into a separate header file

This revision was automatically updated to reflect the committed changes. Closed by commit rGa6fed93f0d10: Moved GlobList into a separate header file (authored by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66747/new/ https://reviews.l

[PATCH] D66336: [ASTImporter] Add development internals docs

martong marked 2 inline comments as done. martong added inline comments. Comment at: clang/docs/InternalsManual.rst:1470 +*templated* class (the ``CXXRecordDecl``) of a ``ClassTemplateDecl`` with +``ClassTemplateDecl::getTemplatedDec()``. And we can get back a pointer of the +"de

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev added a comment. Any feedback? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66485/new/ https://reviews.llvm.org/D66485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang-tools-extra] r369920 - [clangd] Fix docs

Author: kadircet Date: Mon Aug 26 09:01:07 2019 New Revision: 369920 URL: http://llvm.org/viewvc/llvm-project?rev=369920&view=rev Log: [clangd] Fix docs Modified: clang-tools-extra/trunk/docs/clangd/Configuration.rst Modified: clang-tools-extra/trunk/docs/clangd/Configuration.rst URL: http:

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:485 +"=" + InputFileNames[I])); +ObjcopyArgs.push_back(InputFileNames[HostInputIndex]); +ObjcopyArgs.push_back(OutputFileNames.front())

Re: r369829 - PR40674: fix assertion failure if a structured binding declaration has a

Merged to release_90 in r369921. On Sat, Aug 24, 2019 at 3:22 AM Richard Smith via cfe-commits wrote: > > Author: rsmith > Date: Fri Aug 23 18:23:57 2019 > New Revision: 369829 > > URL: http://llvm.org/viewvc/llvm-project?rev=369829&view=rev > Log: > PR40674: fix assertion failure if a structured

[PATCH] D66565: [analyzer] pr43036: Fix support for operator `sizeof...'.

Szelethus accepted this revision. Szelethus added a comment. (++LGTM)++ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66565/new/ https://reviews.llvm.org/D66565 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

aganea updated this revision to Diff 217179. aganea added a comment. Fixed unit tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 Files: lib/Lex/DependencyDirectivesSourceMinimizer.cpp test/Lexer/minimize_source_to_dependency_directives

[clang-tools-extra] r369925 - [clang-doc] Switch Generator::CreateResources to use llvm::Error

Author: juliehockett Date: Mon Aug 26 09:39:48 2019 New Revision: 369925 URL: http://llvm.org/viewvc/llvm-project?rev=369925&view=rev Log: [clang-doc] Switch Generator::CreateResources to use llvm::Error Differential Revision: https://reviews.llvm.org/D66502 Modified: clang-tools-extra/trunk

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:485 +"=" + InputFileNames[I])); +ObjcopyArgs.push_back(InputFileNames[HostInputIndex]); +

[PATCH] D66751: [clangd] Add targetDecl(), which determines what declaration an AST node refers to.

sammccall created this revision. sammccall added reviewers: kadircet, ilya-biryukov. Herald added subscribers: cfe-commits, jfb, arphaman, jkorous, MaskRay, mgorny. Herald added a project: clang. This is the first part of an effort to "unbundle" our libIndex use into separate concerns (AST travers

[PATCH] D66502: [clang-doc] Switch Generator::CreateResources to use llvm::Error

This revision was automatically updated to reflect the committed changes. Closed by commit rG72e1f7f960d5: [clang-doc] Switch Generator::CreateResources to use llvm::Error (authored by juliehockett). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

ABataev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:233 +// RUN: clang-offload-bundler -type=o -targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu -inputs=%t.o,%t.tgt1,%t.tgt2 -outputs=%t.bundle3.o -###

r369926 - Fix -dA flag, it is not a preprocessor flag.

Author: erichkeane Date: Mon Aug 26 10:00:13 2019 New Revision: 369926 URL: http://llvm.org/viewvc/llvm-project?rev=369926&view=rev Log: Fix -dA flag, it is not a preprocessor flag. -dA was in the d_group, which is a preprocessor state dumping group. However -dA is a debug flag to cause a verbose

r369928 - [NFC] Add comments to some bool arguments for better readability

Author: xazax Date: Mon Aug 26 10:03:01 2019 New Revision: 369928 URL: http://llvm.org/viewvc/llvm-project?rev=369928&view=rev Log: [NFC] Add comments to some bool arguments for better readability Modified: cfe/trunk/lib/Sema/SemaInit.cpp Modified: cfe/trunk/lib/Sema/SemaInit.cpp URL: http:

[PATCH] D66686: [LifetimeAnalysis] Make it possible to disable the new warnings

xazax.hun marked an inline comment as done. xazax.hun added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:6651 visitLocalsRetainedByReferenceBinding(Path, Arg, RK_ReferenceBinding, -Visit); +

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/test/Driver/clang-offload-bundler.c:233 +// RUN: clang-offload-bundler -type=o -targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu -inputs=%t

[PATCH] D66556: [clang-scan-deps] Minimizer: Correctly handle multi-line content with CR+LF line endings

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66556/new/ https://reviews.llvm.org/D66556 ___ cfe-commits mailing list cfe-commi

[PATCH] D66485: [Clang][Bundler] Use llvm-objcopy for creating fat object files

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66485/new/ https://reviews.llvm.org/D66485 ___ cfe-commits ma

[PATCH] D65907: Introduce FileEntryRef and use it when handling includes to report correct dependencies when the FileManager is reused across invocations

arphaman added a comment. In D65907#1643800 , @JamesNagurne wrote: > In D65907#1643650 , @arphaman wrote: > > > No the windows test failure was different, there were no Deps at all. I'm > > currently investigating

[PATCH] D66705: FileManager: Use llvm::Expected in new getFileRef API

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66705/new/ https://reviews.llvm.org/D66705 ___ cfe-commits mailing list cfe-commi

[PATCH] D66713: ContentCache: Drop getBuffer's dependency on SourceManager

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66713/new/ https://reviews.llvm.org/D66713 ___ cfe-commits mailing list cfe-commi

[PATCH] D66710: ASTReader: Bypass overridden files when reading PCHs

arphaman added a comment. Missing full context CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66710/new/ https://reviews.llvm.org/D66710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

r369931 - [libclang][index][NFCi] Refactor machinery for skipping function bodies

Author: jkorous Date: Mon Aug 26 10:25:23 2019 New Revision: 369931 URL: http://llvm.org/viewvc/llvm-project?rev=369931&view=rev Log: [libclang][index][NFCi] Refactor machinery for skipping function bodies Refactor machinery for skipping inline function bodies that have already been parsed in oth

[PATCH] D66694: [libclang][index][NFCi] Refactor machinery for skipping already parsed function bodies

This revision was automatically updated to reflect the committed changes. Closed by commit rGb1c90791024b: [libclang][index][NFCi] Refactor machinery for skipping function bodies (authored by jkorous). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Gi

[PATCH] D66627: [clang-tidy] new check: bugprone-pthread-return

jcai19 marked an inline comment as done. jcai19 added a comment. In D66627#1644775 , @gribozavr wrote: > Thanks for the contribution! In abstract, I think it is a good checker, > however, the implementation largely duplicates > `clang-tidy/bugprone/Posix

r369932 - Fix use of invalidated iterator introduced by r369680.

Author: rsmith Date: Mon Aug 26 10:31:06 2019 New Revision: 369932 URL: http://llvm.org/viewvc/llvm-project?rev=369932&view=rev Log: Fix use of invalidated iterator introduced by r369680. Modified: cfe/trunk/lib/Basic/FileManager.cpp Modified: cfe/trunk/lib/Basic/FileManager.cpp URL: http:/

[clang-tools-extra] r369934 - [clangd] Release notes

Author: sammccall Date: Mon Aug 26 10:47:44 2019 New Revision: 369934 URL: http://llvm.org/viewvc/llvm-project?rev=369934&view=rev Log: [clangd] Release notes Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL: http://llvm.org

Re: r369932 - Fix use of invalidated iterator introduced by r369680.

Thanks for the fix! On Mon, 26 Aug 2019 at 10:29, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Mon Aug 26 10:31:06 2019 > New Revision: 369932 > > URL: http://llvm.org/viewvc/llvm-project?rev=369932&view=rev > Log: > Fix use of invalidated iterator i

r369938 - [driver] add a new option `-gen-cdb-fragment-path` to emit

Author: arphaman Date: Mon Aug 26 10:59:41 2019 New Revision: 369938 URL: http://llvm.org/viewvc/llvm-project?rev=369938&view=rev Log: [driver] add a new option `-gen-cdb-fragment-path` to emit a fragment of a compilation database for each compilation This patch adds a new option called -gen-cdb-

[PATCH] D66695: msan, codegen, instcombine: Keep more lifetime markers used for msan

eugenis accepted this revision. eugenis added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/test/Transforms/InstCombine/lifetime-sanitizer.ll:37-50 +define void @msan() sanitize_memory { +entry: + ; CHECK-LABEL: @msan( + %text = alloca i8,

  1   2   3   >