[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge planned changes to this revision. nridge added a comment. Ok, I can try formulating this as part of / an extension to semantic highlighting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536

[PATCH] D67358: [clangd] Implement semantic selections.

nridge added a comment. Which LSP feature is this related to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67358/new/ https://reviews.llvm.org/D67358 ___ cfe-commits mailing list

Re: r371918 - [Driver] Fix multiple bugs related to dependency file options: -M -MM -MD -MMD -MT -MQ

It was related to D67542 It tried to solve some other problems. On Sun, Sep 15, 2019 at 1:40 AM Nico Weber wrote: > This looks similar to https://reviews.llvm.org/D67542 > > On Sat, Sep 14, 2019 at 1:59 AM Fangrui Song via cfe-commits < >

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

plotfi added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } erichkeane wrote: > aheejin wrote: > > MaskRay wrote: > > >

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } aheejin wrote: >

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

lebedev.ri added a comment. In D67253#1670704 , @paulkirth wrote: > In D67253#1670681 , @lebedev.ri > wrote: > > > Re concurrency - you had standalone `LLVMContext` for each thread, right? > > > I believe there

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

paulkirth added a comment. In D67253#1670681 , @lebedev.ri wrote: > Re concurrency - you had standalone `LLVMContext` for each thread, right? I believe there was, but this is just whatever happens when libtooling creates and executes a compiler

[PATCH] D67588: Add builtin trait for add/remove cv (and similar)

zoecarver added a comment. @lebedev.ri after adding _only_ these builtins to libc++ the type trait tests run several seconds faster. I think if we update _all_ the type traits to use builtins then, it could increase speed of the type trait tests by as much as 50% (if not more). CHANGES SINCE

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

lebedev.ri added a comment. Re concurrency - you had standalone `LLVMContext` for each thread, right? In D67253#1670667 , @paulkirth wrote: > In D67253#1670569 , @lebedev.ri > wrote: > > > Layering feels weird

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

paulkirth added a comment. In D67253#1670569 , @lebedev.ri wrote: > Layering feels weird here. > Can this be implemented as/limited to just a > `run-clang-misexpect.py` wrapper over clang itself? > That would be best IMHO. I discussed the concurrency

Re: [PATCH] D66564: [clang-tidy] new FPGA struct pack align check

I'm not sure what is the advantage of this compared to -Wpadded? On Sun, Sep 15, 2019 at 12:05 PM Roman Lebedev via Phabricator via llvm-commits wrote: > lebedev.ri added a comment. > > Forgot the most important question. > Right now this will fire on every single struct. > But it won't matter

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

lebedev.ri added a comment. Forgot the most important question. Right now this will fire on every single struct. But it won't matter unless the alignment/size actually matters, and most often that will happen when you have e.g. a vector of such structs. What i'm asking is - should this be more

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

lebedev.ri added a comment. I, too, don't believe this is FPGA specific; it should likely go into `misc-` or even `performance-`. The wording of the diags seems weird to me, it would be good to 1. add more explanation to the docs and 2. reword the diags. Comment at:

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk added a comment. Forgot to link: https://bugs.llvm.org/show_bug.cgi?id=43250 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67592/new/ https://reviews.llvm.org/D67592 ___ cfe-commits mailing

[PATCH] D67592: [Clang] Use -main-file-name for source filename if not set

the_jk created this revision. the_jk added a reviewer: rsmith. the_jk added a project: clang. Herald added subscribers: cfe-commits, aprantl. -main-file-name is currently used to set the source name used in debug information. If the source filename is "-" and -main-file-name is set, then use

[PATCH] D66564: [clang-tidy] new FPGA struct pack align check

ffrankies marked 22 inline comments as done. ffrankies added a comment. In D66564#1647779 , @BlackAngel35 wrote: > > Please mention new module and check in Release Notes. The new module and check are now mentioned in Release Notes. P.S. The above

r371934 - [OpenMP] Fix OMPClauseReader::readClause() uninitialized variable warning. NFCI.

Author: rksimon Date: Sun Sep 15 09:05:20 2019 New Revision: 371934 URL: http://llvm.org/viewvc/llvm-project?rev=371934=rev Log: [OpenMP] Fix OMPClauseReader::readClause() uninitialized variable warning. NFCI. Fixes static analyzer uninitialized variable warning for the OMPClause - the function

[PATCH] D67420: [analyzer] NFC: Separate PathDiagnosticConsumer options from AnalyzerOptions.

Szelethus added inline comments. Comment at: clang/include/clang/Analysis/PathDiagnostic.h:81 + /// because deterministic mode is always superior when done right, but + /// for some consumers is experimental and needs to be off by default. + bool

[PATCH] D67368: [NFCI]Create CommonAttributeInfo Type as base type of *Attr and ParsedAttr.

aheejin added inline comments. Comment at: cfe/trunk/include/clang/Basic/AttributeCommonInfo.h:166 + ? SpellingIndex + : calculateAttributeSpellingListIndex(); + } MaskRay wrote: > calculateAttributeSpellingListIndex is defined in

[PATCH] D67253: clang-misexpect: a standalone tool for verifying the use of __builtin_expect with PGO data

lebedev.ri added a comment. Layering feels weird here. Can this be implemented as/limited to just a `run-clang-misexpect.py` wrapper over clang itself? That would be best IMHO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67253/new/