[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221209. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files: clang/include/clang/Driver/Action.h clang/include/clang/Driver/Options.td clang/include/clang/Driver/P

r372492 - NFC: Change ObjCQualified*TypesAreCompatible to take

Author: jyknight Date: Sat Sep 21 15:31:28 2019 New Revision: 372492 URL: http://llvm.org/viewvc/llvm-project?rev=372492&view=rev Log: NFC: Change ObjCQualified*TypesAreCompatible to take ObjCObjectPointerType arguments. All callers already had one, just creating a QualType to pass, after which t

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

andwar added inline comments. Comment at: llvm/examples/Bye/Bye.cpp:53 +/* New PM Registration */ + +llvm::PassPluginLibraryInfo getByePluginInfo() { [nit] Empty line Comment at: llvm/examples/Bye/CMakeLists.txt:9 +else() + target_link_librari

[PATCH] D67112: [Sema] Add implicit cast for conversion of function references

aaronpuchert added a reviewer: riccibruno. aaronpuchert added a comment. Perhaps I should mention that this fixes an assertion failure . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67112/new/ https://

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert updated this revision to Diff 221197. aaronpuchert added a comment. Pass correct Clang triple as argument to --target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326 Files: clang/lib/Driver/

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

mehdi_amini added a comment. > we represent the "post-link" flag in the IR (e.g. as a module flag) in order > to keep the IR self-contained. This makes the IR self-contained, which is good, but it also make the interpretation of the IR modal, which isn't great. It means that suddenly the rules

[PATCH] D67627: Clang-format: Add Whitesmiths indentation style

timwoj added a comment. I don't have push access for `master`. Can someone merge this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67627/new/ https://reviews.llvm.org/D67627 ___ cfe-commits mailing l

[PATCH] D67883: [CLANG][BPF] permit any argument type for __builtin_preserve_access_index()

yonghong-song created this revision. yonghong-song added a reviewer: ast. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. Commit c15aa241f821 ("[CLANG][BPF] change __builtin_preserve_access_inde

[PATCH] D67843: DisableFormat also now disables SortIncludes

MyDeveloperDay added a comment. I assume the intention was that users could have DisableFormat=true and SortIncludes=true when they want to sort the includes but not perform any additional formatting in the code. I think by making this change you make it impossible to run clang-format through

[PATCH] D67399: [ARM] Follow AACPS standard for volatile bitfields

rsmith added a comment. In D67399#1669920 , @rjmccall wrote: > In D67399#1669568 , @jfb wrote: > > > In D67399#1669038 , @dnsampaio > > wrote: > > > > > Indeed our main conc

[PATCH] D67638: Improve __builtin_constant_p lowering

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. OK, this is fine by me if you're confident this doesn't degrade the generated code at -O0. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67638/new/ https://re

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Jiboo added a comment. @Szelethus take your time, I'm surprised to be the first with the problem (couldn't find reference on google or llvm bug tracker), I wouldn't be surprised if I fucked up somewhere and that this patch isn't really necessary. Repository: rC Clang CHANGES SINCE LAST ACTI

[PATCH] D67877: [analyzer] Conditionnaly include clang Analysis examples with cmake.

Szelethus added a comment. Apologies for the intrusion, but these plugins were added by me, and test an important case for our internal plugins. Could you please give me just a day or so the check whether the tests work for us correctly? Repository: rC Clang CHANGES SINCE LAST ACTION http

[PATCH] D67877: Conditionnaly include clang Analysis examples with cmake.

Jiboo added inline comments. Comment at: clang/lib/Analysis/plugins/CMakeLists.txt:1-2 -if(CLANG_ENABLE_STATIC_ANALYZER AND LLVM_ENABLE_PLUGINS) +if(CLANG_ENABLE_STATIC_ANALYZER AND LLVM_ENABLE_PLUGINS AND CLANG_BUILD_EXAMPLES) add_subdirectory(SampleAnalyzer) add_subdirec

[PATCH] D67877: Conditionnaly include clang Analysis examples with cmake.

Jiboo updated this revision to Diff 221181. Jiboo marked 3 inline comments as done. Jiboo added a comment. Update to add -U99, although dunno why I don't get more context on clang/lib/Analysis/plugins/CMakeLists.txt. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D67877: Conditionnaly include clang Analysis examples with cmake.

lebedev.ri added a comment. Please upload all patches with full context (`-U9`) Comment at: clang/lib/Analysis/plugins/CMakeLists.txt:1-2 -if(CLANG_ENABLE_STATIC_ANALYZER AND LLVM_ENABLE_PLUGINS) +if(CLANG_ENABLE_STATIC_ANALYZER AND LLVM_ENABLE_PLUGINS AND CLANG_BUILD_EXAM

[PATCH] D67877: Conditionnaly include clang Analysis examples with cmake.

Jiboo created this revision. Jiboo added a reviewer: chandlerc. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Without this patch, the clang Analysis plugin examples (in clang/lib/Analysis/plugins) are always built and installed even if CLANG_BUILD_EXAMPLES is OFF.

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker marked 2 inline comments as done. Tyker added inline comments. Comment at: clang/lib/AST/APValue.cpp:176 + (DataSize - sizeof(MemberPointerBase)) / sizeof(CXXRecordDecl *); + typedef CXXRecordDecl *PathElem; union { Tyker wrote: > aaron.ballman wro

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 221169. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.llvm.org/D63640 Files: clang/include/clang/AST/APValue.h clang/include/clang/AST/ASTContext.h clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h

[PATCH] D67638: Improve __builtin_constant_p lowering

joerg added a comment. Ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67638/new/ https://reviews.llvm.org/D67638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker updated this revision to Diff 221166. Tyker marked 24 inline comments as done. Tyker added a comment. Fixed most changes requested by @aaron.ballman test are currently no valid anymore see comments for why. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63640/new/ https://reviews.l

[PATCH] D63640: [clang] Improve Serialization/Imporing of APValues

Tyker added inline comments. Comment at: clang/include/clang/AST/ASTContext.h:275 - /// Used to cleanups APValues stored in the AST. - mutable llvm::SmallVector APValueCleanups; - aaron.ballman wrote: > Why are you getting rid of this? It seems like we would st

[PATCH] D52386: [Lexer] Add udefined_behavior_sanitizer feature

krytarowski added a comment. Herald added a project: LLVM. This is needed in the NetBSD kernel, more fine-grained checks would be acceptable too, but one global feature detection is what I need. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D52386/new/ https://rev

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

mgorny added a comment. Ping. This is a really silly issue, and one that could be fixed trivially, so it'd be really nice to actually fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new/ https://reviews.llvm.org/D66176 _

r372462 - Attempt to fix a windows buildbot failure

Author: szelethus Date: Sat Sep 21 00:56:40 2019 New Revision: 372462 URL: http://llvm.org/viewvc/llvm-project?rev=372462&view=rev Log: Attempt to fix a windows buildbot failure Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/