Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Fixed the testcase in r372944. On 2019-09-26 08:14, Mikael Holmén via cfe-commits wrote: > Hi, > > On 2019-09-26 03:16, Evgenii Stepanov via cfe-commits wrote: >> Hi, >> >> this change breaks the build with >> >> /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-proj

r372944 - [SortIncludesTest] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919

Author: uabelho Date: Wed Sep 25 23:49:37 2019 New Revision: 372944 URL: http://llvm.org/viewvc/llvm-project?rev=372944&view=rev Log: [SortIncludesTest] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919 Modified: cfe/trunk/unittests/Format/SortIncludesTest.cpp

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

AndWass created this revision. AndWass added reviewers: klimek, owenpan, krasimir, timwoj. AndWass added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. The following code struct f { template void bar() && noexcept {} }; will be format

r372942 - [analyzer] Avoid small vectors of non-default-constructibles.

Author: dergachev Date: Wed Sep 25 23:33:21 2019 New Revision: 372942 URL: http://llvm.org/viewvc/llvm-project?rev=372942&view=rev Log: [analyzer] Avoid small vectors of non-default-constructibles. Unconfuses certain compilers. Modified: cfe/trunk/include/clang/StaticAnalyzer/Core/PathSensit

Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Hi, On 2019-09-26 03:16, Evgenii Stepanov via cfe-commits wrote: > Hi, > > this change breaks the build with > > /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/clang/lib/Format/Format.cpp:737:44: > error: missing field 'SortPriority' initializer > [-Werror,

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6721 + if (getLangOpts().OpenCL) { + Anastasia wrote: > rjmccall wrote: > > Since you're moving this code anyway, can this be split into its own > > function? I'm not sure if it's actual

Re: r372939 - [clang-format] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919

Thank you for fixing this... On Thu, Sep 26, 2019 at 3:00 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: maskray > Date: Wed Sep 25 19:02:17 2019 > New Revision: 372939 > > URL: http://llvm.org/viewvc/llvm-project?rev=372939&view=rev > Log: > [clang-format] Add Sor

Buildbot numbers for the last week of 09/08/2019 - 09/14/2019

Hello everyone, Below are some buildbot numbers for the week of 09/08/2019 - 09/14/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

Buildbot numbers for the week of 09/01/2019 - 09/07/2019

Hello everyone, Below are some buildbot numbers for the week of 09/01/2019 - 09/07/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed to

r372939 - [clang-format] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919

Author: maskray Date: Wed Sep 25 19:02:17 2019 New Revision: 372939 URL: http://llvm.org/viewvc/llvm-project?rev=372939&view=rev Log: [clang-format] Add SortPriority fields to fix -Wmissing-field-initializers after D64695/r372919 Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unitte

Re: r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Hi, this change breaks the build with /var/lib/buildbot/sanitizer-buildbot6/sanitizer-x86_64-linux-android/build/llvm-project/clang/lib/Format/Format.cpp:737:44: error: missing field 'SortPriority' initializer [-Werror,-Wmissing-field-initializers] {"^\"(llvm|llvm-c|clang|clang-c)/", 2}, h

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

Anastasia marked 2 inline comments as done. Anastasia added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:6721 + if (getLangOpts().OpenCL) { + rjmccall wrote: > Since you're moving this code anyway, can this be split into its own > function? I'm n

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rL372936: [libTooling] Add `run` combinator to Stencils. (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

r372936 - [libTooling] Add `run` combinator to Stencils.

Author: ymandel Date: Wed Sep 25 17:53:56 2019 New Revision: 372936 URL: http://llvm.org/viewvc/llvm-project?rev=372936&view=rev Log: [libTooling] Add `run` combinator to Stencils. Summary: This revision adds `run`, a StencilPart that runs a user-defined function that computes a result over `Matc

[PATCH] D67865: [clang-tidy] Finds uses of OSRead* calls on macOS that may mask unexpected behavior due to unaligned reads

dmaclach added a comment. Any other comments on this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67865/new/ https://reviews.llvm.org/D67865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi marked 4 inline comments as done. plotfi added inline comments. Comment at: clang/test/InterfaceStubs/template-namespace-function.cpp:2 // REQUIRES: x86-registered-target -// RUN: %clang -target x86_64-unknown-linux-gnu -o - -emit-interface-stubs \ -// RUN: -interface-stu

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. In D55326#1342412 , @nemanjai wrote: > A couple of questions since I am not all that familiar with clang and am > certainly not familiar with this unusual SUSE 32-bit situation: > > - We seem to be changing the set of aliases

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 marked 6 inline comments as done. xbolva00 added inline comments. Comment at: test/Sema/warn-conditional-emum-types-mismatch.c:19 + +int get_flag_anon_enum(int cond) { + return cond ? A : C; aaron.ballman wrote: > xbolva00 wrote: > > Gcc warns here, but

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

xbolva00 updated this revision to Diff 221860. xbolva00 added a comment. addressed review notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67919/new/ https://reviews.llvm.org/D67919 Files: lib/Sema/SemaChecking.cpp test/Sema/warn-conditional-emum-types-mismatch.c Index: test/S

[PATCH] D65130: [clang][OpenMP] Add clang-offload-wrapper tool

sdmitriev abandoned this revision. sdmitriev added a comment. This patch is no longer relevant since it was agreed to split https://reviews.llvm.org/D64943 into pieces in a different way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65130/new/ https://reviews.llvm.org/D65130 __

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

hfinkel added a comment. In D64943#1683368 , @JonChesterfield wrote: > The three way split looks great, thanks. Makes sense to me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___

r372926 - Simplify -fms-compatibility include lookup logic, NFC

Author: rnk Date: Wed Sep 25 15:50:50 2019 New Revision: 372926 URL: http://llvm.org/viewvc/llvm-project?rev=372926&view=rev Log: Simplify -fms-compatibility include lookup logic, NFC This include search logic has an extra parameter to deal with Windows includes with backslashes, which get normal

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. The three way split looks great, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi updated this revision to Diff 221851. plotfi marked 6 inline comments as done. plotfi added a comment. addressing cindy and saleem's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63978/new/ https://reviews.llvm.org/D63978 Files:

[PATCH] D63978: Clang Interface Stubs merger plumbing for Driver

plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3372 + if (Phase == phases::IfsMerge) { +assert(Phase == PL.back() && "merging must be final compilation step."); +MergerInputs.push_back(Current); compnerd wrote: > Does

Re: r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

Thank you, sorry for the trouble. vedant > On Sep 25, 2019, at 3:36 PM, Evgenii Stepanov > wrote: > > FYI I've fixed a memory leak in the new test in r372925. > > On Wed, Sep 25, 2019 at 10:58 AM Vedant Kumar via cfe-commits > wrote: >> >> Author: vedantk >> Date: Wed Sep 25 11:00:31 2019 >

Re: r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

FYI I've fixed a memory leak in the new test in r372925. On Wed, Sep 25, 2019 at 10:58 AM Vedant Kumar via cfe-commits wrote: > > Author: vedantk > Date: Wed Sep 25 11:00:31 2019 > New Revision: 372903 > > URL: http://llvm.org/viewvc/llvm-project?rev=372903&view=rev > Log: > [Mangle] Add flag to

r372925 - Fix memory leak in DeclTest.

Author: eugenis Date: Wed Sep 25 15:38:20 2019 New Revision: 372925 URL: http://llvm.org/viewvc/llvm-project?rev=372925&view=rev Log: Fix memory leak in DeclTest. Fixes a leak introduced in r372903, detected on the ASan bot. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/354

[PATCH] D68049: Propeller: Clang options for basic block sections

mehdi_amini added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:52 + ///< Produce unique section names with + ///< basic block sections. ENUM_CODEGENOPT(FramePointer, FramePoin

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

dexonsmith added inline comments. Comment at: clang/lib/Lex/DependencyDirectivesSourceMinimizer.cpp:247-248 -static const char *reverseOverSpaces(const char *First, const char *Last) { +static const char *reverseOverSpacesUntilFirstSpace(const char *First, +

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. The code looks correct. I have some nitpicks about how the functions are named, but you don't need to go with my suggestions specifically. Comment at: clang/lib/Lex

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

rnk created this revision. rnk added reviewers: rjmccall, rsmith, hans. Herald added subscribers: s.egerton, simoncook, fedor.sergeev, aheejin. Herald added a project: clang. I noticed that compiling on Windows with -fno-ms-compatibility had the side effect of defining __GNUC__, along with __EXCEP

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67982/new/ https://reviews.llvm.org/D67982 __

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67983/new/ https://reviews.llvm.org/D67983 __

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

rjmccall added a comment. That looks great. I'm probably not the best person to validate that the OMP / CUDA logic is still right, but it seems like the right technical design. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837

[PATCH] D65744: [PR42707][OpenCL] Fix addr space deduction for auto

rjmccall added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:5998 +QualType Type = Var->getType(); +if (Type->isSamplerT() || Type->isVoidType()) + return; Anastasia wrote: > I don't seem to need a check for dependent or auto types because

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

arphaman created this revision. arphaman added reviewers: dexonsmith, Bigcheese, kousikk, aganea. Herald added subscribers: ributzka, tschuett, jkorous. Herald added a project: clang. Clang allows continuations that have whitespace between the backslash and the newline. This patch ensures that th

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1683146 , @lildmh wrote: > HI Alexey, the ast print test is already there. Because I didn't check the > mapper for array type before, such code will always not report any error, and > ast print test is correct. Codegen

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh marked an inline comment as done. lildmh added a comment. HI Alexey, the ast print test is already there. Because I didn't check the mapper for array type before, such code will always not report any error, and ast print test is correct. Codegen test belongs to the other patch I released.

[PATCH] D67837: [CUDA][HIP] Fix assertion in Sema::markKnownEmitted with -fopenmp

yaxunl updated this revision to Diff 221829. yaxunl edited the summary of this revision. yaxunl added a comment. Unify CUDA/HIP/OpenMP host/device check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: include/clang/Sema/Sema.h lib/Se

[PATCH] D64695: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372919: [clang-format] Modified SortIncludes and IncludeCategories to priority for… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed pr

r372919 - [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category.

Author: paulhoad Date: Wed Sep 25 13:33:01 2019 New Revision: 372919 URL: http://llvm.org/viewvc/llvm-project?rev=372919&view=rev Log: [clang-format] Modified SortIncludes and IncludeCategories to priority for sorting #includes within the Group Category. Summary: This new Style rule is made as a

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram created this revision. tmsriram added a reviewer: rnk. Herald added a project: clang. Options for basic block sections, unique internal linkage function names. This is part of the Propeller framework to do post link code layout optimizations. Please see the RFC here: https://groups.go

[PATCH] D67973: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED

This revision was automatically updated to reflect the committed changes. Closed by commit rL372918: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to c

r372918 - [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED

Author: ymandel Date: Wed Sep 25 13:04:25 2019 New Revision: 372918 URL: http://llvm.org/viewvc/llvm-project?rev=372918&view=rev Log: [libTooling][NFC] Switch StencilTest.cpp to use EXPECT_THAT_EXPECTED Summary: Currently, some tests use homegrown matchers to handle `llvm::Expected` values. This

r372917 - [OPENMP50]Parsing/sema support for 'implementation/vendor' context

Author: abataev Date: Wed Sep 25 12:43:37 2019 New Revision: 372917 URL: http://llvm.org/viewvc/llvm-project?rev=372917&view=rev Log: [OPENMP50]Parsing/sema support for 'implementation/vendor' context selector. Added basic parsing/semantic support for 'implementation={vendor()}' context selector.

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

ymandel marked 4 inline comments as done. ymandel added a comment. Thanks for the review! Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181 +/// This supports user-defined extensions to the Stencil language. +StencilPart run(MatchConsumer C); +

RE: r370123 - [preprocessor] Add an opportunity to retain excluded conditional blocks

-Original Message- From: cfe-commits On Behalf Of Evgeny Mankov via cfe-commits Sent: Tuesday, August 27, 2019 3:16 PM To: cfe-commits@lists.llvm.org Subject: [EXT] r370123 - [preprocessor] Add an opportunity to retain excluded conditional blocks Added: cfe/trunk/test/Index/retain-exclu

[PATCH] D66437: Sema: Create a no-op implicit cast for lvalue function conversions.

pcc added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66437/new/ https://reviews.llvm.org/D66437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

Re: r369999 - Don't lose the FoundDecl and template arguments for a DeclRefExpr in

Hi Richard, it looks like this commit caused an assertion failure on the following input: $ cat test2.ii # 2 "" 3 namespace a { enum { b }; } template void c() { auto d = [](auto) { using a::b; b; }; d(0); } void e() { c; } $ clang test2.ii clang: ../clang/lib/Sema/SemaTemplateInsta

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

This revision was automatically updated to reflect the committed changes. Closed by commit rL372903: [Mangle] Add flag to asm labels to disable '\01' prefixing (authored by vedantk, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

r372903 - [Mangle] Add flag to asm labels to disable '\01' prefixing

Author: vedantk Date: Wed Sep 25 11:00:31 2019 New Revision: 372903 URL: http://llvm.org/viewvc/llvm-project?rev=372903&view=rev Log: [Mangle] Add flag to asm labels to disable '\01' prefixing LLDB synthesizes decls using asm labels. These decls cannot have a mangle different than the one specifi

[PATCH] D67031: [Clang][Bundler] Error reporting improvements

sdmitriev added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67031/new/ https://reviews.llvm.org/D67031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 ___ cfe-commits mailing list

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

vsk updated this revision to Diff 221801. vsk added a comment. - Add a comment describing where non-literal labels are used. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67774/new/ https://reviews.llvm.org/D67774 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/A

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

This revision was automatically updated to reflect the committed changes. Closed by commit rG24337db61666: [CUDA][HIP] Enable kernel function return type deduction. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68031/new/ https:

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

hliao added a comment. In D68031#1682822 , @tra wrote: > Nice. I'd mention in the commit message that NVCC does not support deduced > return type for kernel functions. Just tried with NVCC from CUDA 10, except auto-based deduced type is not supported,

r372898 - [CUDA][HIP] Enable kernel function return type deduction.

Author: hliao Date: Wed Sep 25 09:51:45 2019 New Revision: 372898 URL: http://llvm.org/viewvc/llvm-project?rev=372898&view=rev Log: [CUDA][HIP] Enable kernel function return type deduction. Summary: - Even though only `void` is still accepted as the deduced return type, enabling deduction/insta

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Nice. I'd mention in the commit message that NVCC does not support deduced return type for kernel functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D67919: [Diagnostics] Warn if enumeration type mismatch in conditional expression

aaron.ballman added inline comments. Comment at: lib/Sema/SemaChecking.cpp:11264 + + const EnumType *LHSEnumType = LHSStrippedType->getAs(); + if (!LHSEnumType) `const auto *` (and below as well) since the type is spelled out in the initialization. =

[PATCH] D67901: [clangd] Improve semantic highlighting in dependent contexts (fixes #154)

nridge marked 2 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:181 + addToken(E->getMemberLoc(), E->getQualifier() + ? HighlightingKind::StaticField +

[PATCH] D63640: [clang] Improve Serialization/Imporing/Dumping of APValues

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/APValue.h:613 + /// in place as after importing/deserializating then. + void reserveVector(unsigned N) { +assert(isVector() && "Invalid accessor"); `ReserveVector` C

Re: r372863 - [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Reverted and re-landed with a fix to this. This should've been an NFC, but I missed one corner case. Sorry about that. On Wed, Sep 25, 2019 at 4:22 PM Nico Weber wrote: > Is it possible that this broke Tooling/clang-diff-ast.cpp > http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/b

r372889 - Re-land r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Author: ibiryukov Date: Wed Sep 25 08:46:04 2019 New Revision: 372889 URL: http://llvm.org/viewvc/llvm-project?rev=372889&view=rev Log: Re-land r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName Reverted in r372880 due to the test failure. Also contains a

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

This revision was automatically updated to reflect the committed changes. Closed by commit rL372888: [clangd] Change constness of parameters to findExplicitRefs (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[clang-tools-extra] r372888 - [clangd] Change constness of parameters to findExplicitRefs

Author: kadircet Date: Wed Sep 25 08:44:26 2019 New Revision: 372888 URL: http://llvm.org/viewvc/llvm-project?rev=372888&view=rev Log: [clangd] Change constness of parameters to findExplicitRefs Summary: Recursive AST requires non-const ast nodes, but it doesn't really mutate them. In addition to

[PATCH] D68031: [CUDA][HIP] Enable kernel function return type deduction.

hliao created this revision. hliao added reviewers: tra, jlebar. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Even though only `void` is still accepted as the deduced return type, enabling deduction/instantiation on the return type allows more consistent coding. Rep

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. @kadircet says we're using this pattern all over clangd. This somehow slipped my view before. LGTM to be consistent with the rest of clangd (and functions in `FindTarget.h`). I t

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Thank you for working on this! It looks like you're missing all of the sema tests that check that the attribute only appertains to functions, accepts the proper kind of arguments, etc. Comment at:

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

ilya-biryukov added a comment. Who are the callers? Selection tree? FWIW, I'd rather pass non-const everywhere, the concept of const-ness is just not very useful for AST nodes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68027/new/ https://revie

[PATCH] D68030: [CUDA][HIP] Initial kernel return type relaxing.

hliao created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao abandoned this revision. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68030 Files: clang/lib/Sema/SemaDeclAttr.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaStm

[PATCH] D68029: [ThinLTO] Enable index-only WPD from clang

tejohnson created this revision. tejohnson added a reviewer: pcc. Herald added subscribers: arphaman, dexonsmith, steven_wu, inglorion, mehdi_amini. Herald added a project: clang. To trigger the index-only Whole Program Devirt support added to LLVM, we need to be able to specify -fno-split-lto-un

r372884 - [NFC] Fix typo in `getPreviousDecl` comment.

Author: ymandel Date: Wed Sep 25 07:58:39 2019 New Revision: 372884 URL: http://llvm.org/viewvc/llvm-project?rev=372884&view=rev Log: [NFC] Fix typo in `getPreviousDecl` comment. Modified: cfe/trunk/include/clang/AST/DeclBase.h Modified: cfe/trunk/include/clang/AST/DeclBase.h URL: http://ll

[PATCH] D67748: [clangd] Add a helper for extracting nonlocal decls in a FunctionDecl

kadircet updated this revision to Diff 221772. kadircet added a comment. - Use Decl overload of findExplicitReferences Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67748/new/ https://reviews.llvm.org/D67748 Files: clang-tools-extra/clangd/XRefs

r372880 - Revert r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Author: ibiryukov Date: Wed Sep 25 07:50:12 2019 New Revision: 372880 URL: http://llvm.org/viewvc/llvm-project?rev=372880&view=rev Log: Revert r372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName Reason: causes a test failure, will investigate and re-land wi

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

gchatelet added a comment. In D61634#1679331 , @tejohnson wrote: > In D61634#1635595 , @tejohnson wrote: > > > I had some time to work on this finally late last week. I decided the most > > straightforward thing wa

[PATCH] D67969: [libTooling] Add `run` combinator to Stencils.

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:181 +/// This supports user-defined extensions to the Stencil language. +StencilPart run(MatchConsumer

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. Definitely need positive tests with ast printing and codegen. Comment at: lib/Sema/SemaOpenMP.cpp:14751 +assert(Type->getAsArrayTypeUnsafe() && "Expect to get a valid array type"); +Type = Type->getAsArrayTypeUnsafe()->getElementType().getCanoni

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet created this revision. gchatelet added reviewers: tejohnson, courbet, theraven, t.p.northover, jdoerfert. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. This is a follow up on https://reviews.llvm.org/D61634 This patch is simpler and only adds the no_built

[PATCH] D68027: [clangd] Change constness of parameters to findExplicitRefs

kadircet created this revision. kadircet added a reviewer: ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Recursive AST requires non-const ast nodes, but it doesn't really mutate them. In addition to that, in clangd we mo

[PATCH] D68026: [clangd] Add missing header guard, NFC.

hokein updated this revision to Diff 221765. hokein added a comment. upload correct diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68026/new/ https://reviews.llvm.org/D68026 Files: clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.cpp cl

[PATCH] D68024: [clangd] Implement GetEligibleRegions

kadircet created this revision. kadircet added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. This is an helper for incoming move definition out-of-line action to figure out possible insertion locations

[PATCH] D68026: [clangd] Add missing header guard, NFC.

hokein created this revision. hokein added a reviewer: gribozavr. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. [clang-tidy] Make llvm-header-guard work on llvm git monorepo. Repository: rG LLVM Github Monorepo https:

Re: r372863 - [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Is it possible that this broke Tooling/clang-diff-ast.cpp http://lab.llvm.org:8011/builders/clang-cmake-x86_64-avx2-linux/builds/11395/steps/ninja%20check%201/logs/FAIL%3A%20Clang%3A%3Aclang-diff-ast.cpp ? On Wed, Sep 25, 2019 at 9:07 AM Ilya Biryukov via cfe-commits < cfe-commits@lists.llvm.org>

[PATCH] D68023: [AArch64][SVE] Implement int_aarch64_sve_cnt intrinsic

kmclaughlin created this revision. kmclaughlin added reviewers: c-rhodes, sdesmalen, rovka. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a project: LLVM. kmclaughlin added a parent revision: D68021: [IntrinsicEmitter] Add overloaded type VecOfBitcasts

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

This revision was automatically updated to reflect the committed changes. Closed by commit rL372875: [clangd] Fix parseNamespaceEvents to parse the last token (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: h

[clang-tools-extra] r372875 - [clangd] Fix parseNamespaceEvents to parse the last token

Author: kadircet Date: Wed Sep 25 07:12:05 2019 New Revision: 372875 URL: http://llvm.org/viewvc/llvm-project?rev=372875&view=rev Log: [clangd] Fix parseNamespaceEvents to parse the last token Reviewers: hokein, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags:

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

kadircet updated this revision to Diff 221759. kadircet added a comment. - Add empty string testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68020/new/ https://reviews.llvm.org/D68020 Files: clang-tools-extra/clangd/SourceCode.cpp clang-

[PATCH] D68021: [IntrinsicEmitter] Add overloaded type VecOfBitcastsToInt for SVE intrinsics

kmclaughlin created this revision. kmclaughlin added reviewers: c-rhodes, sdesmalen, rovka. Herald added subscribers: jdoerfert, hiraditya, tschuett. Herald added a project: LLVM. This allows intrinsics such as the following to be defined: - declare @llvm.something.nxv4f32(, , ) ...where is de

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:429 +// Parse until EOF +namespace bar{})cpp", + {""}, ---

[PATCH] D63082: [Diagnostics] Added support for -Wint-in-bool-context

xbolva00 added a comment. Happy to hear :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63082/new/ https://reviews.llvm.org/D63082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D68020: [clangd] Fix parseNamespaceEvents to parse the last token

kadircet created this revision. kadircet added reviewers: hokein, ilya-biryukov. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68020 Files: clang-tools-extra/clangd/So

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

ABataev added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3125 +ActionList DeviceAL; +for (auto *SB : SpecializedBuilders) { + if (!SB->isValid()) User real type instead of `auto *` Comment at: clang/lib/Driver/Driver.

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

JonChesterfield added a comment. In D64943#1682452 , @hfinkel wrote: > This LGTM. I'm happy that this is a design improvement over the current > scheme. @JonChesterfield , @ABataev , any further comments? This patch mixes two concerns. 1/ Remove the li

[PATCH] D67961: [libTooling] Introduce the MatchConsumer abstraction

This revision was automatically updated to reflect the committed changes. Closed by commit rL372870: [libTooling] Introduce the MatchConsumer abstraction (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https:/

r372870 - [libTooling] Introduce the MatchConsumer abstraction

Author: ymandel Date: Wed Sep 25 06:34:04 2019 New Revision: 372870 URL: http://llvm.org/viewvc/llvm-project?rev=372870&view=rev Log: [libTooling] Introduce the MatchConsumer abstraction Summary: This revision introduces a separate (small) library for the `MatchConsumer` abstraction: computations

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

hfinkel added a comment. This LGTM. I'm happy that this is a design improvement over the current scheme. @JonChesterfield , @ABataev , any further comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 _

[PATCH] D67825: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

This revision was automatically updated to reflect the committed changes. Closed by commit rL372863: [AST] Extract Decl::printNestedNameSpecifier helper from Decl… (authored by ibiryukov, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commi

r372863 - [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName

Author: ibiryukov Date: Wed Sep 25 06:09:10 2019 New Revision: 372863 URL: http://llvm.org/viewvc/llvm-project?rev=372863&view=rev Log: [AST] Extract Decl::printNestedNameSpecifier helper from Decl::printQualifiedName Summary: To be used in clangd, e.g. in D66647. Currently the alternative to th

  1   2   >