[PATCH] D68120: [clangd] Handle type template parameters in findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68120 Files: clang-tools-extra/clangd/FindTarget.cpp

[PATCH] D68119: [clangd] Handle OverloadExpr in targetDecl

ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68119 Files: clang-tools-extra/clangd/FindTa

[PATCH] D68118: [clangd] Support OverloadExpr in findExplicitReferences

ilya-biryukov created this revision. ilya-biryukov added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68118 Files: clang-tools-extra/clangd/FindTarget.cpp

[libclc] r373046 - travis: Switch to Ubuntu 16.04 (xenial)

Author: jvesely Date: Thu Sep 26 22:57:38 2019 New Revision: 373046 URL: http://llvm.org/viewvc/llvm-project?rev=373046&view=rev Log: travis: Switch to Ubuntu 16.04 (xenial) Use native packages up to llvm-6. Reviewer: tstellar Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml M

[libclc] r373047 - travis: Add LLVM 9 build

Author: jvesely Date: Thu Sep 26 22:58:15 2019 New Revision: 373047 URL: http://llvm.org/viewvc/llvm-project?rev=373047&view=rev Log: travis: Add LLVM 9 build Reviewer: tstellar Signed-off-by: Jan Vesely Modified: libclc/trunk/.travis.yml Modified: libclc/trunk/.travis.yml URL: http://llv

r373043 - [test] Use %clang_cc1 instead of %clang -cc1

Author: maskray Date: Thu Sep 26 22:37:06 2019 New Revision: 373043 URL: http://llvm.org/viewvc/llvm-project?rev=373043&view=rev Log: [test] Use %clang_cc1 instead of %clang -cc1 Modified: cfe/trunk/test/CodeGen/align-global-large.c cfe/trunk/test/CodeGenObjC/protocol-comdat.m cfe/tru

r373042 - Fix use-after-free found in Clang's testsuite.

Author: rsmith Date: Thu Sep 26 22:36:16 2019 New Revision: 373042 URL: http://llvm.org/viewvc/llvm-project?rev=373042&view=rev Log: Fix use-after-free found in Clang's testsuite. We need to discard all remaining cleanups if an earlier cleanup failed, otherwise we may try to rerun the remaining c

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX updated this revision to Diff 222079. SouraVX added a comment. Minor refactor. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/dbg-info-all-calls-described.cpp llvm/inc

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX created this revision. SouraVX added reviewers: aprantl, dblaikie, probinson. SouraVX added projects: LLVM, clang, debug-info. Herald added a subscriber: hiraditya. This patch provides DWARF5 support for C++11 defaulted, deleted member. Added support in clang C++ frontend, llvm, and llvm-

[PATCH] D68072: Reference qualifiers in member templates causing extra indentation.

AndWass added a comment. @klimek I don't have commit access yet, could you please commit it for me? Thanks Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68072/new/ https://reviews.llvm.org/D68072 ___ c

[PATCH] D66834: Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT`

sepavloff added a comment. In D66834#1653334 , @broadwaylamb wrote: > In D66834#1652756 , @compnerd wrote: > > > I think that this is pretty easy to forget. Fortunately, last argument > > wins. Why not sink this

[PATCH] D68115: Zero initialize padding in unions

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/init.c:197 // CHECK-LABEL: @nonzeroPaddedUnionMemset( - // CHECK-NOT: store - // CHECK-NOT: memcpy - // CHECK: call void @llvm.memset.p0i8.i32(i8* {{.*}}, i8 -16, i32 36, i1 false) + // CHECK: ca

[PATCH] D68049: Propeller: Clang options for basic block sections

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:631 +if (A->getOption().matches(options::OPT_fpropeller_optimize_EQ)) { + if (!Args.getLastArgValue(options::OPT_fuse_ld_EQ).equals_lower("lld")) +D.Diag(clang::diag::err_drv_unsupport

[PATCH] D68115: Zero initialize padding in unions

vitalybuka updated this revision to Diff 222071. vitalybuka added a comment. remove unused var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68115/new/ https://reviews.llvm.org/D68115 Files: clang/lib/CodeGen/CGExprConstant.cpp clang/test/Code

[PATCH] D68115: Zero initialize padding in unions

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGenCXX/designated-init.cpp:68 }; -// CHECK: @overwrite_padding = global { { i8, i8 } } { { i8, i8 } { i8 3, i8 1 } } +// CHECK-LE: @overwrite_padding = global { { i8, i8 }

[PATCH] D68115: Zero initialize padding in unions

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/test/CodeGenCXX/designated-init.cpp:68 }; -// CHECK: @overwrite_padding = global { { i8, i8 } } { { i8, i8 } { i8 3, i8 1 } } +// CHECK-LE: @overwrite_padding = global { { i8, i8 }

r373039 - Revert r373034

Author: comex Date: Thu Sep 26 18:58:31 2019 New Revision: 373039 URL: http://llvm.org/viewvc/llvm-project?rev=373039&view=rev Log: Revert r373034 It breaks the build on MSVC. Modified: cfe/trunk/include/clang/AST/Stmt.h cfe/trunk/lib/Analysis/Consumed.cpp Modified: cfe/trunk/include/c

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

Meinersbur added inline comments. Comment at: polly/lib/Support/RegisterPasses.cpp:726 + +#ifndef LLVM_POLLY_LINK_INTO_TOOLS +extern "C" LLVM_ATTRIBUTE_WEAK ::llvm::PassPluginLibraryInfo Meinersbur wrote: > [serious] `LLVM_POLLY_LINK_INTO_TOOLS` is a cmake config

[PATCH] D68115: Zero initialize padding in unions

vitalybuka created this revision. vitalybuka added reviewers: rsmith, jfb. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. vitalybuka edited the summary of this revision. vitalybuka edited the summary of this revision. Existing implementation puts undef into paddi

r373037 - For P0784R7: add support for new (std::nothrow).

Author: rsmith Date: Thu Sep 26 18:26:49 2019 New Revision: 373037 URL: http://llvm.org/viewvc/llvm-project?rev=373037&view=rev Log: For P0784R7: add support for new (std::nothrow). Modified: cfe/trunk/include/clang/AST/Type.h cfe/trunk/lib/AST/Decl.cpp cfe/trunk/lib/AST/ExprConstant.

r373036 - For P0784R7: Add support for dynamic allocation with new / delete during

Author: rsmith Date: Thu Sep 26 18:26:47 2019 New Revision: 373036 URL: http://llvm.org/viewvc/llvm-project?rev=373036&view=rev Log: For P0784R7: Add support for dynamic allocation with new / delete during constant evaluation. Added: cfe/trunk/test/CodeGenCXX/const-init-cxx2a.cpp Modified:

[PATCH] D67833: [OpenMP 5.0] Codegen support to pass user-defined mapper functions to runtime

lildmh updated this revision to Diff 222066. lildmh added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67833/new/ https://reviews.llvm.org/D67833 Files: include/clang/AST/OpenMPClause.h lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h lib/CodeGen

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

dblaikie accepted this revision. dblaikie added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaDeclAttr.cpp:1249 + Diag(A->getLoc(), diag::warn_consumable_attr_for_unconsumable_type) << +A << (isa(D) ? 0 : 1) << Type; + return fal

[PATCH] D67740: [Consumed] Refactor and improve diagnostics

comex added a comment. Ping... Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67740/new/ https://reviews.llvm.org/D67740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

akhuang created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Avoid parsing __pragma into an annotation token when macro arguments are pre-expanded. This is what clang currently does when parsing _Pragmas. Fixes https://bugs.llvm.org/show_bug.cgi?id=41128,

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl updated this revision to Diff 222056. aprantl added a comment. Remove `#if 0` from test I used during debugging. (It still passes!) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68108/new/ https://reviews.llvm.org/D68108 Files: clang/include/clang/AST/DeclObjC.h clang/inclu

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1685036 , @gribozavr wrote: > Sorry, I reverted it in r373032 because the test fails on Linux: > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18323 . > Could you please take a look? Thanks! What's

[PATCH] D66121: Debug Info: Nest Objective-C property function decls inside their container.

aprantl updated this revision to Diff 222048. aprantl added a comment. Factored out the general AST changes into https://reviews.llvm.org/D68108. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66121/new/ https://reviews.llvm.org/D66121 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/

[PATCH] D68108: Redeclare Objective-C property accessors inside the ObjCImplDecl in which they are synthesized.

aprantl created this revision. aprantl added reviewers: rjmccall, dergachev.a, dcoughlin, theraven, ahatanak, erik.pilkington, davide. Herald added subscribers: arphaman, dexonsmith. Herald added a project: clang. aprantl added a child revision: D66121: Debug Info: Nest Objective-C property funct

r373034 - [Consumed][NFC] Refactor handleCall to take function argument list.

Author: comex Date: Thu Sep 26 16:47:18 2019 New Revision: 373034 URL: http://llvm.org/viewvc/llvm-project?rev=373034&view=rev Log: [Consumed][NFC] Refactor handleCall to take function argument list. Differential Revision: https://reviews.llvm.org/D67569 Modified: cfe/trunk/include/clang/AS

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

thakis added a comment. I had a fix, but I was too slow. Here's what you need for the reland: http://codepad.org/3klmw1JV The commit also broke sphinx with this: ` 6.290 [0/1/1] Generating html Sphinx documentation for clang-tools into "/home/buildbot/llvm-build-dir/clang-tools-sphinx-docs

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

gribozavr added a comment. Sorry, I reverted it in r373032 because the test fails on Linux: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18323 . Could you please take a look? Thanks! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ h

[clang-tools-extra] r373032 - Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage"

Author: gribozavr Date: Thu Sep 26 16:28:31 2019 New Revision: 373032 URL: http://llvm.org/viewvc/llvm-project?rev=373032&view=rev Log: Revert "[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage" This reverts commit r373028, because the new test fails o

[clang-tools-extra] r373028 - [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

Author: stephanemoore Date: Thu Sep 26 16:04:59 2019 New Revision: 373028 URL: http://llvm.org/viewvc/llvm-project?rev=373028&view=rev Log: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage Summary: Creates a new darwin ClangTidy module and adds the d

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

This revision was automatically updated to reflect the committed changes. Closed by commit rL373028: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non… (authored by stephanemoore, committed by ). Herald added subscribers: llvm-commits, ilya-biryukov. Herald added a pro

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

stephanemoore added a comment. It looks like everything is in order. I will proceed with landing the patch on your behalf 👍 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 ___ cfe-commits mailing li

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

This revision was automatically updated to reflect the committed changes. Closed by commit rL373023: [OpenMP 5.0] Fix user-defined mapper lookup in sema (authored by Meinersbur, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https

r373023 - [OpenMP 5.0] Fix user-defined mapper lookup in sema

Author: meinersbur Date: Thu Sep 26 15:53:01 2019 New Revision: 373023 URL: http://llvm.org/viewvc/llvm-project?rev=373023&view=rev Log: [OpenMP 5.0] Fix user-defined mapper lookup in sema This patches fixes the case when a user-defined mapper is attached to the elements of an array, and to repor

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman updated this revision to Diff 222036. mwyman marked 4 inline comments as done. mwyman added a comment. Addressed Stephane's review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 Files: clang-tools-extra/clang-tidy/CMakeLists.

Re: r369999 - Don't lose the FoundDecl and template arguments for a DeclRefExpr in

On Wed, 25 Sep 2019 at 11:48, Peter Collingbourne via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Richard, it looks like this commit caused an assertion failure on the > following input: > > $ cat test2.ii > # 2 "" 3 > namespace a { > enum { b }; > } > template void c() { > auto d = [

[PATCH] D67414: [AST] Treat "inline gnu_inline" the same way as "extern inline gnu_inline" in C++ mode

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks good to me, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67414/new/ https://reviews.llvm.org/D67414 ___ cfe-commits maili

r373022 - Always rebuild a DeclRefExpr if its FoundDecl would change.

Author: rsmith Date: Thu Sep 26 15:28:32 2019 New Revision: 373022 URL: http://llvm.org/viewvc/llvm-project?rev=373022&view=rev Log: Always rebuild a DeclRefExpr if its FoundDecl would change. Fixes a regression introduced by r36. Added: cfe/trunk/test/SemaTemplate/using-decl.cpp Modifie

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram marked 13 inline comments as done. tmsriram added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:341 +CODEGENOPT(RelocateWithSymbols, 1, 0) + /// Whether we should use the undefined behaviour optimization for control flow mehd

[PATCH] D68049: Propeller: Clang options for basic block sections

tmsriram updated this revision to Diff 222035. tmsriram added a comment. Updated patch to address the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68049/new/ https://reviews.llvm.org/D68049 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/Basic/Cod

[PATCH] D65543: [Windows] Autolink with basenames and add libdir to libpath

rnk added a comment. I happened to notice that I felt the same way about this in 2014 that I do today: https://reviews.llvm.org/D4428#56536 That makes me feel like I should keep pushing for this change, even though so far people don't seem enthusiastic about it. :) I changed the driver to add t

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

stephanemoore added a comment. > Does the check allow variables in anonymous namespaces? > > namespace { > dispatch_once_t onceToken; > } > > > I //think// such variables should satisfy initialization requirements. > > If not, can we update the check to not trigger on variables? Either w

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/iterator_range.h:27-33 +template +constexpr bool is_random_iterator() { + return std::is_same< +typename std::iterator_traits::iterator_category, +std::random_access_iterator_tag>::value; +} + ---

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

stephanemoore added a comment. Looks good! A couple nits/questions. Does the check allow variables in anonymous namespaces? namespace { dispatch_once_t onceToken; } I //think// such variables should satisfy initialization requirements. If not, can we update the check to not trigger on va

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex marked 2 inline comments as done. comex added inline comments. Comment at: llvm/include/llvm/ADT/iterator_range.h:27-33 +template +constexpr bool is_random_iterator() { + return std::is_same< +typename std::iterator_traits::iterator_category, +std::random_access_i

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:63 +* As per C++ and C Standards (C++: ``[expr.add]``; C17: 6.5.6p8), applying + non-zero offset to ``nullptr`` (or making non-``nullptr`` a ``nullptr``, aaron.ballman wrote: > rsmith wrote:

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added a comment. In D67978#1684845 , @lildmh wrote: > Thanks Alexey! Please check the other 2 mapper patches at > https://reviews.llvm.org/D67833 and https://reviews.llvm.org/D68100 when you > have time. They should be the last mapper patches.

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh added a comment. Thanks Alexey! Please check the other 2 mapper patches at https://reviews.llvm.org/D67833 and https://reviews.llvm.org/D68100 when you have time. They should be the last mapper patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.ll

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString()

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, d

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, diag::err_omp_mapper_wrong_type); ---

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, d

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman updated this revision to Diff 222016. mwyman added a comment. Rebased patch to apply to current master. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67567/new/ https://reviews.llvm.org/D67567 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/Cl

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1684785 , @gribozavr wrote: > Sorry, could you rebase the patch to apply cleanly to master? Seems like > someone else edited ReleaseNotes.rst in the meanwhile. > > $ arc patch D67567 > ... > Checking patch clang-too

r373010 - [OPENMP50]Emit warnings if the functions was defined/used before marked

Author: abataev Date: Thu Sep 26 13:04:15 2019 New Revision: 373010 URL: http://llvm.org/viewvc/llvm-project?rev=373010&view=rev Log: [OPENMP50]Emit warnings if the functions was defined/used before marked declare variant. We can use the original function if it was used/emitted already. So, just

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:63 +* As per C++ and C Standards (C++: ``[expr.add]``; C17: 6.5.6p8), applying + non-zero offset to ``nullptr`` (or making non-``nullptr`` a ``nullptr``, rsmith wrote: > In C, even ad

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

gribozavr added a comment. Sorry, could you rebase the patch to apply cleanly to master? Seems like someone else edited ReleaseNotes.rst in the meanwhile. $ arc patch D67567 ... Checking patch clang-tools-extra/docs/ReleaseNotes.rst... error: while searching for: Finds instances wher

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

lebedev.ri marked 2 inline comments as done. lebedev.ri added a comment. Comment at: clang/docs/ReleaseNotes.rst:238 -- ... +- * ``pointer-overflow`` check was extended added to catch the cases where +a non-zero offset being applied, either to a ``nullptr``, or the resul

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, diag::err_omp_mapper_wrong_type); ---

[PATCH] D68099: [MS ABI]: Fix mangling function arguments for template types to be compatible with MSVC

adamf created this revision. adamf added reviewers: rnk, thakis. adamf added a project: clang. Herald added a subscriber: cfe-commits. MS name mangling supports cache for first 10 distinct function arguments. The error was when non cached template type occurred twice (e.g. 11th and 12th). For such

[PATCH] D67122: [UBSan][clang][compiler-rt] Applying non-zero offset to nullptr is undefined behaviour

rsmith added inline comments. Comment at: clang/docs/ReleaseNotes.rst:63 +* As per C++ and C Standards (C++: ``[expr.add]``; C17: 6.5.6p8), applying + non-zero offset to ``nullptr`` (or making non-``nullptr`` a ``nullptr``, In C, even adding 0 to a null pointe

[PATCH] D68052: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer

This revision was automatically updated to reflect the committed changes. arphaman marked 3 inline comments as done. Closed by commit rG15d5f5dd350e: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in… (authored by arphaman). Changed prior to commit: https://reviews

r373007 - [clang-scan-deps] Allow continuation line backslashes followed by whitespace

Author: arphaman Date: Thu Sep 26 12:28:51 2019 New Revision: 373007 URL: http://llvm.org/viewvc/llvm-project?rev=373007&view=rev Log: [clang-scan-deps] Allow continuation line backslashes followed by whitespace in the dependency source minimizer Clang allows continuations that have whitespace be

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, d

r373005 - Revert "[analyzer] A speculative attempt to avoid gcc-7 crashes..."

Author: dergachev Date: Thu Sep 26 11:52:00 2019 New Revision: 373005 URL: http://llvm.org/viewvc/llvm-project?rev=373005&view=rev Log: Revert "[analyzer] A speculative attempt to avoid gcc-7 crashes..." This reverts commit r372940 which was an overreaction to a flaky buildbot. Modified: cfe

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, diag::err_omp_mapper_wrong_type); ---

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh marked an inline comment as done. lildmh added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, d

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

ABataev added inline comments. Comment at: lib/Sema/SemaOpenMP.cpp:14805 + if (!Type->isStructureOrClassType() && !Type->isUnionType() && + (MapperIdScopeSpec.isSet() || MapperId.getAsString() != "default")) { +SemaRef.Diag(Loc, diag::err_omp_mapper_wrong_type); ---

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh updated this revision to Diff 221991. lildmh added a comment. Fix mapper type checking CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67978/new/ https://reviews.llvm.org/D67978 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/declare_mapper_messages.c test/OpenMP/declare_mapper_m

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema

lildmh updated this revision to Diff 221990. lildmh retitled this revision from "[OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays" to "[OpenMP 5.0] Fix user-defined mapper lookup in sema". lildmh edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.o

r373004 - Only pass -coverage-notes-file when emitting coverage

Author: rnk Date: Thu Sep 26 11:13:19 2019 New Revision: 373004 URL: http://llvm.org/viewvc/llvm-project?rev=373004&view=rev Log: Only pass -coverage-notes-file when emitting coverage The only functional change here is that -coverage-notes-file is not passed to -cc1 in some situations. This code

r372999 - Move normalization of `\` in #includes from -fms-compatibility to -fms-extensions

Author: rnk Date: Thu Sep 26 10:19:22 2019 New Revision: 372999 URL: http://llvm.org/viewvc/llvm-project?rev=372999&view=rev Log: Move normalization of `\` in #includes from -fms-compatibility to -fms-extensions Handling backslashes in include paths in the implementation isn't non-conforming. M

[PATCH] D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage

mwyman added a comment. In D67567#1683905 , @gribozavr wrote: > Thanks! Do you need me to commit the patch for you? Yes, thank you. I don't have commit access—and also wasn't sure if anyone else had further comment. CHANGES SINCE LAST ACTION https:/

[PATCH] D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper

leonardchan added a comment. *ping* @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ https://reviews.llvm.org/D67992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D57829: [HIP] Disable emitting llvm.linker.options in device compilation

yaxunl abandoned this revision. yaxunl marked an inline comment as done. yaxunl added a comment. no longer needed CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 ___ cfe-commits mailing list cfe-comm

Re: r371027 - Revert r361885 "[Driver] Fix -working-directory issues"

Hi, As Karl-Johan said I'll be out of office for a few days so please submit a fix if you can find the time. Thanks, Mikael Den 26 sep. 2019 15:39 skrev Hans Wennborg : On Thu, Sep 26, 2019 at 12:55 PM Mikael Holmén via cfe-commits wrote: > > Hi Hans, > > I'm a bit suspicious against the part

r372994 - Un-XFAIL coverage_no_integrated_as.c test on Windows

Author: rnk Date: Thu Sep 26 09:56:25 2019 New Revision: 372994 URL: http://llvm.org/viewvc/llvm-project?rev=372994&view=rev Log: Un-XFAIL coverage_no_integrated_as.c test on Windows You can't use -fno-integrated-as for *-msvc triples because no usable standalone assembler exists. Perhaps we coul

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp:60 + template const T *getParent(const Expr *E) { +auto Parents = Ctxt.getParents(*E); +if (Parents.size() != 1) Return type is

[PATCH] D64943: [Clang][OpenMP offload] Eliminate use of OpenMP linker script

sdmitriev added a comment. I have uploaded the first part to https://reviews.llvm.org/D68070 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64943/new/ https://reviews.llvm.org/D64943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

uweigand added a comment. This makes sense to me (although we don't currently need the options parameter there). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795 ___ cfe-commits mailing list cfe-comm

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

tellenbach added a comment. This would fix PR37240 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68076/new/ https://reviews.llvm.org/D68076 ___ cfe-commits mailing list c

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

lildmh added a comment. In D67978#1684169 , @ABataev wrote: > In D67978#1684104 , @lildmh wrote: > > > In D67978#1683166 , @ABataev wrote: > > > > > In D67978#1683146

[PATCH] D68076: [AArch64] Enable unwind tables by default for Gnu targets

tellenbach added a comment. Please also see the ongoing discussion on the mailing list: http://lists.llvm.org/pipermail/llvm-dev/2019-September/135433.html Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D67980: [WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields

yonghong-song updated this revision to Diff 221962. yonghong-song retitled this revision from "[WIP][CLANG][BPF] implement clang __builtin_bitfield_info() intrinsic" to "[WIP][CLANG][BPF] do compile-once run-everywhere relocation for bitfields". yonghong-song edited the summary of this revision.

[PATCH] D65433: [clangd] DefineInline action availability checks

kadircet updated this revision to Diff 221947. kadircet added a comment. - Use canonical decl when checking visibility Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65433/new/ https://reviews.llvm.org/D65433 Files: clang-tools-extra/clangd/refac

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

hokein added a comment. In D66647#1684046 , @ilya-biryukov wrote: > We also need to rename parameters sometimes, right? > > // Sometimes we need to rename parameters. > void usages(int decl_param, int); > > void usages(int def_param, int now_named

[PATCH] D67978: [OpenMP 5.0] Fix user-defined mapper lookup in sema for arrays

ABataev added a comment. In D67978#1684104 , @lildmh wrote: > In D67978#1683166 , @ABataev wrote: > > > In D67978#1683146 , @lildmh wrote: > > > > > HI Alexey, the ast print

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

xbolva00 added a comment. This is great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://reviews.llvm.org/D68055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 221939. gchatelet added a comment. - Checks function name validity and errors when passed 0 argument. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68028/new/ https://reviews.llvm.org/D68028 Files: clang/i

[clang-tools-extra] r372981 - [clangd] Bump vscode-clangd v0.0.18

Author: hokein Date: Thu Sep 26 07:11:23 2019 New Revision: 372981 URL: http://llvm.org/viewvc/llvm-project?rev=372981&view=rev Log: [clangd] Bump vscode-clangd v0.0.18 CHANGELOG: - enable semantic highlighting by default - upgrade the LSP dependencies to pickup the incoming LSP v3.15.0 Modified

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

This revision was automatically updated to reflect the committed changes. Closed by commit rL372980: [clangd][vscode] Add npm helper commands to package/release the extension. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[clang-tools-extra] r372980 - [clangd][vscode] Add npm helper commands to package/release the extension.

Author: hokein Date: Thu Sep 26 07:04:52 2019 New Revision: 372980 URL: http://llvm.org/viewvc/llvm-project?rev=372980&view=rev Log: [clangd][vscode] Add npm helper commands to package/release the extension. Summary: Help to fix https://github.com/clangd/clangd/issues/159. Reviewers: ilya-biryuk

[PATCH] D68080: [clangd][vscode] Add npm helper commands to package/release the extension.

hokein marked an inline comment as done. hokein added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/package.json:38 +"package": "vsce package --baseImagesUrl https://raw.githubusercontent.com/llvm/llvm-project/master/clang-tools-extra/clangd

[PATCH] D68074: [clang-tidy] Add readability-make-member-function-const

Eugene.Zelenko added a comment. See also PR21981 and D45444 . Comment at: clang-tools-extra/clang-tidy/readability/MakeMemberFunctionConstCheck.cpp:93 + bool VisitUser(const ImplicitCastExpr *Cast) { + +if (Cast->getCastKind() != CK_NoOp)

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. This looks reasonable to me. Might be worth mentioning in ReleaseNotes too :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68055/new/ https://revi

[PATCH] D68024: [clangd] Implement GetEligiblePoints

ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/SourceCode.cpp:996 + std::vector Enclosing = {""}; + // FIXME: In addition to namespaces try to generate events for function + // definitions as well. One

  1   2   >