[PATCH] D68627: [Sema][X86] Consider target attribute into the checks in validateOutputSize and validateInputSize.

craig.topper created this revision. craig.topper added reviewers: rnk, echristo, erichkeane, RKSimon, spatel. Herald added a project: clang. The validateOutputSize and validateInputSize need to check whether AVX or AVX512 are enabled. But this can be affected by the target attribute so we need to

[PATCH] D68368: [ItaniumMangle] Fix mangling of GNU __null in an expression to match GCC

This revision was automatically updated to reflect the committed changes. Closed by commit rL374013: [ItaniumMangle] Fix mangling of GNU __null in an expression to match GCC (authored by jrtc27, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl

This revision was automatically updated to reflect the committed changes. Closed by commit rL373992: [clang] Accept -ftrivial-auto-var-init in clang-cl (authored by vitalybuka, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68114: Fix for expanding __pragmas in macro arguments

This revision was automatically updated to reflect the committed changes. Closed by commit rL373950: Fix for expanding __pragmas in macro arguments (authored by akhuang, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68412: [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build

This revision was automatically updated to reflect the committed changes. Closed by commit rL373936: [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D68584: Fix Calling Convention through aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL373929: Fix Calling Convention through aliases (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D68584?vs=223617=223750#toc Repository: rL LLVM CHANGES

[PATCH] D68273: [clangd] Fix raciness in code completion tests

This revision was automatically updated to reflect the committed changes. Closed by commit rL373924: [clangd] Fix raciness in code completion tests (authored by kadircet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

This revision was automatically updated to reflect the committed changes. Closed by commit rL373922: [clang-format] [PR27004] omits leading space for noexcept when formatting… (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373921: [clang-format] [NFC] Ensure clang-format is itself clang-formatted. (authored by paulhoad, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D68574: [libTooling] Add `toString` method to the Stencil class

This revision was automatically updated to reflect the committed changes. Closed by commit rL373916: [libTooling] Add `toString` method to the Stencil class (authored by ymandel, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68565: [clang] Add test for FindNextToken in Lexer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGedf5027689c5: [clang] Add test for FindNextToken in Lexer. (authored by usaxena95). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68565/new/

[PATCH] D68564: [clangd] Catch an unchecked "Expected" in HeaderSourceSwitch.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373897: [clangd] Catch an unchecked ExpectedT in HeaderSourceSwitch. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68467: [clangd] If an undocumented definition exists, don't accept documentation from other forward decls.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373892: [clangd] If an undocumented definition exists, dont accept documentation from… (authored by sammccall, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D68458: [clangd] Collect missing macro references.

This revision was automatically updated to reflect the committed changes. Closed by commit rL373889: [clangd] Collect missing macro references. (authored by hokein, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D68578: [HIP] Fix device stub name

t-tye added a comment. In D68578#1697898 , @tra wrote: > In D68578#1697851 , @yaxunl wrote: > > > In D68578#1697822 , @tra wrote: > > > > > Could you elaborate on how

r374011 - [NFC] Fix ubsan-blacklist test

Author: jkorous Date: Mon Oct 7 19:26:17 2019 New Revision: 374011 URL: http://llvm.org/viewvc/llvm-project?rev=374011=rev Log: [NFC] Fix ubsan-blacklist test Restored original test and marked tests for VFS as unsupported on Windows. Added: cfe/trunk/test/CodeGen/ubsan-blacklist-vfs.c

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

hliao added a comment. In D68587#1698247 , @tra wrote: > In D68587#1698102 , @hliao wrote: > > > for most compilation tools, single input and single output are expected. > > Without assuming `-fsyntax-only` alone

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

yaxunl updated this revision to Diff 223712. yaxunl marked 14 inline comments as done. yaxunl added a comment. revised by Alexey's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67837/new/ https://reviews.llvm.org/D67837 Files: include/clang/Sema/Sema.h

r374006 - Reland 'Add VFS support for sanitizers' blacklist'

Author: jkorous Date: Mon Oct 7 18:13:17 2019 New Revision: 374006 URL: http://llvm.org/viewvc/llvm-project?rev=374006=rev Log: Reland 'Add VFS support for sanitizers' blacklist' The original patch broke the test for Windows. Trying to fix as per Reid's suggestions outlined here:

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Thanks!! Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:2030-2033 // FIXME: this is a hack for fixing a later crash when attempting to // dereference

r373999 - Revert "Add VFS support for sanitizers' blacklist"

Author: jkorous Date: Mon Oct 7 17:36:19 2019 New Revision: 373999 URL: http://llvm.org/viewvc/llvm-project?rev=373999=rev Log: Revert "Add VFS support for sanitizers' blacklist" Fix tests on Windows for now. This reverts commit 96ac97a4213287003f08636d0c372b3f71e9cfca. Removed:

[PATCH] D68055: Add -fgnuc-version= to control __GNUC__ and other GCC macros

rsmith added a comment. From a big-picture perspective, I would like us to move to treating MS and GNU extensions in the same way (at the cc1 level) to the extent that we can. I think this moves us in that direction. One comment, though: I'm not convinced that the `__EXCEPTIONS` macro should

r373992 - [clang] Accept -ftrivial-auto-var-init in clang-cl

Author: vitalybuka Date: Mon Oct 7 16:57:11 2019 New Revision: 373992 URL: http://llvm.org/viewvc/llvm-project?rev=373992=rev Log: [clang] Accept -ftrivial-auto-var-init in clang-cl Reviewers: eugenis, rnk Subscribers: cfe-commits Tags: #clang Differential Revision:

[PATCH] D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl

vitalybuka marked an inline comment as done. vitalybuka added inline comments. Comment at: clang/include/clang/Driver/Options.td:1720 " | pattern">, Values<"uninitialized,pattern">; def enable_trivial_var_init_zero : Joined<["-"],

[PATCH] D68610: [clang] enable_trivial_var_init_zero should not be Joined<>

vitalybuka created this revision. vitalybuka added a reviewer: rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68610 Files: clang/include/clang/Driver/Options.td Index:

[PATCH] D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/include/clang/Driver/Options.td:1720 " | pattern">, Values<"uninitialized,pattern">; def enable_trivial_var_init_zero : Joined<["-"],

[PATCH] D68608: [clang] Accept -ftrivial-auto-var-init in clang-cl

vitalybuka created this revision. vitalybuka added reviewers: eugenis, rnk. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D68608 Files: clang/include/clang/Driver/Options.td

[PATCH] D68410: [AttrDocs] document always_inline

dblaikie added a comment. > In D68410#1696411 , @joerg wrote: > >> I wonder if we should actually enumerate evil here, i.e. give the situations >> in which inlining actually fails. > > > Which is likely to change over time. I worry that enumerating

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

Hm, there is no "bitwise negation of a boolean expression always evaluates to 'true'; did you mean logical negation?" for chromium case. I will try to fix it. ut 8. 10. 2019 o 0:03 Dávid Bolvanský napísal(a): > > "FWIW I found the "always evaluates to 'true'" bit important to > understand the

r373977 - Add VFS support for sanitizers' blacklist

Author: jkorous Date: Mon Oct 7 15:36:19 2019 New Revision: 373977 URL: http://llvm.org/viewvc/llvm-project?rev=373977=rev Log: Add VFS support for sanitizers' blacklist Differential Revision: https://reviews.llvm.org/D67742 Added:

[PATCH] D68377: [Builtins] Teach Clang about memccpy

xbolva00 added a comment. Current solution does not work /home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: error: redefinition of ‘BImemccpy’ #define BUILTIN(ID, TYPE, ATTRS) BI##ID, ^ /home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: note:

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

"FWIW I found the "always evaluates to 'true'" bit important to understand the warning." Yeah. I moved this check somewhere else, so we can print precise message: r373973 should emit "bitwise negation of a boolean expression always evaluates to 'true'; did you mean logical negation?" where

r373973 - [Diagnostics] Emit better -Wbool-operation's warning message if we known that the result is always true

Author: xbolva00 Date: Mon Oct 7 14:57:03 2019 New Revision: 373973 URL: http://llvm.org/viewvc/llvm-project?rev=373973=rev Log: [Diagnostics] Emit better -Wbool-operation's warning message if we known that the result is always true Modified:

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

tra added a comment. In D68587#1698102 , @hliao wrote: > for most compilation tools, single input and single output are expected. > Without assuming `-fsyntax-only` alone is host-compilation only, that at > least run syntax checking twice. I believe

[PATCH] D68591: [analyzer] PR43551: Do not dereferce void* in UndefOrNullArgVisitor

Szelethus created this revision. Szelethus added reviewers: NoQ, xazax.hun, baloghadamsoftware, Charusso, dcoughlin, rnkovacs. Szelethus added a project: clang. Herald added subscribers: cfe-commits, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet, whisperity. Exactly what it

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, jfb, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Instead of `AppDelegate::application:didFinishLaunchingWithOptions:` you will now

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

hliao added a comment. In D68587#1698055 , @tra wrote: > I'm fine with this for -E/-M, > > I would argue that with `-fsyntax-only` we want to know whether our source > code, which is common for all sub-compilations, has syntactic errors. > The way we

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. Another approach to reference types we should look at is clang's upcoming sizeless types support (https://reviews.llvm.org/D62962, RFC: http://lists.llvm.org/pipermail/cfe-dev/2019-June/062523.html). This would allow reference types to be constructed at the source

r373952 - [OPENMP]Fix caonical->canonical, NFC.

Author: abataev Date: Mon Oct 7 12:57:40 2019 New Revision: 373952 URL: http://llvm.org/viewvc/llvm-project?rev=373952=rev Log: [OPENMP]Fix caonical->canonical, NFC. Fixed typo. Modified: cfe/trunk/include/clang/AST/StmtOpenMP.h cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp Modified:

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

tra added a comment. I'm fine with this for -E/-M, I would argue that with `-fsyntax-only` we want to know whether our source code, which is common for all sub-compilations, has syntactic errors. The way we compile HIP & CUDA sources, some of the errors will only be reported on one side of

[clang-tools-extra] r373951 - Attempt to fix a few clang-tidy tests on Windows, see PR43593.

Author: nico Date: Mon Oct 7 12:54:19 2019 New Revision: 373951 URL: http://llvm.org/viewvc/llvm-project?rev=373951=rev Log: Attempt to fix a few clang-tidy tests on Windows, see PR43593. Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-branch-clone.cpp

r373950 - Fix for expanding __pragmas in macro arguments

Author: akhuang Date: Mon Oct 7 12:41:53 2019 New Revision: 373950 URL: http://llvm.org/viewvc/llvm-project?rev=373950=rev Log: Fix for expanding __pragmas in macro arguments Summary: Avoid parsing __pragma into an annotation token when macro arguments are pre-expanded. This is what clang

[PATCH] D68587: [hip] Assume host-only compilation if the final phase is ahead of `backend`.

hliao created this revision. hliao added reviewers: tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - There are several scenarios where the compilation needs stopping before `backend`, such as `-E`, `-fsyntax-ony`, and even more if developers want to diagnose

[PATCH] D67980: [BPF] do compile-once run-everywhere relocation for bitfields

ast added a comment. thanks for adding the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67980/new/ https://reviews.llvm.org/D67980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r373939 - [OPENMP50]Treat range-based for as canonical loop.

Author: abataev Date: Mon Oct 7 11:54:57 2019 New Revision: 373939 URL: http://llvm.org/viewvc/llvm-project?rev=373939=rev Log: [OPENMP50]Treat range-based for as canonical loop. According to OpenMP 5.0, range-based for is also considered as a canonical form of loops. Modified:

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

dmikulin updated this revision to Diff 223634. dmikulin added a comment. Added a new CodeGetCXX test case CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985/new/ https://reviews.llvm.org/D67985 Files: clang/lib/CodeGen/CGExprCXX.cpp

[PATCH] D68584: Fix Calling Convention through aliases

rnk accepted this revision. rnk added a comment. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68584/new/ https://reviews.llvm.org/D68584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

thakis accepted this revision. thakis added a comment. Thanks, I think this is a good change. It fixes a false positive in wayland and one somewhere in Chromium's windows sandbox. See the commit thread of r371605 for examples. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68410: [AttrDocs] document always_inline

nickdesaulniers added a comment. In D68410#1694026 , @kristina wrote: > Also, I'm fairly certain `__forceinline` and `always_inline`, confusingly > enough differ in semantics, with `__forceinline` only being a stronger hint > on MSVC. Does clang

r373936 - [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build

Author: mgorny Date: Mon Oct 7 11:14:56 2019 New Revision: 373936 URL: http://llvm.org/viewvc/llvm-project?rev=373936=rev Log: [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build Differential Revision: https://reviews.llvm.org/D68412 Modified: cfe/trunk/CMakeLists.txt

[clang-tools-extra] r373932 - Try to get clangd tests passing on Windows.

Author: nico Date: Mon Oct 7 10:55:05 2019 New Revision: 373932 URL: http://llvm.org/viewvc/llvm-project?rev=373932=rev Log: Try to get clangd tests passing on Windows. Part of PR43592. See also r328645. Modified: clang-tools-extra/trunk/clangd/test/semantic-highlighting.test

[PATCH] D68578: [HIP] Fix device stub name

tra added a comment. In D68578#1697851 , @yaxunl wrote: > In D68578#1697822 , @tra wrote: > > > Could you elaborate on how exactly current implementation does not work? > > > > I would expect the kernel and the

r373929 - Fix Calling Convention through aliases

Author: erichkeane Date: Mon Oct 7 10:28:03 2019 New Revision: 373929 URL: http://llvm.org/viewvc/llvm-project?rev=373929=rev Log: Fix Calling Convention through aliases r369697 changed the behavior of stripPointerCasts to no longer include aliases. However, the code in CGDeclCXX.cpp's

[PATCH] D68412: [clang] [cmake] Support LLVM_DISTRIBUTION_COMPONENTS in stand-alone build

smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68412/new/ https://reviews.llvm.org/D68412 ___ cfe-commits mailing list

r373928 - [libTooling][NFC] Fix build break in r373916.

Author: ymandel Date: Mon Oct 7 10:24:23 2019 New Revision: 373928 URL: http://llvm.org/viewvc/llvm-project?rev=373928=rev Log: [libTooling][NFC] Fix build break in r373916. r373916 used raw strings inside macro calls, which breaks some builds. Modified:

[PATCH] D68584: Fix Calling Convention through aliases

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/CodeGen/CGDeclCXX.cpp:251 // Make sure the call and the callee agree on calling convention. - if (llvm::Function *dtorFn = -

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

pcc added a comment. Can you add a CodeGenCXX test as well, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985/new/ https://reviews.llvm.org/D67985 ___ cfe-commits mailing list

[PATCH] D67985: CFI: wrong type passed to llvm.type.test with multiple inheritance devirtualization

filcab added subscribers: pcc, filcab. filcab added a comment. It seems there's a FIXME anticipating this problem. @pcc: Can you double-check, please? Thank you, Filipe Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67985/new/

[PATCH] D68574: [libTooling] Add `toString` method to the Stencil class

ymandel added a comment. The tests broke the build on some platforms because of the use of raw strings in macros. Fixing now... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68574/new/ https://reviews.llvm.org/D68574

[clang-tools-extra] r373924 - [clangd] Fix raciness in code completion tests

Author: kadircet Date: Mon Oct 7 10:12:18 2019 New Revision: 373924 URL: http://llvm.org/viewvc/llvm-project?rev=373924=rev Log: [clangd] Fix raciness in code completion tests Reviewers: sammccall, ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, usaxena95, cfe-commits Tags: #clang

[PATCH] D63960: [C++20] Add consteval-specific semantic for functions

Tyker updated this revision to Diff 223624. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63960/new/ https://reviews.llvm.org/D63960 Files: clang/include/clang/AST/DeclCXX.h clang/include/clang/Basic/DiagnosticASTKinds.td clang/include/clang/Basic/DiagnosticSemaKinds.td

r373922 - [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

Author: paulhoad Date: Mon Oct 7 10:03:44 2019 New Revision: 373922 URL: http://llvm.org/viewvc/llvm-project?rev=373922=rev Log: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete() Summary: clang-format is incorrectly thinking the parameter parens are

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

mitchell-stellar added a comment. I don't care for the command line switches that try to emulate compiler flags. I am also of the opinion that external scripts should be used for this functionality. git for Windows gives you a full set of bash utilities to utilize, so doing stuff like this on

r373921 - [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

Author: paulhoad Date: Mon Oct 7 09:53:35 2019 New Revision: 373921 URL: http://llvm.org/viewvc/llvm-project?rev=373921=rev Log: [clang-format] [NFC] Ensure clang-format is itself clang-formatted. Summary: Before making a proposed change, ensure ClangFormat.cpp is fully clang-formatted, no

[PATCH] D68578: [HIP] Fix device stub name

hliao added inline comments. Comment at: lib/CodeGen/CGCUDANV.cpp:235 CGF.CGM.getContext().getTargetInfo().getCXXABI())) || + CGF.getLangOpts().HIP || getDeviceStubName(getDeviceSideName(CGF.CurFuncDecl)) == keeping the original

[PATCH] D29039: [clang-format] Proposal for clang-format -r option

mitchell-stellar added a subscriber: djasper. mitchell-stellar added a comment. I agree with @djasper that this is outside the scope of clang-format. git for Windows gives you a full set of bash utilities to utilize, so doing stuff like this on Windows is much easier now. Repository: rL

[PATCH] D68578: [HIP] Fix device stub name

yaxunl added a comment. In D68578#1697822 , @tra wrote: > Could you elaborate on how exactly current implementation does not work? > > I would expect the kernel and the stub to be two distinct entities, as far as > debugger is concerned. It does have

r373918 - Codegen - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Mon Oct 7 09:42:25 2019 New Revision: 373918 URL: http://llvm.org/viewvc/llvm-project?rev=373918=rev Log: Codegen - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/DefineInline.cpp:196 + +std::string Qualifier = printNamespaceScope(*ND->getDeclContext()); +if (auto Err = Replacements.add( ilya-biryukov wrote: > You would want to

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

asbirlea added a comment. Maybe elaborate in the patch description what `determine when and how we will unroll loops.` means? e.g.: "The default before and after this patch is for LoopUnroll to be enabled, and for it to use a cost model to determine whether to unroll the loop (`OnlyWhenForced

[PATCH] D53768: Add VerboseOutputStream to CompilerInstance

scott.linder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53768/new/ https://reviews.llvm.org/D53768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D68551: [clang-format] [NFC] Ensure clang-format is itself clang-formatted.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM. I agree that a system in place that either enforces clang-formatting on commit or after the fact would be ideal. Otherwise, I don't see a need to have to approve

[PATCH] D66647: [clangd] DefineInline action apply logic with fully qualified names

kadircet updated this revision to Diff 223620. kadircet marked 9 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66647/new/ https://reviews.llvm.org/D66647 Files:

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added subscribers: samparker, SjoerdMeijer. dmgreen added a comment. This is looking good to me. My understanding is that is has some dependencies? The llvm side will likely needed to go in first, plus a couple of clang patches? Comment at:

[PATCH] D68481: [clang-format] [PR27004] omits leading space for noexcept when formatting operator delete()

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68481/new/ https://reviews.llvm.org/D68481 ___ cfe-commits

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

sammccall added a comment. In D67536#1697696 , @nridge wrote: > One thing that may be worth considering as well, is that if the client > prefers to highlight the text of the line only, it can calculate the length > of the line itself. In VSCode for

r373916 - [libTooling] Add `toString` method to the Stencil class

Author: ymandel Date: Mon Oct 7 09:20:22 2019 New Revision: 373916 URL: http://llvm.org/viewvc/llvm-project?rev=373916=rev Log: [libTooling] Add `toString` method to the Stencil class Summary: `toString` generates a string representation of the stencil. Patch by Harshal T. Lehri. Reviewers:

[PATCH] D68578: [HIP] Fix device stub name

tra added a comment. Could you elaborate on how exactly current implementation does not work? I would expect the kernel and the stub to be two distinct entities, as far as debugger is concerned. It does have enough information to track each independently (different address, .stub suffix,

[PATCH] D68574: [libTooling] Add `toString` method to the Stencil class

ymandel updated this revision to Diff 223619. ymandel added a comment. fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68574/new/ https://reviews.llvm.org/D68574 Files: clang/include/clang/Tooling/Refactoring/Stencil.h

[PATCH] D68526: [Diagnostics] Silence -Wsizeof-array-div for character buffers

xbolva00 added a comment. @tkanis wrote in post commit review: “What do you think about also not emitting the warning if the lhs sizeof is an array of signed or unsigned char? The warning wants the rhs sizeof to be sizeof(char) which is 1, and dividing by that doesn't really make sense. ” I

[PATCH] D68584: Fix Calling Convention through aliases

erichkeane created this revision. erichkeane added reviewers: rnk, pcc. Herald added a subscriber: hiraditya. Herald added a project: LLVM. r369697 changed the behavior of stripPointerCasts to no longer include aliases. However, the code in CGDeclCXX.cpp's createAtExitStub counted on the looking

[PATCH] D68574: [libTooling] Add `toString` method to the Stencil class

gribozavr accepted this revision. gribozavr added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Tooling/Refactoring/Stencil.h:54 + /// Constructs a string representation of the StencilPart. StencilParts + /// generated by the

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

Typo was fixed some days ago :) Odoslané z iPhonu > Dňa 7. 10. 2019 o 17:22 užívateľ Arthur O'Dwyer > napísal: > >  >> On Mon, Oct 7, 2019 at 10:59 AM Dávid Bolvanský via cfe-commits >> wrote: > >> Okey, I will see what I can do (I know I need to move checking code >> somewhere else). >>

[PATCH] D68581: Include leading attributes in DeclStmt's SourceRange

sberg created this revision. sberg added reviewers: aaron.ballman, rsmith, Nathan-Huckleberry. Herald added a project: clang. For a `DeclStmt` like [[maybe_unused]] int i; `getBeginLoc()` returned the start of `int` instead of the start of `[[` (see

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/RemoveUsingNamespace.cpp:86 + if (const Decl *ParentDecl = Node->Parent->ASTNode.get()) { +return llvm::isa(ParentDecl); + } NIT: remove redundant `{}` around this

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge added a comment. One thing that may be worth considering as well, is that if the client prefers to highlight the text of the line only, it can calculate the length of the line itself. In VSCode for instance, the line lengths are readily available; I imagine other editors are similar

Re: r371605 - [Diagnostics] Add -Wsizeof-array-div

D68526 should fix it. Take a look please. > Dňa 7. 10. 2019 o 17:09 užívateľ Nico Weber napísal: > >  > I gave this another try now that we have a compiler with rL372600. Another > thing the warning currently warns on is code like this: > > char memory[kOpcodeMemory]; > OpcodeFactory

Re: r371605 - [Diagnostics] Add -Wsizeof-array-div

I gave this another try now that we have a compiler with rL372600. Another thing the warning currently warns on is code like this: char memory[kOpcodeMemory]; OpcodeFactory opcode_maker(memory, sizeof(memory)); size_t count = sizeof(memory) / sizeof(PolicyOpcode); or int32_t

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

hokein added a comment. In D67536#1697533 , @nridge wrote: > How would one even measure the line length? `SourceManager` doesn't sem to > have a method like `getLineLength()` or similar. Yes, there is no existing API for that, I think you'd need to get

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

sammccall added a comment. In D67536#1697533 , @nridge wrote: > How would one even measure the line length? `SourceManager` doesn't sem to > have a method like `getLineLength()` or similar. If you look at functions like `offsetToPosition` in

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

Okey, I will see what I can do (I know I need to move checking code somewhere else). > Dňa 7. 10. 2019 o 16:54 užívateľ Nico Weber napísal: > ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r373743 - [NFCI] Improve the -Wbool-operation's warning message

FWIW I found the "always evaluates to 'true'" bit important to understand the warning. We did hit this (at least once) in Chromium after all [1] (looks like a real bug – nothing for you to do about that, and thanks for the warning), and I don't think I would've understood what the warning wanted

[PATCH] D28213: [Frontend] Correct values of ATOMIC_*_LOCK_FREE to match builtin

jyknight reopened this revision. jyknight added a comment. This revision is now accepted and ready to land. The close was due to phabricator problem, reopening. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D28213/new/

r373911 - Sema - silence static analyzer getAs<> null dereference warnings. NFCI.

Author: rksimon Date: Mon Oct 7 07:25:46 2019 New Revision: 373911 URL: http://llvm.org/viewvc/llvm-project?rev=373911=rev Log: Sema - silence static analyzer getAs<> null dereference warnings. NFCI. The static analyzer is warning about potential null dereferences, but in these cases we should

r373910 - [clang] Add test for FindNextToken in Lexer.

Author: usaxena95 Date: Mon Oct 7 07:20:46 2019 New Revision: 373910 URL: http://llvm.org/viewvc/llvm-project?rev=373910=rev Log: [clang] Add test for FindNextToken in Lexer. Reviewers: ilya-biryukov Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D68565

[PATCH] D68562: [clangd] Add RemoveUsingNamespace tweak.

usaxena95 updated this revision to Diff 223592. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Make the tweak trigger only for TopLevelDecl. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68562/new/

[PATCH] D68213: [LTO] Support for embedding bitcode section during LTO

zapster added a comment. (ping) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68213/new/ https://reviews.llvm.org/D68213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge marked 2 inline comments as done. nridge added a comment. How would one even measure the line length? `SourceManager` doesn't sem to have a method like `getLineLength()` or similar. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

nridge marked 5 inline comments as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/Compiler.cpp:66 CI->getLangOpts()->CommentOpts.ParseAllComments = true; + CI->getPreprocessorOpts().DetailedRecord = true; return CI; ilya-biryukov

[PATCH] D67837: [CUDA][HIP] Fix host/device check with -fopenmp

ABataev added inline comments. Comment at: lib/Sema/SemaCUDA.cpp:604 // Do we know that we will eventually codegen the given function? static bool IsKnownEmitted(Sema , FunctionDecl *FD) { + return S.getEmissionStatus(FD) == Sema::FunctionEmissionStatus::Emitted;

  1   2   >