[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

SouraVX added a comment. Hi @probinson @dblaikie @aprantl , I've was investigating and working on your inputs regarding the problem with DW_at_defaulted once. I think clang has also some issues. Though I'm not able to precisely point out. I ranned into some problems in CFE while marking

[PATCH] D69043: [RFC] Adding time-trace to LLD?

ruiu added inline comments. Comment at: lld/ELF/Options.td:361 +def time_trace: F<"time-trace">, HelpText<"Record time trace">; + aganea wrote: > Given this option is a candidate for the other LLD drivers, I am wondering if > we couldn't have a shared

[PATCH] D69150: [analyzer] Fix hidden node traversal in exploded graph dumps.

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. When you see static bool traverseHiddenNodes( const ExplodedNode *N, llvm::function_ref PreCallback, llvm::function_ref PostCallback, llvm::function_ref Stop) {

[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/CallEvent.cpp:325 if (getKind() != CE_CXXAllocator) if (isArgumentConstructedDirectly(Idx)) if (auto AdjIdx = getAdjustedParameterIndex(Idx)) What about this one? It

[PATCH] D69043: [RFC] Adding time-trace to LLD?

ruiu added a comment. I applied this patch and built clang with ThinLTO. Here is the generated file: $ less bin/clang-10.json {"traceEvents":[{"pid":1,"tid":185412,"ph":"X","ts":181,"dur":1441864,"name":"Parse input

[PATCH] D69075: [WebAssembly] -pthread implies -target-feature +sign-ext

This revision was automatically updated to reflect the committed changes. tlively marked an inline comment as done. Closed by commit rG807cecad5d98: [WebAssembly] -pthread implies -target-feature +sign-ext (authored by tlively). Changed prior to commit:

r375199 - [WebAssembly] -pthread implies -target-feature +sign-ext

Author: tlively Date: Thu Oct 17 21:34:26 2019 New Revision: 375199 URL: http://llvm.org/viewvc/llvm-project?rev=375199=rev Log: [WebAssembly] -pthread implies -target-feature +sign-ext Summary: The sign extension proposal was motivated by a desire to not have separate sign-extending atomic

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added inline comments. Comment at: clang/test/Format/dry-run-alias.cpp:1-2 +// RUN: clang-format -style=LLVM -i -n %s 2> %t.stderr +// RUN: grep -E "*code should be clang-formatted*" %t.stderr +

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. In D69088#1714019 , @Meinersbur wrote: > In D69088#1713933 , @hsaito wrote: > > > Have we established general consensus for the desire to have the flexible > > enough loop optimization pass

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713933 , @hsaito wrote: > Have we established general consensus for the desire to have the flexible > enough loop optimization pass ordering to accomplish the outcome of the new > directive, and shared vision for

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713915 , @ABataev wrote: > Just do not allow this form with respect_order clause. What exactly would be the rules what is allowed and what isn't? We can just not allow not mixing `#pragma clang loop` and `#pragma

[PATCH] D69155: [analyzer] Fix off-by-one in operator call parameter binding.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. This is the bug that I'll be using in

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

kousikk added a comment. Thanks for the comment @jkorous. > I think you could've just used CHECK-DAG to fix the tests. It *might* be a > bit more robust. Although just reordering checks seems perfectly fine too. > https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive. >

[PATCH] D67647: [Consumed] Refactor handleCall to take function argument list. NFC.

comex updated this revision to Diff 225557. comex marked 2 inline comments as done. comex added a comment. So, I landed this patch but had to revert it as it broke the build on MSVC (and only MSVC). That was almost a month ago, but I haven't gotten back around to this until now – sorry :| In

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk added a comment. > I haven't looked into this in detail but it feels kind of wasteful to start a > process just to get this value. Right, that's why I cache this information. So multiple compile commands sharing the same compiler process will trigger at 1 subprocess and then

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. Have we established general consensus for the desire to have the flexible enough loop optimization pass ordering to accomplish the outcome of the new directive, and shared vision for the path to get there? If we are making this a general clang directive, I'd like to see

Re: Zorg migration to GitHub/monorepo

Hello everyone, The build bot is almost ready to move to github. As the next step we would migrate the staging master to listen for the both changes, from SVN as it was before, and from github. Tonight I am going to update the staging (aka silent) master and it will start working with github.

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

hliao added inline comments. Comment at: clang/test/Format/dry-run-alias.cpp:1-2 +// RUN: clang-format -style=LLVM -i -n %s 2> %t.stderr +// RUN: grep -E "*code should be clang-formatted*" %t.stderr + Why not check with `FileCheck`? Comment

[PATCH] D69088: [Lex] #pragma clang transform

ABataev added a comment. In D69088#1713901 , @Meinersbur wrote: > In D69088#1713831 , @tyler.nowicki > wrote: > > > That approach would avoid the inevitable conflicts of having both loop and > > transform pragmas

[PATCH] D69150: [analyzer] Fix hidden node traversal in exploded graph dumps.

NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a_sidorin, rnkovacs, Szelethus, baloghadamsoftware, Charusso. Herald added subscribers: cfe-commits, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, szepet. Herald added a project: clang. NoQ marked an inline comment as done.

[PATCH] D69150: [analyzer] Fix hidden node traversal in exploded graph dumps.

NoQ marked an inline comment as done. NoQ added inline comments. Comment at: clang/test/Analysis/dump_egraph.c:32 +// CHECK-SAME:\"pretty\": \"0\", \"location\": \{ +// CHECK-SAME:\"line\": 15, \"column\": 12, \"file\": \" +// CHECK-SAME:\}, \"stmt_point_kind\":

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713831 , @tyler.nowicki wrote: > That approach would avoid the inevitable conflicts of having both loop and > transform pragmas on the same loop. I fear it will give us far worse ambiguities. Consider: #pragma

[PATCH] D65761: Add Windows Control Flow Guard checks (/guard:cf).

rnk added a comment. I think this looks pretty good, thanks! I really only noticed style nits. I think with some small fixes, we should go ahead and merge it. If you want, I can commit it on your behalf, but I know there are other folks at Microsoft with commit access to LLVM, if you'd prefer.

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713831 , @tyler.nowicki wrote: > In D69088#1713648 , @Meinersbur > wrote: > > > In D69088#1713623 , @hsaito wrote: > > > > >

r375189 - [analyzer] exploded-graph-rewriter: Fix typo in r375186. Unbreaks tests.

Author: dergachev Date: Thu Oct 17 16:27:35 2019 New Revision: 375189 URL: http://llvm.org/viewvc/llvm-project?rev=375189=rev Log: [analyzer] exploded-graph-rewriter: Fix typo in r375186. Unbreaks tests. Modified: cfe/trunk/test/Analysis/dump_egraph.c Modified:

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

arphaman added a comment. @kousikk could we please add support for generic `-extra-arg`, which can then add `-resource-dir` like the other clang tools? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

NoQ closed this revision. NoQ added a comment. Closed by rC375186 but i forgot the phabricator link :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69015/new/ https://reviews.llvm.org/D69015 ___

[PATCH] D69088: [Lex] #pragma clang transform

tyler.nowicki added a comment. In D69088#1713648 , @Meinersbur wrote: > In D69088#1713623 , @hsaito wrote: > > > @Meinersbur, if I remember correctly, there was an RFC discussion on this > > topic, right? If yes,

r375186 - [analyzer] Assign truly stable identifiers to exploded nodes.

Author: dergachev Date: Thu Oct 17 16:10:09 2019 New Revision: 375186 URL: http://llvm.org/viewvc/llvm-project?rev=375186=rev Log: [analyzer] Assign truly stable identifiers to exploded nodes. ExplodedGraph nodes will now have a numeric identifier stored in them which will keep track of the

r375184 - [analyzer] exploded-graph-rewriter: Make node headers a bit lighter.

Author: dergachev Date: Thu Oct 17 16:10:02 2019 New Revision: 375184 URL: http://llvm.org/viewvc/llvm-project?rev=375184=rev Log: [analyzer] exploded-graph-rewriter: Make node headers a bit lighter. The 50% grey color is too dark on some monitors. Modified:

r375185 - [analyzer] Display cast kinds in program point dumps.

Author: dergachev Date: Thu Oct 17 16:10:05 2019 New Revision: 375185 URL: http://llvm.org/viewvc/llvm-project?rev=375185=rev Log: [analyzer] Display cast kinds in program point dumps. Because cast expressions have their own hierarchy, it's extremely useful to have some information about what

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

NoQ added inline comments. Comment at: clang/test/Analysis/exploded-graph-rewriter/node_labels.dot:46 +// COLOR-SAME: Sink Node +// GREY-SAME: Sink Node +// CHECK-SAME: Charusso wrote: > `GREY` typo. Whoops!! CHANGES SINCE LAST ACTION

[PATCH] D69015: [analyzer] Make ExplodedNode identifiers truly stable.

NoQ updated this revision to Diff 225540. NoQ marked an inline comment as done. NoQ added a comment. Fxd. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69015/new/ https://reviews.llvm.org/D69015 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/ExplodedGraph.h

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

Bigcheese added a comment. While adding the documentation I realized that a better name for this option would be `-fmodules-strict-context-hash` to make it clear which hash it's referring to. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68528/new/ https://reviews.llvm.org/D68528

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc created this revision. poelmanc added reviewers: malcolm.parsons, alexfh, hokein, aaron.ballman. poelmanc added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgehre. Herald added a project: clang. readability-redundant-member-init removes redundant / unnecessary

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

jkorous added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:70 +}; +if (const int RC = llvm::sys::ExecuteAndWait(ClangBinaryPath, PrintResourceDirArgs, {}, Redirects)) { + auto ErrorBuf = llvm::MemoryBuffer::getFile(ErrorFile.c_str());

Re: [PATCH] D69088: [Lex] #pragma clang transform

Sorry if this is answered in the patches but what happens if a loop has both #pragma clang loop and transform defined before it? I guess it probably shouldn't work. Perhaps instead you could create a new option to indicate that the order should be respected. #pragma clang loop respect_order <-

[PATCH] D68838: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

This revision was automatically updated to reflect the committed changes. Closed by commit rG5b0e039a7a7d: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3 (authored by efriedma). Changed prior to commit: https://reviews.llvm.org/D68838?vs=224496=225534#toc Repository: rG

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

This revision was automatically updated to reflect the committed changes. Closed by commit rG6caada4eb465: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

bruno added a comment. *using implicit modules in a build where compiler flags in different invocations aren't homogeneous, or something along those lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68528/new/ https://reviews.llvm.org/D68528

[PATCH] D68528: [Implicit Modules] Add -cc1 option -fmodules-strict-hash which includes search paths and diagnostics.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM with one minor change. Can you add an entry in the modules docs for this flag and mention that using it can lead to more PCMs in an implicit build? CHANGES SINCE LAST ACTION

r375179 - [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3

Author: efriedma Date: Thu Oct 17 14:57:28 2019 New Revision: 375179 URL: http://llvm.org/viewvc/llvm-project?rev=375179=rev Log: [ARM] Fix arm_neon.h with -flax-vector-conversions=none, part 3 It's completely impossible to check that I've actually found all the issues, due to the use of macros

r375177 - [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

Author: sdmitriev Date: Thu Oct 17 14:55:39 2019 New Revision: 375177 URL: http://llvm.org/viewvc/llvm-project?rev=375177=rev Log: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test Differential Revision: https://reviews.llvm.org/D69140 Modified:

[PATCH] D68682: Clang-tidy fix removals removing all non-blank text from a line should remove the line

poelmanc updated this revision to Diff 225523. poelmanc edited the summary of this revision. poelmanc added a comment. In D68682#1707764 , @alexfh wrote: > cleanupAroundReplacements is not used by clang-format itself. I believe, it's > a part of

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69140/new/ https://reviews.llvm.org/D69140

[PATCH] D69144: [Format] Add format check for throwing negative numbers

jonathoma created this revision. jonathoma added a reviewer: modocache. jonathoma added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. jonathoma edited the summary of this revision. jonathoma added reviewers: sammccall, Quuxplusone. The code `throw

[PATCH] D69140: [clang-offload-wrapper][NFC] Use captured name of the entry type in LIT test

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69140 Files:

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 225521. stevewan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files: clang/lib/Driver/CMakeLists.txt

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713623 , @hsaito wrote: > @Meinersbur, if I remember correctly, there was an RFC discussion on this > topic, right? If yes, would you post the pointer to that? I need a refresher > on what has been

[PATCH] D69088: [Lex] #pragma clang transform

Meinersbur added a comment. In D69088#1713147 , @ABataev wrote: > Why not try to improve the existing #pragma clang loop rather than add a new > pragma with almost the same behavior? The behavior and syntax is different. #pragma clang loop ignores the

[PATCH] D69088: [Lex] #pragma clang transform

hsaito added a comment. @Meinersbur, if I remember correctly, there was an RFC discussion on this topic, right? If yes, would you post the pointer to that? I need a refresher on what has been discussed/settled in the past. Repository: rC Clang CHANGES SINCE LAST ACTION

r375167 - [OPENMP]Dow not emit warnings for uninitialized loop counters.

Author: abataev Date: Thu Oct 17 13:35:08 2019 New Revision: 375167 URL: http://llvm.org/viewvc/llvm-project?rev=375167=rev Log: [OPENMP]Dow not emit warnings for uninitialized loop counters. In OpenMP constructs all counters are initialized and we should not emit warnings about uninitialized

[PATCH] D67992: [Sema] Add MacroQualified case for FunctionTypeUnwrapper

jkim added a comment. Ping... @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67992/new/ https://reviews.llvm.org/D67992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaOverload.cpp:594 }; + struct CNSInfo { +TemplateArgumentList *TemplateArgs; Please add a documentation comment.

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra added a comment. This is... rather oddly-structured output. My brain refuses to accept that the most-indented phase is the input. Perhaps we should do `llvm::errs().indent(MaxIdent-Ident)`. This should give us something like this (withMaxIdent=9), which is somewhat easier to grok, IMO:

[PATCH] D69129: [AMDGPU] Fix assertion due to initializer list

yaxunl created this revision. yaxunl added a reviewer: rjmccall. Herald added subscribers: t-tye, tpr, dstuttard, wdng, kzhuravl. Sometimes a global var is replaced by a different llvm value. clang use GetAddrOfGlobalVar to get the original llvm global variable. For most targets,

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713360 , @tra wrote: > Could you give an example of before/after output? For HIP $ clang -x hip -ccc-print-phases --cuda-gpu-arch=gfx900 --cuda-gpu-arch=gfx906 -c ~/dummy.cpp 0: input,

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. In D69124#1713360 , @tra wrote: > Could you give an example of before/after output? $ clang -x cuda -ccc-print-phases --cuda-gpu-arch=sm_30 --cuda-gpu-arch=sm_60 -c ~/dummy.cpp 0: input, "/home/michliao/dummy.cpp",

[PATCH] D69090: [Try 2] Include sanitize blacklist and other extra deps as part of scan-deps output

jkorous added a comment. I think you could've just used `CHECK-DAG` to fix the tests. It *might* be a bit more robust. Although just reordering checks seems perfectly fine too. https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-dag-directive Using `std::set` here sounds reasonable to

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

tra added a comment. Could you give an example of before/after output? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69124/new/ https://reviews.llvm.org/D69124 ___ cfe-commits mailing list

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao created this revision. hliao added reviewers: tra, sfantao, echristo. Herald added a project: clang. Herald added a subscriber: cfe-commits. hliao added a comment. this patch enables the dumping of actions in the hierarchy or tree. In most cases, it's a linear list but, for offload

[PATCH] D69124: [clang][driver] Print compilation phases with indentation.

hliao added a comment. this patch enables the dumping of actions in the hierarchy or tree. In most cases, it's a linear list but, for offload compilation, a tree representation is more intuitive. Even though there are cross-subtree edges, they are rare and also noted in the corresponding

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk created this revision. kousikk added reviewers: arphaman, Bigcheese, jkorous, dexonsmith. Herald added a project: clang. Herald added a subscriber: cfe-commits. kousikk edited the summary of this revision. kousikk edited the summary of this revision. If -resource-dir is not specified as

[PATCH] D66983: [WebAssembly] Add wasm-specific vector shuffle builtin and intrinsic

tlively reclaimed this revision. tlively added a comment. I'm re-opening this revision. After discussion on https://github.com/WebAssembly/simd/issues/118, there is clear consensus that we do not want to break WebAssembly's abstraction and consider underlying platforms, so shuffles should not

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille added a comment. Extra note: an older version of the patch has been tested by the firefox team without much performance impact, (and no test failure), see https://bugzilla.mozilla.org/show_bug.cgi?id=1588710 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 225462. serge-sans-paille added a comment. Moved the implementation to a specialization of `emitStackProbeInline` that used to be Windows-centric. Provide a generic implementation that generates inline assembly instead. that way we don't clutter

[PATCH] D69088: [Lex] #pragma clang transform

ABataev added a comment. Why not try to improve the existing #pragma clang loop rather than add a new pragma with almost the same behavior? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69088/new/ https://reviews.llvm.org/D69088

r375134 - [OPENMP]Improve use of the global tid parameter.

Author: abataev Date: Thu Oct 17 10:12:03 2019 New Revision: 375134 URL: http://llvm.org/viewvc/llvm-project?rev=375134=rev Log: [OPENMP]Improve use of the global tid parameter. If we can determined, that the global tid parameter can be used in the function, better to use it rather than calling

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

MyDeveloperDay added a comment. In D68554#1712863 , @hans wrote: > > I can't wait for @hans next Windows Snapshot, this is my gate for rolling > > into our builds and CI system, after that, I'm gonna catch every single > > person who tries to

[PATCH] D68969: [clang-format] Remove the dependency on frontend

MyDeveloperDay updated this revision to Diff 225455. MyDeveloperDay added a comment. Update out by one errors and unused variables CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68969/new/ https://reviews.llvm.org/D68969 Files: clang/tools/clang-format/CMakeLists.txt

[PATCH] D68818: [hip][cuda] Fix the extended lambda name mangling issue.

hliao updated this revision to Diff 225452. hliao added a comment. Force numbering on all lambdas in CUDA/HIP. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68818/new/ https://reviews.llvm.org/D68818 Files: clang/include/clang/AST/DeclCXX.h

[PATCH] D66827: Add support for MS qualifiers __ptr32, __ptr64, __sptr, __uptr.

DarkShadow44 added a comment. @akhuang Thanks for looking into this! I've found something else, I've written a small dumper to demonstrate. Pardon the long comment please. Program: typedef int* __ptr32 PINT32; typedef int* PINT64; struct s1 { PINT32 i32; PINT64 i64;

[PATCH] D67216: [cfi] Add flag to always generate .debug_frame

dcandler added a comment. I added the negative option more as a way to disable the flag, since I'm currently looking at cases where it may want to be turned on by default (and a negative option would then allow you to only get .eh_frame in cases where you'd get both .debug_frame/.eh_frame).

[PATCH] D67550: [AArch64][SVE] Implement unpack intrinsics

greened accepted this revision. greened added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67550/new/ https://reviews.llvm.org/D67550 ___ cfe-commits mailing list

Re: r374135 - [c++20] P1152R4: warn on any simple-assignment to a volatile lvalue

On Thu, 17 Oct 2019, 05:17 Stephan Bergmann via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > On 09/10/2019 04:04, Richard Smith via cfe-commits wrote: > > Author: rsmith > > Date: Tue Oct 8 19:04:54 2019 > > New Revision: 374135 > > > > URL:

[PATCH] D68377: [Builtins] Teach Clang about memccpy

aaron.ballman added a comment. In D68377#1698399 , @xbolva00 wrote: > Current solution does not work > /home/xbolva00/LLVM/llvm/tools/clang/include/clang/Basic/Builtins.h:50:34: > error: redefinition of ‘BImemccpy’ > > #define BUILTIN(ID, TYPE, ATTRS)

[PATCH] D67983: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGccc4d83cda16: [ObjC] Diagnose implicit type coercion from ObjC Class to object pointer… (authored by jyknight). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

r375125 - [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object

Author: jyknight Date: Thu Oct 17 08:27:04 2019 New Revision: 375125 URL: http://llvm.org/viewvc/llvm-project?rev=375125=rev Log: [ObjC] Diagnose implicit type coercion from ObjC 'Class' to object pointer types. For example, in Objective-C mode, the initialization of 'x' in: ```

[PATCH] D68028: [clang] Add no_builtin attribute

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:3416 + +def NoBuiltin : InheritableAttr { + let Spellings = [Clang<"no_builtin">]; I think we do not want this to be an inheritable attribute, but just `Attr` instead, because

[PATCH] D67982: [ObjC] Add some additional test cases around pointer conversions.

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c982af05997: [ObjC] Add some additional test cases around pointer conversions. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D67982?vs=221586=225439#toc Repository: rG

r375124 - [ObjC] Add some additional test cases around pointer conversions.

Author: jyknight Date: Thu Oct 17 08:18:59 2019 New Revision: 375124 URL: http://llvm.org/viewvc/llvm-project?rev=375124=rev Log: [ObjC] Add some additional test cases around pointer conversions. This is especially important for Objective-C++, which is entirely missing this testing at the

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet updated this revision to Diff 225435. gchatelet marked 13 inline comments as done. gchatelet added a comment. Herald added subscribers: s.egerton, simoncook, aheejin, dschuff. - Address comments - Fix missing rename - Address comments - Add warning category Repository: rG LLVM

[PATCH] D68028: [clang] Add no_builtin attribute

gchatelet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:3600 "attribute">; +def err_attribute_no_builtin_invalid_builtin_name : Error< + "'%0' is not a valid builtin name for %1">; aaron.ballman wrote: > I think this

r375119 - [OPENMP]Fix thread id passed to outlined region in sequential parallel

Author: abataev Date: Thu Oct 17 07:36:43 2019 New Revision: 375119 URL: http://llvm.org/viewvc/llvm-project?rev=375119=rev Log: [OPENMP]Fix thread id passed to outlined region in sequential parallel regions. The real global thread id must be passed to the outlined region instead of the zero

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:2280 } -EXPECT_THAT(Names, UnorderedElementsAreArray(C.ExpectedDecls)); +EXPECT_THAT(Names, UnorderedElementsAreArray(C.ExpectedDecls)) +<< File.code();

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein updated this revision to Diff 225428. hokein marked 7 inline comments as done. hokein added a comment. address remaining nits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977/new/ https://reviews.llvm.org/D68977 Files:

[PATCH] D68403: [OpenCL] PR43145: preserve addrspace for class accesses

This revision was automatically updated to reflect the committed changes. Closed by commit rGaf6248cbb9e7: [OpenCL] Preserve addrspace in CGClass (PR43145) (authored by svenvh). Changed prior to commit: https://reviews.llvm.org/D68403?vs=223037=225426#toc Repository: rG LLVM Github Monorepo

[PATCH] D68981: [clangd] Use our own relation kind.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc8e3f43ab514: [clangd] Use our own relation kind. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68981/new/

[PATCH] D69043: [RFC] Adding time-trace to LLD?

aganea added inline comments. Comment at: lld/ELF/Driver.cpp:515 + + if (llvm::timeTraceProfilerEnabled()) { +SmallString<128> path(config->outputFile); Could you possibly move this block (and the init block above) into a new file in `lld/Common/` so we

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:415 Optional refInDecl(const Decl *D) { struct Visitor : ConstDeclVisitor { ilya-biryukov wrote: > kadircet wrote: > > ilya-biryukov wrote: > > > hokein wrote: > > > >

r375118 - [OpenCL] Preserve addrspace in CGClass (PR43145)

Author: svenvh Date: Thu Oct 17 07:12:51 2019 New Revision: 375118 URL: http://llvm.org/viewvc/llvm-project?rev=375118=rev Log: [OpenCL] Preserve addrspace in CGClass (PR43145) PR43145 revealed two places where Clang was attempting to create a bitcast without considering the address space of

[clang-tools-extra] r375117 - [clangd] Use our own relation kind.

Author: hokein Date: Thu Oct 17 07:08:28 2019 New Revision: 375117 URL: http://llvm.org/viewvc/llvm-project?rev=375117=rev Log: [clangd] Use our own relation kind. Summary: Move the RelationKind from Serialization.h to Relation.h. This patch doesn't introduce any breaking changes. Reviewers:

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

hans added a comment. > I can't wait for @hans next Windows Snapshot, this is my gate for rolling > into our builds and CI system, after that, I'm gonna catch every single > person who tries to build/check in unclang-formatted. As it happens, there's a new snapshot out today :-) Repository:

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

ilya-biryukov added a comment. Mostly NITs from my side, the change LG, thanks! Comment at: clang-tools-extra/clangd/FindTarget.cpp:422 + // "using namespace" declaration doesn't have a name. + Refs.push_back({D->getQualifierLoc(), +

[PATCH] D68346: [clang-format] Add new option to add spaces around conditions

mitchell-stellar accepted this revision. mitchell-stellar added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68346/new/ https://reviews.llvm.org/D68346 ___ cfe-commits mailing list

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

Typz added a comment. This actually depends on another Diff : https://reviews.llvm.org/D32478 That other change introduces the ability to "unindent operator", which is required here; however, it also changes AlignOperands to have more than 2 modes, which does not seem to be acceptable. Before

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein updated this revision to Diff 225420. hokein marked 6 inline comments as done. hokein added a comment. address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68977/new/ https://reviews.llvm.org/D68977 Files:

[PATCH] D68977: [clangd] Report declaration references in findExplicitReferences.

hokein added inline comments. Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:850 + "1: targets = {Foo::Foo}, decl\n" + "2: targets = {Foo::~Foo}, decl\n" + "3: targets = {Foo}\n" ilya-biryukov wrote: > Could we

[PATCH] D69043: [RFC] Adding time-trace to LLD?

russell.gallop added a comment. In D69043#1712542 , @ruiu wrote: > This seems useful. Can I see an example output? Thanks. Here's an example from Building clang with ThinLTO: F10296420: clang-10.json Using linker

[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

luismarques added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVSubtarget.h:97 RISCVABI::ABI getTargetABI() const { return TargetABI; } + bool isRegisterReservedByUser(size_t i) const { +return UserReservedRegister[i]; This should take a

  1   2   >