[PATCH] D69391: Add #pragma clang loop ivdep

xbolva00 added a comment. "#pragma ivdep" should work too (compatibiluty mode with intel, gcc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69391/new/ https://reviews.llvm.org/D69391 ___ cfe-commits

[PATCH] D69391: Add #pragma clang loop ivdep

YashasAndaluri updated this revision to Diff 226375. YashasAndaluri added a comment. Updated the diff to show context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69391/new/ https://reviews.llvm.org/D69391 Files:

[clang] 45787e5 - Fix compilation warning. NFC.

Author: Michael Liao Date: 2019-10-25T01:06:52-04:00 New Revision: 45787e56829f47e45d127882b1cd1821e7022e68 URL: https://github.com/llvm/llvm-project/commit/45787e56829f47e45d127882b1cd1821e7022e68 DIFF: https://github.com/llvm/llvm-project/commit/45787e56829f47e45d127882b1cd1821e7022e68.diff

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:139 +// that constructor. FIXME(nridge): this should probably be handled in +// targetDecl() itself. +const CXXConstructorDecl *findCalledConstructor(const

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:147 } + while ((N = N->Parent)) { +if (N->ASTNode.get() || N->ASTNode.get() || sammccall wrote: > nridge wrote: > > This part is a super

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

nridge updated this revision to Diff 226372. nridge marked 4 inline comments as done. nridge added a comment. Removed constructor handling, deferring that to a follow-up Addressed other comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a48678a6a16: [hip] Allow the declaration of functions with variadic arguments in HIP. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5a48678 - [hip] Allow the declaration of functions with variadic arguments in HIP.

Author: Michael Liao Date: 2019-10-25T00:39:24-04:00 New Revision: 5a48678a6a1619fada23641a68c2d95ee57806b1 URL: https://github.com/llvm/llvm-project/commit/5a48678a6a1619fada23641a68c2d95ee57806b1 DIFF: https://github.com/llvm/llvm-project/commit/5a48678a6a1619fada23641a68c2d95ee57806b1.diff

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song added a comment. @probinson Thanks for the input! That is my concern too mixing the user defined and language defined may not be a good idea and may actually cause confusion. This is exactly this RFC for. Let us try a different dwarf encoding and then we can continue to discuss.

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

ast added a comment. > The address spaces envisioned by the Linux kernel appear to be more > informational and not descriptive of hardware characteristics. From the kernel pov the `__user` and normal are two different address spaces that must be accessed via different kernel primitives. User

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

probinson added a comment. The DW_AT_address_class attribute is intended to be used for target architectures where a simple address value is ambiguous, and the debugger needs additional information to resolve the ambiguity. The canonical example is something like i386 with its segmented

[clang] 7af309a - [clang][DependencyScanning] clang-format.

Author: Michael Spencer Date: 2019-10-24T18:28:01-07:00 New Revision: 7af309a4ed1a105315a39af3c77da3a8912b8685 URL: https://github.com/llvm/llvm-project/commit/7af309a4ed1a105315a39af3c77da3a8912b8685 DIFF:

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese created this revision. Bigcheese added reviewers: arphaman, kousikk. Bigcheese added a project: clang. Herald added subscribers: tschuett, dexonsmith, mgrang, mgorny. This adds experimental support for extracting a Clang module dependency graph from a compilation database. The output

[clang] ef7a154 - [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

Author: Yuanfang Chen Date: 2019-10-24T16:54:45-07:00 New Revision: ef7a154d17f2e38ba3c8bfa33f240b60464e4cc7 URL: https://github.com/llvm/llvm-project/commit/ef7a154d17f2e38ba3c8bfa33f240b60464e4cc7 DIFF: https://github.com/llvm/llvm-project/commit/ef7a154d17f2e38ba3c8bfa33f240b60464e4cc7.diff

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

This revision was automatically updated to reflect the committed changes. Closed by commit rGef7a154d17f2: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver… (authored by ychen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/

[PATCH] D69297: [ARM][AArch64] Implement __arm_rsrf, __arm_rsrf64, __arm_wsrf & __arm_wsrf64

efriedma added a comment. We have __builtin_bit_cast now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69297/new/ https://reviews.llvm.org/D69297 ___ cfe-commits mailing list

Re: r374288 - Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)"

Reverted in 6d424a161bf3e52730371da0b9439ed93a8ce406 due to the issue described here. Should hopefully be a trivial fix forward. On Tue, Oct 22, 2019 at 2:46 PM Michael Kruse wrote: > Am Mo., 21. Okt. 2019 um 23:44 Uhr schrieb Jordan Rupprecht > : > > At any rate, it sounds like this is not a

[clang] 6d424a1 - Revert "Recommit "[Clang] Pragma vectorize_width() implies vectorize(enable)""

Author: Jordan Rupprecht Date: 2019-10-24T16:35:45-07:00 New Revision: 6d424a161bf3e52730371da0b9439ed93a8ce406 URL: https://github.com/llvm/llvm-project/commit/6d424a161bf3e52730371da0b9439ed93a8ce406 DIFF:

[clang] 7fff716 - [CMake] Update Fuchsia build configuration

Author: Petr Hosek Date: 2019-10-24T16:35:29-07:00 New Revision: 7fff716ec4741f84358a977ddf0cd5ccf448d5c5 URL: https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5 DIFF: https://github.com/llvm/llvm-project/commit/7fff716ec4741f84358a977ddf0cd5ccf448d5c5.diff

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek created this revision. phosek added a reviewer: leonardchan. Herald added subscribers: cfe-commits, aprantl, mgorny. Herald added a project: clang. phosek updated this revision to Diff 226355. leonardchan accepted this revision. This revision is now accepted and ready to land. This

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 

stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of `clang-tools-extra/clang-tidy/add_new_check.py`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69414/new/

[PATCH] D69415: [CMake] Update Fuchsia build configuration

This revision was automatically updated to reflect the committed changes. Closed by commit rG7fff716ec474: [CMake] Update Fuchsia build configuration (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/

[PATCH] D69415: [CMake] Update Fuchsia build configuration

phosek updated this revision to Diff 226355. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69415/new/ https://reviews.llvm.org/D69415 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake

[PATCH] D69414: [clang-tidy] Regenerate clang-tidy check list 

stephanemoore created this revision. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. stephanemoore added a reviewer: aaron.ballman. stephanemoore added a comment. Please let me know if there are any corrections that are required to the output of

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9ab6d8236b17: [clang-scan-deps] Add basic support for modules. (authored by Bigcheese). Changed prior to commit: https://reviews.llvm.org/D68835?vs=225311=226352#toc Repository: rG LLVM Github

[clang] 9ab6d82 - [clang-scan-deps] Add basic support for modules.

Author: Michael Spencer Date: 2019-10-24T16:19:11-07:00 New Revision: 9ab6d8236b176bf9dd43741f4d874a8afebed99c URL: https://github.com/llvm/llvm-project/commit/9ab6d8236b176bf9dd43741f4d874a8afebed99c DIFF:

[PATCH] D69322: [hip][cuda] Enable extended lambda support on Windows.

rjmccall added a comment. Please don't ping for review after a single day. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69322/new/ https://reviews.llvm.org/D69322 ___ cfe-commits mailing list

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

rjmccall resigned from this revision. rjmccall added a comment. Despite generally knowing about coroutines and generally knowing about Clang, I actually don't know the Clang coroutine code and can't review this properly. Repository: rC Clang CHANGES SINCE LAST ACTION

[clang] 9671d1d - [clang]Fixup clang -Werror, , -Wcovered-switch-default build failures

Author: Jinsong Ji Date: 2019-10-24T22:49:17Z New Revision: 9671d1dc1764701824913ecca2b76ab17c33c29e URL: https://github.com/llvm/llvm-project/commit/9671d1dc1764701824913ecca2b76ab17c33c29e DIFF: https://github.com/llvm/llvm-project/commit/9671d1dc1764701824913ecca2b76ab17c33c29e.diff LOG:

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen updated this revision to Diff 226347. ychen added a comment. Address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406 Files: clang/include/clang/Driver/CC1Options.td

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

> On Oct 24, 2019, at 3:02 PM, David Blaikie via Phabricator > wrote: > > dblaikie added a comment. > > In D67723#1720509 , @aprantl wrote: > >> In D67723#1720353 , @rnk wrote: >> >>> In D67723#1717468

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

tejohnson added a comment. Thanks. Prefer the old name since it is already in use and since this is for the "thin link" phase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69406/new/ https://reviews.llvm.org/D69406

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. In D67508#1720228 , @khchen wrote: > But there is some issue if we set the default rv32 march as `rv32gc`. > Because the default multilib does not include `rv32gc`/`lp32d` in riscv gnu > toolchain, >

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

dblaikie added a comment. In D67723#1720509 , @aprantl wrote: > In D67723#1720353 , @rnk wrote: > > > In D67723#1717468 , @aprantl wrote: > > > > > I agree that it would

[clang] 70f59b5 - When diagnosing an ambiguity, only note the candidates that contribute

Author: Richard Smith Date: 2019-10-24T14:58:29-07:00 New Revision: 70f59b5bbc84d195b4c7ee1597dcae4e73d3c479 URL: https://github.com/llvm/llvm-project/commit/70f59b5bbc84d195b4c7ee1597dcae4e73d3c479 DIFF: https://github.com/llvm/llvm-project/commit/70f59b5bbc84d195b4c7ee1597dcae4e73d3c479.diff

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. tldr: my LGTM still stands. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67723/new/ https://reviews.llvm.org/D67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

aprantl added a comment. In D67723#1720353 , @rnk wrote: > In D67723#1717468 , @aprantl wrote: > > > I agree that it would make sense to have a > > `-ginline-info-threshold=<#insns>` or

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

probinson added a comment. > These experiments are convincing me that, in general, line zero isn't that > helpful for DWARF consumers. If the goal is to get smooth stepping, we may > want to refocus on getting reliable is_stmt bits in the line table. If you mean, it's not useful for

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Perhaps we should rename `-fcuda-allow-variadic-functions` to `-fgpu-allow-variadic-functions` after this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D41569: [Concepts] Constraint enforcement and diagnostics

saar.raz closed this revision. saar.raz added a comment. Committed ffa214ef22892d75340dc6720271863901dc2c90 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D41569/new/

[clang] ffa214e - [Concepts] Constraint Enforcement & Diagnostics

Author: Saar Raz Date: 2019-10-25T00:19:51+03:00 New Revision: ffa214ef22892d75340dc6720271863901dc2c90 URL: https://github.com/llvm/llvm-project/commit/ffa214ef22892d75340dc6720271863901dc2c90 DIFF: https://github.com/llvm/llvm-project/commit/ffa214ef22892d75340dc6720271863901dc2c90.diff

[PATCH] D69406: [clang][ThinLTO] Promote cc1 -fthin_link_bitcode to driver -fthinlto_link_bitcode

ychen created this revision. ychen added reviewers: tejohnson, steven_wu. Herald added subscribers: cfe-commits, dexonsmith, inglorion, mehdi_amini. Herald added a project: clang. A necessary step to let build system caching work for its output. I renamed it to match existing driver options for

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

ychen added a comment. Thank you @steven_wu @tejohnson. I created D69406 to promote the flag to the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69327/new/ https://reviews.llvm.org/D69327

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan added a comment. In D68340#1720362 , @Yi-Hong.Lyu wrote: > Seems this commit broke the buildbot > http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 @daltenty's patch rG201ed14aea8c

[clang] 201ed14 - Follow on to Namespace fixup for D68340

Author: David Tenty Date: 2019-10-24T17:01:17-04:00 New Revision: 201ed14aea8cd03e776dbe8484fa7de3ac94a3cf URL: https://github.com/llvm/llvm-project/commit/201ed14aea8cd03e776dbe8484fa7de3ac94a3cf DIFF: https://github.com/llvm/llvm-project/commit/201ed14aea8cd03e776dbe8484fa7de3ac94a3cf.diff

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. One other thought: Does the implementation in this diff care what type the reference type pointers are pointing to? It would be nice if we could enforce the use of an opaque pointee type to prevent the reference types from being dereferenced. Repository: rG LLVM

[PATCH] D66035: [WebAssembly] WIP: Add support for reference types

tlively added a comment. It would be great to see some test .ll files here so we can get a better understanding for what is implemented here. I would also like to see tests of what happens if you try to do a `ptrtoint` or some other illegal operation on a reference type.

[PATCH] D69404: [clang-format] [NFC] update the documentation in Format.h to allow dump_format_style.py to get a little closer to being correct.

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, owenpan. MyDeveloperDay added projects: clang-format, clang. Running dump_format_style.py on the tip of the trunk causes ClangFormatStyleOptions.rst to have changes, which I think ideally it

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

gribozavr added a comment. Looks reasonable to me. The duplication is unfortunate, but it is reasonable while we have two binaries. However, you could explore reading the command line flags for HandleCXX in LLVMFuzzerInitialize from fuzzer's command line flags. Repository: rG LLVM Github

[clang] 126a72f - Fix MSVC "not all control paths return a value" warnings. NFCI.

Author: Simon Pilgrim Date: 2019-10-24T13:40:13-07:00 New Revision: 126a72fcbf7e5e4d958d3804033710c0a4efbe39 URL: https://github.com/llvm/llvm-project/commit/126a72fcbf7e5e4d958d3804033710c0a4efbe39 DIFF: https://github.com/llvm/llvm-project/commit/126a72fcbf7e5e4d958d3804033710c0a4efbe39.diff

[PATCH] D69363: [www] Change URLs to HTTPS.

STL_MSFT closed this revision. STL_MSFT added a comment. Committed: https://github.com/llvm/llvm-project/commit/2e4f1e112dfee1d16c138d42f2bc7ee639f9ae05 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69363/new/ https://reviews.llvm.org/D69363

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

stevewan accepted this revision. stevewan added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/ https://reviews.llvm.org/D69356

[PATCH] D67541: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

MyDeveloperDay added a comment. ClangFormatStyleOptions.rst and Format.h are inconsistent which means when clang/doc/tools/dump_format_style.py is run the rst file being generated is in danger of overwriting your changes (which I think you might have made by hand). I'm happy to try and fix

[PATCH] D68340: Add AIX toolchain and basic linker functionality

Yi-Hong.Lyu added a comment. Seems this commit broke the buildbot http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6806 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340

[PATCH] D69356: [NFC] Rename LLVM_NO_DEAD_STRIP

daltenty updated this revision to Diff 226319. daltenty added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Address comments round 1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69356/new/

[PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

rnk added a comment. In D67723#1717468 , @aprantl wrote: > I agree that it would make sense to have a `-ginline-info-threshold=<#insns>` > or `-gno-small-inline-functions` with a hardcoded threshold to implement the > feature Paul described, and this

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || lenary wrote: > rogfer01 wrote: > > `llvm::StringSwitch` has a method

[PATCH] D31574: [clang-format] update documentation

This revision was automatically updated to reflect the committed changes. Closed by commit rG23b78364150c: [clang-format] update documentation (authored by MyDeveloperDay). Changed prior to commit: https://reviews.llvm.org/D31574?vs=223443=226316#toc Repository: rG LLVM Github Monorepo

[clang] 23b7836 - [clang-format] update documentation

Author: paulhoad Date: 2019-10-24T21:10:13+01:00 New Revision: 23b78364150cd946a8b111e87defdf179eecbc8f URL: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f DIFF: https://github.com/llvm/llvm-project/commit/23b78364150cd946a8b111e87defdf179eecbc8f.diff

[PATCH] D31574: [clang-format] update documentation

MyDeveloperDay added a comment. When I land this change, I'll include the ClangFormatStyleOptions.rst to match (plus some minor NFC) in Format.h that are preventing dump_format_style.py from being rerun in a later commit I'll try and bring the Format.h and ClangFormaatStyleOptions.rst back

[clang] 76ee21e - Namespace fixup for D68340 build on MSVC

Author: David Tenty Date: 2019-10-24T15:47:08-04:00 New Revision: 76ee21e1d09084288bbfee7f960ce0b9e4306d60 URL: https://github.com/llvm/llvm-project/commit/76ee21e1d09084288bbfee7f960ce0b9e4306d60 DIFF: https://github.com/llvm/llvm-project/commit/76ee21e1d09084288bbfee7f960ce0b9e4306d60.diff

[PATCH] D69181: [clang-tidy] Adding misc-signal-terminated-thread check

steakhal added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/BadSignalToKillThreadCheck.cpp:28 + +static Preprocessor *PP; + Can't we place this `PP` variable to the checker class? Like the [[

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

hliao marked an inline comment as done. hliao added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7764 + QualType Ty) const { + llvm_unreachable("AMDGPU does not support varargs"); +} tra wrote: >

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

tra added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:7764 + QualType Ty) const { + llvm_unreachable("AMDGPU does not support varargs"); +} llvm_unreachable() should be used to indicate an error in compiler's

[PATCH] D68914: [clang-format] Remove duplciate code from Invalid BOM detection

This revision was automatically updated to reflect the committed changes. Closed by commit rG8fa5e98fd191: [clang-format] Remove duplciate code from Invalid BOM detection (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 8fa5e98 - [clang-format] Remove duplciate code from Invalid BOM detection

Author: paulhoad Date: 2019-10-24T20:24:44+01:00 New Revision: 8fa5e98fd191d02fc7e0e220d74af267b9140e6a URL: https://github.com/llvm/llvm-project/commit/8fa5e98fd191d02fc7e0e220d74af267b9140e6a DIFF: https://github.com/llvm/llvm-project/commit/8fa5e98fd191d02fc7e0e220d74af267b9140e6a.diff

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

klimek added a comment. > since resource directory should be picked relative > to the path of the clang-compiler in the compilation command. The resource dir should be the resource dir that shipped with the clang source code that the *tool* was built with. We can think about the resource dir

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits added a comment. In D67787#1719251 , @vit9696 wrote: > A side note regarding SPE support. I am currently upgrading to LLVM 9.0 and I > discovered that this patch was not committed anyhow at all: > https://reviews.llvm.org/D54583#1444288 Yeah,

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. I've hopefully fixed the build in rG7b3de1e81197 , but it's hard to tell for sure with the other error. I also fixed the tests in rG78700ef8866d

[clang] 78700ef - [ARM] Fixup MVE intrinsic tests with no assert builds

Author: David Green Date: 2019-10-24T19:59:15+01:00 New Revision: 78700ef8866db7f5cea113fa81d810a28b5b7438 URL: https://github.com/llvm/llvm-project/commit/78700ef8866db7f5cea113fa81d810a28b5b7438 DIFF: https://github.com/llvm/llvm-project/commit/78700ef8866db7f5cea113fa81d810a28b5b7438.diff

[PATCH] D69145: Give readability-redundant-member-init an option IgnoreBaseInCopyConstructors to avoid breaking code with gcc -Werror=extra

poelmanc added a comment. What do @malcolm.parsons, @alexfh, @hokein, @aaron.ballman, @lebedev.ri think of @mgehre's suggestion to enable `IgnoreBaseInCopyConstructors` as the default setting, so gcc users won't experience build errors and think "clang-tidy broke my code!" I could go either

[clang] bb6a27f - Add AIX toolchain and basic linker functionality

Author: stevewan Date: 2019-10-24T14:47:57-04:00 New Revision: bb6a27fc257faac1339e79c20ae807db70a31ebd URL: https://github.com/llvm/llvm-project/commit/bb6a27fc257faac1339e79c20ae807db70a31ebd DIFF: https://github.com/llvm/llvm-project/commit/bb6a27fc257faac1339e79c20ae807db70a31ebd.diff

[PATCH] D68340: Add AIX toolchain and basic linker functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb6a27fc257f: Add AIX toolchain and basic linker functionality (authored by stevewan, committed by daltenty). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 7b3de1e - [ARM] Attempt to fixup MveEmitter warnings

Author: David Green Date: 2019-10-24T19:43:15+01:00 New Revision: 7b3de1e811972b874d91554642ccb2ef5b32eed6 URL: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6 DIFF: https://github.com/llvm/llvm-project/commit/7b3de1e811972b874d91554642ccb2ef5b32eed6.diff

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

dmgreen added a comment. Hmm.. Let me take a look. There's a different error on the same build now, but I think it's just hiding this one. I'll also try and fix the tests that are failing in places too, if I can. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:59 + + auto getCrt0Basename = [, ] { +// Enable gprofiling when "-pg" is specified. jasonliu wrote: > nit: There is no need to capture

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen added a comment. Herald added a subscriber: sameer.abuasal. @lenary You patch is very useful to look up the default march, thanks! But there is some issue if we set the default rv32 march as `rv32gc`. Because the default multilib does not include `rv32gc`/`lp32d` in riscv gnu

[PATCH] D68340: Add AIX toolchain and basic linker functionality

stevewan updated this revision to Diff 226304. stevewan added a comment. Capture local variable IsArch32Bit by value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68340/new/ https://reviews.llvm.org/D68340 Files:

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese added a reviewer: klimek. Bigcheese added a comment. I've added Manuel as a reviewer as this patch is also changing the tooling APIs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537 + if (Triple.getArch() == llvm::Triple::riscv32) +return "rv32gc"; else khchen wrote: > Why do you set rv32gc and rv64gc as

[PATCH] D68969: [clang-format] Remove the dependency on frontend

This revision was automatically updated to reflect the committed changes. MyDeveloperDay marked an inline comment as done. Closed by commit rGec66603ac7ea: [clang-format] Remove the dependency on frontend (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] ec66603 - [clang-format] Remove the dependency on frontend

Author: paulhoad Date: 2019-10-24T19:03:57+01:00 New Revision: ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b URL: https://github.com/llvm/llvm-project/commit/ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b DIFF: https://github.com/llvm/llvm-project/commit/ec66603ac7ea655be5c2c5f508c5bf0d5eaeb65b.diff

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

khchen added inline comments. Herald added a subscriber: sameer.abuasal. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:537 + if (Triple.getArch() == llvm::Triple::riscv32) +return "rv32gc"; else Why do you set rv32gc and rv64gc as default march?

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

merge_guards_bot added a comment. Build result: pass - 59630 tests passed, 0 failed and 763 were skipped. Log files: cmake-log.txt , ninja_check_all-log.txt

[PATCH] D68835: [clang-scan-deps] Add basic support for Clang modules.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. @Bigcheese I don't have time right now to do the build experiments, so I'll leave it as follow-up for me to resolve later. LGTM. CHANGES SINCE LAST ACTION

[PATCH] D69389: [hip] Allow the declaration of functions with variadic arguments in HIP.

hliao updated this revision to Diff 226301. hliao added a comment. revise commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69389/new/ https://reviews.llvm.org/D69389 Files: clang/lib/CodeGen/TargetInfo.cpp

[PATCH] D69388: [clang-tidy] Fix modernize-use-nodiscard check for classes marked as [[nodiscard]]

MyDeveloperDay added a comment. Thank you for the patch, I wrote this checker originally and this LGTM. I'm not sure if others have any objections to using "using clang::attr::WarnUnusedResult" in the body of the function, I couldn't see this pattern used elsewhere in clang-tidy, all I've

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov updated this revision to Diff 226293. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. - Use the same CodeCompletionContext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69382/new/

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

ilya-biryukov marked 3 inline comments as done. ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:463 + // Check all-scopes completions too. + Opts.AllScopes = true; + Results = completions(R"cpp(

[PATCH] D67161: [clang,ARM] Initial ACLE intrinsics for MVE.

Yi-Hong.Lyu added a comment. Seems this commit broke the build http://lab.llvm.org:8011/builders/ppc64le-lld-multistage-test/builds/6794/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67161/new/ https://reviews.llvm.org/D67161

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary marked an inline comment as done. lenary added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || rogfer01 wrote: >

[PATCH] D69382: [clangd] Do not insert parentheses when completing a using declaration

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:463 + // Check all-scopes completions too. + Opts.AllScopes = true; + Results = completions(R"cpp( I believe `AllScopes` and this feature is orthogonal what

[PATCH] D69393: [RFC][DebugInfo] emit user specified address_space in dwarf

yonghong-song created this revision. yonghong-song added reviewers: arsenm, aprantl, Anastasia, ast. yonghong-song added a project: debug-info. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. The RFC intends to kick off the discussion on how to support user defined

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

rogfer01 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:475 + +if (MArch.startswith_lower("rv32")) { + if (MArch.substr(4).contains_lower("d") || `llvm::StringSwitch` has a method `StartsWithLower` which might help make

[PATCH] D69391: Add #pragma clang loop ivdep

YashasAndaluri created this revision. YashasAndaluri added reviewers: hfinkel, Meinersbur, rscottmanley, DTharun. YashasAndaluri created this object with edit policy "Administrators". YashasAndaluri added a project: clang. Herald added subscribers: cfe-commits, zzheng. YashasAndaluri edited the

[PATCH] D69327: [Clang][ThinLTO] Add a cache for compile phase output.

steven_wu added a comment. `ccache` does not have the support for this, I am just saying that this can be easily implemented in `ccache` and that would be much better than the proposed solution here. If we need to add a clang driver flag so build system can better support to detect thin

[PATCH] D69389: [hip] Relax an allow the declaration of functions with variadic arguments in HIP.

hliao created this revision. hliao added reviewers: jlebar, tra, yaxunl. Herald added a project: clang. Herald added a subscriber: cfe-commits. - As variadic parameters have the lowest rank in overload resolution, without real usage of `va_arg`, they are commonly used as the catch-all fallbacks

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm marked 2 inline comments as done. peterwaller-arm added inline comments. Comment at: clang/test/Driver/flang/flang-not-installed.f90:11 +! shell syntax. +! UNSUPPORTED: windows + hfinkel wrote: > I believe that you can write: > > REQUIRES:

[PATCH] D63607: [clang][driver] Add basic --driver-mode=flang support for fortran

peterwaller-arm updated this revision to Diff 226270. peterwaller-arm added a comment. I have rebased the patch for conflicts to master and all the tests are passing. While doing so, I discovered that the test for flang-not-installed was not fit for purpose, because clang actually doesn't first

  1   2   >