[PATCH] D67787: Add 8548 CPU definition and attributes

2019-10-26 Thread Vitaly Cheptsov via Phabricator via cfe-commits
vit9696 added a comment. I noticed a typo in the file, but the rest looks good now. Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:61 .Case("a2q", "a2q") +.Case("8548", "e500") +.Case("e500", "e500") That looks like a typo to me.

[PATCH] D68117: [DWARF-5] Support for C++11 defaulted, deleted member functions.

2019-10-26 Thread Sourabh Singh Tomar via Phabricator via cfe-commits
SouraVX abandoned this revision. SouraVX added a comment. Will work on this later! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68117/new/ https://reviews.llvm.org/D68117 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

2019-10-26 Thread Mark de Wever via Phabricator via cfe-commits
Mordante updated this revision to Diff 226539. Mordante added a comment. Adds a test as requested by @xbolva00 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://reviews.llvm.org/D68912 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/test/SemaCXX/warn-ran

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

2019-10-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge marked an inline comment as done. nridge added a comment. So, to summarize my understanding of the way forward here: 1. Land the refactoring without any constructor targeting (i.e. the current patch, which is ready to review in this state). 2. In a follow-up patch: target constructor in c

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

2019-10-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 226561. nridge added a comment. Updated not to use the beginning-of-identifier location as input to SelectionTree Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69237/new/ https://reviews.llvm.org/D69237 Files:

[PATCH] D69237: Refactor getDeclAtPosition() to use SelectionTree + targetDecl()

2019-10-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. In D69237#1722399 , @nridge wrote: > So, to summarize my understanding of the way forward here: > > 1. Land the refactoring without any constructor targeting (i.e. the current > patch, which is ready to review in this state). > 2.

[PATCH] D67536: [WIP] [clangd] Add support for an inactive regions notification

2019-10-26 Thread Nathan Ridge via Phabricator via cfe-commits
nridge updated this revision to Diff 226563. nridge added a comment. Addressed nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67536/new/ https://reviews.llvm.org/D67536 Files: clang-tools-extra/clangd/ParsedAST.cpp clang-tools-extra/clangd