[PATCH] D69786: [X86] Add support for -mvzeroupper and -mno-vzeroupper to match gcc.

craig.topper added a comment. In D69786#1731942 , @davezarzycki wrote: > Actually, wait, what does it mean for a CPU without AVX to have > `FeatureInsertVZEROUPPER`? Means we’ll do vzeroupper insertion if you add -mavx to the command line and ymm is

[PATCH] D69786: [X86] Add support for -mvzeroupper and -mno-vzeroupper to match gcc.

davezarzycki added a comment. Actually, wait, what does it mean for a CPU without AVX to have `FeatureInsertVZEROUPPER`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69786/new/ https://reviews.llvm.org/D69786

[PATCH] D69786: [X86] Add support for -mvzeroupper and -mno-vzeroupper to match gcc.

davezarzycki accepted this revision. davezarzycki added a comment. This revision is now accepted and ready to land. LGTM. Thanks! I'll close my differential proposal then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69786/new/

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

lebedev.ri added inline comments. Comment at: clang/lib/Format/Format.cpp:768 LLVMStyle.CommentPragmas = "^ IWYU pragma:"; + LLVMStyle.ConstStyle = FormatStyle::CS_Leave; LLVMStyle.CompactNamespaces = false; Based on code reviews, this should be

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert marked 5 inline comments as done. jdoerfert added inline comments. Comment at: clang/include/clang/Basic/OpenMPKinds.h:29 - OMPD_unknown + OMPD_unknown, }; These changes do not impact Clang nor do they remove functionality (if OPENMP_DIRECTIVE is

[PATCH] D69785: [OpenMP] Introduce the OpenMP-IR-Builder

jdoerfert created this revision. jdoerfert added reviewers: kiranchandramohan, ABataev, RaviNarayanaswamy, gtbercea, grokos, sdmitriev, JonChesterfield, hfinkel, fghanim. Herald added subscribers: cfe-commits, jfb, guansong, bollu, hiraditya, mgorny. Herald added projects: clang, LLVM. This is

[PATCH] D69786: [X86] Add support for -mvzeroupper and -mno-vzeroupper to match gcc.

craig.topper created this revision. craig.topper added reviewers: RKSimon, spatel. Herald added subscribers: cfe-commits, jfb, hiraditya. Herald added projects: clang, LLVM. craig.topper added a reviewer: davezarzycki. -mvzeroupper will force the vzeroupper insertion pass to run on CPUs that

[PATCH] D68885: Add a Ranges field to Diagnostic struct

compositeprimes marked 3 inline comments as done. compositeprimes added a comment. Sorry for the delay; I got caught up in some other work. I moved this to https://reviews.llvm.org/D69782 using arc diff. @gribozavr: I'm not sure how to merge this with the other commit, because it's in

[PATCH] D69782: Summary: Instead of dropping all the ranges associated with a Diagnostic when converting them to a ClangTidy error, instead attach them to the ClangTidyError, so they can be consumed b

compositeprimes created this revision. compositeprimes added reviewers: gribozavr, alexfh. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D69782 Files: include/clang/Tooling/Core/Diagnostic.h

[PATCH] D58497: Clear the KnownModules cache if the preprocessor is going away

dexonsmith abandoned this revision. dexonsmith added a comment. I just pushed 31e14f41a21f9016050a20f07d5da03db2e8c13e , which moves KnownModules into ModuleMap as an alternative. In D58497#1648134

[PATCH] D69498: IR: Invert convergent attribute handling

rjmccall added a comment. In D69498#1731265 , @mehdi_amini wrote: > In D69498#1727650 , @dexonsmith > wrote: > > > In D69498#1723606 , @rjmccall > > wrote: > > > > >

[clang] 31e14f4 - clang/Modules: Sink CompilerInstance::KnownModules into ModuleMap

Author: Duncan P. N. Exon Smith Date: 2019-11-03T19:57:33-08:00 New Revision: 31e14f41a21f9016050a20f07d5da03db2e8c13e URL: https://github.com/llvm/llvm-project/commit/31e14f41a21f9016050a20f07d5da03db2e8c13e DIFF:

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 227643. wwagner19 added a comment. Herald added a subscriber: usaxena95. Unfortunately, I had to take a bit of a hiatus there, but i'm back a few months later with an updated patch incorporating all of @sammccall 's feedback! Notably, - Windows paths are

[PATCH] D69781: [analyzer] Add test directory for scan-build

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Woohoo, that's much more tests than i made in D55683 ! Let's hope it works on Windows :/ Comment at:

[PATCH] D55683: [analyzer] Tests for scan-build?

NoQ abandoned this revision. NoQ added a comment. Outdated by D69781 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55683/new/ https://reviews.llvm.org/D55683 ___ cfe-commits

[PATCH] D69770: Add recoverable string parsing errors to APFloat

arsenm added inline comments. Comment at: llvm/lib/Support/APFloat.cpp:273 + if (p != end) +return createError("Invalid exponent in exponent"); Error message sounds like nonsense Comment at: llvm/unittests/ADT/APFloatTest.cpp:1322 +

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso updated this revision to Diff 227640. Charusso marked 2 inline comments as done. Charusso added a comment. - Remove `llvm_unreacheable` from error-handling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69746/new/ https://reviews.llvm.org/D69746 Files:

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

Charusso added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:152 + + if (llvm::Error Err = Repls.add(Repl)) +llvm_unreachable("An error occured during fix-it replacements"); zinovy.nis wrote: > Isn't

[PATCH] D69781: [analyzer] Add test directory for scan-build

dcoughlin created this revision. dcoughlin added a reviewer: NoQ. Herald added subscribers: llvm-commits, cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, delcypher, szepet, baloghadamsoftware, xazax.hun. Herald added projects: clang, LLVM. The static analyzer's

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay added a comment. A demo of `clang-format -i --const-style=east *.cpp *.h` being run on clang/lib/Format can be see here D69780: [clang-format] DO NOT COMMIT - Demo of East/West Const Fixer on clang-format CHANGES SINCE LAST ACTION

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay updated this revision to Diff 227637. MyDeveloperDay added a comment. Support for template object const type declarations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D69764 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D57829: [CUDA][HIP] Disable emitting llvm.linker.options in device compilation

yaxunl updated this revision to Diff 227636. yaxunl added a comment. revised by Artem's comments. Also fix test since linker option only supported on windows. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57829/new/ https://reviews.llvm.org/D57829 Files:

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak created this revision. llunak added a reviewer: dblaikie. llunak added a project: clang. Herald added a subscriber: cfe-commits. See the test for a testcase. If a header contains 'extern template', then the template should be provided somewhere by an explicit instantiation, so it is not

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak created this revision. llunak added a reviewer: dblaikie. llunak added a project: clang. Herald added a subscriber: cfe-commits. This patch allows to build PCH's (with -building-pch-with-obj and the extra .o file) with -fmodules-codegen -fmodules-debuginfo to allow emitting shared code

[PATCH] D69770: Add recoverable string parsing errors to APFloat

ekatz created this revision. ekatz added reviewers: chandlerc, lattner, rsmith. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, hiraditya, nhaehnle, jvesely, arsenm. Herald added projects: clang, LLVM. Implementing the APFloat part in PR4745. Repository: rG LLVM Github

[PATCH] D69769: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 created this revision. Herald added subscribers: cfe-commits, mstorsjo. Herald added a project: clang. Besides the Mingw toolchain, there is also the CrossWindows toolchain, which means GNU-style cli but genuine windows headers + libraries. LLD's MinGW driver is as good a fit as

[PATCH] D69756: [opaque pointer types] Add element type argument to IRBuilder CreatePreserveStructAccessIndex and CreatePreserveArrayAccessIndex

This revision was automatically updated to reflect the committed changes. Closed by commit rG910718bd038c: [opaque pointer types] Add element type argument to IRBuilder… (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 910718b - [opaque pointer types] Add element type argument to IRBuilder CreatePreserveStructAccessIndex and CreatePreserveArrayAccessIndex

Author: Craig Topper Date: 2019-11-03T10:27:18-08:00 New Revision: 910718bd038cdac1671069594a11f6b26bad9c8b URL: https://github.com/llvm/llvm-project/commit/910718bd038cdac1671069594a11f6b26bad9c8b DIFF: https://github.com/llvm/llvm-project/commit/910718bd038cdac1671069594a11f6b26bad9c8b.diff

[PATCH] D69760: [Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc

Ericson2314 updated this revision to Diff 227621. Ericson2314 retitled this revision from "Better clang cross windows with gnu-style flags" to "Clang][Driver] Don't pun -fuse-ld=lld as -fuse-ld=lld-link with msvc". Ericson2314 edited the summary of this revision. Ericson2314 added a comment.

[PATCH] D55326: [Driver] Fix incorrect GNU triplet for PowerPC on SUSE Linux

aaronpuchert added a comment. @jrtc27, @nemanjai: Could you have a look again? I think I answered all your questions and wrote a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55326/new/ https://reviews.llvm.org/D55326

[PATCH] D69766: [Clang][MSVC] Use GetLinkerPath like the other toolchains for consistency

Ericson2314 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69766 Files: clang/lib/Driver/ToolChains/MSVC.cpp Index: clang/lib/Driver/ToolChains/MSVC.cpp

[PATCH] D69764: [clang-format] Add East Const / West Const fixer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: klimek, mitchell-stellar, sammccall, owenpan, krasimir. MyDeveloperDay added a project: clang-format. Herald added a subscriber: mgorny. Herald added a project: clang. Developers these days seem to argue over east vs west

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 updated this revision to Diff 227611. xbolva00 added a comment. Up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td Index:

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 added a comment. I will update tests after we decide on final text. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 ___ cfe-commits mailing list

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

Ericson2314 created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. No idea why these are still here. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69763 Files: clang/test/Driver/windows-cross.c Index:

[PATCH] D69762: [LegacyPassManager] Fixed "null check after derefencing" warning

xbolva00 created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mehdi_amini. Herald added projects: clang, LLVM. The 'RequiredPass' pointer was utilized before it was verified against nullptr. Check lines: 1626, 1629. [Diagnostics] Try to improve warning message

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen updated this revision to Diff 227606. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 Files: clang/lib/Driver/ToolChains/Gnu.cpp clang/lib/Driver/ToolChains/RISCVToolchain.cpp

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

zinovy.nis added inline comments. Comment at: clang/lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:152 + + if (llvm::Error Err = Repls.add(Repl)) +llvm_unreachable("An error occured during fix-it replacements"); Isn't `llvm_unreacheable`

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

kristof.beyls added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + rsmith wrote: > efriedma wrote: > > kristof.beyls wrote: > > > efriedma wrote: > >

[clang] c96428d - Drop spurious self-include [NFC]

Author: Aaron Puchert Date: 2019-11-03T14:29:59+01:00 New Revision: c96428d2184fe2329e625f6a0dc04daa02ee42c9 URL: https://github.com/llvm/llvm-project/commit/c96428d2184fe2329e625f6a0dc04daa02ee42c9 DIFF: https://github.com/llvm/llvm-project/commit/c96428d2184fe2329e625f6a0dc04daa02ee42c9.diff

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie updated this revision to Diff 227605. jdoerrie marked 4 inline comments as done. jdoerrie added a comment. Addressed Marshall's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69520/new/ https://reviews.llvm.org/D69520 Files: libcxx/include/span

[PATCH] D69520: [libc++] Disallow dynamic -> static span conversions

jdoerrie added inline comments. Comment at: libcxx/test/std/containers/views/span.cons/span.fail.cpp:78 - -// Try to remove const and/or volatile (static -> static) -{ mclow.lists wrote: > Ok. The comment here is wrong; this is testing dynamic -> static. >

[PATCH] D32164: [clang-tidy] misc-misplaced-widening-cast: Disable checking of implicit widening casts by default

lebedev.ri added a comment. Herald added subscribers: llvm-commits, gamesh411, Szelethus, rnkovacs. Herald added a project: LLVM. The doc wasn't updated :/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D32164/new/ https://reviews.llvm.org/D32164

[PATCH] D69760: [LLD][MinGW] Support --allow-multiple-definition

Ericson2314 created this revision. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo. Herald added projects: clang, LLVM. We want the Clang CrossWindows toolchain to work with ld.lld and ld.bfd alike, and it uses this, so we need to support this. [Clang][Test]: Remaining "lld-link2"