[clang] 092577e - [cxx_status] Update with Belfast motions.

Author: Richard Smith Date: 2019-11-09T03:13:21-08:00 New Revision: 092577e317229df600539f678064f321737a761b URL: https://github.com/llvm/llvm-project/commit/092577e317229df600539f678064f321737a761b DIFF: https://github.com/llvm/llvm-project/commit/092577e317229df600539f678064f321737a761b.diff

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D69762#1739022 , @xbolva00 wrote: > We cannot use it for block; it is a hard error. Corountine and function can > be merged as suggest

[PATCH] D67460: clang-tidy: modernize-use-using work with multi-argument templates

aaron.ballman added a comment. In D67460#1739062 , @poelmanc wrote: > Thanks @aaron.ballman, I don't have commit access so will someone else commit > this? I can commit it for you when I get back into the office mid-next week, unless someone else wants

[clang] 56b5eab - [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.

Author: Richard Smith Date: 2019-11-09T05:56:51-08:00 New Revision: 56b5eab12970e540c629e9b9a8a95256c116a547 URL: https://github.com/llvm/llvm-project/commit/56b5eab12970e540c629e9b9a8a95256c116a547 DIFF: https://github.com/llvm/llvm-project/commit/56b5eab12970e540c629e9b9a8a95256c116a547.diff

[PATCH] D69792: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning.

This revision was automatically updated to reflect the committed changes. Closed by commit rG56b5eab12970: [NFC] Supress GCC "Bitfield too small to hold all values of enum" warning. (authored by rsmith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

This revision was automatically updated to reflect the committed changes. Closed by commit rGb9be5ce8f3e0: [Parser] Warn when ScopeDepthOrObjCQuals overflows (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63975/new/ https://re

[clang] b9be5ce - [Parser] Warn when ScopeDepthOrObjCQuals overflows

Author: Mark de Wever Date: 2019-11-09T15:33:01+01:00 New Revision: b9be5ce8f3e0e697a61ad16e2c669de6ea8f8739 URL: https://github.com/llvm/llvm-project/commit/b9be5ce8f3e0e697a61ad16e2c669de6ea8f8739 DIFF: https://github.com/llvm/llvm-project/commit/b9be5ce8f3e0e697a61ad16e2c669de6ea8f8739.diff

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6860 "lambda declared 'noreturn' should not return">; def warn_maybe_falloff_nonvoid_lambda : Warning< +"non-void lambda does not re

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6860 "lambda declared 'noreturn' should not return">; def warn_maybe_falloff_nonvoid_lambda : Warning< +"non-void lambda does not return a value in all control paths">, -

[clang] 4a5aa1a - [BPF] Add preserve_access_index attribute for record definition

Author: Yonghong Song Date: 2019-11-09T08:17:12-08:00 New Revision: 4a5aa1a7bf8b1714b817ede8e09cd28c0784228a URL: https://github.com/llvm/llvm-project/commit/4a5aa1a7bf8b1714b817ede8e09cd28c0784228a DIFF: https://github.com/llvm/llvm-project/commit/4a5aa1a7bf8b1714b817ede8e09cd28c0784228a.diff

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a5aa1a7bf8b: [BPF] Add preserve_access_index attribute for record definition (authored by yonghong-song). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6975

[clang] 9434360 - Revert "[BPF] Add preserve_access_index attribute for record definition"

Author: Yonghong Song Date: 2019-11-09T08:32:44-08:00 New Revision: 9434360401218ae02aaea1fbb53a42bc3af2bc76 URL: https://github.com/llvm/llvm-project/commit/9434360401218ae02aaea1fbb53a42bc3af2bc76 DIFF: https://github.com/llvm/llvm-project/commit/9434360401218ae02aaea1fbb53a42bc3af2bc76.diff

Re: [clang] 9434360 - Revert "[BPF] Add preserve_access_index attribute for record definition"

On Sat, Nov 9, 2019 at 11:33 AM Yonghong Song via cfe-commits wrote: > > > Author: Yonghong Song > Date: 2019-11-09T08:32:44-08:00 > New Revision: 9434360401218ae02aaea1fbb53a42bc3af2bc76 > > URL: > https://github.com/llvm/llvm-project/commit/9434360401218ae02aaea1fbb53a42bc3af2bc76 > DIFF: > ht

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

aaron.ballman added a comment. This is missing a bunch of C++ tests that show what happens in the case of inheritance, template instantiations, etc. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:10068 "__builtin_preserve_field_info argument %0 not a constant"

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. Thanks, @aaron.ballman, I will fix the issue and address all you comments. I will re-open this commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.org/D69759 _

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

xbolva00 updated this revision to Diff 228578. xbolva00 added a comment. Herald added a subscriber: arphaman. Added FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/ https://reviews.llvm.org/D69762 Files: clang/include/clang/Basic/

[PATCH] D69935: [DeclCXX] Remove unknown external linkage specifications

ekatz added a comment. No problem. For the source code: extern "C++11" int x; In clang 9.0 the compilation fails with the message: :1:8: error: unknown linkage language extern "C++11" int x; ^~~ 1 error generated. while on the trunk it just pass without any error. Reposi

[PATCH] D69762: [Diagnostics] Try to improve warning message for -Wreturn-type

This revision was automatically updated to reflect the committed changes. Closed by commit rG1da13237a41a: [Diagnostics] Try to improve warning message for -Wreturn-type (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69762/new/

[PATCH] D68912: Adds -Wrange-loop-analysis to -Wall

Mordante added a comment. In D68912#1737559 , @xbolva00 wrote: > Formally unblocking this Thanks. I'll first want to reduce the number of warnings before committing this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68912/new/ https://

[PATCH] D70045: [AST] Use an explicit copy in a range-based for

Mordante created this revision. Mordante added reviewers: rsmith, aaron.ballman, xbolva00. Mordante added a project: clang. The AssociationIteratorTy type will be copied in a range-based for loop. Make the copy explicit to avoid the -Wrange-loop-analysis warning. This avoids new warnings due to D

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

Mordante created this revision. Mordante added reviewers: ABataev, aaron.ballman, xbolva00. Mordante added a project: clang. Herald added a subscriber: guansong. Herald added a reviewer: jdoerfert. The `std::pair>` type will be copied in a range-based for loop. Make the copy explicit to avoid the

[PATCH] D70047: [Analyzer] Use a reference in a range-based for

Mordante created this revision. Mordante added reviewers: dcoughlin, aaron.ballman, xbolva00. Mordante added a project: clang. Herald added subscribers: Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Let the checkers use a reference ins

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

ABataev added a comment. Why do we get the warnings with references? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70046/new/ https://reviews.llvm.org/D70046 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song updated this revision to Diff 228583. yonghong-song added a comment. The Decl "D" could be a nullptr in ProcessDeclAttributeDelayed, which will cause segfault. Handle this properly. Also addressed most of Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D70046: [OpenMP] Use an explicit copy in a range-based for

Mordante added a comment. `OMPMappableExprListClause::const_component_lists_iterator::operator*()` returns an object and not a reference to an object. -Wrange-loop-analysis warns to make it more visible the object is a copy and not a reference. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song updated this revision to Diff 228588. yonghong-song added a comment. use implicit attr to annotate records or fields not explicitly marked by users. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.org/D69

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song marked 2 inline comments as done. yonghong-song added a comment. Hi, @aaron.ballman I think I addressed all your comments, could you take a look again? I tested all failed tests as exposed by the buildbot here (http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. Regarding to this one "This is missing a bunch of C++ tests that show what happens in the case of inheritance, template instantiations, etc." Could you give me some example tests which I can take a look in order to add support. FYI, BPF backend publicly only suppor

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

ast added a comment. I've tested this patch on several kernel selftests/bpf/ and it works like magic. Very nice improvement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https://reviews.llvm.org/D69759 __

[PATCH] D69759: [BPF] Add preserve_access_index attribute for record definition

yonghong-song added a comment. @aaron.ballman BTW, I indeed tested C-style inheritance. An attribute for the forward declaration successfully inherited by a later actual declaration. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69759/new/ https:/

[PATCH] D67787: Add 8548 CPU definition and attributes

jhibbits updated this revision to Diff 228589. jhibbits added a comment. Add clang-translation tests for e500 and 8548 CPU definitions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67787/new/ https://reviews.llvm.org/D67787 Files: clang/lib/Bas

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker added a comment. @rsmith ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69360/new/ https://reviews.llvm.org/D69360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski created this revision. krytarowski added reviewers: joerg, mgorny, ruiu, MaskRay. krytarowski added a project: lld. Herald added subscribers: llvm-commits, cfe-commits, mstorsjo, fedor.sergeev, aheejin, emaste, dschuff. Herald added projects: clang, LLVM. The NetBSD target wraps the d

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski added a comment. Another approach to achieve the same goal as previous attempts. It is already better as it avoids two forks. Does this one look like fine for merging? The previous one for the reference: https://reviews.llvm.org/D69755 Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D70048: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski updated this revision to Diff 228591. krytarowski added a comment. - fix a typo in a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70048/new/ https://reviews.llvm.org/D70048 Files: clang/lib/Driver/ToolChain.cpp lld/CMakeL

[PATCH] D69755: [LLD] Add NetBSD support as a new flavor of LLD (nb.lld)

krytarowski abandoned this revision. krytarowski added a comment. Better patch in https://reviews.llvm.org/D70048 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69755/new/ https://reviews.llvm.org/D69755 __

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 228594. void added a comment. Emit asm goto fallthrough early so that any value extracts will show up in the fallthrough block and not directly after the callbr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69876/