[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

lebedev.ri added a comment. Thank you for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70366/new/ https://reviews.llvm.org/D70366 ___ cfe-commits mailing list

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

dim edited reviewers, added: dim, emaste; removed: clang. dim added a comment. I'll work on a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 ___

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

kimgr added a comment. Oh, I see. I thought `rc.exe` was the one and only implementation. Fair enough, this is probably the lesser of two evils :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70196/new/ https://reviews.llvm.org/D70196

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229747. plotfi marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229745. plotfi marked 2 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

Eugene.Zelenko added a comment. Please describe changes in documentation and Release Notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 ___ cfe-commits

[PATCH] D69979: clang: Guess at some platform FTZ/DAZ default settings

arsenm added a comment. In D69979#1746043 , @spatel wrote: > In D69979#1740294 , @arsenm wrote: > > > In D69979#1738099 , @craig.topper > > wrote: > > > > > I checked

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

rjmccall added a comment. Okay. There's actually a good reason to emit the selector reference as close to the call as possible, but I agree that we shouldn't do that in this patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69991/new/ https://reviews.llvm.org/D69991

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1428 can prove that the call/invoke cannot call a convergent function. +``flatten`` +This attribute is similar to ``alwaysinline``, but applies recursively to It's not obvious to me what

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder updated this revision to Diff 229743. MadCoder added a comment. Diff against previous is: diff diff --git a/clang/lib/CodeGen/CGObjCMac.cpp b/clang/lib/CodeGen/CGObjCMac.cpp index 814f67787dd..775e3406da7 100644 --- a/clang/lib/CodeGen/CGObjCMac.cpp +++

[PATCH] D69991: Implement __attribute__((objc_direct)), __attribute__((objc_direct_members))

MadCoder added a comment. when running the full test-suite before sending the patch, and it broke tests because some loads are now ordered differently :( yay. so I need to either make sure the CG is done in the same order again, or to fix the test expectations. CHANGES SINCE LAST ACTION

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

zturner created this revision. zturner added reviewers: aaron.ballman, dblaikie, jbcoe, NoQ. Herald added a subscriber: xazax.hun. This represents largely a full re-write of modernize-avoid-bind, adding significant new functionality in the process. In particular: 1. Both boost::bind and

[PATCH] D69872: Improve modernize-avoid-bind to support more types of expressions

zturner abandoned this revision. zturner added a comment. I have a more comprehensive version of this patch that I'll upload separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69872/new/ https://reviews.llvm.org/D69872 ___

[PATCH] D70366: Add new 'flatten' LLVM attribute to fix clang's 'flatten' function attribute

LevitatingLion created this revision. LevitatingLion added reviewers: jdoerfert, pcc, chandlerc. LevitatingLion added projects: LLVM, clang. Herald added subscribers: dexonsmith, steven_wu, haicheng, hiraditya, eraman, nhaehnle, jvesely, mehdi_amini, arsenm. This adds a new 'flatten' attribute,

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3506 + types::ID InputType = I.first; + const Arg *InputArg = I.second; + plotfi wrote: > compnerd wrote: > > structured bindings ... so much. > I don't understand? C++17's

[PATCH] D49466: Initial implementation of -fmacro-prefix-map and -ffile-prefix-map

dankm marked 2 inline comments as done. dankm added inline comments. Comment at: llvm/include/llvm/Support/Path.h:172 +/// @param style The path separator style +/// @param strict Strict prefix path checking +/// @result true if \a Path begins with OldPrefix

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3500 + PL = CompilePhaseList; +} + compnerd wrote: > Do you use the `PhaseList` again? Why not `erase_if`? We tried this in

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

plotfi updated this revision to Diff 229731. plotfi marked 7 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70274/new/ https://reviews.llvm.org/D70274 Files: clang/lib/Driver/Driver.cpp

[PATCH] D70340: Add a key method to Sema to optimize debug info size

thakis added a comment. In D70340#1748975 , @rnk wrote: > In D70340#1748712 , @ > > > > > > I guess I was thinking about enabling this only in +asserts builds, so we pay > zero overhead in release builds. I was

[PATCH] D70196: [clang-include-fixer] Skip .rc files when finding symbols

rnk added a comment. We already have llvm-rc.exe which one could plausibly use to compile rc files, and I didn't like `binary.lower().endswith('rc.exe')` as a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70196/new/

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

mhorne added reviewers: compnerd, phosek. mhorne marked 2 inline comments as done. mhorne added a comment. Add some libunwind contributors for additional review. Comment at: libunwind/src/Registers.hpp:3756 +inline double Registers_riscv::getFloatRegister(int regNum) const {

[PATCH] D69585: PerformPendingInstatiations() already in the PCH

llunak updated this revision to Diff 229722. llunak added a comment. It turns out that this patch may introduce unwanted changes, specifically it can cause err_specialization_after_instantiation if the specialization is done in a source file but needed already by code in the PCH. But this seems

[PATCH] D70349: [Attr] Fix `-ast-print` for `asm` attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70349/new/ https://reviews.llvm.org/D70349

[PATCH] D69990: Populate CUDA flags on FreeBSD too, as many other toolchains do.

emaste added a comment. Should have a test added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69990/new/ https://reviews.llvm.org/D69990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 marked 9 inline comments as done and an inline comment as not done. wwagner19 added inline comments. Comment at: clang-tools-extra/clangd/PathMapping.cpp:153 +// Converts \pPath to a posix-style absolute, i.e. if it's a windows path +// then the backward-slash notation

[PATCH] D64305: [clangd] Add path mappings functionality

wwagner19 updated this revision to Diff 229721. wwagner19 marked 5 inline comments as done. wwagner19 added a comment. Thanks for the second review Sam, I addressed most of your comments, notably: - Changed the bool IsIncoming to an enum - Fixed the "doxygen" comments, - Removed some redundant

[PATCH] D70340: Add a key method to Sema to optimize debug info size

rnk added a comment. In D70340#1748712 , @thakis wrote: > I don't see any reason not to do this. What's there to discuss? I'm probably > missing something obvious. I guess I was thinking about enabling this only in +asserts builds, so we pay zero

[PATCH] D70052: [clang-tidy] Add misc-mutating-copy check

gbencze updated this revision to Diff 229720. gbencze added a comment. Moved check to CERT module. Added warnings for calling mutating member functions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70052/new/ https://reviews.llvm.org/D70052 Files:

Re: [PATCH] D70144: clang-tidy: modernize-use-equals-default avoid adding redundant semicolons

We could resolve this using a separate TokenAnalyzer pass similar to what we are doing here https://reviews.llvm.org/D69764, such a would let us look at the last token on the previous line or the next token in the next time to ensure we don't remove legal cases like for(; ; ) Adding a

[PATCH] D69360: [NFC] Refactor representation of materialized temporaries

Tyker updated this revision to Diff 229718. Tyker added a comment. Herald added a reviewer: deadalnix. Herald added subscribers: llvm-commits, ormris, hiraditya. Herald added a project: LLVM. fixe the issue causing buildbot failure. node were visited multiple time by the RecursiveASTVisitor in

[PATCH] D70359: [clangd] Show values of more expressions on hover

lh123 added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:423 + // - certain expressions (sizeof etc) + // - built-in types } I think we should also support hover on literal. Repository: rG LLVM Github Monorepo CHANGES