[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

This revision was automatically updated to reflect the committed changes. Closed by commit rG95fe54931fdd: [clang-tidy] new performance-no-automatic-move check. (authored by courbet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://

[clang-tools-extra] 95fe549 - [clang-tidy] new performance-no-automatic-move check.

Author: Clement Courbet Date: 2019-11-22T08:47:55+01:00 New Revision: 95fe54931fddf9740b3247219e30504da447 URL: https://github.com/llvm/llvm-project/commit/95fe54931fddf9740b3247219e30504da447 DIFF: https://github.com/llvm/llvm-project/commit/95fe54931fddf9740b3247219e30504da447.dif

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

khchen added a comment. Re-applied with test fix in https://reviews.llvm.org/rG4fccd383d571865321b4723b81c3042d2c15fd80 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 ___

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

kbobyrev added inline comments. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3398 + // parameters. + auto AddTemplatedFunctionTypeAndResult = [&](const FunctionTemplateDecl + *FunTmpl) { sammccall wrote: > I

[PATCH] D70445: [clangd] Show lambda signature for lambda autocompletions

kbobyrev updated this revision to Diff 230594. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Simplified the patch to address the comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70445/new/ https://reviews.llvm.org/D70445 Files: clang-tools-extra/clangd/u

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet marked an inline comment as done. courbet added a comment. Thanks for the review. Comment at: clang-tools-extra/clang-tidy/performance/NoAutomaticMoveCheck.cpp:32 + + const auto const_local_variable = + varDecl(hasLocalStorage(), unless(hasType(lValueReferenceType

[PATCH] D70390: [clang-tidy] new performance-no-automatic-move check.

courbet updated this revision to Diff 230595. courbet added a comment. Use LLVM style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70390/new/ https://reviews.llvm.org/D70390 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt clang

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge marked an inline comment as done. nridge added inline comments. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/semantic-highlighting.ts:210 + isWholeLine: true, + // FIXME: Avoid hardcoding these colors. + light: { I'm open

[PATCH] D68720: Support -fstack-clash-protection for x86

serge-sans-paille updated this revision to Diff 230494. serge-sans-paille added a comment. Added extra test for arch support (warns if the flag is used on unsupported targets, and checks it's effectively unused), cc @sylvestre.ledru Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D61446: Generalize the pass registration mechanism used by Polly to any third-party tool

serge-sans-paille added a comment. @Meinersbur to make your reviewer job easier, I've setup validation for that patch, see https://github.com/serge-sans-paille/llvm-project/pull/2/checks It build and validates fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] a3b22da - [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

Author: Artem Dergachev Date: 2019-11-21T21:55:58-08:00 New Revision: a3b22da4e0ea84ed5890063926b6f54685c23225 URL: https://github.com/llvm/llvm-project/commit/a3b22da4e0ea84ed5890063926b6f54685c23225 DIFF: https://github.com/llvm/llvm-project/commit/a3b22da4e0ea84ed5890063926b6f54685c23225.dif

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

NoQ added a comment. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap-msan/builds/16031 MSan doesn't catch it >.< Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69962/new/ https://reviews.llvm.org/D69962

[PATCH] D67537: [clangd] Client-side support for inactive regions

nridge updated this revision to Diff 230586. nridge added a comment. Clean up patch a bit and update tests as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67537/new/ https://reviews.llvm.org/D67537 Files: clang-tools-extra/clangd/clients/c

[PATCH] D70157: Align branches within 32-Byte boundary

skan marked an inline comment as done. skan added a comment. In D70157#1755927 , @jyknight wrote: > Thanks for the comments, they help a little. But it's still somewhat > confusing, so let me write down what seems to be happening: > > - Before emitting ev

[clang] 4fccd38 - [RISCV] Support mutilib in baremetal environment

Author: Zakk Chen Date: 2019-11-21T19:58:21-08:00 New Revision: 4fccd383d571865321b4723b81c3042d2c15fd80 URL: https://github.com/llvm/llvm-project/commit/4fccd383d571865321b4723b81c3042d2c15fd80 DIFF: https://github.com/llvm/llvm-project/commit/4fccd383d571865321b4723b81c3042d2c15fd80.diff LOG

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. LGTM! Let me know if you'd like me to commit this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.or

[PATCH] D62035: [AST] const-ify ObjC inherited class search

modocache abandoned this revision. modocache added a comment. I'm not super interested in this patch anymore, someone else feel free to work on this! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62035/new/ https://reviews.llvm.org/D62035 _

[PATCH] D59765: [Lex] Warn about invisible Hangul whitespace

modocache abandoned this revision. modocache added a comment. I'm not super interested in this patch anymore, someone else feel free to work on this! :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59765/new/ https://reviews.llvm.org/D59765 _

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. LGTM, thanks! Please let me know if you'd like me to commit this change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser added a comment. In D69022#1755636 , @modocache wrote: > Sorry for the slow response here, @junparser! > > The test case you came up with here is great! I can see the issue is that > `ScopeInfo->CoroutineParameterMoves` are built up when Clang p

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

junparser updated this revision to Diff 230581. junparser added a comment. update as @modocache's suggestion CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 Files: clang/lib/Sema/SemaCoroutine.cpp clang/test/SemaCXX/coroutines.cpp Index: c

[clang] f7170d1 - clang/Modules: Move Serialization/Module.{h, cpp} to ModuleFile, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-21T19:07:00-08:00 New Revision: f7170d17a846cd67d70884ba168fd0fad63549ea URL: https://github.com/llvm/llvm-project/commit/f7170d17a846cd67d70884ba168fd0fad63549ea DIFF: https://github.com/llvm/llvm-project/commit/f7170d17a846cd67d70884ba168fd0fad635

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG0b58b80edb81: [analyzer] Fix Objective-C accessor body farms after 2073dd2d. (authored by dergachev.a). Repository: rG

[PATCH] D70150: [analyzer] Don't clean up dead symbols from constraints twice.

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbc8662db154: [analyzer] NFC: Don't clean up range constraints twice. (authored by dergachev.a). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70150/new/ ht

[clang] 0b58b80 - [analyzer] Fix Objective-C accessor body farms after 2073dd2d.

Author: Artem Dergachev Date: 2019-11-21T18:59:46-08:00 New Revision: 0b58b80edb81bf8fb401f8a6e057ca9d50abc0f7 URL: https://github.com/llvm/llvm-project/commit/0b58b80edb81bf8fb401f8a6e057ca9d50abc0f7 DIFF: https://github.com/llvm/llvm-project/commit/0b58b80edb81bf8fb401f8a6e057ca9d50abc0f7.dif

[clang] bbc8662 - [analyzer] NFC: Don't clean up range constraints twice.

Author: Artem Dergachev Date: 2019-11-21T18:59:46-08:00 New Revision: bbc8662db1548f98b1c475cadf6260f9079c11ea URL: https://github.com/llvm/llvm-project/commit/bbc8662db1548f98b1c475cadf6260f9079c11ea DIFF: https://github.com/llvm/llvm-project/commit/bbc8662db1548f98b1c475cadf6260f9079c11ea.dif

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

kousikk added inline comments. Comment at: clang/include/clang-c/Dependencies.h:146 + */ +typedef struct CXOpaqueDependencyScannerWorker *CXDependencyScannerWorker; + It would be simpler if the clients didn't have to worry about the worker? As far as a user of th

[PATCH] D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC

dexonsmith created this revision. dexonsmith added reviewers: Bigcheese, jkorous, rsmith, bruno. Herald added subscribers: ributzka, kbarton, nemanjai. dexonsmith added a parent revision: D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC. Herald added a subscriber: wuzish. Fix the

[PATCH] D69962: [CFG] Fix a flaky crash in CFGBlock::getLastCondition().

This revision was automatically updated to reflect the committed changes. Closed by commit rG6bbca3411b38: [CFG] Add a test for a flaky crash in CFGBlock::getLastCondition(). (authored by dergachev.a). Changed prior to commit: https://reviews.llvm.org/D69962?vs=228292&id=230575#toc Repository:

[PATCH] D70158: [analyzer] Fix Objective-C accessor body farms after D68108.

NoQ added a comment. I'll commit in order to get rid of the crash, but i'm open for discussions :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70158/new/ https://reviews.llvm.org/D70158 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D70576: [Clang] Always set -z now linker option on Fuchsia

phosek added a comment. In D70576#1756049 , @leonardchan wrote: > LGTM. But just to confirm, did you test this on CQ/bots by adding `["now", > "-z"]` as linker flags to the `config("compiler")` in Fuchsia + Zircon? https://fuchsia-review.googlesource.co

[clang] 6bbca34 - [CFG] Add a test for a flaky crash in CFGBlock::getLastCondition().

Author: Artem Dergachev Date: 2019-11-21T18:11:15-08:00 New Revision: 6bbca3411b3861904c3b302f61d59efa14d4d0b9 URL: https://github.com/llvm/llvm-project/commit/6bbca3411b3861904c3b302f61d59efa14d4d0b9 DIFF: https://github.com/llvm/llvm-project/commit/6bbca3411b3861904c3b302f61d59efa14d4d0b9.dif

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added inline comments. Comment at: clang/include/clang-c/Dependencies.h:205 + */ +CINDEX_LINKAGE void clang_experimental_DependencyScannerWorker_dispose_v0( +CXDependencyScannerWorker); Looks like you have a duplicate declaration of this function, an

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

arphaman added a comment. I think this patch is missing tests for the C api that use c-index-test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70351/new/ https://reviews.llvm.org/D70351 ___ cfe-commi

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); Bigcheese wrote: > arphaman wrote: > > What if

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

vsk planned changes to this revision. vsk marked an inline comment as done. vsk added a comment. I'll write something up in the coverage mapping docs. Briefly, though, with this change there should be a gap region that covers the entire switch body (starting from the '{' in 'switch {', and termi

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

leonardchan added a comment. Could you add a test to show that with a fuchsia target we end up returning `this` from constructors + destructors and ensure that this ABI is used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70575/new/ https://revi

[PATCH] D70576: [Clang] Always set -z now linker option on Fuchsia

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. LGTM. But just to confirm, did you test this on CQ/bots by adding `["now", "-z"]` as linker flags to the `config("compiler")` in Fuchsia + Zircon? Repository: rG LLVM Github Monor

[PATCH] D70579: [coroutines][PR41909] Generalize fix from D62550

modocache created this revision. modocache added reviewers: GorNishanov, rsmith, lewissbaker. Herald added a subscriber: EricWF. Herald added a project: clang. In https://reviews.llvm.org/D62550 @rsmith pointed out that there are many situations in which a coroutine body statement may be transform

[PATCH] D70157: Align branches within 32-Byte boundary

efriedma added inline comments. Comment at: llvm/include/llvm/MC/MCFragment.h:684 + // need to be aligned. + static unsigned AlignBoundarySize; + // AlignMaxPrefixSize - The maximum size of prefixes per instruction. Global variables are forbidden in LLVM libra

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 230569. kamleshbhalui added a comment. Added a test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/pr42710.cpp Index: clang/test/C

[PATCH] D67536: [clangd] Inactive regions support as an extension to semantic highlighting

This revision was automatically updated to reflect the committed changes. Closed by commit rGb2e6c2b9954b: [clangd] Inactive regions support as an extension to semantic highlighting (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D67536?vs=230195&id=230565#toc Repositor

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

sunfish added a comment. In D70500#1756011 , @dschuff wrote: > WRT the LTO directory name, there's theoretically the danger that someone > (e.g. emscripten) could be doing a rolling release of the compiler and get > invalidated within a major revision.

[clang-tools-extra] b2e6c2b - [clangd] Inactive regions support as an extension to semantic highlighting

Author: Nathan Ridge Date: 2019-11-21T19:40:55-05:00 New Revision: b2e6c2b9954ba9f9b68b8394790f6cae35aea58e URL: https://github.com/llvm/llvm-project/commit/b2e6c2b9954ba9f9b68b8394790f6cae35aea58e DIFF: https://github.com/llvm/llvm-project/commit/b2e6c2b9954ba9f9b68b8394790f6cae35aea58e.diff

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff added a comment. Also if at some point we are able to remove a bunch of the driver logic from emcc and move it here, (e.g. running clang to link instead of lld directly) we'll need to watch out for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

dschuff accepted this revision. dschuff added a comment. This revision is now accepted and ready to land. WRT the LTO directory name, there's theoretically the danger that someone (e.g. emscripten) could be doing a rolling release of the compiler and get invalidated within a major revision. But

[PATCH] D70576: [Clang] Always set -z now linker option on Fuchsia

phosek created this revision. phosek added reviewers: leonardchan, mcgrathr. Herald added a project: clang. Herald added a subscriber: cfe-commits. This should be the default on Fuchsia. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70576 Files: clang/lib/Driver/ToolChains/

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

This revision was automatically updated to reflect the committed changes. phosek marked an inline comment as done. Closed by commit rG68a3a3b28130: [Clang] Enable RISC-V support for Fuchsia (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D70575: [Clang] Define Fuchsia C++ABI

phosek created this revision. phosek added a reviewer: leonardchan. Herald added a project: clang. Herald added a subscriber: cfe-commits. It is a modified version of the Itanium ABI. The only change is that constructors and destructors return 'this'. Repository: rG LLVM Github Monorepo https

[clang] 68a3a3b - [Clang] Enable RISC-V support for Fuchsia

Author: Petr Hosek Date: 2019-11-21T16:02:26-08:00 New Revision: 68a3a3b28130ff055159632e8f94ef87fa8cba45 URL: https://github.com/llvm/llvm-project/commit/68a3a3b28130ff055159632e8f94ef87fa8cba45 DIFF: https://github.com/llvm/llvm-project/commit/68a3a3b28130ff055159632e8f94ef87fa8cba45.diff LO

[PATCH] D70157: Align branches within 32-Byte boundary

craig.topper added a comment. In D70157#1755927 , @jyknight wrote: > Thanks for the comments, they help a little. But it's still somewhat > confusing, so let me write down what seems to be happening: > > - Before emitting every instruction, a new MCMachin

[PATCH] D69618: NeonEmitter: clean up prototype modifiers

efriedma added a comment. It looks like this broke vcreate_u16 and friends. From http://lab.llvm.org:8011/builders/aosp-O3-polly-before-vectorizer-unprofitable/builds/1224/steps/build-aosp/logs/stdio : external/skia/src/opts/SkBitmapProcState_filter_neon.h:53:42: error: C-style cast from sc

[PATCH] D70157: Align branches within 32-Byte boundary

jyknight added a comment. Thanks for the comments, they help a little. But it's still somewhat confusing, so let me write down what seems to be happening: - Before emitting every instruction, a new MCMachineDependentFragment is now emitted, of one of the multiple types: - For most instruction

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

efriedma added a comment. Could you write a description somewhere of what the overall region tree should look like for a switch? Comment at: clang/test/CoverageMapping/switch.cpp:32 switch (i) { // CHECK-NEXT: File 0, [[@LINE]]:3 -> [[@LINE+6]]:2 = #4 -nop();

[PATCH] D70572: [Serialization] #pragma clang transform

Meinersbur created this revision. Meinersbur added reviewers: hfinkel, kbarton, SjoerdMeijer, aaron.ballman, ABataev, fhahn, hsaito, hans, greened, dmgreen, Ayal, asavonic, rtrieu, dorit, rsmith, tyler.nowicki, jdoerfert. Herald added subscribers: cfe-commits, zzheng. Herald added a project: clan

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

Bigcheese marked an inline comment as done. Bigcheese added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); a

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

vsk created this revision. vsk added reviewers: hans, rnk, efriedma. vsk edited the summary of this revision. Emit a gap region beginning where the switch body begins. This sets line execution counts in the areas between non-overlapping cases to 0. This does not resolve an outstanding issue with

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

merge_guards_bot added a comment. Build result: pass - 60231 tests passed, 0 failed and 732 were skipped. Log files: console-log.txt , CMakeCache.txt

[PATCH] D70268: [clang][clang-scan-deps] Aggregate the full dependency information.

arphaman added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:97 + if (OutputPaths.empty()) +OutputPaths = Opts.Targets; Dependencies.push_back(File); What if `Opts.Targets` is empty? Repository:

[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/include/clang/Lex/ModuleLoader.h:50 +// We failed to load the module, but we shouldn't cache the failure. +OtherUncachedFailure, }; jkorous wrote: > Just a

[PATCH] D70569: [clangd] Allow extract-to-function on regions that always return.

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. We only do a trivial check whether the region always returns - it has to end with a return statement.

[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

jkorous added inline comments. Comment at: clang/include/clang/Lex/ModuleLoader.h:50 +// We failed to load the module, but we shouldn't cache the failure. +OtherUncachedFailure, }; Just a typo - the comma at the end. CHANGES SINCE LAST ACTION https

[PATCH] D70568: [Support] Possibly use exception handler in the Crash Recovery Context in the same way as global exceptions

aganea created this revision. aganea added reviewers: hans, rnk, thakis. Herald added subscribers: llvm-commits, cfe-commits, jfb, arphaman, hiraditya. Herald added a reviewer: jfb. Herald added projects: clang, LLVM. aganea edited the summary of this revision. Herald added a subscriber: dexonsmith

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755768 , @ABataev wrote: > In D70551#1755761 , @sdmitriev wrote: > > > In D70551#1755583 , @ABataev wrote: > > > > > In D70551#173 <

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added a comment. I've split the `CrashRecoveryContext` changes into another patch to minimize the risks, please see D70568 . That patch will need to go first before this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://revie

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea added inline comments. Comment at: clang/lib/Driver/Job.cpp:347 +StringRef DriverExe = llvm::sys::path::stem(D.ClangExecutable); +if (CommandExe.equals_lower(DriverExe)) +CC1Main = Driver::CC1Main; hans wrote: > aganea wrote: > > hans wrote

[PATCH] D69825: [Clang][Driver] Re-use the calling process instead of creating a new process for the cc1 invocation

aganea updated this revision to Diff 230527. aganea marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69825/new/ https://reviews.llvm.org/D69825 Files: clang/include/clang/Driver/Driver.h clang/include/clang/Driver/Job.h clang/lib/Driver/Job.cpp clan

[clang] f8ff3d7 - [OPENMP]Remove unused template parameter, NFC.

Author: Alexey Bataev Date: 2019-11-21T16:42:26-05:00 New Revision: f8ff3d7ebd8499cad896b2e934fbc9d7412ba823 URL: https://github.com/llvm/llvm-project/commit/f8ff3d7ebd8499cad896b2e934fbc9d7412ba823 DIFF: https://github.com/llvm/llvm-project/commit/f8ff3d7ebd8499cad896b2e934fbc9d7412ba823.diff

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

ABataev added a comment. In D70551#1755761 , @sdmitriev wrote: > In D70551#1755583 , @ABataev wrote: > > > In D70551#173 , @sdmitriev > > wrote: > > > > > In D70551#1755

[PATCH] D70467: [Distro] Bypass distro detection on Windows

aganea updated this revision to Diff 230525. aganea added a comment. Removed `#ifdef _WIN32` Use the target triple where possible to detect the distro. The Cuda installation detector uses the host triple, in order to use the host tooling. Skip distro detection when the target or host system is no

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755583 , @ABataev wrote: > In D70551#173 , @sdmitriev wrote: > > > In D70551#1755527 , @ABataev wrote: > > > > > Why do we need this

[PATCH] D69938: [OpenCL] Use __generic addr space when generating internal representation of lambda

rjmccall added a reviewer: rsmith. rjmccall added a comment. In D69938#1754894 , @Anastasia wrote: > In D69938#1752024 , @rjmccall wrote: > > > Yes, in that case copy-elision into the global variable is guaranteed.

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

Bigcheese added a comment. Thanks, you're good to commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache requested changes to this revision. modocache added a comment. This revision now requires changes to proceed. Sorry for the slow response here, @junparser! The test case you came up with here is great! I can see the issue is that `ScopeInfo->CoroutineParameterMoves` are built up when C

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk added inline comments. Comment at: clang/tools/clang-scan-deps/ClangScanDeps.cpp:75-79 +llvm::Optional Redirects[] = { +{""}, // Stdin +StringRef(OutputFile), +StringRef(ErrorFile), +}; Bigcheese wrote: > It would be nice i

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

kousikk updated this revision to Diff 230508. kousikk marked 4 inline comments as done. kousikk added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69122/new/ https://reviews.llvm.org/D69122 Files: clang/tools/

[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

dexonsmith marked 2 inline comments as done. dexonsmith added inline comments. Comment at: clang/include/clang/Frontend/CompilerInstance.h:801-804 + ModuleLoadResult findOrCompileModuleAndReadAST(StringRef ModuleName, + SourceLocat

[PATCH] D70488: [InstCombine] Infer fast math flags on fadd/fsub/fmul/fcmp

bkramer added a comment. In D70488#1753897 , @mcberg2017 wrote: > For us this would be an impediment as we have math models that want ieee > behavior while relaxing precision. Adding nnan or ninf would obstruct those > choices. Mind elaborating why nn

[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

dexonsmith created this revision. dexonsmith added reviewers: bruno, Bigcheese, jkorous, rsmith. Herald added a subscriber: ributzka. Refactor the logic on CompilerInstance::loadModule and a couple of surrounding methods in order to clarify what's going on. - Rename ModuleLoader::loadModuleFromSo

[PATCH] D70555: [coroutines] Don't build promise init with no args

modocache created this revision. modocache added reviewers: GorNishanov, rsmith, lewissbaker. Herald added subscribers: cfe-commits, EricWF. Herald added a project: clang. modocache edited the summary of this revision. In the case of a coroutine that takes no arguments, `Sema::buildCoroutinePromis

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

ABataev added a comment. In D70551#173 , @sdmitriev wrote: > In D70551#1755527 , @ABataev wrote: > > > Why do we need this? > > > To pass wrapper bitcode directly to the linker when LTO is enabled. LTO > plugin

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

ymandel created this revision. ymandel added a reviewer: gribozavr. Herald added a project: clang. Adds combinators `asValue` and `asPointer` to provide a uniform way to handle nodes which may be bound to either a pointer or a value (most often in the context of member expressions). Such polymorph

[clang] 5fcf89f - [PowerPC] Add new Future CPU for PowerPC

Author: Stefan Pintilie Date: 2019-11-21T13:35:48-06:00 New Revision: 5fcf89f77893b4c3367f23dd82b426f783e67cff URL: https://github.com/llvm/llvm-project/commit/5fcf89f77893b4c3367f23dd82b426f783e67cff DIFF: https://github.com/llvm/llvm-project/commit/5fcf89f77893b4c3367f23dd82b426f783e67cff.dif

[PATCH] D70262: [PowerPC] Add new Future CPU for PowerPC

This revision was automatically updated to reflect the committed changes. Closed by commit rG5fcf89f77893: [PowerPC] Add new Future CPU for PowerPC (authored by stefanp). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. In D70551#1755527 , @ABataev wrote: > Why do we need this? To pass wrapper bitcode directly to the linker when LTO is enabled. LTO plugin does not accept bc if there is no data layout. Repository: rG LLVM Github Monorepo

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

Eugene.Zelenko added a comment. Changes should be also reflected in Release Notes. Comment at: clang-tools-extra/docs/clang-tidy/checks/modernize-avoid-bind.rst:7 +The check finds uses of ``std::bind`` and ``boost::bind`` and replaces them +with lambdas. Lambdas will use value

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 230500. xazax.hun edited the summary of this revision. xazax.hun added a comment. - Make the patch standalone and the check on by default for the fuchsia platform. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/

[PATCH] D70544: Debug info: Emit objc_direct methods as members of their containing class

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0cabe280b80: Debug info: Emit objc_direct methods as members of their containing class (authored by aprantl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D70544?vs=

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

zturner updated this revision to Diff 230495. zturner added a comment. - Updated documentation for this check - Incorporated additional suggestions from @aaron.ballman - Fixed an invalid transformation that was generated when binding a member function and the second argument of `bind` (the object

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Thanks, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70485/new/ https://reviews.llvm.org/D70485 _

[PATCH] D70553: [clang-apply-replacements] Add command line option to overwrite readonly files.

zturner created this revision. zturner added reviewers: aaron.ballman, alexfh, hokein. zturner added a project: clang-tools-extra. Herald added a project: clang. Some source code control systems attempt to prevent you from editing files unless you explicitly check them out. This makes it impossi

[PATCH] D68720: Support -fstack-clash-protection for x86

xbolva00 added a comment. https://reviews.llvm.org/rG397fa687691876de9ff0fbaaf0def3ac5a48899c Commited? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 ___ cfe

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

ABataev added a comment. Why do we need this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70551/new/ https://reviews.llvm.org/D70551 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] e0cabe2 - Debug info: Emit objc_direct methods as members of their containing class

Author: Adrian Prantl Date: 2019-11-21T11:01:10-08:00 New Revision: e0cabe280b80ab71045d90b2d6f1a70e5d4c5d05 URL: https://github.com/llvm/llvm-project/commit/e0cabe280b80ab71045d90b2d6f1a70e5d4c5d05 DIFF: https://github.com/llvm/llvm-project/commit/e0cabe280b80ab71045d90b2d6f1a70e5d4c5d05.diff

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70551 Files: clang/test/Driver/clang-offload-wrapper.c clang/tools/clang-offload

[PATCH] D70245: [OPENMP50]Add device/kind context selector support.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4e8231b5cf0f: [OPENMP50]Add device/kind context selector support. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70245/new/ https://re

[clang] 4e8231b - [OPENMP50]Add device/kind context selector support.

Author: Alexey Bataev Date: 2019-11-21T13:28:11-05:00 New Revision: 4e8231b5cf0f5f62c7a51a857e29f5be5cb55734 URL: https://github.com/llvm/llvm-project/commit/4e8231b5cf0f5f62c7a51a857e29f5be5cb55734 DIFF: https://github.com/llvm/llvm-project/commit/4e8231b5cf0f5f62c7a51a857e29f5be5cb55734.diff

[PATCH] D70544: Debug info: Emit objc_direct methods as members of their containing class

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM with two minor comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:4729 - SmallVector EltTys; - auto CurrenetElts = InterfaceDecl->getElements(); - EltTys.append(CurrenetElts.begin(), C

  1   2   >