[PATCH] D70500: [WebAssembly] Enable use of wasm-opt and LTO-enabled system libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG812828984c10: [WebAssembly] Use wasm-opt and LTO libraries when available. (authored by sunfishcode). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

doug.gregor added a comment. In D69420#1757664 , @Bigcheese wrote: > It was already there from a previous commit. I see it in tree currently. Oh, sorry. I missed it in my cherry-picking and GitHub search failed to find it. Repository: rG LLVM Github

[clang] 8128289 - [WebAssembly] Use wasm-opt and LTO libraries when available.

Author: Dan Gohman Date: 2019-11-22T22:16:28-08:00 New Revision: 812828984c10857a4cd260eb638c52a4411f9143 URL: https://github.com/llvm/llvm-project/commit/812828984c10857a4cd260eb638c52a4411f9143 DIFF: https://github.com/llvm/llvm-project/commit/812828984c10857a4cd260eb638c52a4411f9143.diff

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

Bigcheese added a comment. It was already there from a previous commit. I see it in tree currently. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 ___

[PATCH] D70632: clang-format-vs : Fix typo NUGET_EXE_DIR on README

empty2fill created this revision. empty2fill added a reviewer: hans. empty2fill added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Match with the CMake variable. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70632 Files:

[PATCH] D69420: [clang][clang-scan-deps] Add support for extracting full module dependencies.

doug.gregor added a comment. It looks like Inputs/modules_cdb.json missing from this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69420/new/ https://reviews.llvm.org/D69420 ___ cfe-commits

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

kamleshbhalui updated this revision to Diff 230747. kamleshbhalui added a comment. Thanks, @vsk for reviewing. I have incorporated your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70537/new/ https://reviews.llvm.org/D70537 Files: clang/lib/CodeGen/CGDebugInfo.cpp

[clang] 380a645 - [ASTMatchers] work around a miscompile; "NFC"

Author: George Burgess IV Date: 2019-11-22T20:11:16-08:00 New Revision: 380a6452b2e98d9c34828503edf8032f6b4c82d3 URL: https://github.com/llvm/llvm-project/commit/380a6452b2e98d9c34828503edf8032f6b4c82d3 DIFF:

Buildbot numbers for the week of 11/10/2019 - 11/16/2019

Hello everyone, Below are some buildbot numbers for the last week of 11/10/2019 - 11/16/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 11/03/2019 - 11/09/2019

Hello everyone, Below are some buildbot numbers for the week of 11/03/2019 - 11/09/2019. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

LLVM buildmaster will be updated and restarted tonight

Hello everyone, LLVM buildmaster will be updated and restarted after 8PM Pacific time today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC

dexonsmith closed this revision. dexonsmith added a comment. Pushed as 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70583/new/ https://reviews.llvm.org/D70583

[clang-tools-extra] 20d51b2 - clang/Modules: Rename CompilerInstance::ModuleManager, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-22T18:24:11-08:00 New Revision: 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d URL: https://github.com/llvm/llvm-project/commit/20d51b2f14ac4488f684f8fc57cb0ba718a6b91d DIFF:

[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

dexonsmith closed this revision. dexonsmith marked an inline comment as done. dexonsmith added a comment. Pushed as 20d51b2f14ac4488f684f8fc57cb0ba718a6b91d. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70556/new/ https://reviews.llvm.org/D70556

[clang] 5cca622 - clang/Modules: Refactor CompilerInstance::loadModule, NFC

Author: Duncan P. N. Exon Smith Date: 2019-11-22T18:23:47-08:00 New Revision: 5cca622310c10fdf6f921b6cce26f91d9f14c762 URL: https://github.com/llvm/llvm-project/commit/5cca622310c10fdf6f921b6cce26f91d9f14c762 DIFF:

[clang-tools-extra] 9f13a03 - clang-tidy: don't use an absolute path in a test

Author: George Burgess IV Date: 2019-11-22T18:13:18-08:00 New Revision: 9f13a032b6d7f720caf6511d0c9b1b6b7d2bbc67 URL: https://github.com/llvm/llvm-project/commit/9f13a032b6d7f720caf6511d0c9b1b6b7d2bbc67 DIFF:

[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

dblaikie added a comment. Seems to have a few things going on - the title talks about global variables - the description talks about extern types (guessing that's just a typo?) - the patch itself seems to have code that's visiting more functions? ( processFuncPrototypes ) - & also I'd generally

[PATCH] D70583: clang/Modules: Rename CompilerInstance::ModuleManager, NFC

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. > I have to assume there was a point in the past where they were just one > class, but it's been pretty confusing for a while. I think it's time to fix > it. Thanks! LGTM CHANGES SINCE LAST

[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

bruno accepted this revision. bruno added a comment. Nice! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70556/new/ https://reviews.llvm.org/D70556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70556: clang/Modules: Refactor CompilerInstance::loadModule, NFC

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm. Nice cleanup. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70556/new/ https://reviews.llvm.org/D70556 ___ cfe-commits

[clang] e956952 - DebugInfo: Flag Dwarf Version metadata for merging during LTO

Author: David Blaikie Date: 2019-11-22T17:16:35-08:00 New Revision: e956952edec140d2475aa7c8cbe20fbdd3320634 URL: https://github.com/llvm/llvm-project/commit/e956952edec140d2475aa7c8cbe20fbdd3320634 DIFF: https://github.com/llvm/llvm-project/commit/e956952edec140d2475aa7c8cbe20fbdd3320634.diff

Re: [PATCH] D69897: Add #pragma clang loop vectorize_assume_alignment(n)

Hello Michael, A very good Morning to you. On Wed, Nov 20, 2019 at 10:58 PM Michael Kruse wrote: > Am Mi., 20. Nov. 2019 um 10:21 Uhr schrieb HAPPY Mahto > : > >> #pragma clang loop vectorize_assume_alignment(32) > >> for(int i = 0;i < n; i++){ > >> a[i] = b[i] + i*i; > >> } > > > > for this

[PATCH] D70627: [AST] Split out Attrs.h for table generated *Attr classes

rnk created this revision. rnk added a reviewer: aaron.ballman. Herald added subscribers: arphaman, mgrang, kosarev, jholewinski. Herald added a reviewer: jdoerfert. Herald added a project: clang. Many AST headers require Attr to be complete, but do not need the complete table generated list of

[clang] 019779d - Remove needless Attr.h include from DeclCXX.h, NFC

Author: Reid Kleckner Date: 2019-11-22T16:16:10-08:00 New Revision: 019779dadfd7c98aedf0072d604ace295be6fa62 URL: https://github.com/llvm/llvm-project/commit/019779dadfd7c98aedf0072d604ace295be6fa62 DIFF: https://github.com/llvm/llvm-project/commit/019779dadfd7c98aedf0072d604ace295be6fa62.diff

[clang] a9cc64e - Separate the MS inheritance model enum from the attribute, NFC

Author: Reid Kleckner Date: 2019-11-22T16:06:30-08:00 New Revision: a9cc64e50e64e76151679780f0ace11b48eadd44 URL: https://github.com/llvm/llvm-project/commit/a9cc64e50e64e76151679780f0ace11b48eadd44 DIFF: https://github.com/llvm/llvm-project/commit/a9cc64e50e64e76151679780f0ace11b48eadd44.diff

[PATCH] D70625: [DebugInfo][BPF] Support to emit debugInfo for extern variables

yonghong-song created this revision. yonghong-song added reviewers: aprantl, dblaikie, RKSimon, ast. yonghong-song added a project: debug-info. Herald added subscribers: llvm-commits, cfe-commits, ormris, hiraditya. Herald added projects: clang, LLVM. extern variable usage in BPF is different

[clang] 2692eb0 - Move vtordisp mode from Attr class to LangOptions.h, NFC

Author: Reid Kleckner Date: 2019-11-22T15:47:46-08:00 New Revision: 2692eb0b86c8f7ae1299d2e032f2778bb6e0a224 URL: https://github.com/llvm/llvm-project/commit/2692eb0b86c8f7ae1299d2e032f2778bb6e0a224 DIFF: https://github.com/llvm/llvm-project/commit/2692eb0b86c8f7ae1299d2e032f2778bb6e0a224.diff

[clang] 6551ac7 - [Driver] Make -static-libgcc imply static libunwind

Author: Josh Kunz Date: 2019-11-22T15:33:13-08:00 New Revision: 6551ac7489fe070a2edcfac88f68c93321cba9a9 URL: https://github.com/llvm/llvm-project/commit/6551ac7489fe070a2edcfac88f68c93321cba9a9 DIFF: https://github.com/llvm/llvm-project/commit/6551ac7489fe070a2edcfac88f68c93321cba9a9.diff

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/test/Sema/warn-stringcompare.c:4-6 +#define DELIM "/" +#define NULL (void *)0 + Current behaviour: https://godbolt.org/z/7nYH6N Repository: rG LLVM Github Monorepo

[PATCH] D70624: [Diagnostics] Warn for comparison with string literals expanded from macro (PR44064)

xbolva00 created this revision. xbolva00 added a reviewer: aaron.ballman. Herald added a project: clang. Herald added a subscriber: cfe-commits. xbolva00 marked an inline comment as done. xbolva00 added inline comments. Comment at: clang/test/Sema/warn-stringcompare.c:4-6

[PATCH] D69740: [profile] Support counter relocation at runtime

phosek added a comment. In D69740#1752348 , @vsk wrote: > I think this looks good overall. The only high-level item that seems to be > missing is Fuchsia testing -- are there any bots for this? Not yet unfortunately, it's something I'm slowly working

[PATCH] D69740: [profile] Support counter relocation at runtime

phosek updated this revision to Diff 230733. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D69740 Files: clang/docs/SourceBasedCodeCoverage.rst clang/lib/Driver/ToolChains/Darwin.cpp

[Diffusion] rG825235c140e7: Revert "[Sema] Use the canonical type in function isVector"

ahatanak added a subscriber: cfe-commits. BRANCHES master Users: ahatanak (Author) https://reviews.llvm.org/rG825235c140e7 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D69740: [profile] Support counter relocation at runtime

phosek updated this revision to Diff 230727. phosek marked 2 inline comments as done. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69740/new/ https://reviews.llvm.org/D69740

[PATCH] D70596: [analyzer][docs] NFC: Extend documentation for MallocOverflow checker

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Fair enough! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70596/new/ https://reviews.llvm.org/D70596

[clang] 825235c - Revert "[Sema] Use the canonical type in function isVector"

Author: Akira Hatanaka Date: 2019-11-22T13:48:39-08:00 New Revision: 825235c140e7747f686bd7902cb0f9af77590841 URL: https://github.com/llvm/llvm-project/commit/825235c140e7747f686bd7902cb0f9af77590841 DIFF:

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

This revision was automatically updated to reflect the committed changes. Closed by commit rG9353c5dd0664: [Diagnostics] Put deprecated copy warnings into -Wdeprecated-copy (authored by xbolva00). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70351: [clang][WIP][clang-scan-deps] Add an experimental C API.

Bigcheese marked an inline comment as done. Bigcheese added inline comments. Comment at: clang/include/clang-c/Dependencies.h:146 + */ +typedef struct CXOpaqueDependencyScannerWorker *CXDependencyScannerWorker; + kousikk wrote: > It would be simpler if the

[PATCH] D70615: Add an -fno-temp-file flag for compilation

zahen created this revision. zahen added reviewers: rsmith, rnk, zturner. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our build system does not handle randomly named files created during the build well. We'd prefer to write compilation output directly without creating

[PATCH] D70571: [Coverage] Emit a gap region to cover switch bodies

vsk updated this revision to Diff 230714. vsk added a comment. - Add some documentation about clang internals. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70571/new/ https://reviews.llvm.org/D70571 Files: clang/docs/SourceBasedCodeCoverage.rst

[clang] a6150b4 - [Sema] Use the canonical type in function isVector

Author: Akira Hatanaka Date: 2019-11-22T12:57:24-08:00 New Revision: a6150b48cea00ab31e9335cc73770327acc4cb3a URL: https://github.com/llvm/llvm-project/commit/a6150b48cea00ab31e9335cc73770327acc4cb3a DIFF:

[clang] 2b79563 - Fix typo to separate "-x" from warning flag.

Author: Bill Wendling Date: 2019-11-22T12:51:41-08:00 New Revision: 2b795637b9024d76e53cd303ad74ac02ba22da5b URL: https://github.com/llvm/llvm-project/commit/2b795637b9024d76e53cd303ad74ac02ba22da5b DIFF: https://github.com/llvm/llvm-project/commit/2b795637b9024d76e53cd303ad74ac02ba22da5b.diff

[PATCH] D70588: Don't report "main" as missing a prototype in freestanding mode

This revision was automatically updated to reflect the committed changes. Closed by commit rG9180f8a57436: Dont report main as missing a prototype in freestanding mode (authored by void). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70588/new/

[clang] 9180f8a - Don't report "main" as missing a prototype in freestanding mode

Author: Bill Wendling Date: 2019-11-22T12:35:43-08:00 New Revision: 9180f8a57436da0ce91d9d4885702a10f89571bc URL: https://github.com/llvm/llvm-project/commit/9180f8a57436da0ce91d9d4885702a10f89571bc DIFF: https://github.com/llvm/llvm-project/commit/9180f8a57436da0ce91d9d4885702a10f89571bc.diff

[PATCH] D70071: [ConstExprPreter] Removed the flag forcing the use of the interpreter

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70071/new/ https://reviews.llvm.org/D70071

[PATCH] D70608: [OPENMP] [DOCS] correct status for use_device_addr clause

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c7a1c0cfc2a: [OPENMP] [DOCS] correct status for use_device_addr clause (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f22fe04a5c: [RISCV] Use compiler-rt if no GCC installation detected (authored by edward-jones). Changed prior to commit: https://reviews.llvm.org/D68407?vs=229284=230708#toc Repository: rG LLVM

[clang] 0c7a1c0 - [OPENMP] [DOCS] correct status for use_device_addr clause

Author: Kelvin Li Date: 2019-11-22T15:32:40-05:00 New Revision: 0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384 URL: https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384 DIFF: https://github.com/llvm/llvm-project/commit/0c7a1c0cfc2a4e5b8b7f3920b2797c12963b8384.diff

[clang] e0f22fe - [RISCV] Use compiler-rt if no GCC installation detected

Author: Edward Jones Date: 2019-11-22T20:05:29Z New Revision: e0f22fe04a5c9eb244ff0533549743b7deb03b99 URL: https://github.com/llvm/llvm-project/commit/e0f22fe04a5c9eb244ff0533549743b7deb03b99 DIFF: https://github.com/llvm/llvm-project/commit/e0f22fe04a5c9eb244ff0533549743b7deb03b99.diff LOG:

[PATCH] D70467: [Distro] Bypass distro detection on non-Linux hosts

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D70467#1755364 , @aganea wrote: > Actually, I'm not sure the `DetectDistro()` does what it intends to do when > cross-compiling: if I compile on Ubuntu

[PATCH] D69746: [analyzer] FixItHint: Apply and test hints with the Clang Tidy's script

NoQ added a comment. In D69746#1756448 , @gribozavr2 wrote: > > This patch introduces a way to apply the fix-its by the Analyzer: > > I'm not sure this option is very useful... I don't know of anyone who uses > the same option in Clang or ClangTidy. The

[PATCH] D67149: Fix argument order for BugType instation for

NoQ added a comment. Ah, the good old "stringly typed" APIs. Would you like to write a LIT test for the fix, say by `FileCheck`ing the Plist output? (i could write one for you if it's not your cup of tea) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67149/new/

[PATCH] D70613: Add method to ignore invisible AST nodes

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D70613 Files: clang/include/clang/AST/ASTNodeTraverser.h

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added a comment. In D70524#1757237 , @dblaikie wrote: > Generally if you're not touching LLVM code, I would suggest not adding an > LLVM test - unless this is new or surprising usage of existing LLVM > functionality (or the functionality was

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

xbolva00 added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/ https://reviews.llvm.org/D70342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70342: [Diagnostics] Put "deprecated copy" warnings into -Wdeprecated-copy

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks good to me - can handle anything else from @rsmith in post-commit review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70342/new/

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso updated this revision to Diff 230702. Charusso marked an inline comment as done. Charusso retitled this revision from "[analyzer][WIP] CERT: StrChecker: 31.c" to "[analyzer] CERT: StrChecker: 31.c". Charusso added a comment. - Remove the report storing map so we do not traverse

[PATCH] D70411: [analyzer] CERT: StrChecker: 31.c

Charusso added a comment. Now I have simplified the checker so we do not need any ASCII-art, I believe. Do we have any better logic than the current implementation to catch when the string is read? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/

[PATCH] D69620: Add AIX assembler support

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:37 + + // Specify the mode in which the as command operates. + if (IsArch32Bit) { Refer to the other comment regarding confusion of "as" with the English word.

[PATCH] D70111: [DWARF5]Addition of alignment field in the typedef for dwarf5

dblaikie added a comment. In D70111#1754702 , @awpandey wrote: > I am considering this > > - Will commit this without C bindings > - will give separate patch for C bindings and release notes (if necessary). > - will give another patch for Go bindings and

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

dblaikie added a comment. Generally if you're not touching LLVM code, I would suggest not adding an LLVM test - unless this is new or surprising usage of existing LLVM functionality (or the functionality was otherwise undertested in LLVM previously). But I'm guessing that's not the case here?

[PATCH] D70518: [clang-include-fixer] Suppress cmd prompt from Vim on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1e7b6f381a9: [clang-include-fixer] Suppress cmd prompt from Vim on Windows (authored by rnk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70518/new/

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

Eugene.Zelenko added a comment. Please mark addressed comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added inline comments. Comment at: llvm/test/DebugInfo/X86/debug-info-auto-return.ll:1 +;RUN: %llc_dwarf %s -filetype=obj -o - | llvm-dwarfdump -v - | FileCheck %s + I don't think the FORMs are relevant for this test, so we can do without the `-v`

[clang-tools-extra] e1e7b6f - [clang-include-fixer] Suppress cmd prompt from Vim on Windows

Author: Reid Kleckner Date: 2019-11-22T11:28:42-08:00 New Revision: e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9 URL: https://github.com/llvm/llvm-project/commit/e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9 DIFF: https://github.com/llvm/llvm-project/commit/e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9.diff

[PATCH] D70537: [clang] CGDebugInfo asserts `!DT.isNull()` when compiling with debug symbols

vsk requested changes to this revision. vsk added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1437 +if (isa(V)) + continue; + I see that we don't attempt to handle

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Wrapper tool is invoked at link phase, therefore there just could be no .bc files available to read data layout from. Ok, looks like there is no good solution for the data layout problem, so I will drop the idea of passing wrapper .bc directly to the linker when LTO

[PATCH] D70603: Change while to do-while

xbolva00 added a comment. This is fine as NFC/NFCI patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___ cfe-commits mailing list

[PATCH] D70603: Change while to do-while

pi1024e added a comment. What do you mean? I test compiled this and there are no errors after running the test benchmark. Was I supposed to do something else? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/

[PATCH] D70605: [OpenCL] Fix address space for implicit conversion (PR43145)

svenvh created this revision. svenvh added reviewers: Anastasia, rjmccall. Herald added a subscriber: yaxunl. Clang was creating a `DerivedToBase` `ImplicitCastExpr` that was also casting between address spaces as part of the second step in the standard conversion sequence. Defer the address

[PATCH] D70603: Change while to do-while

lebedev.ri added a comment. Missing a test; please upload all patches with full context (`-U9`) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70603/new/ https://reviews.llvm.org/D70603 ___

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

ABataev added a comment. In D70551#1757065 , @sdmitriev wrote: > I would agree with you if data layout was indeed available in the driver, but > unfortunately driver does not have access to any existing TargetInfo instance > (or maybe I just have not

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. I would agree with you if data layout was indeed available in the driver, but unfortunately driver does not have access to any existing TargetInfo instance (or maybe I just have not found it). So, I have to create TargetInfo and build data layout even for the case

[PATCH] D61837: Make it possible control matcher traversal kind with ASTContext

steveire updated this revision to Diff 230678. steveire added a comment. Rebase and update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61837/new/ https://reviews.llvm.org/D61837 Files: clang/include/clang/AST/ASTContext.h

[PATCH] D70603: Change while to do-while

pi1024e created this revision. pi1024e added a project: LLVM. Herald added a project: clang. Herald added a subscriber: cfe-commits. pi1024e added a reviewer: llvm.org. pi1024e edited reviewers, added: modocache, sammccall, Quuxplusone; removed: llvm.org. The assert statement says that the

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG01e8dd2e7a85: [libTooling] Add stencil combinators for nodes that may be pointers or values. (authored by ymandel). Repository: rG LLVM Github Monorepo

[clang] 01e8dd2 - [libTooling] Add stencil combinators for nodes that may be pointers or values.

Author: Yitzhak Mandelbaum Date: 2019-11-22T12:36:40-05:00 New Revision: 01e8dd2e7a852794a60e50f356f171f893503598 URL: https://github.com/llvm/llvm-project/commit/01e8dd2e7a852794a60e50f356f171f893503598 DIFF:

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

ABataev added a comment. In D70551#1756997 , @sdmitriev wrote: > Ok, it is possible to do it like you suggested, but I think that teaching > wrapper tool to set data layout without external help is more preferable. > There is a certain difference

[PATCH] D70551: [clang-offload-wrapper] Add data layout to the wrapper bitcode

sdmitriev added a comment. Ok, it is possible to do it like you suggested, but I think that teaching wrapper tool to set data layout without external help is more preferable. There is a certain difference between opt and wrapper tool – opt works on the existing .bc that is provided in command

[PATCH] D69180: [Format] Add format check for coroutine keywords with negative numbers

jonathoma added a comment. @modocache Feel free to commit from my end! Thanks again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69180/new/ https://reviews.llvm.org/D69180 ___ cfe-commits mailing

[PATCH] D70470: [analyzer] Add FuchsiaHandleCheck to catch handle leaks, use after frees and double frees

xazax.hun updated this revision to Diff 230668. xazax.hun added a comment. - Fix member operator modeling. - Added new lines to the end of files. - Added documentation. - Minor typo fixes in tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70470/new/ https://reviews.llvm.org/D70470

[PATCH] D70572: [Serialization] #pragma clang transform

Meinersbur updated this revision to Diff 230670. Meinersbur added a comment. - Remove some leftovers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70572/new/ https://reviews.llvm.org/D70572 Files: clang/include/clang/Serialization/ASTBitCodes.h

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:194 + The check now supports supports diagnosing and fixing arbitrary callables instead of + only simple free functions. The ``PermissiveParameterList`` option has also been + added to

[clang] 5459a90 - [OPENMP]Simplify processing of context selectors, NFC.

Author: Alexey Bataev Date: 2019-11-22T11:53:06-05:00 New Revision: 5459a905c23c03fad68e80b2dff23ca1ca3b7c7c URL: https://github.com/llvm/llvm-project/commit/5459a905c23c03fad68e80b2dff23ca1ca3b7c7c DIFF: https://github.com/llvm/llvm-project/commit/5459a905c23c03fad68e80b2dff23ca1ca3b7c7c.diff

[PATCH] D70368: [clang-tidy] Rewrite modernize-avoid-bind check

zturner updated this revision to Diff 230661. zturner added a comment. Addressed suggestions from @Eugene.Zelenko CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70368/new/ https://reviews.llvm.org/D70368 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

probinson added inline comments. Comment at: llvm/test/DebugInfo/X86/debug-info-auto-return.ll:30 +; CHECK: DW_TAG_subprogram [7] * +; CHECK-NEXT: DW_AT_linkage_name [DW_FORM_strx1](indexed (0007) string = "_ZN7myClass7findMaxEv") +; CHECK: DW_AT_type [DW_FORM_ref4]

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

modocache added a comment. Thanks again for the patch @junparser! And sorry the review took so long! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69022/new/ https://reviews.llvm.org/D69022 ___

[PATCH] D69022: [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b3d1d1348da: [coroutines] Remove assert on CoroutineParameterMoves in Sema… (authored by modocache). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 0b3d1d1 - [coroutines] Remove assert on CoroutineParameterMoves in Sema::buildCoroutineParameterMoves

Author: Brian Gesiak Date: 2019-11-22T11:39:13-05:00 New Revision: 0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f URL: https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f DIFF: https://github.com/llvm/llvm-project/commit/0b3d1d1348da78c8b12e89f138577b0a8ffd4b2f.diff

[PATCH] D70524: Support DebugInfo generation for auto return type for C++ functions.

aprantl added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:2925 +return C.getQualifiedType(T.getTypePtr(), Quals); + } case Type::DeducedTemplateSpecialization: { You need to mark this `LLVM_FALLTHROUGH` now or you'll get a

[clang] 6f7c876 - [OPENMP]Fix behaviour of defaultmap for OpenMP 4.5.

Author: Alexey Bataev Date: 2019-11-22T11:26:09-05:00 New Revision: 6f7c8760a5c01edaa8e9c8e48940e1b8a7aa4128 URL: https://github.com/llvm/llvm-project/commit/6f7c8760a5c01edaa8e9c8e48940e1b8a7aa4128 DIFF: https://github.com/llvm/llvm-project/commit/6f7c8760a5c01edaa8e9c8e48940e1b8a7aa4128.diff

[PATCH] D62574: Initial draft of target-configurable address spaces.

ebevhan marked 2 inline comments as done. ebevhan added a comment. Sorry for the very late response on this. Hope it's not completely off your radar. Comment at: include/clang/AST/ASTContext.h:2598 + /// Returns true if address space A overlaps with B. + bool

[clang] 26fa9e3 - Add support to find out resource dir and add it as compilation args

Author: Kousik Kumar Date: 2019-11-22T07:43:54-08:00 New Revision: 26fa9e31f58a7ff693f3a5d8c2eb1b6a5a13b133 URL: https://github.com/llvm/llvm-project/commit/26fa9e31f58a7ff693f3a5d8c2eb1b6a5a13b133 DIFF: https://github.com/llvm/llvm-project/commit/26fa9e31f58a7ff693f3a5d8c2eb1b6a5a13b133.diff

[PATCH] D69122: Add support to find out resource dir and add it as compilation args

This revision was automatically updated to reflect the committed changes. Closed by commit rG26fa9e31f58a: Add support to find out resource dir and add it as compilation args (authored by kousikk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D70485: [ARM,MVE] Add intrinsics to deal with predicates.

dmgreen accepted this revision. dmgreen added a comment. Thanks. I'm still happy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70485/new/ https://reviews.llvm.org/D70485 ___ cfe-commits mailing list

[PATCH] D69475: [clang] Provide better fix-it on exception spec error

jdemeule added a comment. Kindly ping reviewer. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69475/new/ https://reviews.llvm.org/D69475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D69282: [RFC] Add a VCS conflict marker format printing on tooling::ReplacementError

jdemeule added a reviewer: ioeric. jdemeule added a comment. Kindly ping reviewers and adding Eric as you were interested last year about that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69282/new/ https://reviews.llvm.org/D69282

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

gribozavr2 marked an inline comment as done. gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:96 +// Constructs an expression that idiomatically represents a value, taking into +// account whether `ExprId` is a pointer or already a

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Transformer/Stencil.h:90 +/// If \p ExprId is of pointer type, constructs an idiomatic dereferencing of +/// the expression bound to \p ExprId, including wrapping it in

[PATCH] D70554: [libTooling] Add stencil combinators for nodes that may be pointers or values.

ymandel updated this revision to Diff 230646. ymandel added a comment. renamed combinators; reordered cases to pair x and maybeX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70554/new/ https://reviews.llvm.org/D70554 Files:

  1   2   >