[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

kpn added a comment. In D69272#1792856 , @mibintc wrote: > In D69272#1717021 , @kpn wrote: > > > Is there a way forward to support having the #pragma at the start of any > > block inside a function? The effect

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked an inline comment as done. ABataev added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3952 + CGM.getOpenMPRuntime().isNontemporalDecl(Field)) || + (!E->isArrow() && BaseLV.isNontemporal())) +

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev updated this revision to Diff 234902. ABataev added a comment. Fix + rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71708/new/ https://reviews.llvm.org/D71708 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

mitchell-stellar accepted this revision. mitchell-stellar added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71769/new/ https://reviews.llvm.org/D71769

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong updated this revision to Diff 234901. martong added a comment. - Better handling of unknown values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71612/new/ https://reviews.llvm.org/D71612 Files:

[PATCH] D69272: Restricted variant of '#pragma STDC FENV_ACCESS'

mibintc added a comment. In D69272#1717021 , @kpn wrote: > Is there a way forward to support having the #pragma at the start of any > block inside a function? The effect won't be restricted to that block, true, > but the standard does say the #pragma is

[PATCH] D71726: Let clang atomic builtins fetch add/sub support floating point types

yaxunl added a comment. In D71726#1791904 , @jfb wrote: > This generally seems fine. Does it work on most backends? I want to make sure > it doesn't fail in backends :) For x86_64, amdgcn, aarch64, armv7, mips64, it is translated to cmpxchg by

[PATCH] D71769: [clang-format] C# formatting a class with inheritance followed by an attribute specifier assume its a braces initializer

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: mitchell-stellar, klimek, sammccall. MyDeveloperDay added a project: clang-format. Herald added a project: clang. MyDeveloperDay edited the summary of this revision. https://bugs.llvm.org/show_bug.cgi?id=44340 The rule that

[PATCH] D71708: [OPENMP50]Codegen for nontemporal clause.

ABataev marked 3 inline comments as done. ABataev added inline comments. Comment at: clang/lib/AST/StmtProfile.cpp:777 +if (E) + Profiler->VisitStmt(E); + } rjmccall wrote: > Can `E` actually be null here? No, remnants of the initial version.

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234890. sylvestre.ledru added a comment. Remove artifacts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 Files:

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. > But please, let's make that table heading nice. `Severity` is capitalised, > `name` is not, "has an autofix" sounds weird... Maybe "offers fixes" instead? Good point, thanks :) Done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. In D36051#1792684 , @Eugene.Zelenko wrote: > May be also split table by checks groups? Maybe? I would like to see this patch land first and iterate then on it. :) This patch is already a significant improvement over the

[PATCH] D36051: [clang-tidy] List the checkers with autofix

Eugene.Zelenko added a comment. May be also split table by checks groups? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051 ___ cfe-commits mailing list

[PATCH] D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

s.egerton created this revision. Herald added subscribers: cfe-commits, simoncook. Herald added a project: clang. s.egerton added reviewers: rsmith, akyrtzi, jordan_rose. Herald added a subscriber: dexonsmith. Previously, the -fdollars-in-identifiers flag allows the '$' symbol to be used in an

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

yaxunl marked 2 inline comments as done. yaxunl added a comment. In D71221#1791802 , @tra wrote: > What's the use case for this flag? If a kernel is launched with a block size greater than the default max block size, explicit launch bound is required.

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

gribozavr2 added a comment. @Ka-Ka Thanks for bringing it to our attention! I fixed these warnings in: https://github.com/llvm/llvm-project/commit/9caf12e8495c1106dd3d1079892ce4f39f91b7d2 https://github.com/llvm/llvm-project/commit/73f423e739bcb9bee7b73f05d4bcd50782013a8c Repository: rG LLVM

[clang] 73f423e - Parenthesized a logical expression.

Author: Dmitri Gribenko Date: 2019-12-20T14:36:21+01:00 New Revision: 73f423e739bcb9bee7b73f05d4bcd50782013a8c URL: https://github.com/llvm/llvm-project/commit/73f423e739bcb9bee7b73f05d4bcd50782013a8c DIFF:

[clang] 9caf12e - Use isa instead of dyn_cast

Author: Dmitri Gribenko Date: 2019-12-20T14:36:21+01:00 New Revision: 9caf12e8495c1106dd3d1079892ce4f39f91b7d2 URL: https://github.com/llvm/llvm-project/commit/9caf12e8495c1106dd3d1079892ce4f39f91b7d2 DIFF:

[PATCH] D36051: [clang-tidy] List the checkers with autofix

whisperity added a comment. In D36051#1792432 , @sylvestre.ledru wrote: > F0342: Screenshot_2019-12-20 clang-tidy - Clang-Tidy Checks — Extra Clang > Tools 10 documentation.png > here is the result Thank you

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong marked an inline comment as done. martong added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:32 + const MemRegion *BaseRegion = MRegion->getBaseRegion(); + assert(BaseRegion == Offset.getRegion()); + This

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidNonConstGlobalVariablesCheck.cpp:20 +namespace { +AST_MATCHER(VarDecl, isLocalVarDecl) { return Node.isLocalVarDecl(); } +} // namespace JonasToth wrote: > This

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

vingeldal updated this revision to Diff 234863. vingeldal marked 5 inline comments as done. vingeldal added a comment. Updating D70265 : [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines Adressed all comments: - Extended teseting - Updated

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

sammccall added a comment. Thanks for taking care of this! Comment at: clang/lib/Tooling/InterpolatingCompilationDatabase.cpp:194 -if (Std != LangStandard::lang_unspecified) // -std take precedence over -x +// Make use of -std iff -x was missing. +if (Type ==

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong marked 22 inline comments as done. martong added a comment. Thank you guys for the assiduous review! Comment at: clang/lib/StaticAnalyzer/Checkers/CheckPlacementNew.cpp:22 +ProgramStateRef State) const; + mutable std::unique_ptr

[PATCH] D71612: [analyzer] Add PlacementNewChecker

martong updated this revision to Diff 234857. martong marked 8 inline comments as done. martong added a comment. - Bugtype by value - Decompose Place to base region and offset - Add test for type hierarchy - Remove State check - Return directly with the size of the type in case of non-array new -

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lenary added a comment. Selfishly, I would like to see the addition of `rvintrin.h` separated from the bit-manipulation-specific headers. I'm looking at landing some additions to clang/LLVM that include builtins, and don't want to cause merge issues with this PR. I haven't yet had time to

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 234853. lewis-revill added a comment. Added .cfi_offset directives for registers saved by libcalls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 Files:

[PATCH] D64573: [Syntax] Allow to mutate syntax trees

Ka-Ka added inline comments. Comment at: clang/lib/Tooling/Syntax/Mutations.cpp:74 + + if (auto *Parent = llvm::dyn_cast(S->parent())) { +// A child of CompoundStatement can just be safely removed. This line introduce a buildbot fail:

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. F0342: Screenshot_2019-12-20 clang-tidy - Clang-Tidy Checks — Extra Clang Tools 10 documentation.png here is the result Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69876: Allow output constraints on "asm goto"

void updated this revision to Diff 234852. void marked 5 inline comments as done. void added a comment. - Improve the asm goto note in the language extensions doc. - Include another testcase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69876: Allow output constraints on "asm goto"

void added inline comments. Comment at: clang/docs/LanguageExtensions.rst:1275 +It's important to note that outputs are valid only on the "fallthrough" branch. +For example, the value assigned to `y` is not valid in the above `err` block. + nickdesaulniers

[PATCH] D71746: Fix the "TypeError: a bytes-like object is required, not 'str'" in exploded-graph-rewriter.py on Python 3.5+

psamolysov created this revision. psamolysov added reviewers: dergachev.a, clang. psamolysov added a project: clang. Herald added a subscriber: cfe-commits. When I run the 'exploded-graph-rewriter.py' tool on Windows using Python 3.5 and above, the following error and stack trace occurs:

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan updated this revision to Diff 234846. skan added a comment. 1. Add more tests for `!VK_NONE` cases. 2. Reduce pervasive `auto` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 Files: llvm/include/llvm/MC/MCAsmBackend.h

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

martong added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9286 + false /*UseCanonicalDecls*/); + (void)Ctx.IsEquivalent(D, Canon); +} Would it be possible to check the structural non-equivalency with `ODRHash`? I wonder

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2377eae286b: [clang][Tooling] Prefer -x over -std when interpolating (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71727/new/

[clang] c2377ea - [clang][Tooling] Prefer -x over -std when interpolating

Author: Kadir Cetinkaya Date: 2019-12-20T11:10:36+01:00 New Revision: c2377eae286bbe616267bef772ee736b030dd007 URL: https://github.com/llvm/llvm-project/commit/c2377eae286bbe616267bef772ee736b030dd007 DIFF:

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

lewis-revill updated this revision to Diff 234842. lewis-revill added a comment. Fixed existing .cfi_offset offsets. Since these are frame-pointer based they also need to account for the libcall stack adjustment. Currently working on adding .cfi_offset instructions for the registers saved by

[PATCH] D71694: [objc_direct] Tigthen checks for direct methods

teemperor added inline comments. Comment at: clang/test/CodeGenObjC/direct-method.m:196 +@implementation Foo (Cat) +// CHECK-LABEL: define hidden i32 @"\01-[Foo(Cat) directMethodInCategory]"( +- (int)directMethodInCategory { MadCoder wrote: > aprantl wrote: > >

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru updated this revision to Diff 234841. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Herald added a reviewer: jdoerfert. Herald added a project: clang. Move to the table idea... Two years after :) Repository: rG LLVM Github Monorepo

[PATCH] D71727: [clang][Tooling] Prefer -x over -std when interpolating

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71727/new/ https://reviews.llvm.org/D71727

[PATCH] D71745: clang-tidy doc: Move from a long list of checkers to tables

sylvestre.ledru created this revision. Herald added subscribers: cfe-commits, whisperity. Herald added a reviewer: jdoerfert. Herald added a project: clang. sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Done here: https://reviews.llvm.org/D36051 Currently, the list

[PATCH] D71745: clang-tidy doc: Move from a long list of checkers to tables

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. Done here: https://reviews.llvm.org/D36051 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71745/new/ https://reviews.llvm.org/D71745

[PATCH] D70258: [OpenMP][IR-Builder] Introduce the finalization stack

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70258/new/ https://reviews.llvm.org/D70258

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added a comment. In D70157#1792262 , @skan wrote: > Do you think this patch is ready to land? @MaskRay It is 00:35 here and I should confess that I haven't read through this yet. There are some minor things like (1) pervasive `auto` (2)

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

skan added a comment. Do you think this patch is ready to land? @MaskRay CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70527: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

This revision was automatically updated to reflect the committed changes. Ka-Ka marked 2 inline comments as done. Closed by commit rGe8efac4b1530: [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths (authored by Ka-Ka). Changed prior to commit:

[clang] e8efac4 - [clang] Fix the canonicalization of paths in -fdiagnostics-absolute-paths

Author: Karl-Johan Karlsson Date: 2019-12-20T09:16:33+01:00 New Revision: e8efac4b15303932581c128dc3976f4359388338 URL: https://github.com/llvm/llvm-project/commit/e8efac4b15303932581c128dc3976f4359388338 DIFF:

[PATCH] D70157: Align branches within 32-Byte boundary(NOP padding)

MaskRay added inline comments. Comment at: llvm/lib/MC/MCAssembler.cpp:1003 + // exists) also marks the end of the branch. + for (auto i = 0U, N = BF.isFused() ? 2U : 1U; + i != N && !isa(F); ++i, F = F->getNextNode()) { skan wrote: > MaskRay wrote: > >

<    1   2