[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define dso_loca

[PATCH] D71510: [clang][checkers] Added new checker 'error-return-checker'. (WIP)

balazske marked 3 inline comments as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/ErrorReturnChecker.cpp:77 +// This should work with any type of null value. +// FIXME: Is this different from the ValueErrorResultChecker with 0 as value? +cla

[PATCH] D67224: [clangd] Enable completions with fixes in VSCode

ilya-biryukov added a comment. In D67224#1804513 , @nridge wrote: > Just throwing a wild idea out there: what if we used > `textDocument/onTypeFormatting` to replace the `.` with `->` as soon as it's > typed? There is no way we can do this with proper

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:350 + const auto *MainFileEntry = SM.getFileEntryForID(SM.getMainFileID()); + if (!MainFileEntry) +return; Does this ever happen? Maybe `assert` it's not nul

[PATCH] D72276: [clang-format] Add IndentCaseBlocks option

MyDeveloperDay added a comment. Could you add an entry into the clang-format section of the clang release notes Comment at: clang/unittests/Format/FormatTest.cpp:1235 + "}", + Style)); } Could you add a test with indented ca

[PATCH] D72320: [NFC] Use isX86() instead of getArch()

Jim created this revision. Jim added reviewers: MaskRay, craig.topper. Herald added subscribers: llvm-commits, cfe-commits, rupprecht, hiraditya. Herald added a reviewer: jhenderson. Herald added projects: clang, LLVM. This is a clean up for https://reviews.llvm.org/D72247. Repository: rG LLVM

[clang] ab1bcda - [NFC] Use isX86() instead of getArch()

Author: Jim Lin Date: 2020-01-07T17:35:44+08:00 New Revision: ab1bcda851d95aeec03ffc1218bf9cae261a9280 URL: https://github.com/llvm/llvm-project/commit/ab1bcda851d95aeec03ffc1218bf9cae261a9280 DIFF: https://github.com/llvm/llvm-project/commit/ab1bcda851d95aeec03ffc1218bf9cae261a9280.diff LOG:

[PATCH] D72320: [NFC] Use isX86() instead of getArch()

This revision was automatically updated to reflect the committed changes. Closed by commit rGab1bcda851d9: [NFC] Use isX86() instead of getArch() (authored by Jim). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72320/new/ https://reviews.llvm.org/D7

Re: [clang] 24ab9b5 - Generalize the pass registration mechanism used by Polly to any third-party tool

On Mon, Jan 06, 2020 at 03:45:15PM -0800, Eric Christopher wrote: > Hi Serge, Hi Eric, > I have a few questions here about this: > > In general this appears to be a lot more complex than the existing plugin > solutions and requires quite a lot of custom cmake rules that are difficult to > mainta

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236541. usaxena95 marked 3 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-tool

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 marked 2 inline comments as done. usaxena95 added inline comments. Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:362 + R.Location.End.setColumn(Range.end.character); + R.Location.FileURI = MainFileURI.c_str(); + // FIXME: Add correct RefK

[PATCH] D64305: [clangd] Add path mappings functionality

sammccall added a comment. Thanks! The latest snapshot looks good. Landing it now with a few minor tweaks mentioned below. (And trivial local style things, we generally prefer to drop braces on simple if statements etc.) Comment at: clang-tools-extra/clangd/PathMapping.cpp:2

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

ilya-biryukov accepted this revision. ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:362 + R.Location.End.setColumn(Range.en

[PATCH] D70765: LTOVisibility.rst: fix up syntax in example

dankamongmen added a comment. > Typically the author commits the patch, unless they don't have commit access > and request the reviewer to commit for them, but I don't see a request for > that here. Thanks, Teresa. I indeed do not have commit access (so far as I know or can tell, anyway), so p

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60496 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D64305: [clangd] Add path mappings functionality

This revision was automatically updated to reflect the committed changes. Closed by commit rGc69ae835d0e0: [clangd] Add path mappings functionality (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D64305?vs=236295&id=236548#toc Repository: rG LLVM Github Monorepo C

[clang-tools-extra] c69ae83 - [clangd] Add path mappings functionality

Author: Sam McCall Date: 2020-01-07T12:40:51+01:00 New Revision: c69ae835d0e0dc493eb09e75f0687a1390525440 URL: https://github.com/llvm/llvm-project/commit/c69ae835d0e0dc493eb09e75f0687a1390525440 DIFF: https://github.com/llvm/llvm-project/commit/c69ae835d0e0dc493eb09e75f0687a1390525440.diff LO

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan updated this revision to Diff 236547. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72227/new/ https://reviews.llvm.org/D72227 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/intel-align-branch.c Index: clang/test/Driver/in

[PATCH] D72227: Add options for clang to align branches within 32B boundary

skan marked 5 inline comments as done. skan added inline comments. Comment at: clang/include/clang/Driver/Options.td:2217 + HelpText<"Specify the maximum number of prefixes on an instruction to " + "align branches. The number should be between 0 and 4.">; +def

[PATCH] D71422: [clangd] Introduce bulletlists

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/FormattedString.cpp:156 +// indented. +std::string indentLines(llvm::StringRef Input) { + std::string IndentedR; -

[PATCH] D72233: Add a new AST matcher 'optionally'.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit. Do you need someone to commit on your behalf? Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:282 REGISTER_MATCHER(hasIni

[PATCH] D72306: [PowerPC] FreeBSD >= 13 default ABI is ELFv2

adalava marked an inline comment as done. adalava added a comment. In D72306#1807097 , @MaskRay wrote: > Are you still using -target powerpc64-unknown-freebsd12.0-elfv2 or -target > powerpc64-unknown-freebsd12.0-elfv1 added in > https://reviews.llvm.org/

[clang] 3b417b7 - Fix "pointer is null" static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-07T13:41:52Z New Revision: 3b417b7cf73b6b5a2953ad4c8178b4394ea4f20e URL: https://github.com/llvm/llvm-project/commit/3b417b7cf73b6b5a2953ad4c8178b4394ea4f20e DIFF: https://github.com/llvm/llvm-project/commit/3b417b7cf73b6b5a2953ad4c8178b4394ea4f20e.diff LOG:

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

simon_tatham updated this revision to Diff 236564. simon_tatham added a comment. Thanks for the helpful advice! Here's a revised version that checks `getEvaluationKind`. I've also added a test for the `vld2q(...).val[0]` construction you mentioned: you're right, of course, that that also crashe

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236569. usaxena95 marked an inline comment as done. usaxena95 added a comment. Removed extra tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-too

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 60496 tests passed, 0 failed and 726 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72167: Add support for __declspec(guard(nocf))

ajpaverd updated this revision to Diff 236572. ajpaverd marked 5 inline comments as done. ajpaverd added a comment. Make guard_nocf an attribute of individual call instructions Instead of using "guard_nocf" as a function attribute, make this an attribute on individual call instructions for which

[clang-tools-extra] a000f2e - [clangd] Introduce bulletlists

Author: Kadir Cetinkaya Date: 2020-01-07T15:21:11+01:00 New Revision: a000f2e53f5c3433608f6097c3f4096e313b5f56 URL: https://github.com/llvm/llvm-project/commit/a000f2e53f5c3433608f6097c3f4096e313b5f56 DIFF: https://github.com/llvm/llvm-project/commit/a000f2e53f5c3433608f6097c3f4096e313b5f56.dif

[PATCH] D72167: Add support for __declspec(guard(nocf))

ajpaverd added a comment. In D72167#1803395 , @aaron.ballman wrote: > Can you please add some Sema tests that verify the attribute only appertains > to functions, accepts the right number of arguments, etc? Also, some tests > showing how this attribute

[PATCH] D71365: expand printf when compiling HIP to AMDGPU

b-sumner added a comment. Should this be looking forward to also handling OpenCL, which does require vector support? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71365/new/ https://reviews.llvm.org/D71365 __

[PATCH] D71422: [clangd] Introduce bulletlists

This revision was automatically updated to reflect the committed changes. kadircet marked 3 inline comments as done. Closed by commit rGa000f2e53f5c: [clangd] Introduce bulletlists (authored by kadircet). Changed prior to commit: https://reviews.llvm.org/D71422?vs=234059&id=236574#toc Reposito

[PATCH] D72167: Add support for __declspec(guard(nocf))

ajpaverd added a comment. In D72167#180 , @dmajor wrote: > Thanks for doing this! > > When I applied this patch and added `__declspec(guard(nocf))` to the function > that was giving us trouble >

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

Abpostelnicu created this revision. Abpostelnicu added a reviewer: alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Fixes fixes `readability-misleading-identation` for `if constexpr`. This is very similar to D71980 . Repos

[clang] 3f2e3dc - [OPENMP]Do not diagnose references to non-integral types for ref in

Author: Alexey Bataev Date: 2020-01-07T09:28:50-05:00 New Revision: 3f2e3dc44b42fab2e991222e74248b7006f1091e URL: https://github.com/llvm/llvm-project/commit/3f2e3dc44b42fab2e991222e74248b7006f1091e DIFF: https://github.com/llvm/llvm-project/commit/3f2e3dc44b42fab2e991222e74248b7006f1091e.diff

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

Abpostelnicu updated this revision to Diff 236580. Abpostelnicu added a comment. Updated the test case to better reflect the changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D72333 Files: clang-tools-ext

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 marked 7 inline comments as done. njames93 added a comment. What do you think about volatile qualifiers. Personally I don't think its important to qualify an volatile on a pointer that is volatile, but i should adhere to the decl being declared as volatile volatile auto X = getPointe

[PATCH] D72334: [Syntax] Build nodes for template declarations.

ilya-biryukov created this revision. ilya-biryukov added a reviewer: gribozavr2. Herald added a project: clang. ilya-biryukov added a parent revision: D72089: [Syntax] Build declarator nodes. ilya-biryukov updated this revision to Diff 236583. ilya-biryukov added a comment. - Cosmetics Handles t

[PATCH] D72334: [Syntax] Build nodes for template declarations.

ilya-biryukov updated this revision to Diff 236583. ilya-biryukov added a comment. - Cosmetics Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72334/new/ https://reviews.llvm.org/D72334 Files: clang/include/clang/Tooling/Syntax/Nodes.h clang/lib

[PATCH] D72334: [Syntax] Build nodes for template declarations.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72334: [Syntax] Build nodes for template declarations.

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

AntonYudintsev added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define ds

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

njames93 added a comment. I could never seem to get the tests to handle differently in templated and non templated code. Maybe i was just being stupid. Think the root cause is that the check detects if the if column appears on a different column to either the else or the closing brace if its on

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

logan-5 updated this revision to Diff 236593. logan-5 added a comment. Clean up some false positives in macro expansions and in expressions with nested potential ADL usages (e.g. in lambdas passed as function parameters). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[clang] 9f2d8b5 - [HIP] Add option --gpu-max-threads-per-block=n

Author: Yaxun (Sam) Liu Date: 2020-01-07T11:18:00-05:00 New Revision: 9f2d8b5c0cdb31c5617476575c03826274ecbd25 URL: https://github.com/llvm/llvm-project/commit/9f2d8b5c0cdb31c5617476575c03826274ecbd25 DIFF: https://github.com/llvm/llvm-project/commit/9f2d8b5c0cdb31c5617476575c03826274ecbd25.dif

[PATCH] D71221: [HIP] Add option --gpu-max-threads-per-block=n

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f2d8b5c0cdb: [HIP] Add option --gpu-max-threads-per-block=n (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

Abpostelnicu updated this revision to Diff 236596. Abpostelnicu added a comment. Updated test with match without compound statement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72333/new/ https://reviews.llvm.org/D72333 Files: clang-tools-extr

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:272 + if (const auto *Typedef = + Value->getReturnType().getTypePtr()->getAs()) { +addUsage(NamingCheckFailures, Typedef->getDecl(), ---

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/QualifiedAutoCheck.cpp:61 + Diag << FixItHint::CreateReplacement( + FixItRange, IsPtrConst ? "const auto *const " : "auto *const "); +} else { njames93 wrote:

[clang] 247a603 - [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

Author: Gabor Horvath Date: 2020-01-07T08:32:40-08:00 New Revision: 247a6032549efb03c14b79c035a47c660b75263e URL: https://github.com/llvm/llvm-project/commit/247a6032549efb03c14b79c035a47c660b75263e DIFF: https://github.com/llvm/llvm-project/commit/247a6032549efb03c14b79c035a47c660b75263e.diff

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

JonasToth added a comment. i am still fine with the patch. if no one else has objections, i think this can land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72284/new/ https://reviews.llvm.org/D72284 __

[PATCH] D62686: [RISCV] Add support for save/restore of callee-saved registers via libcalls

apazos added a comment. Lewis, is the patch final? It would be good to merge it before the 10.0 release branch creation on Jan 15th Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62686/new/ https://reviews.llvm.org/D62686 ___

[PATCH] D72097: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner annotations

This revision was automatically updated to reflect the committed changes. xazax.hun marked an inline comment as done. Closed by commit rG247a6032549e: [LifetimeAnalysis] Do not forbid void deref type in gsl::Pointer/gsl::Owner… (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D72289: [analyzer] Update help text to reflect sarif support

This revision was automatically updated to reflect the committed changes. Closed by commit rG46ac6a4dcd9b: [analyzer] Update help text to reflect sarif support (authored by xazax.hun). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72289/new/ https:/

[clang] 46ac6a4 - [analyzer] Update help text to reflect sarif support

Author: Gabor Horvath Date: 2020-01-07T08:37:49-08:00 New Revision: 46ac6a4dcd9b629188b75fafbe04008c24d1fb55 URL: https://github.com/llvm/llvm-project/commit/46ac6a4dcd9b629188b75fafbe04008c24d1fb55 DIFF: https://github.com/llvm/llvm-project/commit/46ac6a4dcd9b629188b75fafbe04008c24d1fb55.diff

[PATCH] D72284: [clang-tidy] Factor out renaming logic from readability-identifier-naming

aaron.ballman added inline comments. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:272 + if (const auto *Typedef = + Value->getReturnType().getTypePtr()->getAs()) { +addUsage(NamingCheckFailures, Typedef->getDecl(), ---

[PATCH] D68578: [HIP] Fix device stub name

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68578/new/ https://reviews.llvm.org/D68578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 marked an inline comment as done. njames93 added a comment. Would you say this behaviour is better? void baz() { auto MyFunctionPtr = getPtrFunction(); // CHECK-MESSAGES-NOT: :[[@LINE-1]]:3: warning: 'auto MyFunctionPtr' can be declared as 'auto *MyFunctionPtr' // CHECK-FI

[PATCH] D72233: Add a new AST matcher 'optionally'.

air20 marked an inline comment as done. air20 added a comment. In D72233#1806483 , @aaron.ballman wrote: > Just to make sure I understand the purpose -- the goal here is to optionally > match one or more inner matchers without failing even if none of the

[PATCH] D70764: build: reduce CMake handling for zlib

raj.khem added a comment. In D70764#1807405 , @smeenai wrote: > In D70764#1803559 , @raj.khem wrote: > > > this is now in master, and I am seeing build failures in cross-building > > clang, e.g. when building clang

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

nridge updated this revision to Diff 236608. nridge marked an inline comment as done. nridge added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72066/new/ https://reviews.llvm.org/D72066 Files: clang-tools-extra/clangd/u

[PATCH] D72282: [clang-tidy] Add `bugprone-unintended-adl`

JonasToth added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/UnintendedADLCheck.cpp:43 + Whitelist( + utils::options::parseStringList(Options.get("Whitelist", "swap"))) {} + logan-5 wrote: > JonasToth wrote: > > do you mean `st

[clang-tools-extra] 751d4da - [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

Author: Nathan Ridge Date: 2020-01-07T12:13:32-05:00 New Revision: 751d4dae3284c466481ed20ec0b76e894527d2c6 URL: https://github.com/llvm/llvm-project/commit/751d4dae3284c466481ed20ec0b76e894527d2c6 DIFF: https://github.com/llvm/llvm-project/commit/751d4dae3284c466481ed20ec0b76e894527d2c6.diff

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

This revision was automatically updated to reflect the committed changes. Closed by commit rG751d4dae3284: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D72066?vs=236608&id=236612#toc Repositor

[PATCH] D72333: [clang-tidy] Disable match on `if constexpr` statements in template instantiation for `readability-misleading-indentation` check.

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-misleading-indentation.cpp:172 +void call() { + mustPass(); + mustPass(); please add an case that does not get instantiated, with both bad and good indentation

[PATCH] D72066: [clangd] Assert that the testcases in LocateSymbol.All have no diagnostics

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61301 tests passed, 0 failed and 736 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72114: [MS] Overhaul how clang passes overaligned args on x86_32

rjmccall added inline comments. Comment at: clang/test/CodeGen/x86_32-arguments-win32.c:77 +// CHECK-LABEL: define dso_local void @receive_vec_256(<8 x float> inreg %x, <8 x float> inreg %y, <8 x float> inreg %z, <8 x float>* %0, <8 x float>* %1) +// CHECK-LABEL: define dso_loca

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236615. njames93 added a comment. adhere to coding guidelines, added check for local volatile qualifiers, disregard pointer addition on function pointer types CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

njames93 updated this revision to Diff 236617. njames93 added a comment. Added docs for const and volatile qualifiers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72217/new/ https://reviews.llvm.org/D72217 Files: clang-tools-extra/clang-tidy/readability/CMakeLists.txt clang-tools-

[PATCH] D72271: [Clang] Handle target-specific builtins returning aggregates.

rjmccall added a comment. In D72271#1807790 , @simon_tatham wrote: > The current return value of `EmitTargetBuiltinExpr` will be the `llvm::Value > *` corresponding to the last of a sequence of store instructions that writes > the constructed aggregate

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

usaxena95 updated this revision to Diff 236618. usaxena95 added a comment. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71406/new/ https://reviews.llvm.org/D71406 Files: clang-tools-extra/clangd/index/FileIndex.cpp clang-tools-ex

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

JonasToth added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-qualified-auto.cpp:183 + + auto LambdaTest = [] { return 0; }; + // CHECK-MESSAGES-NOT: :[[@LINE-1]]:3: warning: 'auto LambdaTest' can be declared as 'auto *LambdaTest' ---

[clang-tools-extra] 16f47cf - [clangd] Heuristically resolve dependent call through smart pointer type

Author: Nathan Ridge Date: 2020-01-07T12:52:03-05:00 New Revision: 16f47cf607c7193e888de4c1774c46367a5bedf4 URL: https://github.com/llvm/llvm-project/commit/16f47cf607c7193e888de4c1774c46367a5bedf4 DIFF: https://github.com/llvm/llvm-project/commit/16f47cf607c7193e888de4c1774c46367a5bedf4.diff

[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type

This revision was automatically updated to reflect the committed changes. Closed by commit rG16f47cf607c7: [clangd] Heuristically resolve dependent call through smart pointer type (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71

[PATCH] D71644: [clangd] Heuristically resolve dependent call through smart pointer type

nridge updated this revision to Diff 236621. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71644/new/ https://reviews.llvm.org/D71644 Files: clang-tools-extra/clangd/FindTarget.cpp clang-tools-ex

[PATCH] D61634: [clang/llvm] Allow efficient implementation of libc's memory functions in C/C++

tejohnson added a comment. In D61634#1515176 , @tejohnson wrote: > In D61634#1512020 , @gchatelet wrote: > > > AFAIU here is a coarse plan of what needs to happen > I've listed below what I believe is the status:

[PATCH] D71406: [clangd] Add xref for macros to FileIndex.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 61298 tests passed, 0 failed and 736 were skipped. {icon times-circle color=red} clang-tidy: fail. Please fix clang-tidy findings

[PATCH] D71433: [analyzer] CERT: POS34-C

Charusso accepted this revision. Charusso added a comment. This revision is now accepted and ready to land. I have created a `notes.cpp` test-file to test the notes in my checkers, but I think this checker is fine without that test file. @NoQ, what do you think? CHANGES SINCE LAST ACTION http

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

mstorsjo added a comment. Ping @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71572/new/ https://reviews.llvm.org/D71572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D71433: [analyzer] CERT: POS34-C

Charusso added a comment. In D71433#1784238 , @NoQ wrote: > Currently the check may warn on non-bugs of the following kind: > > void foo() { > char env[] = "NAME=value"; > putenv(env); > doStuff(); > putenv("NAME=anothervalue"); > } >

[PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

aaron.ballman added inline comments. Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 +// do not add a "\01" prefix. +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) { + Out << ALA->getLabel(); Sorry to dredge up an old review, but

[PATCH] D71572: [ItaniumCXXABI] Make tls wrappers comdat on Windows

rsmith added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2551 + // actually handle multiple TUs defining the same wrapper. + if (CGM.getTriple().isOSWindows() && CGM.supportsCOMDAT() && + Wrapper->isWeakForLinker()) mstorsjo wrote: > m

[clang-tools-extra] 75eacbf - Fix issues reported by -Wrange-loop-analysis when building with latest Clang (trunk). NFC.

Author: Alexandre Ganea Date: 2020-01-07T13:58:26-05:00 New Revision: 75eacbf1a9fbc29432a6e0c5627e6c8e95683956 URL: https://github.com/llvm/llvm-project/commit/75eacbf1a9fbc29432a6e0c5627e6c8e95683956 DIFF: https://github.com/llvm/llvm-project/commit/75eacbf1a9fbc29432a6e0c5627e6c8e95683956.dif

[clang] c972f6f - [OPENMP]Allow using of members in standalone declaration pragmas.

Author: Alexey Bataev Date: 2020-01-07T13:44:10-05:00 New Revision: c972f6fd7919b737f4c991d27249b9a947011c8e URL: https://github.com/llvm/llvm-project/commit/c972f6fd7919b737f4c991d27249b9a947011c8e DIFF: https://github.com/llvm/llvm-project/commit/c972f6fd7919b737f4c991d27249b9a947011c8e.diff

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

MaskRay created this revision. MaskRay added reviewers: Bdragon28, dim, adalava. Herald added subscribers: llvm-commits, cfe-commits, steven.zhang, jsji, dexonsmith, kbarton, hiraditya, krytarowski, arichardson, nemanjai, emaste. Herald added projects: clang, LLVM. The environments "elfv1" and "e

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

merge_guards_bot added a comment. Herald added a subscriber: wuzish. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts

[PATCH] D69779: -fmodules-codegen should not emit extern templates

llunak added a comment. In D69779#1801771 , @dblaikie wrote: > Ah, if I mark the standalone function template 'inline' (the implicit linkage > of member functions) then I get the same failure for both. Haven't tested > whether the fix is the same fix for

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

MaskRay updated this revision to Diff 236640. MaskRay added a comment. Simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72352/new/ https://reviews.llvm.org/D72352 Files: clang/lib/Basic/Targets/PPC.h clang/lib/Driver/ToolChains/Clang.cpp

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts : diff.

[PATCH] D72212: [Sema] Improve -Wrange-loop-analysis warnings

Mordante marked an inline comment as done. Mordante added a comment. You're welcome. It would be nice if we can get this one in the release. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72212/new/ https://reviews.llvm.org/D72212 ___

[PATCH] D72352: [Triple] Use elfv2 on freebsd>=13 and linux-musl

adalava accepted this revision. adalava added a comment. This revision is now accepted and ready to land. LGTM. Just a comment regarding FreeBSD 11.x. Comment at: clang/test/Driver/ppc-abi.c:27 +// RUN: %clang -target powerpc64-unknown-freebsd12 %s -### 2>&1 | FileCheck --ch

[clang] 4558842 - [OPENMP]Reduce calls for the mangled names.

Author: Alexey Bataev Date: 2020-01-07T14:28:17-05:00 New Revision: 45588428910a7cbcf58317b874dad18b580c9ce5 URL: https://github.com/llvm/llvm-project/commit/45588428910a7cbcf58317b874dad18b580c9ce5 DIFF: https://github.com/llvm/llvm-project/commit/45588428910a7cbcf58317b874dad18b580c9ce5.diff

[clang] fb6e80d - [test] Move ppc64 tests from test/Preprocessor/init.c to init-ppc64.c

Author: Fangrui Song Date: 2020-01-07T11:32:52-08:00 New Revision: fb6e80da446b94d42d484910ea28a82b4900f01f URL: https://github.com/llvm/llvm-project/commit/fb6e80da446b94d42d484910ea28a82b4900f01f DIFF: https://github.com/llvm/llvm-project/commit/fb6e80da446b94d42d484910ea28a82b4900f01f.diff

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

This revision was automatically updated to reflect the committed changes. Closed by commit rG8edf759ca7e1: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72352/new/ http

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

MaskRay updated this revision to Diff 236647. MaskRay added a comment. Add powerpc64-unknown-freebsd11 (its expected EOL is September 30, 2021) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72352/new/ https://reviews.llvm.org/D72352 Files: clang

[PATCH] D72352: [PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl

MaskRay updated this revision to Diff 236649. MaskRay retitled this revision from "[Triple] Use elfv2 on freebsd>=13 and linux-musl" to "[PowerPC][Triple] Use elfv2 on freebsd>=13 and linux-musl". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added a subscriber: shch

[PATCH] D50119: P1144 "Trivially relocatable" (0/3): Compiler support for `__is_trivially_relocatable(T)`

Quuxplusone added a comment. @rjmccall ping? any further thoughts on `[[maybe_trivially_relocatable]]`, in light of the followup libc++ patches? (Those patches do not use `[[maybe_trivially_relocatable]]`, although that may just be because I wrote them.) How could one go about getting this pat

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge updated this revision to Diff 236653. nridge added a comment. Remove no longer used flag from XRefTests.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72119/new/ https://reviews.llvm.org/D72119 Files: clang-tools-extra/clangd/FindTarge

[PATCH] D72355: [clangd] Assert that the testcases in FindExplicitReferencesTest.All have no diagnostics

nridge created this revision. nridge added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72355 Files: clang-tools-extra/clangd/un

[PATCH] D72119: [clangd] Handle DeducedTemplateSpecializationType in TargetFinder

nridge updated this revision to Diff 236652. nridge marked an inline comment as done. nridge added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72119/new/ https://reviews.llvm.org/D72119 Files: clang-tools-ext

Re: [PATCH] D67774: [Mangle] Add flag to asm labels to disable '\01' prefixing

On Tue, Jan 7, 2020 at 1:44 PM Aaron Ballman via Phabricator wrote: > aaron.ballman added inline comments. > > > > Comment at: cfe/trunk/lib/AST/Mangle.cpp:127 > +// do not add a "\01" prefix. > +if (!ALA->getIsLiteralLabel() || ALA->getLabel().startswith("llvm.")) { > +

  1   2   >