[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62325 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241351. serge-sans-paille added a comment. Fix documentation ordering, thank goes to @arichardson for spotting that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/

[PATCH] D69272: Enable '#pragma STDC FENV_ACCESS' in frontend

sepavloff updated this revision to Diff 241352. sepavloff added a comment. Avoid using custom attribute, use Function::useFPIntrin instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69272/new/ https://reviews.llvm.org/D69272 Files:

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

MaskRay added a comment. In D7#1847167 , @mrutland wrote: > In D7#1846796 , @mrutland wrote: > > > In D7#1839207 , @MaskRay wrote: > > > > > I shall also mention

[clang] 509e21a - [clang] Replace SmallStr.str().str() with std::string conversion operator.

Author: Jonas Devlieghere Date: 2020-01-29T21:27:46-08:00 New Revision: 509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e URL: https://github.com/llvm/llvm-project/commit/509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e DIFF:

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore added a comment. Looks in good shape  A couple nits and polish ideas. Comment at: clang-tools-extra/clang-tidy/objc/DeallocInCategoryCheck.cpp:34 + +void DeallocInCategoryCheck::check(const MatchFinder::MatchResult ) { + const auto *MatchedDecl =

Buildbot numbers for the week of 01/19/2020 - 01/25/2020

Hello everyone, Below are some buildbot numbers for the last week of 01/19/2020 - 01/25/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

Buildbot numbers for the week of 01/12/2020 - 01/18/2020

Hello everyone, Below are some buildbot numbers for the week of 01/12/2020 - 01/18/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from greed

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241335. yaxunl added a comment. Remove the ToDo for CUDA/HIP. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/test/CodeGenCUDA/norecurse.cu

[PATCH] D69978: Separately track input and output denormal mode

andrew.w.kaylor added inline comments. Comment at: llvm/docs/LangRef.rst:1829 + operations. The second indicates the handling of denormal inputs to + floating point instructions. + Based on the changes below, if the second value is omitted the input mode

[PATCH] D69868: Allow "callbr" to return non-void values

void added a comment. In D69868#1848327 , @MaskRay wrote: > @rnk Thoughts on passing live-in formation (a bit similar to WinEH catchpad) > to `callbr` at the SelectionDAG stage? To help with the review, here are some of the assumptions I'm making about

[PATCH] D72467: Remove "mask" operand from shufflevector.

efriedma updated this revision to Diff 241333. efriedma added a comment. Address review comments, rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72467/new/ https://reviews.llvm.org/D72467 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62315 tests passed, 0 failed and 838 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 114 warnings

[PATCH] D72717: [CMake] Disable libc++ filesystem tests in CrossWinToARMLinux cache file

ldionne added a comment. It's weird to mix Clang and libc++ test options because they test fundamentally different things. But I don't mind about this patch since it doesn't touch libc++ directly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

Quuxplusone added inline comments. Herald added a subscriber: rnkovacs. Comment at: clang/lib/AST/ASTImporter.cpp:1152 + if (Error E = importSeq(ToElementType, ToSizeExpr)) +return std::move(E); As the author of [P1155 "More Implicit

[PATCH] D73676: [Remarks] Extend the RemarkStreamer to support other emitters

thegameg created this revision. thegameg added reviewers: paquette, anemet, JDevlieghere, hfinkel, fhahn. thegameg added projects: LLVM, clang. Herald added subscribers: dang, dexonsmith, steven_wu, hiraditya, mgorny, mehdi_amini. This extends the RemarkStreamer to allow for other emitters (e.g.

[PATCH] D70099: [libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++

CaseyCarter abandoned this revision. CaseyCarter added a subscriber: STL_MSFT. CaseyCarter added a comment. @STL_MSFT seems to have already fixed this by removing the problem test cases in bf7dc572f199007cbe042d5ea41bcf873dcedd8f

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

rnk created this revision. rnk added reviewers: rsmith, aaron.ballman, a_sidorin. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a subscriber: teemperor. Herald added a project: clang. Use in-out parameters to avoid making

[PATCH] D69221: [clang][darwin] Fix search path logic for C_INCLUDE_DIRS

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. Do you have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69221/new/ https://reviews.llvm.org/D69221 ___ cfe-commits

[PATCH] D70099: [libcxx][test] Only call valarray::min and ::max on empty containers when testing libc++

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. You can go ahead and commit this. Comment at: test/std/numerics/numarray/template.valarray/valarray.members/min.pass.cpp:29 } +#ifdef _LIBCPP_VERSION // Not

[PATCH] D73357: [ARM,MVE] Add intrinsics for v[id]dupq and v[id]wdupq.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. Looks good, from what I can tell. Comment at: llvm/lib/Target/ARM/ARMISelDAGToDAG.cpp:2743 + uint16_t Opcode; + switch (VT.getVectorElementType().getSizeInBits()) { +

[PATCH] D69868: Allow "callbr" to return non-void values

MaskRay added a comment. @rnk Thoughts on passing live-in formation (a bit similar to WinEH catchpad) to `callbr` at the SelectionDAG stage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69868/new/ https://reviews.llvm.org/D69868

[PATCH] D73667: Speed up compilation of ASTImporter

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62308 tests passed, 1 failed and 838 were skipped. failed: libc++.std/thread/futures/futures_async/async.pass.cpp {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format:

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

craig.topper marked 2 inline comments as done. craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12363 +Cmp = Builder.CreateFCmp(Pred, Ops[0], Ops[1]); return EmitX86MaskedCompareResult(*this, Cmp, NumElts, Ops[3]); }

[PATCH] D73667: Speed up compilation of ASTImporter

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62309 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

t-tye added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:918 + // + // ToDo: clang does not support CUDA/HIP dynamic parallelism, therefore + // CUDA/HIP kernel can be marked with norecurse. This may change in the tra wrote: > I believe

[PATCH] D73667: Speed up compilation of ASTImporter

rnk added a comment. The `Expected>` and `std::tie` instantiations are still expensive, and they seem avoidable. We could use this code pattern instead: ExpectedType ASTNodeImporter::VisitVariableArrayType(const VariableArrayType *T) { QualType ToElementType = T->getElementType();

[PATCH] D73667: Speed up compilation of ASTImporter

rnk updated this revision to Diff 241297. rnk added a comment. Herald added a subscriber: rnkovacs. - remove unintended hack to test MSVC Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73667/new/ https://reviews.llvm.org/D73667 Files:

[PATCH] D73667: Speed up compilation of ASTImporter

rnk created this revision. rnk added reviewers: rsmith, aaron.ballman. Herald added a reviewer: martong. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added subscribers: llvm-commits, teemperor. Herald added projects: clang, LLVM. rnk updated this revision to Diff

[PATCH] D71607: [clang-tidy] Add unsigned subtraction warning, with suggestion to convert to unsigned literals.

sorenj added a comment. My colleague pointed out that -Wsigned-conversion will not detect this very frequent mistake for (size_t i = 0; i < v.size() - 1; ++i) It is my contention, and I think it's pretty well substantiated by reviewing cases where this detector fails that no coder ever

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen updated this revision to Diff 241293. cchen added a comment. Update due to negligence Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72811/new/ https://reviews.llvm.org/D72811 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen updated this revision to Diff 241291. cchen added a comment. Fix based on feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72811/new/ https://reviews.llvm.org/D72811 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

ychen added a comment. In D67847#1847757 , @rnk wrote: > If we can reland this patch, it should fix this new clang bug: > https://bugs.llvm.org/show_bug.cgi?id=44705 > > This was the list of failures you noted on the commit: > > In

[PATCH] D72829: Implement -fsemantic-interposition

arichardson added a comment. Thanks documentation looks much better now. Comment at: clang/docs/ClangCommandLineReference.rst:907 + +.. option:: -fsemantic-interposition, -fno-semantic-interposition + arichardson wrote: > arichardson wrote: > > This looks like

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev marked an inline comment as done. sdmitriev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:378 + // Creates temporary file with given contents. + Expected Create(Optional> Contents) { +SmallString<128u> File;

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added inline comments. Comment at: llvm/lib/AsmParser/LLParser.cpp:4858 /// ::= !DITemplateValueParameter(tag: DW_TAG_template_value_parameter, -/// name: "V", type: !1, value: i32 7) +/// name: "V",

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev updated this revision to Diff 241278. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 Files: clang/test/Driver/clang-offload-bundler.c

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added inline comments. Comment at: llvm/include/llvm/IR/DebugInfoMetadata.h:2134 protected: + bool isDefault; + Rename this (& the ctor/other parameters) to "IsDefault" to conform to LLVM's naming conventions (

[PATCH] D67847: [Support] make report_fatal_error `abort` instead of `exit`

rnk added a comment. If we can reland this patch, it should fix this new clang bug: https://bugs.llvm.org/show_bug.cgi?id=44705 This was the list of failures you noted on the commit: In rG647c3f4e47de8a850ffcaa897db68702d8d2459a#885042

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:371 +// object destruction. +struct TempFileList { + ~TempFileList() { If you have `private` members, it should be a class. Also, seems to me it is a RAII

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62312 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev updated this revision to Diff 241269. sdmitriev added a comment. Addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73642/new/ https://reviews.llvm.org/D73642 Files: clang/test/Driver/clang-offload-bundler.c

[PATCH] D72906: [X86] Improve X86 cmpps/cmppd/cmpss/cmpsd intrinsics with strictfp

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. lgtm I have a couple of comments, but nothing that couldn't be addressed in a later patch. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12363 +Cmp

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241265. yaxunl edited the summary of this revision. yaxunl added a comment. revised by Alexey's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73651/new/ https://reviews.llvm.org/D73651 Files: clang/lib/CodeGen/CodeGenFunction.cpp

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

bader added a comment. In D73651#1847862 , @yaxunl wrote: > Added handling of SYCL kernels by Alexey's comments. I cannot add a codegen > test for SYCL since I cannot find a way to instantiate a SYCL kernel. I think SYCL implementation should follow

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

yaxunl updated this revision to Diff 241256. yaxunl retitled this revision from "[OpenCL][CUDA][HIP] Add norecurse" to "[OpenCL][CUDA][HIP][SYCL] Add norecurse". yaxunl edited the summary of this revision. yaxunl added a comment. Herald added a subscriber: ebevhan. Added handling of SYCL kernels

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241254. serge-sans-paille added a comment. take @sfertile review into account. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files:

[PATCH] D73231: [CUDA] Assume the latest known CUDA version if we've found an unknown one.

hans added a comment. In D73231#1845096 , @tra wrote: > @hans : that's another candidate for 10.x cherry-pick, if you're OK with it. Sounds good to me. Cherry-picked in 5777899f146aaa53f598e6978702a7a2725200d7

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

mravishankar accepted this revision. mravishankar marked 2 inline comments as done. mravishankar added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:73 + + using mlir::matchers::m_Val; + auto a = m_Val(block.getArgument(0));

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/VforkChecker.cpp:109 "execvpe", + "execve", nullptr Well, this is not the case now, but I wonder if it would also make sense to sort this list alphabetically.

[PATCH] D73651: [OpenCL][CUDA][HIP] Add norecurse

bader added inline comments. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:923 +if ((getLangOpts().CPlusPlus && FD->isMain()) || getLangOpts().OpenCL || +(getLangOpts().CUDA && FD->hasAttr())) + Fn->addFnAttr(llvm::Attribute::NoRecurse);

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak updated this revision to Diff 241245. janvcelak added a comment. Sorry. I missed that step in contribution guidelines. I'm attaching updated version with larger context. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73629/new/ https://reviews.llvm.org/D73629 Files:

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

NoQ added a comment. Yup, thanks, nice catch! We should add a test for this (cf. `test/Analysis/vfork.c`). Also do you have any immediate opinions on https://bugs.llvm.org/show_bug.cgi?id=43871? 'Cause i'm super confused. Like, it's trivial to fix but i'm not sure what the correct behavior

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

ABataev added inline comments. Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:493-518 +// Temporary files that need to be removed. +struct TempFileList : public SmallVector, 2u> { + ~TempFileList() { +for (const auto : *this) +

[PATCH] D73651: [OpenCL][CUDA][HIP] Add norecurse

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM for CUDA. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:918 + // + // ToDo: clang does not support CUDA/HIP dynamic parallelism, therefore + // CUDA/HIP kernel can be

[PATCH] D73651: [OpenCL][CUDA][HIP] Add norecurse

yaxunl created this revision. yaxunl added reviewers: Anastasia, tra. norecurse function attr indicates the function is not called recursively directly or indirectly. Add norecurse to OpenCL functions and CUDA/HIP kernels. Although there is LLVM pass adding norecurse to functions, it only

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62282 tests passed, 0 failed and 827 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 7 warnings

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

This revision was automatically updated to reflect the committed changes. Closed by commit rGb500c49cd4f8: [clangd] Dont mmap source files on all platforms -- dont crash on git… (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73649: [CodeComplete] Member completion for concept-constrained types.

sammccall created this revision. sammccall added reviewers: nridge, saar.raz. Herald added subscribers: cfe-commits, mgrang. Herald added a project: clang. The basic idea is to walk through the concept definition, looking for t.foo() where t has the constrained type. In this patch: - nested

[clang-tools-extra] b500c49 - [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

Author: Sam McCall Date: 2020-01-29T19:44:14+01:00 New Revision: b500c49cd4f81f067cda721049cb1fd72a5e7bf5 URL: https://github.com/llvm/llvm-project/commit/b500c49cd4f81f067cda721049cb1fd72a5e7bf5 DIFF: https://github.com/llvm/llvm-project/commit/b500c49cd4f81f067cda721049cb1fd72a5e7bf5.diff

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

mbrkusanin added a comment. A few notes/questions: 1. Generated code was tested with Qemu: - For mips32r5 Qemu provides p5600 - For mips64r6 Qemu provides i6400 - For mips64r5 there is no cpu on Qemu with MSA and it appears that there won't be any hardware with Mips64r5 and MSA. - For

[PATCH] D73644: [Mips] Add intrinsics for 4-byte and 8-byte MSA loads/stores.

mbrkusanin created this revision. mbrkusanin added reviewers: atanasyan, petarj, sdardis, mstojanovic. mbrkusanin added projects: LLVM, clang. Herald added subscribers: cfe-commits, jrtc27, hiraditya, arichardson. New intrinisics are implemented for when we need to port SIMD code from other

[PATCH] D73642: [Clang][Bundler] Reduce fat object size

sdmitriev created this revision. sdmitriev added a reviewer: ABataev. Herald added a reviewer: alexshap. Herald added a reviewer: jdoerfert. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fat object size has significantly increased after D65819

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

Charusso added a reviewer: NoQ. Charusso added a comment. Hey, thanks! The patch looks great, but please note that we do the reviews with context using `git diff -U99` or uploading with `arc` (https://secure.phabricator.com/book/phabricator/article/arcanist/). Repository: rG LLVM Github

[PATCH] D73638: [AST] Move dependence computations into a separate file

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[clang] 8093d37 - Fix switch covers all cases static analyzer warning. NFCI.

Author: Simon Pilgrim Date: 2020-01-29T17:26:22Z New Revision: 8093d37ed2548ff5c8d6d7c51bd0431afbbf4209 URL: https://github.com/llvm/llvm-project/commit/8093d37ed2548ff5c8d6d7c51bd0431afbbf4209 DIFF: https://github.com/llvm/llvm-project/commit/8093d37ed2548ff5c8d6d7c51bd0431afbbf4209.diff

[PATCH] D72304: [OpenMP][OMPIRBuilder] Add Directives (master and critical) to OMPBuilder.

fghanim added a comment. Everything is fine! I just cloned llvm from git hub, added this revision with `arc patch`. then: `cmake -G"Unix Makefiles" -DLLVM_ENABLE_PROJECTS="clang;openmp" -DCMAKE_BUILD_TYPE=Release -DLLVM_OPTIMIZED_TABLEGEN=1 -DLLVM_USE_LINKER=gold ../llvm-project/llvm` `make` ,

[PATCH] D73638: [AST] Move dependence computations into a separate file

ilya-biryukov added a comment. @rsmith this does not pass through testing, I've messed up somewhere while moving the code. I'll find what went wrong and fix it tomorrow. Please tell if the approach itself LG. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D73617: [clangd] Don't mmap source files on all platforms --> don't crash on git checkout

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73617/new/ https://reviews.llvm.org/D73617

[PATCH] D57054: [MachineOutliner][ARM][RFC] Add Machine Outliner support for ARM

yroux updated this revision to Diff 241188. yroux added a comment. Here is a new version, which disables ARM Low Overhead Loops pass when the Machine Outliner is enabled. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57054/new/

[PATCH] D73637: Fix handling of OO_Spaceship in DecodeOperatorCall

sberg created this revision. sberg added reviewers: rsmith, EricWF. sberg added a project: clang. Herald added a subscriber: cfe-commits. This seems to be a leftover from d30b23d6a54b3f0883914f3c2c2318a78edcbe67 "[c++2a] P0515R3: Support for overloaded operator<=>." (The corresponding

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

This revision was automatically updated to reflect the committed changes. Closed by commit rG6e82d0dfd8df: [Clang][Bundler] Add exclude flag to target objects sections (authored by sdmitriev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/

[clang] 6e82d0d - [Clang][Bundler] Add 'exclude' flag to target objects sections

Author: Sergey Dmitriev Date: 2020-01-29T09:00:45-08:00 New Revision: 6e82d0dfd8dfaebc3985e73740a020b273a2dd31 URL: https://github.com/llvm/llvm-project/commit/6e82d0dfd8dfaebc3985e73740a020b273a2dd31 DIFF:

[PATCH] D73636: [AArch64][SVE] SVE2 intrinsics for complex integer arithmetic

kmclaughlin created this revision. kmclaughlin added reviewers: sdesmalen, dancgr, efriedma, cameron.mcinally, c-rhodes. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Adds the following SVE2

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

mrutland added a comment. In D7#1846796 , @mrutland wrote: > In D7#1839207 , @MaskRay wrote: > > > I shall also mention that we are essentially making decisions for x86 > > people's endbr32/endbr64. I hope

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62284 tests passed, 0 failed and 831 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72829: Implement -fsemantic-interposition

sfertile added a comment. In D72829#1846353 , @arichardson wrote: > As this is user-facing documentation I feel like there should be a slightly > longer explaning what the option does. +1 on this, otherwise LGTM. Thanks for implementing this!

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 ___ cfe-commits mailing list

[PATCH] D73408: [Clang][Bundler] Add 'exclude' flag to target objects sections

sdmitriev added a comment. Any additional comments? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73408/new/ https://reviews.llvm.org/D73408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin added a comment. @thakis I'm sorry sorry if it was not clear. Please let me know if you still prefer to have separate directory for clangTidyMain to have only one target per CMakeLists.txt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72829: Implement -fsemantic-interposition

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62300 tests passed, 0 failed and 837 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 added a comment. > This is an enabler for upcoming enhancements to indirect call promotion, for > example streamlined promotion guard sequences that compare against vtable > address instead of the target function Can you please describe the whole approach in more detail? At the

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/GlobalCompilationDatabase.cpp:122 +if (Entry.CDB) + vlog("Loaded CDB from {0}", Dir); } consider

[clang-tools-extra] 01213f9 - [clang-tidy] Initialize token before handing it to the lexer

Author: Benjamin Kramer Date: 2020-01-29T16:48:57+01:00 New Revision: 01213f90700dbb98a0dbcc01da8fdb89f6db5617 URL: https://github.com/llvm/llvm-project/commit/01213f90700dbb98a0dbcc01da8fdb89f6db5617 DIFF:

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62285 tests passed, 2 failed and 831 were skipped. failed: libc++.std/thread/thread_mutex/thread_mutex_requirements/thread_mutex_requirements_mutex/thread_mutex_recursive/lock.pass.cpp failed:

[PATCH] D73629: [analyzer] vfork checker: allow execve after vfork

janvcelak created this revision. janvcelak added a reviewer: dcoughlin. Herald added subscribers: cfe-commits, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. `execve` is missing in the list of functions

[PATCH] D73628: [clangd] Log directory when a CDB is loaded

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fixes https://github.com/clangd/clangd/issues/268 Repository: rG LLVM Github Monorepo

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2259 +``__builtin_memcpy_inline(dst, src, size)`` is identical to +``__builtin_memcpy(dst, src, size)`` expect that the generated code is +guaranteed not to call any external functions. See [LLVM IR

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth updated this revision to Diff 241155. tnorth added a comment. - Add release notes - Update ClangFormat.rst and ClangFormatStyleOption.rst Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72326/new/ https://reviews.llvm.org/D72326 Files:

[PATCH] D72326: [clang-format] Rebased on master: Add option to specify explicit config file

tnorth added a comment. In D72326#1845342 , @MyDeveloperDay wrote: > Nit: please add a release note and regenerate the ClangFormatStyleOptions.rst > (if there are any changes because you modified Format.h). Hmm, I tried to run

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

gchatelet updated this revision to Diff 241158. gchatelet marked 4 inline comments as done. gchatelet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73543/new/ https://reviews.llvm.org/D73543 Files:

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62287 tests passed, 0 failed and 831 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille added a comment. > As this is user-facing documentation I feel like there should be a slightly > longer explaning what the option does. done! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/

[PATCH] D72829: Implement -fsemantic-interposition

serge-sans-paille updated this revision to Diff 241152. serge-sans-paille added a comment. Update user-level documentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/ https://reviews.llvm.org/D72829 Files:

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

awpandey updated this revision to Diff 241141. awpandey added a comment. Thanks @dblaikie for figuring out the missing feature. I have added support for the non-type template parameter too. Please let me know if further modifications are required. I will happily address them. CHANGES SINCE

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

hokein updated this revision to Diff 241144. hokein added a comment. add trailing blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73624/new/ https://reviews.llvm.org/D73624 Files:

[PATCH] D73624: [clangd][vscode] Get rid of the deprecated vscode module in the extension.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov, dschuff. Herald added a project: clang. hokein updated this revision to Diff 241144. hokein added a comment. add trailing blank line. The

[PATCH] D72222: [Driver][CodeGen] Add -fpatchable-function-entry=N[,0]

mrutland added a comment. In D7#1839207 , @MaskRay wrote: > When -mbranch-protection=bti is used, due to > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92424 (existing GCC releases > have the issue), Linux/arch/arm64 has to make more checks to

[PATCH] D73285: [OpenMP][OMPIRBuilder][BugFix] Handle Unreachable Finalization blocks in `parallel` generation

fghanim marked an inline comment as done. fghanim added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:661 +AfterIP = InsertPointTy(ForkBB, ForkBB->end()); + } jdoerfert wrote: > fghanim wrote: > > jdoerfert wrote: > > > Why do we

[PATCH] D72829: Implement -fsemantic-interposition

sfertile added a comment. Aewsome, thanks for implementing this. I was on vacation for a bit and somehow missed this review in my queue when I cam back but having a look at it now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/

  1   2   >