[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Still LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520

Re: [clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

Should this be cherry-picked to 10.0? On 1/31/20, 7:09 PM, "cfe-commits on behalf of Richard Smith via cfe-commits" wrote: Author: Richard Smith Date: 2020-01-31T19:08:17-08:00 New Revision: 0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4 URL:

[clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

Author: Richard Smith Date: 2020-01-31T19:08:17-08:00 New Revision: 0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4 URL: https://github.com/llvm/llvm-project/commit/0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4 DIFF: https://github.com/llvm/llvm-project/commit/0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4.diff

[PATCH] D73651: [OpenCL][CUDA][HIP][SYCL] Add norecurse

keryell requested changes to this revision. keryell added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:918 + // + // SYCL v2.2 s2.10: + // kernels cannot include RTTI information, exception classes,

LLVM buildmaster will be updated and restarted soon

Hello everyone, LLVM buildmaster will be updated and restarted in the nearest hour. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72876: Create a clang-tidy check to warn when -dealloc is implemented inside an ObjC class category.

stephanemoore requested changes to this revision. stephanemoore added a comment. This revision now requires changes to proceed. One last correction and I think that you're all set! Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:284

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno updated this revision to Diff 241855. bruno added a comment. - Update patch after Volodymyr's review. - Refactor bits done as part of rG90f58eaeff5f , update it to remove that part. Repository: rG LLVM Github

[PATCH] D71734: [Modules] Handle tag types and complain about bad merges in C/Objective-C mode

bruno added a comment. > - Why are you adding ODR hash support for `RecordDecl` and not `TagDecl`? We > already have support for `EnumDecl`, so `TagDecl` seems like a good candidate > to cover both. Honestly, I don't know if it is possible or a good idea but it > looks plausible enough to

[PATCH] D65839: [Driver] Add verbatim dry run option

MaskRay added a comment. One thing I (a zsh user) feel inconvenient about `-###` is that... % echo -### zsh: bad pattern: -### % echo '-###' -### Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65839/new/ https://reviews.llvm.org/D65839

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

davidxl added inline comments. Comment at: llvm/test/Transforms/Inline/devirtualize-4.ll:2 +; RUN: opt < %s -passes='cgscc(devirt<4>(inline)),function(sroa,early-cse)' -S | FileCheck %s +; UN: opt < %s -passes='default' -S | FileCheck %s + typo ? UN:

[PATCH] D69591: Devirtualize a call on alloca without waiting for post inline cleanup and next DevirtSCCRepeatedPass iteration.

yamauchi updated this revision to Diff 241852. yamauchi added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang/test/CodeGenCXX/member-function-pointer-calls.cpp which this change combined with D71308 enables

[clang] aade5fb - Fix wrong devirtualization when the final overrider in one base class

Author: Richard Smith Date: 2020-01-31T17:06:48-08:00 New Revision: aade5fbbfef3e8555df202082bea905deebc2ca5 URL: https://github.com/llvm/llvm-project/commit/aade5fbbfef3e8555df202082bea905deebc2ca5 DIFF: https://github.com/llvm/llvm-project/commit/aade5fbbfef3e8555df202082bea905deebc2ca5.diff

[PATCH] D68520: [cmake] Fix clang builds with BUILD_SHARED=ON and CLANG_LINK_CLANG_DYLIB=ON

tstellar requested review of this revision. tstellar added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68520/new/ https://reviews.llvm.org/D68520 ___ cfe-commits mailing list

[PATCH] D65839: [Driver] Add verbatim dry run option

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. I'm fine with `-###-verbatim`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65839/new/ https://reviews.llvm.org/D65839

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

This revision was automatically updated to reflect the committed changes. Closed by commit rG27684ae66d55: Dont warn about missing declarations for partial template specializations (authored by aaronpuchert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 27684ae - Don't warn about missing declarations for partial template specializations

Author: Aaron Puchert Date: 2020-02-01T00:06:03+01:00 New Revision: 27684ae66d5545f211c0ac4393d0ba2bf3b5b47c URL: https://github.com/llvm/llvm-project/commit/27684ae66d5545f211c0ac4393d0ba2bf3b5b47c DIFF: https://github.com/llvm/llvm-project/commit/27684ae66d5545f211c0ac4393d0ba2bf3b5b47c.diff

[PATCH] D73810: [CMake][Fuchsia] Support for building on Windows

phosek updated this revision to Diff 241822. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73810/new/ https://reviews.llvm.org/D73810 Files: clang/cmake/caches/Fuchsia-stage2.cmake clang/cmake/caches/Fuchsia.cmake Index: clang/cmake/caches/Fuchsia.cmake

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

efriedma added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:1655 +TheCall->getArg(2)->isIntegerConstantExpr(I, Context); +if (I.isNullValue()) + break; You can EvaluateKnownConstInt here, instead of isIntegerConstantExpr.

[PATCH] D73810: [CMake][Fuchsia] Support for building on Windows

phosek created this revision. phosek added reviewers: leonardchan, mcgrathr. Herald added subscribers: cfe-commits, mstorsjo, jfb, mgorny. Herald added a project: clang. This change adds the necessary flags for building the full Fuchsia toolchain on Windows. Repository: rG LLVM Github

[PATCH] D73543: [clang] Add support for __builtin_memcpy_inline

efriedma added inline comments. Comment at: clang/docs/LanguageExtensions.rst:2252 + + * ``__builtin_memcpy_inline`` + This is in the wrong section of the documentation. We could constant-evaluate __builtin_memcpy_inline, I guess, but that isn't the primary

[clang-tools-extra] c0f475f - Revert "[clang-doc] Improving Markdown Output"

Author: Petr Hosek Date: 2020-01-31T14:30:42-08:00 New Revision: c0f475f2e3c3304fb7fc116fdab7871f1d903810 URL: https://github.com/llvm/llvm-project/commit/c0f475f2e3c3304fb7fc116fdab7871f1d903810 DIFF: https://github.com/llvm/llvm-project/commit/c0f475f2e3c3304fb7fc116fdab7871f1d903810.diff

[PATCH] D72954: [clang-doc] Improving Markdown Output

This revision was automatically updated to reflect the committed changes. Closed by commit rGdeae8ee69167: [clang-doc] Improving Markdown Output (authored by phosek). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15554 +LocatorChecker Checker; +if (Checker.Visit(OrigExpr)) { + llvm::copy(Checker.getComponents(), cchen wrote: > ABataev wrote: > > cchen wrote: > > > ABataev

[clang-tools-extra] deae8ee - [clang-doc] Improving Markdown Output

Author: Petr Hosek Date: 2020-01-31T14:21:21-08:00 New Revision: deae8ee6916711b9b20f73fc1a350c3a034d5b34 URL: https://github.com/llvm/llvm-project/commit/deae8ee6916711b9b20f73fc1a350c3a034d5b34 DIFF: https://github.com/llvm/llvm-project/commit/deae8ee6916711b9b20f73fc1a350c3a034d5b34.diff

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15554 +LocatorChecker Checker; +if (Checker.Visit(OrigExpr)) { + llvm::copy(Checker.getComponents(), ABataev wrote: > cchen

[PATCH] D71092: [VFS] More consistent support for Windows

rnk added a comment. I was worried there would be more duplication. :) As far as rebuilding the wheel square goes, this seems totally reasonable. I had a question and a nit, though. Comment at: llvm/lib/Support/VirtualFileSystem.cpp:-1113 + sys::path::Style style =

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15554 +LocatorChecker Checker; +if (Checker.Visit(OrigExpr)) { + llvm::copy(Checker.getComponents(), cchen wrote: > ABataev wrote: > > General question about

[PATCH] D72811: [WIP][OPENMP5.0] allow lvalue for motion clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15554 +LocatorChecker Checker; +if (Checker.Visit(OrigExpr)) { + llvm::copy(Checker.getComponents(), ABataev wrote: > General

[clang] de876ad - [diagtree] Use a different color for unimplemented GCC diagnostic flags

Author: Richard Smith Date: 2020-01-31T13:40:32-08:00 New Revision: de876adab0cb43b79ffc7c5e66cc9053accbb074 URL: https://github.com/llvm/llvm-project/commit/de876adab0cb43b79ffc7c5e66cc9053accbb074 DIFF: https://github.com/llvm/llvm-project/commit/de876adab0cb43b79ffc7c5e66cc9053accbb074.diff

[clang] 42d4a55 - PR44723: Trigger return type deduction for operator<=>s whose return

Author: Richard Smith Date: 2020-01-31T13:06:48-08:00 New Revision: 42d4a55f227a1cc78ab8071062d869abe88655d9 URL: https://github.com/llvm/llvm-project/commit/42d4a55f227a1cc78ab8071062d869abe88655d9 DIFF: https://github.com/llvm/llvm-project/commit/42d4a55f227a1cc78ab8071062d869abe88655d9.diff

[PATCH] D69978: Separately track input and output denormal mode

andrew.w.kaylor accepted this revision. andrew.w.kaylor added a comment. This revision is now accepted and ready to land. lgtm CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69978/new/ https://reviews.llvm.org/D69978 ___ cfe-commits mailing

[PATCH] D71092: [VFS] More consistent support for Windows

amccarth added a comment. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71092/new/ https://reviews.llvm.org/D71092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

tonyelewis added a comment. > Support for checking types should be either opt-in(or opt-out) but never > forced. I feel like it would generate too much noise. Okey dokes. That option could always be added as another feature in the future. Thanks very much for all work on this.

[PATCH] D73570: [FPEnv][X86] Platform-specific builtin constrained FP enablement

kpn updated this revision to Diff 241771. kpn added a comment. Address review comments: FMA tests are now run optimized. This changes where the FIXME lines are located. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73570/new/

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

rsmith accepted this revision. rsmith added a comment. Sorry I missed this before now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68923/new/ https://reviews.llvm.org/D68923 ___ cfe-commits mailing

Re: [clang] b7ce85a - [Concepts] Fix isDeclarationSpecifier to detect type-constraints correctly

On Fri, 31 Jan 2020, 10:08 Saar Raz via cfe-commits, < cfe-commits@lists.llvm.org> wrote: > > Author: Saar Raz > Date: 2020-01-31T20:08:13+02:00 > New Revision: b7ce85a130789d23c69156f4b899962458d1f05d > > URL: > https://github.com/llvm/llvm-project/commit/b7ce85a130789d23c69156f4b899962458d1f05d

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62372 tests passed, 0 failed and 839 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73687/new/ https://reviews.llvm.org/D73687 ___ cfe-commits mailing list

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

Eugene.Zelenko added a comment. In D73580#1852032 , @njames93 wrote: > It looks good, but could you maybe create a child revision showing what it > looks like with a few checks renamed to make sure everything is all working > correctly. I think it'll

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added inline comments. Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:1808-1809 Record.push_back(VE.getMetadataOrNullID(N->getType())); + if (M.getDwarfVersion() >= 5) +Record.push_back(N->getDefault());

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

rjmccall added a comment. If it's reasonable to persist the failure kind, that would probably be good, but it might be a lot of work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73360/new/ https://reviews.llvm.org/D73360 ___ cfe-commits

[clang] b7ce85a - [Concepts] Fix isDeclarationSpecifier to detect type-constraints correctly

Author: Saar Raz Date: 2020-01-31T20:08:13+02:00 New Revision: b7ce85a130789d23c69156f4b899962458d1f05d URL: https://github.com/llvm/llvm-project/commit/b7ce85a130789d23c69156f4b899962458d1f05d DIFF: https://github.com/llvm/llvm-project/commit/b7ce85a130789d23c69156f4b899962458d1f05d.diff

[PATCH] D71033: [analyzer] CERT: STR32-C

Charusso updated this revision to Diff 241761. Charusso added a comment. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71033/new/ https://reviews.llvm.org/D71033 Files: clang/docs/analyzer/checkers.rst clang/include/clang/StaticAnalyzer/Checkers/Checkers.td

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

aprantl added a comment. In D73462#1851129 , @awpandey wrote: > @aprantl Thanks for your valuable feedback. > > I have a doubt. You need a .ll file its corresponding llvm bytecode generated > by current llvm (without my patch). Doest this ll file

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso updated this revision to Diff 241758. Charusso marked an inline comment as done. Charusso added a comment. - Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70805/new/ https://reviews.llvm.org/D70805 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 241757. bader added a comment. Applied suggestion from Ruyman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D70805: [analyzer] SValHasDescendant: Determine whether the SVal has an SVal descendant

Charusso marked 2 inline comments as done. Charusso added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/SValHasDescendant.h:55 + bool VisitSymbolRegionValue(const SymbolRegionValue *S) { +return Visit(S->getRegion()); + }

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso updated this revision to Diff 241752. Charusso edited the summary of this revision. Charusso added a comment. - 2020-ify the checker writing - Remove extra bullet-points of CERT checker documentation: we only need the checker's documentation, not the packages. CHANGES SINCE LAST

[PATCH] D69726: [analyzer] DynamicSize: Store the dynamic size

Charusso updated this revision to Diff 241749. Charusso edited the summary of this revision. Charusso added a comment. - Let us reuse this patch. - Remove the expression storing feature. - Only store known sizes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69726/new/

[PATCH] D61716: [libclang] Expose AtomicType

slowhog updated this revision to Diff 241747. slowhog added a reviewer: aaron.ballman. slowhog added a comment. Updated to latest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61716/new/ https://reviews.llvm.org/D61716 Files:

[PATCH] D73715: - Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory

This revision was automatically updated to reflect the committed changes. Closed by commit rGf99133e853bf: - Update .clang-tidy to ignore parameters of main like functions for naming… (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] f99133e - - Update .clang-tidy to ignore parameters of main like functions for naming violations in clang and llvm directory

Author: Nathan James Date: 2020-01-31T16:49:45Z New Revision: f99133e853bfd2456b334e70933ec0403ad512d6 URL: https://github.com/llvm/llvm-project/commit/f99133e853bfd2456b334e70933ec0403ad512d6 DIFF: https://github.com/llvm/llvm-project/commit/f99133e853bfd2456b334e70933ec0403ad512d6.diff LOG:

[PATCH] D73580: [clang-tidy] rename_check.py: maintain alphabetical order in Renamed checks section

njames93 added a comment. It looks good, but could you maybe create a child revision showing what it looks like with a few checks renamed to make sure everything is all working correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73580/new/

[PATCH] D73413: [clang-tidy] Add check to detect external definitions with no header declaration

njames93 marked 2 inline comments as done. njames93 added a comment. In D73413#1851432 , @tonyelewis wrote: > Thanks so much for all the effort on this. I think it's really wonderful. > > I've added a couple of comments elsewhere. > > My other query:

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62288 tests passed, 8 failed and 837 were skipped. failed: LLVM.CodeGen/AMDGPU/branch-relaxation.ll failed: LLVM.CodeGen/AMDGPU/cf-loop-on-constant.ll failed: LLVM.CodeGen/AMDGPU/infinite-loop.ll failed:

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62288 tests passed, 8 failed and 837 were skipped. failed: LLVM.CodeGen/AMDGPU/branch-relaxation.ll failed: LLVM.CodeGen/AMDGPU/cf-loop-on-constant.ll failed: LLVM.CodeGen/AMDGPU/infinite-loop.ll failed:

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 241735. hokein added a comment. add trailing blank line Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein updated this revision to Diff 241734. hokein marked 3 inline comments as done. hokein added a comment. update, and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73780/new/ https://reviews.llvm.org/D73780 Files:

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein added a comment. In D73780#1851654 , @kadircet wrote: > LG. I might be missing some context though, what's the reasoning behind? > Because, I think it is not necessary to treat protobufs differently. > > It might be sensible to have a more generic

[PATCH] D73701: [clang] fix linkage of nested lambda

hliao accepted this revision. hliao added a comment. This revision is now accepted and ready to land. LGTM, but need @rsmith for the final review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73701/new/ https://reviews.llvm.org/D73701

[PATCH] D73786: [ARM,MVE] Fix vreinterpretq in big-endian mode.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, kristof.beyls. Herald added projects: clang, LLVM. In big-endian MVE, the simple vector load/store instructions (i.e. both

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

kmclaughlin marked 2 inline comments as done. kmclaughlin added a comment. Thanks for reviewing this, @efriedma! Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td: + LLVMSubdivide4VectorType<0>, + llvm_i32_ty], +

[PATCH] D73687: [AArch64][SVE] Add SVE2 intrinsics for complex integer dot product

kmclaughlin updated this revision to Diff 241726. kmclaughlin added a comment. - Removed the AdvSIMD_SVE_CDOT_Intrinsic class - Added ImmArg<4> to AdvSIMD_SVE_CDOT_LANE_Intrinsic CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73687/new/ https://reviews.llvm.org/D73687 Files:

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1168 + Error Err = Error::success(); + QualType ToElementType = T->getElementType(); + Expr *ToSizeExpr = T->getSizeExpr(); shafik wrote: > Should this group be using `importChecked` as

[PATCH] D73360: [OpenCL] Restrict address space conversions in nested pointers

Anastasia added a comment. In D73360#1850001 , @rjmccall wrote: > Is there no follow-up code when actually emitting the failure diagnostic > which tries to figure out a more specific cause of failure? After looking at this a bit more it seems C++ part

[PATCH] D68923: Don't warn about missing declarations for partial template specializations

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. I think the pings have gone on long enough -- if there's an issue with the patch, we can address it post-commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/RedundantExpressionCheck.cpp:335 +return AsTExpr; + else +return nullptr; Please don;e use else after return. Comment at:

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

This revision was automatically updated to reflect the committed changes. antiagainst marked an inline comment as done. Closed by commit rGdf71000d7d5d: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops (authored by antiagainst). Changed prior to commit:

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov updated this revision to Diff 241718. ilya-biryukov added a comment. Fix compilation after rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/ https://reviews.llvm.org/D69330 Files:

[PATCH] D73762: [clang] New warning for for-loops where the iteration does not match the loop condition

Eugene.Zelenko added a comment. Check should also consider cases like: i += 2; i = i + 2; i -= 2; i = i - 2. Probably same with multiplications, divisions and shifts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73762/new/

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon question-circle color=gray} clang-tidy: unknown. {icon question-circle color=gray} clang-format: unknown. Build artifacts :

Re: patch via mailing list: Use getLocation() in too few/many arguments diagnostic

This patch has been languishing for 10 days, and it has been pointed out on cfe-dev that it is important to directly CC appropriate reviewers. As there's no-one listed in clang/CODE_OWNERS.TXT for diagnostics, I've now CCed "all other parts" Richard. On 20 Jan 2020, at 16:09, John Marshall via

[PATCH] D72401: Fixes for spaces around C# object initializers

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bb60e29f18b: [clang-format] Fixes for spaces around C# object initializers (authored by Jonathan Coe jb...@google.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

ilya-biryukov updated this revision to Diff 241717. ilya-biryukov added a comment. Herald added a subscriber: bmahjour. - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69330/new/ https://reviews.llvm.org/D69330 Files:

[clang] 0bb60e2 - [clang-format] Fixes for spaces around C# object initializers

Author: Jonathan Coe Date: 2020-01-31T14:22:01Z New Revision: 0bb60e29f18bd45fc26d5f619150f28fc7541e9b URL: https://github.com/llvm/llvm-project/commit/0bb60e29f18bd45fc26d5f619150f28fc7541e9b DIFF: https://github.com/llvm/llvm-project/commit/0bb60e29f18bd45fc26d5f619150f28fc7541e9b.diff LOG:

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1181 + Error Err = Error::success(); + QualType ToElementType = T->getElementType(); + Expr *ToSizeExpr = T->getSizeExpr(); `importChecked`? Repository: rG LLVM Github Monorepo

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:1168 + Error Err = Error::success(); + QualType ToElementType = T->getElementType(); + Expr *ToSizeExpr = T->getSizeExpr(); Should this group be using `importChecked` as well?

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

merge_guards_bot added a comment. {icon times-circle color=red} Unit tests: fail. 62288 tests passed, 8 failed and 837 were skipped. failed: LLVM.CodeGen/AMDGPU/branch-relaxation.ll failed: LLVM.CodeGen/AMDGPU/cf-loop-on-constant.ll failed: LLVM.CodeGen/AMDGPU/infinite-loop.ll failed:

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov added a comment. As soon as I add a new enum value, this starts crashing some tests (even if we don't ever set the flag or serialize it). Not sure what causes it and won't have time to figure it out before I leave. Sorry about that :( Repository: rG LLVM Github Monorepo

[PATCH] D69978: Separately track input and output denormal mode

arsenm updated this revision to Diff 241714. arsenm marked an inline comment as done. arsenm added a comment. Tweak langref CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69978/new/ https://reviews.llvm.org/D69978 Files: clang/include/clang/Basic/CodeGenOptions.h

[PATCH] D73701: [clang] fix linkage of nested lambda

blastrock updated this revision to Diff 241713. blastrock edited the summary of this revision. blastrock added a reverted change: D1783: Allow nested lambdas in NSDMIs (i.e default initializers). blastrock added a comment. Thank you for the answers. I have removed all the outermost lambda code

[PATCH] D69978: Separately track input and output denormal mode

arsenm marked 3 inline comments as done. arsenm added inline comments. Comment at: llvm/docs/LangRef.rst:1829 + operations. The second indicates the handling of denormal inputs to + floating point instructions. + andrew.w.kaylor wrote: > Based on the changes

[PATCH] D73723: [clangd][Hover] Handle uninstantiated default args

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62330 tests passed, 0 failed and 838 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D73675: Avoid many std::tie/tuple instantiations in ASTImporter

shafik added a comment. Thank you for this work, it is awesome! I really like the removal of `importSeq` I feel like the resulting code is more clear. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73675/new/ https://reviews.llvm.org/D73675

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

antiagainst marked 4 inline comments as done. antiagainst added inline comments. Comment at: mlir/lib/Conversion/LinalgToSPIRV/LinalgToSPIRV.cpp:125 + +PatternMatchResult SingleWorkgroupReduction::matchAndRewrite( +linalg::GenericOp genericOp, ArrayRef operands,

[PATCH] D73723: [clangd][Hover] Handle uninstantiated default args

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c903d0373ff: [clangd][Hover] Handle uninstantiated default args (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73723/new/

[PATCH] D73437: [mlir][spirv] Convert linalg.generic for reduction to SPIR-V ops

nicolasvasilache accepted this revision. nicolasvasilache added a comment. This revision is now accepted and ready to land. Herald added a subscriber: Joonsoo. Thanks Lei, this looks great, glad to see you pushing on this front! Comment at:

[clang-tools-extra] 9c903d0 - [clangd][Hover] Handle uninstantiated default args

Author: Kadir Cetinkaya Date: 2020-01-31T15:03:33+01:00 New Revision: 9c903d0373ff940f9143efab8d948edf776de9f1 URL: https://github.com/llvm/llvm-project/commit/9c903d0373ff940f9143efab8d948edf776de9f1 DIFF:

[PATCH] D73723: [clangd][Hover] Handle uninstantiated default args

kadircet updated this revision to Diff 241707. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73723/new/ https://reviews.llvm.org/D73723 Files:

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

evgeny777 added a comment. This patch is to be rebased against D73094 Comment at: llvm/include/llvm/IR/ModuleSummaryIndex.h:830 enum Kind { +Unknown, ///< Unknown (analysis not performed, don't lower) Unsat, ///<

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

kadircet added a comment. LG. I might be missing some context though, what's the reasoning behind? Because, I think it is not necessary to treat protobufs differently. It might be sensible to have a more generic `isSymbolFromGeneratedFile` filter, but also for this one I don't see any

[clang] ba1f3db - [Concepts] Correctly form initial parameter mapping for parameter packs, support substitution into SubstNonTypeTemplateParmExpr

Author: Saar Raz Date: 2020-01-31T15:59:42+02:00 New Revision: ba1f3db4b0729ad932aa4f091e9578132d98a0c8 URL: https://github.com/llvm/llvm-project/commit/ba1f3db4b0729ad932aa4f091e9578132d98a0c8 DIFF: https://github.com/llvm/llvm-project/commit/ba1f3db4b0729ad932aa4f091e9578132d98a0c8.diff

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

ilya-biryukov updated this revision to Diff 241706. ilya-biryukov added a comment. Herald added a subscriber: bmahjour. Rebase on top of refactored dependence propagation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/

[PATCH] D72401: Fixes for spaces around C# object initializers

krasimir accepted this revision. krasimir added a comment. This revision is now accepted and ready to land. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72401/new/ https://reviews.llvm.org/D72401 ___ cfe-commits mailing list

[PATCH] D73780: [clangd] Separate protobuf-related functions to a dedicated file.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D73780 Files:

[PATCH] D73723: [clangd][Hover] Handle uninstantiated default args

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang-tools-extra/clangd/Hover.cpp:276 +// we only print the expression. +if (PVD->hasDefaultArg() && !PVD->hasUnparsedDefaultArg()) {

[PATCH] D72829: Implement -fsemantic-interposition

This revision was automatically updated to reflect the committed changes. Closed by commit rGfd09f12f32f5: Implement -fsemantic-interposition (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72829/new/

[clang] fd09f12 - Implement -fsemantic-interposition

Author: serge-sans-paille Date: 2020-01-31T14:02:33+01:00 New Revision: fd09f12f32f57564d619a28b8826d33ade47b12e URL: https://github.com/llvm/llvm-project/commit/fd09f12f32f57564d619a28b8826d33ade47b12e DIFF:

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. Also I am not sure why, but the ranges added to the diagnostic in lines 1222-1226 don't show up in the message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73775/new/ https://reviews.llvm.org/D73775 ___

  1   2   >