[PATCH] D74417: [clang][ARC] Remove invalid assertion that can crash clangd

2020-02-13 Thread Erik Pilkington via Phabricator via cfe-commits
erik.pilkington added a comment. In D74417#1874747 , @dgoldman wrote: > Added but it's still failing due to a different assertion failure, do you > think this could be because the abbreviation is different for the ParamVars? > I'm not sure how to handle

[PATCH] D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale

2020-02-13 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm, if the diff comes out wrong, that will not result in an incorrect pass/fail, but only less debugable output. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74498/new/ https://reviews.

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

2020-02-13 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel added a comment. I am unable to commit this myself, can someone commit for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74513/new/ https://reviews.llvm.org/D74513 ___ cfe-commits mailing

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

2020-02-13 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L updated this revision to Diff 244476. Xiangling_L marked 4 inline comments as done. Xiangling_L added a comment. Adjust ABI name to `XL`; Simplify the testcase; CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74015/new/ https://reviews.llvm.org/D74015 Files: clang/include/c

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 created this revision. kkwli0 added reviewers: jdoerfert, ABataev, JonChesterfield, tra. Herald added a subscriber: guansong. kkwli0 edited the summary of this revision. This patch is to add CUDA 10.2 support. It essentially removes the warning message regarding the CUDA 10.2 toolkit not

[PATCH] D74572: [WIP][BPF] implement intrinsic function __builtin__btf_type_id()

2020-02-13 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song created this revision. yonghong-song added reviewers: ast, anakryiko. Herald added subscribers: llvm-commits, cfe-commits, hiraditya, mgorny. Herald added projects: clang, LLVM. The builtin signature looks like: unsigned type_id = __builtin_btf_type_id(expression); The "expressio

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

2020-02-13 Thread Sean Fertile via Phabricator via cfe-commits
sfertile added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: Here would be a good place to add a comment to indicate that XL has several C++ ABIs, but this represents the one used i

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a reviewer: ye-luo. jdoerfert added a comment. > Do we also want to put this patch to 10.0.0 RC2 Yes, if there is nothing else needed to support 10.2 we should for sure do that. > in order to avoid bug 44587 which requires >9.0.1 to be the build compiler? Do we already require C

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Do the in tree tests all pass with the 10.2 toolchain? That's not exactly the same as whether it works but is the closest approximation we have available. Assuming yes, this patch seems uncontroversial. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7457

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

2020-02-13 Thread River Riddle via Phabricator via cfe-commits
rriddle accepted this revision. rriddle added a comment. This revision is now accepted and ready to land. (Appeasing herald for MLIR changes). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71775/new/ https://reviews.llvm.org/D71775 ___ cfe-

[PATCH] D73755: [objc_direct] Small updates to help with adoption.

2020-02-13 Thread Puyan Lotfi via Phabricator via cfe-commits
plotfi added a comment. @MadCoder Could there be a way to mark objc_direct methods as something like __attribute__((visibility("default"))) or __declspec(dllexport) to denote that a given method should be directly callable but still retain the metadata to be called through an objc_msgSend from

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Artem Belevich via Phabricator via cfe-commits
tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. It's a bit premature to call CUDA-10.2 supported. We can compile using it, but clang/llvm has no support for the new things introduced by CUDA-10.2. E.g. CUDA-10.2 introduces new PTX versi

[clang-tools-extra] 47abb43 - [clang-tidy] Fix performance-noexcept-move-constructor-fix test on non-English locale

2020-02-13 Thread Alexandre Ganea via cfe-commits
Author: Alexandre Ganea Date: 2020-02-13T14:46:44-05:00 New Revision: 47abb43fc36433154eb796bd1d098f100503473e URL: https://github.com/llvm/llvm-project/commit/47abb43fc36433154eb796bd1d098f100503473e DIFF: https://github.com/llvm/llvm-project/commit/47abb43fc36433154eb796bd1d098f100503473e.dif

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. In D74571#1874947 , @JonChesterfield wrote: > Do the in tree tests all pass with the 10.2 toolchain? That's not exactly the > same as whether it works but is the closest approximation we have available. > > Assuming yes, this patc

[PATCH] D74498: [clang-tidy] Fix performance-noexcept-move-constructor-fix.cpp on non-English locale

2020-02-13 Thread Alexandre Ganea via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG47abb43fc364: [clang-tidy] Fix performance-noexcept-move-constructor-fix test on non-English… (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

2020-02-13 Thread Alex Lorenz via Phabricator via cfe-commits
arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.llvm.org/D74569 ___ cfe-commits mailing list cfe-commi

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. In D74571#1874950 , @jdoerfert wrote: > > in order to avoid bug 44587 which requires >9.0.1 to be the build compiler? > > Do we already require CUDA 10 as part of the libomptarget cmake (with a nice > message) to avoid the errors y

[clang] 0b2eaa3 - Fix MSVC buildbots after ast_type_traits namespace removal

2020-02-13 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-02-13T11:57:00-08:00 New Revision: 0b2eaa373d12dacf58a72fd9e35ea6159a138647 URL: https://github.com/llvm/llvm-project/commit/0b2eaa373d12dacf58a72fd9e35ea6159a138647 DIFF: https://github.com/llvm/llvm-project/commit/0b2eaa373d12dacf58a72fd9e35ea6159a138647.diff

[clang] 3203e1b - [OPENMP50][DOCS]Update list of supported constructs, NFC.

2020-02-13 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-02-13T15:02:59-05:00 New Revision: 3203e1bc2e190aeee31a5b037f2535d03f2ca818 URL: https://github.com/llvm/llvm-project/commit/3203e1bc2e190aeee31a5b037f2535d03f2ca818 DIFF: https://github.com/llvm/llvm-project/commit/3203e1bc2e190aeee31a5b037f2535d03f2ca818.diff

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D74571#1875002 , @kkwli0 wrote: > In D74571#1874947 , @JonChesterfield > wrote: > > > Do the in tree tests all pass with the 10.2 toolchain? That's not exactly > > the same as whether it wo

[PATCH] D74569: [clang-scan-deps] Switch to using a ThreadPool

2020-02-13 Thread Alexandre Ganea via Phabricator via cfe-commits
aganea added a comment. Thanks for the quick response! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74569/new/ https://reviews.llvm.org/D74569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] 3eb1b59 - [OPENMP50][DOCS]Claim iterators and add reference to array shaping

2020-02-13 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-02-13T15:05:19-05:00 New Revision: 3eb1b59ec0347d60f9809f88cfe7e98c48492621 URL: https://github.com/llvm/llvm-project/commit/3eb1b59ec0347d60f9809f88cfe7e98c48492621 DIFF: https://github.com/llvm/llvm-project/commit/3eb1b59ec0347d60f9809f88cfe7e98c48492621.diff

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D74571#1875022 , @kkwli0 wrote: > In D74571#1874950 , @jdoerfert wrote: > > > > in order to avoid bug 44587 which requires >9.0.1 to be the build > > > compiler? > > > > Do we already

[clang-tools-extra] 8c4cf23 - Fix crash in InfinteLoopCheck

2020-02-13 Thread Nathan James via cfe-commits
Author: Nathan James Date: 2020-02-13T20:20:37Z New Revision: 8c4cf23dee1ac3f259c4795b275cc9bb1234aa29 URL: https://github.com/llvm/llvm-project/commit/8c4cf23dee1ac3f259c4795b275cc9bb1234aa29 DIFF: https://github.com/llvm/llvm-project/commit/8c4cf23dee1ac3f259c4795b275cc9bb1234aa29.diff LOG:

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

2020-02-13 Thread Gabor Marton via Phabricator via cfe-commits
martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2600 + EnumDecl *FoundDef = FoundEnum->getDefinition(); + if (D->isThisDeclarationADefinition() && FoundDef) +return Importer.MapImported(D, FoundDef); shafik w

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

2020-02-13 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. Ping @aaron.ballman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66919/new/ https://reviews.llvm.org/D66919 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

2020-02-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 244508. lebedev.ri added a comment. Herald added a subscriber: martong. Rebased, NFC. In D74081#1860932 , @NoQ wrote: > Looks great, thanks! Thank you for the review! Repository: rG LLVM Github Monorepo CHAN

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

2020-02-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri updated this revision to Diff 244509. lebedev.ri marked 8 inline comments as done. lebedev.ri added a comment. In D72362#1874690 , @aaron.ballman wrote: > LGTM aside from some nits. Thank you for the review! Nits addressed. Repository: rG

[clang-tools-extra] 49bffa5 - [clang-tidy] misc-no-recursion: a new check

2020-02-13 Thread Roman Lebedev via cfe-commits
Author: Roman Lebedev Date: 2020-02-13T23:37:53+03:00 New Revision: 49bffa5f8b790b6f180897b2a03840def645d8f0 URL: https://github.com/llvm/llvm-project/commit/49bffa5f8b790b6f180897b2a03840def645d8f0 DIFF: https://github.com/llvm/llvm-project/commit/49bffa5f8b790b6f180897b2a03840def645d8f0.diff

[clang] d68c7b8 - [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

2020-02-13 Thread Roman Lebedev via cfe-commits
Author: Roman Lebedev Date: 2020-02-13T23:37:53+03:00 New Revision: d68c7b8e3e4d605912ed36a843bbbcaa36234461 URL: https://github.com/llvm/llvm-project/commit/d68c7b8e3e4d605912ed36a843bbbcaa36234461 DIFF: https://github.com/llvm/llvm-project/commit/d68c7b8e3e4d605912ed36a843bbbcaa36234461.diff

[PATCH] D72362: [clang-tidy] misc-no-recursion: a new check

2020-02-13 Thread Roman Lebedev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG49bffa5f8b79: [clang-tidy] misc-no-recursion: a new check (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72362/new/ https://reviews

[PATCH] D74081: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode::CallRecord

2020-02-13 Thread Roman Lebedev via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGd68c7b8e3e4d: [clang][Analysis] CallGraph: store the actual call `Expr*` in the CallGraphNode… (authored by lebedev.ri). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[clang] 7ecf066 - [OPENMP][DOCS]Fix misprint, NFC.

2020-02-13 Thread Alexey Bataev via cfe-commits
Author: Alexey Bataev Date: 2020-02-13T15:43:05-05:00 New Revision: 7ecf066e65d8d5970b2254c2674ad12ce3a76e31 URL: https://github.com/llvm/llvm-project/commit/7ecf066e65d8d5970b2254c2674ad12ce3a76e31 DIFF: https://github.com/llvm/llvm-project/commit/7ecf066e65d8d5970b2254c2674ad12ce3a76e31.diff

[clang] e3548e2 - Remove unnecessary typedef that GCC doesn't like

2020-02-13 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-02-13T12:51:06-08:00 New Revision: e3548e23657d6c4988f815e9c87350f53e48e783 URL: https://github.com/llvm/llvm-project/commit/e3548e23657d6c4988f815e9c87350f53e48e783 DIFF: https://github.com/llvm/llvm-project/commit/e3548e23657d6c4988f815e9c87350f53e48e783.diff

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-02-13 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl added a comment. The upgrade test look good, I found a missing test in the unit tests though. Comment at: llvm/unittests/IR/MetadataTest.cpp:2089 + EXPECT_NE(N, DITemplateTypeParameter::get(Context, Name, +getBasicType("other

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

2020-02-13 Thread Xing Xue via Phabricator via cfe-commits
xingxue accepted this revision. xingxue added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72736/new/ https://reviews.llvm.org/D72736 ___ cfe-commits mailing list cfe-commit

[PATCH] D72239: [clang-tidy] new opencl recursion not supported check

2020-02-13 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. D72362 has landed. I'd advise to see if any of the testcases here aren't being reported by that check, and filing a bugs for them. Other than that, abandon? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://re

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

2020-02-13 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast requested changes to this revision. hubert.reinterpretcast added inline comments. This revision now requires changes to proceed. Comment at: llvm/lib/Support/Unix/Path.inc:243 +#elif defined(_AIX) + return getLoadModuleFilenameForFunction(MainAddr)->c_str(

[clang] fa0118e - [clang-format] Add new option BeforeLambdaBody in Allman style.

2020-02-13 Thread via cfe-commits
Author: Wawha Date: 2020-02-13T22:16:41+01:00 New Revision: fa0118e6e588fe303b08e7e06ba28ac1f8d50c68 URL: https://github.com/llvm/llvm-project/commit/fa0118e6e588fe303b08e7e06ba28ac1f8d50c68 DIFF: https://github.com/llvm/llvm-project/commit/fa0118e6e588fe303b08e7e06ba28ac1f8d50c68.diff LOG: [c

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

2020-02-13 Thread Francois JEAN via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGfa0118e6e588: [clang-format] Add new option BeforeLambdaBody in Allman style. (authored by Wawha). Herald added a reviewer: jdoerfert. Changed prior to commit: https://reviews.llvm.org/D44609?vs=241875&

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

2020-02-13 Thread Francois JEAN via Phabricator via cfe-commits
Wawha added a comment. In D44609#1871612 , @MyDeveloperDay wrote: > Correct follow that description on how to request commit access It's done. I have the commit right, and push that change on github : https://github.com/llvm/llvm-project/commit/fa0118e

[PATCH] D74513: [OpenMP][NFCI] Use the libFrontend DefaultKind in Clang

2020-02-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D74513#1874825 , @atmnpatel wrote: > I am unable to commit this myself, can someone commit for me? I'll do that later. Ping me if I forget please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D74572: [WIP][BPF] implement intrinsic function __builtin__btf_type_id()

2020-02-13 Thread Yonghong Song via Phabricator via cfe-commits
yonghong-song updated this revision to Diff 244529. yonghong-song edited the summary of this revision. yonghong-song added a comment. Herald added a subscriber: ormris. add the type_id assignment to FieldInfo relocation .btf.ext ELF section. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D74542: [ASTImporter] Prevent the ASTImporter from creating multiple main FileIDs.

2020-02-13 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin accepted this revision. a_sidorin added a comment. Nice solution! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74542/new/ https://reviews.llvm.org/D74542 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] f7e2227 - [clang] Fix bad line ending (DOS instead of Unix) inside the release notes.

2020-02-13 Thread via cfe-commits
Author: Wawha Date: 2020-02-13T22:52:28+01:00 New Revision: f7e2227832a6691bf2d07cebf4bd772d5eafbe1a URL: https://github.com/llvm/llvm-project/commit/f7e2227832a6691bf2d07cebf4bd772d5eafbe1a DIFF: https://github.com/llvm/llvm-project/commit/f7e2227832a6691bf2d07cebf4bd772d5eafbe1a.diff LOG: [c

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

2020-02-13 Thread Xiangling Liao via Phabricator via cfe-commits
Xiangling_L marked 3 inline comments as done. Xiangling_L added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: sfertile wrote: > Here would be a good place to add a comment to indicat

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2020-02-13 Thread Jinsong Ji via Phabricator via cfe-commits
jsji added a comment. This is also breaking test-suites in our internal buildbots .. This change is actually changing the default behavior: if user does NOT supply `-ffp-contract`, it becomes `-ffp-contract=on`. So this means any code without explicitly add `-ffp-contract=off` will have `-ffp-

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

2020-02-13 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74554/new/ https://reviews.llvm.org/D74554 ___

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. Interesting distinction. Should compiling without warning indicate comprehensive support, or merely that we ran the tests and they passed? I assumed the latter on the basis that we probably don't have comprehensive support for cuda 10.1 either. No preference ei

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2020-02-13 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. In D74436#1875273 , @jsji wrote: > This is also breaking test-suites in our internal buildbots .. > > This change is actually changing the default behavior: if user does NOT > supply `-ffp-contract`, it becomes `-ffp-contract=on`.

[clang] 88ec01c - Revert "Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on"""

2020-02-13 Thread Melanie Blower via cfe-commits
Author: Melanie Blower Date: 2020-02-13T15:06:12-08:00 New Revision: 88ec01ca1bfa4c3a29225db93d36e6d32278190d URL: https://github.com/llvm/llvm-project/commit/88ec01ca1bfa4c3a29225db93d36e6d32278190d DIFF: https://github.com/llvm/llvm-project/commit/88ec01ca1bfa4c3a29225db93d36e6d32278190d.diff

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2020-02-13 Thread Nemanja Ivanovic via Phabricator via cfe-commits
nemanjai added a comment. > You're right, -O0 shouldn't generate FMA. I'm preparing to revert this now -- > just verifying the build. Perhaps this should be `off` with no optimization `on` with `-O1/-O2/-O3/-Os/-Oz` `fast` with fast math Just a suggestion, I'm not sure whether that would be the

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2020-02-13 Thread Melanie Blower via Phabricator via cfe-commits
mibintc added a comment. @jsji Will your backend tolerate -ffp-contract=on if optimizations are not disabled, e.g. -O2? We are proposing that the default floating point model be -ffp-model=precise, and with precise model, the ffp-contract=on. However you are right we don't want the frontend to

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

2020-02-13 Thread Aleksei Sidorin via Phabricator via cfe-commits
a_sidorin accepted this revision. a_sidorin added inline comments. Comment at: clang/unittests/AST/ASTImporterTest.cpp:4870 + Decl *ToTU = getToTuDecl( + R"( + enum class E; Maybe it's better to use just non-raw string literals here? ``` Decl *ToTU = g

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D74571#1875296 , @JonChesterfield wrote: > Interesting distinction. > > Should compiling without warning indicate comprehensive support, or merely > that we ran the tests and they passed? The test in LLVM do have very limited te

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

2020-02-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1723 +llvm::APInt CondVal = +Selector.ScoreOrCondition->EvaluateKnownConstInt(ASTCtx); +if (CondVal.isNullValue()) aaron.ballman wrote: > jdoerfert wrote: > >

[PATCH] D71830: [OpenMP][Part 2] Use reusable OpenMP context/traits handling

2020-02-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert marked 11 inline comments as done. jdoerfert added inline comments. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:367 } else { -llvm_unreachable("Unknown SimpleArgument type!"); +OS << "if (SA->get" << getUpperName() << "())\n "; +

[PATCH] D74386: [SVE] Update API ConstantVector::getSplat() to use ElementCount.

2020-02-13 Thread Huihui Zhang via Phabricator via cfe-commits
huihuiz updated this revision to Diff 244546. huihuiz marked 2 inline comments as done. huihuiz added a comment. Thanks Eli for the review! Add test cases to check for size query changes in ConstantExpr::getGetElementPtr(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[clang] 0a1123e - Reland D74436 "Change clang option -ffp-model=precise to select ffp-contract=on"

2020-02-13 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-13T16:22:03-08:00 New Revision: 0a1123eb43f945593b26dd037490e0c909fa3c4f URL: https://github.com/llvm/llvm-project/commit/0a1123eb43f945593b26dd037490e0c909fa3c4f DIFF: https://github.com/llvm/llvm-project/commit/0a1123eb43f945593b26dd037490e0c909fa3c4f.diff

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2020-02-13 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. The revert of this breaks tests everywhere, as far as I can tell. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74436/new/ https://reviews.llvm.org/D74436 ___ cfe-commits mailin

[clang] 1d49eb0 - [AsmPrinter] De-capitalize all AsmPrinter::Emit* but EmitInstruction

2020-02-13 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2020-02-13T17:06:24-08:00 New Revision: 1d49eb00d97a8e920ae34ff433419d0cd61641fd URL: https://github.com/llvm/llvm-project/commit/1d49eb00d97a8e920ae34ff433419d0cd61641fd DIFF: https://github.com/llvm/llvm-project/commit/1d49eb00d97a8e920ae34ff433419d0cd61641fd.diff

[PATCH] D74571: [OpenMP][CUDA] Add CUDA 10.2 support

2020-02-13 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. @tra that's great context, thank you very much for writing it up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74571/new/ https://reviews.llvm.org/D74571 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

2020-02-13 Thread Sean Fertile via Phabricator via cfe-commits
sfertile added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLCXXABI final : public ItaniumCXXABI { +public: Xiangling_L wrote: > sfertile wrote: > > Here would be a good place to add a comment to indicate that XL has several > >

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

2020-02-13 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 244555. njames93 added a comment. - Added option to enable transforming template dependent types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-e

[PATCH] D72553: [clang-tidy] Add performance-prefer-preincrement check

2020-02-13 Thread Nathan James via Phabricator via cfe-commits
njames93 updated this revision to Diff 244557. njames93 added a comment. - Fix order in release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72553/new/ https://reviews.llvm.org/D72553 Files: clang-tools-extra/clang-tidy/llvm/LLVMTidyModul

[PATCH] D74436: Change clang option -ffp-model=precise to select ffp-contract=on

2020-02-13 Thread Andy Kaylor via Phabricator via cfe-commits
andrew.w.kaylor added a subscriber: MaskRay. andrew.w.kaylor added a comment. In D74436#1875386 , @thakis wrote: > The revert of this breaks tests everywhere, as far as I can tell. It looks like something strange happened with the revert: > clang-11: wa

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

2020-02-13 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 244566. modocache added a comment. Clean up coroutine intrinsics as part of the ThinLTO pre-link pipeline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: cl

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

2020-02-13 Thread Awanish Pandey via Phabricator via cfe-commits
awpandey updated this revision to Diff 244571. awpandey marked 2 inline comments as done. awpandey added a comment. Hi @aprantl, I have added a test that two DITemplateTypeParameter only differ in the isDefault parameter are not equal. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73462

[PATCH] D74591: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

2020-02-13 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: evgeny777, tejohnson. Herald added subscribers: cfe-commits, dexonsmith, inglorion, emaste. Herald added a project: clang. AddGoldPlugin does more than adding `-plugin path/to/LLVMgold.so`. It works with lld and GNU ld, and adds other LTO opt

<    1   2