[PATCH] D74591: [Driver] Rename AddGoldPlugin to addLTOOptions. NFC

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74591/new/ https://reviews.llvm.org/D74591 _

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rG1d40c4150630: [clang-tools-extra] fix the check for if '-latomic' is necessary (authored by gokturk, committed by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D66919: Warn about zero-parameter K&R definitions in -Wstrict-prototypes

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thanks for your patience while I thought about this more. I think the direction makes sense, so this LGTM with some extra test cases. Comment at: clang/test/Se

[clang-tools-extra] 1d40c41 - [clang-tools-extra] fix the check for if '-latomic' is necessary

Author: Gokturk Yuksek Date: 2020-02-14T14:16:10Z New Revision: 1d40c4150630729a9c1ce5119a8027dac93a5b2d URL: https://github.com/llvm/llvm-project/commit/1d40c4150630729a9c1ce5119a8027dac93a5b2d DIFF: https://github.com/llvm/llvm-project/commit/1d40c4150630729a9c1ce5119a8027dac93a5b2d.diff LOG

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. Whether or not GCC behaves the way it should behave regarding atomics, this seems like a sensible patch to make things work given the current situation. LGTM. Repository: rG LLVM

[PATCH] D74609: [clangd] Update the CompletionItemKind.

kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:106 + case SK::ConversionFunction: +return CompletionItemKind::Operator; case SK::Variable:

[PATCH] D74610: [clang][Index] Visit the default parameter arguements in libindex.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, ilya-biryukov, kristof.beyls. Herald added a project: clang. We are missing the default parmeter arguments when IndexFunctionLocals is true. Fixes https://github.com/clangd/cl

[PATCH] D74609: [clangd] Update the CompletionItemKind.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Fix some FIXMEs. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D74609 Files: clang-tools-extra/clan

[PATCH] D74399: [Driver][RISCV] Add RedHat Linux RISC-V triple

This revision was automatically updated to reflect the committed changes. Closed by commit rG9816e726e747: [Driver][RISCV] Add RedHat Linux RISC-V triple (authored by luismarques). Herald added a subscriber: jrtc27. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[clang] 9816e72 - [Driver][RISCV] Add RedHat Linux RISC-V triple

Author: Luís Marques Date: 2020-02-14T13:46:26Z New Revision: 9816e726e747d72e0c5ac92aa20e652031a10448 URL: https://github.com/llvm/llvm-project/commit/9816e726e747d72e0c5ac92aa20e652031a10448 DIFF: https://github.com/llvm/llvm-project/commit/9816e726e747d72e0c5ac92aa20e652031a10448.diff LOG:

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto updated this revision to Diff 244635. CarolineConcatto added a comment. - [Clang]Rename flag and update the tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951 Files: clang/include/clan

[PATCH] D74606: [clangd] Add add commit characters to the server capabilities

kbobyrev created this revision. kbobyrev added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Make it more convinient for the clients to select completion items by providing a set of defa

[PATCH] D74555: [clangd] Add a flag for setting isIncomplete flag true in all responses

kbobyrev updated this revision to Diff 244618. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Address the review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74555/new/ https://reviews.llvm.org/D74555 Files: clan

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet marked 3 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98 + case SK::TemplateTypeParm: + case SK::TemplateTemplateParm: return CompletionItemKind::Class; hokein wrote: > I think thes

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

This revision was automatically updated to reflect the committed changes. Closed by commit rG84240e0db8ab: [clang][Index] Introduce a TemplateParm SymbolKind (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://re

[clang-tools-extra] 84240e0 - [clang][Index] Introduce a TemplateParm SymbolKind

Author: Kadir Cetinkaya Date: 2020-02-14T13:20:34+01:00 New Revision: 84240e0db8ab85b56df11e6cee8fef5ac7ee8c33 URL: https://github.com/llvm/llvm-project/commit/84240e0db8ab85b56df11e6cee8fef5ac7ee8c33 DIFF: https://github.com/llvm/llvm-project/commit/84240e0db8ab85b56df11e6cee8fef5ac7ee8c33.dif

[PATCH] D73693: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

This revision was automatically updated to reflect the committed changes. Closed by commit rGc45fb35b5e0b: [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

kadircet updated this revision to Diff 244619. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73696/new/ https://reviews.llvm.org/D73696 Files: clang-tools-ex

[clang-tools-extra] c45fb35 - [clang][DeclPrinter] Implement visitors for {TemplateType,NonTypeTemplate}Parms

Author: Kadir Cetinkaya Date: 2020-02-14T13:20:34+01:00 New Revision: c45fb35b5e0b45357a9bfae500ec5403545dbc77 URL: https://github.com/llvm/llvm-project/commit/c45fb35b5e0b45357a9bfae500ec5403545dbc77 DIFF: https://github.com/llvm/llvm-project/commit/c45fb35b5e0b45357a9bfae500ec5403545dbc77.dif

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

kmclaughlin updated this revision to Diff 244610. kmclaughlin added a comment. - Changed 'dl' to 'DL' as suggested by @andwar - Updated tests to address @sdesmalen's comment (changed all tests to check min & max immediate values, plus added some tests where the immediate is out of range) CHANG

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

rogfer01 updated this revision to Diff 244611. rogfer01 added a comment. ChangeLog: - Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://reviews.llvm.org/D70799 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/test/OpenMP/taskyield_codegen.cpp llvm/include

[PATCH] D70799: [OpenMP] Lower taskyield using OpenMP IR Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rG2bef1c0e5645: [OpenMP] Lower taskyield using OpenMP IR Builder (authored by rogfer01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70799/new/ https://revi

[clang] 2bef1c0 - [OpenMP] Lower taskyield using OpenMP IR Builder

Author: Roger Ferrer Ibanez Date: 2020-02-14T11:35:17Z New Revision: 2bef1c0e5645639bda1807f7df970da97792b0c8 URL: https://github.com/llvm/llvm-project/commit/2bef1c0e5645639bda1807f7df970da97792b0c8 DIFF: https://github.com/llvm/llvm-project/commit/2bef1c0e5645639bda1807f7df970da97792b0c8.diff

[PATCH] D74602: Fix standalone build interaction with compiler extension

serge-sans-paille created this revision. serge-sans-paille added reviewers: Keruspe, hans, Meinersbur. Herald added subscribers: llvm-commits, cfe-commits, mgorny. Herald added projects: clang, LLVM. As suggested in https://github.com/llvm/llvm-project/issues/120, don't try to generate the extens

[PATCH] D74298: Honor -finline-functions and -finline-hint-functions at -O0

davezarzycki abandoned this revision. davezarzycki added a comment. I'm abandoning this due to lack of time and the problem being more involved than I thought. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74298/new/ https://reviews.llvm.org/D7429

[PATCH] D74550: [AArch64][SVE] Add SVE index intrinsic

sdesmalen added inline comments. Comment at: llvm/test/CodeGen/AArch64/sve-intrinsics-index.ll:35 +; CHECK-NEXT: ret + %out = call @llvm.aarch64.sve.index.nxv2i64(i64 -14, i64 15) + ret %out Is there a reason you're not testing for -16, 15 for all of these i

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 244601. njames93 added a comment. - Small refactor of code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files: clang-tools-extra/clang-tidy/bugprone/ReservedIdent

[PATCH] D74395: [clangd] Add tracer to the rename workflow, NFC

kbobyrev accepted this revision. kbobyrev added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:345 + +SPAN_ATTACH(Tracer, FileAndOccurrences.first(), +static_cast(Ranges.size()));

[PATCH] D73775: [clang-tidy] Cover cases like (b && c && b) in the redundant expression check

alexeyr added a comment. @aaron.ballman I just noticed this in https://mlir.llvm.org/getting_started/Contributing/ > Note: if you haven’t used Arcanist to send your patch for review, committers > don’t have access to your preferred identity for commit messages. Make sure > to communicate it to

[PATCH] D73904: [clang] stop baremetal driver to append .a to lib

christof added a comment. In D73904#1874303 , @thakis wrote: > I fixed windows tests in a41550cff91b7fb2b56bf0e19ccb341bfd3e37b4 > . > Please watch bots after landing patches next time

[PATCH] D74051: Move update_cc_test_checks.py tests to clang

rsmith added a comment. In D74051#1872856 , @MaskRay wrote: > @rsmith Does `clang/test/utils/` (a new directory) look appropriate to you? That seems fine to me. Following that pattern, I think we should also move: - `test/clang-rename` -> `test/tools/cl

[PATCH] D69828: [OpenMP] Lower taskwait using OpenMP IR Builder

This revision was automatically updated to reflect the committed changes. Closed by commit rGa82f35e17621: [OpenMP] Lower taskwait using OpenMP IR Builder (authored by rogfer01). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES

[clang] a82f35e - [OpenMP] Lower taskwait using OpenMP IR Builder

Author: Roger Ferrer Ibanez Date: 2020-02-14T09:53:02Z New Revision: a82f35e17621a036cb726244ee5cb9708545fb93 URL: https://github.com/llvm/llvm-project/commit/a82f35e17621a036cb726244ee5cb9708545fb93 DIFF: https://github.com/llvm/llvm-project/commit/a82f35e17621a036cb726244ee5cb9708545fb93.diff

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

CarolineConcatto added a comment. @richard.barton.arm A new patch will land today with the changes asked by you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951 __

[PATCH] D73951: [Clang] [Driver]Add logic to search for flang frontend

richard.barton.arm added a comment. I'd still like to see the nits addressed and comments on the tests addressed before approving. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73951/new/ https://reviews.llvm.org/D73951

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2600 + EnumDecl *FoundDef = FoundEnum->getDefinition(); + if (D->isThisDeclarationADefinition() && FoundDef) +return Importer.MapImpo

[PATCH] D74554: [ASTImporter] Added visibility check for scoped enums.

balazske updated this revision to Diff 244582. balazske added a comment. Added to the generic tests (and removed one redundant test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74554/new/ https://reviews.llvm.org/D74554 Files: clang/lib/AST/A

[PATCH] D73696: [clang][Index] Introduce a TemplateParm SymbolKind

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:98 + case SK::TemplateTypeParm: + case SK::TemplateTemplateParm: return CompletionItemKind::Class; --

[clang-tools-extra] b7d6640 - [NFC][clang-tidy] Move recently newly-added tests into checkers/ subdir

Author: Roman Lebedev Date: 2020-02-14T11:25:05+03:00 New Revision: b7d6640ba9812ec74a0f86ae7bc9850332f5fd2b URL: https://github.com/llvm/llvm-project/commit/b7d6640ba9812ec74a0f86ae7bc9850332f5fd2b DIFF: https://github.com/llvm/llvm-project/commit/b7d6640ba9812ec74a0f86ae7bc9850332f5fd2b.diff

<    1   2