[clang] da236f2 - Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color

Author: Kadir Cetinkaya Date: 2020-02-26T09:05:05+01:00 New Revision: da236f235028c82c2f0e00eea1f6f9c689bcae4a URL: https://github.com/llvm/llvm-project/commit/da236f235028c82c2f0e00eea1f6f9c689bcae4a DIFF: https://github.com/llvm/llvm-project/commit/da236f235028c82c2f0e00eea1f6f9c689bcae4a.dif

[PATCH] D75019: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics-color

This revision was automatically updated to reflect the committed changes. Closed by commit rGda236f235028: Strip preceeding -Xclang when stripping -fcolor-diagnostics or -fdiagnostics… (authored by kadircet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to

[PATCH] D75048: [ASTImporter] Improved import of AlignedAttr.

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7944 + if (auto ToEOrErr = Import(From->getAlignmentExpr())) +To = AlignedAttr::Create(ToContext, true, *ToEOrErr, ToRange, +

[PATCH] D74834: [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

hokein updated this revision to Diff 246640. hokein added a comment. keep the old clangdServer::rename around temporarily to make internal integration life easier. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74834/new/ https://reviews.llvm.org/D

[clang-tools-extra] 34d0e1b - [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

Author: Haojian Wu Date: 2020-02-26T09:33:58+01:00 New Revision: 34d0e1bd6d05ee11f638ca085f4755e75e18adfc URL: https://github.com/llvm/llvm-project/commit/34d0e1bd6d05ee11f638ca085f4755e75e18adfc DIFF: https://github.com/llvm/llvm-project/commit/34d0e1bd6d05ee11f638ca085f4755e75e18adfc.diff LO

[PATCH] D74834: [clangd] Expose the rename LimitFiles option to the C++ API, NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG34d0e1bd6d05: [clangd] Expose the rename LimitFiles option to the C++ API, NFC. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D74834?vs=246640&id=246641#toc Repository: rG L

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

hans added a comment. Thanks for writing notes! Go ahead and push directly to the branch when you're ready. Comment at: clang/docs/ReleaseNotes.rst:288 +OpenCL Kernel Language Changes in Clang -- For the formatting to work, I

[PATCH] D75158: [analyzer][StreamChecker] Using function description objects - NFC.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. Have a description object for

[clang-tools-extra] 4feca71 - Fix the clangd-fuzzer build error.

Author: Haojian Wu Date: 2020-02-26T10:13:13+01:00 New Revision: 4feca71df0ca96237342d0e3ef41e3cdbfa0e27c URL: https://github.com/llvm/llvm-project/commit/4feca71df0ca96237342d0e3ef41e3cdbfa0e27c DIFF: https://github.com/llvm/llvm-project/commit/4feca71df0ca96237342d0e3ef41e3cdbfa0e27c.diff LO

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang/lib/Tooling/Syntax/Tokens.cpp:335 clang::Token T; - while (!L.LexFromRawLexer(T)) + while (!L.LexFromRawLexer(T) && L.getCurrentBufferOffset() < FR.endOffset()) AddToken(T); ---

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

kadircet updated this revision to Diff 246646. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74962/new/ https://reviews.llvm.org/D74962 Files: clang/include/clang/Tooling/Syntax/Tokens.h clang/lib/T

[clang] e058667 - Support -fuse-ld=lld for riscv

Author: serge-sans-paille Date: 2020-02-26T10:20:20+01:00 New Revision: e058667a2e017d3225a9bb067dbac7f2159576f7 URL: https://github.com/llvm/llvm-project/commit/e058667a2e017d3225a9bb067dbac7f2159576f7 DIFF: https://github.com/llvm/llvm-project/commit/e058667a2e017d3225a9bb067dbac7f2159576f7.d

[PATCH] D74704: Support -fuse-ld=lld for riscv

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGe058667a2e01: Support -fuse-ld=lld for riscv (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D74871: Fix interaction between -fdiscard-value-names and LLVM Bitcode

serge-sans-paille abandoned this revision. serge-sans-paille added a comment. Obsoleted by https://reviews.llvm.org/D74878 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74871/new/ https://reviews.llvm.org/D74871 _

[clang] 19c664f - Fix typo in clang lit config

Author: serge-sans-paille Date: 2020-02-26T10:37:04+01:00 New Revision: 19c664f71e887111298e49e416511f8be7b2b15f URL: https://github.com/llvm/llvm-project/commit/19c664f71e887111298e49e416511f8be7b2b15f DIFF: https://github.com/llvm/llvm-project/commit/19c664f71e887111298e49e416511f8be7b2b15f.d

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

hokein added inline comments. Comment at: clang/include/clang/AST/DependencyFlags.h:57 + struct NAME##Scope { \ +enum NAME { \ + UnexpandedPack = 1,

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 updated this revision to Diff 246650. njames93 added a comment. - Changed naming to what appears to be llvm python style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files: clang-tools-extra/c

[PATCH] D75158: [analyzer][StreamChecker] Using function description objects - NFC.

Szelethus accepted this revision. Szelethus added reviewers: baloghadamsoftware, NoQ, martong, Charusso, xazax.hun. Szelethus added a comment. This revision is now accepted and ready to land. Herald added a subscriber: rnkovacs. Cool! Though this patch says little without followups, so maybe we s

[PATCH] D75134: [clang-tidy] Improved renamer check logic

njames93 updated this revision to Diff 246653. njames93 added a comment. - Moved shared code into __init__ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75134/new/ https://reviews.llvm.org/D75134 Files: clang-tools-extra/clang-tidy/add_new_check

[PATCH] D75159: [clang-tidy] Fix PR#37210 'Out-of-class template constructor only half-fixed with modernize-pass-by-value'

f00kat created this revision. f00kat added reviewers: aaron.ballman, alexfh. f00kat added projects: clang, clang-tools-extra. Herald added subscribers: cfe-commits, xazax.hun. Existing 'modernize-pass-by-value' check works only with non template values in initializers. Now we also skip cases when

[PATCH] D75160: [AArch64][SVE] Add SVE2 intrinsic for xar

kmclaughlin created this revision. kmclaughlin added reviewers: andwar, c-rhodes, dancgr, efriedma. Herald added subscribers: psnobl, rkruppe, hiraditya, kristof.beyls, tschuett. Herald added a reviewer: rengolin. Herald added a project: LLVM. Implements the @llvm.aarch64.sve.xar intrinsic Repos

[PATCH] D74878: [remark][diagnostics] [codegen] Fix PR44896

hans added a comment. Thanks! Cherry-picked to 10.x as 6f4f4f2c8ce1ad17bdec9fe2071d3fe439eca9eb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74878/new/ https://reviews.llvm.org

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c859fc54d92: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup (authored by kmclaughlin). Changed prior to commit: https://reviews.llvm.org/D74912?vs=246487&id=246661#toc Repositor

[PATCH] D75125: [Docs][OpenCL] Release 10.0 notes for OpenCL

svenvh added inline comments. Comment at: clang/docs/ReleaseNotes.rst:293 +- Allowed ``__private`` to be printed explicitly in diagnostics, AST, etc +- Fixed declaration of ``enqueue_marker``, c11 atomic fetch max/min in the + standard header. Suggesting to mov

[PATCH] D74912: [AArch64][SVE] Add SVE2 intrinsics for bit permutation & table lookup

kmclaughlin added a comment. Thanks for reviewing this, @sdesmalen & @efriedma! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74912/new/ https://reviews.llvm.org/D74912 ___ cfe-commits mailing list cfe

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This removes everything but int_x86_avx512_mask_vcvtph2ps_512 which provides the SAE variant, but even this can use the fpext generic

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske created this revision. Herald added subscribers: cfe-commits, martong, Charusso, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a project: clang. The validity checks are perfor

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske added a comment. Code is not reformatted and tests are to be added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 ___ cfe-commits mailing list cfe-co

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

Szelethus added a comment. Aha, so we're moving every check as to whether the stream is closed to `preCall`? Makes sense, if not much else changed. Could you please run `clang-format-diff.py` after adding the tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[clang] 546918c - Revert "[compiler-rt] Add a critical section when flushing gcov counters"

Author: Hans Wennborg Date: 2020-02-26T13:27:44+01:00 New Revision: 546918cbb4b2231c65cf91fceb738a59d03af7bf URL: https://github.com/llvm/llvm-project/commit/546918cbb4b2231c65cf91fceb738a59d03af7bf DIFF: https://github.com/llvm/llvm-project/commit/546918cbb4b2231c65cf91fceb738a59d03af7bf.diff

[clang-tools-extra] 5560a78 - [clangd] Bump index version number.

Author: Haojian Wu Date: 2020-02-26T13:43:16+01:00 New Revision: 5560a78820ee7cecd1ad14f5a96889459dd36766 URL: https://github.com/llvm/llvm-project/commit/5560a78820ee7cecd1ad14f5a96889459dd36766 DIFF: https://github.com/llvm/llvm-project/commit/5560a78820ee7cecd1ad14f5a96889459dd36766.diff LO

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Get rid of calls to lexer and unnecessary source location transformations. Repository: rG LLVM Gith

[PATCH] D74127: [clangd] Bump index version number.

This revision was automatically updated to reflect the committed changes. Closed by commit rG5560a78820ee: [clangd] Bump index version number. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74127/new/ https://reviews.llvm.org/D7

[clang] 8c2cf49 - [clang][Tooling] Add a way to tokenize a FileRange

Author: Kadir Cetinkaya Date: 2020-02-26T13:50:41+01:00 New Revision: 8c2cf499e6119be8f3f1a0d42c4bb7e45b0d615d URL: https://github.com/llvm/llvm-project/commit/8c2cf499e6119be8f3f1a0d42c4bb7e45b0d615d DIFF: https://github.com/llvm/llvm-project/commit/8c2cf499e6119be8f3f1a0d42c4bb7e45b0d615d.dif

[PATCH] D74962: [clang][Tooling] Add a way to tokenize a FileRange

This revision was automatically updated to reflect the committed changes. Closed by commit rG8c2cf499e611: [clang][Tooling] Add a way to tokenize a FileRange (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74962/new/ https://re

[clang] 6e34a9a - [OpenMP] Fix the test by generating output file in temporary directory

Author: Kirill Bobyrev Date: 2020-02-26T14:07:13+01:00 New Revision: 6e34a9a838c150b968b05b76d545969d1ddeee90 URL: https://github.com/llvm/llvm-project/commit/6e34a9a838c150b968b05b76d545969d1ddeee90 DIFF: https://github.com/llvm/llvm-project/commit/6e34a9a838c150b968b05b76d545969d1ddeee90.diff

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

aganea added a comment. @thakis I think this is a side-effect of implementing `computeHostNumPhysicalCores()` for Windows, which previously returned -1, which in turn made `llvm::heavyweight_hardware_concurrency()` previously behave like `llvm::hardware_concurrency()` (on Windows only). At firs

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

RobRich999 added a comment. I too can see how SMT might not afford much performance difference for LTO codegen. CMT appears to be more significant. I do not have exact numbers right now as my build box is busy, but the change added like an hour to locally building the Chromium browser with Thi

[PATCH] D71775: [ThreadPool] On Windows, extend usage to all CPU sockets and all NUMA groups

mehdi_amini added a comment. There is something puzzling to me in this patch in the way the ThreadPool was modified: the client of the thread pool cannot request a number of threads anymore, but only a *maximum* number of threads. I don't really understand why? Using the OS reported concurrency

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas created this revision. Herald added subscribers: cfe-commits, kristof.beyls. Herald added a project: clang. Half-precision floating point arguments and returns are currently promoted to either float or int32 in clang's CodeGen. As such promotions are implemented as coercion through memor

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet updated this revision to Diff 246682. kadircet added a comment. Add more cleaning. getDeclAtPosition builds a SelectionTree underneath and it only operates on spelling locations inside main file. So it is invalid to pass any expansion locations to it. There is no need to call getBeginni

[PATCH] D75044: [AArch64] __builtin_extract_return_addr for PAuth.

danielkiss updated this revision to Diff 246685. danielkiss added a reviewer: olista01. danielkiss added a comment. rebased and test is updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75044/new/ https://reviews.llvm.org/D75044 Files: clang/lib/CodeGen/TargetInfo.cpp clang/te

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske updated this revision to Diff 246687. balazske added a comment. Reformat code and fixed errors. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 Files: clang/lib/StaticAnalyzer/Checkers/StreamChec

[PATCH] D75165: [ARM,MVE] Add predicated intrinsics for many unary functions.

MarkMurrayARM accepted this revision. MarkMurrayARM added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75165/new/ https://reviews.llvm.org/D75165 _

[PATCH] D75166: [clangd] Clean-up locateSymbolAt

kadircet updated this revision to Diff 246690. kadircet added a comment. - Also clean usage in getSymbolInfo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-extra/clangd/XRefs.cpp Inde

[clang] 319ea2d - [OpenCL] Add atomic type builtins

Author: Sven van Haastregt Date: 2020-02-26T14:08:23Z New Revision: 319ea2dd9e32cd10415e1f5060e84febf7c606c6 URL: https://github.com/llvm/llvm-project/commit/319ea2dd9e32cd10415e1f5060e84febf7c606c6 DIFF: https://github.com/llvm/llvm-project/commit/319ea2dd9e32cd10415e1f5060e84febf7c606c6.diff

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: martong, steakhal, Charusso, gamesh411, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun. Iterator checkers (and pl

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

mitchell-stellar accepted this revision. mitchell-stellar added a comment. Assuming this passes all existing tests, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 ___ cfe-commits mailing list

[PATCH] D75174: [clangd] use printQualifiedName to skip the inlinenamespace qualifiers.

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. symbols in libcpp are inside the inline namespace, printQualifierAsString will print the inline namespace, which is unexpe

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet updated this revision to Diff 246701. kadircet added a comment. - Handle llvm::Expected failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-extra/clangd/XRefs.cpp Index:

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

john.brawn marked 2 inline comments as done. john.brawn added inline comments. Comment at: clang/lib/Sema/ParsedAttr.cpp:144 + // otherwise return a default ParsedAttrInfo. + if (A.getKind() < sizeof(AttrInfoMap)/sizeof(AttrInfoMap[0])) +return *AttrInfoMap[A.getKind()]; --

[PATCH] D75034: [clang-format] use spaces for alignment with UT_ForContinuationAndIndentation

mitchell-stellar added a subscriber: mxbOctasic. mitchell-stellar added a comment. Digging through the history, it seems this behavior was explicitly desired: https://reviews.llvm.org/D19028. @mxbOctasic was the original author and perhaps could comment. Regardless, I think there should be a new

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

Quuxplusone added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:329 // CHECK-NOTES: [[@LINE-3]]:7: note: move occurred here + // CHECK-NOTES: [[@LINE-6]]:7: note: std::move of the const expression {{.*}} };

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel reopened this revision. ymandel added a comment. This revision is now accepted and ready to land. Reopening for fix to failing tests that resulted in revert. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https://reviews.llvm.org/

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

ymandel updated this revision to Diff 246706. ymandel added a comment. Fix failing test under msvc compatibility. Adds -fno-delayed-template-parsing to compilation arguments in tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72153/new/ https:

[clang] 38b4516 - [libTooling] Add function to determine associated text of a declaration.

Author: Yitzhak Mandelbaum Date: 2020-02-26T09:56:48-05:00 New Revision: 38b4516de8a4a791d17085d37f95e3cc15c359f9 URL: https://github.com/llvm/llvm-project/commit/38b4516de8a4a791d17085d37f95e3cc15c359f9 DIFF: https://github.com/llvm/llvm-project/commit/38b4516de8a4a791d17085d37f95e3cc15c359f9.

[PATCH] D44609: [clang-format] New option BeforeLambdaBody to manage lambda line break inside function parameter call (in Allman style)

christophe-calmejane added a comment. In D44609#1875172 , @Wawha wrote: > In D44609#1871612 , @MyDeveloperDay > wrote: > > > Correct follow that description on how to request commit access > > > It's done. I have t

[PATCH] D72153: [libTooling] Add function to determine associated text of a declaration.

This revision was automatically updated to reflect the committed changes. Closed by commit rG38b4516de8a4: [libTooling] Add function to determine associated text of a declaration. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[clang] 41a6612 - Put microsoft template parameter shadow warning behind separate flag (PR44794)

Author: Hans Wennborg Date: 2020-02-26T16:04:40+01:00 New Revision: 41a6612ea8afc5254e4de3aca55628d37f0be433 URL: https://github.com/llvm/llvm-project/commit/41a6612ea8afc5254e4de3aca55628d37f0be433 DIFF: https://github.com/llvm/llvm-project/commit/41a6612ea8afc5254e4de3aca55628d37f0be433.diff

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

hans added a comment. In D75121#1891879 , @rnk wrote: > code lgtm > > Should we have a standalone test for this? Something that compiles with > `clang -cc1 -Wno-microsoft -Wmicrosoft-template-shadow` and looks for the > shadowing warnings? Adding one b

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske updated this revision to Diff 246711. balazske added a comment. Really reformat, bugfixes, and updated tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75163/new/ https://reviews.llvm.org/D75163 Files: clang/lib/StaticAnalyzer/Check

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

sammccall added a comment. Hooray! Comment at: clang-tools-extra/clangd/Hover.cpp:537 + // We prefer the identifiers if any, otherwise make use of the first token. + SourceLocation SourceLocationBeg = TokensAroundCursor.front().location(); first -> last I t

[PATCH] D75121: Put microsoft template parameter shadow warning behind separate flag (PR44794)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41a6612ea8af: Put microsoft template parameter shadow warning behind separate flag (PR44794) (authored by hans). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.org/D75121?v

[clang-tools-extra] 02323a3 - [clangd] use printQualifiedName to skip the inlinenamespace qualifiers.

Author: Haojian Wu Date: 2020-02-26T16:22:45+01:00 New Revision: 02323a3d5f9ea676865f78d603e68fa4b4b62608 URL: https://github.com/llvm/llvm-project/commit/02323a3d5f9ea676865f78d603e68fa4b4b62608 DIFF: https://github.com/llvm/llvm-project/commit/02323a3d5f9ea676865f78d603e68fa4b4b62608.diff LO

[PATCH] D75174: [clangd] use printQualifiedName to skip the inlinenamespace qualifiers.

This revision was automatically updated to reflect the committed changes. Closed by commit rG02323a3d5f9e: [clangd] use printQualifiedName to skip the inlinenamespace qualifiers. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D75174?vs=246699&id=246720#toc Repository:

[clang] e8c5fea - [clang-format] Special handling of spaces for C# code

Author: Jonathan Coe Date: 2020-02-26T15:27:03Z New Revision: e8c5fea243ce30640ec9707fabdb635a49b3153c URL: https://github.com/llvm/llvm-project/commit/e8c5fea243ce30640ec9707fabdb635a49b3153c DIFF: https://github.com/llvm/llvm-project/commit/e8c5fea243ce30640ec9707fabdb635a49b3153c.diff LOG:

[PATCH] D75129: [clang-format] Special handling of spaces for C# code

This revision was automatically updated to reflect the committed changes. Closed by commit rGe8c5fea243ce: [clang-format] Special handling of spaces for C# code (authored by Jonathan Coe ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG L

[PATCH] D75163: [analyzer][StreamChecker] Adding precall and refactoring.

balazske added a comment. Plan: - Add an error state to `StreamState`. - Model every stream function that can fail. Split the state into failed and non-failed and set the return value accordingly (as done at //fopen// now, but not only for stream return values). This is needed here to have a co

[PATCH] D75130: Remove BinaryOperator::CreateFNeg

cameron.mcinally accepted this revision. cameron.mcinally added a comment. This revision is now accepted and ready to land. LGTM, with the TODO to be handled under a separate patch. Thank you for taking care of this, Simon. Comment at: llvm/lib/Transforms/InstCombine/InstCombi

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

tejohnson added a comment. In D73242#1888295 , @tejohnson wrote: > FYI I have reproduced the failure, and am starting to debug. I see what is going on and have a simple fix, just need to create a test case. Expect to send a patch to fix this today, hope

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

sammccall added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:225 + + const auto &TB = AST.getTokens(); // Macros are simple: there's no declaration/definition distinction. used only once - inline? Comment at: clang-tools-

[PATCH] D75181: [Clang][AArch64] Add default arguments to runtime functions.

danielkiss created this revision. danielkiss added reviewers: chill, pcc, olista01, asl. Herald added subscribers: cfe-commits, aheejin, kristof.beyls, sbc100. Herald added a reviewer: jdoerfert. Herald added a project: clang. A runtime function needs the same arguments as normal function. Attrib

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

Rumeet, Thanks for the additional info. At some point we'd like to re-commit this patch. LNT testing showed execution time regressions on arch including x86 and aarch. I didn't capture the test names each time but it appeared to be approximately the same tests regressing everywhere. Andy Kay

[PATCH] D69662: [Checkers] Avoid using evalCall in StreamChecker.

balazske abandoned this revision. balazske added a comment. StreamChecker will be updated in other changes, see: https://reviews.llvm.org/D75158 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69662/new/ https://reviews.llvm.org/D69662 ___

[PATCH] D75176: [clangd] Get rid of getBeginningOfIdentifier helper

kadircet updated this revision to Diff 246729. kadircet marked 4 inline comments as done. kadircet added a comment. - Only use special locations for deducedtype and macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75176/new/ https://reviews.ll

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

whisperity added a comment. Do you have access to the `Driver` somehow? Instead of a `cerr` (-ish) output, something that is formatted like a "true" error diagnostic (or warning), such as `"no such file or directory"` would be much better, I fear this `[ERROR]` will simply be flooded away with

[PATCH] D74692: [clang-tidy][bugprone-use-after-move] Warn on std::move for consts

zinovy.nis marked an inline comment as done. zinovy.nis added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-use-after-move.cpp:329 // CHECK-NOTES: [[@LINE-3]]:7: note: move occurred here + // CHECK-NOTES: [[@LINE-6]]:7: note: std::m

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

whisperity added a comment. Also, //errors// should conceptually break the operation at hand, so this thing should be a warning instead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75171/new/ https://reviews.llvm.org/D75171 __

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet added inline comments. Comment at: clang-tools-extra/clangd/XRefs.cpp:432 auto References = findRefs( - getDeclAtPosition(AST, - SM.getMacroArgExpandedLocation(getBeginningOfIdentifier( -Pos, SM, AST.getLangOpts

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet updated this revision to Diff 246734. kadircet marked 4 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 Files: clang-tools-ex

[PATCH] D75022: clang-format: Extend AllowShortLoopsOnASingleLine to do ... while loops.

DaanDeMeyer added a comment. Is there CI infra that runs for each revision? I verified all the format unit tests still pass but I haven't run the entire test suite on my machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75022/new/ https://reviews.llvm.org/D75022 ___

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:432 auto References = findRefs( - getDeclAtPosition(AST, - SM.getMacroArgExpandedLoca

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

Xiangling_L added a comment. ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74166/new/ https://reviews.llvm.org/D74166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D72705: [analyzer] Added new checker 'alpha.unix.ErrorReturn'.

balazske added a comment. Ping ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72705/new/ https://reviews.llvm.org/D72705 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, gribozavr2. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: aheejin, xazax.hun. Without this patch clang-tidy stops finding file configs on the nearest .clang-tidy file. In some cases i

[PATCH] D75077: [OpenMP5.0] Allow pointer arithmetic in motion/map clause

cchen marked an inline comment as done. cchen added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:15683 } + bool VisitUnaryOperator(UnaryOperator *UO) { +if (SemaRef.getLangOpts().OpenMP < 50) { ABataev wrote: > cchen wrote: > > ABataev wrote

[PATCH] D73242: [WPD/LowerTypeTests] Delay lowering/removal of type tests until after ICP

aganea added a comment. In D73242#1893506 , @tejohnson wrote: > In D73242#1888295 , @tejohnson wrote: > > > FYI I have reproduced the failure, and am starting to debug. > > > I see what is going on and have a simple

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

kadircet updated this revision to Diff 246750. kadircet marked 3 inline comments as done. kadircet added a comment. - Add tests for non-identifier cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75166/new/ https://reviews.llvm.org/D75166 File

[clang-tools-extra] 2011d14 - [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

Author: Kadir Cetinkaya Date: 2020-02-26T17:51:27+01:00 New Revision: 2011d14296eeaae911e898d11154ee5d1a5db1d6 URL: https://github.com/llvm/llvm-project/commit/2011d14296eeaae911e898d11154ee5d1a5db1d6 DIFF: https://github.com/llvm/llvm-project/commit/2011d14296eeaae911e898d11154ee5d1a5db1d6.dif

[PATCH] D75166: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc transformations

This revision was automatically updated to reflect the committed changes. Closed by commit rG2011d14296ee: [clangd] Clean-up XRefs.cpp from Lexer usages and unnecessary SourceLoc… (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

Re: [clang] 83f4372 - [CodeGen] fix clang test that runs the optimizer pipeline; NFC

The test file dates back to: https://reviews.llvm.org/D5698 ...and I'm not familiar with _Complex enough to say how to fix this properly (seems like the check lines are already limited such that -O0 rather than -O1 would work?). But this file keeps wiggling unexpectedly, it's going to move again w

[PATCH] D75171: [Analyzer] Fix for incorrect use of container and iterator checkers

Szelethus requested changes to this revision. Szelethus added a comment. This revision now requires changes to proceed. Im sorry, i though we talked about internal code and we're stuck with the checker interface -- this should definitely be solved by changing the parameter of the `shouldRegister

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 246758. DmitryPolukhin added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/clang-tidy/ClangTidyOp

[clang] 590dc8d - Use virtual functions in ParsedAttrInfo instead of function pointers

Author: John Brawn Date: 2020-02-26T17:24:30Z New Revision: 590dc8d02cd781b110a87b82476c3557cb5957c3 URL: https://github.com/llvm/llvm-project/commit/590dc8d02cd781b110a87b82476c3557cb5957c3 DIFF: https://github.com/llvm/llvm-project/commit/590dc8d02cd781b110a87b82476c3557cb5957c3.diff LOG: Us

[PATCH] D75193: [clangd] Get rid of lexer usage in AST.cpp

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. kadircet added a parent revision: D75176: [clangd] Get rid of getBeginningOfIdentifier helper. Reposit

[PATCH] D31337: Use virtual functions in ParsedAttrInfo instead of function pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG590dc8d02cd7: Use virtual functions in ParsedAttrInfo instead of function pointers (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org/D31337?vs=242363&id=246765#toc Repository:

[PATCH] D31338: Move ParsedAttrInfos into a registry and point to one in ParsedAttr

john.brawn updated this revision to Diff 246763. john.brawn added a comment. Herald added a subscriber: krytarowski. This has been rewritten so that the registry is only used for attributes added by plugins, and everything else continues as before. This also removes the strange dependency I'd pr

[PATCH] D75056: [Driver] Default to -fno-common

SjoerdMeijer updated this revision to Diff 246770. SjoerdMeijer added a comment. minor test update CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ https://reviews.llvm.org/D75056 Files: clang/docs/ClangCommandLineReference.rst clang/docs/ReleaseNotes.rst clang/include/cl

[PATCH] D75056: [Driver] Default to -fno-common

SjoerdMeijer updated this revision to Diff 246768. SjoerdMeijer added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. Thanks for catching that. Now it shows more changes in tests, so updated a bunch of tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75056/new/ htt

  1   2   >