[PATCH] D31342: Add ParsedAttrInfo::handleDeclAttribute

john.brawn updated this revision to Diff 251113. john.brawn added a comment. Use an enum for the return value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31342/new/ https://reviews.llvm.org/D31342 Files: clang/docs/ClangPlugins.rst clang/docs/InternalsManual.rst

[PATCH] D31343: Add an attribute plugin example

john.brawn updated this revision to Diff 251114. john.brawn added a comment. Updated to match the changes to D31342 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D31343/new/ https://reviews.llvm.org/D31343 Files: clang/docs/ClangPlugins.rst

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added a comment. I have no further concerns with this patch (although I would suggest editing the description to use "Unicode" capitalized). I will leave approval of the patch to one of the requested reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 25. ZarkoCA marked an inline comment as done. ZarkoCA added a comment. Fixed testcase breakages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76130/new/ https://reviews.llvm.org/D76130 Files:

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a subscriber: steakhal. Szelethus added a comment. In D75682#1929093 , @balazske wrote: > In D75682#1928716 , @Szelethus wrote: > > > - For streams where the precise state is unknown (they are not

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/AST/ComputeDependence.cpp:174 ExprDependence clang::computeDependence(NoInitExpr *E) { return

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard updated this revision to Diff 251105. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76291/new/ https://reviews.llvm.org/D76291 Files: clang/test/Analysis/checker-plugins.c llvm/include/llvm/Support/FormattedStream.h

[PATCH] D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family.

miyuki accepted this revision. miyuki added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76359/new/ https://reviews.llvm.org/D76359

[PATCH] D76287: [analysis][analyzer] Introduce the skeleton of a reaching definitions calculator

Szelethus marked 9 inline comments as done. Szelethus added a comment. In D76287#1927340 , @xazax.hun wrote: > I think it is very crucial to make the intentions clear, how do you define > `definition` and `variable`? > Other than assignments we might

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao updated this revision to Diff 251101. hliao added a comment. Reformatting with clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76365/new/ https://reviews.llvm.org/D76365 Files: clang/include/clang/AST/Type.h

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

lebedev.ri added a comment. This seems misplaced - why is this in clang and not LLVM? Comment at: clang/include/clang/Basic/TargetInfo.h:1192 + // Get the cache line size of a given cpu. This method switches over + // the given cpu and returns `0` if the CPU is not found. +

[PATCH] D76346: [Syntax] Build template declaration nodes

thakis added a comment. Breaks tests on Windows: http://45.33.8.238/win/10716/step_7.txt Please take a look and revert if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76346/new/ https://reviews.llvm.org/D76346

[PATCH] D76366: [Syntax] Split syntax tests

hlopko added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://reviews.llvm.org/D76366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76366: [Syntax] Split syntax tests

hlopko updated this revision to Diff 251102. hlopko marked 5 inline comments as done. hlopko added a comment. Renaming some tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76366/new/ https://reviews.llvm.org/D76366 Files:

[PATCH] D76346: [Syntax] Build template declaration nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rGdd12826808f9: [Syntax] Build template declaration nodes (authored by hlopko, committed by gribozavr). Changed prior to commit: https://reviews.llvm.org/D76346?vs=251095=251100#toc Repository: rG

[PATCH] D76366: [Syntax] Split syntax tests

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/Tooling/Syntax/TreeTest.cpp:642 + +TEST_F(SyntaxTreeTest, UsingNamespaces) { + expectTreeDumpEqual( "using

[PATCH] D76346: [Syntax] Build template declaration nodes

hlopko updated this revision to Diff 251095. hlopko added a comment. Clang tidy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76346/new/ https://reviews.llvm.org/D76346 Files: clang/include/clang/Tooling/Syntax/Nodes.h

[PATCH] D75470: [SVE] Auto-generate builtins and header for svld1.

thakis added inline comments. Comment at: clang/utils/TableGen/TableGen.cpp:196 +clEnumValN(GenArmSveCodeGenMap, "gen-arm-sve-codegenmap", + "Generate arm_sve_codegenmap.inc for clang"), clEnumValN(GenArmMveHeader, "gen-arm-mve-header",

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

modocache added a comment. Awesome, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/ https://reviews.llvm.org/D75579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76367: [clang-format] Handle C# generic type constraints

jbcoe created this revision. jbcoe added a reviewer: krasimir. jbcoe added a project: clang-format. Herald added a project: clang. Herald added a subscriber: cfe-commits. Treat each C# generic type constraint, `where T: ...`, as a line. Add C# keyword: where Add Token Types:

[PATCH] D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers

martong added a comment. The way I see perhaps we need a 3rd class of checkers (beside super and sub). And that would be those checkers which are not dependent closely on any super checker but they do emit diagnostics. E.g. the PlacementNewChecker is implemented in it's own, it emits some

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/FormattedStream.cpp:59 +size_t NumBytes = getNumBytesForUTF8(PartialUTF8Char[0]); +if (NumBytes > (PartialUTF8Char.size() + Size)) { + // If we still don't have enough bytes for a complete

[PATCH] D74918: Add method to TargetInfo to get CPU cache line size

zoecarver added a comment. @kristof.beyls I'll try to bring that up in my libc++ patch, thanks. I'm planning on committing this today unless anyone still has concerns. @jyknight is this path OK with you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

jasonliu added inline comments. Comment at: clang/test/CodeGen/aix-vararg.c:10 + va_arg(arg, int); + va_end(arg); +} As part of a "va_..." family, do we also want to test va_copy? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] dd12826 - [Syntax] Build template declaration nodes

Author: Marcel Hlopko Date: 2020-03-18T16:16:59+01:00 New Revision: dd12826808f9079e164b82e64b0697a077379241 URL: https://github.com/llvm/llvm-project/commit/dd12826808f9079e164b82e64b0697a077379241 DIFF: https://github.com/llvm/llvm-project/commit/dd12826808f9079e164b82e64b0697a077379241.diff

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

balazske added a comment. In D75682#1928716 , @Szelethus wrote: > - For streams where the precise state is unknown (they are not tracked), > start tracking. If we explicitly check whether a state is `foef()`, we can > rightfully assume both of those

[PATCH] D76366: [Syntax] Split syntax tests

hlopko created this revision. hlopko added a reviewer: gribozavr2. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko added a parent revision: D76346: [Syntax] Build template declaration nodes. This patch split Basic test into multple individual tests to allow simpler

[PATCH] D76365: [cuda][hip] Add CUDA builtin surface/texture reference support.

hliao created this revision. hliao added reviewers: tra, rjmccall, yaxunl. Herald added a reviewer: a.sidorin. Herald added a project: clang. Herald added a subscriber: cfe-commits. - Even though the bindless surface/texture interfaces are promoted, there are still code using surface/texture

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

hubert.reinterpretcast added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:4232 QualType Ty) const { - if (getTarget().getTriple().isOSDarwin()) { + // TODO: Add AIX ABI Info. Currently we are relying on

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

sfertile added inline comments. Comment at: clang/lib/Basic/Targets/PPC.h:373 +// This is the ELF definition, and is overridden by the Darwin and AIX +// sub-target. return TargetInfo::PowerABIBuiltinVaList; Minor nit: `target` --> `targets`.

[PATCH] D72334: [Syntax] Build nodes for template declarations.

gribozavr2 added a comment. Superseded by https://reviews.llvm.org/D76346. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72334/new/ https://reviews.llvm.org/D72334 ___ cfe-commits mailing list

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong marked 11 inline comments as done. martong added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:298 +def StdCLibraryFunctionArgsChecker : Checker<"StdCLibraryFunctionArgs">, + HelpText<"Check constraints of arguments of C standard

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

martong updated this revision to Diff 251083. martong marked 5 inline comments as done. martong added a comment. - Add comments about what is a branch - Do not use 'this' for BugType - Lazily init BT and BT -> BT_InvalidArg - ReportBug -> reportBug Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D75661: Remove SequentialType from the type heirarchy.

nhaehnle added a comment. The AMDGPU changes LGTM, modulo a stylistic nitpick. As for the overall change, I'm perfectly fine with the general direction of SequentialType, though I don't know where we stand in terms of enough people having had a chance to look at it. I'm concerned though about

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein added inline comments. Comment at: clang/include/clang/AST/DependenceFlags.h:46 Instantiation = 2, +/// Placeholder, and is not used in actual Type. +Error = 4, sammccall wrote: > hokein wrote: > > sammccall wrote: > > > I'd like this comment

[PATCH] D75660: Remove CompositeType class

nhaehnle accepted this revision. nhaehnle added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75660/new/ https://reviews.llvm.org/D75660 ___ cfe-commits mailing list

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein updated this revision to Diff 251077. hokein marked 10 inline comments as done. hokein added a comment. address comments, and add more missing-error-bit cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

Szelethus accepted this revision. Szelethus added a comment. LGTM! Please address the nits before commiting, but there is no need for another round of reviews. :) edit: from my end, that is. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:175 +

[PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

djtodoro added a comment. Since we landed the fix for the issue related to the D75036 , I'll reland this again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73534/new/ https://reviews.llvm.org/D73534 ___

[PATCH] D76344: [hip] Revise `GlobalDecl` constructors. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4cf01ed75e35: [hip] Revise `GlobalDecl` constructors. NFC. (authored by hliao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76344/new/

[PATCH] D67336: [analyzer][NFC] Introduce SuperChecker<>, a convenient alternative to Checker<> for storing subcheckers

Szelethus added a comment. Herald added subscribers: ASDenysPetrov, martong, steakhal. > I have mixed feelings. Removing boilerplate is good, but the very fact that > we're legalizing this pattern indicates that our checkers will keep bloating > up, while i always wanted to actually split them

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA marked 8 inline comments as done. ZarkoCA added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:7088 + GPRIndex < NumGPArgRegs; ++GPRIndex) { +unsigned VReg = MF.getRegInfo().getLiveInVirtReg( +IsPPC64 ?

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames `using namespace` decls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a commenting nit. Comment at: clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp:276 + +// fix using namespace decls +if

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware created this revision. baloghadamsoftware added reviewers: NoQ, Szelethus. baloghadamsoftware added a project: clang. Herald added subscribers: ASDenysPetrov, martong, steakhal, Charusso, gamesh411, dkrupp, donat.nagy, mikhail.ramalho, a.sidorin, rnkovacs, szepet, xazax.hun,

[PATCH] D76130: [PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX

ZarkoCA updated this revision to Diff 251065. ZarkoCA retitled this revision from "[PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX in 32-bit mode." to "[PPC][AIX] Implement variadic function handling in LowerFormalArguments_AIX". ZarkoCA edited the summary of this

[PATCH] D76361: [Analyzer] Iterator Modeling - Model `std::advance()`, `std::prev()` and `std::next()`

baloghadamsoftware added a comment. Partially replacing D62895 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76361/new/ https://reviews.llvm.org/D76361 ___

[PATCH] D74144: [OPENMP50]Add basic support for array-shaping operation.

ABataev added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74144/new/ https://reviews.llvm.org/D74144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76360: [PPC][AIX] Emit correct Vaarg for 32BIT-AIX in clang

ZarkoCA created this revision. Herald added subscribers: cfe-commits, kbarton, nemanjai. Herald added a project: clang. ZarkoCA added reviewers: jasonliu, sfertile, cebowleratibm. Herald added a subscriber: wuzish. This patch contains only the FE changes previously found in

[clang] 4cf01ed - [hip] Revise `GlobalDecl` constructors. NFC.

Author: Michael Liao Date: 2020-03-18T09:33:39-04:00 New Revision: 4cf01ed75e35e7bd3ef8ef1a2192c7f4656ab545 URL: https://github.com/llvm/llvm-project/commit/4cf01ed75e35e7bd3ef8ef1a2192c7f4656ab545 DIFF: https://github.com/llvm/llvm-project/commit/4cf01ed75e35e7bd3ef8ef1a2192c7f4656ab545.diff

[PATCH] D76359: [ARM,MVE] Add intrinsics for the VQDMLAD family.

simon_tatham created this revision. simon_tatham added reviewers: dmgreen, MarkMurrayARM, miyuki, ostannard. Herald added subscribers: cfe-commits, hiraditya, kristof.beyls. Herald added a project: clang. This is another set of instructions too complicated to be sensibly expressed in IR by

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus updated this revision to Diff 251056. Szelethus added a comment. Seems like D75171 didn't add const methods after all, here they are. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 Files:

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

ostannard accepted this revision. ostannard added a comment. This revision is now accepted and ready to land. I agree with @dnsampaio here, it's better to match the existing style, and avoid irrelevant churn in the git history. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus updated this revision to Diff 251053. Szelethus added a comment. Address inlines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75360/new/ https://reviews.llvm.org/D75360 Files: clang/include/clang/StaticAnalyzer/Core/CheckerManager.h

[PATCH] D75063: [analyzer] StdLibraryFunctionsChecker: Add NotNull Arg Constraint

martong marked 6 inline comments as done. martong added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:175 +using ValueConstraint::ValueConstraint; +bool CannotBeNull = true; +

[clang] b09cce0 - [OPENMP50]Codegen for detach clause.

Author: Alexey Bataev Date: 2020-03-18T09:01:17-04:00 New Revision: b09cce07c7ebd6d42c97f7144f5a2e7dd8fca19e URL: https://github.com/llvm/llvm-project/commit/b09cce07c7ebd6d42c97f7144f5a2e7dd8fca19e DIFF: https://github.com/llvm/llvm-project/commit/b09cce07c7ebd6d42c97f7144f5a2e7dd8fca19e.diff

[PATCH] D74619: [ARM] Enabling range checks on Neon intrinsics' lane arguments

dnsampaio added a comment. Hi, thanks for looking into this. The patch LGTM, but regarding the indentation, I don't know what would be the best practice here. We tend to like to preserve the line-git-history, but if we start ignoring the formater check, then it has no sense in they being

[PATCH] D76355: [Syntax] Build mapping from AST to syntax tree nodes

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko edited the summary of this revision. hlopko added a parent revision: D76346: [Syntax] Build template declaration nodes. Copy of https://reviews.llvm.org/D72446, submitting with Ilya's

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

SjoerdMeijer added a comment. That sounds good and that seems to address the feedback given here, which I agree with. Just wanted to briefly add that while it already looks like most interested people are on this ticket, perhaps it good to also share the plan and design on the cfe dev list for

[PATCH] D75220: [clang-tidy] RenamerClangTidy now correctly renames `using namespace` decls

njames93 added a comment. Ping?? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75220/new/ https://reviews.llvm.org/D75220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75682: [Analyzer][StreamChecker] Introduction of stream error handling.

Szelethus added a comment. Herald added a subscriber: ASDenysPetrov. In D75682#1926889 , @balazske wrote: > In D75682#1926732 , @Szelethus wrote: > > > Rght I think I finally get it. You don't want to state

[PATCH] D72742: Don't assume promotable integers are zero/sign-extended already in x86-64 ABI.

jyknight added a comment. I wrote some stuff on https://bugs.llvm.org/show_bug.cgi?id=44228, probably best to continue the discussion there. I really don't think we should take this patch -- at least not without reopening the ABI discussion first. Repository: rG LLVM Github Monorepo

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:277 build(std::move(*CurrentReq)); + bool IsEmpty = false; + { kadircet

[PATCH] D75169: [ARM] Enforcing calling convention for half-precision FP arguments and returns for big-endian AArch32

pratlucas added a comment. > Oh, wait, AAPCS wants half values to be passed in the *least* significant > bits of a GPR, even on big-endian machines? That's certainly more convenient, > but it's a weird inconsistency with the otherwise iron rule of the calling > convention, which that it's

[PATCH] D76077: [ARM] Add __bf16 as new Bfloat16 C Type

stuij added a comment. Thanks for the feedback. We'll work on implementing a bfloat IR type. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76077/new/ https://reviews.llvm.org/D76077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

Szelethus marked an inline comment as done. Szelethus added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:217 +mgr.template registerChecker(); } baloghadamsoftware wrote: > NoQ wrote: > > Szelethus wrote: > >

[PATCH] D76299: [ARM,CDE] Implement CDE unpredicated Q-register intrinsics

miyuki updated this revision to Diff 251039. miyuki added a comment. Fixed formatting. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76299/new/ https://reviews.llvm.org/D76299 Files: clang/include/clang/Basic/arm_cde.td clang/test/CodeGen/arm-cde-vec.c

[PATCH] D75842: [Analyzer] Bugfix for CheckerRegistry

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75842/new/ https://reviews.llvm.org/D75842 ___ cfe-commits mailing

[PATCH] D76298: [ARM,CDE] Implement CDE S and D-register intrinsics

miyuki updated this revision to Diff 251038. miyuki added a comment. Fixed formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76298/new/ https://reviews.llvm.org/D76298 Files: clang/include/clang/Basic/arm_cde.td clang/test/CodeGen/arm-cde-vfp.c

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

sammccall added inline comments. Comment at: clang/include/clang/AST/DependenceFlags.h:46 Instantiation = 2, +/// Placeholder, and is not used in actual Type. +Error = 4, hokein wrote: > sammccall wrote: > > I'd like this comment to explain why it

[PATCH] D76123: [ARM,MVE] Add intrinsics for the VQDMLAH family.

This revision was automatically updated to reflect the committed changes. Closed by commit rG928776de9233: [ARM,MVE] Add intrinsics for the VQDMLAH family. (authored by simon_tatham). Changed prior to commit: https://reviews.llvm.org/D76123?vs=250157=251032#toc Repository: rG LLVM Github

[PATCH] D76122: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA.

This revision was automatically updated to reflect the committed changes. simon_tatham marked an inline comment as done. Closed by commit rG28c5d97beec7: [ARM,MVE] Add intrinsics and isel for MVE integer VMLA. (authored by simon_tatham). Changed prior to commit:

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard updated this revision to Diff 251030. ostannard added a comment. - I managed to reproduce the lsl-zero.s test failure on windows, this turned out to be because the test merges stdout and stderr, which can result in them being interleaved in ways which breaks tests. The test doesn't

[PATCH] D76291: [Support] Fix formatted_raw_ostream for UTF-8

ostannard marked 16 inline comments as done. ostannard added inline comments. Comment at: llvm/unittests/Support/formatted_raw_ostream_test.cpp:88 + +TEST(formatted_raw_ostreamTest, Test_UTF8) { + SmallString<128> A; hubert.reinterpretcast wrote: > Should there

[PATCH] D76032: [HIP] Fix duplicate clang -cc1 options on MSVC toolchain

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76032/new/ https://reviews.llvm.org/D76032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

SjoerdMeijer added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:184 + // Also include the Armv8.5 defines + // FIXME: Armv8.6 makes some extensions mandatory. Handle them here. + getTargetDefinesARMV85A(Opts, Builder); Can you be more

[PATCH] D76344: [hip] Revise `GlobalDecl` constructors. NFC.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76344/new/ https://reviews.llvm.org/D76344

[clang] c5b8146 - Reland D75470 [SVE] Auto-generate builtins and header for svld1.

Author: Sander de Smalen Date: 2020-03-18T11:16:28Z New Revision: c5b81466c2bcc194e5563f39f5be3638760b4849 URL: https://github.com/llvm/llvm-project/commit/c5b81466c2bcc194e5563f39f5be3638760b4849 DIFF: https://github.com/llvm/llvm-project/commit/c5b81466c2bcc194e5563f39f5be3638760b4849.diff

[clang] 928776d - [ARM,MVE] Add intrinsics for the VQDMLAH family.

Author: Simon Tatham Date: 2020-03-18T10:55:04Z New Revision: 928776de9233be1487c1b56f90c90ed25b25e355 URL: https://github.com/llvm/llvm-project/commit/928776de9233be1487c1b56f90c90ed25b25e355 DIFF: https://github.com/llvm/llvm-project/commit/928776de9233be1487c1b56f90c90ed25b25e355.diff LOG:

[clang] 28c5d97 - [ARM, MVE] Add intrinsics and isel for MVE integer VMLA.

Author: Simon Tatham Date: 2020-03-18T10:55:04Z New Revision: 28c5d97beec7a2582869f992f54a178c805e2e51 URL: https://github.com/llvm/llvm-project/commit/28c5d97beec7a2582869f992f54a178c805e2e51 DIFF: https://github.com/llvm/llvm-project/commit/28c5d97beec7a2582869f992f54a178c805e2e51.diff LOG:

[PATCH] D75579: Replace MCTargetOptionsCommandFlags.inc and CommandFlags.inc by runtime-registration

serge-sans-paille added a comment. @modocache: fixed by 8d019cda851a1031fbce3c50be0975438147f11d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75579/new/

[PATCH] D76062: [PATCH] [ARM] ARMv8.6-a command-line + BFloat16 Asm Support

stuij added a comment. The failing test is not related to this ticket. It is caused by https://reviews.llvm.org/D70720/new/#1925184, Oliver Stannard is looking into it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76062/new/

[PATCH] D66332: [clang-format] Fix the bug that joins template closer and > or >>

hans added a comment. This seems to have caused https://bugs.llvm.org/show_bug.cgi?id=45218 Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66332/new/ https://reviews.llvm.org/D66332

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein added a comment. In D65591#1927076 , @sammccall wrote: > This is nice and simple, I do wonder whether we're missing cases in > ComputeDependence.cpp for the new bit. > > Can you take a pass through to check? (Assuming you haven't since picking up

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:161 +/// update. +class TUStatusManager { +public: sammccall wrote: > nit: "manager" doesn't really explain what this is, and it's used both as the > class name and the main

[PATCH] D76304: [clangd] Update TUStatus api to accommodate preamble thread

kadircet updated this revision to Diff 251022. kadircet marked 8 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76304/new/ https://reviews.llvm.org/D76304 Files:

[PATCH] D65591: [AST] Add a flag indicating if any subexpression had errors

hokein updated this revision to Diff 251019. hokein marked 5 inline comments as done. hokein added a comment. - address comments - remove the placeholder errorbit in non-Expr dependence Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65591/new/

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 251021. kadircet added a comment. - Reset CurrentReq inside run loop, rather than inside build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files:

[PATCH] D72334: [Syntax] Build nodes for template declarations.

hlopko added a comment. Let's continue the review at https://reviews.llvm.org/D76346. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:190 + // Set role for the node that may or may not be delayed. Node must span + // exactly \p Range. + void

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

lewis-revill accepted this revision. lewis-revill added a comment. This revision is now accepted and ready to land. Thanks, this is looking in good shape now. As long as everyone agrees on this scheme I think the implementation is good to go (pending the bitmanip extension support).

[PATCH] D73898: [analyzer] StdLibraryFunctionsChecker: Add argument constraints

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:191 + /// * a list of branches - a list of list of ranges - + /// i.e. a list of lists of lists of segments, + /// * a list of argument constraints, that must

[PATCH] D76346: Build template declaration nodes

hlopko created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. hlopko added a reviewer: gribozavr2. Copy of https://reviews.llvm.org/D72334, submitting with Ilya's permission. Handles template declaration of all kinds. Also builds template declaration nodes

[PATCH] D76030: [CUDA] Warn about unsupported CUDA SDK version only if it's used.

hans added a comment. In D76030#1925445 , @tra wrote: > @hans -- this should be cherry-picked into 10 if it's not too late yet. It's probably too late for 10.0.0, but sounds like a good candidate for 10.0.1. Repository: rG LLVM Github Monorepo

[PATCH] D69778: Make -fmodules-codegen and -fmodules-debuginfo work also with precompiled headers

llunak added a comment. In D69778#1928111 , @dblaikie wrote: > In D69778#1927761 , @llunak wrote: > > > It comes from 08c5a7b8fda1b97df9d027d1ac096f93edeb6c2f . AFAICT > > -fmodules-codegen is a superset of

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet updated this revision to Diff 251011. kadircet marked 2 inline comments as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76125/new/ https://reviews.llvm.org/D76125 Files:

[PATCH] D76125: [clangd] Decouple preambleworker from astworker, NFCI

kadircet marked 16 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/clangd/TUScheduler.cpp:265 + /// Updates the TUStatus and emits it. Only called in the worker thread. + void emitTUStatus(TUAction Action, +const

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGbd763e2cf7c1: [clang] Fix crash on visiting null nestedNameSpecifier. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75360: [analyzer][NFC] Tie CheckerRegistry to CheckerManager, allow CheckerManager to be constructed for non-analysis purposes

baloghadamsoftware added inline comments. Herald added a subscriber: ASDenysPetrov. Comment at: clang/include/clang/StaticAnalyzer/Frontend/CheckerRegistry.h:217 +mgr.template registerChecker(); } NoQ wrote: > Szelethus wrote: > > baloghadamsoftware

[clang] bd763e2 - [clang] Fix crash on visiting null nestedNameSpecifier.

Author: Haojian Wu Date: 2020-03-18T09:15:02+01:00 New Revision: bd763e2cf7c1d84bab95064cc5cbe542b227b025 URL: https://github.com/llvm/llvm-project/commit/bd763e2cf7c1d84bab95064cc5cbe542b227b025 DIFF: https://github.com/llvm/llvm-project/commit/bd763e2cf7c1d84bab95064cc5cbe542b227b025.diff

[PATCH] D71920: [AST] Refactor propagation of dependency bits. NFC

AlexeySachkov added inline comments. Comment at: clang/include/clang/AST/Type.h:1827-1830 +if (Dependent) + Deps |= TypeDependence::Dependent | TypeDependence::Instantiation; +if (InstantiationDependent) + Deps |= TypeDependence::Instantiation;

[PATCH] D76320: [clang] Fix crash on visiting null nestedNameSpecifier.

hokein updated this revision to Diff 251006. hokein marked an inline comment as done. hokein added a comment. address review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76320/new/ https://reviews.llvm.org/D76320 Files:

<    1   2   3   >