[clang] 410cfc4 - [OpenMP][FIX] Add second include after header was split in d1705c1196

Author: Johannes Doerfert Date: 2020-04-02T00:20:23-05:00 New Revision: 410cfc478f3540d3f07bba920fa3bf99409f6bda URL: https://github.com/llvm/llvm-project/commit/410cfc478f3540d3f07bba920fa3bf99409f6bda DIFF:

[PATCH] D77238: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1705c1196fe: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h (authored by jdoerfert). Changed prior to commit: https://reviews.llvm.org/D77238?vs=254289=254426#toc

[PATCH] D72959: Relative VTables ABI on Fuchsia

ldionne requested changes to this revision. ldionne added inline comments. Comment at: libcxxabi/src/private_typeinfo.cpp:617 // Get (dynamic_ptr, dynamic_type) from static_ptr +#ifndef __Fuchsia__ void **vtable = *static_cast(static_ptr); Please

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso updated this revision to Diff 254420. Charusso marked 4 inline comments as done. Charusso added a comment. - Simplify tests. - Remove dead code, they are far away to being used. - Add an extra test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso updated this revision to Diff 254423. Charusso added a comment. - Remove the last dead comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70411/new/ https://reviews.llvm.org/D70411 Files: clang/docs/analyzer/checkers.rst

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

rjmccall added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1508 void checkFunc(SourceLocation Loc, FunctionDecl *FD) { +auto DiagsCountIt = DiagsCount.find(FD); FunctionDecl *Caller = UseStack.empty() ? nullptr : UseStack.back(); It makes me

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Herald added a subscriber: danielkiss. Seems reasonable, though this isn't UB, its just use of an uninitialized variable. Please add a test case. Repository: rG LLVM Github

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi marked an inline comment as done. plotfi added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00,

[PATCH] D70411: [analyzer] CERT: STR31-C

Charusso added a comment. Thanks for the review, hopefully if I ping @NoQ in every round, it will be green-marked soon. Comment at: clang/lib/StaticAnalyzer/Checkers/cert/StrChecker.cpp:55 + // they can cause a not null-terminated string. In this case we store the + //

[PATCH] D77238: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

hliao added a comment. this patch breaks the test clang/test/Headers/nvptx_device_cmath_functions.cpp, could you please fix it ASAP? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77238/new/ https://reviews.llvm.org/D77238

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254418. pratyai added a comment. - Switched to Int1Ty. - Switched Atomic::NonAtomic (same as just dropping the two lines?) - C++ files were clang-formatted, but arc lint couldn't find clang-format-diff before. Now it seems to have formatted the lit tests. -

[clang] d1705c1 - [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

Author: Johannes Doerfert Date: 2020-04-01T23:46:27-05:00 New Revision: d1705c1196fedfe927716923ac121f1134924a36 URL: https://github.com/llvm/llvm-project/commit/d1705c1196fedfe927716923ac121f1134924a36 DIFF:

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

compnerd added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, It seems that you are touching all the

[PATCH] D76812: [X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [3/3]

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76812/new/ https://reviews.llvm.org/D76812 ___ cfe-commits mailing list

[PATCH] D73290: [PowerPC] Add clang -msvr4-struct-return for 32-bit ELF

brad added a comment. Now that 10 is out, any chance of getting some movement on this to resolve this ABI issue with 32-bit PowerPC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73290/new/ https://reviews.llvm.org/D73290

[PATCH] D77028: [NFC] Refactor DeferredDiagsEmitter and skip redundant visit

yaxunl updated this revision to Diff 254407. yaxunl added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77028/new/ https://reviews.llvm.org/D77028 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/Sema.cpp Index: clang/lib/Sema/Sema.cpp

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

vitalybuka added a comment. LGTM would it be possible to split into 3 patches 1. Instrumentation 2. clang flags stuff 3. compiler-rt test Btw. is this clang formated? Comment at: llvm/lib/Transforms/Instrumentation/SanitizerCoverage.cpp:482 +Ctor =

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:1882 + if (FI.isCmseNSCall()) +FuncAttrs.addAttribute("cmse_nonsecure_call"); + Just curious … Does the LLVM backend have a way to extract a StringRef attribute from a CallInst? I

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

This revision was automatically updated to reflect the committed changes. Closed by commit rG5767085c8de9: Fix infinite recursion in deferred diag emitter (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 5767085 - Fix infinite recursion in deferred diag emitter

Author: Yaxun (Sam) Liu Date: 2020-04-01T22:17:43-04:00 New Revision: 5767085c8de97d15d7fb5433f22bb5b858cc4f3a URL: https://github.com/llvm/llvm-project/commit/5767085c8de97d15d7fb5433f22bb5b858cc4f3a DIFF:

[PATCH] D76184: [OpenMP][NFC] Remove the need to include `OpenMPClause.h`

jdoerfert added a comment. Herald added a subscriber: yaxunl. @rnk What is the plan for this one now? Should I abandon it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76184/new/ https://reviews.llvm.org/D76184

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 254392. atmnpatel added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D74935: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects

This revision was automatically updated to reflect the committed changes. Closed by commit rG6cd673345cfa: [LangRef][AliasAnalysis] Clarify `noalias` affects only modified objects (authored by jdoerfert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 254384. oontvoo added a comment. Update docs. Note: The failure looks spurious ... They seemed to pass locally for me: One eg: [hi on] vyng@vyng:~/repo/llvm-project$ ./build/bin/llvm-lit -v ./clang/test/ClangScanDeps/modules-full.cpp llvm-lit:

[PATCH] D75561: Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGf4754ea0ed7d: Remove const qualifier from Modules returned by ExternalASTSource. (NFC) (authored by aprantl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D77282: [AST] Fix formatting whitespace-only comments

refi64 added a comment. (I manually ran clang-format-diff afterwards, there were no suggested changes.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77282/new/ https://reviews.llvm.org/D77282 ___

[PATCH] D77282: [AST] Fix formatting whitespace-only comments

refi64 created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, ilya-biryukov. Herald added a project: clang. refi64 added a reviewer: ilya-biryukov. refi64 added a comment. (I manually ran clang-format-diff afterwards, there were no suggested changes.) If a string

[PATCH] D75591: [OpenMP] Add firstprivate as a default data-sharing attribute to clang

atmnpatel updated this revision to Diff 254379. atmnpatel added a comment. Herald added a subscriber: yaxunl. Fixes to tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75591/new/ https://reviews.llvm.org/D75591 Files:

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

asbirlea updated this revision to Diff 254378. asbirlea added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update clang test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72893/new/

[PATCH] D76818: [clang-tidy] Add check llvmlibc-implementation-in-namespace.

PaulkaToast updated this revision to Diff 254376. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76818/new/ https://reviews.llvm.org/D76818 Files: clang-tools-extra/clang-tidy/llvmlibc/CMakeLists.txt

[clang] f4754ea - Remove const qualifier from Modules returned by ExternalASTSource. (NFC)

Author: Adrian Prantl Date: 2020-04-01T17:46:02-07:00 New Revision: f4754ea0ed7ddc35042bacbc47d661bfe660f132 URL: https://github.com/llvm/llvm-project/commit/f4754ea0ed7ddc35042bacbc47d661bfe660f132 DIFF: https://github.com/llvm/llvm-project/commit/f4754ea0ed7ddc35042bacbc47d661bfe660f132.diff

[PATCH] D75788: [OpenMP] Provide math functions in OpenMP device code via OpenMP variants

jdoerfert updated this revision to Diff 254375. jdoerfert added a comment. Herald added a subscriber: yaxunl. Rewrite. Wrap math.h, time.h, and cmath. Preload only device functions. Passes all 185 math c++11 tests from [0] which do not deal with long double. [0]

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added a comment. Have you already committed support for CMSE attributes to the LLVM backend? Or is that on the way? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71129/new/ https://reviews.llvm.org/D71129

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/include/clang/AST/Type.h:3622 bool getNoCfCheck() const { return Bits & NoCfCheckMask; } bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; } chill wrote: > snidertm wrote: > > chill

[PATCH] D73307: Unique Names for Functions with Internal Linkage

tmsriram updated this revision to Diff 254347. tmsriram added a comment. Rebase and add tests for anonymous namespace symbol and function static global. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73307/new/ https://reviews.llvm.org/D73307 Files: clang/docs/UsersManual.rst

[PATCH] D77257: Clean up usages of asserting vector getters in Type

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove usages of asserting vector getters in Type in preparation for the VectorType refactor. The existence of these functions complicates the refactor while adding little value. Repository:

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 2 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3622 bool getNoCfCheck() const { return Bits & NoCfCheckMask; } bool getHasRegParm() const { return (Bits >> RegParmOffset) != 0; }

[PATCH] D77254: Clean up usages of asserting vector getters in Type

ctetreau created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove usages of asserting vector getters in Type in preparation for the VectorType refactor. The existence of these functions complicates the refactor while adding little value. Repository:

[PATCH] D74299: [clang-tidy] extend tests of run-clang-tidy

AlexanderLanin added a comment. *ping* CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74299/new/ https://reviews.llvm.org/D74299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77234: clang/AMDGPU: Stop setting old denormal subtarget features

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77234/new/ https://reviews.llvm.org/D77234 ___ cfe-commits mailing list

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. We do have a problem. With your patch I see a lot of errors about function redefinitions conflicting with the ones in CUDA's `math_functions.hpp`: E.g: In file included from :1: In file included from

[PATCH] D73307: Unique Names for Functions with Internal Linkage

davidxl added inline comments. Comment at: clang/test/CodeGen/unique-internal-linkage-names.cpp:29 +int mver_call() { + return mver(); +} [a side note]: interesting, since when Clang had this target attribute based multi-versioning and function overloading ?

[PATCH] D77236: [SVE] Cleanup prior to introdution of FixedVectorType

ctetreau updated this revision to Diff 254327. ctetreau added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Split commit up into multiple smaller commits: 1 commit per llvm library, 1 for clang, and 1 for mlir. Plus one final commit to remove the functions

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/include/clang/AST/Type.h:3604 + (noCallerSavedRegs ? NoCallerSavedRegsMask : 0) | + (hasRegParm ? ((regParm + 1) << RegParmOffset) : 0) | + (NoCfCheck ? NoCfCheckMask : 0) |

[PATCH] D77246: Instead of scream, why not roll?

lazerl0rd created this revision. lazerl0rd added reviewers: nathanchance, clang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Everyone naturally converts hex to text when they see a long value, so provide clearer information on their bad coding habits with a nice link.

[PATCH] D76389: [NewPM] Run the Speculative Execution Pass only if the target has divergent branches

arsenm added inline comments. Comment at: clang/test/CodeGen/thinlto-distributed-newpm.ll:110 ; CHECK-O: Running analysis: OuterAnalysisManagerProxy -; CHECK-O: Running pass: SpeculativeExecutionPass on main +; CHECK-O: Running pass:

[PATCH] D75951: Keep a list of already-included pragma-once files for mods.

oontvoo updated this revision to Diff 254321. oontvoo added a comment. clean up ... Ready to review. PTAL! =) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75951/new/ https://reviews.llvm.org/D75951 Files: clang/include/clang/Lex/HeaderSearch.h

[PATCH] D77236: [SVE] Cleanup prior to introdution of FixedVectorType

ctetreau added a comment. > 1. This is orthogonal to splitting VectorType, as far as I can tell. > `Ty->getVectorNumElements()` works equally well whether the implementation > asserts it's a VectorType that isn't scalable, or asserts it's a > FixedVectorType. While it's not strictly

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

chill marked 3 inline comments as done. chill added inline comments. Comment at: clang/include/clang/AST/Type.h:3588 + NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask), RegParmOffset = 8 }; // Assumed to be the last field

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert added a comment. In D77240#1955755 , @tra wrote: > In D77240#1955724 , @jdoerfert wrote: > > > At least that one is defined in what is "now" `__clang_cuda_math.h`: > > > Cool. We may be OK, but we still

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. In D77240#1955724 , @jdoerfert wrote: > At least that one is defined in what is "now" `__clang_cuda_math.h`: Cool. We may be OK, but we still need to verify it. Math headers are rather fragile and we need to make sure it all still

[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

dblaikie added a comment. This wasn't well committed, unfortunately. It seems it was committed in two parts: IR support and clang functionality: https://github.com/llvm/llvm-project/commit/7a42babeb83e3927e89e72a0e7e45be9d41b6c23 (a recommit of

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254316. pratyai added a comment. Still had a couple of lines of diff left :( Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/ https://reviews.llvm.org/D77244 Files: clang/docs/SanitizerCoverage.rst

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:611 def fno_cuda_short_ptr : Flag<["-"], "fno-cuda-short-ptr">; +def rocm_path_EQ : Joined<["--"], "rocm-path=">, Group, + HelpText<"ROCm installation path">; HIP toolchain will

[PATCH] D77236: [SVE] Cleanup prior to introdution of FixedVectorType

efriedma added a comment. My thoughts, in no particular order: 1. This is orthogonal to splitting VectorType, as far as I can tell. `Ty->getVectorNumElements()` works equally well whether the implementation asserts it's a VectorType that isn't scalable, or asserts it's a FixedVectorType. 2.

[PATCH] D71129: [ARM][CMSE] Implement CMSE attributes

snidertm added inline comments. Comment at: clang/include/clang/AST/Type.h:3588 + NoCallerSavedRegsMask | NoCfCheckMask | CmseNSCallMask), RegParmOffset = 8 }; // Assumed to be the last field Shouldn't RegParmOffset be updated to

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai updated this revision to Diff 254312. pratyai added a comment. Removed some unintentional diffs. Removed some unintentional diffs from clang/lib/Frontend/CompilerInvocation.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77244/new/

[PATCH] D77239: [CUDA][NFCI] Use unqualified lookup for math functions

jdoerfert abandoned this revision. jdoerfert added a comment. In D77239#1955720 , @tra wrote: > > The other macro uses a unqualified lookup already and the qualified one > > will cause problems in the OpenMP overlay. > > There's a bit of inconsitency

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert added a comment. In D77240#1955678 , @tra wrote: > We'll need to make sure that all of these new functions are vailable in all > supported CUDA versions. > E.g. `acoshf` does not seem to be present in CUDA-9. At least that one is defined in

[PATCH] D77239: [CUDA][NFCI] Use unqualified lookup for math functions

tra added a subscriber: jlebar. tra added a comment. > The other macro uses a unqualified lookup already and the qualified one > will cause problems in the OpenMP overlay. There's a bit of inconsitency here. While `__CUDA_CLANG_FN_INTEGER_OVERLOAD_2` indeed uses unqualified lookup, pretty

[PATCH] D77238: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

jdoerfert marked an inline comment as done. jdoerfert added inline comments. Comment at: clang/lib/Headers/__clang_cuda_math.h:81 +#endif +__DEVICE__ long long clock64() { return __nvvm_read_ptx_sreg_clock64(); } +__DEVICE__ double copysign(double __a, double __b) {

[PATCH] D77244: sancov/inline-bool-flag feature + tests + docs.

pratyai created this revision. pratyai added reviewers: kcc, vitalybuka. Herald added subscribers: Sanitizers, cfe-commits, jfb, hiraditya. Herald added projects: clang, Sanitizers. pratyai updated this revision to Diff 254312. pratyai added a comment. Removed some unintentional diffs. Removed

[PATCH] D77240: [CUDA] Add missing cmath overloads

tra added a comment. We'll need to make sure that all of these new functions are vailable in all supported CUDA versions. E.g. `acoshf` does not seem to be present in CUDA-9. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77240/new/

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

arsenm marked 2 inline comments as done. arsenm added a comment. In D59321#1955405 , @hliao wrote: > Do we have a better way to avoid adding those empty bitcode files? No, we need the files to exist for tests. This is what existing bitcode link tests

[PATCH] D70094: [clang-tidy] new altera ID dependent backward branch check

ffrankies updated this revision to Diff 254305. ffrankies marked 5 inline comments as done. ffrankies added a comment. - Updated underlying repo to https://github.com/llvm/llvm-project - Removed braces from one-line if-statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70094/new/

[PATCH] D77131: [clang] Move branch-protection from CodeGenOptions to LangOptions

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77131/new/ https://reviews.llvm.org/D77131 ___ cfe-commits mailing list

[PATCH] D72241: [clang-tidy] new altera single work item barrier check

ffrankies updated this revision to Diff 254304. ffrankies added a comment. - Updated underlying repo to https://github.com/llvm/llvm-project - Removed braces from one-line if-statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72241/new/ https://reviews.llvm.org/D72241 Files:

[PATCH] D72218: [clang-tidy] new altera kernel name restriction check

ffrankies updated this revision to Diff 254301. ffrankies added a comment. - Updated underlying repo to https://github.com/llvm/llvm-project - Removed braces from one-line if-statements CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72218/new/ https://reviews.llvm.org/D72218 Files:

[PATCH] D72235: [clang-tidy] new altera unroll loops check

ffrankies updated this revision to Diff 254299. ffrankies added a comment. Addressed comments by @Eugene.Zelenko - Removed braces from one-lien if statements - Release notes on the altera unroll loops check now match the first line of documentation. CHANGES SINCE LAST ACTION

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 254297. plotfi added a comment. Applying clang-format suggestions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files: clang/include/clang/AST/DeclObjC.h

[PATCH] D77240: [CUDA] Add missing cmath overloads

jdoerfert created this revision. jdoerfert added a reviewer: tra. Herald added subscribers: bollu, yaxunl. Herald added a project: clang. Some function overloads for floats were missing, found by running a test suite [0] with the OpenMP overlay. [0] https://github.com/TApplencourt/OmpVal

[PATCH] D77238: [CUDA][NFC] Split math.h functions out of __clang_cuda_device_functions.h

jdoerfert created this revision. jdoerfert added a reviewer: tra. Herald added subscribers: bollu, yaxunl, mgorny. Herald added a project: clang. jdoerfert added a child revision: D77239: [CUDA][NFCI] Use unqualified lookup for math functions. This is not supported to change anything but allow

[PATCH] D77239: [CUDA][NFCI] Use unqualified lookup for math functions

jdoerfert created this revision. jdoerfert added a reviewer: tra. Herald added subscribers: bollu, yaxunl. Herald added a project: clang. jdoerfert added a child revision: D77240: [CUDA] Add missing cmath overloads. The other macro uses a unqualified lookup already and the qualified one will

Re: [clang] db92719 - DebugInfo: Defaulted non-type template parameters of bool type

On Wed, Apr 1, 2020 at 1:21 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: David Blaikie > Date: 2020-04-01T13:21:13-07:00 > New Revision: db92719c1d17f5052e7cd1309b0e1e92240f47be > > URL: >

[clang] 6e916b5 - Updating the documentation for the noescape attribute.

Author: Aaron Ballman Date: 2020-04-01T16:21:37-04:00 New Revision: 6e916b5860950fee2661ded847abe551f5259ec4 URL: https://github.com/llvm/llvm-project/commit/6e916b5860950fee2661ded847abe551f5259ec4 DIFF: https://github.com/llvm/llvm-project/commit/6e916b5860950fee2661ded847abe551f5259ec4.diff

[clang] db92719 - DebugInfo: Defaulted non-type template parameters of bool type

Author: David Blaikie Date: 2020-04-01T13:21:13-07:00 New Revision: db92719c1d17f5052e7cd1309b0e1e92240f47be URL: https://github.com/llvm/llvm-project/commit/db92719c1d17f5052e7cd1309b0e1e92240f47be DIFF: https://github.com/llvm/llvm-project/commit/db92719c1d17f5052e7cd1309b0e1e92240f47be.diff

[PATCH] D66564: [clang-tidy] new altera struct pack align check

ffrankies updated this revision to Diff 254277. ffrankies added a comment. Addressed comments by @aaron.ballman You're right, we don't want this to trigger on template instantiations and structs declared in system headers. - Check no longer triggers on template instantiations - Check no longer

[PATCH] D76812: [X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [3/3]

sconstab updated this revision to Diff 254276. sconstab added a comment. @craig.topper I think that removing spurious MBBs is not really necessary because the emitted machine code doesn't contain the spurious MBBs, from what I have observed. I added the check anyways, if only because others may

[PATCH] D77168: Add a flag to debug automatic variable initialization

MaskRay added a comment. In D77168#1955500 , @jfb wrote: > In D77168#1955450 , @jcai19 wrote: > > > In D77168#1955312 , @jfb wrote: > > > > > Do you not think `pragma` is a

[PATCH] D77168: Add a flag to debug automatic variable initialization

jfb added a comment. In D77168#1955450 , @jcai19 wrote: > In D77168#1955312 , @jfb wrote: > > > Do you not think `pragma` is a more general approach? That's what's used in > > a bunch of other cases, and I'd like

[PATCH] D77168: Add a flag to debug automatic variable initialization

jcai19 added a comment. In D77168#1955312 , @jfb wrote: > Do you not think `pragma` is a more general approach? That's what's used in a > bunch of other cases, and I'd like to see it attempted here. Yes I absolutely agree pragma is a great way to

Re: [clang] 6f428e0 - [AST] Fix crashes on decltype(recovery-expr).

Hello Douglas, Thanks for the report. I don't think it is intentional, it is certainly a regression (I'm surprised the patch would lead to such behavior), I will take a look tomorrow. On Wed, Apr 1, 2020 at 8:28 PM Yung, Douglas via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Haojian,

[clang] c028472 - Revert "[OPENMP50]Add initial support for OpenMP 5.0 iterator."

Author: Alexey Bataev Date: 2020-04-01T14:54:45-04:00 New Revision: c028472fa1f0e20cc87cfa47d87fe0dd65fea830 URL: https://github.com/llvm/llvm-project/commit/c028472fa1f0e20cc87cfa47d87fe0dd65fea830 DIFF: https://github.com/llvm/llvm-project/commit/c028472fa1f0e20cc87cfa47d87fe0dd65fea830.diff

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76937/new/ https://reviews.llvm.org/D76937 ___ cfe-commits mailing list

[PATCH] D59321: AMDGPU: Teach toolchain to link rocm device libs

hliao added a comment. Do we have a better way to avoid adding those empty bitcode files? Comment at: clang/lib/Driver/ToolChains/AMDGPU.h:29 + struct ConditionalLibrary { +SmallString<0> On; +SmallString<0> Off; may need to add `llvm` namespace

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

yaxunl updated this revision to Diff 254262. yaxunl added a comment. fix assert message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76937/new/ https://reviews.llvm.org/D76937 Files: clang/lib/Sema/Sema.cpp clang/lib/Sema/SemaDecl.cpp

[PATCH] D77168: Add a flag to debug automatic variable initialization

rjmccall added inline comments. Comment at: clang/lib/CodeGen/CGDecl.cpp:1814 +if (StopAfter) { + static unsigned Counter = 0; + if (Counter >= StopAfter) jcai19 wrote: > rjmccall wrote: > > srhines wrote: > > > MaskRay wrote: > > > > I am a bit

[PATCH] D76937: Fix infinite recursion in deferred diagnostic emitter

yaxunl updated this revision to Diff 254261. yaxunl added a comment. Revised by John's comments. Also only check file scope variables. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76937/new/ https://reviews.llvm.org/D76937 Files: clang/lib/Sema/Sema.cpp

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

erichkeane added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + rjmccall wrote: > erichkeane wrote: > > rjmccall wrote: > > > rjmccall wrote: > > > > erichkeane wrote: > > > > > rjmccall wrote: > > > > > > The

[PATCH] D77074: [FPEnv][AArch64] Platform-specific builtin constrained FP enablement

dnsampaio added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:8486-8492 + return Builder.CreateConstrainedFPCall( + F, + {EmitScalarExpr(E->getArg(1)), EmitScalarExpr(E->getArg(2)), Ops[0]}); +} else { + Function *F =

[PATCH] D77229: [Analyzer][WIP] Avoid handling of LazyCompundVals in IteratorModeling

NoQ added a comment. The assert points out that the object under construction is already tracked and you're trying to add it twice. You don't want to add it tho, you just want to find the region. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:394 + return true; + } + erichkeane wrote: > rjmccall wrote: > > rjmccall wrote: > > > erichkeane wrote: > > > > rjmccall wrote: > > > > > The problem with having both

[PATCH] D77234: clang/AMDGPU: Stop setting old denormal subtarget features

arsenm created this revision. arsenm added a reviewer: yaxunl. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. https://reviews.llvm.org/D77234 Files: clang/lib/Basic/Targets/AMDGPU.cpp clang/lib/Basic/Targets/AMDGPU.h

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi updated this revision to Diff 254259. plotfi added a comment. Herald added a subscriber: jfb.  Clipboard gave me junk the first submit. Sorry Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77233/new/ https://reviews.llvm.org/D77233 Files:

[PATCH] D77168: Add a flag to debug automatic variable initialization

srhines added a comment. In D77168#1955312 , @jfb wrote: > Do you not think `pragma` is a more general approach? That's what's used in a > bunch of other cases, and I'd like to see it attempted here. > If not, I agree with John that just counting up

[PATCH] D76812: [X86] Add Indirect Thunk Support to X86 to mitigate Load Value Injection (LVI) [3/3]

craig.topper added inline comments. Comment at: llvm/lib/Target/X86/X86IndirectThunks.cpp:97 + void populateThunk(MachineFunction ) { +// This code mitigates LVI by replacing each indirect call/jump with a direct +// call/jump to a thunk that looks like:

[PATCH] D76932: [AIX] emit .extern and .weak directive linkage

jasonliu added a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76932/new/ https://reviews.llvm.org/D76932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

plotfi created this revision. plotfi added reviewers: compnerd, manmanren. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. plotfi edited the summary of this revision. plotfi updated this revision to Diff 254259. plotfi added a comment. Herald added a subscriber:

RE: [clang] 6f428e0 - [AST] Fix crashes on decltype(recovery-expr).

Hi Haojian, I noticed that after your change, the compiler is now giving an error when trying to create a vector of >= 1024 elements when previously it worked, and gcc has no problem with the same code. Is that intentional? I have put the details in PR45387, can you take a look? Douglas Yung

[PATCH] D77205: [X86] Add TSXLDTRK instructions.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77205/new/ https://reviews.llvm.org/D77205

  1   2   3   >