[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee added a comment. GIT_COMMITTER_NAME=Andrew Browne GIT_COMMITTER_EMAIL=brown...@google.com This would be my second commit. I will request access next time - thanks @dexonsmith! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

efriedma added a comment. That fix looks right; thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77984/new/ https://reviews.llvm.org/D77984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D77989: Allow disabling of vectorization using internal options

wmi added a comment. The patch makes the reasoning about when the internal flags will take effect much easier. One question is, with the change, the internal flags can only be used to disable loop vectorization/slp vectorization/loop interleaving, but not to enable them. Can we treat them in

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

bondhugula added a comment. In D77984#1979644 , @bondhugula wrote: > This revision has broken an MLIR test case that test conversion to LLVM IR > (test/Target/llvmir.mlir - an llvm.alloca in MLIR with its alignment > attribute set to 0 now converts into

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

bondhugula added a comment. This revision has broken MLIR test cases that test conversion to llvm IR (test/Target/llvmir.mlir - an llvm.alloca in MLIR with its alignment attribute set to 0 now converts into an LLVM IR alloca with alignment automatically set to 4 - I think the fix is trivial).

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

rjmccall added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:1892 + /// A FixedPointLiteral record + EXPR_FIXEDPOINT_LITERAL, }; Thanks! I'm sorry to be extremely picky about this, but: - Please put the comment on

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

dexonsmith added a comment. In D77621#1979183 , @browneee wrote: > @dexonsmith I am not a committer, if the last changes looks good please > submit for me. Thanks! You've had a few patches in the past, I suggest you get yourself access.

[PATCH] D57226: [Fixed Point] [AST] Add an AST serialization code for fixed-point literals.

vabridgers updated this revision to Diff 257183. vabridgers added a comment. Address comments from rjmccall Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57226/new/ https://reviews.llvm.org/D57226 Files: clang/include/clang/AST/Expr.h

[PATCH] D78075: [Clang][OpenMP] Added support for nowait target in CodeGen

tianshilei1992 created this revision. Herald added subscribers: cfe-commits, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. Previously for nowait target, CG emitted a function call to `__tgt_target_nowait`, etc. However, in OpenMP RTL, these functions just

[PATCH] D77545: Represent FP options in AST by special Expression node

rjmccall added a comment. In D77545#1977688 , @sepavloff wrote: > In D77545#1974509 , @rjmccall wrote: > > > For example, in this code: > > > > const float global = 2.22 + 3.33; > > > > #pragma STDV

[PATCH] D78068: [www] Turn 'Clang 10' boxes green in C++ status pages to reflect release

hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rsmith, aaron.ballman. Herald added a project: clang. The 'Clang 10' boxes should be green since Clang 10 has been released. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78068 Files:

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

sunfish added a comment. This addresses the review feedback from earlier. To answer this question: > I assume that all he users -Wl args come after.. so its still possible to set > --entry on the command line? Yes, that is what happens. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI

rjmccall added a comment. Thanks. Having an enum like this would also be important if we wanted to implement the Itanium rule (as in, the actual Itanium architecture, not the generic C++ ABI) that v-tables contain "inline" function descriptors rather than pointers to them. (On Itanium, a C

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

aaronpuchert added a comment. In D76038#1978667 , @mstorsjo wrote: > Ping - any update on this one? Are you waiting on @rsmith for input on where > to place a testcase? No, I just didn't get around to writing the test yet, thanks for reminding me.

[PATCH] D62922: [WebAssembly] Implement "Reactor" mode

sunfish updated this revision to Diff 257171. sunfish added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase, update, add a test, and add basic error reporting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

bendjones added a comment. Seems reasonable to me. Thanks @erik.pilkington! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78066/new/ https://reviews.llvm.org/D78066 ___ cfe-commits mailing list

[PATCH] D77903: [SVE] Remove calls to getBitWidth from clang

ctetreau updated this revision to Diff 257162. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77903/new/ https://reviews.llvm.org/D77903 Files: clang/lib/CodeGen/TargetInfo.cpp Index:

[PATCH] D78066: [SemaObjC] Forbid storing an unboxed integer literal in an NSNumber

erik.pilkington created this revision. erik.pilkington added reviewers: rjmccall, bendjones, arphaman. Herald added subscribers: ributzka, dexonsmith, jkorous. This fixes a common mistake (the 3 should be @3): `NSNumber *n = 3`. This extends an existing check for NSString. Also, this only errs

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

mattdr accepted this revision. mattdr added a comment. This revision is now accepted and ready to land. Accepting modulo some comments to be addressed. Most of my review effort was spent on the data structure and algorithm employed as well as code style and readability. I am least confident

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan updated this revision to Diff 257153. leonardchan marked an inline comment as done. leonardchan added a comment. Updated to address comments and added an RAII class for easier checking before exiting functions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:8182-8184 +// Do not check static casts here because they are checked earlier +// in Sema::ActOnCXXNamedCast() +if (!Kind.isStaticCast()) { leonardchan

[PATCH] D73052: [clang-tidy] RenamerClangTidy now renames dependent member expr when the member can be resolved

njames93 updated this revision to Diff 257151. njames93 added a comment. Clean up code and remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73052/new/ https://reviews.llvm.org/D73052 Files:

[PATCH] D77923: OpenCL: Fix some missing predefined macros

jvesely added a comment. > In D77923#1976497 , @jvesely wrote: > >> OPENCL_VERSION is something that should be really set by the opencl driver >> rather than the compiler. >> coarse-grained SVM can be done without FEATURE_FLAT_ADDRESS_SPACE, so those

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

tentzen marked 2 inline comments as done. tentzen added inline comments. Comment at: clang/lib/CodeGen/CGCleanup.cpp:848 // Build a switch-out if we need it: // - if there are branch-afters threaded through the scope rnk wrote: > Are we sure

[clang] 8c635ba - [CUDA] Fix missed CUDA version mappings.

Author: Artem Belevich Date: 2020-04-13T15:54:12-07:00 New Revision: 8c635ba4a84f8b5dbde1984fe2d7eeefaf827ffe URL: https://github.com/llvm/llvm-project/commit/8c635ba4a84f8b5dbde1984fe2d7eeefaf827ffe DIFF:

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee added a comment. I'm open to suggestions to resolve the clang tidy naming warnings. I would prefer to leave grow_pod the same, to minimize changes. @dexonsmith I am not a committer, if the last changes looks good please submit for me. Thanks! Comment at:

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 257130. browneee marked 3 inline comments as done. browneee added a comment. Rename SizeMax() to SizeTypeMax(). Fix max_size(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/

[PATCH] D76182: [AVR] Support aliases in non-zero address space

This revision was automatically updated to reflect the committed changes. Closed by commit rGcfc002714a20: [AVR] Support aliases in non-zero address space (authored by aykevl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76182/new/

[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI

leonardchan added a comment. In D77592#1979030 , @rjmccall wrote: > This is a global switch, right, not something that's mix-and-match between > hierarchies or even between classes? I think I would prefer that the ABI > object just tell us the expected

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added inline comments. Comment at: clang/docs/MatrixSupport.rst:211 + +``M __builtin_matrix_column_load(T *ptr, int row, int col, int stride)`` + fhahn wrote: > rjmccall wrote: > > This name sounds like it's loading a column, when I think you're saying

[clang] cfc0027 - [AVR] Support aliases in non-zero address space

Author: Ayke van Laethem Date: 2020-04-14T00:42:19+02:00 New Revision: cfc002714a208bdbc51fade56141a38fbba26e24 URL: https://github.com/llvm/llvm-project/commit/cfc002714a208bdbc51fade56141a38fbba26e24 DIFF:

[libunwind] 5f7a030 - [libunwind] Enable the new libc++ testing format by default

Author: Louis Dionne Date: 2020-04-13T18:17:18-04:00 New Revision: 5f7a0301628671b8f4d2c1d9ea90ee723d889a56 URL: https://github.com/llvm/llvm-project/commit/5f7a0301628671b8f4d2c1d9ea90ee723d889a56 DIFF: https://github.com/llvm/llvm-project/commit/5f7a0301628671b8f4d2c1d9ea90ee723d889a56.diff

[PATCH] D77772: [Clang] Expose RequiresNullTerminator in FileManager.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Comment at: llvm/unittests/Support/MemoryBufferTest.cpp:396 + + auto MBOrError = MemoryBuffer::getOpenFile(FD, TestPath, -1, false, true); +

LLVM buildmaster will be updated and restarted after 6PM PST today

Hello everyone, LLVM buildmaster will be updated and restarted after 6PM PST today. Thanks Galina ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D78058: option to write files to memory instead of disk

marcrasi created this revision. Herald added subscribers: cfe-commits, jfb, mgorny. Herald added a project: clang. marcrasi edited the summary of this revision. This allows clients to invoke clang without writing anything to disk. I'm not sure if this is the right design, so I'm sending this

[PATCH] D77732: [clangd] Shard preamble symbols in dynamic index

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, API quibbles. It would be nice to test this but the good things about it (memory usage) aren't easy to test, and the bad things (sensitivity to header parsing context) seem odd to

[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI

rjmccall added a comment. This is a global switch, right, not something that's mix-and-match between hierarchies or even between classes? I think I would prefer that the ABI object just tell us the expected layout of a v-table entry (as an enum) rather than forcing a bunch of different

[PATCH] D78030: [TimeProfiler] Emit clock synchronization point

MaskRay added inline comments. Comment at: lld/test/ELF/time-trace.s:21 -# CHECK: "traceEvents": [ +# CHECK: "beginningOfTime": {{[0-9]{16},}} +# CHECK-NEXT: "traceEvents": [ Add 5 spaces after `:` so that the key is aligned Repository: rG LLVM Github

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixSupport.rst:39 + +Future Work: Initialization syntax. + rjmccall wrote: > Maybe break the TODOs here into their own sections, which would come much > later. Done, I've moved the TODOs to a TODO section

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257115. fhahn marked 10 inline comments as done. fhahn added a comment. Address latest comments, thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76612/new/ https://reviews.llvm.org/D76612 Files:

[PATCH] D77923: OpenCL: Fix some missing predefined macros

b-sumner added a comment. In my opinion, for on-line compile for OpenCL, the platform is responsible for setting `__OPENCL_VERSION__`. Also, it should be the platform's choice as to how to respond the image support query and how `__IMAGE_SUPPORT__` is set. For offline compile, it doesn't

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

bendjones added a comment. In D70284#1978948 , @dexonsmith wrote: > In D70284#1752893 , @bendjones wrote: > > > In D70284#1752811 , @dexonsmith > > wrote: > > > > > For

[clang] 4d4fef2 - Revert a few unsuccessful attempts at fixing bots.

Author: Nico Weber Date: 2020-04-13T17:09:21-04:00 New Revision: 4d4fef22dac75c9a9ba3e14742dd681e6c5f935d URL: https://github.com/llvm/llvm-project/commit/4d4fef22dac75c9a9ba3e14742dd681e6c5f935d DIFF: https://github.com/llvm/llvm-project/commit/4d4fef22dac75c9a9ba3e14742dd681e6c5f935d.diff

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

This revision was automatically updated to reflect the committed changes. Closed by commit rG89e0662dee5f: Make IRBuilder automatically set alignment on load/store/alloca. (authored by efriedma). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77427: [X86] Add tests to clang Driver to ensure that SLH/Retpoline features are not enabled with LVI-CFI

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77427/new/ https://reviews.llvm.org/D77427 ___ cfe-commits mailing list

[PATCH] D70284: Constant strings emitted when `-fno-constant-cfstrings` is passed should allow dead stripping

dexonsmith added a comment. In D70284#1752893 , @bendjones wrote: > In D70284#1752811 , @dexonsmith > wrote: > > > For some reason this revision is locked down and I'm not allowed to "edit" > > it, which includes

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru updated this revision to Diff 257105. sylvestre.ledru added a comment. Doing it by hand. @alexfh please let me know if you would be ok with it (I will do it by hand) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/

[clang] 89e0662 - Make IRBuilder automatically set alignment on load/store/alloca.

Author: Eli Friedman Date: 2020-04-13T13:43:14-07:00 New Revision: 89e0662dee5fa541f284e6be0af9e36e7f39f947 URL: https://github.com/llvm/llvm-project/commit/89e0662dee5fa541f284e6be0af9e36e7f39f947 DIFF: https://github.com/llvm/llvm-project/commit/89e0662dee5fa541f284e6be0af9e36e7f39f947.diff

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

rsmith marked 2 inline comments as done. rsmith added a comment. In D77962#1978668 , @rnk wrote: > This code is very string-y. Should clang be parsing uuids into > u32-u16-u16-u8[8] earlier, so that we can get the semantic form directly from > the

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. Thanks for your patience, I missed the updates on Friday. I have a couple of optional comments inline that I don't feel strongly about. LGTM either way. In D77621#1972764

[PATCH] D77847: [clangd] Rebuild dependent files when a header is saved.

This revision was automatically updated to reflect the committed changes. Closed by commit rG596b63ad4019: [clangd] Rebuild dependent files when a header is saved. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77847?vs=256756=257097#toc Repository: rG LLVM

[PATCH] D77836: [Attribute] Fix noderef attribute false-negatives

leonardchan marked 3 inline comments as done. leonardchan added inline comments. Comment at: clang/lib/Sema/SemaCast.cpp:264 + CheckNoderef(*this, E->getType(), TInfo->getType(), OpLoc); + rsmith wrote: > Warning on this seems reasonable for `static_cast` and

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: alexfh. Herald added a project: clang. As discussed here: https://reviews.llvm.org/D77983 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78052 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77984/new/ https://reviews.llvm.org/D77984

[PATCH] D77592: [NFC}[CodeGen] Make VTable initialization a method of CGCXXABI

leonardchan added a comment. In D77592#1975629 , @rjmccall wrote: > This is a weird point to allow further ABI customization of. I understand > why you want to customize this, but I wonder if it's actually worthwhile to > make a `virtual` function for

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, jfb, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov. Herald added a project: clang. sammccall updated this revision to Diff 257083. sammccall added a comment. format

[PATCH] D78048: [clangd] Add tests that no-op changes are cheap

sammccall updated this revision to Diff 257083. sammccall added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78048/new/ https://reviews.llvm.org/D78048 Files: clang-tools-extra/clangd/ClangdServer.cpp

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added inline comments. Comment at: clang/lib/Analysis/BodyFarm.cpp:120 +VK_RValue, OK_Ordinary, SourceLocation(), +FPOptions::defaultWithoutTrailingStorage(C)); } mibintc wrote: > rjmccall

[clang-tools-extra] eac5672 - Fix target_info.test on Windows with a hack

Author: Reid Kleckner Date: 2020-04-13T13:14:06-07:00 New Revision: eac56724fd955af0f8521557cacc57a83f371649 URL: https://github.com/llvm/llvm-project/commit/eac56724fd955af0f8521557cacc57a83f371649 DIFF: https://github.com/llvm/llvm-project/commit/eac56724fd955af0f8521557cacc57a83f371649.diff

[clang-tools-extra] 596b63a - [clangd] Rebuild dependent files when a header is saved.

Author: Sam McCall Date: 2020-04-13T22:08:15+02:00 New Revision: 596b63ad4019e61030803789a1844a0f1aeb34db URL: https://github.com/llvm/llvm-project/commit/596b63ad4019e61030803789a1844a0f1aeb34db DIFF: https://github.com/llvm/llvm-project/commit/596b63ad4019e61030803789a1844a0f1aeb34db.diff

[clang] f22fbe3 - Clean up usages of asserting vector getters in Type

Author: Christopher Tetreault Date: 2020-04-13T13:01:40-07:00 New Revision: f22fbe3a152ed1e7712c6580405cb28db00187a5 URL: https://github.com/llvm/llvm-project/commit/f22fbe3a152ed1e7712c6580405cb28db00187a5 DIFF:

[PATCH] D77257: Clean up usages of asserting vector getters in Type

This revision was automatically updated to reflect the committed changes. Closed by commit rGf22fbe3a152e: Clean up usages of asserting vector getters in Type (authored by ctetreau). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77257/new/

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

rnk added a comment. Thanks for looking into this. This code is very string-y. Should clang be parsing uuids into u32-u16-u16-u8[8] earlier, so that we can get the semantic form directly from the UuidAttr? Based on the test cases you had to pass, is there any reason that would be difficult?

[PATCH] D76038: PR45000: Use Sema::SetParamDefaultArgument in TransformLambdaExpr

mstorsjo added a comment. Ping - any update on this one? Are you waiting on @rsmith for input on where to place a testcase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76038/new/ https://reviews.llvm.org/D76038

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

kadircet added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:2749 +// most useful answer is "yes, this file has a header guard". +if (!ConditionalStack.empty()) + MIOpt.ExitTopLevelConditional(); I think we should put this behind a PPOpt to

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

rjmccall added a comment. Reading through the rest of the spec. Comment at: clang/docs/LanguageExtensions.rst:500 +Clang provides a matrix extension, which is currently being implemented. See +:ref:`matrixsupport` for more details. + rjmccall wrote: > This

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

efriedma updated this revision to Diff 257063. efriedma added a comment. Actually address all the review comments. Fix CreateAlloca to use the pref alignment instead of the ABI alignment, like instcombine and selectiondag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D78033: [cmake] Restrict symbols exported from libclang-cpp

beanz added a comment. I think this has some unintended consequences. If your tool wants to use libLLVM and libClang you really need libClang to be linked against libLLVM, otherwise you're actually just hiding the problem. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

rnk added a comment. I like the implementation strategy, but I have one corner case, which is probably worth a test. Comment at: clang/lib/CodeGen/CGCleanup.cpp:848 // Build a switch-out if we need it: // - if there are branch-afters threaded through the

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

efriedma planned changes to this revision. efriedma added a comment. Err, didn't quite address all the review comments. New version soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77984/new/ https://reviews.llvm.org/D77984

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal updated this revision to Diff 257060. vingeldal added a comment. Ran automatic formatting on the patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461 Files:

[PATCH] D77984: Make IRBuilder automatically set alignment on load/store/alloca.

efriedma updated this revision to Diff 257059. efriedma added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77984/new/ https://reviews.llvm.org/D77984 Files: clang/test/CodeGen/arm_neon_intrinsics.c

[PATCH] D77461: [WIP][clang-tidy] Remove false positive in AvoidNonConstGlobalVariables

vingeldal updated this revision to Diff 257058. vingeldal added a comment. Modified the check to not report static variables in function scope. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77461/new/ https://reviews.llvm.org/D77461 Files:

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

dblaikie added a comment. Looks good to me at this point (I have some vague quandries about whether the report_fatal_error stuff could be improved/made more clear, but couldn't come up with an actionable suggestion so far) - @dexonsmith could you check this over and offer final approval?

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc marked 3 inline comments as done. mibintc added a comment. Adding an inline reply for John. rebased the patch, also re-applied clang-format. What do you think? Comment at: clang/lib/Analysis/BodyFarm.cpp:120 +VK_RValue, OK_Ordinary,

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

mibintc updated this revision to Diff 257055. mibintc added a comment. Responded to @rjmccall 's review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76384/new/ https://reviews.llvm.org/D76384 Files: clang/include/clang/AST/Expr.h

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm closed this revision. arsenm added a comment. dc89a3efb43feedec04facfa2206de011d2606e7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019

[PATCH] D77621: ADT: SmallVector size & capacity use word-size integers when elements are small.

browneee updated this revision to Diff 257044. browneee added a comment. Changed SizeMax to static constexpr function. Changed static asserts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77621/new/ https://reviews.llvm.org/D77621 Files:

[PATCH] D77954: [CUDA][HIP] Fix host/device based overload resolution

tra added a comment. LGTM in principle. That said, my gut feeling is that this patch has a good chance of breaking something in sufficiently convoluted CUDA code like Eigen. When you land this patch, I'd appreciate if you could do it on a workday morning (Pacific time) so I'm around to test it

[PATCH] D78019: HIP: Fix handling of denormal mode

arsenm added a comment. In D78019#1978216 , @tra wrote: > LGTM. The patch appears to be an NFC one for CUDA. CUDA currently isn't changing the default FTZ mode based on the subtarget, which differs from nvcc according to the documentation CHANGES

[PATCH] D77918: [OpenMP] Avoid crash in preparation for diagnose of unsupported type

JonChesterfield accepted this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77918/new/ https://reviews.llvm.org/D77918

[clang] dc89a3e - HIP: Fix handling of denormal mode

Author: Matt Arsenault Date: 2020-04-13T11:48:45-07:00 New Revision: dc89a3efb43feedec04facfa2206de011d2606e7 URL: https://github.com/llvm/llvm-project/commit/dc89a3efb43feedec04facfa2206de011d2606e7 DIFF:

Re: [clang] 246398e - [clang][Parse] properly parse asm-qualifiers, asm inline

On Sun, Apr 12, 2020 at 3:45 PM Joerg Sonnenberger wrote: > > On Thu, Mar 12, 2020 at 03:25:49PM -0700, Nick Desaulniers via cfe-commits > wrote: > > > > Author: Nick Desaulniers > > Date: 2020-03-12T15:13:59-07:00 > > New Revision: 246398ece7115b57a02dbe7876d86ae8e72406ef > > > > URL: > >

[PATCH] D77683: [Docs] Make code review policy clearer about requested pre-commit reviews

dblaikie added a comment. In D77683#1978070 , @hfinkel wrote: > In D77683#1973762 , @dblaikie wrote: > > > In D77683#1973757 , @jdoerfert > > wrote: > > > > > In

[PATCH] D77923: OpenCL: Fix some missing predefined macros

scott.linder added a comment. In D77923#1978261 , @arsenm wrote: > In D77923#1978172 , @scott.linder > wrote: > > > https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/preprocessorDirectives.html > >

[PATCH] D78019: HIP: Fix handling of denormal mode

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 ___ cfe-commits mailing list

[PATCH] D74387: [SYCL] Defer __float128 type usage diagnostics

Fznamznon added a comment. In D74387#1974981 , @jdoerfert wrote: > As I mentioned before. As long as the type is not "used" you can treat it as > a sequence of bytes just as well. So we can lower `__float128` to `char [16]` > with the right alignment.

[PATCH] D77947: [clangd] Send the correct error code when cancelling requests.

This revision was automatically updated to reflect the committed changes. Closed by commit rG31db1e0bd1ea: [clangd] Send the correct error code when cancelling requests. (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D77947?vs=256777=257031#toc Repository: rG

[PATCH] D77923: OpenCL: Fix some missing predefined macros

arsenm added a comment. In D77923#1978172 , @scott.linder wrote: > https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/preprocessorDirectives.html > describes `__OPENCL_VERSION__` as "an integer reflecting the version number > of the OpenCL

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn added inline comments. Comment at: clang/docs/MatrixSupport.rst:3 +Matrix Support +== + rjmccall wrote: > This extension should be called something like "Matrices" or "Matrix Types". > The "X Support" name makes it sound like it's a

[PATCH] D76612: [Matrix] Add draft specification for matrix support in Clang.

fhahn updated this revision to Diff 257025. fhahn marked 15 inline comments as done. fhahn added a comment. Address @rjmccall comments. In D76612#1975719 , @rjmccall wrote: > Scanned through the first bit. Thanks a lot! I hope I managed to address the

[PATCH] D77947: [clangd] Send the correct error code when cancelling requests.

sammccall marked an inline comment as done. sammccall added inline comments. Comment at: clang-tools-extra/clangd/JSONTransport.cpp:28 + [&](const CancelledError ) -> llvm::Error { +switch (C.Reason) { + case

[PATCH] D78019: HIP: Fix handling of denormal mode

tra added a comment. LGTM. The patch appears to be an NFC one for CUDA. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78019/new/ https://reviews.llvm.org/D78019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D76384: Move FPFeatures from BinaryOperator bitfields to Trailing storage

rjmccall added a comment. Thanks. Just a bunch of fairly minor requests now. Comment at: clang/include/clang/AST/Expr.h:3474 + size_t offsetOfTrailingStorage() const; + size_t offsetOfTrailingStorage(); + You don't need the non-const overload.

[PATCH] D77936: [Windows SEH] Fix abnormal-exits in _try

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77936/new/ https://reviews.llvm.org/D77936

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This should probably be untangled into 3 separate patches, but looking for feedback first on whether we want to do this at all. a) store

[PATCH] D77923: OpenCL: Fix some missing predefined macros

scott.linder added a comment. https://www.khronos.org/registry/OpenCL/sdk/2.0/docs/man/xhtml/preprocessorDirectives.html describes `__OPENCL_VERSION__` as "an integer reflecting the version number of the OpenCL supported by the OpenCL device." as contrasted with `__OPENCL_C_VERSION__` which is

[PATCH] D77859: Revert "[DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff."

bondhugula abandoned this revision. bondhugula added a comment. Another revision performed this revert. Dropping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77859/new/ https://reviews.llvm.org/D77859

[PATCH] D77962: PR38490: Support reading values out of __uuidof(X) expressions during constant evaluation.

aeubanks added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:3949 + // Special-case reading from __uuidof expressions so we don't have to + // construct an APValue for the whole uuid. + if (LVal.Designator.isOnePastTheEnd()) { For my

[PATCH] D76182: [AVR] Support aliases in non-zero address space

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76182/new/ https://reviews.llvm.org/D76182

  1   2   >