[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

This revision was automatically updated to reflect the committed changes. Closed by commit rG2368bf52cd77: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm (authored by lei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. > The declaration subprograms are in the retained types list - but when > retained types are emitted, only types in the retained types list are used, > the subprograms (and the types they only indirectly reference) are ignored. So adding the subprogram nodes to retained

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn added inline comments. Comment at: clang/include/clang/AST/Expr.h:2648 +/// MatrixSubscriptExpr - Matrix subscript expression for the MatrixType +/// extension. +class MatrixSubscriptExpr : public Expr { rjmccall wrote: > fhahn wrote: > > rjmccall wrote: >

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

aprantl added a comment. One way to make the tests more robust is capture the output in a `%t.ll` file and do repeated `RUN: cat %t.ll | FileCheck --check-prefix=TYPE1` lines. Anyway, oif the output is just reshuffled, this should be all fine. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

dblaikie added a comment. In D80369#2057077 , @djtodoro wrote: > >> @dblaikie wrote: > > > > ... At least for the C++ test, this change makes it pass: > > > > diff --git clang/test/Modules/ModuleDebugInfo.cpp > > clang/test/Modules/ModuleDebugInfo.cpp

[clang] 2368bf5 - [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

Author: Lei Huang Date: 2020-05-27T13:14:25-05:00 New Revision: 2368bf52cd7725a34f09f4b27a9c205cda06f478 URL: https://github.com/llvm/llvm-project/commit/2368bf52cd7725a34f09f4b27a9c205cda06f478 DIFF: https://github.com/llvm/llvm-project/commit/2368bf52cd7725a34f09f4b27a9c205cda06f478.diff LOG

[clang] b9c6871 - [Driver] Support -fsanitize=shadow-call-stack and cfi-icall on aarch64_be

Author: Fangrui Song Date: 2020-05-27T10:55:05-07:00 New Revision: b9c6871a9570975827dc0bbeb39131c99c8daf8e URL: https://github.com/llvm/llvm-project/commit/b9c6871a9570975827dc0bbeb39131c99c8daf8e DIFF: https://github.com/llvm/llvm-project/commit/b9c6871a9570975827dc0bbeb39131c99c8daf8e.diff

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

fhahn updated this revision to Diff 266602. fhahn marked 10 inline comments as done. fhahn added a comment. Addressed latest round of comments, thanks! Changes include: - OK_MatrixComponent now behaves like OK_VectorComponent with respect to taking address/reference. - Look through non-overload

[PATCH] D80647: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2a3e9f0a6e9: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D80647?vs=266594&id=266601#toc Repository: rG LLVM G

[PATCH] D75044: [AArch64] __builtin_return_address for PAuth.

danielkiss updated this revision to Diff 266595. danielkiss marked an inline comment as done. danielkiss retitled this revision from "[AArch64] __builtin_extract_return_addr for PAuth." to "[AArch64] __builtin_return_address for PAuth.". danielkiss edited the summary of this revision. danielkiss

[PATCH] D80472: [clangd] Add access specifier information to hover contents

This revision was automatically updated to reflect the committed changes. Closed by commit rG6407aa9d2e0e: [clangd] Add access specifier information to hover contents (authored by danielmartin, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D80647: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be

pcc accepted this revision. pcc added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80647/new/ https://reviews.llvm.org/D80647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D80647: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. thanks for the quick fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80647/new/ https://reviews.llvm.org/D80647 _

[PATCH] D44801: Add the -fsanitize=shadow-call-stack flag

MaskRay added inline comments. Herald added a subscriber: arphaman. Comment at: cfe/trunk/test/Driver/sanitizer-ld.c:563 +// RUN: | FileCheck --check-prefix=CHECK-SHADOWCALLSTACK-LINUX-X86-64 %s +// CHECK-SHADOWCALLSTACK-LINUX-X86-64-NOT: error: + sanitizer-ld.

[PATCH] D80647: [Driver] Support -fsanitize=shadow-call-stack on aarch64_be

MaskRay created this revision. MaskRay added reviewers: nickdesaulniers, kcc, pcc. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to lan

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers added a comment. Bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] a2a3e9f - [Driver] Support -fsanitize=shadow-call-stack on aarch64_be

Author: Fangrui Song Date: 2020-05-27T10:37:39-07:00 New Revision: a2a3e9f0a6e91103a0d1fa73086dbdf109c48f69 URL: https://github.com/llvm/llvm-project/commit/a2a3e9f0a6e91103a0d1fa73086dbdf109c48f69 DIFF: https://github.com/llvm/llvm-project/commit/a2a3e9f0a6e91103a0d1fa73086dbdf109c48f69.diff

[clang-tools-extra] 6407aa9 - [clangd] Add access specifier information to hover contents

Author: Daniel Martín Date: 2020-05-27T19:36:46+02:00 New Revision: 6407aa9d2e0e225bc81d3b2602d6e6ed79912ec2 URL: https://github.com/llvm/llvm-project/commit/6407aa9d2e0e225bc81d3b2602d6e6ed79912ec2 DIFF: https://github.com/llvm/llvm-project/commit/6407aa9d2e0e225bc81d3b2602d6e6ed79912ec2.diff

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked an inline comment as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459-469 +if (Origin.From().isMinSignedValue()) { + // If mini is a minimal signed value, absolute value of it is greater +

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 266586. vsavchenko added a comment. Fix code review remarks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintMan

[PATCH] D79400: [CMAKE] Fix build failure when source directory is read only

scott.linder added inline comments. Comment at: llvm/cmake/modules/AddLLVM.cmake:1945 + if (NOT touch_head_result EQUAL 0) +return() + endif() This seems to implement the behavior that when the log is not present and is not writable

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

SjoerdMeijer added a comment. No objections. Some nits inlined, which you can ignore if you think they are not correct. Comment at: clang/include/clang/Basic/arm_neon_incl.td:218 // d: double +// b: bfloat // nit: perhaps bfloat16? Comment

[PATCH] D80222: Replace Clang's createRuntimeFunction with the definitions in OMPKinds.def

jhuber6 marked an inline comment as done. jhuber6 added inline comments. Comment at: openmp/runtime/test/tasking/kmp_taskloop.c:100 th_counter[i] = 0; -#pragma omp parallel num_threads(N) +#pragma omp parallel // num_threads(N) { jhuber6 wro

[PATCH] D79232: [analyzer] Refactor range inference for symbolic expressions

vsavchenko updated this revision to Diff 266571. vsavchenko added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79232/new/ https://reviews.llvm.org/D79232 Files: clang/include/clang/StaticAnalyzer/Core/PathSensitive/RangedCons

[PATCH] D80417: Fix Darwin 'constinit thread_local' variables.

This revision was automatically updated to reflect the committed changes. jyknight marked an inline comment as done. Closed by commit rGaca3d067efe1: Fix Darwin 'constinit thread_local' variables. (authored by jyknight). Changed prior to commit: https://reviews.llvm.org/D80417?vs=265642&id=2665

[PATCH] D80404: [OPENMP50]Initial support for use_device_addr clause.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa888fc6b3412: [OPENMP50]Initial support for use_device_addr clause. (authored by ABataev). Changed prior to commit: https://reviews.llvm.org/D80404?vs=266076&id=266568#toc Repository: rG LLVM Github

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko marked 5 inline comments as done. vsavchenko added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:459-469 +if (Origin.From().isMinSignedValue()) { + // If mini is a minimal signed value, absolute value of it is greater +

[PATCH] D80492: Avoid linking libdl unless needed

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. looks reasonable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80492/new/ https://reviews.llvm.org/D80492 _

[PATCH] D79708: [clang][BFloat] add NEON emitter for bfloat

fpetrogalli accepted this revision. fpetrogalli added a comment. This revision is now accepted and ready to land. LGTM! Might be worth waiting an extra day or two before submitting to make sure the people who provided extra feedback are happy. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] aca3d06 - Fix Darwin 'constinit thread_local' variables.

Author: James Y Knight Date: 2020-05-27T11:59:30-04:00 New Revision: aca3d067efe194539efd1e0fcf03820a2c377753 URL: https://github.com/llvm/llvm-project/commit/aca3d067efe194539efd1e0fcf03820a2c377753 DIFF: https://github.com/llvm/llvm-project/commit/aca3d067efe194539efd1e0fcf03820a2c377753.diff

[clang] a888fc6 - [OPENMP50]Initial support for use_device_addr clause.

Author: Alexey Bataev Date: 2020-05-27T11:35:31-04:00 New Revision: a888fc6b3412574f5869a8680acf4ed2bed1d2a2 URL: https://github.com/llvm/llvm-project/commit/a888fc6b3412574f5869a8680acf4ed2bed1d2a2 DIFF: https://github.com/llvm/llvm-project/commit/a888fc6b3412574f5869a8680acf4ed2bed1d2a2.diff

[PATCH] D80624: Add support for UnaryOperator in SyntaxTree

This revision was automatically updated to reflect the committed changes. Closed by commit rG461af57de781: Add support for UnaryOperator in SyntaxTree (authored by eduucaldas, committed by gribozavr). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D806

[PATCH] D80117: [analyzer] Introduce reasoning about symbolic remainder operator

vsavchenko updated this revision to Diff 266551. vsavchenko added a comment. Move 0 % x case to SValBuilder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80117/new/ https://reviews.llvm.org/D80117 Files: clang/lib/StaticAnalyzer/Core/RangeConstr

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

sammccall added a comment. Thanks for putting this together! As mentioned on the cfe-dev thread, for our out-of-tree checks we're planning to wrap with traverse() instead, to capture the full matcher logic more locally at the cost of some readability. So if this won't be used for in-tree checks,

[clang] 461af57 - Add support for UnaryOperator in SyntaxTree

Author: Eduardo Caldas Date: 2020-05-27T17:12:46+02:00 New Revision: 461af57de78155ee5d1dc1969b81dd019d228538 URL: https://github.com/llvm/llvm-project/commit/461af57de78155ee5d1dc1969b81dd019d228538 DIFF: https://github.com/llvm/llvm-project/commit/461af57de78155ee5d1dc1969b81dd019d228538.diff

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 266548. lei added a comment. fix up rebase issue after revert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Tar

[PATCH] D80472: [clangd] Add access specifier information to hover contents

danielmartin updated this revision to Diff 266540. danielmartin added a comment. Rebase and squash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80472/new/ https://reviews.llvm.org/D80472 Files: clang-tools-extra/clang-doc/Generators.cpp clang

[clang] b5b0087 - SpecialCaseList.h - reduce unnecessary includes to forward declarations. NFC.

Author: Simon Pilgrim Date: 2020-05-27T15:51:03+01:00 New Revision: b5b00877221ec7817b9de9cd65571e1c05e80145 URL: https://github.com/llvm/llvm-project/commit/b5b00877221ec7817b9de9cd65571e1c05e80145 DIFF: https://github.com/llvm/llvm-project/commit/b5b00877221ec7817b9de9cd65571e1c05e80145.diff

[clang] 559845f - Revert "[PowerPC] Add support for -mcpu=pwr10 in both clang and llvm"

Author: Lei Huang Date: 2020-05-27T09:40:21-05:00 New Revision: 559845f8fe53fabb22f9a392e8d34761df250c72 URL: https://github.com/llvm/llvm-project/commit/559845f8fe53fabb22f9a392e8d34761df250c72 DIFF: https://github.com/llvm/llvm-project/commit/559845f8fe53fabb22f9a392e8d34761df250c72.diff LOG

[PATCH] D80020: [PowerPC] Add support for -mcpu=pwr10 in both clang and llvm

lei updated this revision to Diff 266533. lei added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80020/new/ https://reviews.llvm.org/D80020 Files: clang/lib/Basic/Targets/PPC.cpp clang/lib/Basic/Targets/PPC.h Index: clang

[PATCH] D80631: [clang-tidy] RenamerClangTidyChecks ignore builtin and command line macros

njames93 created this revision. njames93 added reviewers: aaron.ballman, alexfh, gribozavr2, hokein. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Fixes readability-identifier-naming option MacroDefinitionCase should ignore macros passed as parameters.

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266521. vsavchenko added a comment. Fix SATestBuild call to CmpRuns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py clang/

[PATCH] D80517: [analyzer] CmpRuns.py: Refactor and add type annotations

vsavchenko updated this revision to Diff 266520. vsavchenko added a comment. Fix SATestBuild call to CmpRuns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80517/new/ https://reviews.llvm.org/D80517 Files: clang/utils/analyzer/CmpRuns.py clang/

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Sounds great! I'm still in favor of at least some lit tests for these scripts. It should be as simple as adding a tiny lit substitution

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

vsavchenko updated this revision to Diff 266518. vsavchenko added a comment. Fix global issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80626/new/ https://reviews.llvm.org/D80626 Files: clang/utils/analyzer/SATestBuild.py Index: clang/util

[PATCH] D80626: [analyzer] SATestBuild.py: Make verbosity level a cmd option

vsavchenko created this revision. vsavchenko added reviewers: NoQ, dcoughlin. Herald added subscribers: cfe-commits, ASDenysPetrov, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. Repository: rG LLVM Git

[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

ymandel added a comment. In D80606#2057136 , @steveire wrote: > It might make sense for now (in order to unblock you) to make the > `Transformer` library explicitly require the `AsIs` mode. I am not so > familiar with the transformer library, but I think

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

ymandel added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7018 +AST_MATCHER_P(clang::ParmVarDecl, isAtPosition, unsigned, N) { + return parmVarDecl(hasAncestor(functionDecl( + hasParameter(N, parmVarDecl().bind("this_decl"))

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff marked 4 inline comments as done. sepavloff added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3772 +C.setPostCallback([=](const Command &Cmd, int Res) { + const llvm::sys::ProcessStatistics &ProcStat = Cmd.getProcessStatistics(); + if (ProcSt

[PATCH] D78903: [Driver] Add option -fproc-stat-report

sepavloff updated this revision to Diff 266506. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78903/new/ https://reviews.llvm.org/D78903 Files: clang/docs/UsersManual.rst clang/include/clang/Driver/Job.

[PATCH] D80623: WIP: Add an API to simplify setting TraversalKind in clang-tidy matchers

steveire created this revision. steveire added a reviewer: sammccall. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D80623 Files: clang/include/clang/ASTMatchers/ASTMatchFinder.h clang/lib/ASTMatchers/AST

[PATCH] D80606: [libTooling][NFC] Demo bug introduced in D72534.

steveire added a comment. It might make sense for now (in order to unblock you) to make the `Transformer` library explicitly require the `AsIs` mode. I am not so familiar with the transformer library, but I think you can do that by adding `traverse(AsIs, ...)` in `Transformer::registerMatchers`

[PATCH] D79721: [Clang][AArch64] Capturing proper pointer alignment for Neon vld1 intrinsicts

pratlucas updated this revision to Diff 266504. pratlucas added a comment. Hi @efriedma and @plotf, Thank you the reduced test and for reverting the original patch. I've updated it to avoid the issue while still capturing the proper argument alignment. Do you mind taking a look before a reland i

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

0x8000- added a comment. @MyDeveloperDay +1 from the trenches - I am in that same position and it took a lot of work to get the organization to _align_ on a consistent style, then enforce that. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69764/new/ https://reviews.llvm.org/D6976

[PATCH] D80624: Add support for UnaryOperator in SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas added a reviewer: gribozavr2. gribozavr2 accepted this revision. This revision is now accepted and ready to land. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D806

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

Szelethus accepted this revision. Szelethus added a comment. This revision is now accepted and ready to land. LGTM! This patch is great! I think you're doing a great job with this project. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:670 - State = State->s

[PATCH] D80369: [DebugInfo][CallSites] Remove decl subprograms from 'retainedTypes:'

djtodoro added a comment. >> @dblaikie wrote: > > ... At least for the C++ test, this change makes it pass: > > diff --git clang/test/Modules/ModuleDebugInfo.cpp > clang/test/Modules/ModuleDebugInfo.cpp > index 26369c89605..b1ffe27ec22 100644 > --- clang/test/Modules/ModuleDebugInfo.cpp >

[clang] 63f927b - Update release notes with porting guide for AST Matchers

Author: Stephen Kelly Date: 2020-05-27T13:21:06+01:00 New Revision: 63f927b17a1ce18cb922c441ffc0691a71d550b8 URL: https://github.com/llvm/llvm-project/commit/63f927b17a1ce18cb922c441ffc0691a71d550b8 DIFF: https://github.com/llvm/llvm-project/commit/63f927b17a1ce18cb922c441ffc0691a71d550b8.diff

[PATCH] D77061: [analyzer] Add core.CallAndMessage to StdCLibraryFunctionArgsChecker's dependency

Szelethus added a comment. Ugh, its a shame we never added a test case for this. Do you remember actually why we needed this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77061/new/ https://reviews.llvm.org/D77061 _

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 marked 2 inline comments as done. gamesh411 added a comment. The remaining documentation and test changes are also underway. Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:227 +/// Identifier. +virtual LoadResultTy load(StringRef Identifier) =

[PATCH] D80603: add isAtPosition narrowing matcher for parmVarDecl

aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. Does the `hasParameter()` matcher not already do this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80603/new/ https://reviews.llvm.org/D80603 ___

[PATCH] D80522: [Analyzer] [NFC] Parameter Regions -- Alternative Approach

balazske added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:917 assert(isa(sReg) || isa(sReg) || isa(sReg) || isa(sReg)); } This assert should not be duplicated. It has the place in `VarRegion

[PATCH] D75665: [analyzer] On-demand parsing capability for CTU

gamesh411 updated this revision to Diff 266473. gamesh411 marked 29 inline comments as done. gamesh411 added a comment. Update functional changes, documentation update incoming Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75665/new/ https://review

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, ---

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

balazske marked an inline comment as done. balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:670 - State = State->set(StreamSym, StreamState::getOpened(Desc)); + // FilePositionIndeterminate is not cleared. + State = State->set(

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, ---

[PATCH] D69000: [clang-tidy] new check: modernize-deprecated-iterator-base

njames93 added a comment. First of all I'd definitely wait until a patch to include ASTMatcher support for CXXBaseSpecifier lands before progressing with this. Secondly this issue should be warned on by clang when compiling with c++17 with some stdlib support, libc++ should mark iterator as dep

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay updated this revision to Diff 266460. MyDeveloperDay added a comment. Fix crash whilst rechecking polly ../polly/lib/Analysis/ScopBuilder.cpp:74:8: warning: code should be clang-format ted [-Wclang-format-violations] static int const MaxDimensionsInAccessRange = 9;

[PATCH] D76791: [Matrix] Implement matrix index expressions ([][]).

rjmccall added inline comments. Comment at: clang/include/clang/AST/Expr.h:2648 +/// MatrixSubscriptExpr - Matrix subscript expression for the MatrixType +/// extension. +class MatrixSubscriptExpr : public Expr { fhahn wrote: > rjmccall wrote: > > Oh, that's inte

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

Szelethus added a comment. LGTM, I just have one question in the inlines. Comment at: clang/lib/StaticAnalyzer/Checkers/StreamChecker.cpp:111-114 +assert((!ES.isFEof() || !IsFilePositionIndeterminate) && + "FilePositionIndeterminate should be false in FEof case.")

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

MyDeveloperDay added a comment. In D50078#2055609 , @Typz wrote: > In D50078#2055227 , @srj wrote: > > > > And I also think it should be on by default instead of modifying many > > > .clang-format files. So IMHO if

[PATCH] D79411: [VE] Clang toolchain for VE

simoll added a comment. Leaving a note: https://reviews.llvm.org/D79084 depends on this patch to build compiler-rt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79411/new/ https://reviews.llvm.org/D79411 ___

[PATCH] D80016: [analyzer] StdLibraryFunctionsChecker: Add support to lookup types

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:747 + : *FilePtrTy) +: None; + martong wrote: > balazske wrote: > > The `Optional` can be left out from the right

[PATCH] D80366: [Analyzer] Add `getReturnValueUnderConstruction()` to `CallEvent`

baloghadamsoftware marked an inline comment as done. baloghadamsoftware added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:112 +Optional ExprEngine::retrieveFromConstructionContext( +ProgramStateRef State, const LocationContext *LCtx, ---

[PATCH] D80472: [clangd] Add access specifier information to hover contents

kadircet added a comment. thanks a lot, looks like you've only uploaded the diff for your latest changes(e.g. changes to clang-doc are gone). you need to squash them and upload a single diff based at master. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

This revision was automatically updated to reflect the committed changes. Closed by commit rG602d9b0afc77: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1 (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. @rsmith, firstly let me thank you for taking the time to review this, I didn't realize i'd invoke such a reaction that the big guns would start showing up.. fundamentally I agree with you, but let me defend my thesi

[PATCH] D79852: [libunwind] Fix wrong endianness check in Unwind-EHABI

speidy accepted this revision. speidy added a comment. Can you merge? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79852/new/ https://reviews.llvm.org/D79852 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D50078: clang-format: support aligned nested conditionals formatting

klimek added a comment. For the policy question: clang-format does intentionally not try to be stable - the "how to" suggestion for clang-format has always been to format changes lines and live with divergence (divergence from people manually formatting things is larger). Repository: rG LLV

[clang] 602d9b0 - [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

Author: Saiyedul Islam Date: 2020-05-27T07:51:27Z New Revision: 602d9b0afc77828f419869289b159a567c62ae81 URL: https://github.com/llvm/llvm-project/commit/602d9b0afc77828f419869289b159a567c62ae81 DIFF: https://github.com/llvm/llvm-project/commit/602d9b0afc77828f419869289b159a567c62ae81.diff LOG

[PATCH] D79961: [PGO] Fix computation of fuction Hash

This revision was automatically updated to reflect the committed changes. Closed by commit rGde02a75e3984: [PGO] Fix computation of function Hash (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D79961?vs=266188&id=266441#toc Repository: rG LLVM Github Monor

[PATCH] D79754: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 1

sameerds accepted this revision. sameerds added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79754/new/ https://reviews.llvm.org/D79754 __

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk updated this revision to Diff 266438. kwk marked an inline comment as done. kwk added a comment. - fix link in doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 Files: clang-tools-extra/clang-tidy/m

[PATCH] D80018: [Analyzer][StreamChecker] Added check for "indeterminate file position".

balazske updated this revision to Diff 266440. balazske marked 2 inline comments as done. balazske added a comment. - Fixed a bug in previous update - Added new tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80018/new/ https://reviews.llvm.org

[PATCH] D80531: [clang-tidy]: Added modernize-replace-disallow-copy-and-assign-macro

kwk added a comment. @Eugene.Zelenko thank you for your patience with me. I fixed the link. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80531/new/ https://reviews.llvm.org/D80531 ___ cfe-commits mail

[clang] de02a75 - [PGO] Fix computation of function Hash

Author: serge-sans-paille Date: 2020-05-27T09:15:21+02:00 New Revision: de02a75e398415bad4df27b4547c25b896c8bf3b URL: https://github.com/llvm/llvm-project/commit/de02a75e398415bad4df27b4547c25b896c8bf3b DIFF: https://github.com/llvm/llvm-project/commit/de02a75e398415bad4df27b4547c25b896c8bf3b.d

<    1   2