[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

2020-06-14 Thread Ahsan Saghir via Phabricator via cfe-commits
saghir created this revision. saghir added reviewers: PowerPC, hfinkel. saghir added projects: LLVM, PowerPC. Herald added subscribers: cfe-commits, shchenz, nemanjai. Herald added a project: clang. saghir added a parent revision: D80758: [PowerPC] Add -m[no-]power10-vector clang and llvm option.

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

2020-06-14 Thread JunMa via Phabricator via cfe-commits
junparser added a comment. @rnk @aaron.ballman any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81543/new/ https://reviews.llvm.org/D81543 ___ cfe-commits mailing list

[PATCH] D81420: Fix size for _ExtInt types with builtins

2020-06-14 Thread Mott, Jeffrey T via Phabricator via cfe-commits
jtmott-intel added a comment. I don't have commit access. For whoever performs the commit, here's a (draft) commit message: [clang] Fix or emit diagnostic for checked arithmetic builtins with _ExtInt types - Fix computed size for _ExtInt types passed to checked arithmetic builtins. -

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

2020-06-14 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. In D81336#2091833 , @aaron.ballman wrote: > In D81336#2090708 , > @LegalizeAdulthood wrote: > > > Yeah, the restriction to the header file is a bug. It was a misconception > > on my

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

2020-06-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added reviewers: sammccall, dblaikie. aaron.ballman added subscribers: sammccall, dblaikie. aaron.ballman added a comment. Pinging @klimek , @sammccall , and @dblaikie to see if there are some opinions about overloading `hasName` (and possibly other naming related questions).

[PATCH] D81336: [clang-tidy] simplify-bool-expr ignores template instantiations

2020-06-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D81336#2090708 , @LegalizeAdulthood wrote: > Yeah, the restriction to the header file is a bug. It was a misconception on > my part when I originally wrote the matcher. Excellent, thank you for weighing in! I'm fine

[clang-tools-extra] 7fc533a - [clangd] Fix windows builds failing on check-clangd

2020-06-14 Thread via cfe-commits
Author: njames93 Date: 2020-06-14T13:29:17+01:00 New Revision: 7fc533a1d8de25e74c4829a9d868dbebd498492c URL: https://github.com/llvm/llvm-project/commit/7fc533a1d8de25e74c4829a9d868dbebd498492c DIFF: https://github.com/llvm/llvm-project/commit/7fc533a1d8de25e74c4829a9d868dbebd498492c.diff

[PATCH] D81786: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

2020-06-14 Thread Bruno Ricci via Phabricator via cfe-commits
riccibruno added a reviewer: lebedev.ri. riccibruno added a comment. Summarising a quick discussion with @lebedev.ri on IRC yesterday: this is not necessarily the best way to test the serialization of AST nodes, in that we could instead perform some kind of structural equivalence test. However

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-14 Thread Kristóf Umann via Phabricator via cfe-commits
Szelethus added a comment. I'd still like to see more `NoteTag`s such as "File read failed, end-of-file indicator set on 'F'", and a final evaluation would be nice, but otherwise this checker looks amazing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

2020-06-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. > @NoQ @baloghadamsoftware Escapes are more within your realm of expertise. > Anything to add? This looks like a fairly standard approach to take, no objections. Comment at:

[PATCH] D81407: [Analyzer][StreamChecker] Add note tags for file opening.

2020-06-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a reviewer: NoQ. NoQ added a comment. Do i understand correctly that the checker is no longer "missing limbs" and we should consider turning it on by default? If so, @balazske could you prioritize hunting down the remaining false positives above adding new checks / hunting down false

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-06-14 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:124 +return; + updateTrackedRegion(Call, C, ThisValRegion); +} NoQ wrote: > Not all constructors behave this way. In particular, if it's a copy/move > constructor

[PATCH] D81315: [analyzer] Warning for default constructed unique pointer dereferences

2020-06-14 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:35 bool isNullAfterMoveMethod(const CallEvent ) const; + BugType NullDereferenceBugType{this, "Null-smartPtr-deref", + "C++ smart pointer"};