[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

aaron.ballman added inline comments. Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109 + static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) { +IO.enumCase(Value, "Warning", clang::tooling::Diagnostic::Warning); +IO.enumCase(Value, "Erro

[PATCH] D81836: [PowerPC][Power10] Implement Vector Permute Builtins in LLVM/Clang

biplmish created this revision. biplmish added reviewers: nemanjai, lei, power-llvm-team. biplmish added projects: clang, LLVM, PowerPC. Herald added subscribers: llvm-commits, cfe-commits, shchenz, hiraditya. This patch implements builtins for the following prototypes: vector unsigned char vec_i

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

kadircet added a comment. Moreover, the most time consuming(well this might be subject to ltrace not counting IO wait times, as an openat above was only 5microsecs/call and a tolower call is 56 microsecs/call :D) bit actually seems like the string comparisons/manipulations done while parsing th

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

stuij created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. stuij added a child revision: D81373: [WIP] Basic bfloat support on Arm. As part of moving the argument lowering handling for bfloat arguments and returns to the backend, t

[PATCH] D74054: [clangd] Include the underlying decls in go-to-definition.

hokein updated this revision to Diff 270715. hokein marked 2 inline comments as done. hokein added a comment. address review comment: fix the wrong result for multiple overloads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74054/new/ https://revi

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett updated this revision to Diff 270716. DavidSpickett added a comment. Address comments from MaskRay. - Use triple slash for actual comments - symlink clang, don't run test on Windows - Merged some commands onto one line e.g. touch/chmod Repository: rG LLVM Github Monorepo CHANGE

[clang] a06b2cb - Fix clang/test/Modules/empty.modulemap by increasing limit.

Author: Sander de Smalen Date: 2020-06-15T12:27:25+01:00 New Revision: a06b2cb0f5df68e06f0cbce5f2d5fb9d3dcb57d6 URL: https://github.com/llvm/llvm-project/commit/a06b2cb0f5df68e06f0cbce5f2d5fb9d3dcb57d6 DIFF: https://github.com/llvm/llvm-project/commit/a06b2cb0f5df68e06f0cbce5f2d5fb9d3dcb57d6.di

[PATCH] D81786: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D81786#2091781 , @riccibruno wrote: > Summarising a quick discussion with @lebedev.ri on IRC yesterday: this is > not necessarily the

[PATCH] D79842: [clang][Driver] Correct tool search path priority

DavidSpickett marked 4 inline comments as done. DavidSpickett added inline comments. Comment at: clang/test/Driver/program-path-priority.c:20 +// No gccs at all, nothing is found +// RUN: env "PATH=" %t/clang -### -target notreal-none-elf %s 2>&1 \ +// RUN: | FileCheck --check-pr

[PATCH] D81719: [clangd] Drop usage of PreambleStatCache in scanPreamble

sammccall added a comment. Thanks for all this investigation! > 80.710.002330 5 394 374 openat I'm curious what the 400 attempts and 20 successes are (I've seen this before but don't remember now). Probably not worth digging into though unless you happen to have the

[PATCH] D81543: [CodeGen][TLS] Set TLS Model for __tls_guard as well.

aaron.ballman added a comment. Changes generally LGTM, but this is not my area of expertise. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2622 Guard->setThreadLocal(true); +Guard->setThreadLocalMode(CGM.GetDefaultLLVMTLSModel()); Do we need a simi

cfe-commits@lists.llvm.org

LukeGeeson updated this revision to Diff 270720. LukeGeeson added a comment. removed redundancy in patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81740/new/ https://reviews.llvm.org/D81740 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/arm-bf16-dotprod-intrinsics.c

[PATCH] D81787: [clang] Fix the serialization of LambdaExpr and the bogus mutation in LambdaExpr::getBody

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with some nits. Comment at: clang/include/clang/AST/ExprCXX.h:2012-2017 + Stmt *getBody() const { return getStoredStmts()[capture_size()]; } + + /// Retr

[PATCH] D81786: [clang][utils] Modify make-ast-dump-check.sh to generate AST serialization dump tests

lebedev.ri added a comment. SGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81786/new/ https://reviews.llvm.org/D81786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D81837: [ARM][bfloat] Removing lowering of bfloat arguments and returns from Clang's CodeGen

stuij updated this revision to Diff 270721. stuij added a comment. adjust arm bfloat mangle tests for these changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81837/new/ https://reviews.llvm.org/D81837 Files: clang/lib/CodeGen/ABIInfo.h cla

cfe-commits@lists.llvm.org

miyuki added inline comments. Comment at: clang/test/CodeGen/arm-bf16-dotprod-intrinsics.c:2 +// RUN: %clang_cc1 -triple armv8-arm-none-eabi \ +// RUN: -O2 -target-feature +neon -target-feature +bf16 \ +// RUN: -mfloat-abi hard \ Would it be sufficient to run

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109 + static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) { +IO.enumCase(Value, "Warning", clang::tooling::D

[PATCH] D80851: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80851/new/ https://reviews.llvm.org/D80851

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

stuij added a comment. I would have expected changes for neon as well. Can't we now also get rid of the HasLegalHalfType argument to GetNeonType in CGBuiltin.(h|cpp). And also similar code in TargetInfo.cpp (ARMABIInfo::classifyReturnType, ARMABIInfo::isIllegalVectorType)? Repository: rG LL

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/Tooling/DiagnosticsYaml.h:109 + static void enumeration(IO &IO, clang::tooling::Diagnostic::Level &Value) { +IO.enumC

[clang] efa8b6e - [Analyzer][StreamChecker] Add check for pointer escape.

Author: Balázs Kéri Date: 2020-06-15T15:43:23+02:00 New Revision: efa8b6e884aa4c3ad74ab44489352c0f80ac9741 URL: https://github.com/llvm/llvm-project/commit/efa8b6e884aa4c3ad74ab44489352c0f80ac9741 DIFF: https://github.com/llvm/llvm-project/commit/efa8b6e884aa4c3ad74ab44489352c0f80ac9741.diff L

[clang] 8799ebb - [clang] Fix or emit diagnostic for checked arithmetic builtins with

Author: Jeff Mott Date: 2020-06-15T06:51:54-07:00 New Revision: 8799ebbc1f03a348f732fc14242ad4c395076bcc URL: https://github.com/llvm/llvm-project/commit/8799ebbc1f03a348f732fc14242ad4c395076bcc DIFF: https://github.com/llvm/llvm-project/commit/8799ebbc1f03a348f732fc14242ad4c395076bcc.diff LOG

[PATCH] D81825: [Clang] Add support for -Wno-inline-namespace-reopened-noninline

Elvina updated this revision to Diff 270739. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81825/new/ https://reviews.llvm.org/D81825 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/Misc/warning-flags.c clang/test/S

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval marked 3 inline comments as done. clementval added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMP.td:496 +def OMP_EndDeclareVariant : Directive<"end declare variant"> {} +def OMP_Unknown : Directive<"unknown"> {} jdoerfert wrote: >

[PATCH] D81420: Fix size for _ExtInt types with builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG8799ebbc1f03: [clang] Fix or emit diagnostic for checked arithmetic builtins with _ExtInt… (authored by jtmott-intel, committed by erichkeane). Herald added a project: clang. Repository: rG LLVM Github

[PATCH] D80699: [Analyzer][StreamChecker] Add check for pointer escape.

This revision was automatically updated to reflect the committed changes. Closed by commit rGefa8b6e884aa: [Analyzer][StreamChecker] Add check for pointer escape. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80699/new/ https

[PATCH] D81395: [AST][RecoveryExpr] Preserve the invalid "undef_var" initializer.

hokein updated this revision to Diff 270746. hokein added a comment. Make recovery fallback as part of the CorrectDelayedTyposInExpr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81395/new/ https://reviews.llvm.org/D81395 Files: clang/include/c

[clang] c98c94d - [clang-tidy] Add diagnostics level to YAML output

Author: Dmitry Polukhin Date: 2020-06-15T07:40:53-07:00 New Revision: c98c94d85f8591c22f369e8f35142379ba27bb33 URL: https://github.com/llvm/llvm-project/commit/c98c94d85f8591c22f369e8f35142379ba27bb33 DIFF: https://github.com/llvm/llvm-project/commit/c98c94d85f8591c22f369e8f35142379ba27bb33.dif

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

DmitryPolukhin added a comment. @aaron.ballman thank you for review and quick response! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79285/new/ https://reviews.llvm.org/D79285 ___ cfe-commits mailing

[PATCH] D79285: [clang-tidy] Add diagnostics level to YAML output

This revision was automatically updated to reflect the committed changes. Closed by commit rGc98c94d85f85: [clang-tidy] Add diagnostics level to YAML output (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79285/new/ https

[clang] 837ca47 - [NFCI] Change the data structure of MaybeODRUseExprSet

Author: Erich Keane Date: 2020-06-15T08:15:50-07:00 New Revision: 837ca4796065ccd0ac0d20860341ac06a9645009 URL: https://github.com/llvm/llvm-project/commit/837ca4796065ccd0ac0d20860341ac06a9645009 DIFF: https://github.com/llvm/llvm-project/commit/837ca4796065ccd0ac0d20860341ac06a9645009.diff L

[clang] e1741e3 - [analyzer] Reasoning about comparison expressions in RangeConstraintManager

Author: Denys Petrov Date: 2020-06-15T18:35:15+03:00 New Revision: e1741e34e00b27cbf9acc9b2eb85b71d2676e968 URL: https://github.com/llvm/llvm-project/commit/e1741e34e00b27cbf9acc9b2eb85b71d2676e968 DIFF: https://github.com/llvm/llvm-project/commit/e1741e34e00b27cbf9acc9b2eb85b71d2676e968.diff

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.

[PATCH] D77806: [analyzer] Do not report CFError null dereference for nonnull params

ASDenysPetrov added a comment. @vsavchenko Seems you could fix this bug https://bugs.llvm.org/show_bug.cgi?id=24876 Could you check it, please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77806/new/ https://reviews.llvm.org/D77806 ___

[PATCH] D81795: [clang] Enable -mms-bitfields by default for mingw targets

rjmccall added a comment. Seems reasonable; GCC is the "system compiler" for this platform. Does `isWindowsGNUEnvironment` exactly track the condition that GCC uses? It's just MinGW, not Cygwin? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D817

[PATCH] D81785: [clangd] Fix readability-else-after-return 'Adding a note without main diagnostic' crash

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ElseAfterReturnCheck.cpp:191 // scope, we can pull the decl out of the if statement. - DiagnosticBuilder Diag = - diag(ElseLoc, WarningMessage, clang::DiagnosticIDs::Level::

[PATCH] D81785: [clangd] Fix readability-else-after-return 'Adding a note without main diagnostic' crash

njames93 updated this revision to Diff 270759. njames93 marked an inline comment as done. njames93 added a comment. - Remove clangd test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81785/new/ https://reviews.llvm.org/D81785 Files: clang-t

[PATCH] D79910: [x86][seses] Add clang flag; Use lvi-cfi with seses

sconstab added a comment. Any progress on this patch? D75939 has been merged, but the SESES feature will not be secure until it has CFI protections. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79910/new/ https:/

[PATCH] D81552: [ASTMatchers] Added hasDirectBase and hasClass Matchers

sammccall added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3553 +/// \endcode +AST_MATCHER_P(CXXBaseSpecifier, hasClass, internal::Matcher, + InnerMatcher) { aaron.ballman wrote: > jkorous wrote: > > aaron.ballman wrot

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/XRefs.cpp:1233 + llvm::SmallString<32> USR; + if (!index::generateUSRForDecl(&ND, USR)) { +THI.data = SymbolID(USR).str()

[PATCH] D78933: [analyzer] Reasoning about comparison expressions in RangeConstraintManager

This revision was automatically updated to reflect the committed changes. Closed by commit rGe1741e34e00b: [analyzer] Reasoning about comparison expressions in RangeConstraintManager (authored by ASDenysPetrov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[clang-tools-extra] 7759f70 - [clangd] Support typeHierarchy/resolve for children of parents as well

Author: Nathan Ridge Date: 2020-06-15T11:59:23-04:00 New Revision: 7759f70fb0ee2cd6752d9188bd2578cc3d9a7a2e URL: https://github.com/llvm/llvm-project/commit/7759f70fb0ee2cd6752d9188bd2578cc3d9a7a2e DIFF: https://github.com/llvm/llvm-project/commit/7759f70fb0ee2cd6752d9188bd2578cc3d9a7a2e.diff

[PATCH] D78644: [LSan] Enable for SystemZ

iii updated this revision to Diff 270771. iii added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-rt/cmake/config-ix.cmake c

[PATCH] D81451: [ARM][Clang] Removing lowering of half-precision FP arguments and returns from Clang's CodeGen

pratlucas added a comment. Hi @stuij, The changes to the backend only handle the half (f16) type itself, not vectors that have it as their base type. From what I've checked on the AAPCS, the rules for handling those types are a bit different and they would require their own handling in the bac

[PATCH] D81847: [ARM] Improve diagnostics message when Neon is unsupported

vhscampos created this revision. Herald added subscribers: cfe-commits, danielkiss, kristof.beyls. Herald added a project: clang. vhscampos added a reviewer: stuij. Whenever Neon is not supported, a generic message is printed: error: "NEON support not enabled" Followed by a series of other err

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge updated this revision to Diff 270769. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81845/new/ https://reviews.llvm.org/D81845 Files: clang-tools-extra/clangd/XRefs.cpp Index: clang-tools-extra/clangd

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

This revision was automatically updated to reflect the committed changes. Closed by commit rG7759f70fb0ee: [clangd] Support typeHierarchy/resolve for children of parents as well (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8184

[clang-tools-extra] d150523 - [clangd] Follow-up to fix lit-test bustage in type-hierarchy.test

Author: Nathan Ridge Date: 2020-06-15T12:18:21-04:00 New Revision: d1505233c85360bf3d9ab07af803b2bb478547a6 URL: https://github.com/llvm/llvm-project/commit/d1505233c85360bf3d9ab07af803b2bb478547a6 DIFF: https://github.com/llvm/llvm-project/commit/d1505233c85360bf3d9ab07af803b2bb478547a6.diff

Re: [clang] e4b3fc1 - Get rid of -Wunused warnings in release build, NFC.

I don't think the comment's adding value here - it should be fairly clear from the context that the whole loop only exists for some assertions. Also: Could you remove the "(void)" casts now that the whole thing's wrapped in NDEBUG? (an alternative way of phrasing this that doesn't require the #if

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

nridge added a comment. In D81845#2093056 , @sammccall wrote: > May have broken tests: > http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30458/steps/test-check-all/logs/FAIL%3A%20Clangd%3A%3A%20type-hierarchy.test Sorry about that, pus

[PATCH] D81845: [clangd] Support typeHierarchy/resolve for children of parents as well

sammccall added a comment. May have broken tests: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/30458/steps/test-check-all/logs/FAIL%3A%20Clangd%3A%3A%20type-hierarchy.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81845/new

[PATCH] D81849: [clang][amdgpu] Prefer not using `fp16` conversion intrinsics.

hliao created this revision. hliao added reviewers: yaxunl, arsenm. Herald added subscribers: cfe-commits, kerbowa, t-tye, tpr, dstuttard, nhaehnle, wdng, jvesely, kzhuravl. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D81849 Files: clang/lib/B

[PATCH] D78644: [LSan] Enable for SystemZ

uweigand accepted this revision. uweigand added a comment. This revision is now accepted and ready to land. This all looks good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78644/new/ https://reviews.llvm.org/D78644 _

[PATCH] D81794: [clang] Don't emit warn_cxx_ms_struct when MSBitfields is enabled globally

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. Thanks. This seems well-contained and the test changes look good. (rnk is on leave and unlikely to respond.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81794/new/ https://rev

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

njames93 added a comment. As an afterthought, Would you think it a good idea to extend this logic to the `ConfigOptionsProvider` That way you can use something along the lines of: clang-tidy --config='{InheritParentConfig: true, CheckOptions: []}' clang-tidy would then go to read the .clang-t

[PATCH] D77592: [clang] Frontend components for the relative vtables ABI

erik.pilkington added inline comments. Comment at: clang/lib/CodeGen/ConstantInitBuilder.cpp:132 + return getRelativeOffsetToPosition(offsetType, target, + Builder.SelfReferences.size()); +} Shouldn't this be `Builder.Buffer.s

[clang] 017969d - [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

Author: Francesco Petrogalli Date: 2020-06-15T16:52:36Z New Revision: 017969de766287ec6c2fc82128c62d1d1dad7bd8 URL: https://github.com/llvm/llvm-project/commit/017969de766287ec6c2fc82128c62d1d1dad7bd8 DIFF: https://github.com/llvm/llvm-project/commit/017969de766287ec6c2fc82128c62d1d1dad7bd8.dif

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. In D75184#2093089 , @njames93 wrote: > As an afterthought, Would you think it a good idea to extend this logic to > the `ConfigOptionsProvider` That way you can use something along the lines of: > > clang-tidy --config='{

[PATCH] D81522: Fix variables used only in asserts.

dblaikie added a comment. Thanks for the fix! Totally within the realm of post-commit review so far as I can see. The paired assertions could maybe be rewritten as: "assert(MRMgr.getVarRegion(P, SFC) ->getKind()== (SFC->inTopFrame() ? NonParamVarRegionKind : ParamVarRegionKind));" though it's n

[PATCH] D80851: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG017969de7662: [llvm][SveEmitter] SVE ACLE for quadword permute intrinsics. (authored by fpetrogalli). Changed prior to commit: https://reviews.llvm.org/D80851?vs=267392&id=270793#toc Repository: rG L

[PATCH] D81732: [clang] Replace Decl::isUnconditionallyVisible() with Sema::isVisible()

dblaikie added a comment. Test case(s)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81732/new/ https://reviews.llvm.org/D81732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

aschwaighofer created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. aschwaighofer added a reviewer: rjmccall. If a record has a mix of relative pointers and other fields they wouldn't necessarily be the same. Fallout from D77592

[PATCH] D79842: [clang][Driver] Correct tool search path priority

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Looks great! Please give other reviews a day or two to respond in case they have comments. Comment at: clang/test/Driver/program-path-priority.c:22 +/// No gccs at all, no

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. ping :) For clang side is there any suggestions? Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270802. dang marked an inline comment as done. dang added a comment. Implement constant table based marshaling for simple enum based options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://review

[PATCH] D80753: [clang-tidy] remove duplicate fixes of alias checkers

Daniel599 marked an inline comment as done. Daniel599 added a comment. ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80753/new/ https://reviews.llvm.org/D80753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3845 + IS_POSITIVE != DEFAULT_VALUE && this->KEYPATH != DEFAULT_VALUE) \ +Args.push_back(StringAllocator(Twine(PREFIX_TYPE[0]) + NAME)); +#i

[PATCH] D79675: [OpenMP][OMPBuilder] Adding Privatization Requirements to OMPIRBuilder

fghanim added a comment. Ping. Does this patch need further changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79675/new/ https://reviews.llvm.org/D79675 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane accepted this revision. erichkeane added a comment. Please fix the 'nit' when committing. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2207 +llvm::RoundingMode::Dynamic, &loseInfo); +(void)EvalSucceed; +llvm::Type *Ty = ConvertType(Prob

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

hubert.reinterpretcast added inline comments. Comment at: clang/test/CodeGen/static-init.cpp:31 +// CHECK: @llvm.global_ctors = appending global [1 x { i32, void ()*, i8* }] [{ i32, void ()*, i8* } { i32 65535, void ()* @__sinit8000_clang_510e898aa8d263cac999dd03eeed5b51, i

[PATCH] D79677: [Clang][OpenMP][OMPBuilder] (1/4) Privatize `parallel` for `OMPBuilder`

fghanim added a comment. ping - please suggest reviewers I can add to review the clang side of things? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79677/new/ https://reviews.llvm.org/D79677 ___ cfe-c

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

jurahul added a comment. Yes, I'd appreciate if someone can land this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81045/new/ https://reviews.llvm.org/D81045 ___ cfe-commits mailing list cfe-c

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl created this revision. yaxunl added reviewers: tra, ashi1. Herald added subscribers: kerbowa, dexonsmith, nhaehnle, jvesely. This patch is a follow up on https://reviews.llvm.org/D81627. In addition to default -fno-gpu-rdc case, this patches let HIP toolchain not use llvm-link/opt/llc to l

[PATCH] D81849: [clang][amdgpu] Prefer not using `fp16` conversion intrinsics.

arsenm added inline comments. Comment at: clang/test/CodeGenHIP/half.hip:6 + +// CHECK-LABEL: @_Z2d0DF16_ +// CHECK: fpext Making sure the argument type is "half" wouldn't hurt either Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

rjmccall added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81857/new/ https://reviews.llvm.org/D81857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D81422: Change filecheck default to dump input on failure

arsenm added a comment. I'm growing to dislike the new behavior even more as I use it. I don't think restricting the dump to CHECK-LABEL prefixes will even help. The amount of context printed previously was good enough for development use. If I ever can't figure it out from the diff, I want to

[clang] 72d20b9 - [LLVM] Change isa<> to a variadic function template

Author: Rahul Joshi Date: 2020-06-15T18:46:57Z New Revision: 72d20b9604f65e35eedb3d00098a2c9412953946 URL: https://github.com/llvm/llvm-project/commit/72d20b9604f65e35eedb3d00098a2c9412953946 DIFF: https://github.com/llvm/llvm-project/commit/72d20b9604f65e35eedb3d00098a2c9412953946.diff LOG: [

[PATCH] D81627: [HIP] Do not call opt/llc for -fno-gpu-rdc

ashi1 accepted this revision. ashi1 added a comment. LGTM, thank you for splitting the cuda-phases from hip-phases, and opening up a follow-up patch for RDC case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81627/new/ https://reviews.llvm.org/D81627 ___

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

arsenm added a comment. Thanks for doing this, this has been sorely needed since forever. We also really need to switch opencl over to this Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:207-209 + Arg *A = Args.getLastArg(options::OPT_march_EQ); + if (!A) +A = Ar

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:7831-7838 + llvm::Value *SizeV = nullptr; + if (CAT) { +llvm::APInt Size = CAT->getSize(); +SizeV = llvm::ConstantInt::get(CGF.SizeTy, Size); + } el

[PATCH] D76443: Use ConstantExpr cached APValues if present for code generation

wchilders abandoned this revision. wchilders added a comment. Abandoned in favor of https://reviews.llvm.org/D76420 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76443/new/ https://reviews.llvm.org/D76443 ___ cfe-commits mailing list cfe-co

[PATCH] D81718: [Analyzer][NFC] Add methods `getReturnObject()` and `getArgObject()` to `CallEvent`

baloghadamsoftware updated this revision to Diff 270814. baloghadamsoftware added a comment. Updated to check the type of the argument expression instead of the `SVal`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81718/new/ https://reviews.llvm.org/D81718 Files: clang/include/clang

[PATCH] D81045: [LLVM] Change isa<> to a variadic function template

This revision was automatically updated to reflect the committed changes. Closed by commit rG72d20b9604f6: [LLVM] Change isa<> to a variadic function template (authored by jurahul, committed by mehdi_amini). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 4a8120c - Fix ConstantAggregateBuilderBase::getRelativeOffset

Author: Arnold Schwaighofer Date: 2020-06-15T12:23:20-07:00 New Revision: 4a8120ca9fb904b50e6940457e0f891ca1fdb605 URL: https://github.com/llvm/llvm-project/commit/4a8120ca9fb904b50e6940457e0f891ca1fdb605 DIFF: https://github.com/llvm/llvm-project/commit/4a8120ca9fb904b50e6940457e0f891ca1fdb605

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

ashi1 added a comment. Thank you for this patch, it looks good, and I have a few minor questions/comments. Comment at: clang/test/Driver/hip-phases.hip:34 +// RDC-DAG: [[P6:[0-9]+]]: backend, {[[P5]]}, ir, (device-[[T]], [[ARCH]]) +// RDC-DAG: [[P10:[0-9]+]]: linker, {[[P6]]},

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:207-209 + Arg *A = Args.getLastArg(options::OPT_march_EQ); + if (!A) +A = Args.getLastArg(options::OPT_mcpu_EQ); arsenm wrote: > Wh

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

smeenai added inline comments. Comment at: llvm/docs/CodingStandards.rst:1600 + // Omit the braces, since the body is simple and clearly associated with the if. + if (isa(D)) +handleFunctionDecl(D); I'm late to the party here (and I haven't read the entire

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl updated this revision to Diff 270825. yaxunl added a reviewer: arsenm. yaxunl added a comment. Herald added a subscriber: wdng. use -mcpu instead of march in HIP toolchain. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81861/new/ https://reviews.llvm.org/D81861 Files: clang/li

[PATCH] D80970: [PowerPC][Power10] Implement centrifuge, vector gather every nth bit, vector evaluate Builtins in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80970/new/ https://reviews.llvm.org/D80970 _

[PATCH] D81774: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81774/new/ https://reviews.llvm.org/D81774 _

[PATCH] D80935: [PowerPC][Power10] Implement Parallel Bits Deposit/Extract Builtins in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM, just 1 minor comment/question. Comment at: llvm/lib/Target/PowerPC/PPCScheduleP9.td:47 + let UnsupportedFeatures = [HasQPX, HasSPE, PrefixInstrs, PCRelativeMemops, +

[PATCH] D81707: [PowerPC][Power10] Implement Vector Clear Left/Rightmost Bytes Builtins in LLVM/Clang

lei accepted this revision as: lei. lei added a comment. This revision is now accepted and ready to land. LGTM Minor nit to be addressed during commit. Comment at: llvm/lib/Target/PowerPC/PPCInstrPrefix.td:522 + [(set v16i8:$vD, +

[PATCH] D69987: [RISCV] Assemble/Disassemble v-ext instructions.

evandro added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrFormats.td:56 +def NoConstraint : RISCVVConstraint<0>; +def WidenV : RISCVVConstraint<1>; +def WidenW : RISCVVConstraint<2>; HsiangKai wrote: > evandro wrote: > > Methinks that

[PATCH] D81857: Fix ConstantAggregateBuilderBase::getRelativeOffset

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a8120ca9fb9: Fix ConstantAggregateBuilderBase::getRelativeOffset (authored by aschwaighofer). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81857/new/ http

[PATCH] D80947: Add to the Coding Standard our that single-line bodies omit braces

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: llvm/docs/CodingStandards.rst:1600 + // Omit the braces, since the body is simple and clearly associated with the if. + if (isa(D)) +handleFunctionDecl(D); smeenai w

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl marked 5 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:34 +// RDC-DAG: [[P6:[0-9]+]]: backend, {[[P5]]}, ir, (device-[[T]], [[ARCH]]) +// RDC-DAG: [[P10:[0-9]+]]: linker, {[[P6]]}, image, (device-hip, [[ARCH]]) --

[clang] d700237 - [CUDA,HIP] Use VFS for SDK detection.

Author: Artem Belevich Date: 2020-06-15T12:54:44-07:00 New Revision: d700237f1aa1bc05d584a0f50fdad89370e17987 URL: https://github.com/llvm/llvm-project/commit/d700237f1aa1bc05d584a0f50fdad89370e17987 DIFF: https://github.com/llvm/llvm-project/commit/d700237f1aa1bc05d584a0f50fdad89370e17987.diff

[PATCH] D63852: [Clang] Move assembler into a separate file

echristo added a comment. Hmm. In general I'd like to hear more about what you're trying. Can you give an idea of how you'd like to invoke the library to assemble something via clang? Why not just call into llvm directly? I'm not necessarily against changing the layering here fwiw, just wanted

[PATCH] D81868: [libTooling] Add parser for string representation of `RangeSelector`.

ymandel created this revision. ymandel added reviewers: gribozavr2, tdl-g. Herald added a project: clang. This patch adds a parser for a `RangeSelector` written as a string. The format is closely based on the way one would right the selector in C++, except that bound nodes are referred to by their

[PATCH] D81861: [HIP] Do not use llvm-link/opt/llc for -fgpu-rdc

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/test/Driver/hip-phases.hip:253 +// L2-DAG: [[P0:[0-9]+]]: input, "{{.*}}obj1.o", object, (host-[[T:hip]]) +// RL2-DAG: [[P1:[0-9]+]]: clang-offload-unbundler, {[[P0]]}, object, (host-[[T:hip

  1   2   >