[PATCH] D82346: [WebAssebmly] Fully disable 'protected' visibility

sbc100 created this revision. Herald added subscribers: cfe-commits, aheejin, jgravelle-google, dschuff. Herald added a project: clang. sbc100 added a reviewer: dschuff. Emscripten doesn't use protected visibility either. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82346 Fi

[PATCH] D82345: [sve][acle] Implement some of the C intrinsics for brain float.

fpetrogalli created this revision. fpetrogalli added reviewers: sdesmalen, kmclaughlin, c-rhodes, ctetreau. Herald added subscribers: llvm-commits, cfe-commits, psnobl, rkruppe, hiraditya, tschuett. Herald added a reviewer: efriedma. Herald added projects: clang, LLVM. The following intrinsics ha

[PATCH] D81836: [PowerPC][Power10] Implement Vector Permute Builtins in LLVM/Clang

steven.zhang added a comment. This is a huge patch. I suggest you to split them into small ones for each kind of builtins, so that, it would be more easy to review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81836/new/ https://reviews.llvm.org/

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

rjmccall added inline comments. Comment at: clang/include/clang/AST/Stmt.h:620 +//unsigned FPFeatures : 21; +unsigned FPFeatures : 32; }; riccibruno wrote: > mibintc wrote: > > This is a temporary change, I know you don't want me to change the assert

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

pfultz2 added a comment. > Could you give an example to demonstrate current use and how it will break? Here is place where it would break: https://github.com/ROCmSoftwarePlatform/AMDMIGraphX/blob/develop/src/targets/gpu/device/include/migraphx/gpu/device/multi_index.hpp#L129 This change was alr

Buildbot numbers for the week of 06/14/2020 - 06/20/2020

Hello everyone, Below are some buildbot numbers for the last week of 06/14/2020 - 06/20/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from gre

Buildbot numbers for the week of 06/7/2020 - 06/13/2020

Hello everyone, Below are some buildbot numbers for the week of 06/7/2020 - 06/13/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

[clang] 2a3b86c - Fix rejects-valid when referencing an implicit operator== from within a

Author: Richard Smith Date: 2020-06-22T20:19:20-07:00 New Revision: 2a3b86c157166f3b15f718443334ab0e27b40592 URL: https://github.com/llvm/llvm-project/commit/2a3b86c157166f3b15f718443334ab0e27b40592 DIFF: https://github.com/llvm/llvm-project/commit/2a3b86c157166f3b15f718443334ab0e27b40592.diff

Buildbot numbers for the week of 05/31/2020 - 06/6/2020

Hello everyone, Below are some buildbot numbers for the week of 05/31/2020 - 06/6/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

Buildbot numbers for the week of 05/24/2020 - 05/30/2020

Hello everyone, Below are some buildbot numbers for the week of 05/24/2020 - 05/30/2020. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from green to

[PATCH] D81774: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG19df9e2959cf: [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D81774?vs=270535&id=272589#toc Repository: r

[clang] 9f9373f - Distinguish between template parameter substitutions that are forming

Author: Richard Smith Date: 2020-06-22T19:34:52-07:00 New Revision: 9f9373f86d2d13b8c9f106863ce70ace69abf388 URL: https://github.com/llvm/llvm-project/commit/9f9373f86d2d13b8c9f106863ce70ace69abf388 DIFF: https://github.com/llvm/llvm-project/commit/9f9373f86d2d13b8c9f106863ce70ace69abf388.diff

[clang] 19df9e2 - [PowerPC][Power10] Implement VSX PCV Generate Operations in LLVM/Clang

Author: Amy Kwan Date: 2020-06-22T21:09:34-05:00 New Revision: 19df9e2959cfa3f25d798bd842df798e2b75f1b2 URL: https://github.com/llvm/llvm-project/commit/19df9e2959cfa3f25d798bd842df798e2b75f1b2 DIFF: https://github.com/llvm/llvm-project/commit/19df9e2959cfa3f25d798bd842df798e2b75f1b2.diff LOG:

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument &Arg : F.args()) { avl wrot

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar updated this revision to Diff 272580. jaafar added a comment. Applied feedback from Aaron Ballman. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81769/new/ https://reviews.llvm.org/D81769 Files: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp clang-tools-e

[PATCH] D82314: [RFC][Coroutines] Optimize the lifespan of temporary co_await object

junparser added a comment. Rather than doing it here, can we build await_resume call expression with MaterializedTemporaryExpr when expand the coawait expression. That's how gcc does. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82314/new/ https

[PATCH] D81769: [clang-tidy] Repair various issues with modernize-avoid-bind

jaafar marked an inline comment as done. jaafar added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidBindCheck.cpp:243 + if ((std::distance(ME->child_begin(), ME->child_end()) == 1) && + isa(*ME->children().begin())) { +// reference to data mem

[PATCH] D82249: [HWASan] Disable GlobalISel/FastISel for HWASan Globals.

hctim added a comment. In D82249#2105036 , @arsenm wrote: > Is the fallback not working correctly in this case for some reason? I'm fairly sure that G_GLOBAL_VALUE used to fallback onto SelectionDAGISel, and that was changed in D78465

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

aardappel added a comment. @dschuff still working on it, it uncovered some issues (as it should :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82130/new/ https://reviews.llvm.org/D82130 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

plotfi added a comment. In D74166#2107831 , @plotfi wrote: > @rjmccall > > FYI this diff appears to be breaking a ptrauth test on > apple/swift/master-next > (clang/test/CodeGenCXX/ptrauth-static-destructors.cpp). > > Investigating this further. Looks

[PATCH] D74166: [AIX][Frontend] Static init implementation for AIX considering no priority

plotfi added subscribers: rjmccall, plotfi. plotfi added a comment. @rjmccall FYI this diff appears to be breaking a ptrauth test on apple/swift/master-next (clang/test/CodeGenCXX/ptrauth-static-destructors.cpp). Investigating this further. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

aeubanks added a comment. In D79895#2107796 , @nick wrote: > > This warning can be turned off by the flag > > `-Wno-uninitialized-const-reference`. > > Suggesting to turn off the warning should be the last resort. I am pointing > to the false positives f

[clang] 009c9b8 - Fix multilevel deduction where an outer pack is used in the type of an

Author: Richard Smith Date: 2020-06-22T16:47:51-07:00 New Revision: 009c9b83acfc8bb863894e349bccc2473c685dbc URL: https://github.com/llvm/llvm-project/commit/009c9b83acfc8bb863894e349bccc2473c685dbc DIFF: https://github.com/llvm/llvm-project/commit/009c9b83acfc8bb863894e349bccc2473c685dbc.diff

[clang] e135cf8 - Add -ast-dump-decl-types flag to include types of value and type

Author: Richard Smith Date: 2020-06-22T16:47:51-07:00 New Revision: e135cf8a03b974d2a43eb9fb93ad2d9adefcdf34 URL: https://github.com/llvm/llvm-project/commit/e135cf8a03b974d2a43eb9fb93ad2d9adefcdf34 DIFF: https://github.com/llvm/llvm-project/commit/e135cf8a03b974d2a43eb9fb93ad2d9adefcdf34.diff

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

nick added a comment. > This warning can be turned off by the flag > `-Wno-uninitialized-const-reference`. Suggesting to turn off the warning should be the last resort. I am pointing to the false positives for large existing code bases from `-Wall` diagnostic. > I don't think we can just make

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked 3 inline comments as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:823 + +bool TailRecursionEliminator::canTRE(Function &F) { + // The local stack holds all alloca instructions and all byval arguments. ---

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

hiraditya added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:801 +if (Branch->isUnconditional()) + if (ReturnInst *Ret = dyn_cast( + Branch->getSuccessor(0)->getFirstNonPHIOrDbg())) can we use isa<> he

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 272564. cchen added a comment. Updated test for clarification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 Files: clang/include/clang/AST/OpenMPClause.h clang/lib/

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

zequanwu added a comment. In D79895#2107604 , @nick wrote: > This diagnostic bring headaches because frequently `-Wunused-variable` > suppression is done via no-op pseudo-consuming function like > `boost::ignore_unused` >

[PATCH] D82335: [clangd] WIP: config

sammccall created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, javed.absar, ilya-biryukov, mgorny. Herald added a project: clang. This is a glorious tangled mess that needs to be split, and needs tests... Repository: rG LLVM Github Mon

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

saghir marked 2 inline comments as done. saghir added inline comments. Comment at: clang/test/Parser/p10-vector-bool-128.c:6 +// RUN:-target-feature +power10-vector -fsyntax-only -verify %s +// expected-no-diagnostics + amyk wrote: > I believe this co

[PATCH] D81963: [HIP] Move HIP Linking Logic into HIP ToolChain

MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk '/Reviewers:|Subscrib

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

dschuff added a comment. So the code LGTM, were you going to add to usertest.ll in this CL? Comment at: llvm/lib/Target/WebAssembly/WebAssemblyMCInstLower.cpp:84 WasmSym->setGlobalType(wasm::WasmGlobalType{ -uint8_t(Subtarget.hasAddr64() ? wasm::WASM_TYPE_I64 -

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea updated this revision to Diff 272556. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80833/new/ https://reviews.llvm.org/D80833 Files: clang/test/CodeGen/debug-info-codeview-buildinfo.c lld/COFF/PDB.cpp lld/test/COFF/Inputs/pdb_lines_1_r

[PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

aganea marked 2 inline comments as done. aganea added a subscriber: uweigand. aganea added inline comments. Comment at: clang/test/CodeGen/debug-info-codeview-buildinfo.c:4 +// RUN: %clang_cl /c /Z7 /Fo%t.obj -fdebug-compilation-dir . -- %s +// RUN: llvm-pdbutil dump --types %t.o

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. In D79972#2104854 , @RaviNarayanaswamy wrote: > How do you plan to support > #pragma omp target update to (arr[1:2][1:2][0:2], x, b[1:5][0:2]) > Are you going to split this into 3 updates since your are using the arg > fields.

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

tra added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:753 return; + if (LI.Default == LCD_None && LI.Captures.size() == 0) { +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); pfultz2 wrote: > There should at least be a flag to enab

[PATCH] D82279: Handle invalid types in the nullPointerConstant AST matcher

steveire accepted this revision. steveire added inline comments. This revision is now accepted and ready to land. Comment at: clang/unittests/ASTMatchers/ASTMatchersNarrowingTest.cpp:2618 + )"; + EXPECT_TRUE(matches(kTest, expr(nullPointerConstant(; } aaro

[PATCH] D82115: [OPENMP50]Codegen for scan directives in parallel for simd regions.

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82115/new/ https://reviews.llvm.org/D82115 _

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

laytonio added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:823 + +bool TailRecursionEliminator::canTRE(Function &F) { + // The local stack holds all alloca instructions and all byval arguments. There is no need to pass th

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

riccibruno added inline comments. Comment at: clang/include/clang/AST/Stmt.h:620 +//unsigned FPFeatures : 21; +unsigned FPFeatures : 32; }; mibintc wrote: > This is a temporary change, I know you don't want me to change the assert to > allow a wider s

[PATCH] D81816: [PowerPC] Add support for vector bool __int128 for Power10

amyk accepted this revision as: amyk. amyk added a comment. Other than Lei's concerns, personally I think this looks good to me. Comment at: clang/test/Parser/p10-vector-bool-128.c:6 +// RUN:-target-feature +power10-vector -fsyntax-only -verify %s +// expected-no-di

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

This revision was automatically updated to reflect the committed changes. Closed by commit rG516803dc8685: [Coroutines] Ensure co_await promise.final_suspend() does not throw (authored by lxfind). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/n

[PATCH] D80242: [Clang] implement -fno-eliminate-unused-debug-types

nickdesaulniers updated this revision to Diff 272546. nickdesaulniers added a comment. - fix clang/test/OpenMP/parallel_codegen.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80242/new/ https://reviews.llvm.org/D80242 Files: clang/docs/ClangC

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

nick added a comment. This diagnostic bring headaches because frequently `-Wunused-variable` suppression is done via no-op pseudo-consuming function like `boost::ignore_unused` . Particularly, it fires in Boost h

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:825 + // The local stack holds all alloca instructions and all byval arguments. + AllocaDerivedValueTracker Tracker; + for (Argument &Arg : F.args()) { avl wrot

[clang] 516803d - [Coroutines] Ensure co_await promise.final_suspend() does not throw

Author: Xun Li Date: 2020-06-22T15:01:42-07:00 New Revision: 516803dc8685ebcc5bce38b05391958ffee22643 URL: https://github.com/llvm/llvm-project/commit/516803dc8685ebcc5bce38b05391958ffee22643 DIFF: https://github.com/llvm/llvm-project/commit/516803dc8685ebcc5bce38b05391958ffee22643.diff LOG: [

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

avl marked 4 inline comments as done. avl added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:130 +IsNocapture = true; + else if (Function *CalledFunction = CB.getCalledFunction()) { +if (CalledFunction->getB

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

pfultz2 added inline comments. Comment at: clang/lib/Sema/SemaCUDA.cpp:753 return; + if (LI.Default == LCD_None && LI.Captures.size() == 0) { +Method->addAttr(CUDADeviceAttr::CreateImplicit(Context)); There should at least be a flag to enable capturing

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc marked 6 inline comments as done. mibintc added a subscriber: yaxunl. mibintc added a comment. @rjmccall I added some inline questions and comments for you. Thanks a lot for your review. Comment at: clang/include/clang/AST/ExprCXX.h:172 + FPOptionsOverride getFPFeatu

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. In D79830#2107404 , @LukeZhuang wrote: > Thank you very much! Turns out when I was validating my patch, someone had beaten me to it, it should be fixed, it just wasn't me :) Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D81869: Modify FPFeatures to use delta not absolute settings to solve PCH compatibility problems

mibintc updated this revision to Diff 272536. mibintc added a comment. Herald added a subscriber: martong. Herald added a reviewer: shafik. This revision rewrites FPOptionsOverride like @rjmccall suggests. There are a couple problems, i'll add inline comments in the trouble areas Repository:

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

yaxunl updated this revision to Diff 272539. yaxunl added a comment. Only make non-capturing lambda host and device by default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78655/new/ https://reviews.llvm.org/D78655 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/inc

[PATCH] D76342: [OpenMP] Implement '#pragma omp tile'

ABataev added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:4781-4784 +/// This represents the '#pragma omp tile' loop transformation directive. +class OMPTileDirective final +: public OMPLoopDirective, + private llvm::TrailingObjects { --

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn updated this revision to Diff 272530. kpn added a comment. Remove debugging command left in accidentally. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang/include/c

[PATCH] D82085: [TRE] allow TRE for non-capturing calls.

efriedma added inline comments. Comment at: llvm/lib/Transforms/Scalar/TailRecursionElimination.cpp:130 +IsNocapture = true; + else if (Function *CalledFunction = CB.getCalledFunction()) { +if (CalledFunction->getBasicBlockList().size() > 0 && ---

[PATCH] D79830: Add support of __builtin_expect_with_probability

LukeZhuang added a comment. Thank you very much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D78759: Add Statically Linked Libraries

This revision was automatically updated to reflect the committed changes. Closed by commit rG4bafb0adcf38: Add Statically Linked Libraries (authored by ashi1). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D78759?vs=271220&id=272526#toc Repository:

[PATCH] D81963: [HIP] Move HIP Linking Logic into HIP ToolChain

This revision was automatically updated to reflect the committed changes. Closed by commit rG77df5a8283ed: [HIP] Move HIP Linking Logic into HIP ToolChain (authored by ashi1). Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D81963?vs=271210&id=272525#to

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

jdenny accepted this revision. jdenny added a comment. This revision is now accepted and ready to land. If you feel reasonably confident that each new DEPENDS is needed, then this LGTM. Otherwise, give it a day to see if anyone with stronger cmake skills than me has a comment. Repository: r

[PATCH] D82326: [clangd] Disable printing of Value for tag-types on hover

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. This is both confusing and crashy. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D8

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

tra added a comment. In D78655#2107190 , @yaxunl wrote: > It seems we can only promote non-capturing lambdas, no matter whether it has > enclosing function or not. I'd be OK with promoting only non-capturing lambdas until we figure out a consistent way

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

wristow added inline comments. Comment at: clang/test/CodeGen/fp-strictfp.cpp:1 +// RUN: %clang_cc1 -triple mips64-linux-gnu -frounding-math -ffp-exception-behavior=strict -O2 -verify=rounding,exception -emit-llvm -o - %s | tee /tmp/1 | FileCheck %s +// RUN: %clang_cc1 -triple

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

RKSimon closed this revision. RKSimon added a comment. Committed at rGb30c16670e428d09a0854a8f418e46a3e705e4d1 (with a typo in the Differential Revision tag so phab didn't catch it) CHANGES SINCE LAST ACTION https://review

[PATCH] D79830: Add support of __builtin_expect_with_probability

erichkeane added a comment. I'll get this fixed, thanks both of you for letting me know. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing

[PATCH] D82324: [OPENMP]Dynamic globalization for parallel target regions.

ABataev created this revision. ABataev added a reviewer: jdoerfert. Herald added subscribers: sstefan1, guansong, yaxunl, jholewinski. Herald added a project: clang. Added support for dynamic memory allocation for globalized variables in case if execution of target regions in parallel is required.

[clang] 77df5a8 - [HIP] Move HIP Linking Logic into HIP ToolChain

Author: Aaron En Ye Shi Date: 2020-06-22T19:48:48Z New Revision: 77df5a8283edbfc33ad3b12df3bd42d54d7ba4f4 URL: https://github.com/llvm/llvm-project/commit/77df5a8283edbfc33ad3b12df3bd42d54d7ba4f4 DIFF: https://github.com/llvm/llvm-project/commit/77df5a8283edbfc33ad3b12df3bd42d54d7ba4f4.diff LO

[clang] 4bafb0a - Add Statically Linked Libraries

Author: Aaron En Ye Shi Date: 2020-06-22T19:48:49Z New Revision: 4bafb0adcf38cf268208ea58eb7e11402d5632e2 URL: https://github.com/llvm/llvm-project/commit/4bafb0adcf38cf268208ea58eb7e11402d5632e2 DIFF: https://github.com/llvm/llvm-project/commit/4bafb0adcf38cf268208ea58eb7e11402d5632e2.diff LO

[PATCH] D79830: Add support of __builtin_expect_with_probability

ashi1 added subscribers: yaxunl, ashi1. ashi1 added a comment. Hi, I am getting a compiler error due to this patch. I am using cmake command: cmake ../llvm -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;lld;clang-tools-extra" -DLLVM_TARGETS_TO_BUILD="AMDGPU;X86" -DLLVM_ENABLE_ASSERTIO

[PATCH] D79830: Add support of __builtin_expect_with_probability

antiagainst added inline comments. Comment at: llvm/lib/Transforms/Scalar/LowerExpectIntrinsic.cpp:62 +// __builtin_expect +return {LikelyBranchWeight, UnlikelyBranchWeight}; + } else { FYI: this breaks GCC5: https://buildkite.com/mlir/mlir-core/builds/

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

kpn added a comment. Herald added a subscriber: wuzish. Ping? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80952/new/ https://reviews.llvm.org/D80952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[PATCH] D81408: [builtins] Improve compatibility with 16 bit targets

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM We don't need to block this on the pre-merge checks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81408/new/ https://reviews.llvm.org

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval added a comment. In D81736#2107202 , @jdenny wrote: > My cmake skills are lacking. Why are there are so many new DEPENDS > relationships where there were none before? Is it because omp_gen is > generating a header file that's included (indir

[PATCH] D82029: [Coroutines] Ensure co_await promise.final_suspend() does not throw

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Sweet! Thanks for the reviews/responses, LGTM :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82029/new/ https://reviews.llvm.org/D82029

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

jdenny added a comment. My cmake skills are lacking. Why are there are so many new DEPENDS relationships where there were none before? Is it because omp_gen is generating a header file that's included (indirectly) in all those places, where apparently that sort of dependency was unusual? Hav

[PATCH] D78655: [CUDA][HIP] Let non-caputuring lambda be host device

yaxunl marked an inline comment as done. yaxunl added a comment. In D78655#2107016 , @tra wrote: > In D78655#2105058 , @yaxunl wrote: > > > - lambdas with any lambda-capture (which must therefore have an enclosing

[clang] 0dfc8e1 - [X86] Remove encoding value from the X86_FEATURE and X86_FEATURE_COMPAT macro. NFCI

Author: Craig Topper Date: 2020-06-22T11:46:21-07:00 New Revision: 0dfc8e1837e3e3ac06ab8c08fdc08b15e0ae1c2d URL: https://github.com/llvm/llvm-project/commit/0dfc8e1837e3e3ac06ab8c08fdc08b15e0ae1c2d DIFF: https://github.com/llvm/llvm-project/commit/0dfc8e1837e3e3ac06ab8c08fdc08b15e0ae1c2d.diff

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

efriedma accepted this revision. efriedma added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79167/new/ https://reviews.llvm.org/D79167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[PATCH] D82317: [Clang/Test]: Update tests where `frozen` attribute is necessary

guiand created this revision. Herald added subscribers: cfe-commits, sstefan1, phosek, kerbowa, luismarques, apazos, sameer.abuasal, pzheng, s.egerton, lenary, dmgreen, Jim, mstorsjo, jocewei, PkmX, jfb, arphaman, the_o, brucehoult, MartinMosbeck, rogfer01, atanasyan, edward-jones, zzheng, jrtc2

Re: [clang] 028571d - [clang][Driver] Correct tool search path priority

Thanks for the heads up Nico. Yes that was a mistake, it was reviewed as https://reviews.llvm.org/D79842 but somehow I told arc to land it as the duplicate diff instead. I'll look into the failure. On Mon, 22 Jun 2020 at 13:48, Nico Weber wrote: > > Hi, > > https://reviews.llvm.org/D79988 is app

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand added a comment. I've added the test change to yet another diff, which you can find here: https://reviews.llvm.org/D82317 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.org/D81678 __

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand added a comment. @jdoerfert I've separated out changes to the language reference to https://reviews.llvm.org/D82316 as you suggested. I kept the name `frozen` for now while we reach a consensus regarding its final name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D81678: Introduce frozen attribute at call sites for stricter poison analysis

guiand updated this revision to Diff 272489. guiand added a comment. I've updated this patch to only include the actual implementation of `frozen`, for easier review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81678/new/ https://reviews.llvm.or

[PATCH] D82206: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a4feb1d53df: [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8220

[PATCH] D82281: [clang-tidy] llvm-twine-local ignores parameters

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a8b04114480: [clang-tidy] llvm-twine-local ignores parameters (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82281/new/ https://revi

[PATCH] D79830: Add support of __builtin_expect_with_probability

This revision was automatically updated to reflect the committed changes. Closed by commit rG37fb86030127: Add support of __builtin_expect_with_probability (authored by LukeZhuang, committed by erichkeane). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D82162: [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ae0f5f3e1d4: [clang-tidy] RenamerClangTidy wont emit fixes in scratch space (authored by njames93). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82162/new/

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. eduucaldas updated this revision to Diff 272492. eduucaldas added a comment. removing automatically added include Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82318 Files

[PATCH] D82318: Add `FloatingLiteral` to SyntaxTree

eduucaldas updated this revision to Diff 272492. eduucaldas added a comment. removing automatically added include Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82318/new/ https://reviews.llvm.org/D82318 Files: clang/include/clang/Tooling/Syntax/

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

kmclaughlin updated this revision to Diff 272483. kmclaughlin added a comment. Added tests to llvm-ir-to-intrinsic.ll which check the results of compare instructions CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79167/new/ https://reviews.llvm.org/D79167 Files: llvm/lib/CodeGen/Sele

[PATCH] D79167: [SVE][CodeGen] Legalisation of vsetcc with scalable types

kmclaughlin added a comment. In D79167#2098774 , @efriedma wrote: > Is it possible to write tests for this that don't result in a "max" or "min" > operation? Or does that fail for some other reason? > > Otherwise LGTM. Thanks for reviewing this, @efrie

[clang] 3a4feb1 - [ARM][BFloat] Implement bf16 get/set_lane without casts to i16 vectors

Author: Mikhail Maltsev Date: 2020-06-22T17:35:43Z New Revision: 3a4feb1d53df68bed7748a0625b593ba4b5dae32 URL: https://github.com/llvm/llvm-project/commit/3a4feb1d53df68bed7748a0625b593ba4b5dae32 DIFF: https://github.com/llvm/llvm-project/commit/3a4feb1d53df68bed7748a0625b593ba4b5dae32.diff LO

[clang-tools-extra] 9a8b041 - [clang-tidy] llvm-twine-local ignores parameters

Author: Nathan James Date: 2020-06-22T18:25:45+01:00 New Revision: 9a8b0411448062e7231a0ee26bd14a3d1c097e9e URL: https://github.com/llvm/llvm-project/commit/9a8b0411448062e7231a0ee26bd14a3d1c097e9e DIFF: https://github.com/llvm/llvm-project/commit/9a8b0411448062e7231a0ee26bd14a3d1c097e9e.diff

[clang] 37fb860 - Add support of __builtin_expect_with_probability

Author: Zhi Zhuang Date: 2020-06-22T10:21:28-07:00 New Revision: 37fb860301272d8138d289da5b606115b3fe5a13 URL: https://github.com/llvm/llvm-project/commit/37fb860301272d8138d289da5b606115b3fe5a13 DIFF: https://github.com/llvm/llvm-project/commit/37fb860301272d8138d289da5b606115b3fe5a13.diff LO

[clang-tools-extra] 6ae0f5f - [clang-tidy] RenamerClangTidy wont emit fixes in scratch space

Author: Nathan James Date: 2020-06-22T18:26:18+01:00 New Revision: 6ae0f5f3e1d465e6a663a50f2cc077671bc6d097 URL: https://github.com/llvm/llvm-project/commit/6ae0f5f3e1d465e6a663a50f2cc077671bc6d097 DIFF: https://github.com/llvm/llvm-project/commit/6ae0f5f3e1d465e6a663a50f2cc077671bc6d097.diff

[PATCH] D81736: [openmp] Base of tablegen generated OpenMP common declaration

clementval requested review of this revision. clementval added a comment. @jdoerfert @jdenny I had to add a bunch of dependencies so that the file is generated correctly when needed. Do you have any feedback on this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D82141: [sve][acle] Add SVE BFloat16 extensions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef597eda8efc: [sve][acle] Add SVE BFloat16 extensions. (authored by fpetrogalli). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82141/new/ https://reviews.l

[PATCH] D82130: [WebAssembly] Adding 64-bit versions of __stack_pointer and other globals

sbc100 accepted this revision. sbc100 added a comment. This revision is now accepted and ready to land. Great! Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:68 + else +CmdArgs.push_back("-m wasm32"); + All the other drivers seem to do `CmdArgs.pu

[PATCH] D81672: [Driver] When forcing a crash print the bug report message

MaskRay added inline comments. Comment at: llvm/lib/Support/PrettyStackTrace.cpp:36 +static const char *BugReportMsg = +"PLEASE submit a bug report to " BUG_REPORT_URL This variable is mutable. Please use `const char BugReportMsg[]` CHANGES SINCE LAST ACT

  1   2   >