[PATCH] D84222: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

hokein added inline comments. Comment at: clang/test/AST/ast-dump-recovery.c:51 + // CHECK-NEXT: `-DeclRefExpr {{.*}} 'some_func' + ptr = some_func(); // should not crash +} For references, the crash stacktrace is like below, the cause is that we run into

[PATCH] D84222: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

hokein updated this revision to Diff 279433. hokein marked an inline comment as done. hokein added a comment. dump cast kind. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84222/new/ https://reviews.llvm.org/D84222 Files: clang/lib/AST/Expr.cpp

[PATCH] D83759: [clangd] Port lit tests to Windows

ArcsinX added a comment. What do you think of this patch? I'm not sure if Windows is important OS for developers, and that some of these changes might be awkward to maintain, but maybe we can enable `background-index.test` at least? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Differential] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9946dcd3e9c7: [clangd] Improve heuristic resolution of dependent t

[Differential] D83492: [OpenMP] Use common interface to access GPU Grid Values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfc7d2908ab38: [OpenMP] Use common interface to access GPU Grid Values (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5

saiislam added a comment. Can you add test with version string 50 also? So, tests should be there for version 45, version 50, and default version. It will ensure that this test doesn't silently stops testing for 50 when we upgrade to the next version. Repository: rG LLVM Github Monorepo CHA

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

lebedev.ri added inline comments. Comment at: llvm/cmake/modules/AddPerfetto.cmake:9 + ExternalProject_Add(perfetto_git + GIT_REPOSITORY https://github.com/google/perfetto.git + GIT_TAG releases/v4.x nickdesaulniers wrote: > lebedev.ri wrote: > > nickd

[PATCH] D84222: [AST][RecoveryExpr] Error-dependent expression should not be treat as a nullptr pointer constant.

hokein created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If an expression is contains-error and its type is unknown (dependent), we don't treat it as a null pointer constant. Fix a recovery-ast crash on C. Repository: rG LLVM Github Monorepo https:

[PATCH] D84221: [OpenMP] Add missing RUN lines for OpenMP 4.5

pdhaliwal created this revision. pdhaliwal added reviewers: saiislam, ABataev, jdoerfert. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a project: clang. This was missed when default version was upgraded to 5.0 (part of D81098 )

[clang-tools-extra] 9946dcd - [clangd] Improve heuristic resolution of dependent types in TargetFinder

Author: Nathan Ridge Date: 2020-07-21T02:03:06-04:00 New Revision: 9946dcd3e9c7e8c7383265b82cc250c72a444f24 URL: https://github.com/llvm/llvm-project/commit/9946dcd3e9c7e8c7383265b82cc250c72a444f24 DIFF: https://github.com/llvm/llvm-project/commit/9946dcd3e9c7e8c7383265b82cc250c72a444f24.diff

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG9946dcd3e9c7: [clangd] Improve heuristic resolution of dependent types in TargetFinder (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D82739?vs=279426&id=279427#toc Repository:

[PATCH] D82739: [clangd] Improve heuristic resolution of dependent types in TargetFinder

nridge updated this revision to Diff 279426. nridge marked 5 inline comments as done. nridge added a comment. Address remaining comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82739/new/ https://reviews.llvm.org/D82739 Files: clang-tools-

[PATCH] D84122: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

This revision was automatically updated to reflect the committed changes. Closed by commit rG100dbd15624c: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector (authored by nridge). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang-tools-extra] 100dbd1 - [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

Author: Nathan Ridge Date: 2020-07-21T01:44:48-04:00 New Revision: 100dbd15624c1ac8d1210e7748462e20fed9a9d9 URL: https://github.com/llvm/llvm-project/commit/100dbd15624c1ac8d1210e7748462e20fed9a9d9 DIFF: https://github.com/llvm/llvm-project/commit/100dbd15624c1ac8d1210e7748462e20fed9a9d9.diff

[PATCH] D84122: [clangd] Handle deduction guides in TargetFinder and ExplicitReferenceCollector

nridge updated this revision to Diff 279424. nridge marked an inline comment as done. nridge added a comment. Address nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84122/new/ https://reviews.llvm.org/D84122 Files: clang-tools-extra/clangd/Fi

[PATCH] D83492: [OpenMP] Use common interface to access GPU Grid Values

This revision was automatically updated to reflect the committed changes. Closed by commit rGfc7d2908ab38: [OpenMP] Use common interface to access GPU Grid Values (authored by saiislam). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83492/new/ https

[clang] fc7d290 - [OpenMP] Use common interface to access GPU Grid Values

Author: Saiyedul Islam Date: 2020-07-21T05:25:46Z New Revision: fc7d2908ab38e1934b3b6a8ab3ec5c674484434b URL: https://github.com/llvm/llvm-project/commit/fc7d2908ab38e1934b3b6a8ab3ec5c674484434b DIFF: https://github.com/llvm/llvm-project/commit/fc7d2908ab38e1934b3b6a8ab3ec5c674484434b.diff LOG

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

aqjune added a comment. In D83360#2162898 , @craig.topper wrote: > @aqjune did you put a patch for InstSimplify doing distribution over undef > yet? Sorry, making InstSimplify to safely distribute undef was a nontrivial job - other than updating InstS

[PATCH] D83820: Change metadata to deferred evalutaion in Clang Transformer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGc0b8954ecba5: [libTooling] In Clang Transformer, change `Metadata` field to deferred… (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83

[PATCH] D79719: [AIX] Implement AIX special alignment rule about double/long double

hubert.reinterpretcast added a comment. I've done another pass over the code (but did not get through the tests). I have no comments about the code at this time. My understanding is that @jasonliu will be doing another pass over this patch, so he can approve while I'm away on vacation. CHANGE

[PATCH] D84144: [clangd] Remove TokenBuffer usage in TypeHierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rGc911803d5df0: [clangd] Remove TokenBuffer usage in TypeHierarchy (authored by ArcsinX, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff220de9009: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions (authored by martong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8340

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG52ab7aa0ba5a: [clang-format] Add BitFieldColonSpacing option (authored by wanders). Repository: rG LLVM Github Monorepo

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 279395. zequanwu added a comment. Missed something. Updated CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/CodeGen/CodeGenAction.cpp clang/lib/

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 279394. zequanwu marked 7 inline comments as done. zequanwu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files: clang/include/clang/Lex/Preprocessor.h clang/lib/Cod

[PATCH] D83519: [NewPM] Support optnone under new pass manager

ychen accepted this revision. ychen added a comment. This revision is now accepted and ready to land. LGTM with one nit. Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:57 +class OptNoneInstrumentation { +public: ychen wrote: > I may probably

[PATCH] D84213: [clang-tools-extra] Disable -Wsuggest-override for unittests/

logan-5 created this revision. logan-5 added reviewers: aaron.ballman, klimek, alexfh, juliehockett, sammccall. logan-5 added a project: clang-tools-extra. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. I added `-Wsuggest-override` to the LLVM build earlier today, an

[PATCH] D82582: [SVE] Remove calls to VectorType::getNumElements from clang

ctetreau updated this revision to Diff 279370. ctetreau added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82582/new/ https://reviews.llvm.org/D82582 Files: clang/lib/CodeGen/CGAtomic.cpp clang/lib/CodeGen/CGBuiltin.cpp cl

[PATCH] D82502: [PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 279362. Conanap marked 5 inline comments as done. Conanap added a comment. Return signature fix, added recognition for ISD:EXTLOAD, some code clean up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82502/new/ h

[PATCH] D83812: [clang][RelativeVTablesABI] Do not emit stubs for architectures that support a PLT relocation

leonardchan updated this revision to Diff 279354. leonardchan marked an inline comment as done. leonardchan added a comment. Add a method to `TargetCodeGenInfo` the returns if the target supports PC relative PLT relocations, Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731

[PATCH] D83188: [clang-tidy] bugprone-bool-pointer-implicit-conversion doesn't handle members

tetsuo-cpp added a comment. Friendly ping. Could I please get this looked at? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83188/new/ https://reviews.llvm.org/D83188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279351. aelitashen added a comment. Add a white space in Symbols loaded info. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-c

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap updated this revision to Diff 279348. Conanap marked 8 inline comments as done. Conanap added a comment. Fixed function names, test case clean up Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/ https://reviews.llvm.org/D83338 File

[PATCH] D83731: Add Debug Info Size to Symbol Status

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a space before the '(' of the debug info size. Comment at: lldb/tools/lldb-vscode/JSONUtils.cpp:357 + std::ostringstream oss; + oss << "("; + oss << std

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

jdenny marked 2 inline comments as done. jdenny added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3067-3068 + unsigned Type = getOpenMPSimpleClauseType(OMPC_map, PP.getSpelling(Tok)); + if (Type < OMPC_MAP_MODIFIER_unknown) +return OMPC_MAP_MODIFIER_unknown

[PATCH] D83722: [PowerPC] Add options to control paired vector memops support

bsaleil updated this revision to Diff 279341. bsaleil added a comment. Add PairedVectorMemops to the list of unsupported features in a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83722/new/ https://reviews.llvm.org/D83722 Files: clang/

[PATCH] D84202: [clang][noderef] Enable -Wnoderef warning for CXX C-style casts

leonardchan created this revision. leonardchan added reviewers: aaron.ballman, rsmith. leonardchan added a project: clang. We find it more valuable to warn on all instances we're removing the `noderef` attribute from a pointer. This patch removes the type holes where we initially didn't warn on

[PATCH] D83652: Merge some of the PCH object support with modular codegen

dblaikie added a comment. In D83652#2161924 , @hans wrote: > In D83652#2159585 , @dblaikie wrote: > > > @hans - could you perhaps give me a quick summary of commands I could use > > to test this feature in Chromium

[PATCH] D84197: [PowerPC][Power10] 128-bit Vector String Isolate instruction definitions and MC Tests

Conanap created this revision. Conanap added reviewers: PowerPC, saghir, nemanjai, hfinkel. Conanap added projects: LLVM, clang, PowerPC. Herald added a subscriber: kbarton. This implements vector string isolate instructions used in vector string isolate builtins. Repository: rG LLVM Github M

[PATCH] D83592: [Parser] Add comment to skipped regions

vsk added a comment. @zequanwu at a high level, I think this is the right approach and it looks nice overall. I do have some feedback (inline). Thanks! Comment at: clang/lib/CodeGen/CoverageMappingGen.cpp:310 + /// Return true if SR should be emitted as SkippedRange. + bool

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 279331. zequanwu added a comment. `arc diff --update` automatically formatted test case. Reverted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files: clang/include/clang/Lex/Preprocessor.h clang/lib

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

nickdesaulniers added inline comments. Comment at: llvm/cmake/modules/AddPerfetto.cmake:9 + ExternalProject_Add(perfetto_git + GIT_REPOSITORY https://github.com/google/perfetto.git + GIT_TAG releases/v4.x lebedev.ri wrote: > nickdesaulniers wrote: > >

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:152 + Align, Name, + /*ArraySize=*/nullptr, Alloca); Do we need to bitcast the result of CreateTempAlloca to a pointer to the array type? I'm concerned that we might miss a bit

[PATCH] D83592: [Parser] Add comment to skipped regions

zequanwu updated this revision to Diff 279329. zequanwu added a comment. Herald added a project: Sanitizers. Herald added a subscriber: Sanitizers. Rebase and address comments. - Keep track of token locations before and after comment regions by `onToken` in `Preprocessor` so when emitting `Skipp

[PATCH] D83360: [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X

craig.topper added a comment. @aqjune did you put a patch for InstSimplify doing distribution over undef yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83360/new/ https://reviews.llvm.org/D83360 __

[PATCH] D81385: Fix libdl linking for libclang in standalone mode

mstorsjo added a subscriber: hans. mstorsjo added a comment. Ping @beanz @hans - I think this is something that would be wanted to have fixed in the release branch (it's a regression for certain build configurations, afaik) - the fix awaits an ack from @beanz. Repository: rG LLVM Github Mon

[PATCH] D79972: [OpenMP5.0] map item can be non-contiguous for target update

cchen abandoned this revision. cchen added a comment. Created a new patch with the support for stride: https://reviews.llvm.org/D84192. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79972/new/ https://reviews.llvm.org/D79972 ___

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

Meinersbur added a comment. In D83261#2162561 , @ABataev wrote: > 1. OMPChildren class uses standard TrailingObjects harness instead of manual > calculation. I was going to argue that OMPExecutableDirective could derive from TrailingObjects as well, bu

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen created this revision. cchen added a reviewer: ABataev. Herald added subscribers: cfe-commits, sstefan1, guansong, yaxunl. Herald added a reviewer: jdoerfert. Herald added a project: clang. In order not to modify the `tgt_target_data_update` information but still be able to pass the extra in

[PATCH] D84147: Use typedef to represent storage type in FPOption and FPOptionsOverride

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84147/new/ https://reviews.llvm.org/D84147 __

[PATCH] D83909: [OPENMP] Fix PR46730: Fix compiler crash on taskloop over constructible loop counters.

ABataev updated this revision to Diff 279308. ABataev added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83909/new/ https://reviews.llvm.org/D83909 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/taskloop_codegen.cpp

[PATCH] D83519: [NewPM] Support optnone under new pass manager

aeubanks updated this revision to Diff 279313. aeubanks marked 4 inline comments as done. aeubanks added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83519/new/ https://reviews.llvm.org/D83519 Files: clang/lib/CodeGe

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2162736 , @sammccall wrote: > Thanks! Do you have commit access, or should I land this for you? No, I don't have commit access. Could you please commit on my behalf? Ilya Golovenko And thanks again for the rev

[PATCH] D83731: Add Debug Info Size to Symbol Status

aelitashen updated this revision to Diff 279303. aelitashen added a comment. Remove white space for test_module_event Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83731/new/ https://reviews.llvm.org/D83731 Files: clang/tools/clang-format/git-cl

[clang] 865ee64 - [NFC] Add missing 'override's

Author: Logan Smith Date: 2020-07-20T19:52:49-07:00 New Revision: 865ee64bf80ca833548582476202ec8b70987341 URL: https://github.com/llvm/llvm-project/commit/865ee64bf80ca833548582476202ec8b70987341 DIFF: https://github.com/llvm/llvm-project/commit/865ee64bf80ca833548582476202ec8b70987341.diff L

[clang] fc24d1e - [clang][NFC] Add missing 'override's

Author: Logan Smith Date: 2020-07-20T16:43:24-07:00 New Revision: fc24d1eaddd8c0618e3ef3ab395029a0238d4568 URL: https://github.com/llvm/llvm-project/commit/fc24d1eaddd8c0618e3ef3ab395029a0238d4568 DIFF: https://github.com/llvm/llvm-project/commit/fc24d1eaddd8c0618e3ef3ab395029a0238d4568.diff L

[clang] a560910 - [Analyzer] Add checkRegionChanges for SmartPtrModeling

Author: Nithin Vadukkumchery Rajendrakumar Date: 2020-07-21T01:13:40+02:00 New Revision: a5609102117d2384fb73a14f37d24a0c844e3864 URL: https://github.com/llvm/llvm-project/commit/a5609102117d2384fb73a14f37d24a0c844e3864 DIFF: https://github.com/llvm/llvm-project/commit/a5609102117d2384fb73a14f3

Re: [clang-tools-extra] 9791416 - Silence a "logical operation on address of string constant" via CMake instead.

Should the warning be disabled for LLVM overall, rather than only for this subproject? (& be good tohave some details in the commit at least of why this warning is being disabled - how it is noisy/unhelpful/etc) On Sun, Jul 19, 2020 at 8:20 AM Aaron Ballman via cfe-commits wrote: > > > Author: Aa

[clang] 8b6179f - [NFC] Add missing 'override's

Author: Logan Smith Date: 2020-07-20T14:39:36-07:00 New Revision: 8b6179f48c6c6701447b68615fdd3b0345f241a4 URL: https://github.com/llvm/llvm-project/commit/8b6179f48c6c6701447b68615fdd3b0345f241a4 DIFF: https://github.com/llvm/llvm-project/commit/8b6179f48c6c6701447b68615fdd3b0345f241a4.diff L

[clang] bd994b8 - Revert "[libTooling] In Clang Transformer, change `Metadata` field to deferred evalutaion"

Author: Yitzhak Mandelbaum Date: 2020-07-20T21:24:58Z New Revision: bd994b81d376c7132b1155c31e99ce27a08f7ba3 URL: https://github.com/llvm/llvm-project/commit/bd994b81d376c7132b1155c31e99ce27a08f7ba3 DIFF: https://github.com/llvm/llvm-project/commit/bd994b81d376c7132b1155c31e99ce27a08f7ba3.diff

[clang] c0b8954 - [libTooling] In Clang Transformer, change `Metadata` field to deferred evalutaion

Author: Yitzhak Mandelbaum Date: 2020-07-20T21:17:09Z New Revision: c0b8954ecba500e3d9609152295b74ccd7d89d62 URL: https://github.com/llvm/llvm-project/commit/c0b8954ecba500e3d9609152295b74ccd7d89d62 DIFF: https://github.com/llvm/llvm-project/commit/c0b8954ecba500e3d9609152295b74ccd7d89d62.diff

[Differential] D83820: Change metadata to deferred evalutaion in Clang Transformer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc0b8954ecba5: [libTooling] In Clang Transformer, change `Metadata` field to deferred… (authored by ymandel). Repository: rG LLVM Github Monorepo

[Differential] D83407: [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3ff220de9009: [analyzer][StdLibraryFunctionsChecker] Add POSIX net

[clang] 3ff220d - [analyzer][StdLibraryFunctionsChecker] Add POSIX networking functions

Author: Gabor Marton Date: 2020-07-20T22:46:24+02:00 New Revision: 3ff220de900970a20c9882b7199c178c6b6428b2 URL: https://github.com/llvm/llvm-project/commit/3ff220de900970a20c9882b7199c178c6b6428b2 DIFF: https://github.com/llvm/llvm-project/commit/3ff220de900970a20c9882b7199c178c6b6428b2.diff

[clang] 52ab7aa - [clang-format] Add BitFieldColonSpacing option

Author: Anders Waldenborg Date: 2020-07-20T20:55:51+02:00 New Revision: 52ab7aa0ba5a3c7a0b2fe1b48519f1d4dc52cacf URL: https://github.com/llvm/llvm-project/commit/52ab7aa0ba5a3c7a0b2fe1b48519f1d4dc52cacf DIFF: https://github.com/llvm/llvm-project/commit/52ab7aa0ba5a3c7a0b2fe1b48519f1d4dc52cacf.d

[clang-tools-extra] c911803 - [clangd] Remove TokenBuffer usage in TypeHierarchy

Author: Aleksandr Platonov Date: 2020-07-20T21:00:49+02:00 New Revision: c911803d5df0f8a781b56849180b4b93a61306a7 URL: https://github.com/llvm/llvm-project/commit/c911803d5df0f8a781b56849180b4b93a61306a7 DIFF: https://github.com/llvm/llvm-project/commit/c911803d5df0f8a781b56849180b4b93a61306a7.

[Differential] D84090: Test revision5 (ignore)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG52ab7aa0ba5a: [clang-format] Add BitFieldColonSpacing option (authored by wanders). Herald added a project: clang. Herald

[PATCH] D83665: [OpenCL] Fixed missing address space for templated copy constructor

Anastasia added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3811 + if(S.getLangOpts().OpenCL) +ArgType = S.deduceOpenCLPointeeAddrSpace(ArgType); ArgType = S.Context.getLValueReferenceType(ArgType); olestrohm wrote: >

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access, or should I land this for you? Comment at: clang-tools-extra/clangd/URI.cpp:29 +bool isWindowsPath(llvm::StringRef Path) { + retur

[PATCH] D84185: Better defaults for MarshallingInfoString

Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84185/new/ https://reviews.llvm.org/D84185 _

[PATCH] D84189: Let denormalizer decide how to render the option based on the option class

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D84188 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84189 Files:

[PATCH] D84190: Port FrontendOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, aaron.ballman, dexonsmith. Herald added a project: clang. Depends on D84189 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84190 Files: clan

[PATCH] D84188: Port FileSystem options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84187 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84188 Files: clang/include/clang

[PATCH] D84187: Port DependencyOutput string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84186 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84187 Files: clang/include/clang

[PATCH] D84186: Convert Analyzer option string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, dexonsmith, a.sidorin, baloghadamsoftware. Herald added projects: clang, LLVM. Depends on D84185 Rep

[PATCH] D83398: [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

This revision was automatically updated to reflect the committed changes. Closed by commit rG2875df0d5657: [OPENMP50]Perform data mapping analysis only for explicitly mapped data. (authored by ABataev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D8

[clang] 2875df0 - [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

Author: Alexey Bataev Date: 2020-07-20T13:01:15-04:00 New Revision: 2875df0d56572168b478f80f59106284ef15d87d URL: https://github.com/llvm/llvm-project/commit/2875df0d56572168b478f80f59106284ef15d87d DIFF: https://github.com/llvm/llvm-project/commit/2875df0d56572168b478f80f59106284ef15d87d.diff

[Differential] D83398: [OPENMP50]Perform data mapping analysis only for explicitly mapped data.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2875df0d5657: [OPENMP50]Perform data mapping analysis only for explicitly mapped data. (authored by ABataev). Repository: rG LLVM Github Monorepo

[PATCH] D84185: Better defaults for MarshallingInfoString

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D84018 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84185 Files:

[PATCH] D83061: [OpenMP] Implement TR8 `present` map type modifier in Clang (1/2)

ABataev added inline comments. Comment at: clang/lib/Parse/ParseOpenMP.cpp:3067-3068 + unsigned Type = getOpenMPSimpleClauseType(OMPC_map, PP.getSpelling(Tok)); + if (Type < OMPC_MAP_MODIFIER_unknown) +return OMPC_MAP_MODIFIER_unknown; + return static_cast(Type); -

[PATCH] D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs

yln added inline comments. Comment at: clang/lib/Driver/ToolChains/Darwin.cpp:2734 - if (isTargetMacOS()) { -if (IsX86_64) - Res |= SanitizerKind::Thread; + if ((IsX86_64 || IsAArch64) && isTargetMacOS()) { +Res |= SanitizerKind::Thread; This bre

[PATCH] D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs

yln added a comment. Simulators on Apple Silicon are not yet supported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84082/new/ https://reviews.llvm.org/D84082 ___ cfe-commits mailing list cfe-commits

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

c-rhodes added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:1887 + +unsigned getSvePredWidth(const Type *T) { return getSveVectorWidth(T) / 8; } + aaron.ballman wrote: > Should this be dividing by the number of bits in a char for the target as > opp

[PATCH] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc5c84710a8: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path (authored by MaskRay). Changed prior to commit: https://reviews.llvm.org/D83015?vs=278555&id=279282#toc Repo

[Differential] D83015: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1bc5c84710a8: [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path (authored by MaskRay). Changed prior to commit: https

[clang] 1bc5c84 - [Driver] Add --ld-path= and deprecate -fuse-ld=/abs/path and -fuse-ld=rel/path

Author: Fangrui Song Date: 2020-07-20T09:34:39-07:00 New Revision: 1bc5c84710a8c73ef21295e63c19d10a8c71f2f5 URL: https://github.com/llvm/llvm-project/commit/1bc5c84710a8c73ef21295e63c19d10a8c71f2f5 DIFF: https://github.com/llvm/llvm-project/commit/1bc5c84710a8c73ef21295e63c19d10a8c71f2f5.diff

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

wanders added a comment. In D84090#2162389 , @MyDeveloperDay wrote: > 2. then I can do `git clang-format`, this will fix up any files in the diff > that need formatting (you'll need to git add them again if they have) (I use https://github.com/kimgr/gi

[PATCH] D83261: [OPENMP]Redesign of OMPExecutableDirective representation.

ABataev added a comment. In D83261#2161217 , @Meinersbur wrote: > AFAICS this extract out the handling of subnodes of OMPExecutableDirectives > into the OMPChildren class which is made optional since `OMPChildren > *OMPExecutableDirectives::Data` can be

[PATCH] D84090: [clang-format] Add BitFieldColonSpacing option

wanders updated this revision to Diff 279279. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84090/new/ https://reviews.llvm.org/D84090 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

ABataev created this revision. ABataev added reviewers: jdoerfert, ye-luo. Herald added subscribers: sstefan1, guansong, yaxunl. Herald added a project: clang. Need to avoid an optimization for base pointer mapping for target data directives. Repository: rG LLVM Github Monorepo https://review

[PATCH] D83494: [libFuzzer] Link libFuzzer's own interceptors when other compiler runtimes are not linked.

morehouse added inline comments. Comment at: compiler-rt/test/fuzzer/custom-allocator.test:2 +UNSUPPORTED: freebsd +RUN: %cpp_compiler -fno-sanitize=all -fno-builtin %S/CustomAllocator.cpp -fPIC %ld_flags_rpath_so1 -O0 -shared -o %dynamiclib1 +RUN: %cpp_compiler -fno-sanitize=ad

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko added a comment. In D84172#2162284 , @sammccall wrote: > Thanks for doing this! And sorry about the shaky windows support... > > (There are potentially other lurking issues due to filenames being used as > keys internally, particularly case

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

xazax.hun added a comment. In D82598#2162239 , @Szelethus wrote: > I chased my own tail for weeks before realizing that there is indeed another > instance when a live **statement** is stored, other then > `ObjCForCollectionStmt`... > > void clang_analy

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko marked 2 inline comments as done. ilya-golovenko added inline comments. Comment at: clang-tools-extra/clangd/URI.cpp:29 +bool isWindowsPath(llvm::StringRef Path) { + return Path.size() > 1 && llvm::isAlpha(Path[0]) && Path[1] == ':'; sammccall w

[PATCH] D84172: [clangd] Fix conversion from Windows UNC paths to file URI format.

ilya-golovenko updated this revision to Diff 279271. ilya-golovenko marked an inline comment as done. ilya-golovenko added a comment. Address code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84172/new/ https://reviews.llvm.org/D8

[PATCH] D83551: [PATCH 2/4][Sema][AArch64] Add semantics for arm_sve_vector_bits attribute

aaron.ballman added a comment. I like the way the code is shaping up with the slightly altered design, nice! Comment at: clang/lib/AST/ASTContext.cpp:1872 +unsigned getSveVectorWidth(const Type *T) { + // Get the vector size from the 'arm_sve_vector_bits' attribute via the -

[PATCH] D83553: [PATCH 3/4][Sema][AArch64] Add codegen for arm_sve_vector_bits attribute

c-rhodes marked an inline comment as done. c-rhodes added inline comments. Comment at: clang/lib/CodeGen/CodeGenTypes.h:138 + llvm::Type *ConvertTypeForMem(QualType T, bool ForBitField = false, +bool EnforceFixedLengthSVEAttribute = false);

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

ABataev added a comment. In D83922#2162444 , @jdenny wrote: > In D83922#2162365 , @ABataev wrote: > > > Looks like it breaks unified_shared_memory/close_enter_exit.c test. Could > > you check this, please? > > > It

[PATCH] D83922: [OpenMP] Fix map clause for unused var: don't ignore it

jdenny added a comment. In D83922#2162365 , @ABataev wrote: > Looks like it breaks unified_shared_memory/close_enter_exit.c test. Could you > check this, please? It doesn't fail for me, and I didn't receive a buildbot notification. Do you have a link?

  1   2   3   >