[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam marked an inline comment as done. saiislam added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:129 + auto *Alloca = Var.getPointer(); + assert(isa(Alloca) || + (isa(Alloca) && @arsenm , it wasn't possible to post D78495 and this

[PATCH] D84260: [OpenMP][AMDGCN] Support OpenMP offloading for AMDGCN architecture - Part 3

saiislam updated this revision to Diff 280660. saiislam added a comment. Added InitTempAlloca address space cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84260/new/ https://reviews.llvm.org/D84260 Files: clang/lib/CodeGen/CGExpr.cpp

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

rjmccall added inline comments. Comment at: clang/include/clang/CodeGen/CGFunctionInfo.h:52 +/// IndirectAliased - Similar to Indirect, but the pointer may not be +/// writable. +IndirectAliased, Hmm. I guess there's actually two different potential

[clang] 33d9c41 - [tsan] Allow TSan in the Clang driver for Apple Silicon Macs

Author: Kuba Mracek Date: 2020-07-24T20:14:00-07:00 New Revision: 33d9c4109ac234bcf17501ba16880ce80622cc9c URL: https://github.com/llvm/llvm-project/commit/33d9c4109ac234bcf17501ba16880ce80622cc9c DIFF: https://github.com/llvm/llvm-project/commit/33d9c4109ac234bcf17501ba16880ce80622cc9c.diff

[PATCH] D84082: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs

This revision was automatically updated to reflect the committed changes. Closed by commit rG33d9c4109ac2: [tsan] Allow TSan in the Clang driver for Apple Silicon Macs (authored by kubamracek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

dsanders updated this revision to Diff 280653. dsanders added a comment. Attempt to fix the windows-specific failure by using posix-style path::append() That feels wrong but it's consistent with a test in the same file that already passes because the path manipulation is an extension append

[PATCH] D84375: [git-clang-format] Add --diffstat parameter

aheejin added a comment. This looks fine to me, but I haven't worked on this part of code myself, so probably others who have can provide better review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84375/new/ https://reviews.llvm.org/D84375

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

aheejin accepted this revision. aheejin added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/WebAssembly/simd-widening.ll:113 + +;; Also test that similar patterns are still expanded correctly + It'd be clearer to

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

dsanders added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2037 +bool isGeneratingTemporaryObject = +ContainsCompileOrAssembleAction(Actions.back()) || LTOMode != LTOK_None; if ((enablesDebugInfo || willEmitRemarks(Args)) && beanz

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

dsanders added a comment. In D84565#2173770 , @dsanders wrote: > In D84565#2173744 , @beanz wrote: > > > @JDevlieghere you are right, I'm missing the change to how clang determines > > it needs to pass the linker

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

dsanders added a comment. In D84565#2173744 , @beanz wrote: > @JDevlieghere you are right, I'm missing the change to how clang determines > it needs to pass the linker the object file path. Update coming momentarily. Isn't that already based on

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz marked an inline comment as done. beanz added inline comments. Comment at: clang/lib/Driver/Driver.cpp:2037 +bool isGeneratingTemporaryObject = +ContainsCompileOrAssembleAction(Actions.back()) || LTOMode != LTOK_None; if ((enablesDebugInfo ||

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz updated this revision to Diff 280647. beanz added a comment. Updated to also pass the linker -object_path_lto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84565/new/ https://reviews.llvm.org/D84565 Files: clang/lib/Driver/Driver.cpp

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

dsanders added a comment. In D84565#2173615 , @JDevlieghere wrote: > When you don’t pass any specific options to the linker, it’s going to > generate a temporary `lto.o` file in `/tmp` and delete it after the link. > When `dsymutil` will try to read

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz added a comment. @JDevlieghere you are right, I'm missing the change to how clang determines it needs to pass the linker the object file path. Update coming momentarily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84565/new/

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz updated this revision to Diff 280641. beanz added a comment. Fixing bad test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84565/new/ https://reviews.llvm.org/D84565 Files: clang/lib/Driver/Driver.cpp

[PATCH] D84572: Allow .dSYM's to be directly placed in an alternate directory

dsanders created this revision. dsanders added reviewers: beanz, bogner. Herald added a reviewer: JDevlieghere. Herald added subscribers: cfe-commits, dang. Herald added a project: clang. Once available in the relevant toolchains this will allow us to implement

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rG74790a5dde9a: [PowerPC] Implement Truncate and Store VSX Vector Builtins (authored by amyk). Changed prior to commit: https://reviews.llvm.org/D82467?vs=276881=280634#toc Repository: rG LLVM Github

[clang] 74790a5 - [PowerPC] Implement Truncate and Store VSX Vector Builtins

Author: Amy Kwan Date: 2020-07-24T19:22:39-05:00 New Revision: 74790a5dde9ae01b7e96bea0b2596ef37b5325bd URL: https://github.com/llvm/llvm-project/commit/74790a5dde9ae01b7e96bea0b2596ef37b5325bd DIFF: https://github.com/llvm/llvm-project/commit/74790a5dde9ae01b7e96bea0b2596ef37b5325bd.diff

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. When you don’t pass any specific options to the linker, it’s going to generate a temporary `lto.o` file in `/tmp` and delete it after the link. When `dsymutil` will try

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

ABataev added a comment. In D84182#2173577 , @grokos wrote: > @ABataev: > > After this patch was committed, I tried to run the following example: > > #include > > int *yptr; > > int main() { > int y[10]; > y[1] = 1; > yptr = [0]; >

[PATCH] D84182: [OPENMP]Fix PR46012: declare target pointer cannot be accessed in target region.

grokos added a comment. @ABataev: After this patch was committed, I tried to run the following example: #include int *yptr; int main() { int y[10]; y[1] = 1; yptr = [0]; printf(" = %p\n", ); printf("[0] = %p\n", [0]); #pragma omp target data map(to:

[PATCH] D84565: [Darwin] [Driver] Clang should invoke dsymutil for lto builds -g*

beanz created this revision. beanz added reviewers: bogner, compnerd, aprantl, arphaman. Herald added subscribers: dexonsmith, inglorion. Herald added a reviewer: JDevlieghere. Herald added a project: clang. Clang should always add a dsymutil step whenever debug information is generated and the

[PATCH] D84564: [darwin] build and link with a separate compiler-rt builtins library for device simulators

arphaman created this revision. arphaman added reviewers: steven_wu, dexonsmith. Herald added subscribers: Sanitizers, ributzka, jkorous, kristof.beyls, mgorny, dberris. Herald added projects: clang, Sanitizers. This change separates out the iOS/tvOS/watchOS simulator slices from the

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added a comment. (Sorry this has been pending a while - I think it's basically there. Only things we really need to address to land this is have a consistent view of what the canonical decl is for the no-@interface case, and avoid too much duplication of mechanisms in the tests)

[PATCH] D83501: [clangd][ObjC] Improve xrefs for protocols and classes

sammccall added inline comments. Comment at: clang-tools-extra/clangd/FindTarget.cpp:360 + dyn_cast(D)) { + // Objective-C implementation should map back to its interface. + D = IID->getClassInterface(); This just describes what the

[PATCH] D82467: [PowerPC][Power10] Implement Truncate and Store VSX Vector Builtins

amyk added a comment. The `llvm/test/CodeGen/PowerPC/builtins-ppc-p10vsx.ll` file actually exists, and there is a BE RUN line in it. I realized I didn't rebase this diff to my previous patch that introduced it. Thus on the commit, I will append my tests to that file. Repository: rG LLVM

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny marked an inline comment as done. jdenny added a comment. In D84422#2173449 , @RaviNarayanaswamy wrote: > In D84422#2173372 , @jdenny wrote: > > > In D84422#2172898

[PATCH] D79744: clang: Use byref for aggregate kernel arguments

arsenm updated this revision to Diff 280607. arsenm added a comment. Use distinct ABIArgInfo::Kind. Also don't enable this for OpenCL yet, since that requires fixing the callable kernel workaround CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/remote/server/Server.cpp:73 private: + template you don't need both RequestT and ClangdRequest as template params: - the things you're currently doing are all available through

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

RaviNarayanaswamy added a comment. In D84422#2173372 , @jdenny wrote: > In D84422#2172898 , @jdenny wrote: > > > Has anyone clarified the motivation for this behavior? > > > I meant, is there any insight into why

[PATCH] D83914: [clangd] Plan features for FoldingRanges

kbobyrev planned changes to this revision. kbobyrev added a comment. Need to resolve the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83914/new/ https://reviews.llvm.org/D83914 ___

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280600. kbobyrev added a comment. Add missing Limit & Filter for fromProtobuf(RefsRequest *) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files:

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap added a comment. Addressed formatting comments Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14156 + + // This transformation is only valid if the we are loading either a byte, + // halfword, word, or doubleword. NeHuang wrote: > nit: if we

[PATCH] D82502: [PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend

Conanap updated this revision to Diff 280597. Conanap marked 2 inline comments as done. Conanap retitled this revision from "[PowerPC][Power10] Implement Load VSX Vector and Sign Extend and Zero Extend" to "[PowerPC] Implement Load VSX Vector and Sign Extend and Zero Extend". Conanap edited the

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

Conanap updated this revision to Diff 280592. Conanap removed a reviewer: power-llvm-team. Conanap added a comment. Herald added a subscriber: kbarton. Converted the impelmentation to an open coded implementation and updated the test cases as appropriate. Repository: rG LLVM Github Monorepo

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280593. kbobyrev added a comment. Remove unused Remote category. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bf4c1f4fb25: Reapply [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff. (authored by asbirlea). Changed prior to commit: https://reviews.llvm.org/D77341?vs=280326=280590#toc

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny added a comment. In D84422#2172898 , @jdenny wrote: > Has anyone clarified the motivation for this behavior? I meant, is there any insight into why the spec specifies this behavior? In D84422#2172926 ,

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea added a comment. Great, thank you for confirming :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77341/new/ https://reviews.llvm.org/D77341 ___ cfe-commits mailing list

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280589. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files:

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/Client.cpp:61 Callback(*Response); + ++Received; } kadircet wrote: > shouldn't we increment this before the `continue` above ? (or rename this to > `successful`

[PATCH] D84499: [clangd] Add more logs and attach tracers to remote index server routines

kbobyrev updated this revision to Diff 280587. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Resolve most review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84499/new/ https://reviews.llvm.org/D84499 Files:

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

nikic added a comment. Numbers for the newest version: https://llvm-compile-time-tracker.com/compare.php?from=183342c0a9850e60dd7a004b651c83dfb3a7d25e=eabcf534fe8760d14c95b40f07c61450c819d643=instructions This is now a geomean 0.2% regressions, and I don't see any large outliers for individual

[PATCH] D83814: [clangd] Add Random Forest runtime for code completion.

sammccall added a comment. In D83814#2166349 , @usaxena95 wrote: > This is still WIP and I will provide more details in the description once > this is finalized. This really should have high level documentation - I don't think Nathan will be the only

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

asbirlea added a comment. Yes. The difference in perf in instructions and cycles count is due to reversing the update order. I'm still not seeing meaningful changes in wall-time even with the update order reversed, but reliable wall-time testing is hard. I do have changes that - drop the

[PATCH] D84556: [WebAssembly] Remove intrinsics for SIMD widening ops

tlively created this revision. tlively added a reviewer: aheejin. Herald added subscribers: llvm-commits, cfe-commits, sunfish, hiraditya, jgravelle-google, sbc100, dschuff. Herald added projects: clang, LLVM. Instead, pattern match extends of extract_subvectors to generate widening operations.

[clang] 313b607 - Revert "Add Debug Info Size to Symbol Status"

Author: Walter Erquinigo Date: 2020-07-24T13:28:29-07:00 New Revision: 313b60742af1f567ef7d8e26eb5b1015a7b5c78f URL: https://github.com/llvm/llvm-project/commit/313b60742af1f567ef7d8e26eb5b1015a7b5c78f DIFF:

[PATCH] D83731: Add Debug Info Size to Symbol Status

This revision was automatically updated to reflect the committed changes. Closed by commit rG986e3af53bfe: Add Debug Info Size to Symbol Status (authored by aelitashen, committed by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 986e3af - Add Debug Info Size to Symbol Status

Author: Yifan Shen Date: 2020-07-24T13:26:06-07:00 New Revision: 986e3af53bfe591e88a1ae4f82ea1cc0a15819a3 URL: https://github.com/llvm/llvm-project/commit/986e3af53bfe591e88a1ae4f82ea1cc0a15819a3 DIFF: https://github.com/llvm/llvm-project/commit/986e3af53bfe591e88a1ae4f82ea1cc0a15819a3.diff

[PATCH] D84554: Use INTERFACE_COMPILE_OPTIONS to disable -Wsuggest-override for any target that links to gtest

logan-5 created this revision. logan-5 added a reviewer: labath. Herald added subscribers: llvm-commits, cfe-commits, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, stephenneuendorffer, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar,

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl updated this revision to Diff 280567. yaxunl marked 9 inline comments as done. yaxunl added a comment. revised by Artem's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60620/new/ https://reviews.llvm.org/D60620 Files:

[PATCH] D83972: Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

This revision was automatically updated to reflect the committed changes. Closed by commit rG0db2934b0fa9: [ASTImporter] Modify ImportDefiniton for ObjCInterfaceDecl so that we always… (authored by shafik). Herald added projects: clang, LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 0db2934 - [ASTImporter] Modify ImportDefiniton for ObjCInterfaceDecl so that we always the ImportDeclContext one we start the definition

Author: shafik Date: 2020-07-24T13:15:08-07:00 New Revision: 0db2934b0fa9e00ac98e2cb168adba96f6bcd0da URL: https://github.com/llvm/llvm-project/commit/0db2934b0fa9e00ac98e2cb168adba96f6bcd0da DIFF: https://github.com/llvm/llvm-project/commit/0db2934b0fa9e00ac98e2cb168adba96f6bcd0da.diff LOG:

[PATCH] D60620: [HIP] Support target id by --offload-arch

yaxunl marked 20 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Driver.h:332 + llvm::Triple getHIPOffloadTargetTriple() const; + tra wrote: > This is used exclusively by the Driver.cpp and does not have to be a

[PATCH] D77341: [DomTree] Replace ChildrenGetter with GraphTraits over GraphDiff.

dblaikie added a comment. In D77341#2171305 , @asbirlea wrote: > The increase in number of instructions and cycles was caused by reversing the > order in which the updates are applied by GraphDiff. > I'll look into re-adding some of the original

[PATCH] D84476: Make hip math headers easier to use from C

This revision was automatically updated to reflect the committed changes. Closed by commit rG679158e662aa: Make hip math headers easier to use from C (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84476/new/

[clang] 679158e - Make hip math headers easier to use from C

Author: Jon Chesterfield Date: 2020-07-24T20:50:46+01:00 New Revision: 679158e662aa247282b8eea4c2d60b33204171fb URL: https://github.com/llvm/llvm-project/commit/679158e662aa247282b8eea4c2d60b33204171fb DIFF:

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

Szelethus added a comment. In D82598#2172416 , @NoQ wrote: > I still wonder what made this statement live in my example. There must have > been some non-trivial liveness analysis going on that caused a statement to > be live; probably something to do

[clang] 032b78a - [analyzer] Revert the accidental commit of D82122

Author: Kirstóf Umann Date: 2020-07-24T21:33:18+02:00 New Revision: 032b78a0762bee129f33e4255ada6d374aa70c71 URL: https://github.com/llvm/llvm-project/commit/032b78a0762bee129f33e4255ada6d374aa70c71 DIFF: https://github.com/llvm/llvm-project/commit/032b78a0762bee129f33e4255ada6d374aa70c71.diff

[PATCH] D84476: Make hip math headers easier to use from C

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Comment at: clang/lib/Headers/__clang_hip_math.h:561 inline double abs(double __x) { return __ocml_fabs_f64(__x); } +#endif __DEVICE__

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

gribozavr2 added inline comments. Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:295 syntax::NestedNameSpecifier *qualifier(); - // TODO after expose `id-expression` from `DependentScopeDeclRefExpr`: // Add accessor for `template_opt`. + syntax::Leaf

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

grokos added a comment. So let's proceed with the patch. Instead of introducing new API functions and making all these changes in all these files, wouldn't it be easier if we just unset the `PRESENT` flag from arg_types in clang when we generate the call to `__tgt_target_data_end_*` if we are

[PATCH] D84422: [OpenMP] Fix `present` for exit from `omp target data`

jdenny added a comment. In D84422#2170702 , @RaviNarayanaswamy wrote: > In D84422#2170667 , @grokos wrote: > > > So is the test case that motivated this patch illegal OpenMP code? > > > > #pragma omp target

[PATCH] D69330: [AST] Add RecoveryExpr to retain expressions on semantic errors

erichkeane added a comment. Herald added a subscriber: dang. I wasn't able to add you to the bug report, but I discovered this: https://bugs.llvm.org/show_bug.cgi?id=46837 I'm still working on it, but if you have a suggestion, I'd appreciate it. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D84476: Make hip math headers easier to use from C

JonChesterfield marked 4 inline comments as done. JonChesterfield added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:561 inline double abs(double __x) { return __ocml_fabs_f64(__x); } +#endif __DEVICE__ yaxunl wrote: > jdoerfert wrote: > >

[PATCH] D84476: Make hip math headers easier to use from C

JonChesterfield updated this revision to Diff 280524. JonChesterfield added a comment. - Fix missing underscores Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84476/new/ https://reviews.llvm.org/D84476 Files:

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

jdoerfert added a comment. In D83268#2172748 , @protze.joachim wrote: > I carefully made sure, that the freshly built clang was used to execute the > test. I opened https://bugs.llvm.org/show_bug.cgi?id=46836 to track the issue > and made it release

[PATCH] D84476: Make hip math headers easier to use from C

yaxunl added inline comments. Comment at: clang/lib/Headers/__clang_hip_math.h:98 // BEGIN FLOAT +#ifdef _cplusplus __DEVICE__ typo ? Comment at: clang/lib/Headers/__clang_hip_math.h:558 // BEGIN DOUBLE +#ifdef _cplusplus __DEVICE__

[PATCH] D83592: [Coverage] Add comment to skipped regions

hans added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:973 + if ((LexLevel == 0 || PreprocessToken) && + !Result.getFlag(Token::IsReinjected)) { +if (LexLevel == 0) zequanwu wrote: > hans wrote: > > zequanwu wrote: > > > @hans , can you

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

protze.joachim reopened this revision. protze.joachim added a comment. This revision is now accepted and ready to land. I carefully made sure, that the freshly built clang was used to execute the test. I opened https://bugs.llvm.org/show_bug.cgi?id=46836 to track the issue and made it release

[PATCH] D84005: Introduce ns_error_domain attribute.

doug.gregor added a comment. In D84005#2171982 , @MForster wrote: > @milseman, @doug.gregor, could you please help with the open questions on > this review? > > Specifically: > > - Is `ns_error_domain` ever needed for something other than an enum? No,

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280511. eduucaldas added a comment. - Remove UnknownNameSpecifier, answer to comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/ https://reviews.llvm.org/D84348 Files:

[PATCH] D83268: [OpenMP][NFC] Remove unused (always fixed) arguments

protze.joachim added a comment. This patch breaks compilation of previously working code. I added the following to `openmp/libomptarget/test/offloading/offloading_success.c`: +// RUN: %libomptarget-compile-run-and-check-nvptx64-nvidia-cuda which results in # command stderr: ptxas

[PATCH] D83987: [libFuzzer] Disable implicit builtin knowledge about memcmp-like functions when -fsanitize=fuzzer-no-link is given.

dokyungs updated this revision to Diff 280507. dokyungs added a comment. Relanding this reverted commit. (See summary) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83987/new/ https://reviews.llvm.org/D83987 Files:

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu updated this revision to Diff 280504. zequanwu added a comment. Change `newSR.ColumnEnd = 1` to `newSR.ColumnEnd = SR.ColumnStart + 1` to ensure ColumnEnd >= ColumnStart. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83592/new/ https://reviews.llvm.org/D83592 Files:

[PATCH] D83592: [Coverage] Add comment to skipped regions

zequanwu marked an inline comment as done. zequanwu added inline comments. Comment at: clang/lib/Lex/Preprocessor.cpp:973 + if ((LexLevel == 0 || PreprocessToken) && + !Result.getFlag(Token::IsReinjected)) { +if (LexLevel == 0) hans wrote: > zequanwu

[PATCH] D83961: [Analyzer] Fix bug report source locations in minimal output.

NoQ added a comment. In D83961#2166903 , @balazske wrote: > Every other test failure comes from RetainCount checker except > //malloc-plist.c//. Aha, ok. So, anyway, for retain count checker we ultimately only care about plist and html reports, not

[PATCH] D84540: [CodeGen][ObjC] Mark calls to objc_unsafeClaimAutoreleasedReturnValue as notail on x86-64

ahatanak created this revision. ahatanak added reviewers: rjmccall, erik.pilkington. ahatanak added a project: clang. Herald added subscribers: ributzka, dexonsmith, jkorous. This is needed because the epilogue code inserted before tail calls on x86-64 breaks the handshake between the caller and

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

eduucaldas updated this revision to Diff 280497. eduucaldas added a comment. - Improve getLocalSourceRange - nested-name-specifier is now a ::-separated list of name-specifiers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84348/new/

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse updated this revision to Diff 280485. morehouse marked 5 inline comments as done. morehouse added a comment. - Rename flag - Clarify doc example - Use temporary variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84371/new/

[PATCH] D84371: [DFSan] Add efficient fast16labels instrumentation mode.

morehouse added inline comments. Comment at: compiler-rt/lib/dfsan/dfsan.cpp:180 dfsan_label __dfsan_union(dfsan_label l1, dfsan_label l2) { - if (flags().fast16labels) + if (fast16labels) return l1 | l2; vitalybuka wrote: > isn't better just create new

[PATCH] D84511: Fix update_cc_test_checks.py --llvm-bin after D78478

arichardson marked an inline comment as done. arichardson added inline comments. Comment at: clang/test/utils/update_cc_test_checks/lit.local.cfg:24 +# works as expected +config.substitutions.append( +('%update_cc_test_checks_llvm_bin', "%s %s %s" % (

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle updated this revision to Diff 280481. nhaehnle marked an inline comment as done. nhaehnle added a comment. v6: - implement predecessors/successors for all CfgTraits implementations - fix error in unwrapRange - rename toGeneric/fromGeneric into wrapRef/unwrapRef to have naming

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added a comment. In D84192#2172482 , @cchen wrote: > @ABataev, do I need to wait for the runtime patch to commit this one? If so, > do you have some recommend reviewers for me to add to that patch? I have > pinged several times for that patch

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, do I need to wait for the runtime patch to commit this one? If so, do you have some recommend reviewers for me to add to that patch? I have pinged several times for that patch but haven't got many reviews for it. Thanks! Repository: rG LLVM Github Monorepo

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192

[PATCH] D84535: [clangd] Switch from EXPECT_TRUE to ASSERT_TRUE in remote marshalling tests

kbobyrev created this revision. kbobyrev added a reviewer: kadircet. Herald added subscribers: cfe-commits, usaxena95, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. When dereferencing Optional's it makes sense to use ASSERT_TRUE for better test failures readability.

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev added inline comments. Comment at: clang-tools-extra/clangd/index/remote/marshalling/Marshalling.cpp:55 +template +llvm::Optional> getIDs(MessageT *Message) { + llvm::DenseSet Result; kadircet wrote: > I would make this return an expected instead of

[PATCH] D84348: WIP: Add complete id-expression support to syntax trees

gribozavr2 added a comment. What is this diff based on? On the left I see, for example, NamespaceNameSpecifier, which is not in the repository yet. Comment at: clang/lib/Tooling/Syntax/BuildTree.cpp:777 // FIXME: Support Microsoft's __super - return new

[PATCH] D84525: [clangd] Add marshalling code for all request types

kbobyrev updated this revision to Diff 280476. kbobyrev marked 4 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84525/new/ https://reviews.llvm.org/D84525 Files:

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen updated this revision to Diff 280474. cchen added a comment. Fix coding style and argument on getIntTypeForBitwidth Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 Files:

[PATCH] D83338: [PowerPC][Power10] Implemented Vector Shift Builtins

amyk added a comment. I realize it may be possible to open code these, as these functions already exist in altivec.h. Could you look into if this is the case? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83338/new/

[PATCH] D84197: [PowerPC][Power10] 128-bit Vector String Isolate instruction definitions and MC Tests

amyk requested changes to this revision. amyk added a comment. This revision now requires changes to proceed. Could you please add back the MC tests for the rightmost load/store instructions, and then add the vector string isolate tests to the end of the file? Repository: rG LLVM Github

[PATCH] D83955: [PowerPC][Power10] Implementation of 128-bit Binary Vector Multiply builtins

amyk accepted this revision as: amyk. amyk added a comment. I think this LGTM now. The file is already upstream, so your tests will need to be added to that file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83955/new/

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

ABataev added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8914 + ASTContext = CGF.getContext(); + QualType Int64Ty = C.getIntTypeForBitwidth(/*DestWidth=*/64, /*Signed=*/true); + RecordDecl *RD; 1. The second argument must be of

[PATCH] D82598: [analyzer][Liveness][NFC] Get rid of statement liveness, because such a thing doesn't exist

NoQ added a comment. I still wonder what made this statement live in my example. There must have been some non-trivial liveness analysis going on that caused a statement to be live; probably something to do with the C++ destructor elements. In D82598#2172371

[PATCH] D83088: Introduce CfgTraits abstraction

nhaehnle marked 3 inline comments as done. nhaehnle added inline comments. Comment at: llvm/include/llvm/CodeGen/MachineCfgTraits.h:44 +// use on a 32-bit architecture. +assert(wrapped != (uintptr_t)-1 && wrapped != (uintptr_t)-2); + arsenm wrote: > I

[PATCH] D84192: [OpenMP5.0] map item can be non-contiguous for target update

cchen added a comment. @ABataev, is there any other concern for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84192/new/ https://reviews.llvm.org/D84192 ___ cfe-commits mailing list

[PATCH] D84534: [AIX] Static init frontend recovery and backend support

Xiangling_L created this revision. Xiangling_L added reviewers: jasonliu, hubert.reinterpretcast, yusra.syeda, zarko, xingxue. Xiangling_L added a project: LLVM. Herald added subscribers: llvm-commits, cfe-commits, jfb, kbarton, hiraditya, nemanjai. Herald added a project: clang. 1. Frontend

  1   2   >